Vadim Zeitlin [Mon, 7 May 2012 13:12:23 +0000 (13:12 +0000)]
Use XkbKeycodeToKeysym() instead of deprecated XKeycodeToKeysym().
XKeycodeToKeysym() is deprecated in new X11 headers because it doesn't work
correctly with all symbols (https://bugs.freedesktop.org/show_bug.cgi?id=5349).
Use XkbKeycodeToKeysym() instead, this should help with some keys and also
avoids deprecation warnings during compilation.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71373
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 7 May 2012 13:12:20 +0000 (13:12 +0000)]
Create a wrapper file for X11/XKBlib.h header.
We need some hacks for the older systems before including this header, extract
them from src/x11/utilsx.cpp into a new private header to be able to reuse it
from wxGTK in the next commit.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71372
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 7 May 2012 12:23:09 +0000 (12:23 +0000)]
Make wxDocTemplate::CreateDocument() exceptions-safe.
Don't create the document object if InitDocument() throws.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71371
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 7 May 2012 11:15:31 +0000 (11:15 +0000)]
Fix performance of wxHtmlParser::SkipCommentTag() in UTF-8 build.
Avoid computing the difference between two potentially distant
iterators, which is O(1) in wchar_t build, but O(n) in UTF-8 one.
See #13445.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71370
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Sun, 6 May 2012 16:56:38 +0000 (16:56 +0000)]
Fix r71367: don't set bgCol twice needlessly.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71368
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Sun, 6 May 2012 13:10:34 +0000 (13:10 +0000)]
Fix wxOwnerDrawnComboBox background on with classic theme.
In wxMSW, if the classic theme was used, read-only wxOwnerDrawnComboBox
had gray background, but native look should be the same for both
editable and read-only combo boxes: white text entry-like rectangle.
Apparently, a similar problem existed with non-classic themes too
before, as there was a workaround in place. Fixed by moving the
workaround into code used by both themed and classic rendering.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71367
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 5 May 2012 14:09:59 +0000 (14:09 +0000)]
No changes, just spelling corrections in the comments.
Closes #14275.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71366
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 5 May 2012 11:22:09 +0000 (11:22 +0000)]
Update the field widths on demand in wxStatusBarGeneric.
This ensures that the value returned from GetFieldRect() is always up to date,
even when this method is called from the user-defined wxEVT_SIZE handler, i.e.
before our own OnSize() could run.
Also remove the now unneeded hack with calling the base class OnSize() from
the statbar sample.
Closes #14268.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71365
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sat, 5 May 2012 05:32:19 +0000 (05:32 +0000)]
fixes crashes with embedded controls in toolbars after toolbar destruction, code was moved in r62988, but apparently Destroy doesn't have to be called, so do a last check, fixes #14258
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71364
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 22:20:59 +0000 (22:20 +0000)]
Don't return NULL widget from wxFileCtrl page of widgets sample.
This makes all the common operations such as setting tooltip, colours &c on
this page simply crash.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71363
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 22:20:55 +0000 (22:20 +0000)]
Derive wxGenericFileCtrl from wxControl.
wxFileCtrl -- which can be #define'd as wxGenericFileCtrl -- is documented to
inherit from wxControl and does derive from it in the native GTK version, so
do it for the generic version too.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71362
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:52 +0000 (20:35 +0000)]
Improve documentation of wxDataViewCtrl mouse event handling.
Explain that catching mouse events directly doesn't work.
Also make it clear that double clicking an item can be caught by processing
wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED.
See #14111.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71361
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:48 +0000 (20:35 +0000)]
Fix precompiled headers use with MSVC in wxGTK sources.
Don't use PCH for C sources, do include wx/wxprec.h from all wxGTK C++
sources.
Closes #14224.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71360
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:44 +0000 (20:35 +0000)]
Declare variables before doing anything else in C code.
Don't put statements before variable declaration in C source file. This fixes
compilation with non C99-compliant C compilers such as MSVC.
See #14224.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71359
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:41 +0000 (20:35 +0000)]
Allow using non-MSW toolkit in MSVC-specific auto-linking header.
This makes it possible to auto-link wxGTK library when using MSVC too.
Closes #14272.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71358
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:37 +0000 (20:35 +0000)]
Define wxCONCATn() macro up to n=9 from n=5 previously.
We'll need it for n=6 for the next commit, so increase the max value of n a
bit more.
See #14272.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71357
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:33 +0000 (20:35 +0000)]
Use GTK-based wxWebView when using GTK+, not under Unix.
Test for the GTK+ toolkit, not Unix platform to determine whether GTK+
wxWebView version should be used.
Closes #14273.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71356
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:31 +0000 (20:35 +0000)]
Add wxDir::GetNameWithSep() and use it to avoid consecutive slashes.
It is wrong to use dir.GetName()+"/" to obtain a slash-terminated directory
name as this results in (usually harmless but at best ugly) double slashes at
at the beginning of the string for the root directory. Add GetNameWithSep() to
obtain the correct result in all cases.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71355
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 20:35:26 +0000 (20:35 +0000)]
Document wxTP_DEFAULT as a standalone constant.
Make sure the declarations in the documentation header can be really parsed.
Closes #14270.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71354
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 4 May 2012 18:31:48 +0000 (18:31 +0000)]
Don't remove the last slash from "/" directory name under Unix.
This was totally wrong as it returned empty string as (invalid) directory
name.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71353
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Thu, 3 May 2012 23:30:40 +0000 (23:30 +0000)]
Add wxDropSource::SetIcon for wxGTK to mimic SetCursor on the other ports.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71349
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Thu, 3 May 2012 23:30:33 +0000 (23:30 +0000)]
* Change "def" to defResult as def is a reserved word in Python
* Correct some methods that were marked pure virtual but which aren't.
* etc.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71348
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Thu, 3 May 2012 23:30:27 +0000 (23:30 +0000)]
fix incorrect default values
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71347
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 3 May 2012 10:17:19 +0000 (10:17 +0000)]
Document wxDataViewChoiceByIndexRenderer.
At least briefly document this class too and not only its parent
wxDataViewChoiceRenderer one.
Closes #14265.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71346
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 3 May 2012 10:17:15 +0000 (10:17 +0000)]
No changes, just remove duplicate flags checks in wxUniv wxTLW.
For some reason (rename of the old wxTHICK_FRAME to wxRESIZE_BORDER?) we
tested for wxRESIZE_BORDER twice in a couple of places. Don't do it for
clarity.
Closes #14264.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71345
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 2 May 2012 19:38:58 +0000 (19:38 +0000)]
use explicit WakeUp variant, too many errors using heuristics, fixes #14176
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71344
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 2 May 2012 19:30:11 +0000 (19:30 +0000)]
make WakeUp variant explicit, too many errors using heuristics, like #14176
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71343
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 2 May 2012 18:44:23 +0000 (18:44 +0000)]
fixes #14178
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71342
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Dimitri Schoolwerth [Wed, 2 May 2012 14:44:45 +0000 (14:44 +0000)]
Fixed parts of toolbar background not being drawn with older comctl32.dll.
When using comctl32.dll versions older than 6.0 toolbar icons would not have their background drawn. Fix this in a rough way by always completely erasing the background like was done before. Regression since r62971.
Closes #13512.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71341
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 2 May 2012 10:37:36 +0000 (10:37 +0000)]
German translations update from Thomas Krebs.
Closes #14262.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71340
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 30 Apr 2012 14:51:52 +0000 (14:51 +0000)]
Fix destruction of wxDataViewCtrl's editor control.
Don't pop event handler from the control more than once.
See r70002 and r70005 (which this reverts) for reference.
Fixes #14215.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71336
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 30 Apr 2012 09:33:30 +0000 (09:33 +0000)]
wxDataViewCtrl: always update the header when col best width changes.
Have an explicit per-column dirty flag and use that to determine whether
we need to call wxHeaderCtrl::UpdateColumn(). Previously, the lack of
computed best width was used as an indicator, but this didn't work
correctly if some code called GetWidth() after invalidation but before
wxDataViewCtrl::UpdateColWidths() was called at idle time. This resulted
in header's column widths getting out of sync with the control itself.
Fixes #14167.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71335
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 30 Apr 2012 09:33:25 +0000 (09:33 +0000)]
Invalidate wxDataViewCtrl bests widths on expand/collapse.
The best column widths are computed from "realized" items that are
available as rows in wxDataViewCtrl. This information changes when a
previously collapsed node is expanded and new items become available for
column width calculation.
Fixes #14167.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71334
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 30 Apr 2012 09:33:21 +0000 (09:33 +0000)]
Respect minimal width in wxDataViewCtrl::GetBestColumnWidth().
See #14167.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71333
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:48:20 +0000 (23:48 +0000)]
Work around the problem with not exiting event loop under MSW.
Changes of r71304 broke the event loop termination under MSW, limit them to
only the case in which they were really needed, i.e. when loop is really
exited by a pending event handler.
This is only a temporary solution, we need something better in longer term.
See #14250.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71329
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:34 +0000 (23:22 +0000)]
No changes, just refactor common IsSorted() tests in wxGTK wxDataViewCtrl.
Add wxDataViewCtrlInternal::ShouldBeSorted() helper instead of testing for
both IsSorted() and wxDataViewModel::HasDefaultCompare() in several places.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71327
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:32 +0000 (23:22 +0000)]
No real changes, just make wxDataViewCtrlInternal::IsSorted() const.
This is a simple accessor, should have been const since the beginning.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71326
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:28 +0000 (23:22 +0000)]
Use PCH in the tests in all Windows ports and not only when using wxMSW.
This change doesn't actually change anything for the "normal" ports as it only
affects wxGTK/MSW which is not officially supported yet, so the make/project
files are unchanged by it.
Closes #14249.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71325
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:25 +0000 (23:22 +0000)]
Added wxDataViewEvent::SetDragFlags() and GetDropEffect() methods.
Allow specifying the drag operation flags and retrieving the drop effect when
it's over for wxDataViewCtrl drag-and-drop.
Currently this is only implemented in the generic version.
Closes #12583.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71324
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:21 +0000 (23:22 +0000)]
Set the data size in wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE in wxGTK.
Allow wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE handler to examine the data
being dragged by setting not only the pointer to it but also its size, as
otherwise it's impossible to do anything with it.
See #12583.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71323
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:18 +0000 (23:22 +0000)]
Explicitly document wxDrag_XXX flags.
They were mentioned in DoDragDrop() documentation but not documented on their
own. Do it now to be able to refer to them from elsewhere.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71322
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:16 +0000 (23:22 +0000)]
Remove internal only methods from wxDataViewEvent documentation.
SetDataXXX() methods are only meant to be used by wxDataViewCtrl itself, so
don't document them as part of public API. Their documentation was pretty
useless anyhow as it didn't say anything not already contained in the method
name.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71321
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:13 +0000 (23:22 +0000)]
Restore 2.8 stock labels for wxID_PREVIEW inadvertently changed in 2.9.
The wxID_PREVIEW labels were accidentally removed in r68641 and added back
with a wrong/different label later. Restore the same one (or almost, just add
an ellipsis at the end) that was used in 2.8.
Closes #13906.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71320
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:10 +0000 (23:22 +0000)]
Add a hack to prevent the test suite from aborting after Grid test case.
There is a problem with the native header control still having the mouse
capture when the grid is destroyed in wxGTK and this resulted in asserts when
destroying the grid, nested asserts due to an exception being thrown from a
dtor and finally abort that prevented the rest of the tests from running.
As I failed to find the real reason for this problem, just forcefully ensure
that we don't have the mouse capture when destroying the grid. This at least
allows the complete test suite to run.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71319
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:08 +0000 (23:22 +0000)]
Improve error reporting for nested asserts failures in the test suite.
If an assert occurred while handling an exception generated by a previous
assert handler, the information about the original assert was lost even if
though it was more important than the secondary assert. Do preserve and show
the original assert message in this case now.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71318
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:05 +0000 (23:22 +0000)]
Work around wxDateTime::ParseFormat() problem in generic wxDateTimePickerCtrl.
Due to a bug in wxDateTime::ParseFormat(), calling it with wxString::c_str()
currently just crashes, so don't do this in generic wxDateTimePickerCtrl code.
The real fix is, of course, to correct the bug in wxDateTime itself but for
now this at least prevents the crash when executing the test suite. And using
c_str() here is unnecessary anyhow.
See #14214.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71317
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:01 +0000 (23:22 +0000)]
Preserve wxComboBox selection when modifying the selected item in wxGTK too.
This does the same thing as r70018 did for wxMSW but for wxGTK, i.e. it keeps
the combo box item selected when its text is modified.
This fixes [Bitmap]ComboBox unit tests under wxGTK.
See #13769.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71316
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 29 Apr 2012 23:21:57 +0000 (23:21 +0000)]
Enable wxComboBox::SetString() test in the widgets sample.
It was disabled because it wasn't implemented for wxGTK at some time in the
past -- but it is implemented now, so there is no reason to not allow testing
it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71315
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Sun, 29 Apr 2012 09:36:44 +0000 (09:36 +0000)]
Don't use ancient -no-cpp-precomp flag on OS X.
See http://trac.wxwidgets.org/ticket/14029 for a discussion of the
problems it causes when using non-Apple compiler. Even for Apple's GCC,
it does nothing these days and we no longer support OS X 10.3, so
there's no point in continuing to use it.
Fixes #14029.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71314
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:26 +0000 (22:25 +0000)]
Make wxGTK code returning correct focus in popup menu presence more robust.
Replace the changes of r69938 with an alternative and simpler solution:
instead of playing games with gs_pendingFocus, which could break down if its
old value became invalid while the menu was shown as happened if one of the
menu commands resulted in this window being destroyed, just take the currently
shown popup menu into account in DoFindFocus() itself.
This should be safer as there is no danger of any dangling pointers here and
is also simpler and more obviously correct.
Closes #14103.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71313
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:23 +0000 (22:25 +0000)]
Add missing "flags" argument to wxNotificationMessage ctor in wxMSW.
It was impossible to specify the flags when creating wxNotificationMessage in
wxMSW, cotrary to the other ports and the documentation.
Fix this by adding the missing argument to the ctor and simply passing it to
the base class one, we don't have to do anything else as the existing code
already calls GetFlags() later so it should respect these flags without any
more changes.
Closes #14245.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71312
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:19 +0000 (22:25 +0000)]
Fix crash in wxFileConfig when deleting last entry of the root group.
This resulted in keeping a dangling pointer to the group line in
wxFileConfigGroup and any attempt to use it after this resulted in a crash.
Fix this by explicitly resetting the last line in this case.
Also add a unit test for this scenario.
Closes #14243.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71311
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:15 +0000 (22:25 +0000)]
Make it possible to forward declare wx{Choice,Tool,Tree}bookEvent again.
Don't use typedef for these classes as it makes it impossible to
forward-declare them, just use #define instead as we already do for
wxListbookEvent and wxNotebookEvent. This allows forward declaration and is
also more consistent.
Closes #12242.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71310
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:07 +0000 (22:25 +0000)]
Use generic wxAboutBox() in wxUniv/GTK.
The native GTK implementation is not used in wxUniv/GTK, so don't exclude the
generic one as well.
Notice that the same should be done for wxMSW and wxOSX too but we currently
seem to use the native version even in wxUniv there. It would be better to
consistently use the generic version in all wxUniv ports.
Closes #14236.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71309
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:03 +0000 (22:25 +0000)]
Don't change wxTextEntry value if it didn't really change.
This is not only unnecessary but also can result in a kind of infinite loop
when wxTextEntry::SetValue() is called from wxEVT_IDLE handler as really
modifying the text results in another wxEVT_IDLE being generated and another
call to SetValue() and so on while not doing it in the first place completely
works around the problem and is also more efficient.
Closes #13936.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71308
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:01 +0000 (22:25 +0000)]
Run some wxTextCtrl unit test cases for single and multi-line controls.
Some of the tests that were previously ran for single or multi-line controls
only actually apply to both of them, so run them for both kinds of control to
test that both of them work correctly.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71307
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:59 +0000 (22:24 +0000)]
No changes, just refactor wxTextCtrl unit test case.
Allow running the same tests for both single and multi-line controls easily.
No real changes yet though, the tests are still ran for the controls with the
same styles as before for now.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71306
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:57 +0000 (22:24 +0000)]
Recognize wxDefaultDateTime in gdb wxDateTime pretty-printer.
Trying to print an uninitialized/invalid wxDateTime in gdb resulted in an
error (Python exception from datetime module), recognize it specially now.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71305
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:54 +0000 (22:24 +0000)]
Don't block in wxEventLoopManual::Dispatch() if loop was exited.
If Exit() was called from a handler for one of the pending events we could
reenter Dispatch() and block there indefinitely if no other events were coming
and this was exactly what happened in wxFileSystemWatcher unit test,
preventing it from ever running to completion under Unix.
Fix this by checking m_shouldExit after executing the pending handlers and
before calling Dispatch().
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71304
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:52 +0000 (22:24 +0000)]
Add a gdb pretty-printer for wxFileName objects.
This pretty-printer works by calling the C++ wxFileName::GetFullPath()
directly instead of interpreting the object data from gdb because this is much
simpler to do, so it can only be used when debugging live programs. If this is
a serious restriction, it would need to be changed to use gdb data access only
later.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71303
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:50 +0000 (22:24 +0000)]
Fix harmless warnings about hiding base class virtual in dialogs sample.
GetTitle() added in r71213 resulted in virtual function warnings from g++, fix
them by renaming it to GetBoxTitle().
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71302
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:47 +0000 (22:24 +0000)]
Don't use too big width for wxHtmlHelpWindow navigation panel.
The width of the navigation panel in wxHtmlHelpWindow could become arbitrarily
high if long items used. Avoid this by using a reasonably large but not too
big minimal width instead of determining it automatically from the items width.
Closes #13754.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71301
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:43 +0000 (22:24 +0000)]
Fix erasing wxHtmlWindow background in wxUniv.
Prevent the default wxWindow-level wxEVT_ERASE_BACKGROUND handler from being
used in wxUniv for wxHtmlWindow. This is unnecessary as it has its own handler
anyhow and also doesn't work for some reason as erasing wxMemoryDC by drawing
a solid rectangle over it seems to be broken in at least wxX11.
Work around this problem by erasing the background in wxHtmlWindow itself if
no user-defined (as opposed to any, including one defined in wxWindow itself)
handler for this event exists.
Closes #13880.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71300
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:40 +0000 (22:24 +0000)]
Handle kCGImageAlphaNoneSkipFirst correctly in wxOSX wxBitmap code.
The code tested twice for kCGImageAlphaNoneSkipLast which was clearly wrong.
The original intention was probably to check for both it and
kCGImageAlphaNoneSkipFirst, so fix it to this now.
Closes #14019.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71299
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:36 +0000 (22:24 +0000)]
Fix wxBitmapButton best size calculation in wxOSX/Carbon.
wxAnyButton refactoring broke the best size computation for Carbon, fix it to
work as it did before.
Closes #13830.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71298
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:34 +0000 (22:24 +0000)]
Document the change in wxEVT_SIZE generation for wxDialogs in wxMSW.
These events are now generated earlier and can result in crashes if the
controls they use are not initialized yet.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71297
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:31 +0000 (22:24 +0000)]
Document that wxDCClipper currently resets clipping region.
Unlike other similar classes, this one doesn't restore the previous clipping
region but just resets it because there is no way to get the current clipping
region from wxDC now. At least document this limitation until it can be fixed.
See #13834.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71296
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 27 Apr 2012 22:35:08 +0000 (22:35 +0000)]
Added note about WXWIN_COMPATIBILITY_2_6 being off in 2.9 by default.
Also list some concrete symbols which are not available any more and their
replacements.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71289
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Fri, 27 Apr 2012 11:39:52 +0000 (11:39 +0000)]
Restored the exact-fit-button horizontal margin calculation from 2.8 since it was too cramped.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71287
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Thu, 26 Apr 2012 01:29:00 +0000 (01:29 +0000)]
Typo fix, and add some missing methods.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71280
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Wed, 25 Apr 2012 11:42:31 +0000 (11:42 +0000)]
Fixed floating image layout when typing in subsequent paragraph
Now makes use of max size for images and keeps the image size reasonable
Added original image size so can usually avoid reloading image when recomputing
cached bitmap size
Takes into account bottom of the last floating image so scrollbars are
set correctly
Original image size is shown in disabled size controls
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71277
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Tue, 24 Apr 2012 11:22:18 +0000 (11:22 +0000)]
Added custom properties to style definitions and style sheets
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71276
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Tue, 24 Apr 2012 05:38:12 +0000 (05:38 +0000)]
Remove code to find topmost X window in SetTransparent().
The purpose of this code is unknown, but it may be intended to make WM
decorations transparent. But it causes a crash when docking an AUI panel.
And in my testing the decorations are transparent even without this code.
Fixes #4841
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71275
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Mon, 23 Apr 2012 16:54:52 +0000 (16:54 +0000)]
Added flags to SetStyle with specific object
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71268
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Sat, 21 Apr 2012 00:07:31 +0000 (00:07 +0000)]
Fix missing and broken interface items for Phoenix
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71247
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Fri, 20 Apr 2012 16:05:13 +0000 (16:05 +0000)]
defer queue-resize until after size-allocate processing, to keep it from being ignored by GTK3
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71246
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Fri, 20 Apr 2012 15:34:24 +0000 (15:34 +0000)]
silence warning about wxOSX_USE_COCOA not being defined
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71245
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Fri, 20 Apr 2012 05:41:54 +0000 (05:41 +0000)]
Make wxTaskBarIcon's ctor have the same API on all platforms even though setting the icon type can only be done on wxOSX-cocoa
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71242
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Fri, 20 Apr 2012 05:41:39 +0000 (05:41 +0000)]
Document SetDoubleBuffered
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71241
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Thu, 19 Apr 2012 17:15:40 +0000 (17:15 +0000)]
move widget resize handling from DoSetSize to DoMoveWindow
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71240
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Thu, 19 Apr 2012 16:51:06 +0000 (16:51 +0000)]
simplify default border code in DoSetSize
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71237
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Thu, 19 Apr 2012 16:44:59 +0000 (16:44 +0000)]
rearrange some code in DoSetSize to facilitate upcoming changes
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71236
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Apr 2012 16:14:18 +0000 (16:14 +0000)]
Fix for wxUniv/GTK compilation.
wxWindowBase needs to be explicitly cast to wxWindow in wxUniv/GTK build but
this wasn't done in the changes of r70597.
Cloes #14235.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71235
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Apr 2012 16:14:16 +0000 (16:14 +0000)]
Correct wxPaintDC base class in the documentation.
wxPaintDC derives from wxClientDC, not wxWindowDC.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71234
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Wed, 18 Apr 2012 16:30:11 +0000 (16:30 +0000)]
Adjust x,y parameters by pizza scroll offset in DoSetSize
This should cause no change in behavior, and is merely preparation for further changes
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71228
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Apr 2012 09:23:05 +0000 (09:23 +0000)]
Don't set focus to hidden window in wxSetFocusToChild().
The window that had focus previously could be hidden now, but its parent could
be hidden as well so it's not enough to set focus to it but we need to loop
until we find a visible ancestor.
Closes #14230.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71227
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Tue, 17 Apr 2012 17:00:36 +0000 (17:00 +0000)]
Fix missing and broken interface items for Phoenix
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71215
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Tue, 17 Apr 2012 16:57:12 +0000 (16:57 +0000)]
avoiding potential mismatch between true and expected state of wxGraphicsContext because it might have been changed through its direct API meanwhile, fixes #14226
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71214
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 17 Apr 2012 13:57:18 +0000 (13:57 +0000)]
Add possibility to change the test message box title in dialog sample.
All the other message box elements were configurable, so why not this one.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71213
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Tue, 17 Apr 2012 06:13:16 +0000 (06:13 +0000)]
building on 10.5
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71212
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Mon, 16 Apr 2012 15:45:52 +0000 (15:45 +0000)]
remove AdjustForParentClientOrigin call, it does nothing in wxGTK
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71211
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 14:33:35 +0000 (14:33 +0000)]
Reset hover item when mouse leaves wxAuiToolBar.
The hover item was not reset properly in some circumstances, do it now.
Also check for the item being disabled in SetHoverItem() itself instead of
doing it several times before calling it.
Closes #14189.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71210
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 14:30:02 +0000 (14:30 +0000)]
Fix wxCairoContext creation from wxWindow under MSW.
cairo_win32_surface_create() must be passed the window HDC and not HWND
itself, the old code calling it was broken.
Add WindowHDC object and pass its HDC to this function now to make it work.
Closes #14194.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71209
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 14:29:59 +0000 (14:29 +0000)]
Add default ctor to wxMSW private WindowHDC helper class.
Allow to use objects of this class without any valid HWND, this is useful for
the derived classes which may, or may not, need the corresponding HDC.
See #14194.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71208
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 14:19:13 +0000 (14:19 +0000)]
Fix type mismatch in wxLogTrace() call in wxSocket.
Cast socket handle to a 32 bit value as we use it with "%d" (or "%u" now as it
makes more sense) format specifier to avoid problems with type mismatches
under Win64.
Closes #14204.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71207
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 13:53:49 +0000 (13:53 +0000)]
Add wxFSInputStream providing stream interface to wxFileSystem.
This class allows using virtual wxFSFiles with any wx functions taking
streams. E.g. it makes it possible to load images and animations from
wxFileSystem.
Closes #14185.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71206
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 13:53:45 +0000 (13:53 +0000)]
Added wxWrapperInputStream class.
This stream allows to wrap another stream. This is a useful base class for
adapter classes providing stream interface on top of something else, like the
upcoming wxFSInputStream.
See #14185.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71205
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 12:12:26 +0000 (12:12 +0000)]
Added support for page tooltips to wxAuiNotebook.
Allow setting tooltips for the tabs of the individual pages of wxAuiNotebook.
Closes #14216.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71204
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 12:12:19 +0000 (12:12 +0000)]
Added wxAcceleratorEntry::ToRawString().
This function can be used to obtain language/locale-independent representation
of an accelerator. This is particularly useful for storing it in configuration
files.
Closes #14228.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71203
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 16 Apr 2012 12:12:15 +0000 (12:12 +0000)]
No real changes, just some typo fixes for previous commits.
Fix wxCOMPtr comment and don't use "s_" for non-static variable.
Closes #14227.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71202
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775