Added many WXUNUSED, untabified once again.

[wxWidgets.git] / src / unix / utilsunx.cpp

diff --git a/src/unix/utilsunx.cpp b/src/unix/utilsunx.cpp
index ea6fd78a5f9a93964dd767487637e01eb9e666e1..fb8c58bc9022092d6faa86f42c20a2c9caf3a4b6 100644 (file)
--- a/src/unix/utilsunx.cpp
+++ b/src/unix/utilsunx.cpp
@@ -23,8 +23,13 @@
 
 #include "wx/utils.h"
 #include "wx/process.h"
 
 #include "wx/utils.h"
 #include "wx/process.h"

+#include "wx/thread.h"

 
 

-#include "wx/unix/execute.h"
+#include "wx/stream.h"
+
+#if wxUSE_GUI
+    #include "wx/unix/execute.h"
+#endif

 
 #include <stdarg.h>
 #include <dirent.h>
 
 #include <stdarg.h>
 #include <dirent.h>


@@ -40,11 +45,9 @@
 #include <fcntl.h>          // for O_WRONLY and friends
 #include <time.h>           // nanosleep() and/or usleep()
 #include <ctype.h>          // isspace()
 #include <fcntl.h>          // for O_WRONLY and friends
 #include <time.h>           // nanosleep() and/or usleep()
 #include <ctype.h>          // isspace()

+#include <sys/time.h>       // needed for FD_SETSIZE

 
 

-// JACS: needed for FD_SETSIZE
-#include <sys/time.h>
-
-#if HAVE_UNAME
+#ifdef HAVE_UNAME

     #include <sys/utsname.h> // for uname()
 #endif // HAVE_UNAME
 
     #include <sys/utsname.h> // for uname()
 #endif // HAVE_UNAME
 


@@ -64,21 +67,22 @@
         #ifdef __SUN__
             int usleep(unsigned int usec);
         #else // !Sun
         #ifdef __SUN__
             int usleep(unsigned int usec);
         #else // !Sun

-            void usleep(unsigned long usec);
-        #endif // Sun/!Sun
+            #ifdef __EMX__
+                /* I copied this from the XFree86 diffs. AV. */
+                #define INCL_DOSPROCESS
+                #include <os2.h>
+                inline void usleep(unsigned long delay)
+                {
+                    DosSleep(delay ? (delay/1000l) : 1l);
+                }
+            #else // !Sun && !EMX
+                void usleep(unsigned long usec);
+            #endif
+        #endif // Sun/EMX/Something else

     };
     };

-#endif // Unices without usleep()

 
 

-#ifdef __EMX__
-  /* I copied this from the XFree86 diffs. AV. */
-//extern void DosSleep(unsigned long);
-#define INCL_DOSPROCESS
-#include <os2.h>
-void usleep(unsigned long delay)
-{
-    DosSleep(delay ? (delay/1000l) : 1l);
-}
-#endif
+    #define HAVE_USLEEP 1
+#endif // Unices without usleep()

 
 // ============================================================================
 // implementation
 
 // ============================================================================
 // implementation


@@ -95,14 +99,14 @@ void wxSleep(int nSecs)
 
 void wxUsleep(unsigned long milliseconds)
 {
 
 void wxUsleep(unsigned long milliseconds)
 {

-#if HAVE_NANOSLEEP
+#if defined(HAVE_NANOSLEEP)

     timespec tmReq;
     timespec tmReq;

-    tmReq.tv_sec = milliseconds / 1000;
+    tmReq.tv_sec = (time_t)(milliseconds / 1000);

     tmReq.tv_nsec = (milliseconds % 1000) * 1000 * 1000;
 
     // we're not interested in remaining time nor in return value
     (void)nanosleep(&tmReq, (timespec *)NULL);
     tmReq.tv_nsec = (milliseconds % 1000) * 1000 * 1000;
 
     // we're not interested in remaining time nor in return value
     (void)nanosleep(&tmReq, (timespec *)NULL);

-#elif HAVE_USLEEP
+#elif defined(HAVE_USLEEP)

     // uncomment this if you feel brave or if you are sure that your version
     // of Solaris has a safe usleep() function but please notice that usleep()
     // is known to lead to crashes in MT programs in Solaris 2.[67] and is not
     // uncomment this if you feel brave or if you are sure that your version
     // of Solaris has a safe usleep() function but please notice that usleep()
     // is known to lead to crashes in MT programs in Solaris 2.[67] and is not


@@ -112,6 +116,9 @@ void wxUsleep(unsigned long milliseconds)
     #endif // Sun
 
     usleep(milliseconds * 1000); // usleep(3) wants microseconds
     #endif // Sun
 
     usleep(milliseconds * 1000); // usleep(3) wants microseconds

+#elif defined(HAVE_SLEEP)
+    // under BeOS sleep() takes seconds (what about other platforms, if any?)
+    sleep(milliseconds * 1000);

 #else // !sleep function
     #error "usleep() or nanosleep() function required for wxUsleep"
 #endif // sleep function
 #else // !sleep function
     #error "usleep() or nanosleep() function required for wxUsleep"
 #endif // sleep function


@@ -123,38 +130,38 @@ void wxUsleep(unsigned long milliseconds)
 
 int wxKill(long pid, wxSignal sig)
 {
 
 int wxKill(long pid, wxSignal sig)
 {

-    return kill(pid, (int)sig);
+    return kill((pid_t)pid, (int)sig);

 }
 
 #define WXEXECUTE_NARGS   127
 
 long wxExecute( const wxString& command, bool sync, wxProcess *process )
 {
 }
 
 #define WXEXECUTE_NARGS   127
 
 long wxExecute( const wxString& command, bool sync, wxProcess *process )
 {

-    wxCHECK_MSG( !command.IsEmpty(), 0, _T("can't exec empty command") );
+    wxCHECK_MSG( !command.IsEmpty(), 0, wxT("can't exec empty command") );

 
     int argc = 0;
     wxChar *argv[WXEXECUTE_NARGS];
     wxString argument;
     const wxChar *cptr = command.c_str();
 
     int argc = 0;
     wxChar *argv[WXEXECUTE_NARGS];
     wxString argument;
     const wxChar *cptr = command.c_str();

-    wxChar quotechar = _T('\0'); // is arg quoted?
+    wxChar quotechar = wxT('\0'); // is arg quoted?

     bool escaped = FALSE;
 
     // split the command line in arguments
     do
     {
     bool escaped = FALSE;
 
     // split the command line in arguments
     do
     {

-        argument=_T("");
-        quotechar = _T('\0');
+        argument=wxT("");
+        quotechar = wxT('\0');

 
         // eat leading whitespace:
         while ( wxIsspace(*cptr) )
             cptr++;
 
 
         // eat leading whitespace:
         while ( wxIsspace(*cptr) )
             cptr++;
 

-        if ( *cptr == _T('\'') || *cptr == _T('"') )
+        if ( *cptr == wxT('\'') || *cptr == wxT('"') )

             quotechar = *cptr++;
 
         do
         {
             quotechar = *cptr++;
 
         do
         {

-            if ( *cptr == _T('\\') && ! escaped )
+            if ( *cptr == wxT('\\') && ! escaped )

             {
                 escaped = TRUE;
                 cptr++;
             {
                 escaped = TRUE;
                 cptr++;


@@ -167,11 +174,11 @@ long wxExecute( const wxString& command, bool sync, wxProcess *process )
 
             // have we reached the end of the argument?
             if ( (*cptr == quotechar && ! escaped)
 
             // have we reached the end of the argument?
             if ( (*cptr == quotechar && ! escaped)

-                 || (quotechar == _T('\0') && wxIsspace(*cptr))
-                 || *cptr == _T('\0') )
+                 || (quotechar == wxT('\0') && wxIsspace(*cptr))
+                 || *cptr == wxT('\0') )

             {
                 wxASSERT_MSG( argc < WXEXECUTE_NARGS,
             {
                 wxASSERT_MSG( argc < WXEXECUTE_NARGS,

-                              _T("too many arguments in wxExecute") );
+                              wxT("too many arguments in wxExecute") );

 
                 argv[argc] = new wxChar[argument.length() + 1];
                 wxStrcpy(argv[argc], argument.c_str());
 
                 argv[argc] = new wxChar[argument.length() + 1];
                 wxStrcpy(argv[argc], argument.c_str());


@@ -198,17 +205,41 @@ long wxExecute( const wxString& command, bool sync, wxProcess *process )
     return lRc;
 }
 
     return lRc;
 }
 

-bool wxShell(const wxString& command)
+// ----------------------------------------------------------------------------
+// wxShell
+// ----------------------------------------------------------------------------
+
+static wxString wxMakeShellCommand(const wxString& command)

 {
     wxString cmd;
 {
     wxString cmd;

-    if ( !!command )
-        cmd.Printf(_T("xterm -e %s"), command.c_str());
+    if ( !command )
+    {
+        // just an interactive shell
+        cmd = _T("xterm");
+    }

     else
     else

-        cmd = command;
+    {
+        // execute command in a shell
+        cmd << _T("/bin/sh -c '") << command << _T('\'');
+    }
+
+    return cmd;
+}

 
 

-    return wxExecute(cmd) != 0;
+bool wxShell(const wxString& command)
+{
+    return wxExecute(wxMakeShellCommand(command), TRUE /* sync */) == 0;

 }
 
 }
 

+bool wxShell(const wxString& command, wxArrayString& output)
+{
+    wxCHECK_MSG( !!command, FALSE, _T("can't exec shell non interactively") );
+
+    return wxExecute(wxMakeShellCommand(command), output);
+}
+
+#if wxUSE_GUI
+

 void wxHandleProcessTermination(wxEndProcessData *proc_data)
 {
     int pid = (proc_data->pid > 0) ? proc_data->pid : -(proc_data->pid);
 void wxHandleProcessTermination(wxEndProcessData *proc_data)
 {
     int pid = (proc_data->pid > 0) ? proc_data->pid : -(proc_data->pid);


@@ -217,9 +248,24 @@ void wxHandleProcessTermination(wxEndProcessData *proc_data)
     // systems wait() might be used instead in a loop (until the right pid
     // terminates)
     int status = 0;
     // systems wait() might be used instead in a loop (until the right pid
     // terminates)
     int status = 0;

-    if ( waitpid(pid, &status, 0) == -1 || !WIFEXITED(status) )
+    int rc;
+
+    // wait for child termination and if waitpid() was interrupted, try again
+    do
+    {
+       rc = waitpid(pid, &status, 0);
+    }
+    while ( rc == -1 && errno == EINTR );
+
+
+    if( rc == -1 || ! (WIFEXITED(status) || WIFSIGNALED(status)) )

     {
     {

-        wxLogSysError(_("Waiting for subprocess termination failed"));
+       wxLogSysError(_("Waiting for subprocess termination failed"));
+       /* AFAIK, this can only happen if something went wrong within
+          wxGTK, i.e. due to a race condition or some serious bug.
+          After having fixed the order of statements in
+          GTK_EndProcessDetector(). (KB)
+       */

     }
     else
     {
     }
     else
     {


@@ -229,126 +275,297 @@ void wxHandleProcessTermination(wxEndProcessData *proc_data)
             proc_data->process->OnTerminate(proc_data->pid,
                                             WEXITSTATUS(status));
         }
             proc_data->process->OnTerminate(proc_data->pid,
                                             WEXITSTATUS(status));
         }

+        // clean up
+        if ( proc_data->pid > 0 )
+        {
+           delete proc_data;
+        }
+        else
+        {
+           // wxExecute() will know about it
+           proc_data->exitcode = status;
+
+           proc_data->pid = 0;
+        }

     }
     }

+}

 
 

-    // clean up
-    if ( proc_data->pid > 0 )
+#endif // wxUSE_GUI
+
+// ----------------------------------------------------------------------------
+// wxStream classes to support IO redirection in wxExecute
+// ----------------------------------------------------------------------------
+
+class wxProcessFileInputStream : public wxInputStream
+{
+public:
+    wxProcessFileInputStream(int fd) { m_fd = fd; }
+    ~wxProcessFileInputStream() { close(m_fd); }
+
+    virtual bool Eof() const;
+
+protected:
+    size_t OnSysRead(void *buffer, size_t bufsize);
+
+protected:
+    int m_fd;
+};
+
+class wxProcessFileOutputStream : public wxOutputStream
+{
+public:
+    wxProcessFileOutputStream(int fd) { m_fd = fd; }
+    ~wxProcessFileOutputStream() { close(m_fd); }
+
+protected:
+    size_t OnSysWrite(const void *buffer, size_t bufsize);
+
+protected:
+    int m_fd;
+};
+
+bool wxProcessFileInputStream::Eof() const
+{
+    if ( m_lasterror == wxSTREAM_EOF )
+        return TRUE;
+
+    // check if there is any input available
+    struct timeval tv;
+    tv.tv_sec = 0;
+    tv.tv_usec = 0;
+
+    fd_set readfds;
+    FD_ZERO(&readfds);
+    FD_SET(m_fd, &readfds);
+    switch ( select(m_fd + 1, &readfds, NULL, NULL, &tv) )

     {
     {

-        delete proc_data;
+        case -1:
+            wxLogSysError(_("Impossible to get child process input"));
+            // fall through
+
+        case 0:
+            return TRUE;
+
+        default:
+            wxFAIL_MSG(_T("unexpected select() return value"));
+            // still fall through
+
+        case 1:
+            // input available: check if there is any
+            return wxInputStream::Eof();
+    }
+}
+
+size_t wxProcessFileInputStream::OnSysRead(void *buffer, size_t bufsize)
+{
+    int ret = read(m_fd, buffer, bufsize);
+    if ( ret == 0 )
+    {
+        m_lasterror = wxSTREAM_EOF;
+    }
+    else if ( ret == -1 )
+    {
+        m_lasterror = wxSTREAM_READ_ERROR;
+        ret = 0;

     }
     else
     {
     }
     else
     {

-        // wxExecute() will know about it
-        proc_data->exitcode = status;
+        m_lasterror = wxSTREAM_NOERROR;
+    }

 
 

-        proc_data->pid = 0;
+    return ret;
+}
+
+size_t wxProcessFileOutputStream::OnSysWrite(const void *buffer, size_t bufsize)
+{
+    int ret = write(m_fd, buffer, bufsize);
+    if ( ret == -1 )
+    {
+        m_lasterror = wxSTREAM_WRITE_ERROR;
+        ret = 0;

     }
     }

+    else
+    {
+        m_lasterror = wxSTREAM_NOERROR;
+    }
+
+    return ret;

 }
 
 }
 

-long wxExecute( wxChar **argv, bool sync, wxProcess *process )
+long wxExecute(wxChar **argv,
+               bool sync,
+               wxProcess *process)

 {
 {

-    wxCHECK_MSG( *argv, 0, _T("can't exec empty command") );
+    wxCHECK_MSG( *argv, 0, wxT("can't exec empty command") );

 
 

-    int end_proc_detect[2];

 #if wxUSE_UNICODE
     int mb_argc = 0;
     char *mb_argv[WXEXECUTE_NARGS];
 
 #if wxUSE_UNICODE
     int mb_argc = 0;
     char *mb_argv[WXEXECUTE_NARGS];
 

-    while (argv[mb_argc]) {
-      wxWX2MBbuf mb_arg = wxConvCurrent->cWX2MB(argv[mb_argc]);
-      mb_argv[mb_argc] = strdup(mb_arg);
-      mb_argc++;
+    while (argv[mb_argc])
+    {
+        wxWX2MBbuf mb_arg = wxConvertWX2MB(argv[mb_argc]);
+        mb_argv[mb_argc] = strdup(mb_arg);
+        mb_argc++;

     }
     mb_argv[mb_argc] = (char *) NULL;
     }
     mb_argv[mb_argc] = (char *) NULL;

-#else
+
+    // this macro will free memory we used above
+    #define ARGS_CLEANUP                                 \
+        for ( mb_argc = 0; mb_argv[mb_argc]; mb_argc++ ) \
+            free(mb_argv[mb_argc])
+#else // ANSI
+    // no need for cleanup
+    #define ARGS_CLEANUP
+

     wxChar **mb_argv = argv;
     wxChar **mb_argv = argv;

-#endif
+#endif // Unicode/ANSI

 
 

+#if wxUSE_GUI

     // create pipes
     // create pipes

-    if (pipe(end_proc_detect) == -1)
+    int end_proc_detect[2];
+    if ( pipe(end_proc_detect) == -1 )

     {
         wxLogSysError( _("Pipe creation failed") );
     {
         wxLogSysError( _("Pipe creation failed") );

-#if wxUSE_UNICODE
-       mb_argc = 0;
-       while (mb_argv[mb_argc])
-         free(mb_argv[mb_argc++]);
-#endif
+        wxLogError( _("Failed to execute '%s'\n"), *argv );
+
+        ARGS_CLEANUP;
+

         return 0;
     }
         return 0;
     }

+#endif // wxUSE_GUI
+
+    int pipeIn[2];
+    int pipeOut[2];
+    pipeIn[0] = pipeIn[1] =
+    pipeOut[0] = pipeOut[1] = -1;
+
+    if ( process && process->IsRedirected() )
+    {
+        if ( pipe(pipeIn) == -1 || pipe(pipeOut) == -1 )
+        {
+#if wxUSE_GUI
+            // free previously allocated resources
+            close(end_proc_detect[0]);
+            close(end_proc_detect[1]);
+#endif // wxUSE_GUI
+
+            wxLogSysError( _("Pipe creation failed") );
+            wxLogError( _("Failed to execute '%s'\n"), *argv );
+
+            ARGS_CLEANUP;
+
+            return 0;
+        }
+    }

 
     // fork the process
 
     // fork the process

-#if HAVE_VFORK
+#ifdef HAVE_VFORK

     pid_t pid = vfork();
 #else
     pid_t pid = fork();
 #endif
     pid_t pid = vfork();
 #else
     pid_t pid = fork();
 #endif

-    if (pid == -1)
+
+    if ( pid == -1 )     // error?

     {
     {

+#if wxUSE_GUI
+        close(end_proc_detect[0]);
+        close(end_proc_detect[1]);
+        close(pipeIn[0]);
+        close(pipeIn[1]);
+        close(pipeOut[0]);
+        close(pipeOut[1]);
+#endif // wxUSE_GUI
+

         wxLogSysError( _("Fork failed") );
         wxLogSysError( _("Fork failed") );

-#if wxUSE_UNICODE
-       mb_argc = 0;
-       while (mb_argv[mb_argc])
-         free(mb_argv[mb_argc++]);
-#endif
+
+        ARGS_CLEANUP;
+

         return 0;
     }
         return 0;
     }

-    else if (pid == 0)
+    else if ( pid == 0 )  // we're in child

     {
     {

-        // we're in child
+#if wxUSE_GUI

         close(end_proc_detect[0]); // close reading side
         close(end_proc_detect[0]); // close reading side

+#endif // wxUSE_GUI

 
 

-        // These three lines close the open file descriptors to to avoid any
+        // These lines close the open file descriptors to to avoid any

         // input/output which might block the process or irritate the user. If
         // input/output which might block the process or irritate the user. If

-        // one wants proper IO for the subprocess, the right thing to do is
-        // to start an xterm executing it.
-        if (sync == 0)
+        // one wants proper IO for the subprocess, the right thing to do is to
+        // start an xterm executing it.
+        if ( !sync )

         {
         {

-            // leave stderr opened, it won't do any hurm

             for ( int fd = 0; fd < FD_SETSIZE; fd++ )
             {
             for ( int fd = 0; fd < FD_SETSIZE; fd++ )
             {

-                if ( fd != end_proc_detect[1] && fd != STDERR_FILENO )
+                if ( fd == pipeIn[0] || fd == pipeOut[1]
+#if wxUSE_GUI
+                     || fd == end_proc_detect[1]
+#endif // wxUSE_GUI
+                   )
+                {
+                    // don't close this one, we still need it
+                    continue;
+                }
+
+                // leave stderr opened too, it won't do any hurm
+                if ( fd != STDERR_FILENO )

                     close(fd);
             }
         }
 
                     close(fd);
             }
         }
 

-#if 0
-        close(STDERR_FILENO);
+        // redirect stdio and stdout
+        // (TODO: what about stderr?)
+        if ( pipeIn[0] != -1 )
+        {
+            if ( dup2(pipeIn[0], STDIN_FILENO) == -1 ||
+                 dup2(pipeOut[1], STDOUT_FILENO) == -1 )
+            {
+                wxLogSysError(_("Failed to redirect child process "
+                                "input/output"));
+            }

 
 

-        // some programs complain about stderr not being open, so redirect
-        // them:
-        open("/dev/null", O_RDONLY);  // stdin
-        open("/dev/null", O_WRONLY);  // stdout
-        open("/dev/null", O_WRONLY);  // stderr
-#endif
+            close(pipeIn[0]);
+            close(pipeOut[1]);
+        }

 
         execvp (*mb_argv, mb_argv);
 
         // there is no return after successful exec()
 
         execvp (*mb_argv, mb_argv);
 
         // there is no return after successful exec()

-        wxFprintf(stderr, _("Can't execute '%s'\n"), *argv);
-

         _exit(-1);
     }
         _exit(-1);
     }

-    else
+    else // we're in parent

     {
     {

-        // we're in parent
-        close(end_proc_detect[1]); // close writing side
+        ARGS_CLEANUP;

 
 

-        wxEndProcessData *data = new wxEndProcessData;
-        data->tag = wxAddProcessCallback(data, end_proc_detect[0]);
+        // pipe initialization: construction of the wxStreams
+        if ( process && process->IsRedirected() )
+        {
+            // These two streams are relative to this process.
+            wxOutputStream *outStream = new wxProcessFileOutputStream(pipeIn[1]);
+            wxInputStream *inStream = new wxProcessFileInputStream(pipeOut[0]);
+            close(pipeIn[0]); // close reading side
+            close(pipeOut[1]); // close writing side

 
 

-#if wxUSE_UNICODE
-       mb_argc = 0;
-       while (mb_argv[mb_argc])
-         free(mb_argv[mb_argc++]);
-#endif
+            process->SetPipeStreams(inStream, outStream);
+        }
+
+#if wxUSE_GUI
+        wxEndProcessData *data = new wxEndProcessData;

 
         if ( sync )
         {
 
         if ( sync )
         {

-            wxASSERT_MSG( !process, _T("wxProcess param ignored for sync exec") );
+            // we may have process for capturing the program output, but it's
+            // not used in wxEndProcessData in the case of sync execution

             data->process = NULL;
 
             // sync execution: indicate it by negating the pid
             data->pid = -pid;
             data->process = NULL;
 
             // sync execution: indicate it by negating the pid
             data->pid = -pid;

+            data->tag = wxAddProcessCallback(data, end_proc_detect[0]);
+
+            close(end_proc_detect[1]); // close writing side
+
+            wxBusyCursor bc;
+            wxWindowDisabler wd;

 
             // it will be set to 0 from GTK_EndProcessDetector
             while (data->pid != 0)
 
             // it will be set to 0 from GTK_EndProcessDetector
             while (data->pid != 0)


@@ -360,17 +577,35 @@ long wxExecute( wxChar **argv, bool sync, wxProcess *process )
 
             return exitcode;
         }
 
             return exitcode;
         }

-        else
+        else // async execution

         {
             // async execution, nothing special to do - caller will be
         {
             // async execution, nothing special to do - caller will be

-            // notified about the process terminationif process != NULL, data
+            // notified about the process termination if process != NULL, data

             // will be deleted in GTK_EndProcessDetector
             // will be deleted in GTK_EndProcessDetector

-            data->process = process;
-            data->pid = pid;
+            data->process  = process;
+            data->pid      = pid;
+            data->tag      = wxAddProcessCallback(data, end_proc_detect[0]);
+
+            close(end_proc_detect[1]); // close writing side

 
             return pid;
         }
 
             return pid;
         }

+#else // !wxUSE_GUI
+        wxASSERT_MSG( sync, wxT("async execution not supported yet") );
+
+        int exitcode = 0;
+        if ( waitpid(pid, &exitcode, 0) == -1 || !WIFEXITED(exitcode) )
+        {
+            wxLogSysError(_("Waiting for subprocess termination failed"));
+        }
+
+        return exitcode;
+#endif // wxUSE_GUI

     }
     }

+
+    return 0;
+
+    #undef ARGS_CLEANUP

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -381,14 +616,14 @@ const wxChar* wxGetHomeDir( wxString *home  )
 {
     *home = wxGetUserHome( wxString() );
     if ( home->IsEmpty() )
 {
     *home = wxGetUserHome( wxString() );
     if ( home->IsEmpty() )

-        *home = _T("/");
+        *home = wxT("/");

 
     return home->c_str();
 }
 
 #if wxUSE_UNICODE
 const wxMB2WXbuf wxGetUserHome( const wxString &user )
 
     return home->c_str();
 }
 
 #if wxUSE_UNICODE
 const wxMB2WXbuf wxGetUserHome( const wxString &user )

-#else // just for binary compatibility
+#else // just for binary compatibility -- there is no 'const' here

 char *wxGetUserHome( const wxString &user )
 #endif
 {
 char *wxGetUserHome( const wxString &user )
 #endif
 {


@@ -396,15 +631,15 @@ char *wxGetUserHome( const wxString &user )
 
     if ( !user )
     {
 
     if ( !user )
     {

-        register wxChar *ptr;
+        wxChar *ptr;

 
 

-        if ((ptr = wxGetenv(_T("HOME"))) != NULL)
+        if ((ptr = wxGetenv(wxT("HOME"))) != NULL)

         {
             return ptr;
         }
         {
             return ptr;
         }

-        if ((ptr = wxGetenv(_T("USER"))) != NULL || (ptr = wxGetenv(_T("LOGNAME"))) != NULL)
+        if ((ptr = wxGetenv(wxT("USER"))) != NULL || (ptr = wxGetenv(wxT("LOGNAME"))) != NULL)

         {
         {

-            who = getpwnam(wxConvCurrent->cWX2MB(ptr));
+            who = getpwnam(wxConvertWX2MB(ptr));

         }
 
         // We now make sure the the user exists!
         }
 
         // We now make sure the the user exists!


@@ -418,11 +653,7 @@ char *wxGetUserHome( const wxString &user )
       who = getpwnam (user.mb_str());
     }
 
       who = getpwnam (user.mb_str());
     }
 

-#if wxUSE_UNICODE
-    return who ? wxConvCurrent->cMB2WX(who->pw_dir) : (wxMB2WXbuf)((wxChar*)NULL);
-#else
-    return who ? who->pw_dir : ((char*)NULL);
-#endif
+    return wxConvertMB2WX(who ? who->pw_dir : 0);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -434,9 +665,9 @@ char *wxGetUserHome( const wxString &user )
 // private use only)
 static bool wxGetHostNameInternal(wxChar *buf, int sz)
 {
 // private use only)
 static bool wxGetHostNameInternal(wxChar *buf, int sz)
 {

-    wxCHECK_MSG( buf, FALSE, _T("NULL pointer in wxGetHostNameInternal") );
+    wxCHECK_MSG( buf, FALSE, wxT("NULL pointer in wxGetHostNameInternal") );

 
 

-    *buf = _T('\0');
+    *buf = wxT('\0');

 
     // we're using uname() which is POSIX instead of less standard sysinfo()
 #if defined(HAVE_UNAME)
 
     // we're using uname() which is POSIX instead of less standard sysinfo()
 #if defined(HAVE_UNAME)


@@ -444,13 +675,13 @@ static bool wxGetHostNameInternal(wxChar *buf, int sz)
     bool ok = uname(&uts) != -1;
     if ( ok )
     {
     bool ok = uname(&uts) != -1;
     if ( ok )
     {

-        wxStrncpy(buf, wxConvCurrent->cMB2WX(uts.nodename), sz - 1);
-        buf[sz] = _T('\0');
+        wxStrncpy(buf, wxConvertMB2WX(uts.nodename), sz - 1);
+        buf[sz] = wxT('\0');

     }
 #elif defined(HAVE_GETHOSTNAME)
     bool ok = gethostname(buf, sz) != -1;
 #else // no uname, no gethostname
     }
 #elif defined(HAVE_GETHOSTNAME)
     bool ok = gethostname(buf, sz) != -1;
 #else // no uname, no gethostname

-    wxFAIL_MSG(_T("don't know host name for this machine"));
+    wxFAIL_MSG(wxT("don't know host name for this machine"));

 
     bool ok = FALSE;
 #endif // uname/gethostname
 
     bool ok = FALSE;
 #endif // uname/gethostname


@@ -471,11 +702,11 @@ bool wxGetHostName(wxChar *buf, int sz)
     {
         // BSD systems return the FQDN, we only want the hostname, so extract
         // it (we consider that dots are domain separators)
     {
         // BSD systems return the FQDN, we only want the hostname, so extract
         // it (we consider that dots are domain separators)

-        wxChar *dot = wxStrchr(buf, _T('.'));
+        wxChar *dot = wxStrchr(buf, wxT('.'));

         if ( dot )
         {
             // nuke it
         if ( dot )
         {
             // nuke it

-            *dot = _T('\0');
+            *dot = wxT('\0');

         }
     }
 
         }
     }
 


@@ -488,9 +719,9 @@ bool wxGetFullHostName(wxChar *buf, int sz)
 
     if ( ok )
     {
 
     if ( ok )
     {

-        if ( !wxStrchr(buf, _T('.')) )
+        if ( !wxStrchr(buf, wxT('.')) )

         {
         {

-            struct hostent *host = gethostbyname(wxConvCurrent->cWX2MB(buf));
+            struct hostent *host = gethostbyname(wxConvertWX2MB(buf));

             if ( !host )
             {
                 wxLogSysError(_("Cannot get the official hostname"));
             if ( !host )
             {
                 wxLogSysError(_("Cannot get the official hostname"));


@@ -500,7 +731,7 @@ bool wxGetFullHostName(wxChar *buf, int sz)
             else
             {
                 // the canonical name
             else
             {
                 // the canonical name

-                wxStrncpy(buf, wxConvCurrent->cMB2WX(host->h_name), sz);
+                wxStrncpy(buf, wxConvertMB2WX(host->h_name), sz);

             }
         }
         //else: it's already a FQDN (BSD behaves this way)
             }
         }
         //else: it's already a FQDN (BSD behaves this way)


@@ -513,10 +744,10 @@ bool wxGetUserId(wxChar *buf, int sz)
 {
     struct passwd *who;
 
 {
     struct passwd *who;
 

-    *buf = _T('\0');
+    *buf = wxT('\0');

     if ((who = getpwuid(getuid ())) != NULL)
     {
     if ((who = getpwuid(getuid ())) != NULL)
     {

-        wxStrncpy (buf, wxConvCurrent->cMB2WX(who->pw_name), sz - 1);
+        wxStrncpy (buf, wxConvertMB2WX(who->pw_name), sz - 1);

         return TRUE;
     }
 
         return TRUE;
     }
 


@@ -526,20 +757,34 @@ bool wxGetUserId(wxChar *buf, int sz)
 bool wxGetUserName(wxChar *buf, int sz)
 {
     struct passwd *who;
 bool wxGetUserName(wxChar *buf, int sz)
 {
     struct passwd *who;

-    char *comma;

 
 

-    *buf = _T('\0');
-    if ((who = getpwuid (getuid ())) != NULL) {
-       comma = strchr(who->pw_gecos, ',');
+    *buf = wxT('\0');
+    if ((who = getpwuid (getuid ())) != NULL)
+    {
+        // pw_gecos field in struct passwd is not standard
+#if HAVE_PW_GECOS
+       char *comma = strchr(who->pw_gecos, ',');

        if (comma)
            *comma = '\0'; // cut off non-name comment fields
        if (comma)
            *comma = '\0'; // cut off non-name comment fields

-       wxStrncpy (buf, wxConvCurrent->cMB2WX(who->pw_gecos), sz - 1);
+       wxStrncpy (buf, wxConvertMB2WX(who->pw_gecos), sz - 1);
+#else // !HAVE_PW_GECOS
+       wxStrncpy (buf, wxConvertMB2WX(who->pw_name), sz - 1);
+#endif // HAVE_PW_GECOS/!HAVE_PW_GECOS

        return TRUE;
     }
 
     return FALSE;
 }
 
        return TRUE;
     }
 
     return FALSE;
 }
 

+wxString wxGetOsDescription()
+{
+#ifndef WXWIN_OS_DESCRIPTION
+    #error WXWIN_OS_DESCRIPTION should be defined in config.h by configure
+#else
+    return WXWIN_OS_DESCRIPTION;
+#endif
+}
+

 // ----------------------------------------------------------------------------
 // error and debug output routines (deprecated, use wxLog)
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // error and debug output routines (deprecated, use wxLog)
 // ----------------------------------------------------------------------------


@@ -556,16 +801,17 @@ void wxDebugMsg( const char *format, ... )
 void wxError( const wxString &msg, const wxString &title )
 {
   wxFprintf( stderr, _("Error ") );
 void wxError( const wxString &msg, const wxString &title )
 {
   wxFprintf( stderr, _("Error ") );

-  if (!title.IsNull()) wxFprintf( stderr, _T("%s "), WXSTRINGCAST(title) );
-  if (!msg.IsNull()) wxFprintf( stderr, _T(": %s"), WXSTRINGCAST(msg) );
-  wxFprintf( stderr, _T(".\n") );
+  if (!title.IsNull()) wxFprintf( stderr, wxT("%s "), WXSTRINGCAST(title) );
+  if (!msg.IsNull()) wxFprintf( stderr, wxT(": %s"), WXSTRINGCAST(msg) );
+  wxFprintf( stderr, wxT(".\n") );

 }
 
 void wxFatalError( const wxString &msg, const wxString &title )
 {
   wxFprintf( stderr, _("Error ") );
 }
 
 void wxFatalError( const wxString &msg, const wxString &title )
 {
   wxFprintf( stderr, _("Error ") );

-  if (!title.IsNull()) wxFprintf( stderr, _T("%s "), WXSTRINGCAST(title) );
-  if (!msg.IsNull()) wxFprintf( stderr, _T(": %s"), WXSTRINGCAST(msg) );
-  wxFprintf( stderr, _T(".\n") );
+  if (!title.IsNull()) wxFprintf( stderr, wxT("%s "), WXSTRINGCAST(title) );
+  if (!msg.IsNull()) wxFprintf( stderr, wxT(": %s"), WXSTRINGCAST(msg) );
+  wxFprintf( stderr, wxT(".\n") );

   exit(3); // the same exit code as for abort()
 }
   exit(3); // the same exit code as for abort()
 }

+