Doc updates (debug stuff); Cygwin corrections

[wxWidgets.git] / src / gtk / listbox.cpp

diff --git a/src/gtk/listbox.cpp b/src/gtk/listbox.cpp
index 2896e62535a69e6474d19d7dd974354c287f8fde..066cc2a8e99efc71c8b5bd14151abbf1c38980c3 100644 (file)
--- a/src/gtk/listbox.cpp
+++ b/src/gtk/listbox.cpp
@@ -101,6 +101,9 @@ bool wxListBox::Create( wxWindow *parent, wxWindowID id,
 
     for (int i = 0; i < n; i++)
     {
 
     for (int i = 0; i < n; i++)
     {

+        m_clientDataList.Append( (wxObject*) NULL );
+        m_clientObjectList.Append( (wxObject*) NULL );
+  

         GtkWidget *list_item;
         list_item = gtk_list_item_new_with_label( choices[i] );
 
         GtkWidget *list_item;
         list_item = gtk_list_item_new_with_label( choices[i] );
 


@@ -115,8 +118,6 @@ bool wxListBox::Create( wxWindow *parent, wxWindowID id,
 
         ConnectWidget( list_item );    
        
 
         ConnectWidget( list_item );    
        

-        m_clientDataList.Append( (wxObject*)NULL );
-

         gtk_widget_show( list_item );
     }
 
         gtk_widget_show( list_item );
     }
 


@@ -138,14 +139,7 @@ bool wxListBox::Create( wxWindow *parent, wxWindowID id,
 
 wxListBox::~wxListBox()
 {
 
 wxListBox::~wxListBox()
 {

-    wxNode *node = m_clientDataList.First();
-    while (node)
-    {
-        wxClientData *cd = (wxClientData*)node->Data();
-        if (cd) delete cd;
-        node = node->Next();
-    }
-    m_clientDataList.Clear();
+  Clear();

 }
 
 void wxListBox::AppendCommon( const wxString &item )
 }
 
 void wxListBox::AppendCommon( const wxString &item )


@@ -174,24 +168,24 @@ void wxListBox::AppendCommon( const wxString &item )
 
 void wxListBox::Append( const wxString &item )
 {
 
 void wxListBox::Append( const wxString &item )
 {

-    m_clientDataList.Append( (wxObject*)NULL );
+    m_clientDataList.Append( (wxObject*) NULL );
+    m_clientObjectList.Append( (wxObject*) NULL );

   
     AppendCommon( item );
 }
 
 void wxListBox::Append( const wxString &item, void *clientData )
 {
   
     AppendCommon( item );
 }
 
 void wxListBox::Append( const wxString &item, void *clientData )
 {

-    if (clientData)
-        m_clientDataList.Append( (wxObject*) new wxVoidClientData( clientData ) );
-    else
-        m_clientDataList.Append( (wxObject*)NULL );
+    m_clientDataList.Append( (wxObject*) clientData );
+    m_clientObjectList.Append( (wxObject*) NULL );

   
     AppendCommon( item );
 }
 
 void wxListBox::Append( const wxString &item, wxClientData *clientData )
 {
   
     AppendCommon( item );
 }
 
 void wxListBox::Append( const wxString &item, wxClientData *clientData )
 {

-    m_clientDataList.Append( (wxObject*) clientData );
+    m_clientObjectList.Append( (wxObject*) clientData );
+    m_clientDataList.Append( (wxObject*) NULL );

   
     AppendCommon( item );
 }
   
     AppendCommon( item );
 }


@@ -203,13 +197,7 @@ void wxListBox::SetClientData( int n, void* clientData )
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return;
   
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return;
   

-    wxClientData *cd = (wxClientData*) node->Data();
-    if (cd) delete cd;
-  
-    if (clientData)
-        node->SetData( (wxObject*) new wxVoidClientData(clientData) );
-    else
-        node->SetData( (wxObject*) NULL );
+    node->SetData( (wxObject*) clientData );

 }
 
 void* wxListBox::GetClientData( int n )
 }
 
 void* wxListBox::GetClientData( int n )


@@ -219,18 +207,14 @@ void* wxListBox::GetClientData( int n )
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return NULL;
     
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return NULL;
     

-    wxVoidClientData *cd = (wxVoidClientData*) node->Data();
-    if (cd)
-        return cd->GetData();
-    else
-        return (void*) NULL;  
+    return node->Data();

 }
 
 void wxListBox::SetClientObject( int n, wxClientData* clientData )
 {
     wxCHECK_RET( m_widget != NULL, "invalid combobox" );
     
 }
 
 void wxListBox::SetClientObject( int n, wxClientData* clientData )
 {
     wxCHECK_RET( m_widget != NULL, "invalid combobox" );
     

-    wxNode *node = m_clientDataList.Nth( n );
+    wxNode *node = m_clientObjectList.Nth( n );

     if (!node) return;
   
     wxClientData *cd = (wxClientData*) node->Data();
     if (!node) return;
   
     wxClientData *cd = (wxClientData*) node->Data();


@@ -243,7 +227,7 @@ wxClientData* wxListBox::GetClientObject( int n )
 {
     wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, "invalid combobox" );
   
 {
     wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, "invalid combobox" );
   

-    wxNode *node = m_clientDataList.Nth( n );
+    wxNode *node = m_clientObjectList.Nth( n );

     if (!node) return (wxClientData*) NULL;
     
     return (wxClientData*) node->Data();
     if (!node) return (wxClientData*) NULL;
     
     return (wxClientData*) node->Data();


@@ -255,13 +239,15 @@ void wxListBox::Clear()
 
     gtk_list_clear_items( m_list, 0, Number() );
 
 
     gtk_list_clear_items( m_list, 0, Number() );
 

-    wxNode *node = m_clientDataList.First();
+    wxNode *node = m_clientObjectList.First();

     while (node)
     {
         wxClientData *cd = (wxClientData*)node->Data();
         if (cd) delete cd;
         node = node->Next();
     }
     while (node)
     {
         wxClientData *cd = (wxClientData*)node->Data();
         if (cd) delete cd;
         node = node->Next();
     }

+    m_clientObjectList.Clear();
+    

     m_clientDataList.Clear();
 }
 
     m_clientDataList.Clear();
 }
 


@@ -281,15 +267,17 @@ void wxListBox::Delete( int n )
     gtk_list_remove_items( m_list, list );
     g_list_free( list );
 
     gtk_list_remove_items( m_list, list );
     g_list_free( list );
 

-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node)
-    {
-        wxFAIL_MSG( "wrong index" );
-    }
-    else
+    wxNode *node = m_clientObjectList.Nth( n );
+    if (node)

     {
         wxClientData *cd = (wxClientData*)node->Data();
         if (cd) delete cd;
     {
         wxClientData *cd = (wxClientData*)node->Data();
         if (cd) delete cd;

+        m_clientObjectList.DeleteNode( node );
+    }
+    
+    node = m_clientDataList.Nth( n );
+    if (node)
+    {

         m_clientDataList.DeleteNode( node );
     }
 }
         m_clientDataList.DeleteNode( node );
     }
 }


@@ -534,10 +522,13 @@ void wxListBox::ApplyWidgetStyle()
 {
     SetWidgetStyle();
   
 {
     SetWidgetStyle();
   

-    GdkWindow *window = GTK_WIDGET(m_list)->window;
-    m_backgroundColour.CalcPixel( gdk_window_get_colormap( window ) );
-    gdk_window_set_background( window, m_backgroundColour.GetColor() );
-    gdk_window_clear( window );
+    if (m_backgroundColour.Ok())
+    {
+        GdkWindow *window = GTK_WIDGET(m_list)->window;
+        m_backgroundColour.CalcPixel( gdk_window_get_colormap( window ) );
+        gdk_window_set_background( window, m_backgroundColour.GetColor() );
+        gdk_window_clear( window );
+    }

       
     GList *child = m_list->children;
     while (child)
       
     GList *child = m_list->children;
     while (child)