enter wxPendingEventLocker critical section in ProcessPendingEvents() (fixes 1720352)

[wxWidgets.git] / src / mac / carbon / timer.cpp

diff --git a/src/mac/carbon/timer.cpp b/src/mac/carbon/timer.cpp
index f7a1a01fd847063bb1d7ad221963fcce229ea505..28179a84f4820ed0b3bd62acd55f279524c36bad 100644 (file)
--- a/src/mac/carbon/timer.cpp
+++ b/src/mac/carbon/timer.cpp
@@ -1,218 +1,216 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        timer.cpp
+// Name:        sec/mac/carbon/timer.cpp

 // Purpose:     wxTimer implementation
 // Author:      Stefan Csomor
 // Modified by:
 // Created:     1998-01-01
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Csomor
 // Purpose:     wxTimer implementation
 // Author:      Stefan Csomor
 // Modified by:
 // Created:     1998-01-01
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Csomor

-// Licence:       wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "timer.h"
-#endif
-

 #include "wx/wxprec.h"
 
 #include "wx/wxprec.h"
 

-#include "wx/timer.h"
+#if wxUSE_TIMER
+
+#ifndef WX_PRECOMP
+    #include "wx/dynarray.h"
+#endif

 
 

-IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxEvtHandler)
+#include "wx/mac/private/timer.h"

 
 #ifdef __WXMAC__
 
 #ifdef __WXMAC__

-#include "wx/mac/private.h"
+    #include "wx/mac/private.h"

 #endif
 #endif

+

 #ifndef __DARWIN__
 #ifndef __DARWIN__

-#include <Timer.h>
+    #include <Timer.h>

 #endif
 
 #endif
 

-#include "wx/dynarray.h"
-

 #define wxMAC_USE_CARBON_TIMER 1
 
 #if wxMAC_USE_CARBON_TIMER
 
 #define wxMAC_USE_CARBON_TIMER 1
 
 #if wxMAC_USE_CARBON_TIMER
 

-typedef struct MacTimerInfo
+struct MacTimerInfo

 {
 {

-    wxTimer* m_timer ;
-    EventLoopTimerUPP m_proc ;
-    EventLoopTimerRef   m_timerRef ;
-} ;
+    wxCarbonTimerImpl* m_timer;
+    EventLoopTimerUPP m_proc;
+    EventLoopTimerRef   m_timerRef;
+};

 
 

-static pascal void wxProcessTimer( EventLoopTimerRef  theTimer , void *data ) ;
-static pascal void wxProcessTimer( EventLoopTimerRef theTimer , void *data )
+static pascal void wxProcessTimer( EventLoopTimerRef theTimer, void *data )

 {
 {

-    if ( !data )
-        return ;
-        
-    wxTimer* timer = (wxTimer*) data ;
-    
+    if ( data == NULL )
+        return;
+
+    wxCarbonTimerImpl* timer = (wxCarbonTimerImpl*)data;
+

     if ( timer->IsOneShot() )
     if ( timer->IsOneShot() )

-        timer->Stop() ;
+        timer->Stop();

 
     timer->Notify();
 }
 
 
     timer->Notify();
 }
 

-void wxTimer::Init()
+wxCarbonTimerImpl::wxCarbonTimerImpl(wxTimer *timer)
+                 : wxTimerImpl(timer)

 {
 {

-    m_info = new MacTimerInfo() ;
-    m_info->m_timer = this ;
-    m_info->m_proc = NULL ;
-    m_info->m_timerRef = kInvalidID ;
+    m_info = new MacTimerInfo();
+    m_info->m_timer = this;
+    m_info->m_proc = NULL;
+    m_info->m_timerRef = kInvalidID;

 }
 
 }
 

-bool wxTimer::IsRunning() const 
+bool wxCarbonTimerImpl::IsRunning() const

 {
 {

-    return ( m_info->m_timerRef != kInvalidID ) ;
+    return ( m_info->m_timerRef != kInvalidID );

 }
 
 }
 

-wxTimer::~wxTimer()
+wxCarbonTimerImpl::~wxCarbonTimerImpl()

 {
 {

-    Stop();
-    if (m_info != NULL) {
-        delete m_info ;
-        m_info = NULL ;
-    }
+    delete m_info;

 }
 
 }
 

-bool wxTimer::Start(int milliseconds,bool mode)
+bool wxCarbonTimerImpl::Start( int milliseconds, bool mode )

 {
 {

-    (void)wxTimerBase::Start(milliseconds, mode);
+    (void)wxTimerImpl::Start(milliseconds, mode);
+
+    wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeout") );
+    wxCHECK_MSG( m_info->m_timerRef == NULL, false, wxT("attempting to restart a timer") );

 
 

-    wxCHECK_MSG( m_milli > 0, FALSE, wxT("invalid value for timer timeout") );
-    wxCHECK_MSG( m_info->m_timerRef == NULL , FALSE, wxT("attempting to restart a timer") );
+    m_info->m_timer = this;
+    m_info->m_proc = NewEventLoopTimerUPP( &wxProcessTimer );

 
 

-    m_info->m_timer = this ;
-    m_info->m_proc = NewEventLoopTimerUPP( &wxProcessTimer);
-    verify_noerr( InstallEventLoopTimer (
-        GetMainEventLoop() ,
+    OSStatus err = InstallEventLoopTimer(
+        GetMainEventLoop(),

         m_milli*kEventDurationMillisecond,
         m_milli*kEventDurationMillisecond,

-        IsOneShot() ? 0 : m_milli*kEventDurationMillisecond ,
+        IsOneShot() ? 0 : m_milli * kEventDurationMillisecond,

         m_info->m_proc,
         this,
         m_info->m_proc,
         this,

-        &m_info->m_timerRef) ) ;
-    return TRUE;
+        &m_info->m_timerRef );
+    verify_noerr( err );
+
+    return true;

 }
 
 }
 

-void wxTimer::Stop()
+void wxCarbonTimerImpl::Stop()

 {
     if (m_info->m_timerRef)
 {
     if (m_info->m_timerRef)

-        RemoveEventLoopTimer( m_info->m_timerRef ) ; 
+        RemoveEventLoopTimer( m_info->m_timerRef );

     if (m_info->m_proc)
     if (m_info->m_proc)

-        DisposeEventLoopTimerUPP(m_info->m_proc) ;
-    m_info->m_proc = NULL ;
-    m_info->m_timerRef = kInvalidID ;
+        DisposeEventLoopTimerUPP( m_info->m_proc );
+
+    m_info->m_proc = NULL;
+    m_info->m_timerRef = kInvalidID;

 }
 
 }
 

-#else
+#else // !wxMAC_USE_CARBON_TIMER

 
 typedef struct MacTimerInfo
 {
     TMTask m_task;
 
 typedef struct MacTimerInfo
 {
     TMTask m_task;

-    wxMacNotifierTableRef m_table ;
-    wxTimer* m_timer ;
-} ;
+    wxMacNotifierTableRef m_table;
+    wxCarbonTimerImpl* m_timer;
+};

 
 

-static void wxProcessTimer( unsigned long event , void *data ) ;
+static void wxProcessTimer( unsigned long event, void *data );

 
 static pascal void MacTimerProc( TMTask * t )
 {
 
 static pascal void MacTimerProc( TMTask * t )
 {

-    MacTimerInfo * tm = (MacTimerInfo*)  t ;
-    wxMacAddEvent( tm->m_table , wxProcessTimer, 0 , (void*) tm->m_timer , TRUE ) ;
+    MacTimerInfo * tm = (MacTimerInfo*) t;
+    wxMacAddEvent( tm->m_table, wxProcessTimer, 0, (void*) tm->m_timer, true );

 }
 
 // we need this array to track timers that are being deleted within the Notify procedure
 }
 
 // we need this array to track timers that are being deleted within the Notify procedure

-// adding the timer before the Notify call and checking after whether it still is in there 
+// adding the timer before the Notify call and checking after whether it still is in there

 // as the destructor would have removed it from the array
 
 // as the destructor would have removed it from the array
 

-wxArrayPtrVoid gTimersInProcess ;
+wxArrayPtrVoid gTimersInProcess;

 
 

-static void wxProcessTimer( unsigned long event , void *data )
+static void wxProcessTimer( unsigned long event, void *data )

 {
 {

-    if ( !data )
-        return ;
-        
-    wxTimer* timer = (wxTimer*) data ;
-    
-    if ( timer->IsOneShot() )
-        timer->Stop() ;
-        
-    gTimersInProcess.Add( timer ) ;
-     
+    if ( data == NULL )
+        return;
+
+    wxCarbonTimerImpl* timer = (wxCarbonTimerImpl*) data;
+    if ( timer->m_oneShot )
+        timer->Stop();
+
+    gTimersInProcess.Add( timer );

     timer->Notify();
 
     timer->Notify();
 

-    int index = gTimersInProcess.Index( timer ) ;
-    
+    int index = gTimersInProcess.Index( timer );

     if ( index != wxNOT_FOUND )
     {
     if ( index != wxNOT_FOUND )
     {

-        gTimersInProcess.RemoveAt( index ) ;
-        
+        gTimersInProcess.RemoveAt( index );
+

         if ( !timer->IsOneShot() && timer->m_info->m_task.tmAddr )
         if ( !timer->IsOneShot() && timer->m_info->m_task.tmAddr )

-        {
-            PrimeTime( (QElemPtr)  &timer->m_info->m_task , timer->GetInterval() ) ;
-        }
-    
+            PrimeTime( (QElemPtr) &timer->m_info->m_task, timer->GetInterval() );

     }
 }
 
     }
 }
 

-void wxTimer::Init()
+void wxCarbonTimerImpl::Init()

 {
 {

-    m_info = new MacTimerInfo() ;
-    m_info->m_task.tmAddr = NULL ;
-    m_info->m_task.tmWakeUp = 0 ;
-    m_info->m_task.tmReserved = 0 ;
-    m_info->m_task.qType = 0 ;
-    m_info->m_table = wxMacGetNotifierTable() ;
-    m_info->m_timer = this ;
+    m_info = new MacTimerInfo();
+    m_info->m_task.tmAddr = NULL;
+    m_info->m_task.tmWakeUp = 0;
+    m_info->m_task.tmReserved = 0;
+    m_info->m_task.qType = 0;
+    m_info->m_table = wxMacGetNotifierTable();
+    m_info->m_timer = this;

 }
 
 }
 

-bool wxTimer::IsRunning() const 
+bool wxCarbonTimerImpl::IsRunning() const

 {
     // as the qType may already indicate it is elapsed, but it
     // was not handled internally yet
 {
     // as the qType may already indicate it is elapsed, but it
     // was not handled internally yet

-    return ( m_info->m_task.tmAddr != NULL ) ;
+    return ( m_info->m_task.tmAddr != NULL );

 }
 
 }
 

-wxTimer::~wxTimer()
+wxCarbonTimerImpl::~wxCarbonTimerImpl()

 {
     Stop();
 {
     Stop();

-    if (m_info != NULL) {
-        delete m_info ;
-        m_info = NULL ;
+    if (m_info != NULL)
+    {
+        delete m_info;
+        m_info = NULL;

     }
     }

-    int index = gTimersInProcess.Index( this ) ;
+
+    int index = gTimersInProcess.Index( this );

     if ( index != wxNOT_FOUND )
     if ( index != wxNOT_FOUND )

-        gTimersInProcess.RemoveAt( index ) ;  
+        gTimersInProcess.RemoveAt( index );

 }
 
 }
 

-bool wxTimer::Start(int milliseconds,bool mode)
+bool wxCarbonTimerImpl::Start( int milliseconds, bool mode )

 {
 {

-    (void)wxTimerBase::Start(milliseconds, mode);
-
-    wxCHECK_MSG( m_milli > 0, FALSE, wxT("invalid value for timer timeout") );
-    wxCHECK_MSG( m_info->m_task.tmAddr == NULL , FALSE, wxT("attempting to restart a timer") );
-
-    m_info->m_task.tmAddr = NewTimerUPP( MacTimerProc ) ;
-    m_info->m_task.tmWakeUp = 0 ;
-    m_info->m_task.tmReserved = 0 ;
-    m_info->m_task.qType = 0 ;
-    m_info->m_timer = this ;
-    InsXTime((QElemPtr) &m_info->m_task ) ;
-    PrimeTime( (QElemPtr) &m_info->m_task , m_milli ) ;
-    return TRUE;
+    (void)wxTimerBase::Start( milliseconds, mode );
+
+    wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeout") );
+    wxCHECK_MSG( m_info->m_task.tmAddr == NULL, false, wxT("attempting to restart a timer") );
+
+    m_info->m_task.tmAddr = NewTimerUPP( MacTimerProc );
+    m_info->m_task.tmWakeUp = 0;
+    m_info->m_task.tmReserved = 0;
+    m_info->m_task.qType = 0;
+    m_info->m_timer = this;
+    InsXTime( (QElemPtr) &m_info->m_task );
+    PrimeTime( (QElemPtr) &m_info->m_task, m_milli );
+
+    return true;

 }
 
 }
 

-void wxTimer::Stop()
+void wxCarbonTimerImpl::Stop()

 {
     if ( m_info->m_task.tmAddr )
     {
 {
     if ( m_info->m_task.tmAddr )
     {

-        RmvTime(  (QElemPtr) &m_info->m_task ) ;
-        DisposeTimerUPP(m_info->m_task.tmAddr) ;
-        m_info->m_task.tmAddr = NULL ;
+        RmvTime( (QElemPtr) &m_info->m_task );
+        DisposeTimerUPP( m_info->m_task.tmAddr );
+        m_info->m_task.tmAddr = NULL;

     }
     }

-    wxMacRemoveAllNotifiersForData( wxMacGetNotifierTable() , this ) ;
+
+    wxMacRemoveAllNotifiersForData( wxMacGetNotifierTable(), this );

 }
 
 }
 

-#endif
+#endif // wxMAC_USE_CARBON_TIMER/!wxMAC_USE_CARBON_TIMER

 
 

+#endif // wxUSE_TIMER