readability cleanup

[wxWidgets.git] / src / cocoa / dialog.mm

diff --git a/src/cocoa/dialog.mm b/src/cocoa/dialog.mm
index 59cf2fb0a2103642e2310115c207a39fe3486133..d18483cc868d4b17b052ff37b756fde1f448a4bf 100644 (file)
--- a/src/cocoa/dialog.mm
+++ b/src/cocoa/dialog.mm
@@ -4,18 +4,26 @@
 // Author:      David Elliott
 // Modified by:
 // Created:     2002/12/15
 // Author:      David Elliott
 // Modified by:
 // Created:     2002/12/15

-// RCS-ID:      $Id: 
+// RCS-ID:      $Id:

 // Copyright:   2002 David Elliott
 // Copyright:   2002 David Elliott

-// Licence:    wxWindows license
+// Licence:     wxWidgets licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#include "wx/dialog.h"
-#include "wx/app.h"
-#include "wx/settings.h"
-#include "wx/log.h"
+#include "wx/wxprec.h"
+#ifndef WX_PRECOMP
+    #include "wx/log.h"
+    #include "wx/app.h"
+    #include "wx/dialog.h"
+    #include "wx/settings.h"
+#endif //WX_PRECOMP
+
+#include "wx/cocoa/autorelease.h"
+#include "wx/cocoa/string.h"

 
 #import <AppKit/NSPanel.h>
 #import <AppKit/NSApplication.h>
 
 #import <AppKit/NSPanel.h>
 #import <AppKit/NSApplication.h>

+#import <AppKit/NSEvent.h>
+#import <Foundation/NSRunLoop.h>

 
 // Lists to keep track of windows, so we can disable/enable them
 // for modal dialogs
 
 // Lists to keep track of windows, so we can disable/enable them
 // for modal dialogs


@@ -34,7 +42,8 @@ WX_IMPLEMENT_COCOA_OWNER(wxDialog,NSPanel,NSWindow,NSWindow)
 
 void wxDialog::Init()
 {
 
 void wxDialog::Init()
 {

-    SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE));
+    m_isModal = false;
+    SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE));

 }
 
 bool wxDialog::Create(wxWindow *parent, wxWindowID winid,
 }
 
 bool wxDialog::Create(wxWindow *parent, wxWindowID winid,


@@ -44,6 +53,7 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID winid,
            long style,
            const wxString& name)
 {
            long style,
            const wxString& name)
 {

+    wxAutoNSAutoreleasePool pool;

     wxTopLevelWindows.Append(this);
 
     if(!CreateBase(parent,winid,pos,size,style,wxDefaultValidator,name))
     wxTopLevelWindows.Append(this);
 
     if(!CreateBase(parent,winid,pos,size,style,wxDefaultValidator,name))


@@ -66,82 +76,111 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID winid,
     // Because we do not release on close, the following release matches the
     // above alloc and thus the retain count will be 1.
     [m_cocoaNSWindow release];
     // Because we do not release on close, the following release matches the
     // above alloc and thus the retain count will be 1.
     [m_cocoaNSWindow release];

-    wxLogDebug("wxDialog m_cocoaNSWindow retainCount=%d",[m_cocoaNSWindow retainCount]);
+    wxLogTrace(wxTRACE_COCOA_RetainRelease,wxT("wxDialog m_cocoaNSWindow retainCount=%d"),[m_cocoaNSWindow retainCount]);
+    [m_cocoaNSWindow setTitle:wxNSStringWithWxString(title)];
+    [m_cocoaNSWindow setHidesOnDeactivate:NO];

 
     return true;
 }
 
 wxDialog::~wxDialog()
 {
 
     return true;
 }
 
 wxDialog::~wxDialog()
 {

-    wxLogDebug("Destroying");
-    // setReleasedWhenClosed: NO
-    [m_cocoaNSWindow close];
-    SetNSPanel(NULL);
+    DisassociateNSPanel(GetNSPanel());

 }
 
 }
 

-void wxDialog::Cocoa_close(void)
+void wxDialog::CocoaDelegate_windowWillClose(void)

 {
     m_closed = true;
     /* Actually, this isn't true anymore */
 {
     m_closed = true;
     /* Actually, this isn't true anymore */

-    wxLogDebug("Woah: Dialogs are not generally closed");
+    wxLogTrace(wxTRACE_COCOA,wxT("Woah: Dialogs are not generally closed"));

 }
 
 void wxDialog::SetModal(bool flag)
 {
 }
 
 void wxDialog::SetModal(bool flag)
 {

-    if ( flag )
-    {
-        wxModelessWindows.DeleteObject(this);
-        m_windowStyle |= wxDIALOG_MODAL ;
-    }
-    else
-    {
-        m_windowStyle &= ~wxDIALOG_MODAL ;
-        wxModelessWindows.Append(this);
-    }
+    wxFAIL_MSG( wxT("wxDialog:SetModal obsolete now") );

 }
 
 bool wxDialog::Show(bool show)
 {
 }
 
 bool wxDialog::Show(bool show)
 {

+    if(m_isShown == show)
+        return false;
+

     if(show)
     if(show)

-        InitDialog();
-    if(IsModal())

     {
     {

-        if(show)
-        {
-            wxModalDialogs.Append(this);
-            wxLogDebug("runModal");
-            [wxTheApp->GetNSApplication() runModalForWindow:m_cocoaNSWindow];
-            wxLogDebug("runModal END");
+        wxAutoNSAutoreleasePool pool;
+        InitDialog();
+        if(IsModal())
+        {   // ShowModal() will show the dialog
+            m_isShown = true;
+            return true;

         }
         }

-        else
-        {
-            wxLogDebug("abortModal");
+    }
+    else
+    {
+        if(IsModal())
+        {   // this doesn't hide the dialog, base class Show(false) does.
+            wxLogTrace(wxTRACE_COCOA,wxT("abortModal"));

             [wxTheApp->GetNSApplication() abortModal];
             wxModalDialogs.DeleteObject(this);
             [wxTheApp->GetNSApplication() abortModal];
             wxModalDialogs.DeleteObject(this);

+            m_isModal = false;

         }
     }
         }
     }

-    return true;
+    return wxTopLevelWindow::Show(show);

 }
 
 }
 

-// Replacement for Show(TRUE) for modal dialogs - returns return code
+// Shows the dialog and begins a modal event loop.  When the event loop
+// is stopped (via EndModal()) it returns the exit code.

 int wxDialog::ShowModal()
 {
 int wxDialog::ShowModal()
 {

-    if(!IsModal())
-        SetModal(true);
+    wxCHECK_MSG(!IsModal(),GetReturnCode(),wxT("wxDialog::ShowModal called within its own modal loop"));
+
+    // Show(true) will set m_isShown = true
+    m_isShown = false;
+    m_isModal = true;
+    wxModalDialogs.Append(this);
+
+    wxLogTrace(wxTRACE_COCOA,wxT("runModal"));
+    NSApplication *theNSApp = wxTheApp->GetNSApplication();
+    // If the app hasn't started, flush the event queue
+    // If we don't do this, the Dock doesn't get the message that
+    // the app has started so will refuse to activate it.
+    if(![theNSApp isRunning])
+    {
+        // We should only do a few iterations so one pool should be okay
+        wxAutoNSAutoreleasePool pool;
+        while(NSEvent *event = [theNSApp
+                    nextEventMatchingMask:NSAnyEventMask
+                    untilDate:[NSDate distantPast]
+                    inMode:NSDefaultRunLoopMode
+                    dequeue: YES])
+        {
+            [theNSApp sendEvent: event];
+        }
+    }
+

     Show(true);
     Show(true);

+    do {
+        wxAutoNSAutoreleasePool pool;
+        [wxTheApp->GetNSApplication() runModalForWindow:m_cocoaNSWindow];
+    } while(0);
+    wxLogTrace(wxTRACE_COCOA,wxT("runModal END"));
+

     return GetReturnCode();
 }
 
     return GetReturnCode();
 }
 

-// EndModal will work for any dialog

 void wxDialog::EndModal(int retCode)
 {
 void wxDialog::EndModal(int retCode)
 {

+    wxASSERT_MSG(IsModal(), wxT("EndModal() should only be used within ShowModal()"));

     SetReturnCode(retCode);
     Show(false);
 }
 
     SetReturnCode(retCode);
     Show(false);
 }
 

-bool wxDialog::IsModal() const
+void wxDialog::EndDialog(int retCode)

 {
 {

-    return (GetWindowStyleFlag() & wxDIALOG_MODAL);
+    if(IsModal())
+        EndModal(retCode);
+    else
+        Show(false);

 }
 
 void wxDialog::OnCloseWindow(wxCloseEvent& event)
 }
 
 void wxDialog::OnCloseWindow(wxCloseEvent& event)


@@ -163,16 +202,16 @@ void wxDialog::OnCloseWindow(wxCloseEvent& event)
     event.Veto();
 
     static wxList closing;
     event.Veto();
 
     static wxList closing;

-    
+

     if ( closing.Member(this) )
     {
     if ( closing.Member(this) )
     {

-        wxLogDebug("WARNING: Attempting to recursively call Close for dialog");
+        wxLogDebug(wxT("WARNING: Attempting to recursively call Close for dialog"));

         return;
     }
         return;
     }

-    
+

     closing.Append(this);
     closing.Append(this);

-    
-    wxLogDebug("Sending Cancel Event");
+
+    wxLogTrace(wxTRACE_COCOA,wxT("Sending Cancel Event"));

     wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
     cancelEvent.SetEventObject( this );
     GetEventHandler()->ProcessEvent(cancelEvent); // This may close the dialog
     wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
     cancelEvent.SetEventObject( this );
     GetEventHandler()->ProcessEvent(cancelEvent); // This may close the dialog


@@ -185,20 +224,20 @@ void wxDialog::OnOK(wxCommandEvent& event)
 {
     if ( Validate() && TransferDataFromWindow() )
     {
 {
     if ( Validate() && TransferDataFromWindow() )
     {

-        EndModal(wxID_OK);
+        EndDialog(wxID_OK);

     }
 }
 
 void wxDialog::OnApply(wxCommandEvent& event)
 {
     }
 }
 
 void wxDialog::OnApply(wxCommandEvent& event)
 {

-       if (Validate())
-               TransferDataFromWindow();
-       // TODO probably need to disable the Apply button until things change again
+    if (Validate())
+        TransferDataFromWindow();
+    // TODO probably need to disable the Apply button until things change again

 }
 
 void wxDialog::OnCancel(wxCommandEvent& event)
 {
 }
 
 void wxDialog::OnCancel(wxCommandEvent& event)
 {

-    wxLogDebug("Cancelled!");
-    EndModal(wxID_CANCEL);
+    wxLogTrace(wxTRACE_COCOA,wxT("Cancelled!"));
+    EndDialog(wxID_CANCEL);

 }
 
 }