wxMenuItem::wxMenuItem(
wxMenu* pParentMenu
, int nId
-, const wxString& rText
-, const wxString& rStrHelp
-, wxItemKind kind
+, const wxString& rsText
+, const wxString& rsHelp
+, wxItemKind eKind
, wxMenu* pSubMenu
)
-: wxMenuItemBase(pParentMenu, nId, rText, rStrHelp, kind, pSubMenu)
+: wxMenuItemBase( pParentMenu
+ ,nId
+ ,TextToLabel(rsText)
+ ,rsHelp
+ ,eKind
+ ,pSubMenu
+ )
#if wxUSE_OWNER_DRAWN
-, wxOwnerDrawn( TextToLabel(rText)
- ,bCheckable
+, wxOwnerDrawn( TextToLabel(rsText)
+ ,eKind == wxITEM_CHECK
)
#endif // owner drawn
{
wxMenuItem::wxMenuItem(
wxMenu* pParentMenu
, int nId
-, const wxString& rText
-, const wxString& rStrHelp
+, const wxString& rsText
+, const wxString& rsHelp
, bool bIsCheckable
, wxMenu* pSubMenu
)
-: wxMenuItemBase(pParentMenu, nId, rText, rStrHelp, bIsCheckable ? kITEM_CHECK : kITEM_NORMAL, pSubMenu)
+: wxMenuItemBase( pParentMenu
+ ,nId
+ ,TextToLabel(rsText)
+ ,rsHelp
+ ,bIsCheckable ? wxITEM_CHECK : wxITEM_NORMAL
+ ,pSubMenu
+ )
#if wxUSE_OWNER_DRAWN
-, wxOwnerDrawn( TextToLabel(rText)
- ,bCheckable
+, wxOwnerDrawn( TextToLabel(rsText)
+ ,bIsCheckable
)
#endif // owner drawn
{
wxASSERT_MSG(pParentMenu != NULL, wxT("a menu item should have a parent"));
+ memset(&m_vMenuData, '\0', sizeof(m_vMenuData));
+ m_vMenuData.id = (USHORT)nId;
Init();
} // end of wxMenuItem::wxMenuItem
void wxMenuItem::Init()
{
- m_radioGroup.start = -1;
- m_isRadioGroupStart = FALSE;
+ m_vRadioGroup.m_nStart = -1;
+ m_bIsRadioGroupStart = FALSE;
#if wxUSE_OWNER_DRAWN
- // set default menu colors
+ //
+ // Set default menu colors
+ //
#define SYS_COLOR(c) (wxSystemSettings::GetColour(wxSYS_COLOUR_##c))
SetTextColour(SYS_COLOR(MENUTEXT));
#undef SYS_COLOR
- // we don't want normal items be owner-drawn
+ //
+ // We don't want normal items be owner-drawn
+ //
ResetOwnerDrawn();
- // tell the owner drawing code to to show the accel string as well
+ //
+ // Tell the owner drawing code to to show the accel string as well
+ //
SetAccelString(m_text.AfterFirst(_T('\t')));
#endif // wxUSE_OWNER_DRAWN
-}
+} // end of wxMenuItem::Init
wxMenuItem::~wxMenuItem()
{
return label;
}
-// radio group stuff
+//
+// Radio group stuff
// -----------------
-
+//
void wxMenuItem::SetAsRadioGroupStart()
{
m_bIsRadioGroupStart = TRUE;
int nStart
)
{
- wxASSERT_MSG( !m_bIsRadioGroupStart,
- _T("should only be called for the next radio items") );
+ wxASSERT_MSG( !m_bIsRadioGroupStart
+ ,_T("should only be called for the next radio items")
+ );
m_vRadioGroup.m_nStart = nStart;
-} // end of wxMenuItem::SetRadioGroupStart
+} // wxMenuItem::SetRadioGroupStart
void wxMenuItem::SetRadioGroupEnd(
int nEnd
)
{
- wxASSERT_MSG( m_bIsRadioGroupStart,
- _T("should only be called for the first radio item") );
-
+ wxASSERT_MSG( m_bIsRadioGroupStart
+ ,_T("should only be called for the first radio item")
+ );
m_vRadioGroup.m_nEnd = nEnd;
} // end of wxMenuItem::SetRadioGroupEnd
if (m_isChecked == bCheck)
return;
- if (bCheck)
- bOk = (bool)::WinSendMsg( GetHMenuOf(m_parentMenu)
- ,MM_SETITEMATTR
- ,MPFROM2SHORT(GetRealId(), TRUE)
- ,MPFROM2SHORT(MIA_CHECKED, MIA_CHECKED)
- );
- else
- bOk = (bool)::WinSendMsg( GetHMenuOf(m_parentMenu)
- ,MM_SETITEMATTR
- ,MPFROM2SHORT(GetRealId(), TRUE)
- ,MPFROM2SHORT(MIA_CHECKED, FALSE)
- );
+ HMENU hMenu = GetHmenuOf(m_parentMenu);
+
+ if (GetKind() == wxITEM_RADIO)
+ {
+ //
+ // It doesn't make sense to uncheck a radio item - what would this do?
+ //
+ if (!bCheck)
+ return;
+
+ //
+ // Get the index of this item in the menu
+ //
+ const wxMenuItemList& rItems = m_parentMenu->GetMenuItems();
+ int nPos = rItems.IndexOf(this);
+
+ wxCHECK_RET( nPos != wxNOT_FOUND
+ ,_T("menuitem not found in the menu items list?")
+ );
+
+ //
+ // Get the radio group range
+ //
+ int nStart;
+ int nEnd;
+
+ if (m_bIsRadioGroupStart)
+ {
+ //
+ // We already have all information we need
+ //
+ nStart = nPos;
+ nEnd = m_vRadioGroup.m_nEnd;
+ }
+ else // next radio group item
+ {
+ //
+ // Get the radio group end from the start item
+ //
+ nStart = m_vRadioGroup.m_nStart;
+ nEnd = rItems.Item(nStart)->GetData()->m_vRadioGroup.m_nEnd;
+ }
+
+ //
+ // Also uncheck all the other items in this radio group
+ //
+ wxMenuItemList::Node* pNode = rItems.Item(nStart);
+
+ for (int n = nStart; n <= nEnd && pNode; n++)
+ {
+ if (n == nPos)
+ {
+ ::WinSendMsg( hMenu
+ ,MM_SETITEMATTR
+ ,MPFROM2SHORT(n, TRUE)
+ ,MPFROM2SHORT(MIA_CHECKED, MIA_CHECKED)
+ );
+ }
+ if (n != nPos)
+ {
+ pNode->GetData()->m_isChecked = FALSE;
+ ::WinSendMsg( hMenu
+ ,MM_SETITEMATTR
+ ,MPFROM2SHORT(n, TRUE)
+ ,MPFROM2SHORT(MIA_CHECKED, FALSE)
+ );
+ }
+ pNode = pNode->GetNext();
+ }
+ }
+ else // check item
+ {
+ if (bCheck)
+ bOk = (bool)::WinSendMsg( hMenu
+ ,MM_SETITEMATTR
+ ,MPFROM2SHORT(GetRealId(), TRUE)
+ ,MPFROM2SHORT(MIA_CHECKED, MIA_CHECKED)
+ );
+ else
+ bOk = (bool)::WinSendMsg( hMenu
+ ,MM_SETITEMATTR
+ ,MPFROM2SHORT(GetRealId(), TRUE)
+ ,MPFROM2SHORT(MIA_CHECKED, FALSE)
+ );
+ }
if (!bOk)
{
wxLogLastError("CheckMenuItem");
// Don't do anything if label didn't change
//
- wxString Text = TextToLabel(rText);
- if (m_text == Text)
+ wxString sText = TextToLabel(rText);
+ if (m_text == sText)
return;
- wxMenuItemBase::SetText(Text);
- OWNER_DRAWN_ONLY(wxOwnerDrawn::SetName(Text));
+ wxMenuItemBase::SetText(sText);
+ OWNER_DRAWN_ONLY(wxOwnerDrawn::SetName(sText));
- HWND hMenu = GetHMenuOf(m_parentMenu);
+ HWND hMenu = GetHmenuOf(m_parentMenu);
wxCHECK_RET(hMenu, wxT("menuitem without menu"));
#endif //owner drawn
{
uFlagsOld |= MIS_TEXT;
- pData = (BYTE*)Text.c_str();
+ pData = (BYTE*)sText.c_str();
}
//
projects / wxWidgets.git / blobdiff