fixed memory leak in Accept()

[wxWidgets.git] / src / common / fs_zip.cpp

diff --git a/src/common/fs_zip.cpp b/src/common/fs_zip.cpp
index 706cd05352f97fc565bf9b533d141c7169ebb620..dcce84cc10ad422057bf65d3790923387c76e2ad 100644 (file)
--- a/src/common/fs_zip.cpp
+++ b/src/common/fs_zip.cpp
@@ -61,7 +61,7 @@ wxZipFSHandler::~wxZipFSHandler()
 bool wxZipFSHandler::CanOpen(const wxString& location)
 {
     wxString p = GetProtocol(location);
 bool wxZipFSHandler::CanOpen(const wxString& location)
 {
     wxString p = GetProtocol(location);

-    return (p == wxT("zip") );
+    return (p == wxT("zip"));

 }
 
 
 }
 
 


@@ -73,24 +73,24 @@ wxFSFile* wxZipFSHandler::OpenFile(wxFileSystem& WXUNUSED(fs), const wxString& l
     wxString left = GetLeftLocation(location);
     wxInputStream *s;
 
     wxString left = GetLeftLocation(location);
     wxInputStream *s;
 

-    if (GetProtocol(left) != wxT("file")) {
+    if (GetProtocol(left) != wxT("file")) 
+    {
+        wxLogError(_("ZIP handler currently supports only local files!"));

         return NULL;
     }
 
     s = new wxZipInputStream(left, right);
         return NULL;
     }
 
     s = new wxZipInputStream(left, right);

-    if (s && (s -> LastError() == wxStream_NOERROR)) {
+    if (s && (s->LastError() == wxStream_NOERROR)) 
+    {

         return new wxFSFile(s,
                             left + wxT("#zip:") + right,
                             GetMimeTypeFromExt(location),
                             GetAnchor(location),
                             wxDateTime(wxFileModificationTime(left)));
     }
         return new wxFSFile(s,
                             left + wxT("#zip:") + right,
                             GetMimeTypeFromExt(location),
                             GetAnchor(location),
                             wxDateTime(wxFileModificationTime(left)));
     }

-    else
-    {
-        if (s)
-            delete s;
-        return NULL;
-    }
+
+    delete s;
+    return NULL;

 }
 
 
 }
 
 


@@ -102,19 +102,23 @@ wxString wxZipFSHandler::FindFirst(const wxString& spec, int flags)
     
     if (right.Last() == wxT('/')) right.RemoveLast();
 
     
     if (right.Last() == wxT('/')) right.RemoveLast();
 

-    if (m_Archive) {
+    if (m_Archive) 
+    {

         unzClose((unzFile)m_Archive);
         m_Archive = NULL;
     }
 
         unzClose((unzFile)m_Archive);
         m_Archive = NULL;
     }
 

-    if (GetProtocol(left) != wxT("file")) {
+    if (GetProtocol(left) != wxT("file")) 

         return wxEmptyString;
         return wxEmptyString;

-    }

 
 

-    switch (flags) {
-        case wxFILE  : m_AllowDirs = FALSE, m_AllowFiles = TRUE; break;
-        case wxDIR   : m_AllowDirs = TRUE, m_AllowFiles = FALSE; break;
-        default : m_AllowDirs = m_AllowFiles = TRUE; break;
+    switch (flags) 
+    {
+        case wxFILE: 
+            m_AllowDirs = FALSE, m_AllowFiles = TRUE; break;
+        case wxDIR: 
+            m_AllowDirs = TRUE, m_AllowFiles = FALSE; break;
+        default: 
+            m_AllowDirs = m_AllowFiles = TRUE; break;

     }
 
     m_ZipFile = left;
     }
 
     m_ZipFile = left;


@@ -122,13 +126,16 @@ wxString wxZipFSHandler::FindFirst(const wxString& spec, int flags)
     m_Pattern = right.AfterLast(wxT('/'));
     m_BaseDir = right.BeforeLast(wxT('/'));
 
     m_Pattern = right.AfterLast(wxT('/'));
     m_BaseDir = right.BeforeLast(wxT('/'));
 

-    if (m_Archive) {
-        if (unzGoToFirstFile((unzFile)m_Archive) != UNZ_OK) {
+    if (m_Archive) 
+    {
+        if (unzGoToFirstFile((unzFile)m_Archive) != UNZ_OK) 
+        {

             unzClose((unzFile)m_Archive);
             m_Archive = NULL;        
         }
             unzClose((unzFile)m_Archive);
             m_Archive = NULL;        
         }

+        else return DoFind();

     }
     }

-    return DoFind();
+    return wxEmptyString;

 }
 
 
 }
 
 


@@ -154,7 +161,8 @@ wxString wxZipFSHandler::DoFind()
         unzGetCurrentFileInfo((unzFile)m_Archive, NULL, namebuf, 1024, NULL, 0, NULL, 0);
         for (c = namebuf; *c; c++) if (*c == wxT('\\')) *c = wxT('/');
         fn = namebuf;
         unzGetCurrentFileInfo((unzFile)m_Archive, NULL, namebuf, 1024, NULL, 0, NULL, 0);
         for (c = namebuf; *c; c++) if (*c == wxT('\\')) *c = wxT('/');
         fn = namebuf;

-        if (fn.Last() == wxT('/')) {
+        if (fn.Length() > 0 && fn.Last() == wxT('/')) 
+        {

             fn.RemoveLast();
             wasdir = TRUE;
         }
             fn.RemoveLast();
             wasdir = TRUE;
         }


@@ -163,14 +171,16 @@ wxString wxZipFSHandler::DoFind()
         name = fn.AfterLast(wxT('/'));
         dir = fn.BeforeLast(wxT('/'));
 
         name = fn.AfterLast(wxT('/'));
         dir = fn.BeforeLast(wxT('/'));
 

-        if (dir == m_BaseDir) {
+        if (dir == m_BaseDir) 
+        {

             if (m_AllowFiles && !wasdir && wxMatchWild(m_Pattern, name, FALSE))
                 match = m_ZipFile + wxT("#zip:") + fn;
             if (m_AllowDirs && wasdir && wxMatchWild(m_Pattern, name, FALSE))
                 match = m_ZipFile + wxT("#zip:") + fn;
         }
         
             if (m_AllowFiles && !wasdir && wxMatchWild(m_Pattern, name, FALSE))
                 match = m_ZipFile + wxT("#zip:") + fn;
             if (m_AllowDirs && wasdir && wxMatchWild(m_Pattern, name, FALSE))
                 match = m_ZipFile + wxT("#zip:") + fn;
         }
         

-        if (unzGoToNextFile((unzFile)m_Archive) != UNZ_OK) {
+        if (unzGoToNextFile((unzFile)m_Archive) != UNZ_OK) 
+        {

             unzClose((unzFile)m_Archive);
             m_Archive = NULL;
             break;
             unzClose((unzFile)m_Archive);
             m_Archive = NULL;
             break;