Warning fix and source cleaning.

[wxWidgets.git] / src / common / valgen.cpp

diff --git a/src/common/valgen.cpp b/src/common/valgen.cpp
index caadd90e805cb5c9d1f03f569101068d741af5b4..7119e95c4a864bb8c7b215639d6c5caeb4cc1d70 100644 (file)
--- a/src/common/valgen.cpp
+++ b/src/common/valgen.cpp
@@ -6,10 +6,10 @@
 // Created:     Jan 22 1999
 // RCS-ID:
 // Copyright:   (c) 1999 Kevin Smith
 // Created:     Jan 22 1999
 // RCS-ID:
 // Copyright:   (c) 1999 Kevin Smith

-// Licence:    wxWindows licence
+// Licence:           wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "valgen.h"
 #endif
 
 #pragma implementation "valgen.h"
 #endif
 


@@ -44,15 +44,20 @@
   #include "wx/slider.h"
 #endif
 
   #include "wx/slider.h"
 #endif
 

-#ifndef __WIN16__
+
+  #include "wx/spinctrl.h"
+
+#if wxUSE_SPINBTN

   #include "wx/spinbutt.h"
   #include "wx/spinbutt.h"

+#endif

 #if wxUSE_CHECKLISTBOX
   #include "wx/checklst.h"
 #endif
 #if wxUSE_CHECKLISTBOX
   #include "wx/checklst.h"
 #endif

-#endif

 
 #include "wx/valgen.h"
 
 
 #include "wx/valgen.h"
 

+IMPLEMENT_CLASS(wxGenericValidator, wxValidator)
+

 wxGenericValidator::wxGenericValidator(bool *val)
 {
     Initialize();
 wxGenericValidator::wxGenericValidator(bool *val)
 {
     Initialize();


@@ -78,6 +83,7 @@ wxGenericValidator::wxGenericValidator(wxArrayInt *val)
 }
 
 wxGenericValidator::wxGenericValidator(const wxGenericValidator& val)
 }
 
 wxGenericValidator::wxGenericValidator(const wxGenericValidator& val)

+    : wxValidator()

 {
     Copy(val);
 }
 {
     Copy(val);
 }


@@ -91,18 +97,14 @@ bool wxGenericValidator::Copy(const wxGenericValidator& val)
     m_pString = val.m_pString;
     m_pArrayInt = val.m_pArrayInt;
 
     m_pString = val.m_pString;
     m_pArrayInt = val.m_pArrayInt;
 

-    return TRUE;
-}
-
-wxGenericValidator::~wxGenericValidator()
-{
+    return true;

 }
 
 // Called to transfer data to the window
 bool wxGenericValidator::TransferToWindow(void)
 {
     if ( !m_validatorWindow )
 }
 
 // Called to transfer data to the window
 bool wxGenericValidator::TransferToWindow(void)
 {
     if ( !m_validatorWindow )

-        return FALSE;
+        return false;

 
     // bool controls
 #if wxUSE_CHECKBOX
 
     // bool controls
 #if wxUSE_CHECKBOX


@@ -110,21 +112,21 @@ bool wxGenericValidator::TransferToWindow(void)
     {
         wxCheckBox* pControl = (wxCheckBox*) m_validatorWindow;
         if (m_pBool)
     {
         wxCheckBox* pControl = (wxCheckBox*) m_validatorWindow;
         if (m_pBool)

-       {
-           pControl->SetValue(*m_pBool);
-           return TRUE;
-       }
+        {
+            pControl->SetValue(*m_pBool);
+            return true;
+        }

     } else
 #endif
 #if wxUSE_RADIOBTN
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioButton)) )
     {
         wxRadioButton* pControl = (wxRadioButton*) m_validatorWindow;
     } else
 #endif
 #if wxUSE_RADIOBTN
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioButton)) )
     {
         wxRadioButton* pControl = (wxRadioButton*) m_validatorWindow;

-       if (m_pBool)
-       {
-           pControl->SetValue(*m_pBool) ;
-           return TRUE;
-       }
+        if (m_pBool)
+        {
+            pControl->SetValue(*m_pBool) ;
+            return true;
+        }

     } else
 #endif
 
     } else
 #endif
 


@@ -133,208 +135,217 @@ bool wxGenericValidator::TransferToWindow(void)
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxGauge)) )
     {
         wxGauge* pControl = (wxGauge*) m_validatorWindow;
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxGauge)) )
     {
         wxGauge* pControl = (wxGauge*) m_validatorWindow;

-       if (m_pInt)
-       {
-           pControl->SetValue(*m_pInt);
-           return TRUE;
-       }
+        if (m_pInt)
+        {
+            pControl->SetValue(*m_pInt);
+            return true;
+        }

     } else
 #endif
 #if wxUSE_RADIOBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioBox)) )
     {
         wxRadioBox* pControl = (wxRadioBox*) m_validatorWindow;
     } else
 #endif
 #if wxUSE_RADIOBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioBox)) )
     {
         wxRadioBox* pControl = (wxRadioBox*) m_validatorWindow;

-       if (m_pInt)
-       {
-           pControl->SetSelection(*m_pInt) ;
-           return TRUE;
-       }
+        if (m_pInt)
+        {
+            pControl->SetSelection(*m_pInt) ;
+            return true;
+        }

     } else
 #endif
 #if wxUSE_SCROLLBAR
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxScrollBar)) )
     {
         wxScrollBar* pControl = (wxScrollBar*) m_validatorWindow;
     } else
 #endif
 #if wxUSE_SCROLLBAR
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxScrollBar)) )
     {
         wxScrollBar* pControl = (wxScrollBar*) m_validatorWindow;

-       if (m_pInt)
-       {
-           pControl->SetThumbPosition(*m_pInt) ;
-           return TRUE;
-       }
+        if (m_pInt)
+        {
+            pControl->SetThumbPosition(*m_pInt) ;
+            return true;
+        }
+    } else
+#endif
+#if wxUSE_SPINCTRL && !defined(__WXMOTIF__)
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinCtrl)) )
+    {
+        wxSpinCtrl* pControl = (wxSpinCtrl*) m_validatorWindow;
+        if (m_pInt)
+        {
+            pControl->SetValue(*m_pInt);
+            return true;
+        }

     } else
 #endif
 #if wxUSE_SPINBTN
     } else
 #endif
 #if wxUSE_SPINBTN

-#ifndef __WIN16__

     if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinButton)) )
     {
         wxSpinButton* pControl = (wxSpinButton*) m_validatorWindow;
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinButton)) )
     {
         wxSpinButton* pControl = (wxSpinButton*) m_validatorWindow;

-       if (m_pInt)
-       {
-           pControl->SetValue(*m_pInt) ;
-           return TRUE;
-       }
+        if (m_pInt)
+        {
+            pControl->SetValue(*m_pInt) ;
+            return true;
+        }

     } else
 #endif
     } else
 #endif

-#endif

 #if wxUSE_SLIDER
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxSlider)) )
     {
         wxSlider* pControl = (wxSlider*) m_validatorWindow;
         if (m_pInt)
         {
 #if wxUSE_SLIDER
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxSlider)) )
     {
         wxSlider* pControl = (wxSlider*) m_validatorWindow;
         if (m_pInt)
         {

-           pControl->SetValue(*m_pInt) ;
-           return TRUE;
-       }
+            pControl->SetValue(*m_pInt) ;
+            return true;
+        }

     } else
 #endif
 
     } else
 #endif
 

-  // string controls
-#if 1
+    // string controls
+#if wxUSE_BUTTON

     if (m_validatorWindow->IsKindOf(CLASSINFO(wxButton)) )
     {
         wxButton* pControl = (wxButton*) m_validatorWindow;
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxButton)) )
     {
         wxButton* pControl = (wxButton*) m_validatorWindow;

-       if (m_pString)
-       {
-           pControl->SetLabel(*m_pString) ;
-           return TRUE;
-       }
+        if (m_pString)
+        {
+            pControl->SetLabel(*m_pString) ;
+            return true;
+        }

     } else
 #endif
 #if wxUSE_COMBOBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
     {
         wxComboBox* pControl = (wxComboBox*) m_validatorWindow;
     } else
 #endif
 #if wxUSE_COMBOBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
     {
         wxComboBox* pControl = (wxComboBox*) m_validatorWindow;

-       if (m_pString)
-       {
-           pControl->SetValue(*m_pString) ;
-           return TRUE;
-       }
-    } else
-#endif
-#if wxUSE_CHOICE
-    if (m_validatorWindow->IsKindOf(CLASSINFO(wxChoice)) )
-    {
-        wxChoice* pControl = (wxChoice*) m_validatorWindow;

         if (m_pInt)
         {
             pControl->SetSelection(*m_pInt) ;
         if (m_pInt)
         {
             pControl->SetSelection(*m_pInt) ;

-            return TRUE;
+            return true;

         }
         else if (m_pString)
         {
         }
         else if (m_pString)
         {

-            if (pControl->FindString(* m_pString) > -1)
+            if (pControl->FindString(* m_pString) != wxNOT_FOUND)

             {
                 pControl->SetStringSelection(* m_pString);
             }
             {
                 pControl->SetStringSelection(* m_pString);
             }

-            return TRUE;
+            if ((m_validatorWindow->GetWindowStyle() & wxCB_READONLY) == 0)
+            {
+                pControl->SetValue(* m_pString);
+            }
+            return true;

         }
     } else
 #endif
         }
     } else
 #endif

-    if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
+#if wxUSE_CHOICE
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxChoice)) )

     {
     {

-        wxComboBox* pControl = (wxComboBox*) m_validatorWindow;
+        wxChoice* pControl = (wxChoice*) m_validatorWindow;

         if (m_pInt)
         {
             pControl->SetSelection(*m_pInt) ;
         if (m_pInt)
         {
             pControl->SetSelection(*m_pInt) ;

-            return TRUE;
+            return true;

         }
         else if (m_pString)
         {
         }
         else if (m_pString)
         {

-            if (pControl->FindString(* m_pString) > -1)
+            if (pControl->FindString(* m_pString) != wxNOT_FOUND)

             {
                 pControl->SetStringSelection(* m_pString);
             }
             {
                 pControl->SetStringSelection(* m_pString);
             }

-            return TRUE;
+            return true;

         }
     } else
         }
     } else

+#endif

     if (m_validatorWindow->IsKindOf(CLASSINFO(wxStaticText)) )
     {
         wxStaticText* pControl = (wxStaticText*) m_validatorWindow;
         if (m_pString)
         {
             pControl->SetLabel(*m_pString) ;
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxStaticText)) )
     {
         wxStaticText* pControl = (wxStaticText*) m_validatorWindow;
         if (m_pString)
         {
             pControl->SetLabel(*m_pString) ;

-            return TRUE;
+            return true;

         }
         }

-    } else 
+    } else
+#if wxUSE_TEXTCTRL

     if (m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
     {
         wxTextCtrl* pControl = (wxTextCtrl*) m_validatorWindow;
         if (m_pString)
         {
             pControl->SetValue(*m_pString) ;
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
     {
         wxTextCtrl* pControl = (wxTextCtrl*) m_validatorWindow;
         if (m_pString)
         {
             pControl->SetValue(*m_pString) ;

-            return TRUE;
+            return true;

         }
         else if (m_pInt)
         {
             wxString str;
         }
         else if (m_pInt)
         {
             wxString str;

-            str.Printf("%d", *m_pInt);
+            str.Printf(wxT("%d"), *m_pInt);

             pControl->SetValue(str);
             pControl->SetValue(str);

-            return TRUE;
+            return true;

         }
     } else
         }
     } else

-#if wxUSE_CHECKLISTBOX
-#ifndef __WIN16__
-  // array controls
-  // NOTE: wxCheckListBox isa wxListBox, so wxCheckListBox
-  // MUST come first:
-  if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckListBox)) )
-  {
-    wxCheckListBox* pControl = (wxCheckListBox*) m_validatorWindow;
-       if (m_pArrayInt)
-    {
-      // clear all selections
-      int i;
-      for (i = 0 ; i < pControl->Number(); ++i)
-        pControl->Check(i, FALSE);
-      // select each item in our array
-      unsigned u;
-      for (u = 0; u < m_pArrayInt->Count(); ++u)
-        pControl->Check(m_pArrayInt->Item(u));
-      return TRUE;
-    }
-       else
-               return FALSE;
-  } else

 #endif
 #endif

+    // array controls
+#if wxUSE_CHECKLISTBOX
+    // NOTE: wxCheckListBox is a wxListBox, so wxCheckListBox MUST come first:
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckListBox)) )
+    {
+        wxCheckListBox* pControl = (wxCheckListBox*) m_validatorWindow;
+        if (m_pArrayInt)
+        {
+            // clear all selections
+            size_t i,
+                   count = pControl->GetCount();
+            for ( i = 0 ; i < count; i++ )
+                pControl->Check(i, false);
+
+            // select each item in our array
+            count = m_pArrayInt->GetCount();
+            for ( i = 0 ; i < count; i++ )
+                pControl->Check(m_pArrayInt->Item(i));
+
+            return true;
+        }
+        else
+            return false;
+    } else

 #endif
 #if wxUSE_LISTBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxListBox)) )
     {
         wxListBox* pControl = (wxListBox*) m_validatorWindow;
 #endif
 #if wxUSE_LISTBOX
     if (m_validatorWindow->IsKindOf(CLASSINFO(wxListBox)) )
     {
         wxListBox* pControl = (wxListBox*) m_validatorWindow;

-       if (m_pArrayInt)
-       {
-           // clear all selections
-           int i;
-           for (i = 0 ; i < pControl->Number(); ++i)
-               pControl->Deselect(i);
-           // select each item in our array
-           unsigned u;
-           for (u = 0; u < m_pArrayInt->Count(); ++u)
-               pControl->SetSelection(m_pArrayInt->Item(u));
-           return TRUE;
-       }
+        if (m_pArrayInt)
+        {
+            // clear all selections
+            size_t i,
+                   count = pControl->GetCount();
+            for ( i = 0 ; i < count; i++ )
+                pControl->Deselect(i);
+
+            // select each item in our array
+            count = m_pArrayInt->GetCount();
+            for ( i = 0 ; i < count; i++ )
+                pControl->SetSelection(m_pArrayInt->Item(i));
+
+            return true;
+        }

     } else
 #endif
     } else
 #endif

+        ;   // to match the last 'else' above

 
   // unrecognized control, or bad pointer
 
   // unrecognized control, or bad pointer

-    return FALSE;
-  return FALSE;
+  return false;

 }
 
 // Called to transfer data from the window
 bool wxGenericValidator::TransferFromWindow(void)
 {
   if ( !m_validatorWindow )
 }
 
 // Called to transfer data from the window
 bool wxGenericValidator::TransferFromWindow(void)
 {
   if ( !m_validatorWindow )

-    return FALSE;
+    return false;

 
   // bool controls
 #if wxUSE_CHECKBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckBox)) )
   {
     wxCheckBox* pControl = (wxCheckBox*) m_validatorWindow;
 
   // bool controls
 #if wxUSE_CHECKBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckBox)) )
   {
     wxCheckBox* pControl = (wxCheckBox*) m_validatorWindow;

-       if (m_pBool)
+        if (m_pBool)

     {
       *m_pBool = pControl->GetValue() ;
     {
       *m_pBool = pControl->GetValue() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif


@@ -342,10 +353,10 @@ bool wxGenericValidator::TransferFromWindow(void)
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioButton)) )
   {
     wxRadioButton* pControl = (wxRadioButton*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioButton)) )
   {
     wxRadioButton* pControl = (wxRadioButton*) m_validatorWindow;

-       if (m_pBool)
+        if (m_pBool)

     {
       *m_pBool = pControl->GetValue() ;
     {
       *m_pBool = pControl->GetValue() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif


@@ -354,10 +365,10 @@ bool wxGenericValidator::TransferFromWindow(void)
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxGauge)) )
   {
     wxGauge* pControl = (wxGauge*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxGauge)) )
   {
     wxGauge* pControl = (wxGauge*) m_validatorWindow;

-       if (m_pInt)
+        if (m_pInt)

     {
       *m_pInt = pControl->GetValue() ;
     {
       *m_pInt = pControl->GetValue() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif


@@ -365,10 +376,10 @@ bool wxGenericValidator::TransferFromWindow(void)
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioBox)) )
   {
     wxRadioBox* pControl = (wxRadioBox*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxRadioBox)) )
   {
     wxRadioBox* pControl = (wxRadioBox*) m_validatorWindow;

-       if (m_pInt)
+        if (m_pInt)

     {
       *m_pInt = pControl->GetSelection() ;
     {
       *m_pInt = pControl->GetSelection() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif


@@ -376,61 +387,74 @@ bool wxGenericValidator::TransferFromWindow(void)
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxScrollBar)) )
   {
     wxScrollBar* pControl = (wxScrollBar*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxScrollBar)) )
   {
     wxScrollBar* pControl = (wxScrollBar*) m_validatorWindow;

-       if (m_pInt)
+        if (m_pInt)

     {
       *m_pInt = pControl->GetThumbPosition() ;
     {
       *m_pInt = pControl->GetThumbPosition() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif

+#if wxUSE_SPINCTRL && !defined(__WXMOTIF__)
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinCtrl)) )
+    {
+        wxSpinCtrl* pControl = (wxSpinCtrl*) m_validatorWindow;
+        if (m_pInt)
+        {
+            *m_pInt=pControl->GetValue();
+            return true;
+        }
+    } else
+#endif

 #if wxUSE_SPINBTN
 #if wxUSE_SPINBTN

-#ifndef __WIN16__

   if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinButton)) )
   {
     wxSpinButton* pControl = (wxSpinButton*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxSpinButton)) )
   {
     wxSpinButton* pControl = (wxSpinButton*) m_validatorWindow;

-       if (m_pInt)
+        if (m_pInt)

     {
       *m_pInt = pControl->GetValue() ;
     {
       *m_pInt = pControl->GetValue() ;

-      return TRUE;
+      return true;

     }
   } else
 #endif
     }
   } else
 #endif

-#endif

 #if wxUSE_SLIDER
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxSlider)) )
   {
     wxSlider* pControl = (wxSlider*) m_validatorWindow;
     if (m_pInt)
     {
 #if wxUSE_SLIDER
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxSlider)) )
   {
     wxSlider* pControl = (wxSlider*) m_validatorWindow;
     if (m_pInt)
     {

-      pControl->SetValue(*m_pInt) ;
-      return TRUE;
+      *m_pInt = pControl->GetValue() ;
+      return true;

     }
   } else
 #endif
   // string controls
     }
   } else
 #endif
   // string controls

+#if wxUSE_BUTTON

   if (m_validatorWindow->IsKindOf(CLASSINFO(wxButton)) )
   {
     wxButton* pControl = (wxButton*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxButton)) )
   {
     wxButton* pControl = (wxButton*) m_validatorWindow;

-       if (m_pString)
+        if (m_pString)

     {
       *m_pString = pControl->GetLabel() ;
     {
       *m_pString = pControl->GetLabel() ;

-      return TRUE;
+      return true;

     }
     }

-  }
-  else
+  } else
+#endif

 #if wxUSE_COMBOBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
   {
     wxComboBox* pControl = (wxComboBox*) m_validatorWindow;
 #if wxUSE_COMBOBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
   {
     wxComboBox* pControl = (wxComboBox*) m_validatorWindow;

-       if (m_pString)
+    if (m_pInt)

     {
     {

-      *m_pString = pControl->GetValue() ;
-      return TRUE;
+      *m_pInt = pControl->GetSelection() ;
+      return true;

     }
     else if (m_pString)
     {
     }
     else if (m_pString)
     {

-        *m_pString = pControl->GetStringSelection();
-        return TRUE;
+        if (m_validatorWindow->GetWindowStyle() & wxCB_READONLY)
+            *m_pString = pControl->GetStringSelection();
+        else
+            *m_pString = pControl->GetValue();
+        return true;

     }
   } else
 #endif
     }
   } else
 #endif


@@ -438,100 +462,95 @@ bool wxGenericValidator::TransferFromWindow(void)
  if (m_validatorWindow->IsKindOf(CLASSINFO(wxChoice)) )
   {
     wxChoice* pControl = (wxChoice*) m_validatorWindow;
  if (m_validatorWindow->IsKindOf(CLASSINFO(wxChoice)) )
   {
     wxChoice* pControl = (wxChoice*) m_validatorWindow;

-       if (m_pInt)
+        if (m_pInt)

     {
       *m_pInt = pControl->GetSelection() ;
     {
       *m_pInt = pControl->GetSelection() ;

-      return TRUE;
+      return true;

     }
     else if (m_pString)
     {
         *m_pString = pControl->GetStringSelection();
     }
     else if (m_pString)
     {
         *m_pString = pControl->GetStringSelection();

-        return TRUE;
+        return true;

     }
   } else
 #endif
     }
   } else
 #endif

- if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)) )
-  {
-    wxComboBox* pControl = (wxComboBox*) m_validatorWindow;
-       if (m_pInt)
-    {
-      *m_pInt = pControl->GetSelection() ;
-      return TRUE;
-    }
-    else if (m_pString)
-    {
-        *m_pString = pControl->GetStringSelection();
-        return TRUE;
-    }
-  } else

   if (m_validatorWindow->IsKindOf(CLASSINFO(wxStaticText)) )
   {
     wxStaticText* pControl = (wxStaticText*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxStaticText)) )
   {
     wxStaticText* pControl = (wxStaticText*) m_validatorWindow;

-       if (m_pString)
+        if (m_pString)

     {
       *m_pString = pControl->GetLabel() ;
     {
       *m_pString = pControl->GetLabel() ;

-      return TRUE;
+      return true;

     }
   } else
     }
   } else

+#if wxUSE_TEXTCTRL

   if (m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
   {
     wxTextCtrl* pControl = (wxTextCtrl*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
   {
     wxTextCtrl* pControl = (wxTextCtrl*) m_validatorWindow;

-       if (m_pString)
+        if (m_pString)

     {
       *m_pString = pControl->GetValue() ;
     {
       *m_pString = pControl->GetValue() ;

-      return TRUE;
+      return true;

     }
     else if (m_pInt)
     {
     }
     else if (m_pInt)
     {

-        *m_pInt = atoi(pControl->GetValue());
-        return TRUE;
+        *m_pInt = wxAtoi(pControl->GetValue());
+        return true;

     }
   } else
     }
   } else

-#if wxUSE_CHECKLISTBOX
-#ifndef __WIN16__
+#endif

   // array controls
   // array controls

-  // NOTE: wxCheckListBox isa wxListBox, so wxCheckListBox
-  // MUST come first:
+#if wxUSE_CHECKLISTBOX
+  // NOTE: wxCheckListBox isa wxListBox, so wxCheckListBox MUST come first:

   if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckListBox)) )
   {
     wxCheckListBox* pControl = (wxCheckListBox*) m_validatorWindow;
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxCheckListBox)) )
   {
     wxCheckListBox* pControl = (wxCheckListBox*) m_validatorWindow;

-       if (m_pArrayInt)
+    if (m_pArrayInt)

     {
       // clear our array
       m_pArrayInt->Clear();
     {
       // clear our array
       m_pArrayInt->Clear();

+

       // add each selected item to our array
       // add each selected item to our array

-      int i;
-      for (i = 0 ; i < pControl->Number(); ++i)
+      size_t i,
+             count = pControl->GetCount();
+      for ( i = 0; i < count; i++ )
+      {

         if (pControl->IsChecked(i))
           m_pArrayInt->Add(i);
         if (pControl->IsChecked(i))
           m_pArrayInt->Add(i);

-      return TRUE;
+      }
+
+      return true;

     }
     }

-       else
-         return FALSE;
+    else
+      return false;

   } else
 #endif
   } else
 #endif

-#endif

 #if wxUSE_LISTBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxListBox)) )
   {
     wxListBox* pControl = (wxListBox*) m_validatorWindow;
 #if wxUSE_LISTBOX
   if (m_validatorWindow->IsKindOf(CLASSINFO(wxListBox)) )
   {
     wxListBox* pControl = (wxListBox*) m_validatorWindow;

-       if (m_pArrayInt)
+    if (m_pArrayInt)

     {
       // clear our array
       m_pArrayInt->Clear();
     {
       // clear our array
       m_pArrayInt->Clear();

+

       // add each selected item to our array
       // add each selected item to our array

-      int i;
-      for (i = 0 ; i < pControl->Number(); ++i)
+      size_t i,
+             count = pControl->GetCount();
+      for ( i = 0; i < count; i++ )
+      {

         if (pControl->Selected(i))
           m_pArrayInt->Add(i);
         if (pControl->Selected(i))
           m_pArrayInt->Add(i);

-      return TRUE;
+      }
+
+      return true;

     }
   } else
 #endif
 
   // unrecognized control, or bad pointer
     }
   } else
 #endif
 
   // unrecognized control, or bad pointer

-    return FALSE;
-  return FALSE;
+    return false;
+  return false;

 }
 
 /*
 }
 
 /*