bug in menu accelerators code corrected (don't create empty accel table,

[wxWidgets.git] / src / gtk / choice.cpp

diff --git a/src/gtk/choice.cpp b/src/gtk/choice.cpp
index 8bbf2ab5b2dd9d1a83a78e897365d17049b71af8..f13d20eae3f0582dc56a25c149a4588c1534ead6 100644 (file)
--- a/src/gtk/choice.cpp
+++ b/src/gtk/choice.cpp
@@ -4,7 +4,7 @@
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 
 /////////////////////////////////////////////////////////////////////////////
 
 


@@ -14,6 +14,16 @@
 
 #include "wx/choice.h"
 
 
 #include "wx/choice.h"
 

+#include "gdk/gdk.h"
+#include "gtk/gtk.h"
+
+//-----------------------------------------------------------------------------
+// idle system
+//-----------------------------------------------------------------------------
+
+extern void wxapp_install_idle_handler();
+extern bool g_isIdle;
+

 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------


@@ -26,15 +36,17 @@ extern bool   g_blockEventsOnDrag;
 
 static void gtk_choice_clicked_callback( GtkWidget *WXUNUSED(widget), wxChoice *choice )
 {
 
 static void gtk_choice_clicked_callback( GtkWidget *WXUNUSED(widget), wxChoice *choice )
 {

-  if (!choice->HasVMT()) return;
-  if (g_blockEventsOnDrag) return;
-  
-  wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, choice->GetId() );
-  event.SetInt( choice->GetSelection() );
-  wxString tmp( choice->GetStringSelection() );
-  event.SetString( WXSTRINGCAST(tmp) );
-  event.SetEventObject(choice);
-  choice->GetEventHandler()->ProcessEvent(event);
+    if (g_isIdle) wxapp_install_idle_handler();
+
+    if (!choice->m_hasVMT) return;
+
+    if (g_blockEventsOnDrag) return;
+
+    wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, choice->GetId() );
+    event.SetInt( choice->GetSelection() );
+    event.SetString( choice->GetStringSelection() );
+    event.SetEventObject(choice);
+    choice->GetEventHandler()->ProcessEvent(event);

 }
 
 //-----------------------------------------------------------------------------
 }
 
 //-----------------------------------------------------------------------------


@@ -53,52 +65,53 @@ bool wxChoice::Create( wxWindow *parent, wxWindowID id,
                        long style, const wxValidator& validator, const wxString &name )
 {
     m_needParent = TRUE;
                        long style, const wxValidator& validator, const wxString &name )
 {
     m_needParent = TRUE;

-  
+#if (GTK_MINOR_VERSION > 0)
+    m_acceptsFocus = TRUE;
+#endif
+

     PreCreation( parent, id, pos, size, style, name );
     PreCreation( parent, id, pos, size, style, name );

-    
+

     SetValidator( validator );
 
     m_widget = gtk_option_menu_new();
     SetValidator( validator );
 
     m_widget = gtk_option_menu_new();

-  
-    wxSize newSize = size;
-    if (newSize.x == -1) newSize.x = 80;
-    if (newSize.y == -1) newSize.y = 26;
+
+    wxSize newSize(size);
+    if (newSize.x == -1)
+        newSize.x = 80;
+    if (newSize.y == -1)
+        newSize.y = 26;

     SetSize( newSize.x, newSize.y );
     SetSize( newSize.x, newSize.y );

-  
+

     GtkWidget *menu = gtk_menu_new();
     GtkWidget *menu = gtk_menu_new();

-  
+

     for (int i = 0; i < n; i++)
     {
         m_clientDataList.Append( (wxObject*) NULL );
         m_clientObjectList.Append( (wxObject*) NULL );
     for (int i = 0; i < n; i++)
     {
         m_clientDataList.Append( (wxObject*) NULL );
         m_clientObjectList.Append( (wxObject*) NULL );

-  
-        GtkWidget *item = gtk_menu_item_new_with_label( choices[i] );
+
+        GtkWidget *item = gtk_menu_item_new_with_label( choices[i].mbc_str() );

         gtk_menu_append( GTK_MENU(menu), item );
         gtk_menu_append( GTK_MENU(menu), item );

-    
-        gtk_widget_realize( item );
-        gtk_widget_realize( GTK_BIN(item)->child );
-    
+

         gtk_widget_show( item );
         gtk_widget_show( item );

-    
-        gtk_signal_connect( GTK_OBJECT( item ), "activate", 
+
+        gtk_signal_connect( GTK_OBJECT( item ), "activate",

           GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this );
     }
     gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu );
           GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this );
     }
     gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu );

-  
-    m_parent->AddChild( this );

 
 

-    (m_parent->m_insertCallback)( m_parent, this );
-  
+    m_parent->DoAddChild( this );
+

     PostCreation();
     PostCreation();

-  
+

     SetBackgroundColour( parent->GetBackgroundColour() );
     SetForegroundColour( parent->GetForegroundColour() );
     SetBackgroundColour( parent->GetBackgroundColour() );
     SetForegroundColour( parent->GetForegroundColour() );

+    SetFont( parent->GetFont() );

 
     Show( TRUE );
 
     Show( TRUE );

-    
+

     return TRUE;
 }
     return TRUE;
 }

-      
+

 wxChoice::~wxChoice()
 {
     Clear();
 wxChoice::~wxChoice()
 {
     Clear();


@@ -106,21 +119,24 @@ wxChoice::~wxChoice()
 
 void wxChoice::AppendCommon( const wxString &item )
 {
 
 void wxChoice::AppendCommon( const wxString &item )
 {

-    wxCHECK_RET( m_widget != NULL, "invalid choice" );
-  
+    wxCHECK_RET( m_widget != NULL, _T("invalid choice") );
+

     GtkWidget *menu = gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) );
     GtkWidget *menu = gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) );

-    GtkWidget *menu_item = gtk_menu_item_new_with_label( item );
-  
+    GtkWidget *menu_item = gtk_menu_item_new_with_label( item.mbc_str() );
+

     gtk_menu_append( GTK_MENU(menu), menu_item );
     gtk_menu_append( GTK_MENU(menu), menu_item );

-  
-    gtk_widget_realize( menu_item );
-    gtk_widget_realize( GTK_BIN(menu_item)->child );
-  
-    if (m_widgetStyle) ApplyWidgetStyle();
-  
-    gtk_signal_connect( GTK_OBJECT( menu_item ), "activate", 
+
+    if (GTK_WIDGET_REALIZED(m_widget))
+    {
+        gtk_widget_realize( menu_item );
+        gtk_widget_realize( GTK_BIN(menu_item)->child );
+
+        if (m_widgetStyle) ApplyWidgetStyle();
+    }
+
+    gtk_signal_connect( GTK_OBJECT( menu_item ), "activate",

       GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this );
       GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this );

-    
+

     gtk_widget_show( menu_item );
 }
 
     gtk_widget_show( menu_item );
 }
 


@@ -128,7 +144,7 @@ void wxChoice::Append( const wxString &item )
 {
     m_clientDataList.Append( (wxObject*) NULL );
     m_clientObjectList.Append( (wxObject*) NULL );
 {
     m_clientDataList.Append( (wxObject*) NULL );
     m_clientObjectList.Append( (wxObject*) NULL );

-  
+

     AppendCommon( item );
 }
 
     AppendCommon( item );
 }
 


@@ -136,7 +152,7 @@ void wxChoice::Append( const wxString &item, void *clientData )
 {
     m_clientDataList.Append( (wxObject*) clientData );
     m_clientObjectList.Append( (wxObject*) NULL );
 {
     m_clientDataList.Append( (wxObject*) clientData );
     m_clientObjectList.Append( (wxObject*) NULL );

-  
+

     AppendCommon( item );
 }
 
     AppendCommon( item );
 }
 


@@ -144,61 +160,61 @@ void wxChoice::Append( const wxString &item, wxClientData *clientData )
 {
     m_clientObjectList.Append( (wxObject*) clientData );
     m_clientDataList.Append( (wxObject*) NULL );
 {
     m_clientObjectList.Append( (wxObject*) clientData );
     m_clientDataList.Append( (wxObject*) NULL );

-  
+

     AppendCommon( item );
 }
 
 void wxChoice::SetClientData( int n, void* clientData )
 {
     AppendCommon( item );
 }
 
 void wxChoice::SetClientData( int n, void* clientData )
 {

-    wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-  
+    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+

     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return;
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return;

-  
+

     node->SetData( (wxObject*) clientData );
 }
 
 void* wxChoice::GetClientData( int n )
 {
     node->SetData( (wxObject*) clientData );
 }
 
 void* wxChoice::GetClientData( int n )
 {

-    wxCHECK_MSG( m_widget != NULL, NULL, "invalid combobox" );
-  
+    wxCHECK_MSG( m_widget != NULL, NULL, _T("invalid combobox") );
+

     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return NULL;
     wxNode *node = m_clientDataList.Nth( n );
     if (!node) return NULL;

-    
+

     return node->Data();
 }
 
 void wxChoice::SetClientObject( int n, wxClientData* clientData )
 {
     return node->Data();
 }
 
 void wxChoice::SetClientObject( int n, wxClientData* clientData )
 {

-    wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-    
+    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+

     wxNode *node = m_clientObjectList.Nth( n );
     if (!node) return;
     wxNode *node = m_clientObjectList.Nth( n );
     if (!node) return;

-  
+

     wxClientData *cd = (wxClientData*) node->Data();
     if (cd) delete cd;
     wxClientData *cd = (wxClientData*) node->Data();
     if (cd) delete cd;

-    
+

     node->SetData( (wxObject*) clientData );
 }
 
 wxClientData* wxChoice::GetClientObject( int n )
 {
     node->SetData( (wxObject*) clientData );
 }
 
 wxClientData* wxChoice::GetClientObject( int n )
 {

-    wxCHECK_MSG( m_widget != NULL, (wxClientData*) NULL, "invalid combobox" );
-  
+    wxCHECK_MSG( m_widget != NULL, (wxClientData*) NULL, _T("invalid combobox") );
+

     wxNode *node = m_clientObjectList.Nth( n );
     if (!node) return (wxClientData*) NULL;
     wxNode *node = m_clientObjectList.Nth( n );
     if (!node) return (wxClientData*) NULL;

-    
+

     return (wxClientData*) node->Data();
 }
     return (wxClientData*) node->Data();
 }

- 
+

 void wxChoice::Clear()
 {
 void wxChoice::Clear()
 {

-    wxCHECK_RET( m_widget != NULL, "invalid choice" );
+    wxCHECK_RET( m_widget != NULL, _T("invalid choice") );

 
     gtk_option_menu_remove_menu( GTK_OPTION_MENU(m_widget) );
     GtkWidget *menu = gtk_menu_new();
     gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu );
 
     gtk_option_menu_remove_menu( GTK_OPTION_MENU(m_widget) );
     GtkWidget *menu = gtk_menu_new();
     gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu );

-    
+

     wxNode *node = m_clientObjectList.First();
     while (node)
     {
     wxNode *node = m_clientObjectList.First();
     while (node)
     {


@@ -207,22 +223,22 @@ void wxChoice::Clear()
         node = node->Next();
     }
     m_clientObjectList.Clear();
         node = node->Next();
     }
     m_clientObjectList.Clear();

-    
+

     m_clientDataList.Clear();
 }
 
 void wxChoice::Delete( int WXUNUSED(n) )
 {
     m_clientDataList.Clear();
 }
 
 void wxChoice::Delete( int WXUNUSED(n) )
 {

-    wxFAIL_MSG( "wxChoice:Delete not implemented" );
+    wxFAIL_MSG( _T("wxChoice:Delete not implemented") );

 }
 
 int wxChoice::FindString( const wxString &string ) const
 {
 }
 
 int wxChoice::FindString( const wxString &string ) const
 {

-    wxCHECK_MSG( m_widget != NULL, -1, "invalid choice" );
+    wxCHECK_MSG( m_widget != NULL, -1, _T("invalid choice") );

 
     // If you read this code once and you think you understand
     // it, then you are very wrong. Robert Roebling.
 
     // If you read this code once and you think you understand
     // it, then you are very wrong. Robert Roebling.

-  
+

     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;
     GList *child = menu_shell->children;
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;
     GList *child = menu_shell->children;


@@ -232,16 +248,16 @@ int wxChoice::FindString( const wxString &string ) const
         GtkLabel *label = (GtkLabel *) NULL;
         if (bin->child) label = GTK_LABEL(bin->child);
         if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child );
         GtkLabel *label = (GtkLabel *) NULL;
         if (bin->child) label = GTK_LABEL(bin->child);
         if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child );

-    
-        wxASSERT_MSG( label != NULL , "wxChoice: invalid label" );
-    
-       if (string == label->label) return count;
+
+        wxASSERT_MSG( label != NULL , _T("wxChoice: invalid label") );
+
+       if (string == label->label)
+           return count;
+

        child = child->next;
        count++;
     }
        child = child->next;
        count++;
     }

-  
-    wxFAIL_MSG( "wxChoice: string not found" );
-  
+

     return -1;
 }
 
     return -1;
 }
 


@@ -252,7 +268,7 @@ int wxChoice::GetColumns() const
 
 int wxChoice::GetSelection()
 {
 
 int wxChoice::GetSelection()
 {

-    wxCHECK_MSG( m_widget != NULL, -1, "invalid choice" );
+    wxCHECK_MSG( m_widget != NULL, -1, _T("invalid choice") );

 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;
 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;


@@ -264,15 +280,15 @@ int wxChoice::GetSelection()
         child = child->next;
         count++;
     }
         child = child->next;
         count++;
     }

-  
-    wxFAIL_MSG( "wxChoice: no selection" );
-  
+
+    wxFAIL_MSG( _T("wxChoice: no selection") );
+

     return -1;
 }
 
 wxString wxChoice::GetString( int n ) const
 {
     return -1;
 }
 
 wxString wxChoice::GetString( int n ) const
 {

-    wxCHECK_MSG( m_widget != NULL, "", "invalid choice" );
+    wxCHECK_MSG( m_widget != NULL, _T(""), _T("invalid choice") );

 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;
 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;


@@ -285,34 +301,34 @@ wxString wxChoice::GetString( int n ) const
             GtkLabel *label = (GtkLabel *) NULL;
             if (bin->child) label = GTK_LABEL(bin->child);
             if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child );
             GtkLabel *label = (GtkLabel *) NULL;
             if (bin->child) label = GTK_LABEL(bin->child);
             if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child );

-      
-            wxASSERT_MSG( label != NULL , "wxChoice: invalid label" );
-      
+
+            wxASSERT_MSG( label != NULL , _T("wxChoice: invalid label") );
+

             return label->label;
         }
         child = child->next;
         count++;
     }
             return label->label;
         }
         child = child->next;
         count++;
     }

-  
-    wxFAIL_MSG( "wxChoice: string not found" );
-  
+
+    wxFAIL_MSG( _T("wxChoice: invalid index in GetString()") );
+

     return "";
 }
 
 wxString wxChoice::GetStringSelection() const
 {
     return "";
 }
 
 wxString wxChoice::GetStringSelection() const
 {

-    wxCHECK_MSG( m_widget != NULL, "", "invalid choice" );
+    wxCHECK_MSG( m_widget != NULL, _T(""), _T("invalid choice") );

 
     GtkLabel *label = GTK_LABEL( GTK_BUTTON(m_widget)->child );
 
     GtkLabel *label = GTK_LABEL( GTK_BUTTON(m_widget)->child );

-  
-    wxASSERT_MSG( label != NULL , "wxChoice: invalid label" );
-  
+
+    wxASSERT_MSG( label != NULL , _T("wxChoice: invalid label") );
+

     return label->label;
 }
 
 int wxChoice::Number() const
 {
     return label->label;
 }
 
 int wxChoice::Number() const
 {

-    wxCHECK_MSG( m_widget != NULL, 0, "invalid choice" );
+    wxCHECK_MSG( m_widget != NULL, 0, _T("invalid choice") );

 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;
 
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     int count = 0;


@@ -331,17 +347,17 @@ void wxChoice::SetColumns( int WXUNUSED(n) )
 
 void wxChoice::SetSelection( int n )
 {
 
 void wxChoice::SetSelection( int n )
 {

-    wxCHECK_RET( m_widget != NULL, "invalid choice" );
+    wxCHECK_RET( m_widget != NULL, _T("invalid choice") );

 
     int tmp = n;
     gtk_option_menu_set_history( GTK_OPTION_MENU(m_widget), (gint)tmp );
 
     int tmp = n;
     gtk_option_menu_set_history( GTK_OPTION_MENU(m_widget), (gint)tmp );

-  
+

     gtk_choice_clicked_callback( (GtkWidget *) NULL, this );
 }
 
 void wxChoice::SetStringSelection( const wxString &string )
 {
     gtk_choice_clicked_callback( (GtkWidget *) NULL, this );
 }
 
 void wxChoice::SetStringSelection( const wxString &string )
 {

-    wxCHECK_RET( m_widget != NULL, "invalid choice" );
+    wxCHECK_RET( m_widget != NULL, _T("invalid choice") );

 
     int n = FindString( string );
     if (n != -1) SetSelection( n );
 
     int n = FindString( string );
     if (n != -1) SetSelection( n );


@@ -350,24 +366,24 @@ void wxChoice::SetStringSelection( const wxString &string )
 void wxChoice::ApplyWidgetStyle()
 {
     SetWidgetStyle();
 void wxChoice::ApplyWidgetStyle()
 {
     SetWidgetStyle();

-  
+

     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );
     GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) );

-  
+

     gtk_widget_set_style( m_widget, m_widgetStyle );
     gtk_widget_set_style( GTK_WIDGET( menu_shell ), m_widgetStyle );
     gtk_widget_set_style( m_widget, m_widgetStyle );
     gtk_widget_set_style( GTK_WIDGET( menu_shell ), m_widgetStyle );

-  
+

     GList *child = menu_shell->children;
     while (child)
     {
         gtk_widget_set_style( GTK_WIDGET( child->data ), m_widgetStyle );
     GList *child = menu_shell->children;
     while (child)
     {
         gtk_widget_set_style( GTK_WIDGET( child->data ), m_widgetStyle );

-    
+

         GtkBin *bin = GTK_BIN( child->data );
         GtkWidget *label = (GtkWidget *) NULL;
         if (bin->child) label = bin->child;
         if (!label) label = GTK_BUTTON(m_widget)->child;
         GtkBin *bin = GTK_BIN( child->data );
         GtkWidget *label = (GtkWidget *) NULL;
         if (bin->child) label = bin->child;
         if (!label) label = GTK_BUTTON(m_widget)->child;

-    
+

         gtk_widget_set_style( label, m_widgetStyle );
         gtk_widget_set_style( label, m_widgetStyle );

-    
+

         child = child->next;
     }
 }
         child = child->next;
     }
 }