avoid setting initial position if it was not specified, broken in r70734

[wxWidgets.git] / src / html / m_span.cpp

diff --git a/src/html/m_span.cpp b/src/html/m_span.cpp
index 50660bd4f18e63eb42da6c7c80cab5497ea9aef3..bb9e9facc57b0c80e376516ed6d5fdea0f4c1f5a 100644 (file)
--- a/src/html/m_span.cpp
+++ b/src/html/m_span.cpp
@@ -2,7 +2,6 @@
 // Name:        src/html/m_span.cpp
 // Purpose:     wxHtml module for span handling
 // Author:      Nigel Paton
-// RCS-ID:      $Id$
 // Copyright:   wxWidgets team
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
@@ -45,108 +44,7 @@ TAG_HANDLER_BEGIN(SPAN, "SPAN" )
         // Load any style parameters
         wxHtmlStyleParams styleParams(tag);
 
-        wxString str;
-
-        str = styleParams.GetParam(wxS("color"));
-        if ( !str.empty() )
-        {
-            wxColour clr;
-            if ( wxHtmlTag::ParseAsColour(str, &clr) )
-            {
-                m_WParser->SetActualColor(clr);
-                m_WParser->GetContainer()->InsertCell(new wxHtmlColourCell(clr));
-            }
-        }
-
-        str = styleParams.GetParam(wxS("background-color"));
-        if ( !str.empty() )
-        {
-            wxColour clr;
-            if ( wxHtmlTag::ParseAsColour(str, &clr) )
-            {
-                m_WParser->SetActualBackgroundColor(clr);
-                m_WParser->SetActualBackgroundMode(wxBRUSHSTYLE_SOLID);
-                m_WParser->GetContainer()->InsertCell(new wxHtmlColourCell(clr, wxHTML_CLR_BACKGROUND));
-            }
-        }
-
-        str = styleParams.GetParam(wxS("font-size"));
-        if ( !str.empty() )
-        {
-            // Point size
-            int foundIndex = str.Find(wxS("pt"));
-            if (foundIndex != wxNOT_FOUND)
-            {
-                str.Truncate(foundIndex);
-
-                long sizeValue;
-                if (str.ToLong(&sizeValue) == true)
-                {
-                    // Set point size
-                    m_WParser->SetFontPointSize(sizeValue);
-                    m_WParser->GetContainer()->InsertCell(
-                         new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-                }
-            }
-            // else: check for other ways of specifying size (TODO)
-        }
-
-        str = styleParams.GetParam(wxS("font-weight"));
-        if ( !str.empty() )
-        {
-            // Only bold and normal supported just now
-            if ( str == wxS("bold") )
-            {
-                m_WParser->SetFontBold(true);
-                m_WParser->GetContainer()->InsertCell(
-                     new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-            }
-            else if ( str == wxS("normal") )
-            {
-                m_WParser->SetFontBold(false);
-                m_WParser->GetContainer()->InsertCell(
-                     new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-            }
-        }
-
-        str = styleParams.GetParam(wxS("font-style"));
-        if ( !str.empty() )
-        {
-            // "oblique" and "italic" are more or less the same.
-            // "inherit" (using the parent font) is not supported.
-            if ( str == wxS("oblique") || str == wxS("italic") )
-            {
-                m_WParser->SetFontItalic(true);
-                m_WParser->GetContainer()->InsertCell(
-                     new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-            }
-            else if ( str == wxS("normal") )
-            {
-                m_WParser->SetFontItalic(false);
-                m_WParser->GetContainer()->InsertCell(
-                     new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-            }
-        }
-
-        str = styleParams.GetParam(wxS("text-decoration"));
-        if ( !str.empty() )
-        {
-            // Only underline is supported.
-            if ( str == wxS("underline") )
-            {
-                m_WParser->SetFontUnderlined(true);
-                m_WParser->GetContainer()->InsertCell(
-                     new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-            }
-        }
-
-        str = styleParams.GetParam(wxS("font-family"));
-        if ( !str.empty() )
-        {
-            m_WParser->SetFontFace(str);
-            m_WParser->GetContainer()->InsertCell(
-                 new wxHtmlFontCell(m_WParser->CreateCurrentFont()));
-        }
+        ApplyStyle(styleParams);
 
         ParseInner(tag);
 
@@ -171,7 +69,7 @@ TAG_HANDLER_BEGIN(SPAN, "SPAN" )
             m_WParser->SetActualBackgroundMode(oldbackmode);
             m_WParser->SetActualBackgroundColor(oldbackclr);
             m_WParser->GetContainer()->InsertCell(
-                new wxHtmlColourCell(oldbackclr, oldbackmode == wxBRUSHSTYLE_TRANSPARENT ? wxHTML_CLR_TRANSPARENT_BACKGROUND : wxHTML_CLR_BACKGROUND));
+                new wxHtmlColourCell(oldbackclr, oldbackmode == wxTRANSPARENT ? wxHTML_CLR_TRANSPARENT_BACKGROUND : wxHTML_CLR_BACKGROUND));
         }
 
         return true;