#include "wx/wxprec.h"
#ifndef WX_PRECOMP
+ #include "wx/app.h"
#include "wx/frame.h"
#include "wx/menu.h"
#include "wx/utils.h"
IMPLEMENT_DYNAMIC_CLASS(wxMenu, wxEvtHandler)
IMPLEMENT_DYNAMIC_CLASS(wxMenuBar, wxEvtHandler)
+// ----------------------------------------------------------------------------
+// static function for translating menu labels
+// ----------------------------------------------------------------------------
+
+static wxString TextToLabel(const wxString& rTitle)
+{
+ wxString Title;
+ const wxChar *pc;
+ for (pc = rTitle; *pc != wxT('\0'); pc++ )
+ {
+ if (*pc == wxT('&') )
+ {
+ if (*(pc+1) == wxT('&'))
+ {
+ pc++;
+ Title << wxT('&');
+ }
+ else
+ Title << wxT('~');
+ }
+// else if (*pc == wxT('/'))
+// {
+// Title << wxT('\\');
+// }
+ else
+ {
+ if ( *pc == wxT('~') )
+ {
+ // tildes must be doubled to prevent them from being
+ // interpreted as accelerator character prefix by PM ???
+ Title << *pc;
+ }
+ Title << *pc;
+ }
+ }
+ return Title;
+}
+
// ============================================================================
// implementation
// ============================================================================
,0L
,NULL
,NULL
- )) != 0)
+ )) == 0)
{
wxLogLastError("WinLoadMenu");
}
+ m_vMenuData.iPosition = 0;
+ m_vMenuData.afStyle = MIS_SUBMENU | MIS_TEXT;
+ m_vMenuData.afAttribute = (USHORT)0;
+ m_vMenuData.id = (USHORT)0;
+ m_vMenuData.hwndSubMenu = m_hMenu;
+ m_vMenuData.hItem = NULLHANDLE;
//
// If we have a title, insert it in the beginning of the menu
, size_t nPos
)
{
+ ERRORID vError;
+ wxString sError;
+ MENUITEM vItem;
+
#if wxUSE_ACCEL
UpdateAccel(pItem);
#endif // wxUSE_ACCEL
+ memset(&vItem, '\0', sizeof(vItem));
+
//
// If "Break" has just been called, insert a menu break before this item
// (and don't forget to reset the flag)
//
if (m_bDoBreak)
{
- m_vMenuData.afStyle |= MIS_BREAK;
+ vItem.afStyle |= MIS_BREAK;
m_bDoBreak = FALSE;
}
+ //
+ // Menu items that are being inserted into a submenu MUST have a
+ // MENUITEM structure separate from the parent menu so we must use
+ // a local vItem not the object's m_vMenuItem as that is the MENUITEM
+ // associated with the parent submenu.
+ //
if (pItem->IsSeparator())
{
- m_vMenuData.afStyle |= MIS_SEPARATOR;
+ vItem.afStyle |= MIS_SEPARATOR;
}
//
// Id is the numeric id for normal menu items and HMENU for submenus as
- // required by ::WinInsertMenu() API
+ // required by ::MM_INSERTITEM message API
//
wxMenu* pSubmenu = pItem->GetSubMenu();
wxASSERT_MSG(pSubmenu->GetHMenu(), wxT("invalid submenu"));
pSubmenu->SetParent(this);
- m_vMenuData.iPosition = 0; // submenus have a 0 position
- m_vMenuData.id = (USHORT)pSubmenu->GetHMenu();
- m_vMenuData.afStyle |= MIS_SUBMENU;
+ vItem.iPosition = 0; // submenus have a 0 position
+ vItem.id = (USHORT)pSubmenu->GetHMenu();
+ vItem.afStyle |= MIS_SUBMENU | MIS_TEXT;
}
else
{
- m_vMenuData.id = pItem->GetId();
+ vItem.id = pItem->GetId();
}
BYTE* pData;
//
// Want to get {Measure|Draw}Item messages?
// item draws itself, pass pointer to it in data parameter
- // Will eventually need to set the image handle somewhere into m_vMenuData.hItem
+ // Will eventually need to set the image handle somewhere into vItem.hItem
//
- m_vMenuData.afStyle |= MIS_OWNERDRAW;
+ vItem.afStyle |= MIS_OWNERDRAW;
pData = (BYTE*)pItem;
+ // vItem.hItem = ????
}
else
#endif
//
// Menu is just a normal string (passed in data parameter)
//
- m_vMenuData.afStyle |= MIS_TEXT;
+ vItem.afStyle |= MIS_TEXT;
pData = (char*)pItem->GetText().c_str();
}
- BOOL bOk;
+ APIRET rc;
- //
- // -1 means this is a sub menu not a menuitem. We must create a window for it.
- // Submenus are also attached to a menubar so its parent and owner should be the handle of the menubar.
- //
- if (nPos == (size_t)-1)
+ if (pSubmenu == NULL)
{
- HWND hSubMenu = ::WinCreateWindow( GetWinHwnd(m_menuBar) // parent
- ,WC_MENU // type
- ,"Menu" // a generic name
- ,0L // no style flag
- ,0L,0L,0L,0L // no position
- ,GetWinHwnd(m_menuBar) // no owner
- ,HWND_TOP // always on top
- ,0L // no ID needed for dynamic creation
- ,NULL // no control data
- ,NULL // no presentation params
- );
-
- m_vMenuData.iPosition = 0;
- m_vMenuData.hwndSubMenu = hSubMenu;
- m_vMenuData.hItem = NULLHANDLE;
-
- bOk = (bool)::WinSendMsg(GetHmenu(), MM_INSERTITEM, (MPARAM)&m_vMenuData, (MPARAM)pItem->GetText().c_str());
- }
- else
- {
- m_vMenuData.iPosition = nPos;
- m_vMenuData.hwndSubMenu = NULLHANDLE;
- m_vMenuData.hItem = NULLHANDLE;
- bOk = (bool)::WinSendMsg(GetHmenu(), MM_INSERTITEM, (MPARAM)&m_vMenuData, (MPARAM)pItem->GetText().c_str());
+ //
+ // -1 means append at end
+ //
+ if (nPos == (size_t)-1)
+ {
+ vItem.iPosition = MIT_END;
+ }
+ else
+ {
+ vItem.iPosition = nPos;
+ }
}
- if (!bOk)
+ rc = (APIRET)::WinSendMsg(GetHmenu(), MM_INSERTITEM, (MPARAM)&vItem, (MPARAM)pData);
+ if (rc == MIT_MEMERROR || rc == MIT_ERROR)
{
+ vError = ::WinGetLastError(vHabmain);
+ sError = wxPMErrorToStr(vError);
+ wxLogError("Error inserting or appending a menuitem. Error: %s\n", sError);
wxLogLastError("Insert or AppendMenu");
return FALSE;
}
{
MENUITEM vItem;
HWND hFrame;
+ HWND hMenuBar = NULLHANDLE;
if (m_hMenu != 0 )
return m_hMenu;
{
size_t nCount = GetMenuCount();
+ hMenuBar = GetHwnd();
for (size_t i = 0; i < nCount; i++)
{
- vItem.iPosition = 0;
- vItem.afStyle = MIS_SUBMENU | MIS_TEXT;
- vItem.afAttribute = (USHORT)0;
- vItem.id = (USHORT)0;
- vItem.hwndSubMenu = m_menus[i]->GetHMenu();
- vItem.hItem = NULLHANDLE;
-
- ::WinSendMsg(GetHmenu(), MM_INSERTITEM, (MPARAM)&vItem, (MPARAM)m_titles[i].c_str());
+ APIRET rc;
+ ERRORID vError;
+ wxString sError;
+ MENUITEM vItem;
+
+ //
+ // Set the parent and owner of the submenues to be the menubar, not the desktop
+ //
+ if (!::WinSetParent(m_menus[i]->m_vMenuData.hwndSubMenu, hMenuBar, FALSE))
+ {
+ vError = ::WinGetLastError(vHabmain);
+ sError = wxPMErrorToStr(vError);
+ wxLogError("Error setting parent for submenu. Error: %s\n", sError);
+ return NULLHANDLE;
+ }
+
+ if (!::WinSetOwner(m_menus[i]->m_vMenuData.hwndSubMenu, hMenuBar))
+ {
+ vError = ::WinGetLastError(vHabmain);
+ sError = wxPMErrorToStr(vError);
+ wxLogError("Error setting parent for submenu. Error: %s\n", sError);
+ return NULLHANDLE;
+ }
+
+ rc = (APIRET)::WinSendMsg(hMenuBar, MM_INSERTITEM, (MPARAM)&m_menus[i]->m_vMenuData, (MPARAM)m_titles[i].c_str());
+ if (rc == MIT_MEMERROR || rc == MIT_ERROR)
+ {
+ vError = ::WinGetLastError(vHabmain);
+ sError = wxPMErrorToStr(vError);
+ wxLogError("Error inserting or appending a menuitem. Error: %s\n", sError);
+ return NULLHANDLE;
+ }
}
}
- return m_hMenu;
+ return hMenuBar;
} // end of wxMenuBar::Create
// ---------------------------------------------------------------------------
)
{
SHORT nId;
+ wxString Title = TextToLabel(rTitle);
wxMenu* pMenuOld = wxMenuBarBase::Replace( nPos
,pMenu
- ,rTitle
+ ,Title
);
}
if (!pMenuOld)
return FALSE;
- m_titles[nPos] = rTitle;
+ m_titles[nPos] = Title;
if (IsAttached())
{
::WinSendMsg((HWND)m_hMenu, MM_DELETEITEM, MPFROM2SHORT(nId, TRUE), (MPARAM)0);
- ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)rTitle.c_str());
+ ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)Title.c_str());
#if wxUSE_ACCEL
if (pMenuOld->HasAccels() || pMenu->HasAccels())
, const wxString& rTitle
)
{
+ wxString Title = TextToLabel(rTitle);
if (!wxMenuBarBase::Insert( nPos
,pMenu
- ,rTitle
+ ,Title
))
return FALSE;
- m_titles.Insert( rTitle
+ m_titles.Insert( Title
,nPos
);
if (IsAttached())
{
- ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)rTitle.c_str());
+ ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)Title.c_str());
#if wxUSE_ACCEL
if (pMenu->HasAccels())
{
wxCHECK_MSG(hSubmenu, FALSE, wxT("can't append invalid menu to menubar"));
- if (!wxMenuBarBase::Append(pMenu, rTitle))
+ wxString Title = TextToLabel(rTitle);
+ if (!wxMenuBarBase::Append(pMenu, Title))
return FALSE;
pMenu->Attach(this);
- m_titles.Add(rTitle);
+ m_titles.Add(Title);
if ( IsAttached() )
{
pMenu->m_vMenuData.iPosition = MIT_END;
- ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)rTitle.c_str());
+ ::WinSendMsg((HWND)m_hMenu, MM_INSERTITEM, (MPARAM)&pMenu->m_vMenuData, (MPARAM)Title.c_str());
#if wxUSE_ACCEL
if (pMenu->HasAccels())
{
projects / wxWidgets.git / blobdiff