Added wxList:Nth check again

[wxWidgets.git] / src / generic / imaglist.cpp

diff --git a/src/generic/imaglist.cpp b/src/generic/imaglist.cpp
index ad91a211e0a2032cc6c46fc18f031283b1a4b3a3..29ad9cdb7518cef1650a9f7b324d4083bbd23181 100644 (file)
--- a/src/generic/imaglist.cpp
+++ b/src/generic/imaglist.cpp
@@ -21,9 +21,9 @@ IMPLEMENT_DYNAMIC_CLASS(wxImageList, wxObject)
 
 wxImageList::wxImageList( int width, int height, bool WXUNUSED(mask), int WXUNUSED(initialCount) )
 {
-  m_width = width;
-  m_height = height;
-  Create();
+    m_width = width;
+    m_height = height;
+    Create();
 }
 
 wxImageList::~wxImageList()
@@ -32,90 +32,97 @@ wxImageList::~wxImageList()
 
 int wxImageList::GetImageCount() const
 {
-  return m_images.Number();
+    return m_images.Number();
 }
 
 bool wxImageList::Create()
 {
-  m_images.DeleteContents( TRUE );
-  return TRUE;
+    m_images.DeleteContents( TRUE );
+    return TRUE;
 }
 
 int wxImageList::Add( const wxBitmap &bitmap )
 {
-  m_images.Append( new wxBitmap(bitmap) );
-  return m_images.Number();
+    m_images.Append( new wxBitmap(bitmap) );
+    return m_images.Number();
 }
 
-const wxBitmap *wxImageList::GetBitmap(int index) const {
-  wxNode *node = m_images.Nth(index);
-  if (node != NULL)
+const wxBitmap *wxImageList::GetBitmap( int index ) const 
+{
+    wxNode *node = m_images.Nth( index );
+    
+    wxCHECK_MSG( node, (wxBitmap *) NULL, "wrong index in image list" );
+    
     return (wxBitmap*)node->Data();
-
-  return (wxBitmap *) NULL;
 }
     
 bool wxImageList::Replace( int index, const wxBitmap &bitmap )
 {
-  wxNode *node = m_images.Nth( index );
-  if (!node) return FALSE;
+    wxNode *node = m_images.Nth( index );
+    
+    wxCHECK_MSG( node, FALSE, "wrong index in image list" );
   
-  if (index == m_images.Number()-1)
-  {
-    m_images.DeleteNode( node );
-    m_images.Append( new wxBitmap(bitmap) );
-  }
-  else
-  {
-    wxNode *next = node->Next();
-    m_images.DeleteNode( node );
-    m_images.Insert( next, new wxBitmap(bitmap) );
-  }
+    if (index == m_images.Number()-1)
+    {
+        m_images.DeleteNode( node );
+        m_images.Append( new wxBitmap(bitmap) );
+    }
+    else
+    {
+        wxNode *next = node->Next();
+        m_images.DeleteNode( node );
+        m_images.Insert( next, new wxBitmap(bitmap) );
+    }
   
-  return TRUE;
+    return TRUE;
 }
 
 bool wxImageList::Remove( int index )
 {
-  wxNode *node = m_images.Nth( index );
-  if (node) m_images.DeleteNode( node );
-  return (node != NULL);
+    wxNode *node = m_images.Nth( index );
+    
+    wxCHECK_MSG( node, FALSE, "wrong index in image list" );
+    
+    m_images.DeleteNode( node );
+     
+    return TRUE;
 }
 
 bool wxImageList::RemoveAll()
 {
-  m_images.Clear();
-  return TRUE;
+    m_images.Clear();
+    
+    return TRUE;
 }
 
 bool wxImageList::GetSize( int index, int &width, int &height ) const
 {
-  wxNode *node = m_images.Nth( index );
-  if (node)
-  {
+    width = 0;
+    height = 0;
+    
+    wxNode *node = m_images.Nth( index );
+    
+    wxCHECK_MSG( node, FALSE, "wrong index in image list" );
+    
     wxBitmap *bm = (wxBitmap*)node->Data();
     width = bm->GetWidth();
     height = bm->GetHeight();
+    
     return TRUE;
-  }
-  else
-  {
-    width = 0;
-    height = 0;
-    return FALSE;
-  }
 }
 
 bool wxImageList::Draw( int index, wxDC &dc, int x, int y,
                         int flags, bool WXUNUSED(solidBackground) )
 {
-  wxNode *node = m_images.Nth( index );
-  if (!node) return FALSE;
-  wxBitmap *bm = (wxBitmap*)node->Data();
+    wxNode *node = m_images.Nth( index );
+    
+    wxCHECK_MSG( node, FALSE, "wrong index in image list" );
+    
+    wxBitmap *bm = (wxBitmap*)node->Data();
   
-  dc.DrawBitmap( *bm, x, y, (flags & wxIMAGELIST_DRAW_TRANSPARENT) > 0 );
+    dc.DrawBitmap( *bm, x, y, (flags & wxIMAGELIST_DRAW_TRANSPARENT) > 0 );
 
-  return TRUE;
+    return TRUE;
 }