int style)
: wxDialog(parent, -1, title)
{
+ // we may disappear at any moment, let the others know about it
+ SetExtraStyle(GetExtraStyle() | wxWS_EX_TRANSIENT);
+
m_windowStyle |= style;
bool hasAbortButton = (style & wxPD_CAN_ABORT) != 0;
+
+#if defined(__WXMSW__) && !defined(__WXUNIVERSAL__)
+ // we have to remove the "Close" button from the title bar then as it is
+ // confusing to have it - it doesn't work anyhow
+ //
+ // FIXME: should probably have a (extended?) window style for this
+ if ( !hasAbortButton )
+ {
+ EnableCloseButton(FALSE);
+ }
+#endif // wxMSW
+
m_state = hasAbortButton ? Continue : Uncancelable;
m_maximum = maximum;
+#ifdef __WXMSW__
+ // we can't have values > 65,536 in the progress control under Windows, so
+ // scale everything down
+ m_factor = m_maximum / 65536 + 1;
+ m_maximum /= m_factor;
+#endif // __WXMSW__
+
m_parentTop = parent;
while ( m_parentTop && m_parentTop->GetParent() )
{
c->height.AsIs();
m_msg->SetConstraints(c);
- wxSize sizeDlg, sizeLabel = m_msg->GetSize();
+ wxSize sizeDlg,
+ sizeLabel = m_msg->GetSize();
sizeDlg.y = 2*LAYOUT_Y_MARGIN + sizeLabel.y;
wxWindow *lastWindow = m_msg;
if ( maximum > 0 )
{
- m_gauge = new wxGauge(this, -1, maximum,
- wxDefaultPosition, wxDefaultSize,
- wxGA_HORIZONTAL | wxRAISED_BORDER);
-// Sorry, but wxGA_SMOOTH happens to also mean wxDIALOG_MODAL and will
-// cause the dialog to be modal. Have an extra style argument to wxProgressDialog,
-// perhaps.
-// wxGA_HORIZONTAL | wxRAISED_BORDER | (style & wxGA_SMOOTH));
+ // note that we can't use wxGA_SMOOTH because it happens to also mean
+ // wxDIALOG_MODAL and will cause the dialog to be modal. Have an extra
+ // style argument to wxProgressDialog, perhaps.
+ m_gauge = new wxGauge(this, -1, m_maximum,
+ wxDefaultPosition, wxDefaultSize,
+ wxGA_HORIZONTAL);
+
c = new wxLayoutConstraints;
c->left.SameAs(this, wxLeft, 2*LAYOUT_X_MARGIN);
c->top.Below(m_msg, 2*LAYOUT_Y_MARGIN);
// create the estimated/remaining/total time zones if requested
m_elapsed = m_estimated = m_remaining = (wxStaticText*)NULL;
- int nTimeLabels = 0;
+ // if we are going to have at least one label, remmeber it in this var
+ wxStaticText *label = NULL;
+
+ // also count how many labels we really have
+ size_t nTimeLabels = 0;
+
if ( style & wxPD_ELAPSED_TIME )
{
nTimeLabels++;
+ label =
m_elapsed = CreateLabel(_("Elapsed time : "), &lastWindow);
}
{
nTimeLabels++;
+ label =
m_estimated = CreateLabel(_("Estimated time : "), &lastWindow);
}
{
nTimeLabels++;
+ label =
m_remaining = CreateLabel(_("Remaining time : "), &lastWindow);
}
{
// set it to the current time
m_timeStart = wxGetCurrentTime();
- sizeDlg.y += nTimeLabels * (sizeLabel.y + LAYOUT_Y_MARGIN);
+ sizeDlg.y += nTimeLabels * (label->GetSize().y + LAYOUT_Y_MARGIN);
}
if ( hasAbortButton )
Show(TRUE);
Enable(TRUE); // enable this window
+ // this one can be initialized even if the others are unknown for now
+ //
+ // NB: do it after calling Layout() to keep the labels correctly aligned
+ if ( m_elapsed )
+ {
+ SetTimeLabel(0, m_elapsed);
+ }
+
// Update the display (especially on X, GTK)
wxYield();
wxProgressDialog::Update(int value, const wxString& newmsg)
{
wxASSERT_MSG( value == -1 || m_gauge, wxT("cannot update non existent dialog") );
+
+#ifdef __WXMSW__
+ value /= m_factor;
+#endif // __WXMSW__
+
wxASSERT_MSG( value <= m_maximum, wxT("invalid progress value") );
if ( m_gauge )
+ {
m_gauge->SetValue(value + 1);
+ }
if ( !newmsg.IsEmpty() )
{
-#ifdef __WXMSW__
- // this seems to be necessary or garbage is left when the new label is
- // longer than the old one
- m_msg->SetLabel(wxEmptyString);
-#endif // MSW
-
m_msg->SetLabel(newmsg);
wxYield();
SetTimeLabel(remaining, m_remaining);
}
- if ( (value == m_maximum ) && !(GetWindowStyle() & wxPD_AUTO_HIDE) )
+ if ( (value == m_maximum ) )
{
- if ( m_btnAbort )
+ // so that we return TRUE below and that out [Cancel] handler knew what
+ // to do
+ m_state = Finished;
+ if( !(GetWindowStyle() & wxPD_AUTO_HIDE) )
{
- // tell the user what he should do...
- m_btnAbort->SetLabel(_("Close"));
+ if ( m_btnAbort )
+ {
+ // tell the user what he should do...
+ m_btnAbort->SetLabel(_("Close"));
+ }
+#if defined(__WXMSW__) && !defined(__WXUNIVERSAL__)
+ else // enable the close button to give the user a way to close the dlg
+ {
+ EnableCloseButton(TRUE);
+ }
+#endif // __WXMSW__
+
+ if ( !newmsg )
+ {
+ // also provide the finishing message if the application didn't
+ m_msg->SetLabel(_("Done."));
+ }
+
+ wxYield();
+
+ (void)ShowModal();
}
-
- if ( !newmsg )
+ else
{
- // also provide the finishing message if the application didn't
- m_msg->SetLabel(_("Done."));
+ Hide();
+ ReenableOtherWindows();
}
-
- // so that we return TRUE below and that out [Cancel] handler knew what
- // to do
- m_state = Finished;
-
- wxYield();
-
- (void)ShowModal();
}
else
{