Fix crash in wxDC::GetMultiLineTextExtent() after last commit.

[wxWidgets.git] / src / gtk / tglbtn.cpp

diff --git a/src/gtk/tglbtn.cpp b/src/gtk/tglbtn.cpp
index cc2f7db78dd19a801d2604718df237a0954b487e..1ad831108f722b2d0940672ffb5be01132251d2d 100644 (file)
--- a/src/gtk/tglbtn.cpp
+++ b/src/gtk/tglbtn.cpp
@@ -7,7 +7,7 @@
 // Created:     08.02.01
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Johnny C. Norris II
 // Created:     08.02.01
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Johnny C. Norris II

-// License:     wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 // For compilers that support precompilation, includes "wx.h".
 /////////////////////////////////////////////////////////////////////////////
 
 // For compilers that support precompilation, includes "wx.h".


@@ -21,12 +21,7 @@
     #include "wx/button.h"
 #endif
 
     #include "wx/button.h"
 #endif
 

-// FIXME: Use GtkImage instead of GtkPixmap.
-#include <gtk/gtkversion.h>
-#ifdef GTK_DISABLE_DEPRECATED
-#undef GTK_DISABLE_DEPRECATED
-#endif
-
+#include <gtk/gtk.h>

 #include "wx/gtk/private.h"
 
 extern bool      g_blockEventsOnDrag;
 #include "wx/gtk/private.h"
 
 extern bool      g_blockEventsOnDrag;


@@ -34,174 +29,47 @@ extern bool      g_blockEventsOnDrag;
 extern "C" {
 static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxToggleButton *cb)
 {
 extern "C" {
 static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxToggleButton *cb)
 {

-    if (g_isIdle)
-        wxapp_install_idle_handler();
-
-    if (!cb->m_hasVMT || g_blockEventsOnDrag)
+    if (g_blockEventsOnDrag)

         return;
 
         return;
 

-    if (cb->m_blockEvent) return;
-

     // Generate a wx event.
     wxCommandEvent event(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, cb->GetId());
     event.SetInt(cb->GetValue());
     event.SetEventObject(cb);
     // Generate a wx event.
     wxCommandEvent event(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, cb->GetId());
     event.SetInt(cb->GetValue());
     event.SetEventObject(cb);

-    cb->GetEventHandler()->ProcessEvent(event);
+    cb->HandleWindowEvent(event);

 }
 }
 
 }
 }
 

-DEFINE_EVENT_TYPE(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED)
+wxDEFINE_EVENT( wxEVT_COMMAND_TOGGLEBUTTON_CLICKED, wxCommandEvent );

 
 // ------------------------------------------------------------------------
 
 // ------------------------------------------------------------------------

-// wxToggleBitmapButton
+// wxBitmapToggleButton

 // ------------------------------------------------------------------------
 
 // ------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxToggleBitmapButton, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxBitmapToggleButton, wxToggleButton)

 
 

-bool wxToggleBitmapButton::Create(wxWindow *parent, wxWindowID id,
-                            const wxBitmap &label, const wxPoint &pos,
+bool wxBitmapToggleButton::Create(wxWindow *parent, wxWindowID id,
+                            const wxBitmap &bitmap, const wxPoint &pos,

                             const wxSize &size, long style,
                             const wxValidator& validator,
                             const wxString &name)
 {
                             const wxSize &size, long style,
                             const wxValidator& validator,
                             const wxString &name)
 {

-    m_needParent = true;
-    m_acceptsFocus = true;
-
-    m_blockEvent = false;
-
-    if (!PreCreation(parent, pos, size) ||
-       !CreateBase(parent, id, pos, size, style, validator, name ))
-    {
-        wxFAIL_MSG(wxT("wxToggleBitmapButton creation failed"));
+    if ( !wxToggleButton::Create(parent, id, wxEmptyString, pos, size, style | wxBU_NOTEXT | wxBU_EXACTFIT,
+                                 validator, name) )

         return false;
         return false;

-    }
-
-    m_bitmap = label;
-
-    // Create the gtk widget.
-    m_widget = gtk_toggle_button_new();

 
 

-    if (style & wxNO_BORDER)
-       gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );
-
-    if (m_bitmap.Ok())
+    if ( bitmap.IsOk() )

     {
     {

-        OnSetBitmap();
-    }
-
-    g_signal_connect (m_widget, "clicked",
-                      G_CALLBACK (gtk_togglebutton_clicked_callback),
-                      this);
-
-    m_parent->DoAddChild(this);
-
-    PostCreation(size);
-
-    return true;
-}
-
-// void SetValue(bool state)
-// Set the value of the toggle button.
-void wxToggleBitmapButton::SetValue(bool state)
-{
-    wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
-
-    if (state == GetValue())
-        return;
-
-    m_blockEvent = true;
-
-    gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
-
-    m_blockEvent = false;
-}
+        SetBitmapLabel(bitmap);

 
 

-// bool GetValue() const
-// Get the value of the toggle button.
-bool wxToggleBitmapButton::GetValue() const
-{
-    wxCHECK_MSG(m_widget != NULL, false, wxT("invalid toggle button"));
-
-    return GTK_TOGGLE_BUTTON(m_widget)->active;
-}
-
-void wxToggleBitmapButton::SetLabel(const wxBitmap& label)
-{
-    wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
-
-    m_bitmap = label;
-    InvalidateBestSize();
-
-    OnSetBitmap();
-}
-
-void wxToggleBitmapButton::OnSetBitmap()
-{
-    if (!m_bitmap.Ok()) return;
-
-    GdkBitmap *mask = (GdkBitmap *) NULL;
-    if (m_bitmap.GetMask()) mask = m_bitmap.GetMask()->GetBitmap();
-
-    GtkWidget *child = GTK_BIN(m_widget)->child;
-    if (child == NULL)
-    {
-        // initial bitmap
-        GtkWidget *pixmap = gtk_pixmap_new(m_bitmap.GetPixmap(), mask);
-        gtk_widget_show(pixmap);
-        gtk_container_add(GTK_CONTAINER(m_widget), pixmap);
+        // we need to adjust the size after setting the bitmap as it may be too
+        // big for the default button size
+        SetInitialSize(size);

     }
     }

-    else
-    {   // subsequent bitmaps
-        GtkPixmap *g_pixmap = GTK_PIXMAP(child);
-        gtk_pixmap_set(g_pixmap, m_bitmap.GetPixmap(), mask);
-    }
-}
-
-bool wxToggleBitmapButton::Enable(bool enable /*=true*/)
-{
-    if (!wxControl::Enable(enable))
-        return false;
-
-    gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);

 
     return true;
 }
 
 
     return true;
 }
 

-void wxToggleBitmapButton::DoApplyWidgetStyle(GtkRcStyle *style)
-{
-    gtk_widget_modify_style(m_widget, style);
-    gtk_widget_modify_style(GTK_BIN(m_widget)->child, style);
-}
-
-GdkWindow *
-wxToggleBitmapButton::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const
-{
-    return GTK_BUTTON(m_widget)->event_window;
-}
-
-// Get the "best" size for this control.
-wxSize wxToggleBitmapButton::DoGetBestSize() const
-{
-    wxSize best;
-
-    if (m_bitmap.Ok())
-    {
-        int border = HasFlag(wxNO_BORDER) ? 4 : 10;
-        best.x = m_bitmap.GetWidth()+border;
-        best.y = m_bitmap.GetHeight()+border;
-    }
-    CacheBestSize(best);
-    return best;
-}
-
-
-// static
-wxVisualAttributes
-wxToggleBitmapButton::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
-{
-    return GetDefaultAttributesFromGTKWidget(gtk_toggle_button_new);
-}
-

 
 // ------------------------------------------------------------------------
 // wxToggleButton
 
 // ------------------------------------------------------------------------
 // wxToggleButton


@@ -215,21 +83,35 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
                             const wxValidator& validator,
                             const wxString &name)
 {
                             const wxValidator& validator,
                             const wxString &name)
 {

-    m_needParent = true;
-    m_acceptsFocus = true;
-
-    m_blockEvent = false;
-

     if (!PreCreation(parent, pos, size) ||
     if (!PreCreation(parent, pos, size) ||

-        !CreateBase(parent, id, pos, size, style, validator, name )) {
+        !CreateBase(parent, id, pos, size, style, validator, name ))
+    {

         wxFAIL_MSG(wxT("wxToggleButton creation failed"));
         return false;
     }
 
         wxFAIL_MSG(wxT("wxToggleButton creation failed"));
         return false;
     }
 

-    wxControl::SetLabel(label);
+    // create either a standard toggle button with text label (which may still contain
+    // an image under GTK+ 2.6+) or a bitmap-only toggle button if we don't have any
+    // label
+    const bool
+        useLabel = !(style & wxBU_NOTEXT) && !label.empty();
+    if ( useLabel )
+    {
+        m_widget = gtk_toggle_button_new_with_mnemonic("");
+    }
+    else // no label, suppose we will have a bitmap
+    {
+        m_widget = gtk_toggle_button_new();
+
+        GtkWidget *image = gtk_image_new();
+        gtk_widget_show(image);
+        gtk_container_add(GTK_CONTAINER(m_widget), image);
+    }
+
+    g_object_ref(m_widget);

 
 

-    // Create the gtk widget.
-    m_widget = gtk_toggle_button_new_with_label( wxGTK_CONV( m_label ) );
+    if ( useLabel )
+        SetLabel(label);

 
     g_signal_connect (m_widget, "clicked",
                       G_CALLBACK (gtk_togglebutton_clicked_callback),
 
     g_signal_connect (m_widget, "clicked",
                       G_CALLBACK (gtk_togglebutton_clicked_callback),


@@ -242,6 +124,18 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
     return true;
 }
 
     return true;
 }
 

+void wxToggleButton::GTKDisableEvents()
+{
+    g_signal_handlers_block_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+
+void wxToggleButton::GTKEnableEvents()
+{
+    g_signal_handlers_unblock_by_func(m_widget,
+                                (gpointer) gtk_togglebutton_clicked_callback, this);
+}
+

 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxToggleButton::SetValue(bool state)
 // void SetValue(bool state)
 // Set the value of the toggle button.
 void wxToggleButton::SetValue(bool state)


@@ -251,11 +145,11 @@ void wxToggleButton::SetValue(bool state)
     if (state == GetValue())
         return;
 
     if (state == GetValue())
         return;
 

-    m_blockEvent = true;
+    GTKDisableEvents();

 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 
 
     gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
 

-    m_blockEvent = false;
+    GTKEnableEvents();

 }
 
 // bool GetValue() const
 }
 
 // bool GetValue() const


@@ -264,44 +158,69 @@ bool wxToggleButton::GetValue() const
 {
     wxCHECK_MSG(m_widget != NULL, false, wxT("invalid toggle button"));
 
 {
     wxCHECK_MSG(m_widget != NULL, false, wxT("invalid toggle button"));
 

-    return GTK_TOGGLE_BUTTON(m_widget)->active;
+    return gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(m_widget)) != 0;

 }
 
 void wxToggleButton::SetLabel(const wxString& label)
 {
     wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
 
 }
 
 void wxToggleButton::SetLabel(const wxString& label)
 {
     wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
 

-    wxControl::SetLabel(label);
+    wxAnyButton::SetLabel(label);

 
 

-    gtk_label_set_text(GTK_LABEL(GTK_BIN(m_widget)->child), wxGTK_CONV(GetLabel()));
+    if ( HasFlag(wxBU_NOTEXT) )
+    {
+        // Don't try to update the label for a button not showing it, this is
+        // unnecessary and can also actually replace the image we show with the
+        // label entirely breaking the button code, see #13693.
+        return;
+    }
+
+    const wxString labelGTK = GTKConvertMnemonics(label);
+
+    gtk_button_set_label(GTK_BUTTON(m_widget), wxGTK_CONV(labelGTK));
+
+    GTKApplyWidgetStyle( false );

 }
 
 }
 

-bool wxToggleButton::Enable(bool enable /*=true*/)
+#if wxUSE_MARKUP
+bool wxToggleButton::DoSetLabelMarkup(const wxString& markup)

 {
 {

-    if (!wxControl::Enable(enable))
+    wxCHECK_MSG( m_widget != NULL, false, "invalid toggle button" );
+
+    const wxString stripped = RemoveMarkup(markup);
+    if ( stripped.empty() && !markup.empty() )

         return false;
 
         return false;
 

-    gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
+    wxControl::SetLabel(stripped);
+
+    if ( !HasFlag(wxBU_NOTEXT) )
+    {
+        GtkLabel * const label = GTKGetLabel();
+        wxCHECK_MSG( label, false, "no label in this toggle button?" );
+
+        GTKSetLabelWithMarkupForLabel(label, markup);
+    }

 
     return true;
 }
 
     return true;
 }

+#endif // wxUSE_MARKUP

 
 

-void wxToggleButton::DoApplyWidgetStyle(GtkRcStyle *style)
+GtkLabel *wxToggleButton::GTKGetLabel() const

 {
 {

-    gtk_widget_modify_style(m_widget, style);
-    gtk_widget_modify_style(GTK_BIN(m_widget)->child, style);
+    GtkWidget* child = gtk_bin_get_child(GTK_BIN(m_widget));
+    return GTK_LABEL(child);

 }
 
 }
 

-GdkWindow *
-wxToggleButton::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const
+void wxToggleButton::DoApplyWidgetStyle(GtkRcStyle *style)

 {
 {

-    return GTK_BUTTON(m_widget)->event_window;
+    GTKApplyStyle(m_widget, style);
+    GTKApplyStyle(gtk_bin_get_child(GTK_BIN(m_widget)), style);

 }
 
 // Get the "best" size for this control.
 wxSize wxToggleButton::DoGetBestSize() const
 {
 }
 
 // Get the "best" size for this control.
 wxSize wxToggleButton::DoGetBestSize() const
 {

-    wxSize ret(wxControl::DoGetBestSize());
+    wxSize ret(wxAnyButton::DoGetBestSize());

 
     if (!HasFlag(wxBU_EXACTFIT))
     {
 
     if (!HasFlag(wxBU_EXACTFIT))
     {