Applied patch [ 681893 ] Combobox in toolbar

[wxWidgets.git] / src / mac / notebmac.cpp

diff --git a/src/mac/notebmac.cpp b/src/mac/notebmac.cpp
index ab97b53540b24c151b69b20fc22d884988edb2c2..aae205f86b13f1cdde9aa5da6e513c7282be1cca 100644 (file)
--- a/src/mac/notebmac.cpp
+++ b/src/mac/notebmac.cpp
@@ -9,6 +9,10 @@
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 

+#ifdef __GNUG__
+  #pragma implementation "notebook.h"
+#endif
+

 // ============================================================================
 // declarations
 // ============================================================================
 // ============================================================================
 // declarations
 // ============================================================================


@@ -16,15 +20,12 @@
 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------

-#ifdef __GNUG__
-#pragma implementation "notebook.h"
-#endif
-
-#include  <wx/string.h>
-#include  <wx/log.h>
-#include  <wx/imaglist.h>
-#include  <wx/notebook.h>
-#include <wx/mac/uma.h>
+#include "wx/app.h"
+#include "wx/string.h"
+#include "wx/log.h"
+#include "wx/imaglist.h"
+#include "wx/notebook.h"
+#include "wx/mac/uma.h"

 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------


@@ -32,19 +33,25 @@
 // check that the page index is valid
 #define IS_VALID_PAGE(nPage) (((nPage) >= 0) && ((nPage) < GetPageCount()))
 
 // check that the page index is valid
 #define IS_VALID_PAGE(nPage) (((nPage) >= 0) && ((nPage) < GetPageCount()))
 

-const short kwxMacTabLeftMargin = 16 ;
-const short kwxMacTabTopMargin = 30 ;
-const short kwxMacTabRightMargin = 16 ;
-const short kwxMacTabBottomMargin = 16 ;
+static bool constantsSet = false ;
+
+ short kwxMacTabLeftMargin = 0 ;
+ short kwxMacTabTopMargin = 0 ;
+ short kwxMacTabRightMargin = 0 ;
+ short kwxMacTabBottomMargin = 0 ;

 
 // ----------------------------------------------------------------------------
 // event table
 // ----------------------------------------------------------------------------
 
 #if !USE_SHARED_LIBRARIES
 
 // ----------------------------------------------------------------------------
 // event table
 // ----------------------------------------------------------------------------
 
 #if !USE_SHARED_LIBRARIES

+DEFINE_EVENT_TYPE(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED)
+DEFINE_EVENT_TYPE(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGING)
+

 BEGIN_EVENT_TABLE(wxNotebook, wxControl)
     EVT_NOTEBOOK_PAGE_CHANGED(-1, wxNotebook::OnSelChange)
 BEGIN_EVENT_TABLE(wxNotebook, wxControl)
     EVT_NOTEBOOK_PAGE_CHANGED(-1, wxNotebook::OnSelChange)

-
+    EVT_MOUSE_EVENTS(wxNotebook::OnMouse)
+    

     EVT_SIZE(wxNotebook::OnSize)
     EVT_SET_FOCUS(wxNotebook::OnSetFocus)
     EVT_NAVIGATION_KEY(wxNotebook::OnNavigationKey)
     EVT_SIZE(wxNotebook::OnSize)
     EVT_SET_FOCUS(wxNotebook::OnSetFocus)
     EVT_NAVIGATION_KEY(wxNotebook::OnNavigationKey)


@@ -65,7 +72,31 @@ IMPLEMENT_DYNAMIC_CLASS(wxNotebookEvent, wxCommandEvent)
 // common part of all ctors
 void wxNotebook::Init()
 {
 // common part of all ctors
 void wxNotebook::Init()
 {

-    m_pImageList = NULL;
+    if ( !constantsSet )
+    {
+        if ( UMAHasAquaLayout() )
+        {
+      // I got these values for Mac OS X from the Appearance mgr docs. (Mark Newsam)
+            kwxMacTabLeftMargin = 20 ;
+            kwxMacTabTopMargin = 38 ;
+            kwxMacTabRightMargin = 20 ;
+            kwxMacTabBottomMargin = 12 ;
+        }
+        else
+        {
+            kwxMacTabLeftMargin = 16 ;
+            kwxMacTabTopMargin = 30 ;
+            kwxMacTabRightMargin = 16 ;
+            kwxMacTabBottomMargin = 16 ;
+        }
+        constantsSet = true ;
+    }
+    if ( UMAHasAquaLayout() )
+    {
+        m_macHorizontalBorder = 7;
+        m_macVerticalBorder = 8;
+    }
+

     m_nSelection = -1;
 }
 
     m_nSelection = -1;
 }
 


@@ -101,8 +132,17 @@ bool wxNotebook::Create(wxWindow *parent,
        
        MacPreControlCreate( parent , id ,  "" , pos , size ,style, wxDefaultValidator , name , &bounds , title ) ;
 
        
        MacPreControlCreate( parent , id ,  "" , pos , size ,style, wxDefaultValidator , name , &bounds , title ) ;
 

-       m_macControl = UMANewControl( parent->GetMacRootWindow() , &bounds , title , true , 0 , 0 , 1, 
-               kControlTabSmallProc , (long) this ) ;
+       int tabstyle = kControlTabSmallNorthProc ;
+       if ( HasFlag(wxNB_LEFT) )
+               tabstyle = kControlTabSmallWestProc ;
+       else if ( HasFlag( wxNB_RIGHT ) )
+               tabstyle = kControlTabSmallEastProc ;
+       else if ( HasFlag( wxNB_BOTTOM ) )
+               tabstyle = kControlTabSmallSouthProc ;
+
+
+       m_macControl = ::NewControl( MAC_WXHWND(parent->MacGetRootWindow()) , &bounds , title , false , 0 , 0 , 1, 
+               tabstyle , (long) this ) ;

        
        MacPostControlCreate() ;
        return TRUE ;
        
        MacPostControlCreate() ;
        return TRUE ;


@@ -114,104 +154,138 @@ wxNotebook::~wxNotebook()
        m_macControl = NULL ;
 }
 
        m_macControl = NULL ;
 }
 

+wxSize wxNotebook::CalcSizeFromPage(const wxSize& sizePage)
+{
+    wxSize sizeTotal = sizePage;
+    
+    int major,minor;
+    wxGetOsVersion( &major, &minor );
+    
+    // Mac has large notebook borders. Aqua even more so.
+
+    if ( HasFlag(wxNB_LEFT) || HasFlag(wxNB_RIGHT) )
+    {
+        sizeTotal.x += 90;
+        
+        if (major >= 10)
+            sizeTotal.y += 28;
+        else
+            sizeTotal.y += 20;
+    }
+    else
+    {
+        if (major >= 10)
+        {
+            sizeTotal.x += 34;
+            sizeTotal.y += 46;
+        }
+        else
+        {
+            sizeTotal.x += 22;
+            sizeTotal.y += 44;
+        }
+    }
+
+    return sizeTotal;
+}
+

 // ----------------------------------------------------------------------------
 // wxNotebook accessors
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // wxNotebook accessors
 // ----------------------------------------------------------------------------

-int wxNotebook::GetPageCount() const
+
+void wxNotebook::SetPadding(const wxSize& padding)

 {
 {

-    return m_aPages.Count();
+   wxFAIL_MSG( wxT("wxNotebook::SetPadding not implemented") );

 }
 
 }
 

-int wxNotebook::GetRowCount() const
+void wxNotebook::SetTabSize(const wxSize& sz)

 {
 {

-    return 1;
+    wxFAIL_MSG( wxT("wxNotebook::SetTabSize not implemented") );
+}
+
+void wxNotebook::SetPageSize(const wxSize& size)
+{
+    wxFAIL_MSG( wxT("wxNotebook::SetPageSize not implemented") );

 }
 
 int wxNotebook::SetSelection(int nPage)
 {
 }
 
 int wxNotebook::SetSelection(int nPage)
 {

-    wxASSERT( IS_VALID_PAGE(nPage) );
+  if( !IS_VALID_PAGE(nPage) ) 
+    return m_nSelection ;

 
     ChangePage(m_nSelection, nPage);
 
     ChangePage(m_nSelection, nPage);

-               SetControlValue( m_macControl , m_nSelection + 1 ) ;
-//     Boolean enabled = true ;
-       
-//     SetControlData( m_macControl, m_nSelection + 1, kControlTabEnabledFlagTag, sizeof( Boolean ), (Ptr)&enabled );
-    return m_nSelection;
-}
+       SetControl32BitValue( (ControlHandle) m_macControl , m_nSelection + 1 ) ;

 
 

-void wxNotebook::AdvanceSelection(bool bForward)
-{
-    int nSel = GetSelection();
-    int nMax = GetPageCount() - 1;
-    if ( bForward )
-        SetSelection(nSel == nMax ? 0 : nSel + 1);
-    else
-        SetSelection(nSel == 0 ? nMax : nSel - 1);
+    Refresh();
+    return m_nSelection;

 }
 
 bool wxNotebook::SetPageText(int nPage, const wxString& strText)
 {
     wxASSERT( IS_VALID_PAGE(nPage) );
 
 }
 
 bool wxNotebook::SetPageText(int nPage, const wxString& strText)
 {
     wxASSERT( IS_VALID_PAGE(nPage) );
 

-    // TODO
-    return FALSE;
+    wxNotebookPage *page = m_pages[nPage];
+    page->SetLabel(strText);
+    MacSetupTabs();
+
+    return true;

 }
 
 wxString wxNotebook::GetPageText(int nPage) const
 {
     wxASSERT( IS_VALID_PAGE(nPage) );
 
 }
 
 wxString wxNotebook::GetPageText(int nPage) const
 {
     wxASSERT( IS_VALID_PAGE(nPage) );
 

-    // TODO
-    return wxString("");
+    wxNotebookPage *page = m_pages[nPage];
+    return page->GetLabel();

 }
 
 int wxNotebook::GetPageImage(int nPage) const
 {
 }
 
 int wxNotebook::GetPageImage(int nPage) const
 {

-    wxASSERT( IS_VALID_PAGE(nPage) );
+    wxCHECK_MSG( IS_VALID_PAGE(nPage), -1, _T("invalid notebook page") );

 
 

-    // TODO
-    return 0;
+    return m_images[nPage];

 }
 
 bool wxNotebook::SetPageImage(int nPage, int nImage)
 {
 }
 
 bool wxNotebook::SetPageImage(int nPage, int nImage)
 {

-    wxASSERT( IS_VALID_PAGE(nPage) );
+    wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, _T("invalid notebook page") );

 
 

-    // TODO
-    return FALSE;
-}
+    wxCHECK_MSG( m_imageList && nImage < m_imageList->GetImageCount(), FALSE,
+                 _T("invalid image index in SetPageImage()") );
+
+    if ( nImage != m_images[nPage] )
+    {
+        // if the item didn't have an icon before or, on the contrary, did have
+        // it but has lost it now, its size will change - but if the icon just
+        // changes, it won't
+        m_images[nPage] = nImage;

 
 

-void wxNotebook::SetImageList(wxImageList* imageList)
-{ 
-    m_pImageList = imageList;
-    // TODO
+               MacSetupTabs() ;
+    }
+
+    return TRUE;

 }
 
 // ----------------------------------------------------------------------------
 // wxNotebook operations
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // wxNotebook operations
 // ----------------------------------------------------------------------------
 

-// remove one page from the notebook
-bool wxNotebook::DeletePage(int nPage)
-{
-    wxCHECK( IS_VALID_PAGE(nPage), FALSE );
-
-    // TODO: delete native widget page
-
-    delete m_aPages[nPage];
-    m_aPages.Remove(nPage);
-
-    return TRUE;
-}
-

 // remove one page from the notebook, without deleting the window
 // remove one page from the notebook, without deleting the window

-bool wxNotebook::RemovePage(int nPage)
+wxNotebookPage* wxNotebook::DoRemovePage(int nPage)

 {
 {

-    wxCHECK( IS_VALID_PAGE(nPage), FALSE );
+    wxCHECK( IS_VALID_PAGE(nPage), NULL );
+    wxNotebookPage* page = m_pages[nPage] ;
+    m_pages.RemoveAt(nPage);

 
 

-    m_aPages.Remove(nPage);
+    MacSetupTabs();

 
 

-    return TRUE;
+    if(m_nSelection >= GetPageCount()) {
+        m_nSelection = GetPageCount() - 1;
+    }
+    if(m_nSelection >= 0) {
+        m_pages[m_nSelection]->Show(true);
+    }
+    return page;

 }
 
 // remove all pages
 }
 
 // remove all pages


@@ -219,24 +293,12 @@ bool wxNotebook::DeleteAllPages()
 {
     // TODO: delete native widget pages
 
 {
     // TODO: delete native widget pages
 

-    int nPageCount = GetPageCount();
-    int nPage;
-    for ( nPage = 0; nPage < nPageCount; nPage++ )
-        delete m_aPages[nPage];
-
-    m_aPages.Clear();
+    WX_CLEAR_ARRAY(m_pages) ;
+    MacSetupTabs();

 
     return TRUE;
 }
 
 
     return TRUE;
 }
 

-// add a page to the notebook
-bool wxNotebook::AddPage(wxNotebookPage *pPage,
-                         const wxString& strText,
-                         bool bSelect,
-                         int imageId)
-{
-    return InsertPage(GetPageCount(), pPage, strText, bSelect, imageId);
-}

 
 // same as AddPage() but does it at given position
 bool wxNotebook::InsertPage(int nPage,
 
 // same as AddPage() but does it at given position
 bool wxNotebook::InsertPage(int nPage,


@@ -248,34 +310,97 @@ bool wxNotebook::InsertPage(int nPage,
     wxASSERT( pPage != NULL );
     wxCHECK( IS_VALID_PAGE(nPage) || nPage == GetPageCount(), FALSE );
 
     wxASSERT( pPage != NULL );
     wxCHECK( IS_VALID_PAGE(nPage) || nPage == GetPageCount(), FALSE );
 

-               ControlTabInfoRec tie ;
-               Boolean enabled = true ;
-               if ( nPage + 1 > GetControlMaximum( m_macControl ) )
-               {
-                       SetControlMaximum( m_macControl , nPage + 1 ) ;
-               }
-               
-               tie.version = 0 ;
-               tie.iconSuiteID = 0 ;
-               strcpy( (char*) tie.name , strText ) ;
-               c2pstr( (char*) tie.name ) ;    
-               SetControlData( m_macControl, nPage + 1, kControlTabInfoTag , sizeof( ControlTabInfoRec) , (char*) &tie ) ;
-               SetControlData( m_macControl, m_nSelection + 1, kControlTabEnabledFlagTag, sizeof( Boolean ), (Ptr)&enabled );
+    pPage->SetLabel(strText);

 
     // save the pointer to the page
 
     // save the pointer to the page

-    m_aPages.Insert(pPage, nPage);
+    m_pages.Insert(pPage, nPage);

 
 

-    // some page must be selected: either this one or the first one if there is 
-    // still no selection
-    if ( bSelect )
+    m_images.Insert(imageId, nPage);
+
+    MacSetupTabs();
+
+    if ( bSelect ) {

         m_nSelection = nPage;
         m_nSelection = nPage;

-    else if ( m_nSelection == -1 )
+    }
+    else if ( m_nSelection == -1 ) {

         m_nSelection = 0;
         m_nSelection = 0;

+    }
+    else if (m_nSelection >= nPage) {
+        m_nSelection++;
+    }
+    // don't show pages by default (we'll need to adjust their size first)
+    pPage->Show( false ) ;

 
 

-       // don't show pages by default (we'll need to adjust their size first)
-               pPage->Show( FALSE ) ;
+    int h, w;
+    GetSize(&w, &h);
+    pPage->SetSize(kwxMacTabLeftMargin, kwxMacTabTopMargin,
+                   w - kwxMacTabLeftMargin - kwxMacTabRightMargin,
+                   h - kwxMacTabTopMargin - kwxMacTabBottomMargin );
+    if ( pPage->GetAutoLayout() ) {
+        pPage->Layout();
+    }

 
 

-    return TRUE;
+    return true;
+}
+
+/* Added by Mark Newsam
+ * When a page is added or deleted to the notebook this function updates
+ * information held in the m_macControl so that it matches the order
+ * the user would expect.
+ */
+void wxNotebook::MacSetupTabs()
+{
+    SetControl32BitMaximum( (ControlHandle) m_macControl , GetPageCount() ) ;
+
+    wxNotebookPage *page;
+    ControlTabInfoRec info;
+
+    for(int ii = 0; ii < GetPageCount(); ii++)
+    {
+        page = m_pages[ii];
+        info.version = 0;
+        info.iconSuiteID = 0;
+#if TARGET_CARBON
+               c2pstrcpy( (StringPtr) info.name , page->GetLabel() ) ;
+#else
+               strcpy( (char *) info.name , page->GetLabel() ) ;
+               c2pstr( (char *) info.name ) ;
+#endif
+        SetControlData( (ControlHandle) m_macControl, ii+1, kControlTabInfoTag,
+                        sizeof( ControlTabInfoRec) , (char*) &info ) ;
+        SetTabEnabled( (ControlHandle) m_macControl , ii+1 , true ) ;
+
+#if TARGET_CARBON
+        if ( GetImageList() && GetPageImage(ii) >= 0 && UMAGetSystemVersion() >= 0x1020 )
+        {
+               // tab controls only support very specific types of images, therefore we are doing an odyssee
+               // accross the icon worlds (even Apple DTS did not find a shorter path)
+               // in order not to pollute the icon registry we put every icon into (OSType) 1 and immediately
+               // afterwards Unregister it (IconRef is ref counted, so it will stay on the tab even if we 
+               // unregister it) in case this will ever lead to having the same icon everywhere add some kind
+               // of static counter 
+               ControlButtonContentInfo info ;
+               wxMacCreateBitmapButton( &info , *GetImageList()->GetBitmap( GetPageImage(ii ) ) , kControlContentPictHandle) ;
+               IconFamilyHandle iconFamily = (IconFamilyHandle) NewHandle(0) ;
+               OSErr err = SetIconFamilyData( iconFamily, 'PICT' , (Handle) info.u.picture ) ;
+            wxASSERT_MSG( err == noErr , "Error when adding bitmap" ) ;
+               IconRef iconRef ;
+               err = RegisterIconRefFromIconFamily( 'WXNG' , (OSType) 1 , iconFamily, &iconRef ) ;
+            wxASSERT_MSG( err == noErr , "Error when adding bitmap" ) ;
+               info.contentType = kControlContentIconRef ;
+               info.u.iconRef = iconRef ;
+               SetControlData( (ControlHandle) m_macControl, ii+1,kControlTabImageContentTag,
+                        sizeof( info ), (Ptr)&info );
+            wxASSERT_MSG( err == noErr , "Error when setting icon on tab" ) ;
+               UnregisterIconRef( 'WXNG' , (OSType) 1 ) ;
+            ReleaseIconRef( iconRef ) ;
+            DisposeHandle( (Handle) iconFamily ) ;
+        }
+#endif
+    }
+    Rect bounds;
+    GetControlBounds((ControlHandle)m_macControl, &bounds);
+    InvalWindowRect((WindowRef)MacGetRootWindow(), &bounds);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -286,14 +411,6 @@ bool wxNotebook::InsertPage(int nPage,
 //     time because doing it in ::Create() doesn't work (for unknown reasons)
 void wxNotebook::OnSize(wxSizeEvent& event)
 {
 //     time because doing it in ::Create() doesn't work (for unknown reasons)
 void wxNotebook::OnSize(wxSizeEvent& event)
 {

-    static bool s_bFirstTime = TRUE;
-    if ( s_bFirstTime ) {
-        // TODO: any first-time-size processing.
-        s_bFirstTime = FALSE;
-    }
-
-    // TODO: all this may or may not be necessary for your platform
-

     // emulate page change (it's esp. important to do it first time because
     // otherwise our page would stay invisible)
     int nSel = m_nSelection;
     // emulate page change (it's esp. important to do it first time because
     // otherwise our page would stay invisible)
     int nSel = m_nSelection;


@@ -304,14 +421,15 @@ void wxNotebook::OnSize(wxSizeEvent& event)
     int w, h;
     GetSize(&w, &h);
 
     int w, h;
     GetSize(&w, &h);
 

-    unsigned int nCount = m_aPages.Count();
+    unsigned int nCount = m_pages.Count();

     for ( unsigned int nPage = 0; nPage < nCount; nPage++ ) {
     for ( unsigned int nPage = 0; nPage < nCount; nPage++ ) {

-        wxNotebookPage *pPage = m_aPages[nPage];
-        pPage->SetSize(kwxMacTabLeftMargin, kwxMacTabTopMargin, w - kwxMacTabLeftMargin - kwxMacTabRightMargin,
-               h - kwxMacTabTopMargin - kwxMacTabBottomMargin );
-//        pPage->SetSize(0, 0, w, h);
-        if ( pPage->GetAutoLayout() )
+        wxNotebookPage *pPage = m_pages[nPage];
+        pPage->SetSize(kwxMacTabLeftMargin, kwxMacTabTopMargin,
+                       w - kwxMacTabLeftMargin - kwxMacTabRightMargin,
+                       h - kwxMacTabTopMargin - kwxMacTabBottomMargin );
+        if ( pPage->GetAutoLayout() ) {

             pPage->Layout();
             pPage->Layout();

+        }

     }
 
     // Processing continues to next OnSize
     }
 
     // Processing continues to next OnSize


@@ -332,7 +450,7 @@ void wxNotebook::OnSetFocus(wxFocusEvent& event)
 {
     // set focus to the currently selected page if any
     if ( m_nSelection != -1 )
 {
     // set focus to the currently selected page if any
     if ( m_nSelection != -1 )

-        m_aPages[m_nSelection]->SetFocus();
+        m_pages[m_nSelection]->SetFocus();

 
     event.Skip();
 }
 
     event.Skip();
 }


@@ -381,33 +499,103 @@ void wxNotebook::Command(wxCommandEvent& event)
 // hide the currently active panel and show the new one
 void wxNotebook::ChangePage(int nOldSel, int nSel)
 {
 // hide the currently active panel and show the new one
 void wxNotebook::ChangePage(int nOldSel, int nSel)
 {

-  // it's not an error (the message may be generated by the tab control itself)
-  // and it may happen - just do nothing
-  if ( nSel == nOldSel )
-  {
-    wxNotebookPage *pPage = m_aPages[nSel];
-       pPage->Show(FALSE);
-       pPage->Show(TRUE);
-       pPage->SetFocus();
-    return;
-  }
+    // it's not an error (the message may be generated by the tab control itself)
+    // and it may happen - just do nothing
+    if ( nSel == nOldSel )
+    {
+        wxNotebookPage *pPage = m_pages[nSel];
+        pPage->Show(FALSE);
+        pPage->Show(TRUE);
+        pPage->SetFocus();
+        return;
+    }

 
 

+    // Hide previous page

     if ( nOldSel != -1 ) {
     if ( nOldSel != -1 ) {

-        m_aPages[nOldSel]->Show(FALSE);
+        m_pages[nOldSel]->Show(FALSE);

     }
 
     }
 

-    wxNotebookPage *pPage = m_aPages[nSel];
+    wxNotebookPage *pPage = m_pages[nSel];

     pPage->Show(TRUE);
     pPage->SetFocus();
 
     m_nSelection = nSel;
 }
 
     pPage->Show(TRUE);
     pPage->SetFocus();
 
     m_nSelection = nSel;
 }
 

-void wxNotebook::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
+
+void  wxNotebook::OnMouse( wxMouseEvent &event )

 {
 {

-  wxNotebookEvent event(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED, m_windowId , ::GetControlValue(m_macControl) - 1, m_nSelection);
+   if ( (ControlHandle) m_macControl == NULL )
+   {
+      event.Skip() ;
+      return ;
+   }
+
+   if (event.GetEventType() == wxEVT_LEFT_DOWN || event.GetEventType() == wxEVT_LEFT_DCLICK )
+   {
+      int x = event.m_x ;
+      int y = event.m_y ;
+
+      MacClientToRootWindow( &x , &y ) ;
+
+      ControlHandle   control ;
+      Point       localwhere ;
+      SInt16      controlpart ;
+
+      localwhere.h = x ;
+      localwhere.v = y ;
+
+      short modifiers = 0;
+
+      if ( !event.m_leftDown && !event.m_rightDown )
+           modifiers  |= btnState ;
+
+      if ( event.m_shiftDown )
+           modifiers |= shiftKey ;
+
+      if ( event.m_controlDown )
+           modifiers |= controlKey ;
+
+      if ( event.m_altDown )
+           modifiers |= optionKey ;
+
+      if ( event.m_metaDown )
+           modifiers |= cmdKey ;
+
+      control = (ControlHandle) m_macControl ;
+      if ( control && ::IsControlActive( control ) )
+      {
+           {
+            wxNotebookEvent changing(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGING, m_windowId,
+                                    ::GetControl32BitValue(control) - 1, m_nSelection);
+               changing.SetEventObject(this);
+               ProcessEvent(changing);
+ 
+               if(changing.IsAllowed())
+               {
+              controlpart = ::HandleControlClick(control, localwhere, modifiers,
+                                                 (ControlActionUPP) -1);
+              wxTheApp->s_lastMouseDown = 0 ;
+     
+              wxNotebookEvent event(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED, m_windowId,
+                                    ::GetControl32BitValue(control) - 1, m_nSelection);
+              event.SetEventObject(this);
+     
+              ProcessEvent(event);
+               }
+           }
+       }
+   }
+}
+ 
+
+void wxNotebook::MacHandleControlClick( WXWidget control , wxInt16 controlpart ) 
+{
+#if 0
+  wxNotebookEvent event(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED, m_windowId , ::GetControl32BitValue((ControlHandle)m_macControl) - 1, m_nSelection);

   event.SetEventObject(this);
 
   ProcessEvent(event);
   event.SetEventObject(this);
 
   ProcessEvent(event);

+#endif

 }
 
 }