]> git.saurik.com Git - wxWidgets.git/blobdiff - src/mac/menu.cpp
projects / wxWidgets.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
Integrated recent API-change
[wxWidgets.git] / src / mac / menu.cpp
diff --git a/src/mac/menu.cpp b/src/mac/menu.cpp
index 1fc7c4a22941326f98c5bf900b6c9a354c2200d9..427db90852fd76c82b19f57c160a7b38ebd20c00 100644 (file)
--- a/src/mac/menu.cpp
+++ b/src/mac/menu.cpp
@@ -27,187 +27,466 @@
 #include "wx/log.h"
 #include "wx/utils.h"
 
 #include "wx/log.h"
 #include "wx/utils.h"
 
+#include "wx/mac/uma.h"
+
 // other standard headers
 // ----------------------
 #include <string.h>
 
 // other standard headers
 // ----------------------
 #include <string.h>
 
-#if !USE_SHARED_LIBRARY
 IMPLEMENT_DYNAMIC_CLASS(wxMenu, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenuBar, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenu, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenuBar, wxEvtHandler)
-#endif
+
+// the (popup) menu title has this special id
+static const int idMenuTitle = -2;
+static int formerHelpMenuItems = 0 ;
+
+const short kwxMacMenuBarResource = 1 ;
+const short kwxMacAppleMenuId = 1 ;
 
 // ============================================================================
 // implementation
 // ============================================================================
 
 
 // ============================================================================
 // implementation
 // ============================================================================
 
+//
+// Helper Functions to get Mac Menus the way they should be ;-)
+//
+
+void wxMacCtoPString(const char* theCString, Str255 thePString);
+
+// remove inappropriate characters, if useShortcuts is false, the ampersand will not auto-generate a mac menu-shortcut
+
+void wxMacBuildMenuString(StringPtr outMacItemText, char *outMacShortcutChar , short *outMacModifiers , const char *inItemText , bool useShortcuts )
+{
+       char *p = (char *) &outMacItemText[1] ;
+       short macModifiers = 0 ;
+       char macShortCut = 0 ;
+       const char *inItemName ;
+       wxString inItemTextMac ;
+       
+       if (wxApp::s_macDefaultEncodingIsPC)
+       {
+               inItemTextMac =  wxMacMakeMacStringFromPC( inItemText ) ;
+               inItemName = inItemTextMac ;
+       }
+       else
+       {
+               inItemName = inItemText ;
+       }
+       
+       if ( useShortcuts && !wxApp::s_macSupportPCMenuShortcuts )
+               useShortcuts = false ;
+       
+       // we have problems with a leading hypen - it will be taken as a separator
+       
+       while ( *inItemName == '-' )
+               inItemName++ ;
+               
+       while( *inItemName )
+       {
+               switch ( *inItemName )
+               {
+                       // special characters for macintosh menus -> use some replacement
+                       case ';' :
+                               *p++ = ',' ;
+                               break ;
+                       case '^' :
+                               *p++ = ' ' ;
+                               break ;
+                       case '!' :
+                               *p++ = ' ' ;
+                               break ;
+                       case '<' :
+                               *p++ = ' ' ;
+                               break ;
+                       case '/' :
+                               *p++ = '|' ;
+                               break ;
+                       case '(' :
+                               *p++ = '[' ;
+                               break ;
+                       case ')' :      
+                               *p++ = ']' ;
+                               break ;
+                       // shortcuts
+                       case '&' :
+                               {
+                                       ++inItemName ;
+                                       if ( *inItemName )
+                                       {
+                                               *p++ = *inItemName ;
+                                               if ( useShortcuts )
+                                                       macShortCut = *inItemName ;
+                                       }
+                                       else
+                                               --inItemName ;
+                               }
+                               break ;
+                       // win-like accelerators
+                       case '\t' :
+                               {
+                                       ++inItemName ;
+                                       while( *inItemName )
+                                       {
+                                               if (strncmp("Ctrl", inItemName, 4) == 0) 
+                                               {
+                                                       inItemName = inItemName + 5;
+                                                       macShortCut = *inItemName;
+                                               }
+                                               else if  (strncmp("Cntrl", inItemName, 5) == 0) 
+                                               {
+                                                       inItemName = inItemName + 6;
+                                                       macShortCut = *inItemName;
+                                               }
+                                               else if (strncmp("Alt", inItemName, 3) == 0) 
+                                               {
+                                                       inItemName = inItemName + 4;
+                                                       macModifiers |= kMenuOptionModifier ;
+                                                       macShortCut = *inItemName ;
+                                               }
+                                               else if (strncmp("Shift", inItemName, 5) == 0) 
+                                               {
+                                                       inItemName = inItemName + 6;
+                                                       macModifiers |= kMenuShiftModifier ;
+                                                       macShortCut = *inItemName ;
+                                               }
+                                               else if (strncmp("F", inItemName, 1) == 0) 
+                                               {
+                                                       inItemName += strlen( inItemName ) ;
+                                                       // no function keys at the moment
+                                                       // macModifiers |= kMenuShiftModifier ;
+                                                       // macShortCut = *inItemName ;
+                                               }
+                                               else
+                                               {
+                                                       break ;
+                                               }
+                                       }
+
+                                       if ( *inItemName == 0 )
+                                               --inItemName ;
+                                               
+                               }
+                               break ;
+                       default :
+                               *p++ = *inItemName ;
+               }
+               ++inItemName ;
+       }
+
+       outMacItemText[0] = (p - (char *)outMacItemText) - 1;
+       if ( outMacShortcutChar )
+               *outMacShortcutChar = macShortCut ;
+       if ( outMacModifiers )
+               *outMacModifiers = macModifiers ;
+       if ( macShortCut )
+       {
+                       int pos = outMacItemText[0] ;
+                       outMacItemText[++pos] = '/';
+                       outMacItemText[++pos] = toupper( macShortCut );
+                       outMacItemText[0] = pos ;
+       }
+}
+
 // Menus
 
 // Construct a menu with optional title (then use append)
 // Menus
 
 // Construct a menu with optional title (then use append)
-wxMenu::wxMenu(const wxString& title, const wxFunction func)
+
+short wxMenu::s_macNextMenuId = 2 ;
+
+void wxMenu::Init()
 {
 {
-    m_title = title;
-    m_parent = NULL;
-    m_eventHandler = this;
-    m_noItems = 0;
-    m_menuBar = NULL;
-    m_clientData = (void*) NULL;
-    if (m_title != "")
+    m_doBreak = FALSE;
+
+    // create the menu
+       Str255  label;
+       wxMacBuildMenuString( label, NULL , NULL , m_title , false );
+       m_macMenuId = s_macNextMenuId++; 
+    wxCHECK_RET( s_macNextMenuId < 236 , "menu ids > 235 cannot be used for submenus on mac" );
+       m_hMenu = ::NewMenu(m_macMenuId, label);
+
+    if ( !m_hMenu )
     {
     {
-        Append(-2, m_title) ;
-        AppendSeparator() ;
+        wxLogLastError("CreatePopupMenu");
     }
 
     }
 
-    Callback(func);
-
-    // TODO create menu
+    // if we have a title, insert it in the beginning of the menu
+    if ( !!m_title )
+    {
+        Append(idMenuTitle, m_title) ;
+        AppendSeparator() ;
+    }
 }
 
 }
 
-// The wxWindow destructor will take care of deleting the submenus.
 wxMenu::~wxMenu()
 {
 wxMenu::~wxMenu()
 {
-    // TODO destroy menu and children
-
-    wxNode *node = m_menuItems.First();
-    while (node)
-    {
-        wxMenuItem *item = (wxMenuItem *)node->Data();
+       if (m_hMenu)
+               ::DisposeMenu(m_hMenu);
 
 
-        // Delete child menus.
-        // Beware: they must not be appended to children list!!!
-        // (because order of delete is significant)
-        if (item->GetSubMenu())
-            item->DeleteSubMenu();
-
-        wxNode *next = node->Next();
-        delete item;
-        delete node;
-        node = next;
-    }
+#if wxUSE_ACCEL
+    // delete accels
+    WX_CLEAR_ARRAY(m_accels);
+#endif // wxUSE_ACCEL
 }
 
 void wxMenu::Break()
 {
 }
 
 void wxMenu::Break()
 {
-    // TODO
+       // not available on the mac platform
 }
 
 }
 
-// function appends a new item or submenu to the menu
-void wxMenu::Append(wxMenuItem *pItem)
+#if wxUSE_ACCEL
+
+int wxMenu::FindAccel(int id) const
 {
 {
-    // TODO
+    size_t n, count = m_accels.GetCount();
+    for ( n = 0; n < count; n++ )
+    {
+        if ( m_accels[n]->m_command == id )
+            return n;
+    }
 
 
-    wxCHECK_RET( pItem != NULL, "can't append NULL item to the menu" );
+    return wxNOT_FOUND;
+}
 
 
-    m_menuItems.Append(pItem);
+void wxMenu::UpdateAccel(wxMenuItem *item)
+{
+    // find the (new) accel for this item
+    wxAcceleratorEntry *accel = wxGetAccelFromString(item->GetText());
+    if ( accel )
+        accel->m_command = item->GetId();
+
+    // find the old one
+    int n = FindAccel(item->GetId());
+    if ( n == wxNOT_FOUND )
+    {
+        // no old, add new if any
+        if ( accel )
+            m_accels.Add(accel);
+        else
+            return;     // skipping RebuildAccelTable() below
+    }
+    else
+    {
+        // replace old with new or just remove the old one if no new
+        delete m_accels[n];
+        if ( accel )
+            m_accels[n] = accel;
+        else
+            m_accels.Remove(n);
+    }
 
 
-    m_noItems++;
+    if ( IsAttached() )
+    {
+        m_menuBar->RebuildAccelTable();
+    }
 }
 
 }
 
-void wxMenu::AppendSeparator()
+#endif // wxUSE_ACCEL
+
+// function appends a new item or submenu to the menu
+// append a new item or submenu to the menu
+bool wxMenu::DoInsertOrAppend(wxMenuItem *pItem, size_t pos)
 {
 {
-    // TODO
-    Append(new wxMenuItem(this, ID_SEPARATOR));
+    wxASSERT_MSG( pItem != NULL, "can't append NULL item to the menu" );
+#if wxUSE_ACCEL
+    UpdateAccel(pItem);
+#endif // wxUSE_ACCEL
+
+       if ( pItem->IsSeparator() )
+       {
+               if ( pos == (size_t)-1 )
+               {
+                       MacAppendMenu(m_hMenu, "\p-");
+               }
+               else
+               {
+                       MacInsertMenuItem(m_hMenu, "\p-" , pos);
+               }
+       }
+       else 
+       {
+               wxMenu *pSubMenu = pItem->GetSubMenu() ;
+               if ( pSubMenu != NULL )
+               {
+                       Str255 label;
+                       wxASSERT_MSG( pSubMenu->m_hMenu != NULL , "invalid submenu added");
+                   pSubMenu->m_menuParent = this ;
+                       wxMacBuildMenuString( label , NULL , NULL , pItem->GetText() ,false);
+               
+                       // hardcoded adding of the submenu combination for mac
+               
+                       int theEnd = label[0] + 1; 
+                       if (theEnd > 251) 
+                               theEnd = 251; // mac allows only 255 characters
+                       label[theEnd++] = '/';
+                       label[theEnd++] = hMenuCmd; 
+                       label[theEnd++] = '!';
+                       label[theEnd++] = pSubMenu->m_macMenuId; 
+                       label[theEnd] = 0x00;
+                       label[0] = theEnd;
+
+                       if (wxMenuBar::MacGetInstalledMenuBar() == m_menuBar) 
+                       {
+                               ::InsertMenu( pSubMenu->m_hMenu , -1 ) ;
+                       }
+                       
+                       if ( pos == (size_t)-1 )
+                       {
+                               MacAppendMenu(m_hMenu, label);
+                       }
+                       else
+                       {
+                               MacInsertMenuItem(m_hMenu, label , pos);
+                       }
+               }
+               else
+               {
+                       Str255 label ;
+                       wxMacBuildMenuString( label , NULL , NULL , pItem->GetText(), pItem->GetId() == wxApp::s_macAboutMenuItemId);
+                       if ( label[0] == 0 )
+                       {
+                               // we cannot add empty menus on mac
+                               label[0] = 1 ;
+                               label[1] = ' ' ;
+                       }
+                       if ( pos == (size_t)-1 )
+                       {
+                               MacAppendMenu(m_hMenu, label);
+                       }
+                       else
+                       {
+                               MacInsertMenuItem(m_hMenu, label , pos);
+                       }
+                       if ( pItem->GetId() == idMenuTitle ) 
+                       {
+                               if ( pos == (size_t)-1 )
+                               {
+                                       UMADisableMenuItem( m_hMenu , CountMItems( m_hMenu ) ) ;
+                               }
+                               else
+                               {
+                                       UMADisableMenuItem( m_hMenu , pos + 1 ) ;
+                               }
+                       }
+               }
+       }
+    // if we're already attached to the menubar, we must update it
+    if ( IsAttached() )
+    {
+        m_menuBar->Refresh();
+    }
+       return TRUE ;
 }
 
 }
 
-// Pullright item
-void wxMenu::Append(int Id, const wxString& label, wxMenu *SubMenu, 
-                    const wxString& helpString)
+bool wxMenu::DoAppend(wxMenuItem *item)
 {
 {
-    Append(new wxMenuItem(this, Id, label, helpString, FALSE, SubMenu));
+    return wxMenuBase::DoAppend(item) && DoInsertOrAppend(item);
 }
 
 }
 
-// Ordinary menu item
-void wxMenu::Append(int Id, const wxString& label, 
-                    const wxString& helpString, bool checkable)
+bool wxMenu::DoInsert(size_t pos, wxMenuItem *item)
 {
 {
-  // 'checkable' parameter is useless for Windows.
-    Append(new wxMenuItem(this, Id, label, helpString, checkable));
+    return wxMenuBase::DoInsert(pos, item) && DoInsertOrAppend(item, pos);
 }
 
 }
 
-void wxMenu::Delete(int id)
+wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)
 {
 {
-    wxNode *node;
-    wxMenuItem *item;
-    int pos;
+    // we need to find the items position in the child list
+    size_t pos;
+    wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+    for ( pos = 0; node; pos++ )
+    {
+        if ( node->GetData() == item )
+            break;
 
 
-    for (pos = 0, node = m_menuItems.First(); node; node = node->Next(), pos++) {
-        item = (wxMenuItem *)node->Data();
-        if (item->GetId() == id)
-               break;
+        node = node->GetNext();
     }
 
     }
 
-    if (!node)
-       return;
-
-    m_menuItems.DeleteNode(node);
-    delete item;
+    // DoRemove() (unlike Remove) can only be called for existing item!
+    wxCHECK_MSG( node, NULL, wxT("bug in wxMenu::Remove logic") );
 
 
-    // TODO
-}
+#if wxUSE_ACCEL
+    // remove the corresponding accel from the accel table
+    int n = FindAccel(item->GetId());
+    if ( n != wxNOT_FOUND )
+    {
+        delete m_accels[n];
 
 
-void wxMenu::Enable(int Id, bool Flag)
-{
-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK_RET( item != NULL, "can't enable non-existing menu item" );
+        m_accels.Remove(n);
+    }
+    //else: this item doesn't have an accel, nothing to do
+#endif // wxUSE_ACCEL
 
 
-    item->Enable(Flag);
-}
+       ::DeleteMenuItem( m_hMenu , pos + 1);
 
 
-bool wxMenu::Enabled(int Id) const
-{
-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK( item != NULL, FALSE );
+    if ( IsAttached() )
+    {
+        // otherwise, the chane won't be visible
+        m_menuBar->Refresh();
+    }
 
 
-    return item->IsEnabled();
+    // and from internal data structures
+    return wxMenuBase::DoRemove(item);
 }
 
 }
 
-void wxMenu::Check(int Id, bool Flag)
-{
-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK_RET( item != NULL, "can't get status of non-existing menu item" );
+// ---------------------------------------------------------------------------
+// accelerator helpers
+// ---------------------------------------------------------------------------
 
 
-    item->Check(Flag);
-}
+#if wxUSE_ACCEL
 
 
-bool wxMenu::Checked(int Id) const
+// create the wxAcceleratorEntries for our accels and put them into provided
+// array - return the number of accels we have
+size_t wxMenu::CopyAccels(wxAcceleratorEntry *accels) const
 {
 {
-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK( item != NULL, FALSE );
+    size_t count = GetAccelCount();
+    for ( size_t n = 0; n < count; n++ )
+    {
+        *accels++ = *m_accels[n];
+    }
 
 
-    return item->IsChecked();
+    return count;
 }
 
 }
 
+#endif // wxUSE_ACCEL
+
 void wxMenu::SetTitle(const wxString& label)
 {
 void wxMenu::SetTitle(const wxString& label)
 {
+       Str255 title ;
     m_title = label ;
     m_title = label ;
-    // TODO
+       wxMacBuildMenuString( title, NULL , NULL , label , false );
+       UMASetMenuTitle( m_hMenu , title ) ;
 }
 
 }
 
-const wxString wxMenu::GetTitle() const
-{
-    return m_title;
-}
+/*
 
 void wxMenu::SetLabel(int id, const wxString& label)
 {
 
 void wxMenu::SetLabel(int id, const wxString& label)
 {
+    Str255 maclabel ;
+   int index ;
     wxMenuItem *item = FindItemForId(id) ;
     if (item==NULL)
         return;
 
     wxMenuItem *item = FindItemForId(id) ;
     if (item==NULL)
         return;
 
+    index = MacGetIndexFromItem( item ) ;
+    if (index < 1)
+               return;
+
     if (item->GetSubMenu()==NULL)
     {
     if (item->GetSubMenu()==NULL)
     {
-        // TODO
+               wxMacBuildMenuString( maclabel , NULL , NULL , label , false );
+               ::SetMenuItemText( m_hMenu , index , maclabel ) ;
     }
     else
     {
     }
     else
     {
-        // TODO
+               wxMacBuildMenuString( maclabel , NULL , NULL , label , false );
+               ::SetMenuItemText( m_hMenu , index , maclabel ) ;
     }
     item->SetName(label);
 }
 
 wxString wxMenu::GetLabel(int Id) const
 {
     }
     item->SetName(label);
 }
 
 wxString wxMenu::GetLabel(int Id) const
 {
-    // TODO
-    return wxString("") ;
+    wxMenuItem *pItem = FindItemForId(Id) ;
+    return pItem->GetName() ;
 }
 
 // Finds the item id matching the given string, -1 if not found.
 }
 
 // Finds the item id matching the given string, -1 if not found.
@@ -278,294 +557,688 @@ wxString wxMenu::GetHelpString (int itemId) const
     wxString str("");
     return (item == NULL) ? str : item->GetHelp();
 }
     wxString str("");
     return (item == NULL) ? str : item->GetHelp();
 }
+*/
 
 
-void wxMenu::ProcessCommand(wxCommandEvent & event)
+bool wxMenu::ProcessCommand(wxCommandEvent & event)
 {
     bool processed = FALSE;
 
 {
     bool processed = FALSE;
 
+#if WXWIN_COMPATIBILITY
     // Try a callback
     if (m_callback)
     {
     // Try a callback
     if (m_callback)
     {
-            (void) (*(m_callback)) (*this, event);
-            processed = TRUE;
+        (void)(*(m_callback))(*this, event);
+        processed = TRUE;
     }
     }
+#endif WXWIN_COMPATIBILITY
 
     // Try the menu's event handler
     if ( !processed && GetEventHandler())
     {
 
     // Try the menu's event handler
     if ( !processed && GetEventHandler())
     {
-            processed = GetEventHandler()->ProcessEvent(event);
+        processed = GetEventHandler()->ProcessEvent(event);
     }
     }
-/* TODO
-    // Try the window the menu was popped up from (and up
-    // through the hierarchy)
-    if ( !processed && GetInvokingWindow())
-        processed = GetInvokingWindow()->ProcessEvent(event);
-*/
+
+    // Try the window the menu was popped up from (and up through the
+    // hierarchy)
+    wxWindow *win = GetInvokingWindow();
+    if ( !processed && win )
+        processed = win->GetEventHandler()->ProcessEvent(event);
+
+    return processed;
 }
 
 }
 
-bool wxWindow::PopupMenu(wxMenu *menu, int x, int y)
+
+// ---------------------------------------------------------------------------
+// other
+// ---------------------------------------------------------------------------
+
+void wxMenu::Attach(wxMenuBar *menubar)
 {
 {
-    // TODO
-    return FALSE;
+    // menu can be in at most one menubar because otherwise they would both
+    // delete the menu pointer
+    wxASSERT_MSG( !m_menuBar, wxT("menu belongs to 2 menubars, expect a crash") );
+
+    m_menuBar = menubar;
 }
 
 }
 
-// Menu Bar
-wxMenuBar::wxMenuBar()
+void wxMenu::Detach()
 {
 {
-    m_eventHandler = this;
-    m_menuCount = 0;
-    m_menus = NULL;
-    m_titles = NULL;
-    m_menuBarFrame = NULL;
+    wxASSERT_MSG( m_menuBar, wxT("can't detach menu if it's not attached") );
 
 
-    // TODO
+    m_menuBar = NULL;
 }
 
 }
 
-wxMenuBar::wxMenuBar(int n, wxMenu *menus[], const wxString titles[])
+wxWindow *wxMenu::GetWindow() const
 {
 {
-    m_eventHandler = this;
-    m_menuCount = n;
-    m_menus = menus;
-    m_titles = new wxString[n];
-    int i;
-    for ( i = 0; i < n; i++ )
-       m_titles[i] = titles[i];
-    m_menuBarFrame = NULL;
+    if ( m_invokingWindow != NULL )
+        return m_invokingWindow;
+    else if ( m_menuBar != NULL)
+        return m_menuBar->GetFrame();
 
 
-    // TODO
+    return NULL;
 }
 
 }
 
-wxMenuBar::~wxMenuBar()
+// helper functions returning the mac menu position for a certain item, note that this is 
+// mac-wise 1 - based, i.e. the first item has index 1 whereas on MSWin it has pos 0
+
+int wxMenu::MacGetIndexFromId( int id ) 
 {
 {
-    int i;
-    for (i = 0; i < m_menuCount; i++)
+    size_t pos;
+    wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+    for ( pos = 0; node; pos++ )
     {
     {
-        delete m_menus[i];
-    }
-    delete[] m_menus;
-    delete[] m_titles;
+        if ( node->GetData()->GetId() == id )
+            break;
 
 
-    // TODO
+        node = node->GetNext();
+    }
+       
+    if (!node)
+               return 0;
+               
+       return pos + 1 ;
 }
 
 }
 
-// Must only be used AFTER menu has been attached to frame,
-// otherwise use individual menus to enable/disable items
-void wxMenuBar::Enable(int id, bool flag)
+int wxMenu::MacGetIndexFromItem( wxMenuItem *pItem ) 
 {
 {
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return;
+    size_t pos;
+    wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+    for ( pos = 0; node; pos++ )
+    {
+        if ( node->GetData() == pItem )
+            break;
+
+        node = node->GetNext();
+    }
 
 
-    // TODO
+    if (!node)
+               return 0;
+               
+       return pos + 1 ;
 }
 
 }
 
-void wxMenuBar::EnableTop(int pos, bool flag)
+void wxMenu::MacEnableMenu( bool bDoEnable ) 
 {
 {
-    // TODO
+       if ( bDoEnable )
+               UMAEnableMenuItem( m_hMenu , 0 ) ;
+       else
+               UMADisableMenuItem( m_hMenu , 0 ) ;
+               
+       ::DrawMenuBar() ;
 }
 
 }
 
-// Must only be used AFTER menu has been attached to frame,
-// otherwise use individual menus
-void wxMenuBar::Check(int id, bool flag)
+bool wxMenu::MacMenuSelect( wxEvtHandler* handler, long when , int macMenuId, int macMenuItemNum )
 {
 {
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return;
-
-    if (!item->IsCheckable())
-        return ;
+  int pos;
+  wxNode *node;
 
 
-    // TODO
+       if ( m_macMenuId == macMenuId )
+       {
+               node = GetMenuItems().Nth(macMenuItemNum-1);
+               if (node) 
+               {
+                       wxMenuItem *pItem = (wxMenuItem*)node->Data();
+       
+                       wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED, pItem->GetId());
+                       event.m_timeStamp = when;
+                       event.SetEventObject(handler);
+               event.SetInt( pItem->GetId() );
+                       {
+                               bool processed = false ;
+
+#if WXWIN_COMPATIBILITY
+                           // Try a callback
+                           if (m_callback)
+                           {
+                                   (void) (*(m_callback)) (*this, event);
+                                   processed = TRUE;
+                           }
+#endif                 
+                           // Try the menu's event handler
+                           if ( !processed && handler)
+                           {
+                                   processed = handler->ProcessEvent(event);
+                           }
+                       
+                               // Try the window the menu was popped up from (and up
+                               // through the hierarchy)
+                               if ( !processed && GetInvokingWindow())
+                               processed = GetInvokingWindow()->GetEventHandler()->ProcessEvent(event);
+                       }
+                       return true ;
+               }
+       }
+       else if ( macMenuId == kHMHelpMenuID )
+       {
+               int menuItem = formerHelpMenuItems ;
+         for (pos = 0, node = GetMenuItems().First(); node; node = node->Next(), pos++) 
+         {     
+               wxMenuItem * pItem = (wxMenuItem *)  node->Data() ;
+               
+               wxMenu *pSubMenu = pItem->GetSubMenu() ;
+                       if ( pSubMenu != NULL )
+                       {
+                       }
+                       else
+                       {
+                               if ( pItem->GetId() != wxApp::s_macAboutMenuItemId )
+                                       ++menuItem ;
+                                       
+                               if ( menuItem == macMenuItemNum )
+                               {
+                                       wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED, pItem->GetId());
+                                       event.m_timeStamp = when;
+                                       event.SetEventObject(handler);
+                                       event.SetInt( pItem->GetId() );
+                                       {
+                                               bool processed = false ;
+#if WXWIN_COMPATIBILITY
+                                           // Try a callback
+                                           if (m_callback)
+                                           {
+                                                   (void) (*(m_callback)) (*this, event);
+                                                   processed = TRUE;
+                                           }
+#endif                                 
+                                           // Try the menu's event handler
+                                           if ( !processed && handler)
+                                           {
+                                                   processed = handler->ProcessEvent(event);
+                                           }
+                                       
+                                               // Try the window the menu was popped up from (and up
+                                               // through the hierarchy)
+                                               if ( !processed && GetInvokingWindow())
+                                               processed = GetInvokingWindow()->GetEventHandler()->ProcessEvent(event);
+                                       }
+                                       return true ;
+                               }
+                       }
+         }
+       }
+
+  for (pos = 0, node = GetMenuItems().First(); node; node = node->Next(), pos++) 
+  {    
+               wxMenuItem * pItem = (wxMenuItem *)  node->Data() ;
+       
+               wxMenu *pSubMenu = pItem->GetSubMenu() ;
+               if ( pSubMenu != NULL )
+               {
+                       if ( pSubMenu->MacMenuSelect( handler , when , macMenuId , macMenuItemNum ) )
+                               return true ;
+               }
+  }
+
+       return false ;
 }
 
 }
 
-bool wxMenuBar::Checked(int id) const
-{
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return FALSE;
+// Menu Bar
+
+/* 
+
+Mac Implementation note :
 
 
-    // TODO
-    return FALSE;
+The Mac has only one global menubar, so we attempt to install the currently
+active menubar from a frame, we currently don't take into account mdi-frames
+which would ask for menu-merging
+
+Secondly there is no mac api for changing a menubar that is not the current 
+menubar, so we have to wait for preparing the actual menubar until the
+wxMenubar is to be used
+
+We can in subsequent versions use MacInstallMenuBar to provide some sort of 
+auto-merge for MDI in case this will be necessary
+
+*/
+
+wxMenuBar* wxMenuBar::s_macInstalledMenuBar = NULL ;
+
+void wxMenuBar::Init()
+{
+    m_eventHandler = this;
+    m_menuBarFrame = NULL;
 }
 
 }
 
-bool wxMenuBar::Enabled(int id) const
+wxMenuBar::wxMenuBar()
 {
 {
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return FALSE;
+    Init();
+}
 
 
-    // TODO
-    return FALSE ;
+wxMenuBar::wxMenuBar( long WXUNUSED(style) )
+{
+    Init();
 }
 
 
 }
 
 
-void wxMenuBar::SetLabel(int id, const wxString& label)
+wxMenuBar::wxMenuBar(int count, wxMenu *menus[], const wxString titles[])
 {
 {
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
+    Init();
 
 
-    if (!item)
-        return;
+    m_titles.Alloc(count);
 
 
-    // TODO
+    for ( int i = 0; i < count; i++ )
+    {
+        m_menus.Append(menus[i]);
+        m_titles.Add(titles[i]);
+
+        menus[i]->Attach(this);
+    }
 }
 
 }
 
-wxString wxMenuBar::GetLabel(int id) const
+wxMenuBar::~wxMenuBar()
 {
 {
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-
-    if (!item)
-        return wxString("");
+       if (s_macInstalledMenuBar == this)
+       {
+               ::ClearMenuBar();
+               s_macInstalledMenuBar = NULL;
+       }
 
 
-    // TODO
-    return wxString("") ;
 }
 
 }
 
-void wxMenuBar::SetLabelTop(int pos, const wxString& label)
+void wxMenuBar::Refresh()
 {
 {
-    // TODO
+    wxCHECK_RET( IsAttached(), wxT("can't refresh unatteched menubar") );
+
+    DrawMenuBar();
 }
 
 }
 
-wxString wxMenuBar::GetLabelTop(int pos) const
+#if wxUSE_ACCEL
+
+void wxMenuBar::RebuildAccelTable()
 {
 {
-    // TODO
-    return wxString("");
+    // merge the accelerators of all menus into one accel table
+    size_t nAccelCount = 0;
+    size_t i, count = GetMenuCount();
+    for ( i = 0; i < count; i++ )
+    {
+        nAccelCount += m_menus[i]->GetAccelCount();
+    }
+
+    if ( nAccelCount )
+    {
+        wxAcceleratorEntry *accelEntries = new wxAcceleratorEntry[nAccelCount];
+
+        nAccelCount = 0;
+        for ( i = 0; i < count; i++ )
+        {
+            nAccelCount += m_menus[i]->CopyAccels(&accelEntries[nAccelCount]);
+        }
+
+        m_accelTable = wxAcceleratorTable(nAccelCount, accelEntries);
+
+        delete [] accelEntries;
+    }
 }
 
 }
 
-bool wxMenuBar::OnDelete(wxMenu *a_menu, int pos)
+#endif // wxUSE_ACCEL
+
+
+void wxMenuBar::MacInstallMenuBar() 
 {
 {
-    // TODO
-    return FALSE;
+       Handle menubar = ::GetNewMBar( kwxMacMenuBarResource ) ;
+       wxString message ;
+       wxCHECK_RET( menubar != NULL, "can't read MBAR resource" );
+       ::SetMenuBar( menubar ) ;
+       ::DisposeHandle( menubar ) ;
+
+               MenuHandle menu = ::GetMenuHandle( kwxMacAppleMenuId ) ;
+               ::AppendResMenu(menu, 'DRVR');
+ 
+       for (int i = 0; i < m_menus.GetCount(); i++)
+       {
+                       Str255  label;
+       wxNode *node;
+       wxMenuItem *item;
+       int pos ;
+                       wxMenu* menu = m_menus[i] , *subMenu = NULL ;
+               
+                       
+                       if( m_titles[i] == "?" || m_titles[i] == "&?"  || m_titles[i] == wxApp::s_macHelpMenuTitleName )
+                       {
+                               MenuHandle mh = NULL ;
+                               if ( HMGetHelpMenuHandle( &mh ) != noErr )
+                               {
+                                       continue ;
+                               }
+                               if ( formerHelpMenuItems == 0 )
+                               {
+                                       if( mh )
+                                               formerHelpMenuItems = CountMenuItems( mh ) ;
+                               }
+                                       
+                       for (pos = 0 , node = menu->GetMenuItems().First(); node; node = node->Next(), pos++) 
+                       {
+                                       item = (wxMenuItem *)node->Data();
+                                       subMenu = item->GetSubMenu() ;
+                                       if (subMenu)                    
+                                       {
+                                               // we don't support hierarchical menus in the help menu yet
+                                       }
+                                       else            
+                                       {
+                                               if ( item->IsSeparator() )
+                                               {
+                                                       if ( mh )
+                                                               ::AppendMenu(mh, "\p-" );
+                                               }
+                                               else
+                                               {
+                                                       Str255 label ;
+                                                       wxMacBuildMenuString( label , NULL , NULL , item->GetText(), item->GetId() != wxApp::s_macAboutMenuItemId); // no shortcut in about menu
+                                                       if ( label[0] == 0 )
+                                                       {
+                                                               // we cannot add empty menus on mac
+                                                               label[0] = 1 ;
+                                                               label[1] = ' ' ;
+                                                       }
+                                                       if ( item->GetId() == wxApp::s_macAboutMenuItemId )
+                                                       { 
+                                                                       ::SetMenuItemText( GetMenuHandle( kwxMacAppleMenuId ) , 1 , label );
+                       //                                      ::EnableMenuItem( GetMenuHandle( kwxMacAppleMenuId ) , 1 );
+                                                                       ::EnableItem( GetMenuHandle( kwxMacAppleMenuId ) , 1 );
+                                                       }
+                                                       else
+                                                       {
+                                                               if ( mh )
+                                                                       ::AppendMenu(mh, label );
+                                                       }
+                                               }
+                                       }
+                               }
+                       }
+                       else
+                       {
+                               wxMacBuildMenuString( label, NULL , NULL , m_titles[i] , false );
+                               UMASetMenuTitle( menu->GetHMenu() , label ) ;
+                       for (pos = 0, node = menu->GetMenuItems().First(); node; node = node->Next(), pos++) 
+                       {
+                                       item = (wxMenuItem *)node->Data();
+                                       subMenu = item->GetSubMenu() ;
+                                       if (subMenu)                    
+                                       {
+                                               ::InsertMenu( subMenu->GetHMenu() , -1 ) ;
+                                       }
+                               }
+                               ::InsertMenu(m_menus[i]->GetHMenu(), 0);
+                       }
+               }
+               ::DrawMenuBar() ;
+
+       s_macInstalledMenuBar = this;
 }
 
 }
 
-bool wxMenuBar::OnAppend(wxMenu *a_menu, const char *title)
+void wxMenuBar::EnableTop(size_t pos, bool enable)
 {
 {
-    // TODO
-    return FALSE;
+    wxCHECK_RET( IsAttached(), wxT("doesn't work with unattached menubars") );
+       m_menus[pos]->MacEnableMenu( enable ) ;
+    Refresh();
 }
 
 }
 
-void wxMenuBar::Append (wxMenu * menu, const wxString& title)
+void wxMenuBar::SetLabelTop(size_t pos, const wxString& label)
 {
 {
-    if (!OnAppend(menu, title))
-        return;
+    wxCHECK_RET( pos < GetMenuCount(), wxT("invalid menu index") );
 
 
-    m_menuCount ++;
-    wxMenu **new_menus = new wxMenu *[m_menuCount];
-    wxString *new_titles = new wxString[m_menuCount];
-    int i;
+    m_titles[pos] = label;
 
 
-    for (i = 0; i < m_menuCount - 1; i++)
-       {
-        new_menus[i] = m_menus[i];
-        m_menus[i] = NULL;
-        new_titles[i] = m_titles[i];
-        m_titles[i] = "";
-    }
-    if (m_menus)
+    if ( !IsAttached() )
     {
     {
-        delete[]m_menus;
-        delete[]m_titles;
+        return;
     }
     }
-    m_menus = new_menus;
-    m_titles = new_titles;
 
 
-    m_menus[m_menuCount - 1] = (wxMenu *)menu;
-    m_titles[m_menuCount - 1] = title;
+    m_menus[pos]->SetTitle( label ) ;
+       if (wxMenuBar::s_macInstalledMenuBar == this) // are we currently installed ?
+       {
+               ::SetMenuBar( GetMenuBar() ) ;
+               ::InvalMenuBar() ;
+       }
+}
+
+wxString wxMenuBar::GetLabelTop(size_t pos) const
+{
+    wxCHECK_MSG( pos < GetMenuCount(), wxEmptyString,
+                 wxT("invalid menu index in wxMenuBar::GetLabelTop") );
 
 
-    // TODO
+    return m_titles[pos];
 }
 
 }
 
-void wxMenuBar::Delete(wxMenu * menu, int i)
+int wxMenuBar::FindMenu(const wxString& title)
 {
 {
-    int j;
-    int ii = (int) i;
+    wxString menuTitle = wxStripMenuCodes(title);
 
 
-    if (menu != 0)
+    size_t count = GetMenuCount();
+    for ( size_t i = 0; i < count; i++ )
     {
     {
-           for (ii = 0; ii < m_menuCount; ii++)
-        {
-            if (m_menus[ii] == menu)
-            break;
-           }
-        if (ii >= m_menuCount)
-            return;
-    } else
-    {
-        if (ii < 0 || ii >= m_menuCount)
-            return;
-        menu = m_menus[ii];
+        wxString title = wxStripMenuCodes(m_titles[i]);
+        if ( menuTitle == title )
+            return i; 
     }
 
     }
 
-    if (!OnDelete(menu, ii))
-        return;
+    return wxNOT_FOUND;
 
 
-    menu->SetParent(NULL);
+}
+
+
+// ---------------------------------------------------------------------------
+// wxMenuBar construction
+// ---------------------------------------------------------------------------
+
+// ---------------------------------------------------------------------------
+// wxMenuBar construction
+// ---------------------------------------------------------------------------
+
+wxMenu *wxMenuBar::Replace(size_t pos, wxMenu *menu, const wxString& title)
+{
+    wxMenu *menuOld = wxMenuBarBase::Replace(pos, menu, title);
+    if ( !menuOld )
+        return FALSE;
+    m_titles[pos] = title;
 
 
-    -- m_menuCount;
-    for (j = ii; j < m_menuCount; j++)
+    if ( IsAttached() )
     {
     {
-        m_menus[j] = m_menus[j + 1];
-        m_titles[j] = m_titles[j + 1];
+               if (s_macInstalledMenuBar == this)
+               {
+                       ::DeleteMenu( menuOld->MacGetMenuId() /* m_menus[pos]->MacGetMenuId() */ ) ;
+                       {
+                               Str255  label;
+                               wxMacBuildMenuString( label, NULL , NULL , title , false );
+                               UMASetMenuTitle( menu->GetHMenu() , label ) ;
+                               if ( pos == m_menus.GetCount() - 1)
+                               {
+                                       ::InsertMenu( menu->GetHMenu() , 0 ) ;
+                               }
+                               else
+                               {
+                                       ::InsertMenu( menu->GetHMenu() , m_menus[pos+1]->MacGetMenuId() ) ;
+                               }
+                       }
+               }
+
+
+#if wxUSE_ACCEL
+        if ( menuOld->HasAccels() || menu->HasAccels() )
+        {
+            // need to rebuild accell table
+            RebuildAccelTable();
+        }
+#endif // wxUSE_ACCEL
+
+        Refresh();
     }
     }
+
+    return menuOld;
 }
 
 }
 
-// Find the menu menuString, item itemString, and return the item id.
-// Returns -1 if none found.
-int wxMenuBar::FindMenuItem (const wxString& menuString, const wxString& itemString) const
+bool wxMenuBar::Insert(size_t pos, wxMenu *menu, const wxString& title)
 {
 {
-    char buf1[200];
-    char buf2[200];
-    wxStripMenuCodes ((char *)(const char *)menuString, buf1);
-    int i;
-    for (i = 0; i < m_menuCount; i++)
+    if ( !wxMenuBarBase::Insert(pos, menu, title) )
+        return FALSE;
+
+    m_titles.Insert(title, pos);
+
+    menu->Attach(this);
+
+    if ( IsAttached() )
     {
     {
-        wxStripMenuCodes ((char *)(const char *)m_titles[i], buf2);
-        if (strcmp (buf1, buf2) == 0)
-            return m_menus[i]->FindItem (itemString);
+       if ( pos == (size_t) -1 )
+               {
+                       ::InsertMenu( menu->GetHMenu() , 0 ) ;
+               }
+               else
+               {
+                       ::InsertMenu( menu->GetHMenu() , m_menus[pos+1]->MacGetMenuId() ) ;
+               }
+
+#if wxUSE_ACCEL
+        if ( menu->HasAccels() )
+        {
+            // need to rebuild accell table
+            RebuildAccelTable();
+        }
+#endif // wxUSE_ACCEL
+
+        Refresh();
     }
     }
-    return -1;
+
+    return TRUE;
 }
 
 }
 
-wxMenuItem *wxMenuBar::FindItemForId (int Id, wxMenu ** itemMenu) const
+void wxMenuBar::MacMenuSelect(wxEvtHandler* handler, long when , int macMenuId, int macMenuItemNum)
 {
 {
-    if (itemMenu)
-        *itemMenu = NULL;
+       // first scan fast for direct commands, i.e. menus which have these commands directly in their own list
 
 
-    wxMenuItem *item = NULL;
-    int i;
-    for (i = 0; i < m_menuCount; i++)
-        if ((item = m_menus[i]->FindItemForId (Id, itemMenu)))
-            return item;
-    return NULL;
+       if ( macMenuId == kwxMacAppleMenuId && macMenuItemNum == 1 )
+       {
+                       wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED, wxApp::s_macAboutMenuItemId );
+                       event.m_timeStamp = when;
+                       event.SetEventObject(handler);
+       event.SetInt( wxApp::s_macAboutMenuItemId );
+                       handler->ProcessEvent(event);
+       }
+       else
+       {               
+         for (int i = 0; i < m_menus.GetCount() ; i++)
+         {
+               if ( m_menus[i]->MacGetMenuId() == macMenuId || 
+                       ( macMenuId == kHMHelpMenuID && ( m_titles[i] == "?" || m_titles[i] == "&?"  || m_titles[i] == wxApp::s_macHelpMenuTitleName ) )
+                       )
+               {
+                       if ( m_menus[i]->MacMenuSelect( handler , when , macMenuId , macMenuItemNum ) )
+                               return ;
+                       else
+                       {
+                               //TODO flag this as an error since it must contain the item
+                               return ;
+                       }
+               }
+               }
+       
+         for (int i = 0; i < m_menus.GetCount(); i++)
+         {
+               if ( m_menus[i]->MacMenuSelect( handler , when , macMenuId , macMenuItemNum ) )
+               {
+                       break ;
+               }
+         }
+       }
 }
 
 }
 
-void wxMenuBar::SetHelpString (int Id, const wxString& helpString)
+wxMenu *wxMenuBar::Remove(size_t pos)
 {
 {
-    int i;
-    for (i = 0; i < m_menuCount; i++)
+    wxMenu *menu = wxMenuBarBase::Remove(pos);
+    if ( !menu )
+        return NULL;
+
+    if ( IsAttached() )
     {
     {
-        if (m_menus[i]->FindItemForId (Id))
+               if (s_macInstalledMenuBar == this)
+               {
+                       ::DeleteMenu( menu->MacGetMenuId() /* m_menus[pos]->MacGetMenuId() */ ) ;
+               }
+
+        menu->Detach();
+
+#if wxUSE_ACCEL
+        if ( menu->HasAccels() )
         {
         {
-            m_menus[i]->SetHelpString (Id, helpString);
-            return;
+            // need to rebuild accell table
+            RebuildAccelTable();
         }
         }
+#endif // wxUSE_ACCEL
+
+        Refresh();
     }
     }
+
+    m_titles.Remove(pos);
+
+    return menu;
 }
 
 }
 
-wxString wxMenuBar::GetHelpString (int Id) const
+bool wxMenuBar::Append(wxMenu *menu, const wxString& title)
 {
 {
-    int i;
-    for (i = 0; i < m_menuCount; i++)
+    WXHMENU submenu = menu ? menu->GetHMenu() : 0;
+    wxCHECK_MSG( submenu, FALSE, wxT("can't append invalid menu to menubar") );
+
+    if ( !wxMenuBarBase::Append(menu, title) )
+        return FALSE;
+
+    menu->Attach(this);
+
+    m_titles.Add(title);
+
+    if ( IsAttached() )
+    {
+               if (s_macInstalledMenuBar == this)
+               {
+                       ::InsertMenu( menu->GetHMenu() , 0 ) ;
+               }
+
+#if wxUSE_ACCEL
+        if ( menu->HasAccels() )
+        {
+            // need to rebuild accell table
+            RebuildAccelTable();
+        }
+#endif // wxUSE_ACCEL
+
+        Refresh();
+    }
+
+    return TRUE;
+}
+
+// ---------------------------------------------------------------------------
+// wxMenuBar searching for menu items
+// ---------------------------------------------------------------------------
+
+// Find the itemString in menuString, and return the item id or wxNOT_FOUND
+int wxMenuBar::FindMenuItem(const wxString& menuString,
+                            const wxString& itemString) const
+{
+    wxString menuLabel = wxStripMenuCodes(menuString);
+    size_t count = GetMenuCount();
+    for ( size_t i = 0; i < count; i++ )
     {
     {
-        if (m_menus[i]->FindItemForId (Id))
-            return wxString(m_menus[i]->GetHelpString (Id));
+        wxString title = wxStripMenuCodes(m_titles[i]);
+        if ( menuString == title )
+            return m_menus[i]->FindItem(itemString);
     }
     }
-    return wxString("");
+
+    return wxNOT_FOUND;
+}
+
+wxMenuItem *wxMenuBar::FindItem(int id, wxMenu **itemMenu) const
+{
+    if ( itemMenu )
+        *itemMenu = NULL;
+
+    wxMenuItem *item = NULL;
+    size_t count = GetMenuCount();
+    for ( size_t i = 0; !item && (i < count); i++ )
+    {
+        item = m_menus[i]->FindItem(id, itemMenu);
+    }
+
+    return item;
 }
 
 
 }
 
 
wxWidgets (Impactor)