cleaned up the checkbox creation code (~70 lines of code became 3)

[wxWidgets.git] / src / msw / ole / automtn.cpp

diff --git a/src/msw/ole/automtn.cpp b/src/msw/ole/automtn.cpp
index 5f83323c4cf3102496610374538c28961e2411f7..ac4e48776dccdceb891813e33cde62102fe18826 100644 (file)
--- a/src/msw/ole/automtn.cpp
+++ b/src/msw/ole/automtn.cpp
@@ -20,15 +20,19 @@
 #pragma hdrstop
 #endif
 
-#include "wx/log.h"
+#include "wx/defs.h"
 
-#include <math.h>
-#include <time.h>
+// Watcom C++ gives a linker error if this is compiled in.
+// With Borland C++, all samples crash if this is compiled in.
+#if wxUSE_OLE &&!defined(__WATCOMC__) && !(defined(__BORLANDC__) && (__BORLANDC__ < 0x520)) && !defined(__CYGWIN10__)
 
+#include "wx/log.h"
 #include "wx/msw/ole/automtn.h"
-
 #include "wx/msw/private.h"
 
+#include <math.h>
+#include <time.h>
+
 #include <wtypes.h>
 #include <unknwn.h>
 #include <ole2.h>
@@ -81,9 +85,11 @@ static wxString ConvertStringFromOle(BSTR bStr);
 static int rgMonthDays[13] =
        {0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334, 365};
 
+#if wxUSE_TIMEDATE
 static BOOL OleDateFromTm(WORD wYear, WORD wMonth, WORD wDay,
        WORD wHour, WORD wMinute, WORD wSecond, DATE& dtDest);
 static BOOL TmFromOleDate(DATE dtSrc, struct tm& tmDest);
+#endif // wxUSE_TIMEDATE
 
 static void ClearVariant(VARIANTARG *pvarg) ;
 static void ReleaseVariant(VARIANTARG *pvarg) ;
@@ -427,17 +433,13 @@ WXIDISPATCH* wxAutomationObject::GetDispatchProperty(const wxString& property, i
        wxVariant retVariant;
        if (Invoke(property, DISPATCH_PROPERTYGET, retVariant, noArgs, args))
        {
-               if (retVariant.GetType() == T("void*"))
+               if (retVariant.GetType() == wxT("void*"))
                {
                        return (WXIDISPATCH*) retVariant.GetVoidPtr();
                }
-               else
-               {
-                       return (WXIDISPATCH*) NULL;
-               }
        }
-       else
-               return (WXIDISPATCH*) NULL;
+
+       return (WXIDISPATCH*) NULL;
 }
 
 // A way of initialising another wxAutomationObject with a dispatch object
@@ -467,19 +469,19 @@ bool wxAutomationObject::GetInstance(const wxString& classId) const
        
        if (FAILED(CLSIDFromProgID((BSTR) unicodeName, &clsId))) 
        {
-               wxLogWarning(T("Cannot obtain CLSID from ProgID"));
+               wxLogWarning(wxT("Cannot obtain CLSID from ProgID"));
                return FALSE;
        }
 
        if (FAILED(GetActiveObject(clsId, NULL, &pUnk)))
        {
-               wxLogWarning(T("Cannot find an active object"));
+               wxLogWarning(wxT("Cannot find an active object"));
                return FALSE;
        }
        
        if (pUnk->QueryInterface(IID_IDispatch, (LPVOID*) &m_dispatchPtr) != S_OK)
        {
-               wxLogWarning(T("Cannot find IDispatch interface"));
+               wxLogWarning(wxT("Cannot find IDispatch interface"));
                return FALSE;
        }
 
@@ -499,14 +501,14 @@ bool wxAutomationObject::CreateInstance(const wxString& classId) const
        
        if (FAILED(CLSIDFromProgID((BSTR) unicodeName, &clsId))) 
        {
-               wxLogWarning(T("Cannot obtain CLSID from ProgID"));
+               wxLogWarning(wxT("Cannot obtain CLSID from ProgID"));
                return FALSE;
        }
 
        // start a new copy of Excel, grab the IDispatch interface
        if (FAILED(CoCreateInstance(clsId, NULL, CLSCTX_LOCAL_SERVER, IID_IDispatch, (void**)&m_dispatchPtr))) 
        {
-               wxLogWarning(T("Cannot start an instance of this class."));
+               wxLogWarning(wxT("Cannot start an instance of this class."));
                return FALSE;
        }
        
@@ -525,17 +527,17 @@ bool ConvertVariantToOle(const wxVariant& variant, VARIANTARG& oleVariant)
 
     wxString type(variant.GetType());
 
-    if (type == T("long"))
+    if (type == wxT("long"))
     {
         oleVariant.vt = VT_I4;
         oleVariant.lVal = variant.GetLong() ;
     }
-    else if (type == T("double"))
+    else if (type == wxT("double"))
     {
         oleVariant.vt = VT_R8;
         oleVariant.dblVal = variant.GetDouble();
     }
-    else if (type == T("bool"))
+    else if (type == wxT("bool"))
     {
         oleVariant.vt = VT_BOOL;
         // 'bool' required for VC++ 4 apparently
@@ -545,13 +547,15 @@ bool ConvertVariantToOle(const wxVariant& variant, VARIANTARG& oleVariant)
         oleVariant.boolVal = variant.GetBool();
 #endif
     }
-    else if (type == T("string"))
+    else if (type == wxT("string"))
     {
         wxString str( variant.GetString() );
         oleVariant.vt = VT_BSTR;
         oleVariant.bstrVal = ConvertStringToOle(str);
     }
-    else if (type == T("date"))
+// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
+#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
+    else if (type == wxT("date"))
     {
         wxDate date( variant.GetDate() );
         oleVariant.vt = VT_DATE;
@@ -560,7 +564,7 @@ bool ConvertVariantToOle(const wxVariant& variant, VARIANTARG& oleVariant)
                                0, 0, 0, oleVariant.date))
                        return FALSE;
     }
-    else if (type == T("time"))
+    else if (type == wxT("time"))
     {
         wxTime time( variant.GetTime() );
         oleVariant.vt = VT_DATE;
@@ -569,12 +573,13 @@ bool ConvertVariantToOle(const wxVariant& variant, VARIANTARG& oleVariant)
                        time.GetHour(), time.GetMinute(), time.GetSecond(), oleVariant.date))
                        return FALSE;
     }
-    else if (type == T("void*"))
+#endif
+    else if (type == wxT("void*"))
     {
         oleVariant.vt = VT_DISPATCH;
         oleVariant.pdispVal = (IDispatch*) variant.GetVoidPtr();
     }
-    else if (type == T("list") || type == T("stringlist"))
+    else if (type == wxT("list") || type == wxT("stringlist"))
     {
         oleVariant.vt = VT_VARIANT | VT_ARRAY;
 
@@ -644,7 +649,8 @@ bool ConvertOleToVariant(const VARIANTARG& oleVariant, wxVariant& variant)
                }
        case VT_DATE:
                {
-                       struct tm tmTemp;
+#if wxUSE_TIMEDATE
+            struct tm tmTemp;
                        if (!TmFromOleDate(oleVariant.date, tmTemp))
                                return FALSE;
 
@@ -652,7 +658,9 @@ bool ConvertOleToVariant(const VARIANTARG& oleVariant, wxVariant& variant)
                        wxTime time(date, tmTemp.tm_hour, tmTemp.tm_min, tmTemp.tm_sec);
 
                        variant = time;
-                       break;
+#endif
+
+            break;
                }
        case VT_I4:
                {
@@ -673,8 +681,12 @@ bool ConvertOleToVariant(const VARIANTARG& oleVariant, wxVariant& variant)
 #else
                        variant = (bool) (oleVariant.bool != 0);
 #endif
+#else
+#ifndef HAVE_BOOL // Can't use bool operator if no native bool type
+                       variant = (long) (oleVariant.boolVal != 0);
 #else
                        variant = (bool) (oleVariant.boolVal != 0);
+#endif
 #endif
                        break;
                }
@@ -728,7 +740,7 @@ bool ConvertOleToVariant(const VARIANTARG& oleVariant, wxVariant& variant)
                }
        default:
                {
-                       wxLogError(T("wxAutomationObject::ConvertOleToVariant: Unknown variant value type"));
+                       wxLogError(wxT("wxAutomationObject::ConvertOleToVariant: Unknown variant value type"));
                        return FALSE;
                }
        }
@@ -1061,7 +1073,7 @@ static void ReleaseVariant(VARIANTARG *pvarg)
                }
                else 
                {
-                       wxLogWarning(T("ReleaseVariant: Array contains non-variant type"));
+                       wxLogWarning(wxT("ReleaseVariant: Array contains non-variant type"));
                }
                
                // Free the array itself.
@@ -1088,7 +1100,7 @@ static void ReleaseVariant(VARIANTARG *pvarg)
                                break;
                                
                        default:
-                               wxLogWarning(T("ReleaseVariant: Unknown type"));
+                               wxLogWarning(wxT("ReleaseVariant: Unknown type"));
                                break;
                }
        }
@@ -1159,3 +1171,5 @@ void ShowException(LPOLESTR szMember, HRESULT hr, EXCEPINFO *pexcep, unsigned in
 
 #endif
 
+#endif // __WATCOMC__
+