fixing overrelease and out-of-bounds write, fixes #13725

[wxWidgets.git] / src / common / msgout.cpp

diff --git a/src/common/msgout.cpp b/src/common/msgout.cpp
index 07889dbc592d2557d948d0dc3a8daa2f30835ec1..9647088067e24c9ff33cca816872d84f6065e779 100644 (file)
--- a/src/common/msgout.cpp
+++ b/src/common/msgout.cpp
@@ -118,7 +118,13 @@ void wxMessageOutputBest::Output(const wxString& str)
             return;
     }
 
             return;
     }
 

-    ::MessageBox(NULL, str.t_str(), NULL, MB_ICONINFORMATION | MB_OK);
+    wxString title;
+    if ( wxTheApp )
+        title = wxTheApp->GetAppDisplayName();
+    else // Use some title to avoid default "Error"
+        title = _("Message");
+
+    ::MessageBox(NULL, str.t_str(), title.t_str(), MB_ICONINFORMATION | MB_OK);

 #else // !__WINDOWS__
     // TODO: use the native message box for the other ports too
     wxMessageOutputStderr::Output(str);
 #else // !__WINDOWS__
     // TODO: use the native message box for the other ports too
     wxMessageOutputStderr::Output(str);


@@ -147,6 +153,8 @@ void wxMessageOutputStderr::Output(const wxString& str)
         fprintf(m_fp, "%s", (const char*) buf);
     else // print at least something
         fprintf(m_fp, "%s", (const char*) strWithLF.ToAscii());
         fprintf(m_fp, "%s", (const char*) buf);
     else // print at least something
         fprintf(m_fp, "%s", (const char*) strWithLF.ToAscii());

+
+    fflush(m_fp);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -155,7 +163,7 @@ void wxMessageOutputStderr::Output(const wxString& str)
 
 void wxMessageOutputDebug::Output(const wxString& str)
 {
 
 void wxMessageOutputDebug::Output(const wxString& str)
 {

-#if defined(__WXMSW__) && !defined(__WXMICROWIN__)
+#if defined(__WINDOWS__) && !defined(__WXMICROWIN__)

     wxString out(AppendLineFeedIfNeeded(str));
     out.Replace(wxT("\t"), wxT("        "));
     out.Replace(wxT("\n"), wxT("\r\n"));
     wxString out(AppendLineFeedIfNeeded(str));
     out.Replace(wxT("\t"), wxT("        "));
     out.Replace(wxT("\n"), wxT("\r\n"));


@@ -187,12 +195,14 @@ void wxMessageOutputLog::Output(const wxString& str)
 
 #if wxUSE_GUI && wxUSE_MSGDLG
 
 
 #if wxUSE_GUI && wxUSE_MSGDLG
 

+extern WXDLLEXPORT_DATA(const char) wxMessageBoxCaptionStr[] = "Message";
+

 void wxMessageOutputMessageBox::Output(const wxString& str)
 {
     wxString out(str);
 
     // the native MSW msg box understands the TABs, others don't
 void wxMessageOutputMessageBox::Output(const wxString& str)
 {
     wxString out(str);
 
     // the native MSW msg box understands the TABs, others don't

-#ifndef __WXMSW__
+#ifndef __WINDOWS__

     out.Replace(wxT("\t"), wxT("        "));
 #endif
 
     out.Replace(wxT("\t"), wxT("        "));
 #endif