set disposition to OPEN_ALWAYS for write and read-write modes (replaces patch 1836605)

[wxWidgets.git] / src / msw / combobox.cpp

diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp
index 93c931c85fdc01282c2fe5dea0943b2d25a59d89..bb651346225a7cbe8d9aa2ff066f8db3700fbdda 100644 (file)
--- a/src/msw/combobox.cpp
+++ b/src/msw/combobox.cpp
@@ -235,6 +235,9 @@ WXLRESULT wxComboBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lPara
             {
                 // combobox selection sometimes spontaneously changes when its
                 // size changes, restore it to the old value if necessary
             {
                 // combobox selection sometimes spontaneously changes when its
                 // size changes, restore it to the old value if necessary

+                if ( !GetEditHWNDIfAvailable() )
+                    break;
+

                 long fromOld, toOld;
                 GetSelection(&fromOld, &toOld);
                 WXLRESULT result = wxChoice::MSWWindowProc(nMsg, wParam, lParam);
                 long fromOld, toOld;
                 GetSelection(&fromOld, &toOld);
                 WXLRESULT result = wxChoice::MSWWindowProc(nMsg, wParam, lParam);


@@ -391,22 +394,24 @@ bool wxComboBox::MSWShouldPreProcessMessage(WXMSG *pMsg)
     return wxChoice::MSWShouldPreProcessMessage(pMsg);
 }
 
     return wxChoice::MSWShouldPreProcessMessage(pMsg);
 }
 

+WXHWND wxComboBox::GetEditHWNDIfAvailable() const
+{
+    // we assume that the only child of the combobox is the edit window so it's
+    // unnecessary to pass "EDIT" as class name parameter
+    return (WXHWND)::FindWindowEx(GetHwnd(), NULL, NULL, NULL);
+}
+

 WXHWND wxComboBox::GetEditHWND() const
 {
     // this function should not be called for wxCB_READONLY controls, it is
 WXHWND wxComboBox::GetEditHWND() const
 {
     // this function should not be called for wxCB_READONLY controls, it is

-    // the callers responsability to check this
+    // the callers responsibility to check this

     wxASSERT_MSG( !HasFlag(wxCB_READONLY),
                   _T("read-only combobox doesn't have any edit control") );
 
     wxASSERT_MSG( !HasFlag(wxCB_READONLY),
                   _T("read-only combobox doesn't have any edit control") );
 

-    POINT pt;
-    pt.x = pt.y = 4;
-    HWND hwndEdit = ::ChildWindowFromPoint(GetHwnd(), pt);
-    if ( !hwndEdit || hwndEdit == GetHwnd() )
-    {
-        wxFAIL_MSG(_T("combobox without edit control?"));
-    }
+    WXHWND hWndEdit = GetEditHWNDIfAvailable();
+    wxASSERT_MSG( hWndEdit, _T("combobox without edit control?") );

 
 

-    return (WXHWND)hwndEdit;
+    return hWndEdit;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -502,6 +507,12 @@ WXDWORD wxComboBox::MSWGetStyle(long style, WXDWORD *exstyle) const
 // wxComboBox text control-like methods
 // ----------------------------------------------------------------------------
 
 // wxComboBox text control-like methods
 // ----------------------------------------------------------------------------
 

+wxString wxComboBox::GetValue() const
+{
+    return HasFlag(wxCB_READONLY) ? GetStringSelection()
+                                  : wxTextEntry::GetValue();
+}
+

 void wxComboBox::SetValue(const wxString& value)
 {
     if ( HasFlag(wxCB_READONLY) )
 void wxComboBox::SetValue(const wxString& value)
 {
     if ( HasFlag(wxCB_READONLY) )


@@ -517,6 +528,21 @@ void wxComboBox::Clear()
         wxTextEntry::Clear();
 }
 
         wxTextEntry::Clear();
 }
 

+void wxComboBox::GetSelection(long *from, long *to) const
+{
+    if ( !HasFlag(wxCB_READONLY) )
+    {
+        wxTextEntry::GetSelection(from, to);
+    }
+    else // text selection doesn't make sense for read only comboboxes
+    {
+        if ( from )
+            *from = -1;
+        if ( to )
+            *to = -1;
+    }
+}
+

 bool wxComboBox::IsEditable() const
 {
     return !HasFlag(wxCB_READONLY) && wxTextEntry::IsEditable();
 bool wxComboBox::IsEditable() const
 {
     return !HasFlag(wxCB_READONLY) && wxTextEntry::IsEditable();


@@ -581,12 +607,12 @@ void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)
 
 void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)
 {
 
 void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)
 {

-    event.Enable( CanUndo() );
+    event.Enable( IsEditable() && CanUndo() );

 }
 
 void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)
 {
 }
 
 void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)
 {

-    event.Enable( CanRedo() );
+    event.Enable( IsEditable() && CanRedo() );

 }
 
 void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)
 }
 
 void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)