Since CE cannot do the logical/device origin calculations

[wxWidgets.git] / src / msw / toplevel.cpp

diff --git a/src/msw/toplevel.cpp b/src/msw/toplevel.cpp
index 1153dde708cd0bd56e17b822dec59648b6e1cf3e..eccae97c29db29351e40316a83490c1ed33fe930 100644 (file)
--- a/src/msw/toplevel.cpp
+++ b/src/msw/toplevel.cpp
@@ -31,6 +31,7 @@
 #ifndef WX_PRECOMP
     #include "wx/app.h"
     #include "wx/toplevel.h"
+    #include "wx/dialog.h"
     #include "wx/string.h"
     #include "wx/log.h"
     #include "wx/intl.h"
@@ -151,27 +152,24 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
                         (style & ~wxBORDER_MASK) | wxBORDER_NONE, exflags
                       ) & ~WS_CHILD & ~WS_VISIBLE;
 
+#if defined(__WXWINCE__) && _WIN32_WCE < 400
+    msflags |= WS_VISIBLE;
+#endif
+
     // first select the kind of window being created
     //
     // note that if we don't set WS_POPUP, Windows assumes WS_OVERLAPPED and
     // creates a window with both caption and border, hence we also test it
     // below in some other cases
     if ( style & wxFRAME_TOOL_WINDOW )
-        msflags |= WS_POPUP;
-    else
     {
-        if (msflags & WS_BORDER)
-            msflags |= WS_OVERLAPPED;
+        msflags |= WS_POPUP;
     }
-    
+    //else: WS_OVERLAPPED is 0 anyhow, so it is on by default
 
     // border and caption styles
     if ( style & wxRESIZE_BORDER )
-#ifndef WS_THICKFRAME
-        msflags = msflags;
-#else
         msflags |= WS_THICKFRAME;
-#endif
     else if ( exflags && ((style & wxBORDER_DOUBLE) || (style & wxBORDER_RAISED)) )
         *exflags |= WS_EX_DLGMODALFRAME;
     else if ( !(style & wxBORDER_NONE) )
@@ -179,16 +177,16 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
     else
         msflags |= WS_POPUP;
 
+    // normally we consider that all windows without caption must be popups,
+    // but CE is an exception: there windows normally do not have the caption
+    // but shouldn't be made popups as popups can't have menus and don't look
+    // like normal windows anyhow
     if ( style & wxCAPTION )
-#ifdef __WXWINCE__
-        msflags = msflags;
-#else
         msflags |= WS_CAPTION;
-#endif
+#ifndef __WXWINCE__
     else
         msflags |= WS_POPUP;
-
-    return msflags;
+#endif // !__WXWINCE__
 
     // next translate the individual flags
     if ( style & wxMINIMIZE_BOX )
@@ -198,15 +196,12 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
     if ( style & wxSYSTEM_MENU )
         msflags |= WS_SYSMENU;
 
-    // under CE these 2 styles are not defined currently
-#ifdef WS_MINIMIZE
+    // NB: under CE these 2 styles are not supported currently, we should
+    //     call Minimize()/Maximize() "manually" if we want to support them
     if ( style & wxMINIMIZE )
         msflags |= WS_MINIMIZE;
-#endif // WS_MINIMIZE
-#ifdef WS_MAXIMIZE
     if ( style & wxMAXIMIZE )
         msflags |= WS_MAXIMIZE;
-#endif // WS_MAXIMIZE
 
     // Keep this here because it saves recoding this function in wxTinyFrame
     if ( style & (wxTINY_CAPTION_VERT | wxTINY_CAPTION_HORIZ) )
@@ -214,6 +209,8 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
         
     if ( exflags )
     {
+        // there is no taskbar under CE, so omit all this
+#ifndef __WXWINCE__
         if ( !(GetExtraStyle() & wxTOPLEVEL_EX_DIALOG) )
         {
             if ( style & wxFRAME_TOOL_WINDOW )
@@ -225,8 +222,6 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
                 style |= wxFRAME_NO_TASKBAR;
             }
 
-            // again, support for this is missing under CE
-#ifdef WS_EX_APPWINDOW
             // We have to solve 2 different problems here:
             //
             // 1. frames with wxFRAME_NO_TASKBAR flag shouldn't appear in the
@@ -245,8 +240,8 @@ WXDWORD wxTopLevelWindowMSW::MSWGetStyle(long style, WXDWORD *exflags) const
                 *exflags |= WS_EX_APPWINDOW;
             }
             //else: nothing to do [here]
-#endif // WS_EX_APPWINDOW
         }
+#endif // !__WXWINCE__
 
         if ( style & wxSTAY_ON_TOP )
             *exflags |= WS_EX_TOPMOST;
@@ -389,10 +384,12 @@ bool wxTopLevelWindowMSW::CreateDialog(const void *dlgTemplate,
         y = (sizeDpy.y - h) / 2;
     }
 
+#ifndef __WXWINCE__
     if ( !::MoveWindow(GetHwnd(), x, y, w, h, FALSE) )
     {
         wxLogLastError(wxT("MoveWindow"));
     }
+#endif
 
     if ( !title.empty() )
     {
@@ -920,7 +917,7 @@ void wxTopLevelWindowMSW::OnActivate(wxActivateEvent& event)
 
 // the DialogProc for all wxWindows dialogs
 LONG APIENTRY _EXPORT
-wxDlgProc(HWND WXUNUSED(hDlg),
+wxDlgProc(HWND hDlg,
           UINT message,
           WPARAM WXUNUSED(wParam),
           LPARAM WXUNUSED(lParam))
@@ -931,6 +928,16 @@ wxDlgProc(HWND WXUNUSED(hDlg),
             // for this message, returning TRUE tells system to set focus to
             // the first control in the dialog box, but as we set the focus
             // ourselves, we return FALSE from here as well, so fall through
+#ifdef __WXWINCE__
+        {
+            SHINITDLGINFO shidi;
+            shidi.dwMask = SHIDIM_FLAGS;
+            shidi.dwFlags = SHIDIF_DONEBUTTON |
+                            SHIDIF_SIZEDLGFULLSCREEN;
+            shidi.hDlg = hDlg;
+            SHInitDialog( &shidi );
+        }
+#endif
 
         default:
             // for all the other ones, FALSE means that we didn't process the