removed code refreshing toolbar on every MDI child move -- no idea why was it there...

[wxWidgets.git] / src / mac / carbon / frame.cpp

diff --git a/src/mac/carbon/frame.cpp b/src/mac/carbon/frame.cpp
index 25820c27684f14693a59038cb910ed32521b5aec..12853edfa48683492d2c2e78c584a9df6866887f 100644 (file)
--- a/src/mac/carbon/frame.cpp
+++ b/src/mac/carbon/frame.cpp
@@ -9,10 +9,6 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "frame.h"
-#endif
-
 #include "wx/wxprec.h"
 
 #include "wx/frame.h"
@@ -41,6 +37,7 @@ END_EVENT_TABLE()
 IMPLEMENT_DYNAMIC_CLASS(wxFrame, wxTopLevelWindow)
 
 #define WX_MAC_STATUSBAR_HEIGHT 18
+
 // ----------------------------------------------------------------------------
 // creation/destruction
 // ----------------------------------------------------------------------------
@@ -48,18 +45,19 @@ IMPLEMENT_DYNAMIC_CLASS(wxFrame, wxTopLevelWindow)
 void wxFrame::Init()
 {
     m_frameMenuBar = NULL;
+    m_frameStatusBar = NULL;
+    m_winLastFocused = NULL;
 
 #if wxUSE_TOOLBAR
-    m_frameToolBar = NULL ;
+    m_frameToolBar = NULL;
 #endif
-    m_frameStatusBar = NULL;
-    m_winLastFocused = NULL ;
-
-    m_iconized = false;
 
 #if wxUSE_TOOLTIPS
-    m_hwndToolTip = 0;
+    // NB: is this used anywhere?
+    m_hwndToolTip = NULL;
 #endif
+
+    m_iconized = false;
 }
 
 bool wxFrame::Create(wxWindow *parent,
@@ -89,14 +87,14 @@ wxFrame::~wxFrame()
 wxPoint wxFrame::GetClientAreaOrigin() const
 {
     wxPoint pt = wxTopLevelWindow::GetClientAreaOrigin();
-    
+
 #if wxUSE_TOOLBAR && !defined(__WXUNIVERSAL__)
     wxToolBar *toolbar = GetToolBar();
     if ( toolbar && toolbar->IsShown() )
     {
         int w, h;
         toolbar->GetSize(&w, &h);
-        
+
         if ( toolbar->GetWindowStyleFlag() & wxTB_VERTICAL )
         {
             pt.x += w;
@@ -108,8 +106,8 @@ wxPoint wxFrame::GetClientAreaOrigin() const
 #endif
         }
     }
-#endif // wxUSE_TOOLBAR
-    
+#endif
+
     return pt;
 }
 
@@ -120,7 +118,7 @@ bool wxFrame::Enable(bool enable)
 
     if ( m_frameMenuBar && m_frameMenuBar == wxMenuBar::MacGetInstalledMenuBar() )
     {
-         int iMaxMenu = m_frameMenuBar->GetMenuCount();
+        int iMaxMenu = m_frameMenuBar->GetMenuCount();
         for ( int i = 0 ; i < iMaxMenu ; ++ i )
         {
             m_frameMenuBar->EnableTop( i , enable ) ;
@@ -133,12 +131,12 @@ bool wxFrame::Enable(bool enable)
 wxStatusBar *wxFrame::OnCreateStatusBar(int number, long style, wxWindowID id,
     const wxString& name)
 {
-    wxStatusBar *statusBar = NULL;
+    wxStatusBar *statusBar;
 
-    statusBar = new wxStatusBar(this, id,
-        style, name);
-    statusBar->SetSize( 100 , WX_MAC_STATUSBAR_HEIGHT ) ;
+    statusBar = new wxStatusBar(this, id, style, name);
+    statusBar->SetSize(100 , WX_MAC_STATUSBAR_HEIGHT);
     statusBar->SetFieldsCount(number);
+
     return statusBar;
 }
 
@@ -164,6 +162,7 @@ void wxFrame::OnSysColourChanged(wxSysColourChangedEvent& event)
     if ( m_frameStatusBar )
     {
         wxSysColourChangedEvent event2;
+
         event2.SetEventObject( m_frameStatusBar );
         m_frameStatusBar->ProcessEvent(event2);
     }
@@ -172,7 +171,6 @@ void wxFrame::OnSysColourChanged(wxSysColourChangedEvent& event)
     wxWindow::OnSysColourChanged(event);
 }
 
-
 // Default activation behaviour - set the focus for the first child
 // subwindow found.
 void wxFrame::OnActivate(wxActivateEvent& event)
@@ -189,9 +187,7 @@ void wxFrame::OnActivate(wxActivateEvent& event)
             if ( win->IsTopLevel() )
             {
                 if ( win != this )
-                {
                     m_winLastFocused = NULL;
-                }
 
                 break;
             }
@@ -204,23 +200,23 @@ void wxFrame::OnActivate(wxActivateEvent& event)
     else
     {
         // restore focus to the child which was last focused
-        wxWindow *parent = m_winLastFocused ? m_winLastFocused->GetParent()
-                                            : NULL;
+        wxWindow *parent = m_winLastFocused
+            ? m_winLastFocused->GetParent()
+            : NULL;
+
         if ( !parent )
-        {
             parent = this;
-        }
 
         wxSetFocusToChild(parent, &m_winLastFocused);
 
-        if ( m_frameMenuBar != NULL )
+        if (m_frameMenuBar != NULL)
         {
             m_frameMenuBar->MacInstallMenuBar() ;
         }
         else if (wxTheApp->GetTopWindow() && wxTheApp->GetTopWindow()->IsKindOf(CLASSINFO(wxFrame)))
         {
-            // Trying toplevel frame menbar
-            if( ((wxFrame*)wxTheApp->GetTopWindow())->GetMenuBar() )
+            // Trying toplevel frame membar
+            if (((wxFrame*)wxTheApp->GetTopWindow())->GetMenuBar())
                 ((wxFrame*)wxTheApp->GetTopWindow())->GetMenuBar()->MacInstallMenuBar();
          }
     }
@@ -229,33 +225,41 @@ void wxFrame::OnActivate(wxActivateEvent& event)
 void wxFrame::DetachMenuBar()
 {
     if ( m_frameMenuBar )
-    {
         m_frameMenuBar->UnsetInvokingWindow();
-    }
 
     wxFrameBase::DetachMenuBar();
 }
 
 void wxFrame::AttachMenuBar( wxMenuBar *menuBar )
 {
-    wxFrameBase::AttachMenuBar(menuBar);
+    wxFrame* tlf = wxDynamicCast( wxFindWinFromMacWindow( FrontNonFloatingWindow() ) , wxFrame );
+    bool makeCurrent = false;
+
+    // if this is already the current menubar or we are the frontmost window
+    if ( (tlf == this) || (m_frameMenuBar == wxMenuBar::MacGetInstalledMenuBar()) )
+        makeCurrent = true;
+    // or there is an app-level menubar like MDI
+    else if ( tlf && (tlf->GetMenuBar() == NULL) && (((wxFrame*)wxTheApp->GetTopWindow()) == this) )
+        makeCurrent = true;
+
+    wxFrameBase::AttachMenuBar( menuBar );
 
     if (m_frameMenuBar)
     {
         m_frameMenuBar->SetInvokingWindow( this );
+        if (makeCurrent)
+            m_frameMenuBar->MacInstallMenuBar();
     }
 }
 
 void wxFrame::DoGetClientSize(int *x, int *y) const
 {
-    wxTopLevelWindow::DoGetClientSize( x , y ) ;
+    wxTopLevelWindow::DoGetClientSize( x , y );
 
 #if wxUSE_STATUSBAR
     if ( GetStatusBar() && GetStatusBar()->IsShown() && y )
-    {
         *y -= WX_MAC_STATUSBAR_HEIGHT;
-    }
-#endif // wxUSE_STATUSBAR
+#endif
 
 #if wxUSE_TOOLBAR
     wxToolBar *toolbar = GetToolBar();
@@ -266,17 +270,18 @@ void wxFrame::DoGetClientSize(int *x, int *y) const
 
         if ( toolbar->GetWindowStyleFlag() & wxTB_VERTICAL )
         {
-            if ( x )  *x -= w;
+            if ( x )
+                *x -= w;
         }
         else
         {
-#if wxMAC_USE_NATIVE_TOOLBAR
-            // todo verify whether HIToolBox is giving correct sizes here for the tlw
-            if ( y )  *y -= h;
+#if !wxMAC_USE_NATIVE_TOOLBAR
+            if ( y )
+                *y -= h;
 #endif
         }
     }
-#endif // wxUSE_TOOLBAR
+#endif
 }
 
 bool wxFrame::MacIsChildOfClientArea( const wxWindow* child ) const
@@ -284,12 +289,12 @@ bool wxFrame::MacIsChildOfClientArea( const wxWindow* child ) const
 #if wxUSE_STATUSBAR
     if ( child == GetStatusBar() )
         return false ;
-#endif // wxUSE_STATUSBAR
+#endif
 
 #if wxUSE_TOOLBAR
     if ( child == GetToolBar() )
         return false ;
-#endif // wxUSE_TOOLBAR
+#endif
 
     return wxFrameBase::MacIsChildOfClientArea( child ) ;
 }
@@ -308,27 +313,25 @@ void wxFrame::DoSetClientSize(int clientwidth, int clientheight)
 
     // find the current client size
 
-  // Find the difference between the entire window (title bar and all)
-  // and the client area; add this to the new client size to move the
-  // window
-
+    // Find the difference between the entire window (title bar and all) and
+    // the client area; add this to the new client size to move the window
     DoSetSize( -1 , -1 , currentwidth + clientwidth - currentclientwidth ,
         currentheight + clientheight - currentclientheight , wxSIZE_USE_EXISTING ) ;
 }
 
-
 #if wxUSE_TOOLBAR
 void wxFrame::SetToolBar(wxToolBar *toolbar)
 {
     if ( m_frameToolBar == toolbar )
         return ;
-    
+
 #if wxMAC_USE_NATIVE_TOOLBAR
     if ( m_frameToolBar )
-        m_frameToolBar->MacInstallNativeToolbar(false) ;
+        m_frameToolBar->MacInstallNativeToolbar( false ) ;
 #endif
-    
+
     m_frameToolBar = toolbar ;
+
 #if wxMAC_USE_NATIVE_TOOLBAR
     if ( toolbar )
         toolbar->MacInstallNativeToolbar( true ) ;
@@ -338,9 +341,7 @@ void wxFrame::SetToolBar(wxToolBar *toolbar)
 wxToolBar* wxFrame::CreateToolBar(long style, wxWindowID id, const wxString& name)
 {
     if ( wxFrameBase::CreateToolBar(style, id, name) )
-    {
         PositionToolBar();
-    }
 
     return m_frameToolBar;
 }
@@ -351,19 +352,20 @@ void wxFrame::PositionToolBar()
 
     GetSize( &cw , &ch ) ;
 
-    if ( GetStatusBar() && GetStatusBar()->IsShown())
+    if (GetStatusBar() && GetStatusBar()->IsShown())
     {
-      int statusX, statusY;
-      GetStatusBar()->GetClientSize(&statusX, &statusY);
-      ch -= statusY;
+        int statusX, statusY;
+
+        GetStatusBar()->GetClientSize(&statusX, &statusY);
+        ch -= statusY;
     }
 
     if (GetToolBar())
     {
         int tx, ty, tw, th;
-        tx = ty = 0 ;
 
-        GetToolBar()->GetSize(& tw, & th);
+        tx = ty = 0 ;
+        GetToolBar()->GetSize(&tw, &th);
         if (GetToolBar()->GetWindowStyleFlag() & wxTB_VERTICAL)
         {
             // Use the 'real' position. wxSIZE_NO_ADJUSTMENTS
@@ -381,3 +383,4 @@ void wxFrame::PositionToolBar()
     }
 }
 #endif
+