/////////////////////////////////////////////////////////////////////////////
-// Name: imaggif.cpp
+// Name: src/common/imaggif.cpp
// Purpose: wxGIFHandler
// Author: Vaclav Slavik & Guillermo Rodriguez Garcia
// RCS-ID: $Id$
// Licence: wxWindows licence
/////////////////////////////////////////////////////////////////////////////
-/*
- We don't put pragma implement in this file because it is already present in
- src/common/image.cpp
-*/
-
// For compilers that support precompilation, includes "wx.h".
#include "wx/wxprec.h"
#ifdef __BORLANDC__
-# pragma hdrstop
+ #pragma hdrstop
#endif
+#if wxUSE_IMAGE && wxUSE_GIF
+
#ifndef WX_PRECOMP
-# include "wx/defs.h"
+ #include "wx/intl.h"
+ #include "wx/log.h"
#endif
-#if wxUSE_GIF
-
-#include "wx/image.h"
+#include "wx/imaggif.h"
#include "wx/gifdecod.h"
#include "wx/wfstream.h"
-#include "wx/log.h"
-#include "wx/intl.h"
-#if !USE_SHARED_LIBRARIES
IMPLEMENT_DYNAMIC_CLASS(wxGIFHandler,wxImageHandler)
-#endif
//-----------------------------------------------------------------------------
// wxGIFHandler
#if wxUSE_STREAMS
-bool wxGIFHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose, int WXUNUSED(index) )
+bool wxGIFHandler::LoadFile(wxImage *image, wxInputStream& stream,
+ bool verbose, int index)
{
wxGIFDecoder *decod;
int error;
- bool ok;
+ bool ok = true;
- decod = new wxGIFDecoder(&stream, TRUE);
+// image->Destroy();
+ decod = new wxGIFDecoder(&stream, true);
+ error = decod->ReadGIF();
- if ((error = decod->ReadGIF()) != wxGIF_OK)
+ if ((error != wxGIF_OK) && (error != wxGIF_TRUNCATED))
{
if (verbose)
{
switch (error)
{
- case wxGIF_INVFORMAT: wxLogError(_("wxGIFHandler: error in GIF image format")); break;
- case wxGIF_MEMERR: wxLogError(_("wxGIFHandler: couldn't allocate enough memory")); break;
- default: wxLogError(_("wxGIFHandler: unknown error !!!"));
+ case wxGIF_INVFORMAT:
+ wxLogError(_("GIF: error in GIF image format."));
+ break;
+ case wxGIF_MEMERR:
+ wxLogError(_("GIF: not enough memory."));
+ break;
+ default:
+ wxLogError(_("GIF: unknown error!!!"));
+ break;
}
}
delete decod;
- return FALSE;
+ return false;
+ }
+
+ if ((error == wxGIF_TRUNCATED) && verbose)
+ {
+ wxLogError(_("GIF: data stream seems to be truncated."));
+ /* go on; image data is OK */
+ }
+
+ if (index != -1)
+ {
+ // We're already on index = 0 by default. So no need
+ // to call GoFrame(0) then. On top of that GoFrame doesn't
+ // accept an index of 0. (Instead GoFirstFrame() should be used)
+ // Also if the gif image has only one frame, calling GoFrame(0)
+ // fails because GoFrame() only works with gif animations.
+ // (It fails if IsAnimation() returns false)
+ // All valid reasons to NOT call GoFrame when index equals 0.
+ if (index != 0)
+ {
+ ok = decod->GoFrame(index);
+ }
}
- image->Destroy();
- ok = decod->ConvertToImage(image);
+ if (ok)
+ {
+ ok = decod->ConvertToImage(image);
+ }
+ else
+ {
+ wxLogError(_("GIF: Invalid gif index."));
+ }
delete decod;
+
return ok;
}
wxOutputStream& WXUNUSED(stream), bool verbose )
{
if (verbose)
- wxLogDebug(wxT("wxGIFHandler is read-only!!"));
+ wxLogDebug(wxT("GIF: the handler is read-only!!"));
- return FALSE;
+ return false;
}
bool wxGIFHandler::DoCanRead( wxInputStream& stream )
{
- wxGIFDecoder *decod;
- bool ok;
-
- decod = new wxGIFDecoder(&stream);
- ok = decod->CanRead();
-
- delete decod;
- return ok;
+ wxGIFDecoder decod(&stream);
+ return decod.CanRead();
}
#endif // wxUSE_STREAMS