Found bug that skrewed up display wrt horizontal

[wxWidgets.git] / src / msw / pen.cpp

diff --git a/src/msw/pen.cpp b/src/msw/pen.cpp
index 50f821006a8042c5f1fc6e6838a4cb7de46e02f1..97d1e52b05181e97be1690d9b94dcabd9d86fcdf 100644 (file)
--- a/src/msw/pen.cpp
+++ b/src/msw/pen.cpp
@@ -32,9 +32,7 @@
 #include "wx/msw/private.h"
 #include "assert.h"
 
 #include "wx/msw/private.h"
 #include "assert.h"
 

-#if !USE_SHARED_LIBRARIES

 IMPLEMENT_DYNAMIC_CLASS(wxPen, wxGDIObject)
 IMPLEMENT_DYNAMIC_CLASS(wxPen, wxGDIObject)

-#endif

 
 wxPenRefData::wxPenRefData()
 {
 
 wxPenRefData::wxPenRefData()
 {


@@ -43,7 +41,7 @@ wxPenRefData::wxPenRefData()
   m_join = wxJOIN_ROUND ;
   m_cap = wxCAP_ROUND ;
   m_nbDash = 0 ;
   m_join = wxJOIN_ROUND ;
   m_cap = wxCAP_ROUND ;
   m_nbDash = 0 ;

-  m_dash = 0 ;
+  m_dash = (wxMSWDash*)NULL;

   m_hPen = 0;
 }
 
   m_hPen = 0;
 }
 


@@ -69,7 +67,7 @@ wxPenRefData::~wxPenRefData()
 
 wxPen::wxPen()
 {
 
 wxPen::wxPen()
 {

-  if ( wxThePenList )
+  if (wxThePenList)

     wxThePenList->AddPen(this);
 }
 
     wxThePenList->AddPen(this);
 }
 


@@ -91,7 +89,7 @@ wxPen::wxPen(const wxColour& col, int Width, int Style)
   M_PENDATA->m_join = wxJOIN_ROUND ;
   M_PENDATA->m_cap = wxCAP_ROUND ;
   M_PENDATA->m_nbDash = 0 ;
   M_PENDATA->m_join = wxJOIN_ROUND ;
   M_PENDATA->m_cap = wxCAP_ROUND ;
   M_PENDATA->m_nbDash = 0 ;

-  M_PENDATA->m_dash = 0 ;
+  M_PENDATA->m_dash = (wxMSWDash*)NULL;

   M_PENDATA->m_hPen = 0 ;
 
 #ifndef __WIN32__
   M_PENDATA->m_hPen = 0 ;
 
 #ifndef __WIN32__


@@ -125,139 +123,168 @@ wxPen::wxPen(const wxColour& col, int Width, int Style)
 
 wxPen::wxPen(const wxBitmap& stipple, int Width)
 {
 
 wxPen::wxPen(const wxBitmap& stipple, int Width)
 {

-  m_refData = new wxPenRefData;
+    m_refData = new wxPenRefData;

 
 //  M_PENDATA->m_colour = col;
 
 //  M_PENDATA->m_colour = col;

-  M_PENDATA->m_stipple = stipple;
-  M_PENDATA->m_width = Width;
-  M_PENDATA->m_style = wxSTIPPLE;
-  M_PENDATA->m_join = wxJOIN_ROUND ;
-  M_PENDATA->m_cap = wxCAP_ROUND ;
-  M_PENDATA->m_nbDash = 0 ;
-  M_PENDATA->m_dash = 0 ;
-  M_PENDATA->m_hPen = 0 ;
+    M_PENDATA->m_stipple = stipple;
+    M_PENDATA->m_width = Width;
+    M_PENDATA->m_style = wxSTIPPLE;
+    M_PENDATA->m_join = wxJOIN_ROUND ;
+    M_PENDATA->m_cap = wxCAP_ROUND ;
+    M_PENDATA->m_nbDash = 0 ;
+    M_PENDATA->m_dash = (wxMSWDash*)NULL;
+    M_PENDATA->m_hPen = 0 ;

 
 

-  RealizeResource();
+    RealizeResource();

 
 

-  if ( wxThePenList )
-    wxThePenList->AddPen(this);
+    if (wxThePenList)
+       wxThePenList->AddPen(this);

 }
 
 bool wxPen::RealizeResource()
 {
 }
 
 bool wxPen::RealizeResource()
 {

-  if (M_PENDATA && (M_PENDATA->m_hPen == 0))
-  {
-    if (M_PENDATA->m_style==wxTRANSPARENT)
-    {
-      M_PENDATA->m_hPen = (WXHPEN) ::GetStockObject(NULL_PEN);
-      return TRUE;
-    }
-
-    COLORREF ms_colour = 0 ;
-    ms_colour = M_PENDATA->m_colour.GetPixel() ;
-
-    // Join style, Cap style, Pen Stippling only on Win32.
-    // Currently no time to find equivalent on Win3.1, sorry
-    // [if such equiv exist!!]
+   if (M_PENDATA && (M_PENDATA->m_hPen == 0))
+   {
+       if (M_PENDATA->m_style==wxTRANSPARENT)
+       {
+           M_PENDATA->m_hPen = (WXHPEN) ::GetStockObject(NULL_PEN);
+           return TRUE;
+       }
+
+       COLORREF ms_colour = 0;
+       ms_colour = M_PENDATA->m_colour.GetPixel();
+
+       // Join style, Cap style, Pen Stippling only on Win32.
+       // Currently no time to find equivalent on Win3.1, sorry
+       // [if such equiv exist!!]

 #ifdef __WIN32__
 #ifdef __WIN32__

-    if (M_PENDATA->m_join==wxJOIN_ROUND        &&
-        M_PENDATA->m_cap==wxCAP_ROUND          &&
-        M_PENDATA->m_style!=wxUSER_DASH        &&
-        M_PENDATA->m_style!=wxSTIPPLE          &&
-        M_PENDATA->m_width <= 1
-       )
-      M_PENDATA->m_hPen = (WXHPEN) CreatePen(wx2msPenStyle(M_PENDATA->m_style), M_PENDATA->m_width, ms_colour);
-    else
-    {
-      DWORD ms_style = PS_GEOMETRIC|wx2msPenStyle(M_PENDATA->m_style) ;
-
-      LOGBRUSH logb ;
-
-      switch(M_PENDATA->m_join)
-      {
-        case wxJOIN_BEVEL: ms_style |= PS_JOIN_BEVEL ; break ;
-        case wxJOIN_MITER: ms_style |= PS_JOIN_MITER ; break ;
-        default:
-        case wxJOIN_ROUND: ms_style |= PS_JOIN_ROUND ; break ;
-      }
-
-      switch(M_PENDATA->m_cap)
-      {
-        case wxCAP_PROJECTING: ms_style |= PS_ENDCAP_SQUARE ; break ;
-        case wxCAP_BUTT:       ms_style |= PS_ENDCAP_FLAT ;   break ;
-        default:
-        case wxCAP_ROUND:      ms_style |= PS_ENDCAP_ROUND ;  break ;
-      }
-
-      switch(M_PENDATA->m_style)
-      {
-        case wxSTIPPLE:
-          logb.lbStyle = BS_PATTERN ;
-          if (M_PENDATA->m_stipple.Ok())
-            logb.lbHatch = (LONG)M_PENDATA->m_stipple.GetHBITMAP() ;
-          else
-            logb.lbHatch = (LONG)0 ;
-        break ;
-        case wxBDIAGONAL_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_BDIAGONAL ;
-        break ;
-        case wxCROSSDIAG_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_DIAGCROSS ;
-        break ;
-        case wxFDIAGONAL_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_FDIAGONAL ;
-        break ;
-        case wxCROSS_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_CROSS ;
-        break ;
-        case wxHORIZONTAL_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_HORIZONTAL ;
-        break ;
-        case wxVERTICAL_HATCH:
-          logb.lbStyle = BS_HATCHED ;
-          logb.lbHatch = HS_VERTICAL ;
-        break ;
-        default:
-          logb.lbStyle = BS_SOLID ;
-        break ;
-      }
-      logb.lbColor = ms_colour ;
-      wxDash *real_dash ;
-      if (M_PENDATA->m_style==wxUSER_DASH && M_PENDATA->m_nbDash && M_PENDATA->m_dash)
-      {
-        real_dash = new wxDash[M_PENDATA->m_nbDash] ;
-        int i;
-        for (i=0;i<M_PENDATA->m_nbDash;i++)
-          real_dash[i] = M_PENDATA->m_dash[i] * M_PENDATA->m_width ;
-      }
-      else
-        real_dash = 0 ;
-
-      // Win32s doesn't have ExtCreatePen function...
-      if (wxGetOsVersion()==wxWINDOWS_NT || wxGetOsVersion()==wxWIN95)
-        M_PENDATA->m_hPen = (WXHPEN) ExtCreatePen(ms_style,M_PENDATA->m_width,&logb,
-                            M_PENDATA->m_style==wxUSER_DASH ? M_PENDATA->m_nbDash:0, (const DWORD *)real_dash);
-      else
-        M_PENDATA->m_hPen = (WXHPEN) CreatePen(wx2msPenStyle(M_PENDATA->m_style), M_PENDATA->m_width, ms_colour);
-
-      if (real_dash)
-        delete [] real_dash ;
-    }
+       if (M_PENDATA->m_join==wxJOIN_ROUND        &&
+           M_PENDATA->m_cap==wxCAP_ROUND          &&
+           M_PENDATA->m_style!=wxUSER_DASH        &&
+           M_PENDATA->m_style!=wxSTIPPLE          &&
+          M_PENDATA->m_width <= 1)
+       {
+          M_PENDATA->m_hPen =
+            (WXHPEN) CreatePen( wx2msPenStyle(M_PENDATA->m_style),
+                                M_PENDATA->m_width,
+                                ms_colour );
+       }
+       else
+       {
+          DWORD ms_style = PS_GEOMETRIC | wx2msPenStyle(M_PENDATA->m_style);
+
+          switch(M_PENDATA->m_join)
+           {
+               case wxJOIN_BEVEL: ms_style |= PS_JOIN_BEVEL; break;
+               case wxJOIN_MITER: ms_style |= PS_JOIN_MITER; break;
+               default:
+               case wxJOIN_ROUND: ms_style |= PS_JOIN_ROUND; break;
+           }
+
+           switch(M_PENDATA->m_cap)
+           {
+               case wxCAP_PROJECTING: ms_style |= PS_ENDCAP_SQUARE;  break;
+               case wxCAP_BUTT:       ms_style |= PS_ENDCAP_FLAT;    break;
+               default:
+               case wxCAP_ROUND:      ms_style |= PS_ENDCAP_ROUND;   break;
+           }
+
+          LOGBRUSH logb;
+
+          switch(M_PENDATA->m_style)
+           {
+               case wxSTIPPLE:
+                   logb.lbStyle = BS_PATTERN ;
+                   if (M_PENDATA->m_stipple.Ok())
+                       logb.lbHatch = (LONG)M_PENDATA->m_stipple.GetHBITMAP();
+                   else
+                       logb.lbHatch = (LONG)0;
+                   break;
+               case wxBDIAGONAL_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_BDIAGONAL;
+                  break;
+              case wxCROSSDIAG_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_DIAGCROSS;
+                  break;
+              case wxFDIAGONAL_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_FDIAGONAL;
+                  break;
+              case wxCROSS_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_CROSS;
+                  break;
+              case wxHORIZONTAL_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_HORIZONTAL;
+                  break;
+              case wxVERTICAL_HATCH:
+                  logb.lbStyle = BS_HATCHED;
+                  logb.lbHatch = HS_VERTICAL;
+                  break;
+              default:
+                   logb.lbStyle = BS_SOLID;
+#ifdef __WXDEBUG__
+                  // this should be unnecessary (it's unused) but suppresses the Purigy
+                   // messages about uninitialized memory read
+                  logb.lbHatch = 0;
+#endif
+                  break;
+          }
+
+          logb.lbColor = ms_colour;
+
+          wxMSWDash *real_dash;
+           if (M_PENDATA->m_style==wxUSER_DASH && M_PENDATA->m_nbDash && M_PENDATA->m_dash)
+          {
+              real_dash = new wxMSWDash[M_PENDATA->m_nbDash];
+               int i;
+               for (i=0; i<M_PENDATA->m_nbDash; i++)
+                   real_dash[i] = M_PENDATA->m_dash[i] * M_PENDATA->m_width;
+           }
+          else
+           {
+              real_dash = (wxMSWDash*)NULL;
+           }
+
+           // Win32s doesn't have ExtCreatePen function...
+          if (wxGetOsVersion()==wxWINDOWS_NT || wxGetOsVersion()==wxWIN95)
+          {
+              M_PENDATA->m_hPen =
+                (WXHPEN) ExtCreatePen( ms_style,
+                                       M_PENDATA->m_width,
+                                       &logb,
+                                       M_PENDATA->m_style==wxUSER_DASH
+                                         ? M_PENDATA->m_nbDash
+                                         : 0,
+                                       real_dash );
+          }
+          else
+           {
+              M_PENDATA->m_hPen =
+                 (WXHPEN) CreatePen( wx2msPenStyle(M_PENDATA->m_style),
+                                     M_PENDATA->m_width,
+                                     ms_colour );
+           }
+
+           if (real_dash)
+               delete [] real_dash;
+       }

 #else
 #else

-    M_PENDATA->m_hPen = (WXHPEN) CreatePen(wx2msPenStyle(M_PENDATA->m_style), M_PENDATA->m_width, ms_colour);
+       M_PENDATA->m_hPen =
+        (WXHPEN) CreatePen( wx2msPenStyle(M_PENDATA->m_style),
+                            M_PENDATA->m_width,
+                            ms_colour );

 #endif
 #ifdef WXDEBUG_CREATE
 #endif
 #ifdef WXDEBUG_CREATE

-    if (M_PENDATA->m_hPen==0)
-      wxError("Cannot create pen","Internal error") ;
+       if (M_PENDATA->m_hPen==0)
+           wxError("Cannot create pen","Internal error") ;

 #endif
 #endif

-    return TRUE;
-  }
-  return FALSE;
+       return TRUE;
+    }
+    return FALSE;

 }
 
 WXHANDLE wxPen::GetResourceHandle()
 }
 
 WXHANDLE wxPen::GetResourceHandle()


@@ -265,7 +292,7 @@ WXHANDLE wxPen::GetResourceHandle()
        if ( !M_PENDATA )
                return 0;
        else
        if ( !M_PENDATA )
                return 0;
        else

-               return (WXHANDLE)M_PENDATA->m_hPen;
+               return (WXHANDLE)M_PENDATA->m_hPen;

 }
 
 bool wxPen::FreeResource(bool force)
 }
 
 bool wxPen::FreeResource(bool force)


@@ -350,7 +377,7 @@ void wxPen::SetDashes(int nb_dashes, const wxDash *Dash)
     Unshare();
 
     M_PENDATA->m_nbDash = nb_dashes;
     Unshare();
 
     M_PENDATA->m_nbDash = nb_dashes;

-    M_PENDATA->m_dash = (wxDash *)Dash;
+    M_PENDATA->m_dash = (wxMSWDash *)Dash;

   
     RealizeResource();
 }
   
     RealizeResource();
 }


@@ -375,45 +402,42 @@ void wxPen::SetCap(int Cap)
 
 int wx2msPenStyle(int wx_style)
 {
 
 int wx2msPenStyle(int wx_style)
 {

-  int cstyle;
-/***
+    int cstyle;
+    switch (wx_style)
+    { 
+       case wxDOT:
+           cstyle = PS_DOT;
+          break;
+
+       case wxDOT_DASH:
+          cstyle = PS_DASHDOT;
+          break;
+
+       case wxSHORT_DASH:
+       case wxLONG_DASH:
+           cstyle = PS_DASH;
+          break;
+
+       case wxTRANSPARENT:
+           cstyle = PS_NULL;
+          break;
+
+       case wxUSER_DASH:

 #ifdef __WIN32__
 #ifdef __WIN32__

-  DWORD vers = GetVersion() ;
-  WORD  high = HIWORD(vers) ; // high bit=0 for NT, 1 for Win32s
-#endif
-***/
-  switch (wx_style)
-  {
-    case wxDOT:
-      cstyle = PS_DOT;
-      break;
-    case wxSHORT_DASH:
-    case wxLONG_DASH:
-      cstyle = PS_DASH;
-      break;
-    case wxTRANSPARENT:
-      cstyle = PS_NULL;
-      break;
-    case wxUSER_DASH:
-      // User dash style not supported on Win3.1, sorry...
-#ifdef __WIN32__
-      // Win32s doesn't have PS_USERSTYLE
-/***
-      if ((high&0x8000)==0)
-***/
-      if (wxGetOsVersion()==wxWINDOWS_NT)
-        cstyle = PS_USERSTYLE ;
-      else
-        cstyle = PS_DOT ; // We must make a choice... This is mine!
+           // Win32s doesn't have PS_USERSTYLE
+          if (wxGetOsVersion()==wxWINDOWS_NT || wxGetOsVersion()==wxWIN95)
+              cstyle = PS_USERSTYLE;
+          else
+               cstyle = PS_DOT; // We must make a choice... This is mine!

 #else
 #else

-      cstyle = PS_DASH ;
+           cstyle = PS_DASH;

 #endif
 #endif

-      break ;
-    case wxSOLID:
-    default:
-      cstyle = PS_SOLID;
-      break;
-  }
-  return cstyle;
+           break;
+       case wxSOLID:
+       default:
+           cstyle = PS_SOLID;
+           break;
+   }
+   return cstyle;

 }
 
 }