Minor changes.

[wxWidgets.git] / src / unix / threadpsx.cpp

diff --git a/src/unix/threadpsx.cpp b/src/unix/threadpsx.cpp
index eee36b4d3a2394b2771f42cda61564171567ae8c..e1ea13a436368548343d2b11f1325067919f4874 100644 (file)
--- a/src/unix/threadpsx.cpp
+++ b/src/unix/threadpsx.cpp
@@ -102,23 +102,15 @@ wxMutex::wxMutex()
 {
     p_internal = new wxMutexInternal;
     
 {
     p_internal = new wxMutexInternal;
     

-#if 0
-    /* I don't know where this function is supposed to exist,
-       and NP actually means non-portable, RR. */
-    pthread_mutexattr_t attr_type;
-    pthread_mutexattr_settype( &attr_type, PTHREAD_MUTEX_FAST_NP );
-
-    pthread_mutex_init( &(p_internal->p_mutex), (const pthread_mutexattr_t*) &attr_type );
-#else
-    pthread_mutex_init( &(p_internal->p_mutex), (const pthread_mutexattr_t*) NULL );
-#endif
+    pthread_mutex_init(&(p_internal->p_mutex),
+                       (pthread_mutexattr_t*) NULL );

     m_locked = 0;
 }
 
 wxMutex::~wxMutex()
 {
     if (m_locked > 0)
     m_locked = 0;
 }
 
 wxMutex::~wxMutex()
 {
     if (m_locked > 0)

-        wxLogDebug(_T("Freeing a locked mutex (%d locks)"), m_locked);
+        wxLogDebug(wxT("Freeing a locked mutex (%d locks)"), m_locked);

 
     pthread_mutex_destroy( &(p_internal->p_mutex) );
     delete p_internal;
 
     pthread_mutex_destroy( &(p_internal->p_mutex) );
     delete p_internal;


@@ -129,7 +121,7 @@ wxMutexError wxMutex::Lock()
     int err = pthread_mutex_lock( &(p_internal->p_mutex) );
     if (err == EDEADLK)
     {
     int err = pthread_mutex_lock( &(p_internal->p_mutex) );
     if (err == EDEADLK)
     {

-        wxLogDebug(_T("Locking this mutex would lead to deadlock!"));
+        wxLogDebug(wxT("Locking this mutex would lead to deadlock!"));

 
         return wxMUTEX_DEAD_LOCK;
     }
 
         return wxMUTEX_DEAD_LOCK;
     }


@@ -165,7 +157,7 @@ wxMutexError wxMutex::Unlock()
     }
     else
     {
     }
     else
     {

-        wxLogDebug(_T("Unlocking not locked mutex."));
+        wxLogDebug(wxT("Unlocking not locked mutex."));

 
         return wxMUTEX_UNLOCKED;
     }
 
         return wxMUTEX_UNLOCKED;
     }


@@ -188,7 +180,8 @@ public:
 wxCondition::wxCondition()
 {
     p_internal = new wxConditionInternal;
 wxCondition::wxCondition()
 {
     p_internal = new wxConditionInternal;

-    pthread_cond_init( &(p_internal->p_condition), (const pthread_condattr_t *) NULL );
+    pthread_cond_init( &(p_internal->p_condition),
+                       (pthread_condattr_t *) NULL );

 }
 
 wxCondition::~wxCondition()
 }
 
 wxCondition::~wxCondition()


@@ -329,7 +322,7 @@ void *wxThreadInternal::PthreadStart(void *ptr)
     // terminate the thread
     thread->Exit(status);
 
     // terminate the thread
     thread->Exit(status);
 

-    wxFAIL_MSG(_T("wxThread::Exit() can't return."));
+    wxFAIL_MSG(wxT("wxThread::Exit() can't return."));

 
     return NULL;
 }
 
     return NULL;
 }


@@ -360,6 +353,8 @@ wxThreadInternal::wxThreadInternal()
 {
     m_state = STATE_NEW;
     m_cancelled = FALSE;
 {
     m_state = STATE_NEW;
     m_cancelled = FALSE;

+    m_prio = WXTHREAD_DEFAULT_PRIORITY;
+    m_threadId = 0;

 
     // this mutex is locked during almost all thread lifetime - it will only be
     // unlocked in the very end
 
     // this mutex is locked during almost all thread lifetime - it will only be
     // unlocked in the very end


@@ -398,7 +393,7 @@ wxThreadInternal::~wxThreadInternal()
 wxThreadError wxThreadInternal::Run()
 {
     wxCHECK_MSG( GetState() == STATE_NEW, wxTHREAD_RUNNING,
 wxThreadError wxThreadInternal::Run()
 {
     wxCHECK_MSG( GetState() == STATE_NEW, wxTHREAD_RUNNING,

-                 _T("thread may only be started once after successful Create()") );
+                 wxT("thread may only be started once after successful Create()") );

 
     // the mutex was locked on Create(), so we will be able to lock it again
     // only when the thread really starts executing and enters the wait -
 
     // the mutex was locked on Create(), so we will be able to lock it again
     // only when the thread really starts executing and enters the wait -


@@ -417,7 +412,7 @@ wxThreadError wxThreadInternal::Run()
 
 void wxThreadInternal::Wait()
 {
 
 void wxThreadInternal::Wait()
 {

-    wxCHECK_RET( WasCancelled(), _T("thread should have been cancelled first") );
+    wxCHECK_RET( WasCancelled(), wxT("thread should have been cancelled first") );

 
     // if the thread we're waiting for is waiting for the GUI mutex, we will
     // deadlock so make sure we release it temporarily
 
     // if the thread we're waiting for is waiting for the GUI mutex, we will
     // deadlock so make sure we release it temporarily


@@ -461,7 +456,7 @@ void wxThreadInternal::Pause()
     // the state is set from the thread which pauses us first, this function
     // is called later so the state should have been already set
     wxCHECK_RET( m_state == STATE_PAUSED,
     // the state is set from the thread which pauses us first, this function
     // is called later so the state should have been already set
     wxCHECK_RET( m_state == STATE_PAUSED,

-                 _T("thread must first be paused with wxThread::Pause().") );
+                 wxT("thread must first be paused with wxThread::Pause().") );

 
     // don't pause the thread which is being terminated - this would lead to
     // deadlock if the thread is paused after Delete() had called Resume() but
 
     // don't pause the thread which is being terminated - this would lead to
     // deadlock if the thread is paused after Delete() had called Resume() but


@@ -476,7 +471,7 @@ void wxThreadInternal::Pause()
 void wxThreadInternal::Resume()
 {
     wxCHECK_RET( m_state == STATE_PAUSED,
 void wxThreadInternal::Resume()
 {
     wxCHECK_RET( m_state == STATE_PAUSED,

-                 _T("can't resume thread which is not suspended.") );
+                 wxT("can't resume thread which is not suspended.") );

 
     // we will be able to lock this mutex only when Pause() starts waiting
     wxMutexLocker lock(m_mutexSuspend);
 
     // we will be able to lock this mutex only when Pause() starts waiting
     wxMutexLocker lock(m_mutexSuspend);


@@ -545,6 +540,17 @@ wxThreadError wxThread::Create()
         wxLogError(_("Cannot get priority range for scheduling policy %d."),
                    prio);
     }
         wxLogError(_("Cannot get priority range for scheduling policy %d."),
                    prio);
     }

+    else if ( max_prio == min_prio )
+    {
+        if ( p_internal->GetPriority() != WXTHREAD_DEFAULT_PRIORITY )
+        {
+            // notify the programmer that this doesn't work here
+            wxLogWarning(_("Thread priority setting is ignored."));
+        }
+        //else: we have default priority, so don't complain
+
+        // anyhow, don't do anything because priority is just ignored
+    }

     else
     {
         struct sched_param sp;
     else
     {
         struct sched_param sp;


@@ -576,6 +582,9 @@ wxThreadError wxThread::Create()
 
 wxThreadError wxThread::Run()
 {
 
 wxThreadError wxThread::Run()
 {

+    wxCHECK_MSG( p_internal->GetId(), wxTHREAD_MISC_ERROR,
+                 wxT("must call wxThread::Create() first") );
+

     return p_internal->Run();
 }
 
     return p_internal->Run();
 }
 


@@ -587,7 +596,7 @@ void wxThread::SetPriority(unsigned int prio)
 {
     wxCHECK_RET( ((int)WXTHREAD_MIN_PRIORITY <= (int)prio) &&
                  ((int)prio <= (int)WXTHREAD_MAX_PRIORITY),
 {
     wxCHECK_RET( ((int)WXTHREAD_MIN_PRIORITY <= (int)prio) &&
                  ((int)prio <= (int)WXTHREAD_MAX_PRIORITY),

-                 _T("invalid thread priority") );
+                 wxT("invalid thread priority") );

 
     wxCriticalSectionLocker lock(m_critsect);
 
 
     wxCriticalSectionLocker lock(m_critsect);
 


@@ -616,7 +625,7 @@ void wxThread::SetPriority(unsigned int prio)
 
         case STATE_EXITED:
         default:
 
         case STATE_EXITED:
         default:

-            wxFAIL_MSG(_T("impossible to set thread priority in this state"));
+            wxFAIL_MSG(wxT("impossible to set thread priority in this state"));

     }
 }
 
     }
 }
 


@@ -642,7 +651,7 @@ wxThreadError wxThread::Pause()
 
     if ( p_internal->GetState() != STATE_RUNNING )
     {
 
     if ( p_internal->GetState() != STATE_RUNNING )
     {

-        wxLogDebug(_T("Can't pause thread which is not running."));
+        wxLogDebug(wxT("Can't pause thread which is not running."));

 
         return wxTHREAD_NOT_RUNNING;
     }
 
         return wxTHREAD_NOT_RUNNING;
     }


@@ -666,7 +675,7 @@ wxThreadError wxThread::Resume()
     }
     else
     {
     }
     else
     {

-        wxLogDebug(_T("Attempt to resume a thread which is not paused."));
+        wxLogDebug(wxT("Attempt to resume a thread which is not paused."));

 
         return wxTHREAD_MISC_ERROR;
     }
 
         return wxTHREAD_MISC_ERROR;
     }


@@ -729,8 +738,8 @@ wxThreadError wxThread::Kill()
 
                 return wxTHREAD_MISC_ERROR;
             }
 
                 return wxTHREAD_MISC_ERROR;
             }

-           //GL: As we must auto-destroy, the destruction must happen here (2).
-           delete this;
+            //GL: As we must auto-destroy, the destruction must happen here (2).
+            delete this;

 
             return wxTHREAD_NO_ERROR;
     }
 
             return wxTHREAD_NO_ERROR;
     }


@@ -776,13 +785,17 @@ bool wxThread::TestDestroy()
 wxThread::~wxThread()
 {
     m_critsect.Enter();
 wxThread::~wxThread()
 {
     m_critsect.Enter();

-    if (p_internal->GetState() != STATE_EXITED &&
-        p_internal->GetState() != STATE_NEW)
-      wxLogDebug(_T("The thread is being destroyed althought it is still running ! The application may crash."));
+    if ( p_internal->GetState() != STATE_EXITED &&
+         p_internal->GetState() != STATE_NEW )
+    {
+        wxLogDebug(wxT("The thread is being destroyed although it is still "
+                     "running! The application may crash."));
+    }

 
     m_critsect.Leave();
 
     delete p_internal;
 
     m_critsect.Leave();
 
     delete p_internal;

+

     // remove this thread from the global array
     gs_allThreads.Remove(this);
 }
     // remove this thread from the global array
     gs_allThreads.Remove(this);
 }


@@ -858,16 +871,18 @@ bool wxThreadModule::OnInit()
 
 void wxThreadModule::OnExit()
 {
 
 void wxThreadModule::OnExit()
 {

-    wxASSERT_MSG( wxThread::IsMain(), _T("only main thread can be here") );
+    wxASSERT_MSG( wxThread::IsMain(), wxT("only main thread can be here") );

 
     // terminate any threads left
     size_t count = gs_allThreads.GetCount();
     if ( count != 0u )
 
     // terminate any threads left
     size_t count = gs_allThreads.GetCount();
     if ( count != 0u )

-        wxLogDebug(_T("Some threads were not terminated by the application."));
+        wxLogDebug(wxT("Some threads were not terminated by the application."));

 
     for ( size_t n = 0u; n < count; n++ )
     {
 
     for ( size_t n = 0u; n < count; n++ )
     {

-        gs_allThreads[n]->Delete();
+        // Delete calls the destructor which removes the current entry. We
+        // should only delete the first one each time.
+        gs_allThreads[0]->Delete();

     }
 
     // destroy GUI mutex
     }
 
     // destroy GUI mutex