fix crash when using wxDataViewListStore::DeleteAllItems

[wxWidgets.git] / src / generic / datavgen.cpp

diff --git a/src/generic/datavgen.cpp b/src/generic/datavgen.cpp
index bd6a350ed8e5158b1a68d82eab292e0407de7561..483a1400eb98224c4c84d279ee51d41da8d2d0a0 100644 (file)
--- a/src/generic/datavgen.cpp
+++ b/src/generic/datavgen.cpp
@@ -34,6 +34,7 @@
     #include "wx/settings.h"
     #include "wx/msgdlg.h"
     #include "wx/dcscreen.h"
     #include "wx/settings.h"
     #include "wx/msgdlg.h"
     #include "wx/dcscreen.h"

+    #include "wx/frame.h"

 #endif
 
 #include "wx/stockitem.h"
 #endif
 
 #include "wx/stockitem.h"


@@ -44,6 +45,9 @@
 #include "wx/icon.h"
 #include "wx/list.h"
 #include "wx/listimpl.cpp"
 #include "wx/icon.h"
 #include "wx/list.h"
 #include "wx/listimpl.cpp"

+#include "wx/imaglist.h"
+#include "wx/headerctrl.h"
+#include "wx/dnd.h"

 
 //-----------------------------------------------------------------------------
 // classes
 
 //-----------------------------------------------------------------------------
 // classes


@@ -59,13 +63,10 @@ static const int PADDING_RIGHTLEFT = 3;
 // the expander space margin
 static const int EXPANDER_MARGIN = 4;
 
 // the expander space margin
 static const int EXPANDER_MARGIN = 4;
 

-//-----------------------------------------------------------------------------
-// wxDataViewHeaderWindow
-//-----------------------------------------------------------------------------
-
-// on wxMSW the header window (only that part however) can be made native!
-#if defined(__WXMSW__) && !defined(__WXUNIVERSAL__)
-    #define USE_NATIVE_HEADER_WINDOW
+#ifdef __WXMSW__
+static const int EXPANDER_OFFSET = 4;
+#else
+static const int EXPANDER_OFFSET = 1;

 #endif
 
 //Below is the compare stuff
 #endif
 
 //Below is the compare stuff


@@ -74,184 +75,135 @@ static wxDataViewModel * g_model;
 static int g_column = -2;
 static bool g_asending = true;
 
 static int g_column = -2;
 static bool g_asending = true;
 

-// NB: for some reason, this class must be dllexport'ed or we get warnings from
-//     MSVC in DLL build
-class WXDLLIMPEXP_ADV wxDataViewHeaderWindowBase : public wxControl
+//-----------------------------------------------------------------------------
+// wxDataViewHeaderWindow
+//-----------------------------------------------------------------------------
+
+class wxDataViewHeaderWindow : public wxHeaderCtrl

 {
 public:
 {
 public:

-    wxDataViewHeaderWindowBase()
-        { m_owner = NULL; }
-
-    bool Create(wxDataViewCtrl *parent, wxWindowID id,
-                const wxPoint &pos, const wxSize &size,
-                const wxString &name)
+    wxDataViewHeaderWindow(wxDataViewCtrl *parent)
+        : wxHeaderCtrl(parent)

     {
     {

-        return wxWindow::Create(parent, id, pos, size, wxNO_BORDER, name);

     }
 
     }
 

-    void SetOwner( wxDataViewCtrl* owner ) { m_owner = owner; }
-    wxDataViewCtrl *GetOwner() { return m_owner; }
-
-    // called on column addition/removal
-    virtual void UpdateDisplay() { /* by default, do nothing */ }
-
-    // returns the n-th column
-    virtual wxDataViewColumn *GetColumn(unsigned int n)
-    {
-        wxASSERT(m_owner);
-        wxDataViewColumn *ret = m_owner->GetColumn(n);
-        wxASSERT(ret);
-
-        return ret;
-    }
+    wxDataViewCtrl *GetOwner() const
+        { return static_cast<wxDataViewCtrl *>(GetParent()); }

 
 protected:
 
 protected:

-    wxDataViewCtrl      *m_owner;
-
-    // sends an event generated from the n-th wxDataViewColumn
-    void SendEvent(wxEventType type, unsigned int n);
-};
-
-#ifdef USE_NATIVE_HEADER_WINDOW
-
-#define COLUMN_WIDTH_OFFSET         2
-#define wxDataViewHeaderWindowMSW   wxDataViewHeaderWindow
-
-class wxDataViewHeaderWindowMSW : public wxDataViewHeaderWindowBase
-{
-public:
-
-    wxDataViewHeaderWindowMSW( wxDataViewCtrl *parent,
-                               wxWindowID id,
-                               const wxPoint &pos = wxDefaultPosition,
-                               const wxSize &size = wxDefaultSize,
-                               const wxString &name = wxT("wxdataviewctrlheaderwindow") )
+    // implement/override wxHeaderCtrl functions by forwarding them to the main
+    // control
+    virtual const wxHeaderColumn& GetColumn(unsigned int idx) const

     {
     {

-        Create(parent, id, pos, size, name);
+        return *(GetOwner()->GetColumn(idx));

     }
 
     }
 

-    bool Create(wxDataViewCtrl *parent, wxWindowID id,
-                const wxPoint &pos, const wxSize &size,
-                const wxString &name);
-
-    ~wxDataViewHeaderWindowMSW();
-
-    // called when any column setting is changed and/or changed
-    // the column count
-    virtual void UpdateDisplay();
-
-    virtual void OnInternalIdle();
-
-    // called Refresh afterwards
-    virtual void ScrollWindow(int dx, int dy, const wxRect *rect = NULL);
-
-    virtual wxBorder GetDefaultBorder() const { return wxBORDER_NONE; }
-
-protected:
-    virtual bool MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result);
-
-    virtual void DoSetSize(int x, int y, int width, int height, int sizeFlags);
-
-    wxSize DoGetBestSize() const;
-
-    unsigned int GetColumnIdxFromHeader(NMHEADER *nmHDR);
+    virtual bool UpdateColumnWidthToFit(unsigned int idx, int widthTitle)
+    {
+        wxDataViewCtrl * const owner = GetOwner();

 
 

-    wxDataViewColumn *GetColumnFromHeader(NMHEADER *nmHDR)
-        { return GetColumn(GetColumnIdxFromHeader(nmHDR)); }
+        int widthContents = owner->GetBestColumnWidth(idx);
+        owner->GetColumn(idx)->SetWidth(wxMax(widthTitle, widthContents));
+        owner->OnColumnChange(idx);

 
 

-    int   m_scrollOffsetX;
-    int   m_buttonHeight;
-    bool  m_delayedUpdate;
+        return true;
+    }

 
 private:
 
 private:

-    DECLARE_DYNAMIC_CLASS(wxDataViewHeaderWindowMSW)
-};
-
-#else       // !defined(__WXMSW__)
-
-#define HEADER_WINDOW_HEIGHT            25
-#define HEADER_HORIZ_BORDER             5
-#define HEADER_VERT_BORDER              3
-#define wxGenericDataViewHeaderWindow   wxDataViewHeaderWindow
-
-class wxGenericDataViewHeaderWindow : public wxDataViewHeaderWindowBase
-{
-public:
-    wxGenericDataViewHeaderWindow( wxDataViewCtrl *parent,
-                                    wxWindowID id,
-                                    const wxPoint &pos = wxDefaultPosition,
-                                    const wxSize &size = wxDefaultSize,
-                                    const wxString &name = wxT("wxdataviewctrlheaderwindow") )
+    bool SendEvent(wxEventType type, unsigned int n)

     {
     {

-        Init();
-        Create(parent, id, pos, size, name);
-    }
+        wxDataViewCtrl * const owner = GetOwner();
+        wxDataViewEvent event(type, owner->GetId());

 
 

-    bool Create(wxDataViewCtrl *parent, wxWindowID id,
-                const wxPoint &pos, const wxSize &size,
-                const wxString &name);
+        event.SetEventObject(owner);
+        event.SetColumn(n);
+        event.SetDataViewColumn(owner->GetColumn(n));
+        event.SetModel(owner->GetModel());

 
 

-    ~wxGenericDataViewHeaderWindow()
-    {
-        delete m_resizeCursor;
+        // for events created by wxDataViewHeaderWindow the
+        // row / value fields are not valid
+        return owner->GetEventHandler()->ProcessEvent(event);

     }
 
     }
 

-    virtual void UpdateDisplay() { Refresh(); }
-
-    // event handlers:
-
-    void OnPaint( wxPaintEvent &event );
-    void OnMouse( wxMouseEvent &event );
-    void OnSetFocus( wxFocusEvent &event );
-
-
-protected:
+    void OnClick(wxHeaderCtrlEvent& event)
+    {
+        const unsigned idx = event.GetColumn();

 
 

-    // vars used for column resizing:
+        if ( SendEvent(wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK, idx) )
+            return;

 
 

-    wxCursor            *m_resizeCursor;
-    const wxCursor      *m_currentCursor;
-    bool                 m_isDragging;
+        // default handling for the column click is to sort by this column or
+        // toggle its sort order
+        wxDataViewCtrl * const owner = GetOwner();
+        wxDataViewColumn * const col = owner->GetColumn(idx);
+        if ( !col->IsSortable() )
+        {
+            // no default handling for non-sortable columns
+            event.Skip();
+            return;
+        }

 
 

-    bool                 m_dirty;     // needs refresh?
-    int                  m_hover;     // index of the column under the mouse
-    int                  m_column;    // index of the column being resized
-    int                  m_currentX;  // divider line position in logical (unscrolled) coords
-    int                  m_minX;      // minimal position beyond which the divider line
-                                      // can't be dragged in logical coords
+        if ( col->IsSortKey() )
+        {
+            // already using this column for sorting, just change the order
+            col->ToggleSortOrder();
+        }
+        else // not using this column for sorting yet
+        {
+            // first unset the old sort column if any
+            int oldSortKey = owner->GetSortingColumnIndex();
+            if ( oldSortKey != wxNOT_FOUND )
+            {
+                owner->GetColumn(oldSortKey)->UnsetAsSortKey();
+                owner->OnColumnChange(oldSortKey);
+            }

 
 

-    // the pen used to draw the current column width drag line
-    // when resizing the columsn
-    wxPen m_penCurrent;
+            owner->SetSortingColumnIndex(idx);
+            col->SetAsSortKey();
+        }

 
 

+        wxDataViewModel * const model = owner->GetModel();
+        if ( model )
+            model->Resort();

 
 

-    // internal utilities:
+        owner->OnColumnChange(idx);
+    }

 
 

-    void Init()
+    void OnRClick(wxHeaderCtrlEvent& event)

     {
     {

-        m_currentCursor = (wxCursor *) NULL;
-        m_resizeCursor = new wxCursor( wxCURSOR_SIZEWE );
-
-        m_isDragging = false;
-        m_dirty = false;
+        if ( !SendEvent(wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK,
+                        event.GetColumn()) )
+            event.Skip();
+    }

 
 

-        m_hover = wxNOT_FOUND;
-        m_column = wxNOT_FOUND;
-        m_currentX = 0;
-        m_minX = 0;
+    void OnEndResize(wxHeaderCtrlEvent& event)
+    {
+        wxDataViewCtrl * const owner = GetOwner();

 
 

-        wxColour col = wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT);
-        m_penCurrent = wxPen(col, 1, wxSOLID);
+        const unsigned col = event.GetColumn();
+        owner->GetColumn(col)->SetWidth(event.GetWidth());
+        GetOwner()->OnColumnChange(col);

     }
 
     }
 

-    void AdjustDC(wxDC& dc);
+    void OnEndReorder(wxHeaderCtrlEvent& event)
+    {
+        wxDataViewCtrl * const owner = GetOwner();
+        owner->ColumnMoved(owner->GetColumn(event.GetColumn()),
+                        event.GetNewOrder());
+    }

 
 

-private:
-    DECLARE_DYNAMIC_CLASS(wxGenericDataViewHeaderWindow)

     DECLARE_EVENT_TABLE()
     DECLARE_EVENT_TABLE()

+    wxDECLARE_NO_COPY_CLASS(wxDataViewHeaderWindow);

 };
 
 };
 

-#endif      // defined(__WXMSW__)
+BEGIN_EVENT_TABLE(wxDataViewHeaderWindow, wxHeaderCtrl)
+    EVT_HEADER_CLICK(wxID_ANY, wxDataViewHeaderWindow::OnClick)
+    EVT_HEADER_RIGHT_CLICK(wxID_ANY, wxDataViewHeaderWindow::OnRClick)
+
+    EVT_HEADER_END_RESIZE(wxID_ANY, wxDataViewHeaderWindow::OnEndResize)
+
+    EVT_HEADER_END_REORDER(wxID_ANY, wxDataViewHeaderWindow::OnEndReorder)
+END_EVENT_TABLE()

 
 //-----------------------------------------------------------------------------
 // wxDataViewRenameTimer
 
 //-----------------------------------------------------------------------------
 // wxDataViewRenameTimer


@@ -295,7 +247,7 @@ public:
     {
     }
 
     {
     }
 

-    wxDataViewTreeNode * GetParent() { return m_parent; }
+    wxDataViewTreeNode * GetParent() const { return m_parent; }

     void SetParent( wxDataViewTreeNode * parent ) { m_parent = parent; }
     wxDataViewTreeNodes &  GetNodes() { return m_nodes; }
     wxDataViewTreeLeaves & GetChildren() { return m_leaves; }
     void SetParent( wxDataViewTreeNode * parent ) { m_parent = parent; }
     wxDataViewTreeNodes &  GetNodes() { return m_nodes; }
     wxDataViewTreeLeaves & GetChildren() { return m_leaves; }


@@ -317,14 +269,15 @@ public:
     }
 
     wxDataViewItem & GetItem() { return m_item; }
     }
 
     wxDataViewItem & GetItem() { return m_item; }

+    const wxDataViewItem & GetItem() const { return m_item; }

     void SetItem( const wxDataViewItem & item ) { m_item = item; }
 
     void SetItem( const wxDataViewItem & item ) { m_item = item; }
 

-    unsigned int GetChildrenNumber() { return m_leaves.GetCount(); }
-    unsigned int GetNodeNumber() { return m_nodes.GetCount(); }
-    int GetIndentLevel()
+    unsigned int GetChildrenNumber() const { return m_leaves.GetCount(); }
+    unsigned int GetNodeNumber() const { return m_nodes.GetCount(); }
+    int GetIndentLevel() const

     {
     {

-        int ret = 0 ;
-        wxDataViewTreeNode * node = this;
+        int ret = 0;
+        const wxDataViewTreeNode * node = this;

         while( node->GetParent()->GetParent() != NULL )
         {
             node = node->GetParent();
         while( node->GetParent()->GetParent() != NULL )
         {
             node = node->GetParent();


@@ -333,16 +286,16 @@ public:
         return ret;
     }
 
         return ret;
     }
 

-    bool IsOpen()
+    bool IsOpen() const

     {
     {

-        return m_open ;
+        return m_open;

     }
 
     void ToggleOpen()
     {
         int len = m_nodes.GetCount();
         int sum = 0;
     }
 
     void ToggleOpen()
     {
         int len = m_nodes.GetCount();
         int sum = 0;

-        for ( int i = 0 ;i < len ; i ++)
+        for ( int i = 0;i < len; i ++)

             sum += m_nodes[i]->GetSubTreeCount();
 
         sum += m_leaves.GetCount();
             sum += m_nodes[i]->GetSubTreeCount();
 
         sum += m_leaves.GetCount();


@@ -357,15 +310,15 @@ public:
             ChangeSubTreeCount(sum);
         }
     }
             ChangeSubTreeCount(sum);
         }
     }

-    bool HasChildren() { return m_hasChildren; }
+    bool HasChildren() const { return m_hasChildren; }

     void SetHasChildren( bool has ){ m_hasChildren = has; }
 
     void SetSubTreeCount( int num ) { m_subTreeCount = num; }
     void SetHasChildren( bool has ){ m_hasChildren = has; }
 
     void SetSubTreeCount( int num ) { m_subTreeCount = num; }

-    int GetSubTreeCount() { return m_subTreeCount; }
+    int GetSubTreeCount() const { return m_subTreeCount; }

     void ChangeSubTreeCount( int num )
     {
         if( !m_open )
     void ChangeSubTreeCount( int num )
     {
         if( !m_open )

-            return ;
+            return;

         m_subTreeCount += num;
         if( m_parent )
             m_parent->ChangeSubTreeCount(num);
         m_subTreeCount += num;
         if( m_parent )
             m_parent->ChangeSubTreeCount(num);


@@ -424,6 +377,8 @@ public:
                             const wxString &name = wxT("wxdataviewctrlmainwindow") );
     virtual ~wxDataViewMainWindow();
 
                             const wxString &name = wxT("wxdataviewctrlmainwindow") );
     virtual ~wxDataViewMainWindow();
 

+    bool IsVirtualList() const { return m_root == NULL; }
+

     // notifications from wxDataViewModel
     bool ItemAdded( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemDeleted( const wxDataViewItem &parent, const wxDataViewItem &item );
     // notifications from wxDataViewModel
     bool ItemAdded( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemDeleted( const wxDataViewItem &parent, const wxDataViewItem &item );


@@ -432,7 +387,7 @@ public:
     bool Cleared();
     void Resort()
     {
     bool Cleared();
     void Resort()
     {

-        if (m_root)
+        if (!IsVirtualList())

         {
             SortPrepare();
             m_root->Resort();
         {
             SortPrepare();
             m_root->Resort();


@@ -462,6 +417,9 @@ public:
     wxDataViewCtrl *GetOwner() { return m_owner; }
     const wxDataViewCtrl *GetOwner() const { return m_owner; }
 
     wxDataViewCtrl *GetOwner() { return m_owner; }
     const wxDataViewCtrl *GetOwner() const { return m_owner; }
 

+#if wxUSE_DRAG_AND_DROP
+    wxBitmap CreateItemBitmap( unsigned int row, int &indent );
+#endif // wxUSE_DRAG_AND_DROP

     void OnPaint( wxPaintEvent &event );
     void OnArrowChar(unsigned int newCurrent, const wxKeyEvent& event);
     void OnChar( wxKeyEvent &event );
     void OnPaint( wxPaintEvent &event );
     void OnArrowChar(unsigned int newCurrent, const wxKeyEvent& event);
     void OnChar( wxKeyEvent &event );


@@ -489,7 +447,7 @@ public:
     unsigned int GetFirstVisibleRow() const;
     //I change this method to un const because in the tree view, the displaying number of the tree are changing along with the expanding/collapsing of the tree nodes
     unsigned int GetLastVisibleRow();
     unsigned int GetFirstVisibleRow() const;
     //I change this method to un const because in the tree view, the displaying number of the tree are changing along with the expanding/collapsing of the tree nodes
     unsigned int GetLastVisibleRow();

-    unsigned int GetRowCount() ;
+    unsigned int GetRowCount();

 
     wxDataViewItem GetSelection() const;
     wxDataViewSelection GetSelections(){ return m_selection; }
 
     wxDataViewItem GetSelection() const;
     wxDataViewSelection GetSelections(){ return m_selection; }


@@ -514,9 +472,13 @@ public:
 
     wxRect GetLineRect( unsigned int row ) const;
 
 
     wxRect GetLineRect( unsigned int row ) const;
 

+    int GetLineStart( unsigned int row ) const;  // row * m_lineHeight in fixed mode
+    int GetLineHeight( unsigned int row ) const; // m_lineHeight in fixed mode
+    int GetLineAt( unsigned int y ) const;       // y / m_lineHeight in fixed mode
+

     //Some useful functions for row and item mapping
     wxDataViewItem GetItemByRow( unsigned int row ) const;
     //Some useful functions for row and item mapping
     wxDataViewItem GetItemByRow( unsigned int row ) const;

-    int GetRowByItem( const wxDataViewItem & item );
+    int GetRowByItem( const wxDataViewItem & item ) const;

 
     //Methods for building the mapping tree
     void BuildTree( wxDataViewModel  * model );
 
     //Methods for building the mapping tree
     void BuildTree( wxDataViewModel  * model );


@@ -526,12 +488,25 @@ public:
 
     void Expand( unsigned int row ) { OnExpanding( row ); }
     void Collapse( unsigned int row ) { OnCollapsing( row ); }
 
     void Expand( unsigned int row ) { OnExpanding( row ); }
     void Collapse( unsigned int row ) { OnCollapsing( row ); }

+    bool IsExpanded( unsigned int row ) const;
+
+#if wxUSE_DRAG_AND_DROP
+    bool EnableDragSource( const wxDataFormat &format );
+    bool EnableDropTarget( const wxDataFormat &format );
+
+    void RemoveDropHint();
+    wxDragResult OnDragOver( wxDataFormat format, wxCoord x, wxCoord y, wxDragResult def );
+    bool OnDrop( wxDataFormat format, wxCoord x, wxCoord y );
+    wxDragResult OnData( wxDataFormat format, wxCoord x, wxCoord y, wxDragResult def );
+    void OnLeave();
+#endif // wxUSE_DRAG_AND_DROP
+

 private:
 private:

-    wxDataViewTreeNode * GetTreeNodeByRow( unsigned int row );
+    wxDataViewTreeNode * GetTreeNodeByRow( unsigned int row ) const;

     //We did not need this temporarily
     //wxDataViewTreeNode * GetTreeNodeByItem( const wxDataViewItem & item );
 
     //We did not need this temporarily
     //wxDataViewTreeNode * GetTreeNodeByItem( const wxDataViewItem & item );
 

-    int RecalculateCount() ;
+    int RecalculateCount();

 
     wxDataViewEvent SendExpanderEvent( wxEventType type, const wxDataViewItem & item );
     void OnExpanding( unsigned int row );
 
     wxDataViewEvent SendExpanderEvent( wxEventType type, const wxDataViewItem & item );
     void OnExpanding( unsigned int row );


@@ -553,13 +528,23 @@ private:
 
     bool                        m_hasFocus;
 
 
     bool                        m_hasFocus;
 

+#if wxUSE_DRAG_AND_DROP

     int                         m_dragCount;
     wxPoint                     m_dragStart;
 
     int                         m_dragCount;
     wxPoint                     m_dragStart;
 

+    bool                        m_dragEnabled;
+    wxDataFormat                m_dragFormat;
+
+    bool                        m_dropEnabled;
+    wxDataFormat                m_dropFormat;
+    bool                        m_dropHint;
+    unsigned int                m_dropHintLine;
+#endif // wxUSE_DRAG_AND_DROP
+

     // for double click logic
     unsigned int m_lineLastClicked,
     // for double click logic
     unsigned int m_lineLastClicked,

-           m_lineBeforeLastClicked,
-           m_lineSelectSingleOnUp;
+        m_lineBeforeLastClicked,
+        m_lineSelectSingleOnUp;

 
     // the pen used to draw horiz/vertical rules
     wxPen m_penRule;
 
     // the pen used to draw horiz/vertical rules
     wxPen m_penRule;


@@ -598,7 +583,7 @@ public:
     virtual bool Cleared()
         { return m_mainWindow->Cleared(); }
     virtual void Resort()
     virtual bool Cleared()
         { return m_mainWindow->Cleared(); }
     virtual void Resort()

-         { m_mainWindow->Resort(); }
+        { m_mainWindow->Resort(); }

 
     wxDataViewMainWindow    *m_mainWindow;
 };
 
     wxDataViewMainWindow    *m_mainWindow;
 };


@@ -641,6 +626,29 @@ wxDC *wxDataViewRenderer::GetDC()
     return m_dc;
 }
 
     return m_dc;
 }
 

+void wxDataViewRenderer::SetAlignment( int align )
+{
+    m_align=align;
+}
+
+int wxDataViewRenderer::GetAlignment() const
+{
+    return m_align;
+}
+
+int wxDataViewRenderer::CalculateAlignment() const
+{
+    if (m_align == wxDVR_DEFAULT_ALIGNMENT)
+    {
+        if (GetOwner() == NULL)
+        return wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL;
+
+        return GetOwner()->GetAlignment() | wxALIGN_CENTRE_VERTICAL;
+    }
+
+    return m_align;
+}
+

 // ---------------------------------------------------------
 // wxDataViewCustomRenderer
 // ---------------------------------------------------------
 // ---------------------------------------------------------
 // wxDataViewCustomRenderer
 // ---------------------------------------------------------


@@ -648,7 +656,7 @@ wxDC *wxDataViewRenderer::GetDC()
 IMPLEMENT_ABSTRACT_CLASS(wxDataViewCustomRenderer, wxDataViewRenderer)
 
 wxDataViewCustomRenderer::wxDataViewCustomRenderer( const wxString &varianttype,
 IMPLEMENT_ABSTRACT_CLASS(wxDataViewCustomRenderer, wxDataViewRenderer)
 
 wxDataViewCustomRenderer::wxDataViewCustomRenderer( const wxString &varianttype,

-                          wxDataViewCellMode mode, int align ) :
+                        wxDataViewCellMode mode, int align ) :

     wxDataViewRenderer( varianttype, mode, align )
 {
 }
     wxDataViewRenderer( varianttype, mode, align )
 {
 }


@@ -696,8 +704,8 @@ wxControl* wxDataViewTextRenderer::CreateEditorCtrl( wxWindow *parent,
         wxRect labelRect, const wxVariant &value )
 {
     return new wxTextCtrl( parent, wxID_ANY, value,
         wxRect labelRect, const wxVariant &value )
 {
     return new wxTextCtrl( parent, wxID_ANY, value,

-                           wxPoint(labelRect.x,labelRect.y),
-                           wxSize(labelRect.width,labelRect.height) );
+                        wxPoint(labelRect.x,labelRect.y),
+                        wxSize(labelRect.width,labelRect.height) );

 }
 
 bool wxDataViewTextRenderer::GetValueFromEditorCtrl( wxControl *editor, wxVariant &value )
 }
 
 bool wxDataViewTextRenderer::GetValueFromEditorCtrl( wxControl *editor, wxVariant &value )


@@ -753,13 +761,13 @@ bool wxDataViewTextRendererAttr::Render( wxRect cell, wxDC *dc, int WXUNUSED(sta
 
         if (m_attr.GetBold() || m_attr.GetItalic())
         {
 
         if (m_attr.GetBold() || m_attr.GetItalic())
         {

-             font = dc->GetFont();
-             wxFont myfont = font;
-             if (m_attr.GetBold())
-                 myfont.SetWeight( wxFONTWEIGHT_BOLD );
-             if (m_attr.GetItalic())
-                 myfont.SetStyle( wxFONTSTYLE_ITALIC );
-             dc->SetFont( myfont );
+            font = dc->GetFont();
+            wxFont myfont = font;
+            if (m_attr.GetBold())
+                myfont.SetWeight( wxFONTWEIGHT_BOLD );
+            if (m_attr.GetItalic())
+                myfont.SetStyle( wxFONTSTYLE_ITALIC );
+            dc->SetFont( myfont );

         }
     }
 
         }
     }
 


@@ -853,14 +861,6 @@ bool wxDataViewToggleRenderer::GetValue( wxVariant &WXUNUSED(value) ) const
 
 bool wxDataViewToggleRenderer::Render( wxRect cell, wxDC *dc, int WXUNUSED(state) )
 {
 
 bool wxDataViewToggleRenderer::Render( wxRect cell, wxDC *dc, int WXUNUSED(state) )
 {

-    // User wxRenderer here
-
-    wxRect rect;
-    rect.x = cell.x + cell.width/2 - 10;
-    rect.width = 20;
-    rect.y = cell.y + cell.height/2 - 10;
-    rect.height = 20;
-

     int flags = 0;
     if (m_toggle)
         flags |= wxCONTROL_CHECKED;
     int flags = 0;
     if (m_toggle)
         flags |= wxCONTROL_CHECKED;


@@ -870,15 +870,15 @@ bool wxDataViewToggleRenderer::Render( wxRect cell, wxDC *dc, int WXUNUSED(state
     wxRendererNative::Get().DrawCheckBox(
             GetOwner()->GetOwner(),
             *dc,
     wxRendererNative::Get().DrawCheckBox(
             GetOwner()->GetOwner(),
             *dc,

-            rect,
+            cell,

             flags );
 
     return true;
 }
 
 bool wxDataViewToggleRenderer::Activate( wxRect WXUNUSED(cell),
             flags );
 
     return true;
 }
 
 bool wxDataViewToggleRenderer::Activate( wxRect WXUNUSED(cell),

-                                         wxDataViewModel *model,
-                                         const wxDataViewItem & item, unsigned int col)
+                                        wxDataViewModel *model,
+                                        const wxDataViewItem & item, unsigned int col)

 {
     bool value = !m_toggle;
     wxVariant variant = value;
 {
     bool value = !m_toggle;
     wxVariant variant = value;


@@ -889,7 +889,9 @@ bool wxDataViewToggleRenderer::Activate( wxRect WXUNUSED(cell),
 
 wxSize wxDataViewToggleRenderer::GetSize() const
 {
 
 wxSize wxDataViewToggleRenderer::GetSize() const
 {

-    return wxSize(20,20);
+    // the window parameter is not used by GetCheckBoxSize() so it's
+    // safe to pass NULL
+    return wxRendererNative::Get().GetCheckBoxSize(NULL);

 }
 
 // ---------------------------------------------------------
 }
 
 // ---------------------------------------------------------


@@ -1041,7 +1043,7 @@ wxSize wxDataViewDateRenderer::GetSize() const
 }
 
 bool wxDataViewDateRenderer::Activate( wxRect WXUNUSED(cell), wxDataViewModel *model,
 }
 
 bool wxDataViewDateRenderer::Activate( wxRect WXUNUSED(cell), wxDataViewModel *model,

-                                       const wxDataViewItem & item, unsigned int col )
+                                    const wxDataViewItem & item, unsigned int col )

 {
     wxVariant variant;
     model->GetValue( variant, item, col );
 {
     wxVariant variant;
     model->GetValue( variant, item, col );


@@ -1067,7 +1069,7 @@ bool wxDataViewDateRenderer::Activate( wxRect WXUNUSED(cell), wxDataViewModel *m
 IMPLEMENT_CLASS(wxDataViewIconTextRenderer, wxDataViewCustomRenderer)
 
 wxDataViewIconTextRenderer::wxDataViewIconTextRenderer(
 IMPLEMENT_CLASS(wxDataViewIconTextRenderer, wxDataViewCustomRenderer)
 
 wxDataViewIconTextRenderer::wxDataViewIconTextRenderer(

-  const wxString &varianttype, wxDataViewCellMode mode, int align ) :
+const wxString &varianttype, wxDataViewCellMode mode, int align ) :

     wxDataViewCustomRenderer( varianttype, mode, align )
 {
     SetMode(mode);
     wxDataViewCustomRenderer( varianttype, mode, align )
 {
     SetMode(mode);


@@ -1121,874 +1123,493 @@ wxSize wxDataViewIconTextRenderer::GetSize() const
 
 wxControl *
 wxDataViewIconTextRenderer::CreateEditorCtrl(wxWindow * WXUNUSED(parent),
 
 wxControl *
 wxDataViewIconTextRenderer::CreateEditorCtrl(wxWindow * WXUNUSED(parent),

-                                             wxRect WXUNUSED(labelRect),
-                                             const wxVariant& WXUNUSED(value))
+                                            wxRect WXUNUSED(labelRect),
+                                            const wxVariant& WXUNUSED(value))

 {
     return NULL;
 }
 
 bool
 wxDataViewIconTextRenderer::GetValueFromEditorCtrl(wxControl* WXUNUSED(editor),
 {
     return NULL;
 }
 
 bool
 wxDataViewIconTextRenderer::GetValueFromEditorCtrl(wxControl* WXUNUSED(editor),

-                                                   wxVariant& WXUNUSED(value))
+                                                wxVariant& WXUNUSED(value))

 {
     return false;
 }
 
 {
     return false;
 }
 

-// ---------------------------------------------------------
-// wxDataViewColumn
-// ---------------------------------------------------------
+//-----------------------------------------------------------------------------
+// wxDataViewDropTarget
+//-----------------------------------------------------------------------------

 
 

-IMPLEMENT_ABSTRACT_CLASS(wxDataViewColumn, wxDataViewColumnBase)
+#if wxUSE_DRAG_AND_DROP

 
 

-wxDataViewColumn::wxDataViewColumn( const wxString &title, wxDataViewRenderer *cell,
-                                    unsigned int model_column,
-                                    int width, wxAlignment align, int flags ) :
-    wxDataViewColumnBase( title, cell, model_column, width, align, flags )
+class wxBitmapCanvas: public wxWindow

 {
 {

-    SetAlignment(align);
-    SetTitle(title);
-    SetFlags(flags);
+public:
+    wxBitmapCanvas( wxWindow *parent, const wxBitmap &bitmap, const wxSize &size ) :
+    wxWindow( parent, wxID_ANY, wxPoint(0,0), size )
+    {
+        m_bitmap = bitmap;
+        Connect( wxEVT_PAINT, wxPaintEventHandler(wxBitmapCanvas::OnPaint) );
+    }

 
 

-    m_autosize = width < 0;  // TODO
+    void OnPaint( wxPaintEvent &WXUNUSED(event) )
+    {
+        wxPaintDC dc(this);
+        dc.DrawBitmap( m_bitmap, 0, 0);
+    }

 
 

-    Init(width < 0 ? wxDVC_DEFAULT_WIDTH : width);
-}
+    wxBitmap m_bitmap;
+};

 
 

-wxDataViewColumn::wxDataViewColumn( const wxBitmap &bitmap, wxDataViewRenderer *cell,
-                                    unsigned int model_column,
-                                    int width, wxAlignment align, int flags ) :
-    wxDataViewColumnBase( bitmap, cell, model_column, width, align, flags )
+class wxDataViewDropSource: public wxDropSource

 {
 {

-    SetAlignment(align);
-    SetFlags(flags);
+public:
+    wxDataViewDropSource( wxDataViewMainWindow *win, unsigned int row ) :
+        wxDropSource( win )
+    {
+        m_win = win;
+        m_row = row;
+        m_hint = NULL;
+    }

 
 

-    Init(width < 0 ? wxDVC_TOGGLE_DEFAULT_WIDTH : width);
-}
+    ~wxDataViewDropSource()
+    {
+        delete m_hint;
+    }

 
 

-wxDataViewColumn::~wxDataViewColumn()
-{
-}
+    virtual bool GiveFeedback( wxDragResult WXUNUSED(effect) )
+    {
+        wxPoint pos = wxGetMousePosition();

 
 

-void wxDataViewColumn::Init( int width )
-{
-    m_width = width;
-    m_minWidth = wxDVC_DEFAULT_MINWIDTH;
-    m_ascending = true;
-}
+        if (!m_hint)
+        {
+            int liney = m_win->GetLineStart( m_row );
+            int linex = 0;
+            m_win->GetOwner()->CalcUnscrolledPosition( 0, liney, NULL, &liney );
+            m_win->ClientToScreen( &linex, &liney );
+            m_dist_x = pos.x - linex;
+            m_dist_y = pos.y - liney;

 
 

-void wxDataViewColumn::SetResizeable( bool resizeable )
-{
-    if (resizeable)
-        m_flags |= wxDATAVIEW_COL_RESIZABLE;
-    else
-        m_flags &= ~wxDATAVIEW_COL_RESIZABLE;
-}
+            int indent = 0;
+            wxBitmap ib = m_win->CreateItemBitmap( m_row, indent );
+            m_dist_x -= indent;
+            m_hint = new wxFrame( m_win->GetParent(), wxID_ANY, wxEmptyString,
+                                        wxPoint(pos.x - m_dist_x, pos.y + 5 ),
+                                        ib.GetSize(),
+                                        wxFRAME_TOOL_WINDOW |
+                                        wxFRAME_FLOAT_ON_PARENT |
+                                        wxFRAME_NO_TASKBAR |
+                                        wxNO_BORDER );
+            new wxBitmapCanvas( m_hint, ib, ib.GetSize() );
+            m_hint->Show();
+        }
+        else
+        {
+            m_hint->Move( pos.x - m_dist_x, pos.y + 5  );
+            m_hint->SetTransparent( 128 );
+        }

 
 

-void wxDataViewColumn::SetHidden( bool hidden )
-{
-    if (hidden)
-        m_flags |= wxDATAVIEW_COL_HIDDEN;
-    else
-        m_flags &= ~wxDATAVIEW_COL_HIDDEN;
+        return false;
+    }
+
+    wxDataViewMainWindow   *m_win;
+    unsigned int            m_row;
+    wxFrame                *m_hint;
+    int m_dist_x,m_dist_y;
+};

 
 

-    // tell our owner to e.g. update its scrollbars:
-    if (GetOwner())
-        GetOwner()->OnColumnChange();
-}

 
 

-void wxDataViewColumn::SetSortable( bool sortable )
+class wxDataViewDropTarget: public wxDropTarget

 {
 {

-    if (sortable)
-        m_flags |= wxDATAVIEW_COL_SORTABLE;
-    else
-        m_flags &= ~wxDATAVIEW_COL_SORTABLE;
+public:
+    wxDataViewDropTarget( wxDataObject *obj, wxDataViewMainWindow *win ) :
+        wxDropTarget( obj )
+    {
+        m_win = win;
+    }

 
 

-    // Update header button
-    if (GetOwner())
-        GetOwner()->OnColumnChange();
-}
+    virtual wxDragResult OnDragOver( wxCoord x, wxCoord y, wxDragResult def )
+        {
+        wxDataFormat format = GetMatchingPair();
+        if (format == wxDF_INVALID)
+            return wxDragNone;
+        return m_win->OnDragOver( format, x, y, def);
+        }

 
 

-void wxDataViewColumn::SetReorderable( bool reorderable )
-{
-    if (reorderable)
-        m_flags |= wxDATAVIEW_COL_REORDERABLE;
-    else
-        m_flags &= ~wxDATAVIEW_COL_REORDERABLE;
-}
+    virtual bool OnDrop( wxCoord x, wxCoord y )
+        {
+        wxDataFormat format = GetMatchingPair();
+        if (format == wxDF_INVALID)
+            return false;
+        return m_win->OnDrop( format, x, y );
+        }

 
 

-void wxDataViewColumn::SetSortOrder( bool ascending )
-{
-    m_ascending = ascending;
+    virtual wxDragResult OnData( wxCoord x, wxCoord y, wxDragResult def )
+        {
+        wxDataFormat format = GetMatchingPair();
+        if (format == wxDF_INVALID)
+            return wxDragNone;
+        if (!GetData())
+            return wxDragNone;
+        return m_win->OnData( format, x, y, def );
+        }

 
 

-    // Update header button
-    if (GetOwner())
-        GetOwner()->OnColumnChange();
-}
+    virtual void OnLeave()
+        { m_win->OnLeave(); }

 
 

-bool wxDataViewColumn::IsSortOrderAscending() const
-{
-    return m_ascending;
-}
+    wxDataViewMainWindow   *m_win;
+};

 
 

-void wxDataViewColumn::SetInternalWidth( int width )
-{
-    m_width = width;
+#endif // wxUSE_DRAG_AND_DROP

 
 

-    // the scrollbars of the wxDataViewCtrl needs to be recalculated!
-    if (m_owner && m_owner->m_clientArea)
-        m_owner->m_clientArea->RecalculateDisplay();
-}
+//-----------------------------------------------------------------------------
+// wxDataViewRenameTimer
+//-----------------------------------------------------------------------------

 
 

-void wxDataViewColumn::SetWidth( int width )
+wxDataViewRenameTimer::wxDataViewRenameTimer( wxDataViewMainWindow *owner )

 {
 {

-    if (m_owner->m_headerArea) m_owner->m_headerArea->UpdateDisplay();
-
-    SetInternalWidth(width);
+    m_owner = owner;

 }
 
 }
 

+void wxDataViewRenameTimer::Notify()
+{
+    m_owner->OnRenameTimer();
+}

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-// wxDataViewHeaderWindowBase
+// wxDataViewMainWindow

 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 

-void wxDataViewHeaderWindowBase::SendEvent(wxEventType type, unsigned int n)
+//The tree building helper, declared firstly
+static void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node);
+
+int LINKAGEMODE wxDataViewSelectionCmp( unsigned int row1, unsigned int row2 )

 {
 {

-    wxWindow *parent = GetParent();
-    wxDataViewEvent le(type, parent->GetId());
+    if (row1 > row2) return 1;
+    if (row1 == row2) return 0;
+    return -1;
+}

 
 

-    le.SetEventObject(parent);
-    le.SetColumn(n);
-    le.SetDataViewColumn(GetColumn(n));
-    le.SetModel(GetOwner()->GetModel());

 
 

-    // for events created by wxDataViewHeaderWindow the
-    // row / value fields are not valid
+IMPLEMENT_ABSTRACT_CLASS(wxDataViewMainWindow, wxWindow)
+
+BEGIN_EVENT_TABLE(wxDataViewMainWindow,wxWindow)
+    EVT_PAINT         (wxDataViewMainWindow::OnPaint)
+    EVT_MOUSE_EVENTS  (wxDataViewMainWindow::OnMouse)
+    EVT_SET_FOCUS     (wxDataViewMainWindow::OnSetFocus)
+    EVT_KILL_FOCUS    (wxDataViewMainWindow::OnKillFocus)
+    EVT_CHAR          (wxDataViewMainWindow::OnChar)
+END_EVENT_TABLE()

 
 

-    parent->GetEventHandler()->ProcessEvent(le);
-}
+wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID id,
+    const wxPoint &pos, const wxSize &size, const wxString &name ) :
+    wxWindow( parent, id, pos, size, wxWANTS_CHARS|wxBORDER_NONE, name ),
+    m_selection( wxDataViewSelectionCmp )

 
 

-#ifdef USE_NATIVE_HEADER_WINDOW
+{
+    SetOwner( parent );

 
 

-#ifndef HDS_DRAGDROP
-    #define HDS_DRAGDROP 0x0040
-#endif
-#ifndef HDS_FULLDRAG
-    #define HDS_FULLDRAG 0x0080
-#endif
+    m_lastOnSame = false;
+    m_renameTimer = new wxDataViewRenameTimer( this );

 
 

-// implemented in msw/listctrl.cpp:
-int WXDLLIMPEXP_CORE wxMSWGetColumnClicked(NMHDR *nmhdr, POINT *ptClick);
+    // TODO: user better initial values/nothing selected
+    m_currentCol = NULL;
+    m_currentRow = 0;

 
 

-IMPLEMENT_ABSTRACT_CLASS(wxDataViewHeaderWindowMSW, wxWindow)
+    m_lineHeight = wxMax( 17, GetCharHeight() + 2 ); // 17 = mini icon height + 1

 
 

-bool wxDataViewHeaderWindowMSW::Create( wxDataViewCtrl *parent, wxWindowID id,
-                                        const wxPoint &pos, const wxSize &size,
-                                        const wxString &name )
-{
-    m_owner = parent;
+#if wxUSE_DRAG_AND_DROP
+    m_dragCount = 0;
+    m_dragStart = wxPoint(0,0);

 
 

-    m_scrollOffsetX = 0;
-    m_delayedUpdate = false;
-    m_buttonHeight = wxRendererNative::Get().GetHeaderButtonHeight( this );
+    m_dragEnabled = false;
+    m_dropEnabled = false;
+    m_dropHint = false;
+    m_dropHintLine = (unsigned int) -1;
+#endif // wxUSE_DRAG_AND_DROP

 
 

-    int x = pos.x == wxDefaultCoord ? 0 : pos.x,
-        y = pos.y == wxDefaultCoord ? 0 : pos.y,
-        w = size.x == wxDefaultCoord ? 1 : size.x,
-        h = m_buttonHeight;
+    m_lineLastClicked = (unsigned int) -1;
+    m_lineBeforeLastClicked = (unsigned int) -1;
+    m_lineSelectSingleOnUp = (unsigned int) -1;

 
 

-    wxSize new_size(w,h);
+    m_hasFocus = false;

 
 

-    if ( !CreateControl(parent, id, pos, new_size, 0, wxDefaultValidator, name) )
-        return false;
+    SetBackgroundColour( *wxWHITE );

 
 

-    // create the native WC_HEADER window:
-    WXHWND hwndParent = (HWND)parent->GetHandle();
-    WXDWORD msStyle = WS_CHILD | HDS_DRAGDROP | HDS_BUTTONS | HDS_HORZ | HDS_HOTTRACK | HDS_FULLDRAG;
-
-    if ( m_isShown )
-        msStyle |= WS_VISIBLE;
-
-    m_hWnd = CreateWindowEx(0,
-                            WC_HEADER,
-                            (LPCTSTR) NULL,
-                            msStyle,
-                            x, y, w, h,
-                            (HWND)hwndParent,
-                            (HMENU)-1,
-                            wxGetInstance(),
-                            (LPVOID) NULL);
-    if (m_hWnd == NULL)
-    {
-        wxLogLastError(_T("CreateWindowEx"));
-        return false;
-    }
+    SetBackgroundStyle(wxBG_STYLE_CUSTOM);

 
 

-    // we need to subclass the m_hWnd to force wxWindow::HandleNotify
-    // to call wxDataViewHeaderWindow::MSWOnNotify
-    SubclassWin(m_hWnd);
+    m_penRule = wxPen(GetRuleColour());

 
 

-    // the following is required to get the default win's font for
-    // header windows and must be done befor sending the HDM_LAYOUT msg
-    SetFont(GetFont());
+    //Here I compose a pen can draw black lines, maybe there are something system colour to use
+    m_penExpander = wxPen(wxColour(0,0,0));
+    //Some new added code to deal with the tree structure
+    m_root = new wxDataViewTreeNode( NULL );
+    m_root->SetHasChildren(true);

 
 

-    return true;
+    //Make m_count = -1 will cause the class recaculate the real displaying number of rows.
+    m_count = -1;
+    m_underMouse = NULL;
+    UpdateDisplay();
+}
+
+wxDataViewMainWindow::~wxDataViewMainWindow()
+{
+    DestroyTree();
+    delete m_renameTimer;

 }
 
 }
 

-wxDataViewHeaderWindowMSW::~wxDataViewHeaderWindow()
+
+#if wxUSE_DRAG_AND_DROP
+bool wxDataViewMainWindow::EnableDragSource( const wxDataFormat &format )

 {
 {

-    UnsubclassWin();
+    m_dragFormat = format;
+    m_dragEnabled = format != wxDF_INVALID;
+
+    return true;

 }
 
 }
 

-wxSize wxDataViewHeaderWindowMSW::DoGetBestSize() const
+bool wxDataViewMainWindow::EnableDropTarget( const wxDataFormat &format )

 {
 {

-    return wxSize( 80, m_buttonHeight+2 );
+    m_dropFormat = format;
+    m_dropEnabled = format != wxDF_INVALID;
+
+    if (m_dropEnabled)
+        SetDropTarget( new wxDataViewDropTarget( new wxCustomDataObject( format ), this ) );
+
+    return true;

 }
 
 }
 

-void wxDataViewHeaderWindowMSW::OnInternalIdle()
+void wxDataViewMainWindow::RemoveDropHint()

 {
 {

-    if (m_delayedUpdate)
+    if (m_dropHint)

     {
     {

-        m_delayedUpdate = false;
-        UpdateDisplay();
+            m_dropHint = false;
+            RefreshRow( m_dropHintLine );
+            m_dropHintLine = (unsigned int) -1;

     }
 }
 
     }
 }
 

-void wxDataViewHeaderWindowMSW::UpdateDisplay()
+wxDragResult wxDataViewMainWindow::OnDragOver( wxDataFormat format, wxCoord x, wxCoord y, wxDragResult def )

 {
 {

-    // remove old columns
-    for (int j=0, max=Header_GetItemCount((HWND)m_hWnd); j < max; j++)
-        Header_DeleteItem((HWND)m_hWnd, 0);
+    int xx = x;
+    int yy = y;
+    m_owner->CalcUnscrolledPosition( xx, yy, &xx, &yy );
+    unsigned int row = GetLineAt( yy );

 
 

-    // add the updated array of columns to the header control
-    unsigned int cols = GetOwner()->GetColumnCount();
-    unsigned int added = 0;
-    for (unsigned int i = 0; i < cols; i++)
+    if ((row >= GetRowCount()) || (yy > GetEndOfLastCol()))

     {
     {

-        wxDataViewColumn *col = GetColumn( i );
-        if (col->IsHidden())
-            continue;      // don't add it!
+        RemoveDropHint();
+        return wxDragNone;
+    }

 
 

-        HDITEM hdi;
-        hdi.mask = HDI_TEXT | HDI_FORMAT | HDI_WIDTH;
-        hdi.pszText = (wxChar *) col->GetTitle().wx_str();
-        hdi.cxy = col->GetWidth();
-        hdi.cchTextMax = sizeof(hdi.pszText)/sizeof(hdi.pszText[0]);
-        hdi.fmt = HDF_LEFT | HDF_STRING;
-        //hdi.fmt &= ~(HDF_SORTDOWN|HDF_SORTUP);
+    wxDataViewItem item = GetItemByRow( row );

 
 

-        if (col->IsSortable() && GetOwner()->GetSortingColumn() == col)
-        {
-            //The Microsoft Comctrl32.dll 6.0 support SORTUP/SORTDOWN, but they are not default
-            //see http://msdn2.microsoft.com/en-us/library/ms649534.aspx for more detail
-            // VZ: works with 5.81
-            hdi.fmt |= col->IsSortOrderAscending() ? HDF_SORTUP : HDF_SORTDOWN;
-        }
-
-        // lParam is reserved for application's use:
-        // we store there the column index to use it later in MSWOnNotify
-        // (since columns may have been hidden)
-        hdi.lParam = (LPARAM)i;
-
-        // the native wxMSW implementation of the header window
-        // draws the column separator COLUMN_WIDTH_OFFSET pixels
-        // on the right: to correct this effect we make the column
-        // exactly COLUMN_WIDTH_OFFSET wider (for the first column):
-        if (i == 0)
-            hdi.cxy += COLUMN_WIDTH_OFFSET;
-
-        switch (col->GetAlignment())
-        {
-        case wxALIGN_LEFT:
-            hdi.fmt |= HDF_LEFT;
-            break;
-        case wxALIGN_CENTER:
-        case wxALIGN_CENTER_HORIZONTAL:
-            hdi.fmt |= HDF_CENTER;
-            break;
-        case wxALIGN_RIGHT:
-            hdi.fmt |= HDF_RIGHT;
-            break;
-
-        default:
-            // such alignment is not allowed for the column header!
-            break; // wxFAIL;
-        }
-
-        SendMessage((HWND)m_hWnd, HDM_INSERTITEM,
-                    (WPARAM)added, (LPARAM)&hdi);
-        added++;
-    }
-}
-
-unsigned int wxDataViewHeaderWindowMSW::GetColumnIdxFromHeader(NMHEADER *nmHDR)
-{
-    unsigned int idx;
-
-    // NOTE: we don't just return nmHDR->iItem because when there are
-    //       hidden columns, nmHDR->iItem may be different from
-    //       nmHDR->pitem->lParam
+    wxDataViewModel *model = GetOwner()->GetModel();

 
 

-    if (nmHDR->pitem && nmHDR->pitem->mask & HDI_LPARAM)
+    wxDataViewEvent event( wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE, m_owner->GetId() );
+    event.SetEventObject( m_owner );
+    event.SetItem( item );
+    event.SetModel( model );
+    event.SetDataFormat( format );
+    if (!m_owner->HandleWindowEvent( event ))

     {
     {

-        idx = (unsigned int)nmHDR->pitem->lParam;
-        return idx;
+        RemoveDropHint();
+        return wxDragNone;

     }
 
     }
 

-    HDITEM item;
-    item.mask = HDI_LPARAM;
-    Header_GetItem((HWND)m_hWnd, nmHDR->iItem, &item);
-
-    return (unsigned int)item.lParam;
-}
-
-bool wxDataViewHeaderWindowMSW::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result)
-{
-    NMHDR *nmhdr = (NMHDR *)lParam;
-
-    // is it a message from the header?
-    if ( nmhdr->hwndFrom != (HWND)m_hWnd )
-        return wxWindow::MSWOnNotify(idCtrl, lParam, result);
-
-    NMHEADER *nmHDR = (NMHEADER *)nmhdr;
-    switch ( nmhdr->code )
+    if (!event.IsAllowed())

     {
     {

-        case HDN_BEGINTRACK:
-            // user has started to resize a column:
-            // do we need to veto it?
-            if (!GetColumn(nmHDR->iItem)->IsResizeable())
-            {
-                // veto it!
-                *result = TRUE;
-            }
-            break;
-
-        case HDN_BEGINDRAG:
-            // user has started to reorder a column
-            if ((nmHDR->iItem != -1) && (!GetColumn(nmHDR->iItem)->IsReorderable()))
-            {
-                // veto it!
-                *result = TRUE;
-            }
-            break;
-
-        case HDN_ENDDRAG:       // user has finished reordering a column
-            {
-               wxDataViewColumn *col = GetColumn(nmHDR->iItem);
-               unsigned int new_pos = nmHDR->pitem->iOrder;
-               m_owner->ColumnMoved( col, new_pos );
-               m_delayedUpdate = true;
-            }
-            break;
-
-        case HDN_ITEMCHANGING:
-            if (nmHDR->pitem != NULL &&
-                (nmHDR->pitem->mask & HDI_WIDTH) != 0)
-            {
-                int minWidth = GetColumnFromHeader(nmHDR)->GetMinWidth();
-                if (nmHDR->pitem->cxy < minWidth)
-                {
-                    // do not allow the user to resize this column under
-                    // its minimal width:
-                    *result = TRUE;
-                }
-            }
-            break;
-
-        case HDN_ITEMCHANGED:   // user is resizing a column
-        case HDN_ENDTRACK:      // user has finished resizing a column
-
-            // update the width of the modified column:
-            if (nmHDR->pitem != NULL &&
-                (nmHDR->pitem->mask & HDI_WIDTH) != 0)
-            {
-                unsigned int idx = GetColumnIdxFromHeader(nmHDR);
-                unsigned int w = nmHDR->pitem->cxy;
-                wxDataViewColumn *col = GetColumn(idx);
-
-                // see UpdateDisplay() for more info about COLUMN_WIDTH_OFFSET
-                if (idx == 0 && w > COLUMN_WIDTH_OFFSET)
-                    w -= COLUMN_WIDTH_OFFSET;
-
-                if (w >= (unsigned)col->GetMinWidth())
-                    col->SetInternalWidth(w);
-            }
-            break;
-
-        case HDN_ITEMCLICK:
-            {
-                unsigned int idx = GetColumnIdxFromHeader(nmHDR);
-                wxDataViewModel * model = GetOwner()->GetModel();
-
-                if(nmHDR->iButton == 0)
-                {
-                    wxDataViewColumn *col = GetColumn(idx);
-                    if(col->IsSortable())
-                    {
-                        if(model && m_owner->GetSortingColumn() == col)
-                        {
-                            bool order = col->IsSortOrderAscending();
-                            col->SetSortOrder(!order);
-                        }
-                        else if(model)
-                        {
-                            m_owner->SetSortingColumn(col);
-                        }
-                    }
-                    UpdateDisplay();
-                    if(model)
-                        model->Resort();
-                }
-
-                wxEventType evt = nmHDR->iButton == 0 ?
-                        wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK :
-                        wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK;
-                SendEvent(evt, idx);
-            }
-            break;
-
-        case NM_RCLICK:
-            {
-                // NOTE: for some reason (i.e. for a bug in Windows)
-                //       the HDN_ITEMCLICK notification is not sent on
-                //       right clicks, so we need to handle NM_RCLICK
-
-                POINT ptClick;
-                int column = wxMSWGetColumnClicked(nmhdr, &ptClick);
-                if (column != wxNOT_FOUND)
-                {
-                    HDITEM item;
-                    item.mask = HDI_LPARAM;
-                    Header_GetItem((HWND)m_hWnd, column, &item);
-
-                    // 'idx' may be different from 'column' if there are
-                    // hidden columns...
-                    unsigned int idx = (unsigned int)item.lParam;
-                    SendEvent(wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK,
-                              idx);
-                }
-            }
-            break;
-
-        case HDN_GETDISPINFOW:
-            // see wxListCtrl::MSWOnNotify for more info!
-            break;
-
-        case HDN_ITEMDBLCLICK:
-            {
-                unsigned int idx = GetColumnIdxFromHeader(nmHDR);
-                int w = GetOwner()->GetBestColumnWidth(idx);
-
-                // update the native control:
-                HDITEM hd;
-                ZeroMemory(&hd, sizeof(hd));
-                hd.mask = HDI_WIDTH;
-                hd.cxy = w;
-                Header_SetItem(GetHwnd(),
-                               nmHDR->iItem,  // NOTE: we don't want 'idx' here!
-                               &hd);
-
-                // update the wxDataViewColumn class:
-                GetColumn(idx)->SetInternalWidth(w);
-            }
-            break;
-
-        default:
-            return wxWindow::MSWOnNotify(idCtrl, lParam, result);
+        RemoveDropHint();
+        return wxDragNone;

     }
 
     }
 

-    return true;
-}

 
 

-void wxDataViewHeaderWindowMSW::ScrollWindow(int dx, int WXUNUSED(dy),
-                                             const wxRect * WXUNUSED(rect))
-{
-    m_scrollOffsetX += dx;
+    if (m_dropHint && (row != m_dropHintLine))
+        RefreshRow( m_dropHintLine );
+    m_dropHint = true;
+    m_dropHintLine = row;
+    RefreshRow( row );

 
 

-    GetParent()->Layout();
+    return def;

 }
 
 }
 

-void wxDataViewHeaderWindowMSW::DoSetSize(int x, int y,
-                                          int w, int h,
-                                          int f)
+bool wxDataViewMainWindow::OnDrop( wxDataFormat format, wxCoord x, wxCoord y )

 {
 {

-    // TODO: why is there a border + 2px around it?
-    wxControl::DoSetSize( x+m_scrollOffsetX+1, y+1, w-m_scrollOffsetX-2, h-2, f );
-}
+    RemoveDropHint();

 
 

-#else       // !defined(__WXMSW__)
+    int xx = x;
+    int yy = y;
+    m_owner->CalcUnscrolledPosition( xx, yy, &xx, &yy );
+    unsigned int row = GetLineAt( yy );

 
 

-IMPLEMENT_ABSTRACT_CLASS(wxGenericDataViewHeaderWindow, wxWindow)
-BEGIN_EVENT_TABLE(wxGenericDataViewHeaderWindow, wxWindow)
-    EVT_PAINT         (wxGenericDataViewHeaderWindow::OnPaint)
-    EVT_MOUSE_EVENTS  (wxGenericDataViewHeaderWindow::OnMouse)
-    EVT_SET_FOCUS     (wxGenericDataViewHeaderWindow::OnSetFocus)
-END_EVENT_TABLE()
+    if ((row >= GetRowCount()) || (yy > GetEndOfLastCol()))
+        return false;

 
 

-bool wxGenericDataViewHeaderWindow::Create(wxDataViewCtrl *parent, wxWindowID id,
-                                           const wxPoint &pos, const wxSize &size,
-                                           const wxString &name )
-{
-    m_owner = parent;
+    wxDataViewItem item = GetItemByRow( row );

 
 

-    if (!wxDataViewHeaderWindowBase::Create(parent, id, pos, size, name))
-        return false;
+    wxDataViewModel *model = GetOwner()->GetModel();

 
 

-    wxVisualAttributes attr = wxPanel::GetClassDefaultAttributes();
-    SetBackgroundStyle( wxBG_STYLE_CUSTOM );
-    SetOwnForegroundColour( attr.colFg );
-    SetOwnBackgroundColour( attr.colBg );
-    if (!m_hasFont)
-        SetOwnFont( attr.font );
+    wxDataViewEvent event( wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE, m_owner->GetId() );
+    event.SetEventObject( m_owner );
+    event.SetItem( item );
+    event.SetModel( model );
+    event.SetDataFormat( format );
+    if (!m_owner->HandleWindowEvent( event ))
+        return false;

 
 

-    // set our size hints: wxDataViewCtrl will put this wxWindow inside
-    // a wxBoxSizer and in order to avoid super-big header windows,
-    // we need to set our height as fixed
-    SetMinSize(wxSize(-1, HEADER_WINDOW_HEIGHT));
-    SetMaxSize(wxSize(-1, HEADER_WINDOW_HEIGHT));
+    if (!event.IsAllowed())
+        return false;

 
     return true;
 }
 
 
     return true;
 }
 

-void wxGenericDataViewHeaderWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
+wxDragResult wxDataViewMainWindow::OnData( wxDataFormat format, wxCoord x, wxCoord y, wxDragResult def )

 {
 {

-    int w, h;
-    GetClientSize( &w, &h );
-
-    wxAutoBufferedPaintDC dc( this );
-
-    dc.SetBackground(GetBackgroundColour());
-    dc.Clear();
-
-    int xpix;
-    m_owner->GetScrollPixelsPerUnit( &xpix, NULL );
+    int xx = x;
+    int yy = y;
+    m_owner->CalcUnscrolledPosition( xx, yy, &xx, &yy );
+    unsigned int row = GetLineAt( yy );

 
 

-    int x;
-    m_owner->GetViewStart( &x, NULL );
+    if ((row >= GetRowCount()) || (yy > GetEndOfLastCol()))
+        return wxDragNone;

 
 

-    // account for the horz scrollbar offset
-    dc.SetDeviceOrigin( -x * xpix, 0 );
+    wxDataViewItem item = GetItemByRow( row );

 
 

-    dc.SetFont( GetFont() );
-
-    unsigned int cols = GetOwner()->GetColumnCount();
-    unsigned int i;
-    int xpos = 0;
-    for (i = 0; i < cols; i++)
-    {
-        wxDataViewColumn *col = GetColumn( i );
-        if (col->IsHidden())
-            continue;      // skip it!
-
-        int cw = col->GetWidth();
-        int ch = h;
+    wxDataViewModel *model = GetOwner()->GetModel();

 
 

-        wxHeaderSortIconType sortArrow = wxHDR_SORT_ICON_NONE;
-        if (col->IsSortable() && GetOwner()->GetSortingColumn() == col)
-        {
-            if (col->IsSortOrderAscending())
-                sortArrow = wxHDR_SORT_ICON_UP;
-            else
-                sortArrow = wxHDR_SORT_ICON_DOWN;
-        }
+    wxCustomDataObject *obj = (wxCustomDataObject *) GetDropTarget()->GetDataObject();

 
 

-        int state = 0;
-        if (m_parent->IsEnabled())
-        {
-            if ((int) i == m_hover)
-                state = wxCONTROL_CURRENT;
-        }
-        else
-        {
-            state = (int) wxCONTROL_DISABLED;
-        }
+    wxDataViewEvent event( wxEVT_COMMAND_DATAVIEW_ITEM_DROP, m_owner->GetId() );
+    event.SetEventObject( m_owner );
+    event.SetItem( item );
+    event.SetModel( model );
+    event.SetDataFormat( format );
+    event.SetDataSize( obj->GetSize() );
+    event.SetDataBuffer( obj->GetData() );
+    if (!m_owner->HandleWindowEvent( event ))
+        return wxDragNone;

 
 

-        wxRendererNative::Get().DrawHeaderButton
-                                (
-                                    this,
-                                    dc,
-                                    wxRect(xpos, 0, cw, ch-1),
-                                    state,
-                                    sortArrow
-                                );
+    if (!event.IsAllowed())
+        return wxDragNone;

 
 

-        // align as required the column title:
-        int x = xpos;
-        wxSize titleSz = dc.GetTextExtent(col->GetTitle());
-        switch (col->GetAlignment())
-        {
-        case wxALIGN_LEFT:
-            x += HEADER_HORIZ_BORDER;
-            break;
-        case wxALIGN_RIGHT:
-            x += cw - titleSz.GetWidth() - HEADER_HORIZ_BORDER;
-            break;
-        default:
-        case wxALIGN_CENTER:
-        case wxALIGN_CENTER_HORIZONTAL:
-            x += (cw - titleSz.GetWidth() - 2 * HEADER_HORIZ_BORDER)/2;
-            break;
-        }
-
-        // always center the title vertically:
-        int y = wxMax((ch - titleSz.GetHeight()) / 2, HEADER_VERT_BORDER);
-
-        dc.SetClippingRegion( xpos+HEADER_HORIZ_BORDER,
-                              HEADER_VERT_BORDER,
-                              wxMax(cw - 2 * HEADER_HORIZ_BORDER, 1),  // width
-                              wxMax(ch - 2 * HEADER_VERT_BORDER, 1));  // height
-        dc.DrawText( col->GetTitle(), x, y );
-        dc.DestroyClippingRegion();
-
-        xpos += cw;
-    }
+    return def;

 }
 
 }
 

-void wxGenericDataViewHeaderWindow::OnSetFocus( wxFocusEvent &event )
+void wxDataViewMainWindow::OnLeave()

 {
 {

-    GetParent()->SetFocus();
-    event.Skip();
+    RemoveDropHint();

 }
 
 }
 

-void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
+wxBitmap wxDataViewMainWindow::CreateItemBitmap( unsigned int row, int &indent )

 {
 {

-    // we want to work with logical coords
-    int x;
-    m_owner->CalcUnscrolledPosition(event.GetX(), 0, &x, NULL);
-    int y = event.GetY();
-
-    if (m_isDragging)
+    int height = GetLineHeight( row );
+    int width = 0;
+    unsigned int cols = GetOwner()->GetColumnCount();
+    unsigned int col;
+    for (col = 0; col < cols; col++)

     {
     {

-        // we don't draw the line beyond our window,
-        // but we allow dragging it there
-        int w = 0;
-        GetClientSize( &w, NULL );
-        m_owner->CalcUnscrolledPosition(w, 0, &w, NULL);
-        w -= 6;
-
-        if (event.ButtonUp())
-        {
-            m_isDragging = false;
-            if (HasCapture())
-                ReleaseMouse();
-
-            m_dirty = true;
-        }
-        m_currentX = wxMax(m_minX + 7, x);
+        wxDataViewColumn *column = GetOwner()->GetColumnAt(col);
+        if (column->IsHidden())
+            continue;      // skip it!
+        width += column->GetWidth();
+    }

 
 

-        if (m_currentX < w)
-        {
-            GetColumn(m_column)->SetWidth(m_currentX - m_minX);
-            Refresh();
-            GetOwner()->Refresh();
-        }
+    indent = 0;
+    if (!IsVirtualList())
+    {
+        wxDataViewTreeNode *node = GetTreeNodeByRow(row);
+        indent = GetOwner()->GetIndent() * node->GetIndentLevel();
+        indent = indent + m_lineHeight;  //try to use the m_lineHeight as the expander space

 
 

+        if(!node->HasChildren())
+            delete node;

     }
     }

-    else     // not dragging
-    {
-        m_minX = 0;
-        m_column = wxNOT_FOUND;
+    width -= indent;

 
 

-        bool hit_border = false;
+    wxBitmap bitmap( width, height );
+    wxMemoryDC dc( bitmap );
+    dc.SetFont( GetFont() );
+    dc.SetPen( *wxBLACK_PEN );
+    dc.SetBrush( *wxWHITE_BRUSH );
+    dc.DrawRectangle( 0,0,width,height );

 
 

-        // end of the current column
-        int xpos = 0;
+    wxDataViewModel *model = m_owner->GetModel();

 
 

-        // find the column where this event occured
-        int countCol = m_owner->GetColumnCount();
-        for (int column = 0; column < countCol; column++)
-        {
-            wxDataViewColumn *p = GetColumn(column);
+    wxDataViewColumn *expander = GetOwner()->GetExpanderColumn();
+    if (!expander)
+    {
+        // TODO-RTL: last column for RTL support
+        expander = GetOwner()->GetColumnAt( 0 );
+        GetOwner()->SetExpanderColumn(expander);
+    }

 
 

-            if (p->IsHidden())
-                continue;   // skip if not shown

 
 

-            xpos += p->GetWidth();
-            m_column = column;
-            if ((abs(x-xpos) < 3) && (y < 22))
-            {
-                hit_border = true;
-                break;
-            }
+    int x = 0;
+    for (col = 0; col < cols; col++)
+    {
+        wxDataViewColumn *column = GetOwner()->GetColumnAt( col );
+        wxDataViewRenderer *cell = column->GetRenderer();

 
 

-            if (x < xpos)
-            {
-                // inside the column
-                break;
-            }
+        if (column->IsHidden())
+            continue;       // skip it!

 
 

-            m_minX = xpos;
-        }
+        width = column->GetWidth();

 
 

-        int old_hover = m_hover;
-        m_hover = m_column;
-        if (event.Leaving())
-            m_hover = wxNOT_FOUND;
-        if (old_hover != m_hover)
-            Refresh();
+        if (column == expander)
+            width -= indent;

 
 

-        if (m_column == wxNOT_FOUND)
-            return;
+        wxVariant value;
+        wxDataViewItem item = GetItemByRow( row );
+        model->GetValue( value, item, column->GetModelColumn());
+        cell->SetValue( value );

 
 

-        bool resizeable = GetColumn(m_column)->IsResizeable();
-        if (event.LeftDClick() && resizeable)
-        {
-            GetColumn(m_column)->SetWidth(GetOwner()->GetBestColumnWidth(m_column));
-            Refresh();
-        }
-        else if (event.LeftDown() || event.RightUp())
+        if (cell->GetWantsAttr())

         {
         {

-            if (hit_border && event.LeftDown() && resizeable)
-            {
-                m_isDragging = true;
-                CaptureMouse();
-                m_currentX = x;
-            }
-            else    // click on a column
-            {
-                wxDataViewModel * model = GetOwner()->GetModel();
-                wxEventType evt = event.LeftDown() ?
-                        wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK :
-                        wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK;
-                SendEvent(evt, m_column);
-
-                //Left click the header
-                if(event.LeftDown())
-                {
-                    wxDataViewColumn *col = GetColumn(m_column);
-                    if(col->IsSortable())
-                    {
-                        wxDataViewColumn* sortCol = m_owner->GetSortingColumn();
-                        if(model && sortCol == col)
-                        {
-                            bool order = col->IsSortOrderAscending();
-                            col->SetSortOrder(!order);
-                        }
-                        else if(model)
-                        {
-                            m_owner->SetSortingColumn(col);
-                        }
-                    }
-                    UpdateDisplay();
-                    if(model)
-                        model->Resort();
-                    //Send the column sorted event
-                    SendEvent(wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED, m_column);
-                }
-            }
+                wxDataViewItemAttr attr;
+                bool ret = model->GetAttr( item, column->GetModelColumn(), attr );
+                if (ret)
+                    cell->SetAttr( attr );
+                cell->SetHasAttr( ret );

         }
         }

-        else if (event.Moving())
-        {
-            if (hit_border && resizeable)
-                m_currentCursor = m_resizeCursor;
-            else
-                m_currentCursor = wxSTANDARD_CURSOR;

 
 

-            SetCursor(*m_currentCursor);
-        }
+        wxSize size = cell->GetSize();
+        size.x = wxMin( 2*PADDING_RIGHTLEFT + size.x, width );
+        size.y = height;
+        wxRect item_rect(x, 0, size.x, size.y);
+
+        int align = cell->CalculateAlignment();
+        // horizontal alignment:
+        item_rect.x = x;
+        if (align & wxALIGN_CENTER_HORIZONTAL)
+            item_rect.x = x + (width / 2) - (size.x / 2);
+        else if (align & wxALIGN_RIGHT)
+            item_rect.x = x + width - size.x;
+        //else: wxALIGN_LEFT is the default
+
+        // vertical alignment:
+        item_rect.y = 0;
+        if (align & wxALIGN_CENTER_VERTICAL)
+            item_rect.y = (height / 2) - (size.y / 2);
+        else if (align & wxALIGN_BOTTOM)
+            item_rect.y = height - size.y;
+        //else: wxALIGN_TOP is the default
+
+        // add padding
+        item_rect.x += PADDING_RIGHTLEFT;
+        item_rect.width = size.x - 2 * PADDING_RIGHTLEFT;
+
+        //dc.SetClippingRegion( item_rect );
+        cell->Render( item_rect, &dc, 0 );
+        //dc.DestroyClippingRegion();
+
+        x += width;

     }
     }

-}

 
 

-void wxGenericDataViewHeaderWindow::AdjustDC(wxDC& dc)
-{
-    int xpix, x;
-
-    m_owner->GetScrollPixelsPerUnit( &xpix, NULL );
-    m_owner->GetViewStart( &x, NULL );
-
-    // shift the DC origin to match the position of the main window horizontal
-    // scrollbar: this allows us to always use logical coords
-    dc.SetDeviceOrigin( -x * xpix, 0 );
+    return bitmap;

 }
 
 }
 

-#endif      // defined(__WXMSW__)
+#endif // wxUSE_DRAG_AND_DROP

 
 

-//-----------------------------------------------------------------------------
-// wxDataViewRenameTimer
-//-----------------------------------------------------------------------------
-
-wxDataViewRenameTimer::wxDataViewRenameTimer( wxDataViewMainWindow *owner )
-{
-    m_owner = owner;
-}
-
-void wxDataViewRenameTimer::Notify()
-{
-    m_owner->OnRenameTimer();
-}
-
-//-----------------------------------------------------------------------------
-// wxDataViewMainWindow
-//-----------------------------------------------------------------------------
-
-//The tree building helper, declared firstly
-static void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node);
-
-int LINKAGEMODE wxDataViewSelectionCmp( unsigned int row1, unsigned int row2 )
-{
-    if (row1 > row2) return 1;
-    if (row1 == row2) return 0;
-    return -1;
-}
-
-
-IMPLEMENT_ABSTRACT_CLASS(wxDataViewMainWindow, wxWindow)
-
-BEGIN_EVENT_TABLE(wxDataViewMainWindow,wxWindow)
-    EVT_PAINT         (wxDataViewMainWindow::OnPaint)
-    EVT_MOUSE_EVENTS  (wxDataViewMainWindow::OnMouse)
-    EVT_SET_FOCUS     (wxDataViewMainWindow::OnSetFocus)
-    EVT_KILL_FOCUS    (wxDataViewMainWindow::OnKillFocus)
-    EVT_CHAR          (wxDataViewMainWindow::OnChar)
-END_EVENT_TABLE()
-
-wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID id,
-    const wxPoint &pos, const wxSize &size, const wxString &name ) :
-    wxWindow( parent, id, pos, size, wxWANTS_CHARS|wxBORDER_NONE, name ),
-    m_selection( wxDataViewSelectionCmp )
-
-{
-    SetOwner( parent );
-
-    m_lastOnSame = false;
-    m_renameTimer = new wxDataViewRenameTimer( this );
-
-    // TODO: user better initial values/nothing selected
-    m_currentCol = NULL;
-    m_currentRow = 0;
-
-    m_lineHeight = wxMax( 17, GetCharHeight() + 2 ); // 17 = mini icon height + 1
-
-    m_dragCount = 0;
-    m_dragStart = wxPoint(0,0);
-    m_lineLastClicked = (unsigned int) -1;
-    m_lineBeforeLastClicked = (unsigned int) -1;
-    m_lineSelectSingleOnUp = (unsigned int) -1;
-
-    m_hasFocus = false;
-
-    SetBackgroundColour( *wxWHITE );
-
-    SetBackgroundStyle(wxBG_STYLE_CUSTOM);
-
-    m_penRule = wxPen(GetRuleColour());
-
-    //Here I compose a pen can draw black lines, maybe there are something system colour to use
-    m_penExpander = wxPen(wxColour(0,0,0));
-    //Some new added code to deal with the tree structure
-    m_root = new wxDataViewTreeNode( NULL );
-    m_root->SetHasChildren(true);
-
-    //Make m_count = -1 will cause the class recaculate the real displaying number of rows.
-    m_count = -1 ;
-    m_underMouse = NULL;
-    UpdateDisplay();
-}
-
-wxDataViewMainWindow::~wxDataViewMainWindow()
-{
-    DestroyTree();
-    delete m_renameTimer;
-}

 
 void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
 {
 
 void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
 {


@@ -2011,19 +1632,19 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
     m_owner->CalcUnscrolledPosition( update.x, update.y, &update.x, &update.y );
 
     // compute which items needs to be redrawn
     m_owner->CalcUnscrolledPosition( update.x, update.y, &update.x, &update.y );
 
     // compute which items needs to be redrawn

-    unsigned int item_start = wxMax( 0, (update.y / m_lineHeight) );
+    unsigned int item_start = GetLineAt( wxMax(0,update.y) );

     unsigned int item_count =
     unsigned int item_count =

-        wxMin( (int)(((update.y + update.height) / m_lineHeight) - item_start + 1),
-               (int)(GetRowCount( ) - item_start));
+        wxMin( (int)(  GetLineAt( wxMax(0,update.y+update.height) ) - item_start + 1),
+            (int)(GetRowCount( ) - item_start));

     unsigned int item_last = item_start + item_count;
 
     // compute which columns needs to be redrawn
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int col_start = 0;
     unsigned int item_last = item_start + item_count;
 
     // compute which columns needs to be redrawn
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int col_start = 0;

-    unsigned int x_start = 0;
+    unsigned int x_start;

     for (x_start = 0; col_start < cols; col_start++)
     {
     for (x_start = 0; col_start < cols; col_start++)
     {

-        wxDataViewColumn *col = GetOwner()->GetColumn(col_start);
+        wxDataViewColumn *col = GetOwner()->GetColumnAt(col_start);

         if (col->IsHidden())
             continue;      // skip it!
 
         if (col->IsHidden())
             continue;      // skip it!
 


@@ -2038,7 +1659,7 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
     unsigned int x_last = x_start;
     for (; col_last < cols; col_last++)
     {
     unsigned int x_last = x_start;
     for (; col_last < cols; col_last++)
     {

-        wxDataViewColumn *col = GetOwner()->GetColumn(col_last);
+        wxDataViewColumn *col = GetOwner()->GetColumnAt(col_last);

         if (col->IsHidden())
             continue;      // skip it!
 
         if (col->IsHidden())
             continue;      // skip it!
 


@@ -2054,9 +1675,9 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
         dc.SetPen(m_penRule);
         dc.SetBrush(*wxTRANSPARENT_BRUSH);
 
         dc.SetPen(m_penRule);
         dc.SetBrush(*wxTRANSPARENT_BRUSH);
 

-        for (unsigned int i = item_start; i <= item_last+1; i++)
+        for (unsigned int i = item_start; i <= item_last; i++)

         {
         {

-            int y = i * m_lineHeight;
+            int y = GetLineStart( i );

             dc.DrawLine(x_start, y, x_last, y);
         }
     }
             dc.DrawLine(x_start, y, x_last, y);
         }
     }


@@ -2070,19 +1691,19 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
         int x = x_start;
         for (unsigned int i = col_start; i < col_last; i++)
         {
         int x = x_start;
         for (unsigned int i = col_start; i < col_last; i++)
         {

-            wxDataViewColumn *col = GetOwner()->GetColumn(i);
+            wxDataViewColumn *col = GetOwner()->GetColumnAt(i);

             if (col->IsHidden())
                 continue;       // skip it
 
             if (col->IsHidden())
                 continue;       // skip it
 

-            dc.DrawLine(x, item_start * m_lineHeight,
-                        x, item_last * m_lineHeight);
+            dc.DrawLine(x, GetLineStart( item_start ),
+                        x, GetLineStart( item_last ) );

 
             x += col->GetWidth();
         }
 
         // Draw last vertical rule
 
             x += col->GetWidth();
         }
 
         // Draw last vertical rule

-        dc.DrawLine(x, item_start * m_lineHeight,
-                    x, item_last * m_lineHeight);
+        dc.DrawLine(x, GetLineStart( item_start ),
+                    x, GetLineStart( item_last ) );

     }
 
     // redraw the background for the items which are selected/current
     }
 
     // redraw the background for the items which are selected/current


@@ -2097,7 +1718,7 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
             if (m_hasFocus)
                 flags |= wxCONTROL_FOCUSED;
 
             if (m_hasFocus)
                 flags |= wxCONTROL_FOCUSED;
 

-            wxRect rect( x_start, item*m_lineHeight, x_last, m_lineHeight );
+            wxRect rect( x_start, GetLineStart( item ), x_last, GetLineHeight( item ) );

             wxRendererNative::Get().DrawItemSelectionRect
                                 (
                                     this,
             wxRendererNative::Get().DrawItemSelectionRect
                                 (
                                     this,


@@ -2108,27 +1729,37 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
         }
     }
 
         }
     }
 

+#if wxUSE_DRAG_AND_DROP
+    if (m_dropHint)
+    {
+        wxRect rect( x_start, GetLineStart( m_dropHintLine ),
+                    x_last, GetLineHeight( m_dropHintLine ) );
+        dc.SetPen( *wxBLACK_PEN );
+        dc.SetBrush( *wxTRANSPARENT_BRUSH );
+        dc.DrawRectangle( rect );
+    }
+#endif // wxUSE_DRAG_AND_DROP
+

     wxDataViewColumn *expander = GetOwner()->GetExpanderColumn();
     if (!expander)
     {
     wxDataViewColumn *expander = GetOwner()->GetExpanderColumn();
     if (!expander)
     {

-        // TODO: last column for RTL support
-        expander = GetOwner()->GetColumn( 0 );
+        // TODO-RTL: last column for RTL support
+        expander = GetOwner()->GetColumnAt( 0 );

         GetOwner()->SetExpanderColumn(expander);
     }
 
         GetOwner()->SetExpanderColumn(expander);
     }
 

-    // redraw all cells for all rows which must be repainted and for all columns
+    // redraw all cells for all rows which must be repainted and all columns

     wxRect cell_rect;
     cell_rect.x = x_start;
     wxRect cell_rect;
     cell_rect.x = x_start;

-    cell_rect.height = m_lineHeight;        // -1 is for the horizontal rules

     for (unsigned int i = col_start; i < col_last; i++)
     {
     for (unsigned int i = col_start; i < col_last; i++)
     {

-        wxDataViewColumn *col = GetOwner()->GetColumn( i );
+
+        wxDataViewColumn *col = GetOwner()->GetColumnAt( i );

         wxDataViewRenderer *cell = col->GetRenderer();
         cell_rect.width = col->GetWidth();
 
         if (col->IsHidden())
         wxDataViewRenderer *cell = col->GetRenderer();
         cell_rect.width = col->GetWidth();
 
         if (col->IsHidden())

-            continue;       // skipt it!
-
+            continue;       // skip it!

 
         for (unsigned int item = item_start; item < item_last; item++)
         {
 
         for (unsigned int item = item_start; item < item_last; item++)
         {


@@ -2137,7 +1768,7 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
             wxDataViewTreeNode *node = NULL;
             wxDataViewItem dataitem;
 
             wxDataViewTreeNode *node = NULL;
             wxDataViewItem dataitem;
 

-            if (m_root)
+            if (!IsVirtualList())

             {
                 node = GetTreeNodeByRow(item);
                 if( node == NULL )
             {
                 node = GetTreeNodeByRow(item);
                 if( node == NULL )


@@ -2150,7 +1781,7 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
             }
             else
             {
             }
             else
             {

-                dataitem = wxDataViewItem( (void*) item );
+                dataitem = wxDataViewItem( wxUIntToPtr(item) );

             }
 
             model->GetValue( value, dataitem, col->GetModelColumn());
             }
 
             model->GetValue( value, dataitem, col->GetModelColumn());


@@ -2165,12 +1796,13 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
                 cell->SetHasAttr( ret );
             }
 
                 cell->SetHasAttr( ret );
             }
 

-            // update the y offset
-            cell_rect.y = item * m_lineHeight;
+            // update cell_rect
+            cell_rect.y = GetLineStart( item );
+            cell_rect.height = GetLineHeight( item );     // -1 is for the horizontal rules (?)

 
             //Draw the expander here.
             int indent = 0;
 
             //Draw the expander here.
             int indent = 0;

-            if ((m_root) && (col == expander))
+            if ((!IsVirtualList()) && (col == expander))

             {
                 indent = node->GetIndentLevel();
 
             {
                 indent = node->GetIndentLevel();
 


@@ -2179,8 +1811,9 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
 
                 int expander_width = m_lineHeight - 2*EXPANDER_MARGIN;
                 // change the cell_rect.x to the appropriate pos
 
                 int expander_width = m_lineHeight - 2*EXPANDER_MARGIN;
                 // change the cell_rect.x to the appropriate pos

-                int  expander_x = indent + EXPANDER_MARGIN , expander_y = cell_rect.y + EXPANDER_MARGIN ;
-                indent = indent + m_lineHeight ;  //try to use the m_lineHeight as the expander space
+                int  expander_x = indent + EXPANDER_MARGIN;
+                int expander_y = cell_rect.y + EXPANDER_MARGIN + (GetLineHeight(item) / 2) - (expander_width/2) - EXPANDER_OFFSET;
+                indent = indent + m_lineHeight;  //try to use the m_lineHeight as the expander space

                 dc.SetPen( m_penExpander );
                 dc.SetBrush( wxNullBrush );
                 if( node->HasChildren() )
                 dc.SetPen( m_penExpander );
                 dc.SetBrush( wxNullBrush );
                 if( node->HasChildren() )


@@ -2196,14 +1829,14 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
                     else
                         wxRendererNative::Get().DrawTreeItemButton( this, dc, rect, flag);
                 }
                     else
                         wxRendererNative::Get().DrawTreeItemButton( this, dc, rect, flag);
                 }

-                 //force the expander column to left-center align
-                 cell->SetAlignment( wxALIGN_CENTER_VERTICAL );
+                //force the expander column to left-center align
+                cell->SetAlignment( wxALIGN_CENTER_VERTICAL );

             }
             if (node && !node->HasChildren())
             {
                 // Yes, if the node does not have any child, it must be a leaf which
                 // mean that it is a temporarily created by GetTreeNodeByRow
             }
             if (node && !node->HasChildren())
             {
                 // Yes, if the node does not have any child, it must be a leaf which
                 // mean that it is a temporarily created by GetTreeNodeByRow

-                wxDELETE(node)
+                wxDELETE(node);

             }
 
             // cannot be bigger than allocated space
             }
 
             // cannot be bigger than allocated space


@@ -2214,7 +1847,7 @@ void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
             size.y = cell_rect.height;
 
             wxRect item_rect(cell_rect.GetTopLeft(), size);
             size.y = cell_rect.height;
 
             wxRect item_rect(cell_rect.GetTopLeft(), size);

-            int align = cell->GetAlignment();
+            int align = cell->CalculateAlignment();

 
             // horizontal alignment:
             item_rect.x = cell_rect.x;
 
             // horizontal alignment:
             item_rect.x = cell_rect.x;


@@ -2264,14 +1897,18 @@ void wxDataViewMainWindow::OnRenameTimer()
     // We have to call this here because changes may just have
     // been made and no screen update taken place.
     if ( m_dirty )
     // We have to call this here because changes may just have
     // been made and no screen update taken place.
     if ( m_dirty )

+    {
+        // TODO: use wxTheApp->SafeYieldFor(NULL, wxEVT_CATEGORY_UI) instead
+        //       (needs to be tested!)

         wxSafeYield();
         wxSafeYield();

+    }

 
     int xpos = 0;
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int i;
     for (i = 0; i < cols; i++)
     {
 
     int xpos = 0;
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int i;
     for (i = 0; i < cols; i++)
     {

-        wxDataViewColumn *c = GetOwner()->GetColumn( i );
+        wxDataViewColumn *c = GetOwner()->GetColumnAt( i );

         if (c->IsHidden())
             continue;      // skip it!
 
         if (c->IsHidden())
             continue;      // skip it!
 


@@ -2279,15 +1916,30 @@ void wxDataViewMainWindow::OnRenameTimer()
             break;
         xpos += c->GetWidth();
     }
             break;
         xpos += c->GetWidth();
     }

-    wxRect labelRect( xpos, m_currentRow * m_lineHeight,
-                      m_currentCol->GetWidth(), m_lineHeight );
+
+    // we have to take an expander column into account and compute its indentation
+    // to get the editor at the correct x position where the actual text is
+    int indent = 0;
+    if (!IsVirtualList() && GetOwner()->GetExpanderColumn() == m_currentCol)
+    {
+        wxDataViewTreeNode* node = GetTreeNodeByRow(m_currentRow);
+        indent = GetOwner()->GetIndent() * node->GetIndentLevel();
+        indent = indent + m_lineHeight;
+
+        if(!node->HasChildren())
+            delete node;
+    }
+
+    wxRect labelRect( xpos + indent,
+                    GetLineStart( m_currentRow ),
+                    m_currentCol->GetWidth() - indent,
+                    GetLineHeight( m_currentRow ) );

 
     GetOwner()->CalcScrolledPosition( labelRect.x, labelRect.y,
 
     GetOwner()->CalcScrolledPosition( labelRect.x, labelRect.y,

-                                     &labelRect.x, &labelRect.y);
+                                    &labelRect.x, &labelRect.y);

 
     wxDataViewItem item = GetItemByRow( m_currentRow );
     m_currentCol->GetRenderer()->StartEditing( item, labelRect );
 
     wxDataViewItem item = GetItemByRow( m_currentRow );
     m_currentCol->GetRenderer()->StartEditing( item, labelRect );

-

 }
 
 //------------------------------------------------------------------
 }
 
 //------------------------------------------------------------------


@@ -2296,15 +1948,15 @@ void wxDataViewMainWindow::OnRenameTimer()
 class DoJob
 {
 public:
 class DoJob
 {
 public:

-    DoJob(){};
-    virtual ~DoJob(){};
+    DoJob() { }
+    virtual ~DoJob() { }

 
     //The return value control how the tree-walker tranverse the tree
     // 0: Job done, stop tranverse and return
     // 1: Ignore the current node's subtree and continue
     // 2: Job not done, continue
     enum  { OK = 0 , IGR = 1, CONT = 2 };
 
     //The return value control how the tree-walker tranverse the tree
     // 0: Job done, stop tranverse and return
     // 1: Ignore the current node's subtree and continue
     // 2: Job not done, continue
     enum  { OK = 0 , IGR = 1, CONT = 2 };

-    virtual int operator() ( wxDataViewTreeNode * node ) = 0 ;
+    virtual int operator() ( wxDataViewTreeNode * node ) = 0;

     virtual int operator() ( void * n ) = 0;
 };
 
     virtual int operator() ( void * n ) = 0;
 };
 


@@ -2316,12 +1968,12 @@ bool Walker( wxDataViewTreeNode * node, DoJob & func )
     switch( func( node ) )
     {
         case DoJob::OK :
     switch( func( node ) )
     {
         case DoJob::OK :

-            return true ;
+            return true;

         case DoJob::IGR:
             return false;
         case DoJob::CONT:
         case DoJob::IGR:
             return false;
         case DoJob::CONT:

-            default:
-                ;
+        default:
+            ;

     }
 
     wxDataViewTreeNodes nodes = node->GetNodes();
     }
 
     wxDataViewTreeNodes nodes = node->GetNodes();


@@ -2331,7 +1983,7 @@ bool Walker( wxDataViewTreeNode * node, DoJob & func )
     int len = leaves.GetCount();
     int i = 0, nodes_i = 0;
 
     int len = leaves.GetCount();
     int i = 0, nodes_i = 0;
 

-    for( ; i < len ; i ++ )
+    for(; i < len; i ++ )

     {
         void * n = leaves[i];
         if( nodes_i < len_nodes && n == nodes[nodes_i]->GetItem().GetID() )
     {
         void * n = leaves[i];
         if( nodes_i < len_nodes && n == nodes[nodes_i]->GetItem().GetID() )


@@ -2347,12 +1999,12 @@ bool Walker( wxDataViewTreeNode * node, DoJob & func )
             switch( func( n ) )
             {
                 case DoJob::OK :
             switch( func( n ) )
             {
                 case DoJob::OK :

-                    return true ;
+                    return true;

                 case DoJob::IGR:
                     continue;
                 case DoJob::CONT:
                 default:
                 case DoJob::IGR:
                     continue;
                 case DoJob::CONT:
                 default:

-                    ;
+                ;

             }
     }
     return false;
             }
     }
     return false;


@@ -2398,7 +2050,7 @@ bool wxDataViewMainWindow::ItemAdded(const wxDataViewItem & parent, const wxData
 static void DestroyTreeHelper( wxDataViewTreeNode * node);
 
 bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
 static void DestroyTreeHelper( wxDataViewTreeNode * node);
 
 bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,

-                                       const wxDataViewItem& item)
+                                    const wxDataViewItem& item)

 {
     if (!m_root)
     {
 {
     if (!m_root)
     {


@@ -2440,7 +2092,7 @@ bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
         wxDataViewTreeNode * n = NULL;
         wxDataViewTreeNodes nodes = node->GetNodes();
         int len = nodes.GetCount();
         wxDataViewTreeNode * n = NULL;
         wxDataViewTreeNodes nodes = node->GetNodes();
         int len = nodes.GetCount();

-        for( int i = 0 ; i < len; i ++)
+        for( int i = 0; i < len; i ++)

         {
             if( nodes[i]->GetItem() == item )
             {
         {
             if( nodes[i]->GetItem() == item )
             {


@@ -2549,7 +2201,7 @@ void wxDataViewMainWindow::RecalculateDisplay()
     }
 
     int width = GetEndOfLastCol();
     }
 
     int width = GetEndOfLastCol();

-    int height = GetRowCount() * m_lineHeight;
+    int height = GetLineStart( GetRowCount() );

 
     SetVirtualSize( width, height );
     GetOwner()->SetScrollRate( 10, m_lineHeight );
 
     SetVirtualSize( width, height );
     GetOwner()->SetScrollRate( 10, m_lineHeight );


@@ -2569,18 +2221,18 @@ void wxDataViewMainWindow::ScrollTo( int rows, int column )
 {
     int x, y;
     m_owner->GetScrollPixelsPerUnit( &x, &y );
 {
     int x, y;
     m_owner->GetScrollPixelsPerUnit( &x, &y );

-    int sy = rows*m_lineHeight/y;
+    int sy = GetLineStart( rows )/y;

     int sx = 0;
     if( column != -1 )
     {
         wxRect rect = GetClientRect();
         int colnum = 0;
     int sx = 0;
     if( column != -1 )
     {
         wxRect rect = GetClientRect();
         int colnum = 0;

-        int x_start = 0, x_end = 0, w = 0;
+        int x_start, w = 0;

         int xx, yy, xe;
         m_owner->CalcUnscrolledPosition( rect.x, rect.y, &xx, &yy );
         for (x_start = 0; colnum < column; colnum++)
         {
         int xx, yy, xe;
         m_owner->CalcUnscrolledPosition( rect.x, rect.y, &xx, &yy );
         for (x_start = 0; colnum < column; colnum++)
         {

-            wxDataViewColumn *col = GetOwner()->GetColumn(colnum);
+            wxDataViewColumn *col = GetOwner()->GetColumnAt(colnum);

             if (col->IsHidden())
                 continue;      // skip it!
 
             if (col->IsHidden())
                 continue;      // skip it!
 


@@ -2588,7 +2240,7 @@ void wxDataViewMainWindow::ScrollTo( int rows, int column )
             x_start += w;
         }
 
             x_start += w;
         }
 

-        x_end = x_start + w;
+        int x_end = x_start + w;

         xe = xx + rect.width;
         if( x_end > xe )
         {
         xe = xx + rect.width;
         if( x_end > xe )
         {


@@ -2615,7 +2267,7 @@ int wxDataViewMainWindow::GetEndOfLastCol() const
     for (i = 0; i < GetOwner()->GetColumnCount(); i++)
     {
         const wxDataViewColumn *c =
     for (i = 0; i < GetOwner()->GetColumnCount(); i++)
     {
         const wxDataViewColumn *c =

-            wx_const_cast(wxDataViewCtrl*, GetOwner())->GetColumn( i );
+            const_cast<wxDataViewCtrl*>(GetOwner())->GetColumnAt( i );

 
         if (!c->IsHidden())
             width += c->GetWidth();
 
         if (!c->IsHidden())
             width += c->GetWidth();


@@ -2629,17 +2281,17 @@ unsigned int wxDataViewMainWindow::GetFirstVisibleRow() const
     int y = 0;
     m_owner->CalcUnscrolledPosition( x, y, &x, &y );
 
     int y = 0;
     m_owner->CalcUnscrolledPosition( x, y, &x, &y );
 

-    return y / m_lineHeight;
+    return GetLineAt( y );

 }
 
 unsigned int wxDataViewMainWindow::GetLastVisibleRow()
 {
     wxSize client_size = GetClientSize();
     m_owner->CalcUnscrolledPosition( client_size.x, client_size.y,
 }
 
 unsigned int wxDataViewMainWindow::GetLastVisibleRow()
 {
     wxSize client_size = GetClientSize();
     m_owner->CalcUnscrolledPosition( client_size.x, client_size.y,

-                                     &client_size.x, &client_size.y );
+                                    &client_size.x, &client_size.y );

 
     //we should deal with the pixel here
 
     //we should deal with the pixel here

-    unsigned int row = ((client_size.y)/m_lineHeight) - 1;
+    unsigned int row = GetLineAt(client_size.y) - 1;

 
     return wxMin( GetRowCount()-1, row );
 }
 
     return wxMin( GetRowCount()-1, row );
 }


@@ -2649,11 +2301,7 @@ unsigned int wxDataViewMainWindow::GetRowCount()
     if ( m_count == -1 )
     {
         m_count = RecalculateCount();
     if ( m_count == -1 )
     {
         m_count = RecalculateCount();

-        int width, height;
-        GetVirtualSize( &width, &height );
-        height = m_count * m_lineHeight;
-
-        SetVirtualSize( width, height );
+        UpdateDisplay();

     }
     return m_count;
 }
     }
     return m_count;
 }


@@ -2777,7 +2425,7 @@ void wxDataViewMainWindow::SendSelectionChangedEvent( const wxDataViewItem& item
 
 void wxDataViewMainWindow::RefreshRow( unsigned int row )
 {
 
 void wxDataViewMainWindow::RefreshRow( unsigned int row )
 {

-    wxRect rect( 0, row*m_lineHeight, GetEndOfLastCol(), m_lineHeight );
+    wxRect rect( 0, GetLineStart( row ), GetEndOfLastCol(), GetLineHeight( row ) );

     m_owner->CalcScrolledPosition( rect.x, rect.y, &rect.x, &rect.y );
 
     wxSize client_size = GetClientSize();
     m_owner->CalcScrolledPosition( rect.x, rect.y, &rect.x, &rect.y );
 
     wxSize client_size = GetClientSize();


@@ -2796,7 +2444,7 @@ void wxDataViewMainWindow::RefreshRows( unsigned int from, unsigned int to )
         from = tmp;
     }
 
         from = tmp;
     }
 

-    wxRect rect( 0, from*m_lineHeight, GetEndOfLastCol(), (to-from+1) * m_lineHeight );
+    wxRect rect( 0, GetLineStart( from ), GetEndOfLastCol(), GetLineStart( (to-from+1) ) );

     m_owner->CalcScrolledPosition( rect.x, rect.y, &rect.x, &rect.y );
 
     wxSize client_size = GetClientSize();
     m_owner->CalcScrolledPosition( rect.x, rect.y, &rect.x, &rect.y );
 
     wxSize client_size = GetClientSize();


@@ -2808,95 +2456,255 @@ void wxDataViewMainWindow::RefreshRows( unsigned int from, unsigned int to )
 
 void wxDataViewMainWindow::RefreshRowsAfter( unsigned int firstRow )
 {
 
 void wxDataViewMainWindow::RefreshRowsAfter( unsigned int firstRow )
 {

-    unsigned int count = GetRowCount();
-    if (firstRow > count)
+    wxSize client_size = GetClientSize();
+    int start = GetLineStart( firstRow );
+    m_owner->CalcScrolledPosition( start, 0, &start, NULL );
+    if (start > client_size.y) return;
+
+    wxRect rect( 0, start, client_size.x, client_size.y - start );
+
+    Refresh( true, &rect );
+}
+
+void wxDataViewMainWindow::OnArrowChar(unsigned int newCurrent, const wxKeyEvent& event)
+{
+    wxCHECK_RET( newCurrent < GetRowCount(),
+                _T("invalid item index in OnArrowChar()") );
+
+    // if there is no selection, we cannot move it anywhere
+    if (!HasCurrentRow())

         return;
 
         return;
 

-    wxRect rect( 0, firstRow*m_lineHeight, GetEndOfLastCol(), count * m_lineHeight );
-    m_owner->CalcScrolledPosition( rect.x, rect.y, &rect.x, &rect.y );
+    unsigned int oldCurrent = m_currentRow;

 
 

-    wxSize client_size = GetClientSize();
-    wxRect client_rect( 0, 0, client_size.x, client_size.y );
-    wxRect intersect_rect = client_rect.Intersect( rect );
-    if (intersect_rect.width > 0)
-        Refresh( true, &intersect_rect );
+    // in single selection we just ignore Shift as we can't select several
+    // items anyhow
+    if ( event.ShiftDown() && !IsSingleSel() )
+    {
+        RefreshRow( oldCurrent );
+
+        ChangeCurrentRow( newCurrent );
+
+        // select all the items between the old and the new one
+        if ( oldCurrent > newCurrent )
+        {
+            newCurrent = oldCurrent;
+            oldCurrent = m_currentRow;
+        }
+
+        SelectRows( oldCurrent, newCurrent, true );
+        if (oldCurrent!=newCurrent)
+            SendSelectionChangedEvent(GetItemByRow(m_selection[0]));
+    }
+    else // !shift
+    {
+        RefreshRow( oldCurrent );
+
+        // all previously selected items are unselected unless ctrl is held
+        if ( !event.ControlDown() )
+            SelectAllRows(false);
+
+        ChangeCurrentRow( newCurrent );
+
+        if ( !event.ControlDown() )
+        {
+            SelectRow( m_currentRow, true );
+            SendSelectionChangedEvent(GetItemByRow(m_currentRow));
+        }
+        else
+            RefreshRow( m_currentRow );
+    }
+
+    GetOwner()->EnsureVisible( m_currentRow, -1 );
+}
+
+wxRect wxDataViewMainWindow::GetLineRect( unsigned int row ) const
+{
+    wxRect rect;
+    rect.x = 0;
+    rect.y = GetLineStart( row );
+    rect.width = GetEndOfLastCol();
+    rect.height = GetLineHeight( row );
+
+    return rect;
+}
+
+int wxDataViewMainWindow::GetLineStart( unsigned int row ) const
+{
+    const wxDataViewModel *model = GetOwner()->GetModel();
+
+    if (GetOwner()->GetWindowStyle() & wxDV_VARIABLE_LINE_HEIGHT)
+    {
+        // TODO make more efficient
+
+        int start = 0;
+
+        unsigned int r;
+        for (r = 0; r < row; r++)
+        {
+            const wxDataViewTreeNode* node = GetTreeNodeByRow(r);
+            if (!node) return start;
+
+            wxDataViewItem item = node->GetItem();
+
+            if (node && !node->HasChildren())
+            {
+                // Yes, if the node does not have any child, it must be a leaf which
+                // mean that it is a temporarily created by GetTreeNodeByRow
+                wxDELETE(node);
+            }
+
+            unsigned int cols = GetOwner()->GetColumnCount();
+            unsigned int col;
+            int height = m_lineHeight;
+            for (col = 0; col < cols; col++)
+            {
+                const wxDataViewColumn *column = GetOwner()->GetColumn(col);
+                if (column->IsHidden())
+                    continue;      // skip it!
+
+                if ((col != 0) && model->IsContainer(item) && !model->HasContainerColumns(item))
+                    continue;      // skip it!
+
+                const wxDataViewRenderer *renderer = column->GetRenderer();
+                wxVariant value;
+                model->GetValue( value, item, column->GetModelColumn() );
+                wxDataViewRenderer *renderer2 = const_cast<wxDataViewRenderer*>(renderer);
+                renderer2->SetValue( value );
+                height = wxMax( height, renderer->GetSize().y );
+            }
+
+
+            start += height;
+        }
+
+        return start;
+    }
+    else
+    {
+        return row * m_lineHeight;
+    }

 }
 
 }
 

-void wxDataViewMainWindow::OnArrowChar(unsigned int newCurrent, const wxKeyEvent& event)
+int wxDataViewMainWindow::GetLineAt( unsigned int y ) const

 {
 {

-    wxCHECK_RET( newCurrent < GetRowCount(),
-                 _T("invalid item index in OnArrowChar()") );
+    const wxDataViewModel *model = GetOwner()->GetModel();

 
 

-    // if there is no selection, we cannot move it anywhere
-    if (!HasCurrentRow())
-        return;
-
-    unsigned int oldCurrent = m_currentRow;
+    // check for the easy case first
+    if ( !GetOwner()->HasFlag(wxDV_VARIABLE_LINE_HEIGHT) )
+        return y / m_lineHeight;

 
 

-    // in single selection we just ignore Shift as we can't select several
-    // items anyhow
-    if ( event.ShiftDown() && !IsSingleSel() )
+    // TODO make more efficient
+    unsigned int row = 0;
+    unsigned int yy = 0;
+    for (;;)

     {
     {

-        RefreshRow( oldCurrent );
+    const wxDataViewTreeNode* node = GetTreeNodeByRow(row);
+    if (!node)
+    {
+        // not really correct...
+        return row + ((y-yy) / m_lineHeight);
+    }

 
 

-        ChangeCurrentRow( newCurrent );
+    wxDataViewItem item = node->GetItem();

 
 

-        // select all the items between the old and the new one
-        if ( oldCurrent > newCurrent )
+        if (node && !node->HasChildren())

         {
         {

-            newCurrent = oldCurrent;
-            oldCurrent = m_currentRow;
+            // Yes, if the node does not have any child, it must be a leaf which
+            // mean that it is a temporarily created by GetTreeNodeByRow
+            wxDELETE(node);

         }
 
         }
 

-        SelectRows( oldCurrent, newCurrent, true );
-        if (oldCurrent!=newCurrent)
-            SendSelectionChangedEvent(GetItemByRow(m_selection[0]));
+    unsigned int cols = GetOwner()->GetColumnCount();
+    unsigned int col;
+    int height = m_lineHeight;
+    for (col = 0; col < cols; col++)
+    {
+            const wxDataViewColumn *column = GetOwner()->GetColumn(col);
+            if (column->IsHidden())
+                continue;      // skip it!
+
+            if ((col != 0) && model->IsContainer(item) && !model->HasContainerColumns(item))
+                continue;      // skip it!
+
+            const wxDataViewRenderer *renderer = column->GetRenderer();
+            wxVariant value;
+            model->GetValue( value, item, column->GetModelColumn() );
+            wxDataViewRenderer *renderer2 = const_cast<wxDataViewRenderer*>(renderer);
+            renderer2->SetValue( value );
+            height = wxMax( height, renderer->GetSize().y );

     }
     }

-    else // !shift
+
+    yy += height;
+    if (y < yy)
+        return row;
+
+    row++;
+    }
+}
+
+int wxDataViewMainWindow::GetLineHeight( unsigned int row ) const
+{
+    const wxDataViewModel *model = GetOwner()->GetModel();
+
+    if (GetOwner()->GetWindowStyle() & wxDV_VARIABLE_LINE_HEIGHT)

     {
     {

-        RefreshRow( oldCurrent );
+        wxASSERT( !IsVirtualList() );

 
 

-        // all previously selected items are unselected unless ctrl is held
-        if ( !event.ControlDown() )
-            SelectAllRows(false);
+        const wxDataViewTreeNode* node = GetTreeNodeByRow(row);
+        // wxASSERT( node );
+        if (!node) return m_lineHeight;

 
 

-        ChangeCurrentRow( newCurrent );
+        wxDataViewItem item = node->GetItem();

 
 

-        if ( !event.ControlDown() )
+        if (node && !node->HasChildren())

         {
         {

-            SelectRow( m_currentRow, true );
-            SendSelectionChangedEvent(GetItemByRow(m_currentRow));
+                // Yes, if the node does not have any child, it must be a leaf which
+                // mean that it is a temporarily created by GetTreeNodeByRow
+            wxDELETE(node);

         }
         }

-        else
-            RefreshRow( m_currentRow );
-    }

 
 

-    GetOwner()->EnsureVisible( m_currentRow, -1 );
-}
+        int height = m_lineHeight;

 
 

-wxRect wxDataViewMainWindow::GetLineRect( unsigned int row ) const
-{
-    wxRect rect;
-    rect.x = 0;
-    rect.y = m_lineHeight * row;
-    rect.width = GetEndOfLastCol();
-    rect.height = m_lineHeight;
+        unsigned int cols = GetOwner()->GetColumnCount();
+        unsigned int col;
+        for (col = 0; col < cols; col++)
+        {
+            const wxDataViewColumn *column = GetOwner()->GetColumn(col);
+            if (column->IsHidden())
+                continue;      // skip it!

 
 

-    return rect;
+            if ((col != 0) && model->IsContainer(item) && !model->HasContainerColumns(item))
+                continue;      // skip it!
+
+            const wxDataViewRenderer *renderer = column->GetRenderer();
+            wxVariant value;
+            model->GetValue( value, item, column->GetModelColumn() );
+            wxDataViewRenderer *renderer2 = const_cast<wxDataViewRenderer*>(renderer);
+            renderer2->SetValue( value );
+            height = wxMax( height, renderer->GetSize().y );
+        }
+
+        return height;
+    }
+    else
+    {
+        return m_lineHeight;
+    }

 }
 
 class RowToItemJob: public DoJob
 {
 public:
 }
 
 class RowToItemJob: public DoJob
 {
 public:

-    RowToItemJob( unsigned int row , int current ) { this->row = row; this->current = current ;}
-    virtual ~RowToItemJob(){};
+    RowToItemJob( unsigned int row , int current ) { this->row = row; this->current = current;}
+    virtual ~RowToItemJob() { }

 
     virtual int operator() ( wxDataViewTreeNode * node )
     {
         current ++;
         if( current == static_cast<int>(row))
 
     virtual int operator() ( wxDataViewTreeNode * node )
     {
         current ++;
         if( current == static_cast<int>(row))

-         {
-            ret = node->GetItem() ;
+        {
+            ret = node->GetItem();

             return DoJob::OK;
         }
 
             return DoJob::OK;
         }
 


@@ -2923,8 +2731,8 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-         {
-            ret = wxDataViewItem( n ) ;
+        {
+            ret = wxDataViewItem( n );

             return DoJob::OK;
         }
         return DoJob::CONT;
             return DoJob::OK;
         }
         return DoJob::CONT;


@@ -2932,7 +2740,7 @@ public:
     wxDataViewItem GetResult(){ return ret; }
 private:
     unsigned int row;
     wxDataViewItem GetResult(){ return ret; }
 private:
     unsigned int row;

-    int current ;
+    int current;

     wxDataViewItem ret;
 };
 
     wxDataViewItem ret;
 };
 


@@ -2940,7 +2748,7 @@ wxDataViewItem wxDataViewMainWindow::GetItemByRow(unsigned int row) const
 {
     if (!m_root)
     {
 {
     if (!m_root)
     {

-        return wxDataViewItem( (void*) row );
+        return wxDataViewItem( wxUIntToPtr(row) );

     }
     else
     {
     }
     else
     {


@@ -2956,18 +2764,18 @@ public:
     RowToTreeNodeJob( unsigned int row , int current, wxDataViewTreeNode * node )
     {
         this->row = row;
     RowToTreeNodeJob( unsigned int row , int current, wxDataViewTreeNode * node )
     {
         this->row = row;

-        this->current = current ;
-        ret = NULL ;
+        this->current = current;
+        ret = NULL;

         parent = node;
     }
         parent = node;
     }

-    virtual ~RowToTreeNodeJob(){};
+    virtual ~RowToTreeNodeJob(){ }

 
     virtual int operator() ( wxDataViewTreeNode * node )
     {
         current ++;
         if( current == static_cast<int>(row))
 
     virtual int operator() ( wxDataViewTreeNode * node )
     {
         current ++;
         if( current == static_cast<int>(row))

-         {
-            ret = node ;
+        {
+            ret = node;

             return DoJob::OK;
         }
 
             return DoJob::OK;
         }
 


@@ -2985,7 +2793,7 @@ public:
             {
                 int index = static_cast<int>(row) - current - 1;
                 void * n = node->GetChildren().Item( index );
             {
                 int index = static_cast<int>(row) - current - 1;
                 void * n = node->GetChildren().Item( index );

-                ret = new wxDataViewTreeNode( parent ) ;
+                ret = new wxDataViewTreeNode( parent );

                 ret->SetItem( wxDataViewItem( n ));
                 ret->SetHasChildren(false);
                 return DoJob::OK;
                 ret->SetItem( wxDataViewItem( n ));
                 ret->SetHasChildren(false);
                 return DoJob::OK;


@@ -3000,8 +2808,8 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-         {
-            ret = new wxDataViewTreeNode( parent ) ;
+        {
+            ret = new wxDataViewTreeNode( parent );

             ret->SetItem( wxDataViewItem( n ));
             ret->SetHasChildren(false);
             return DoJob::OK;
             ret->SetItem( wxDataViewItem( n ));
             ret->SetHasChildren(false);
             return DoJob::OK;


@@ -3012,24 +2820,19 @@ public:
     wxDataViewTreeNode * GetResult(){ return ret; }
 private:
     unsigned int row;
     wxDataViewTreeNode * GetResult(){ return ret; }
 private:
     unsigned int row;

-    int current ;
+    int current;

     wxDataViewTreeNode * ret;
     wxDataViewTreeNode * ret;

-    wxDataViewTreeNode * parent ;
+    wxDataViewTreeNode * parent;

 };
 
 
 };
 
 

-wxDataViewTreeNode * wxDataViewMainWindow::GetTreeNodeByRow(unsigned int row)
+wxDataViewTreeNode * wxDataViewMainWindow::GetTreeNodeByRow(unsigned int row) const

 {
 {

-    if (!m_root)
-    {
-        return NULL;
-    }
-    else
-    {
-        RowToTreeNodeJob job( row , -2, m_root );
-        Walker( m_root , job );
-        return job.GetResult();
-    }
+    wxASSERT( !IsVirtualList() );
+
+    RowToTreeNodeJob job( row , -2, m_root );
+    Walker( m_root , job );
+    return job.GetResult();

 }
 
 wxDataViewEvent wxDataViewMainWindow::SendExpanderEvent( wxEventType type, const wxDataViewItem & item )
 }
 
 wxDataViewEvent wxDataViewMainWindow::SendExpanderEvent( wxEventType type, const wxDataViewItem & item )


@@ -3045,8 +2848,31 @@ wxDataViewEvent wxDataViewMainWindow::SendExpanderEvent( wxEventType type, const
     return le;
 }
 
     return le;
 }
 

+
+bool wxDataViewMainWindow::IsExpanded( unsigned int row ) const
+{
+    if (IsVirtualList())
+    return false;
+
+    wxDataViewTreeNode * node = GetTreeNodeByRow(row);
+    if (!node)
+    return false;
+
+    if (!node->HasChildren())
+    {
+    delete node;
+    return false;
+    }
+
+    return node->IsOpen();
+}
+
+

 void wxDataViewMainWindow::OnExpanding( unsigned int row )
 {
 void wxDataViewMainWindow::OnExpanding( unsigned int row )
 {

+    if (IsVirtualList())
+    return;
+

     wxDataViewTreeNode * node = GetTreeNodeByRow(row);
     if( node != NULL )
     {
     wxDataViewTreeNode * node = GetTreeNodeByRow(row);
     if( node != NULL )
     {


@@ -3054,22 +2880,39 @@ void wxDataViewMainWindow::OnExpanding( unsigned int row )
         {
             if( !node->IsOpen())
             {
         {
             if( !node->IsOpen())
             {

-               wxDataViewEvent e = SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_EXPANDING,node->GetItem());
-               //Check if the user prevent expanding
-               if( e.GetSkipped() )
+            wxDataViewEvent e = SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_EXPANDING,node->GetItem());
+            //Check if the user prevent expanding
+            if( e.GetSkipped() )

                     return;
 
                     return;
 

-               node->ToggleOpen();
-               //Here I build the children of current node
-               if( node->GetChildrenNumber() == 0 )
-               {
-                   SortPrepare();
-                   ::BuildTreeHelper(GetOwner()->GetModel(), node->GetItem(), node);
-               }
-               m_count = -1;
-               UpdateDisplay();
-               //Send the expanded event
-               SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_EXPANDED,node->GetItem());
+            node->ToggleOpen();
+            //Here I build the children of current node
+            if( node->GetChildrenNumber() == 0 )
+            {
+                SortPrepare();
+                ::BuildTreeHelper(GetOwner()->GetModel(), node->GetItem(), node);
+            }
+
+            // By expanding the node all row indices that are currently in the selection list
+            // and are greater than our node have become invalid. So we have to correct that now.
+            const unsigned rowAdjustment = node->GetSubTreeCount();
+            for(unsigned i=0; i<m_selection.size(); ++i)
+            {
+                const unsigned testRow = m_selection[i];
+                // all rows above us are not affected, so skip them
+                if(testRow <= row)
+                    continue;
+
+                m_selection[i] += rowAdjustment;
+            }
+
+            if(m_currentRow > row)
+                ChangeCurrentRow(m_currentRow + rowAdjustment);
+
+            m_count = -1;
+            UpdateDisplay();
+            //Send the expanded event
+            SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_EXPANDED,node->GetItem());

             }
             else
             {
             }
             else
             {


@@ -3086,6 +2929,9 @@ void wxDataViewMainWindow::OnExpanding( unsigned int row )
 
 void wxDataViewMainWindow::OnCollapsing(unsigned int row)
 {
 
 void wxDataViewMainWindow::OnCollapsing(unsigned int row)
 {

+    if (IsVirtualList())
+    return;
+

     wxDataViewTreeNode * node = GetTreeNodeByRow(row);
     if( node != NULL )
     {
     wxDataViewTreeNode * node = GetTreeNodeByRow(row);
     if( node != NULL )
     {


@@ -3096,7 +2942,55 @@ void wxDataViewMainWindow::OnCollapsing(unsigned int row)
             wxDataViewEvent e = SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_COLLAPSING,node->GetItem());
             if( e.GetSkipped() )
                 return;
             wxDataViewEvent e = SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_COLLAPSING,node->GetItem());
             if( e.GetSkipped() )
                 return;

+
+            // Find out if there are selected items below the current node.
+            bool selectCollapsingRow = false;
+            const unsigned rowAdjustment = node->GetSubTreeCount();
+            unsigned maxRowToBeTested = row + rowAdjustment;
+            for(unsigned i=0; i<m_selection.size(); ++i)
+            {
+                const unsigned testRow = m_selection[i];
+                if(testRow > row && testRow <= maxRowToBeTested)
+                {
+                    selectCollapsingRow = true;
+                    // get out as soon as we have found a node that is selected
+                    break;
+                }
+            }
+

             node->ToggleOpen();
             node->ToggleOpen();

+
+            // If the node to be closed has selected items the user won't see those any longer.
+            // We select the collapsing node in this case.
+            if(selectCollapsingRow)
+            {
+                SelectAllRows(false);
+                ChangeCurrentRow(row);
+                SelectRow(row, true);
+                SendSelectionChangedEvent(GetItemByRow(row));
+            }
+            else
+            {
+                // if there were no selected items below our node we still need to "fix" the
+                // selection list to adjust for the changing of the row indices.
+                // We actually do the opposite of what we are doing in OnExpanding().
+                for(unsigned i=0; i<m_selection.size(); ++i)
+                {
+                    const unsigned testRow = m_selection[i];
+                    // all rows above us are not affected, so skip them
+                    if(testRow <= row)
+                        continue;
+
+                    m_selection[i] -= rowAdjustment;
+                }
+
+                // if the "current row" is being collapsed away we change it to the current row ;-)
+                if(m_currentRow > row && m_currentRow <= maxRowToBeTested)
+                    ChangeCurrentRow(row);
+                else if(m_currentRow > row)
+                    ChangeCurrentRow(m_currentRow - rowAdjustment);
+            }
+

             m_count = -1;
             UpdateDisplay();
             SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_COLLAPSED,nd->GetItem());
             m_count = -1;
             UpdateDisplay();
             SendExpanderEvent(wxEVT_COMMAND_DATAVIEW_ITEM_COLLAPSED,nd->GetItem());


@@ -3106,7 +3000,7 @@ void wxDataViewMainWindow::OnCollapsing(unsigned int row)
             node = node->GetParent();
             if( node != NULL )
             {
             node = node->GetParent();
             if( node != NULL )
             {

-                int  parent = GetRowByItem( node->GetItem() ) ;
+                int  parent = GetRowByItem( node->GetItem() );

                 if( parent >= 0 )
                 {
                     SelectRow( row, false);
                 if( parent >= 0 )
                 {
                     SelectRow( row, false);


@@ -3127,6 +3021,9 @@ wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item
     if( model == NULL )
         return NULL;
 
     if( model == NULL )
         return NULL;
 

+    if (!item.IsOk())
+        return m_root;
+

     //Compose the a parent-chain of the finding item
     ItemList list;
     list.DeleteContents( true );
     //Compose the a parent-chain of the finding item
     ItemList list;
     list.DeleteContents( true );


@@ -3141,7 +3038,7 @@ wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item
     //Find the item along the parent-chain.
     //This algorithm is designed to speed up the node-finding method
     wxDataViewTreeNode * node = m_root;
     //Find the item along the parent-chain.
     //This algorithm is designed to speed up the node-finding method
     wxDataViewTreeNode * node = m_root;

-    for( ItemList::const_iterator iter = list.begin(); iter !=list.end() ; iter++ )
+    for( ItemList::const_iterator iter = list.begin(); iter !=list.end(); iter++ )

     {
         if( node->HasChildren() )
         {
     {
         if( node->HasChildren() )
         {


@@ -3154,14 +3051,14 @@ wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item
             wxDataViewTreeNodes nodes = node->GetNodes();
             unsigned int i;
             bool found = false;
             wxDataViewTreeNodes nodes = node->GetNodes();
             unsigned int i;
             bool found = false;

-            
+

             for (i = 0; i < nodes.GetCount(); i ++)
             {
                 if (nodes[i]->GetItem() == (**iter))
                 {
                     if (nodes[i]->GetItem() == item)
             for (i = 0; i < nodes.GetCount(); i ++)
             {
                 if (nodes[i]->GetItem() == (**iter))
                 {
                     if (nodes[i]->GetItem() == item)

-                       return nodes[i];
-                       
+                    return nodes[i];
+

                     node = nodes[i];
                     found = true;
                     break;
                     node = nodes[i];
                     found = true;
                     break;


@@ -3181,12 +3078,11 @@ void wxDataViewMainWindow::HitTest( const wxPoint & point, wxDataViewItem & item
     wxDataViewColumn *col = NULL;
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int colnum = 0;
     wxDataViewColumn *col = NULL;
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int colnum = 0;

-    unsigned int x_start = 0;

     int x, y;
     m_owner->CalcUnscrolledPosition( point.x, point.y, &x, &y );
     int x, y;
     m_owner->CalcUnscrolledPosition( point.x, point.y, &x, &y );

-    for (x_start = 0; colnum < cols; colnum++)
+    for (unsigned x_start = 0; colnum < cols; colnum++)

     {
     {

-        col = GetOwner()->GetColumn(colnum);
+        col = GetOwner()->GetColumnAt(colnum);

         if (col->IsHidden())
             continue;      // skip it!
 
         if (col->IsHidden())
             continue;      // skip it!
 


@@ -3198,22 +3094,22 @@ void wxDataViewMainWindow::HitTest( const wxPoint & point, wxDataViewItem & item
     }
 
     column = col;
     }
 
     column = col;

-    item = GetItemByRow( y/m_lineHeight );
+    item = GetItemByRow( GetLineAt( y ) );

 }
 
 wxRect wxDataViewMainWindow::GetItemRect( const wxDataViewItem & item, const wxDataViewColumn* column )
 {
     int row = GetRowByItem(item);
 }
 
 wxRect wxDataViewMainWindow::GetItemRect( const wxDataViewItem & item, const wxDataViewColumn* column )
 {
     int row = GetRowByItem(item);

-    int y = row*m_lineHeight;
-    int h = m_lineHeight;
+    int y = GetLineStart( row );
+    int h = GetLineHeight( m_lineHeight );

     int x = 0;
     wxDataViewColumn *col = NULL;
     for( int i = 0, cols = GetOwner()->GetColumnCount(); i < cols; i ++ )
     {
     int x = 0;
     wxDataViewColumn *col = NULL;
     for( int i = 0, cols = GetOwner()->GetColumnCount(); i < cols; i ++ )
     {

-       col = GetOwner()->GetColumn( i );
-       x += col->GetWidth();
-       if( GetOwner()->GetColumn(i+1) == column )
-           break;
+    col = GetOwner()->GetColumnAt( i );
+    x += col->GetWidth();
+    if( GetOwner()->GetColumnAt(i+1) == column )
+        break;

     }
     int w = col->GetWidth();
     m_owner->CalcScrolledPosition( x, y, &x, &y );
     }
     int w = col->GetWidth();
     m_owner->CalcScrolledPosition( x, y, &x, &y );


@@ -3240,29 +3136,32 @@ int wxDataViewMainWindow::RecalculateCount()
 class ItemToRowJob : public DoJob
 {
 public:
 class ItemToRowJob : public DoJob
 {
 public:

-    ItemToRowJob(const wxDataViewItem & item, ItemList::const_iterator iter )
-    { this->item = item ; ret = -1 ; m_iter = iter ; }
-    virtual ~ItemToRowJob(){};
+    ItemToRowJob(const wxDataViewItem& item_, ItemList::const_iterator iter)
+        : m_iter(iter),
+        item(item_)
+    {
+        ret = -1;
+    }

 
     //Maybe binary search will help to speed up this process
     virtual int operator() ( wxDataViewTreeNode * node)
     {
 
     //Maybe binary search will help to speed up this process
     virtual int operator() ( wxDataViewTreeNode * node)
     {

-         ret ++;
-         if( node->GetItem() == item )
-         {
-             return DoJob::OK;
-         }
+        ret ++;
+        if( node->GetItem() == item )
+        {
+            return DoJob::OK;
+        }

 
 

-         if( node->GetItem() == **m_iter )
-         {
-             m_iter++ ;
-             return DoJob::CONT;
-         }
-         else
-         {
-             ret += node->GetSubTreeCount();
-             return DoJob::IGR;
-         }
+        if( node->GetItem() == **m_iter )
+        {
+            m_iter++;
+            return DoJob::CONT;
+        }
+        else
+        {
+            ret += node->GetSubTreeCount();
+            return DoJob::IGR;
+        }

 
     }
 
 
     }
 


@@ -3274,7 +3173,8 @@ public:
         return DoJob::CONT;
     }
     //the row number is begin from zero
         return DoJob::CONT;
     }
     //the row number is begin from zero

-    int GetResult(){ return ret -1 ; }
+    int GetResult() { return ret -1; }
+

 private:
     ItemList::const_iterator  m_iter;
     wxDataViewItem item;
 private:
     ItemList::const_iterator  m_iter;
     wxDataViewItem item;


@@ -3282,9 +3182,9 @@ private:
 
 };
 
 
 };
 

-int wxDataViewMainWindow::GetRowByItem(const wxDataViewItem & item)
+int wxDataViewMainWindow::GetRowByItem(const wxDataViewItem & item) const

 {
 {

-    wxDataViewModel * model = GetOwner()->GetModel();
+    const wxDataViewModel * model = GetOwner()->GetModel();

     if( model == NULL )
         return -1;
 
     if( model == NULL )
         return -1;
 


@@ -3299,7 +3199,7 @@ int wxDataViewMainWindow::GetRowByItem(const wxDataViewItem & item)
 
         //Compose the a parent-chain of the finding item
         ItemList list;
 
         //Compose the a parent-chain of the finding item
         ItemList list;

-        wxDataViewItem * pItem = NULL;
+        wxDataViewItem * pItem;

         list.DeleteContents( true );
         wxDataViewItem it( item );
         while( it.IsOk() )
         list.DeleteContents( true );
         wxDataViewItem it( item );
         while( it.IsOk() )


@@ -3320,10 +3220,11 @@ int wxDataViewMainWindow::GetRowByItem(const wxDataViewItem & item)
 static void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node)
 {
     if( !model->IsContainer( item ) )
 static void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node)
 {
     if( !model->IsContainer( item ) )

-        return ;
+        return;

 
     wxDataViewItemArray children;
     unsigned int num = model->GetChildren( item, children);
 
     wxDataViewItemArray children;
     unsigned int num = model->GetChildren( item, children);

+

     unsigned int index = 0;
     while( index < num )
     {
     unsigned int index = 0;
     while( index < num )
     {


@@ -3331,7 +3232,7 @@ static void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wx
         {
             wxDataViewTreeNode * n = new wxDataViewTreeNode( node );
             n->SetItem(children[index]);
         {
             wxDataViewTreeNode * n = new wxDataViewTreeNode( node );
             n->SetItem(children[index]);

-            n->SetHasChildren( true ) ;
+            n->SetHasChildren( true );

             node->AddNode( n );
         }
         else
             node->AddNode( n );
         }
         else


@@ -3353,7 +3254,7 @@ void wxDataViewMainWindow::BuildTree(wxDataViewModel * model)
 
     if (GetOwner()->GetModel()->IsVirtualListModel())
     {
 
     if (GetOwner()->GetModel()->IsVirtualListModel())
     {

-        m_count = -1 ;
+        m_count = -1;

         return;
     }
 
         return;
     }
 


@@ -3364,7 +3265,7 @@ void wxDataViewMainWindow::BuildTree(wxDataViewModel * model)
     wxDataViewItem item;
     SortPrepare();
     BuildTreeHelper( model, item, m_root);
     wxDataViewItem item;
     SortPrepare();
     BuildTreeHelper( model, item, m_root);

-    m_count = -1 ;
+    m_count = -1;

 }
 
 static void DestroyTreeHelper( wxDataViewTreeNode * node )
 }
 
 static void DestroyTreeHelper( wxDataViewTreeNode * node )


@@ -3372,9 +3273,9 @@ static void DestroyTreeHelper( wxDataViewTreeNode * node )
     if( node->GetNodeNumber() != 0 )
     {
         int len = node->GetNodeNumber();
     if( node->GetNodeNumber() != 0 )
     {
         int len = node->GetNodeNumber();

-        int i = 0 ;
+        int i = 0;

         wxDataViewTreeNodes& nodes = node->GetNodes();
         wxDataViewTreeNodes& nodes = node->GetNodes();

-        for( ; i < len; i ++ )
+        for(; i < len; i ++ )

         {
             DestroyTreeHelper(nodes[i]);
         }
         {
             DestroyTreeHelper(nodes[i]);
         }


@@ -3384,9 +3285,9 @@ static void DestroyTreeHelper( wxDataViewTreeNode * node )
 
 void wxDataViewMainWindow::DestroyTree()
 {
 
 void wxDataViewMainWindow::DestroyTree()
 {

-    if (m_root)
+    if (!IsVirtualList())

     {
     {

-       ::DestroyTreeHelper(m_root);
+    ::DestroyTreeHelper(m_root);

         m_count = 0;
         m_root = NULL;
     }
         m_count = 0;
         m_root = NULL;
     }


@@ -3394,7 +3295,7 @@ void wxDataViewMainWindow::DestroyTree()
 
 void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
 {
 
 void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
 {

-    if ( HandleAsNavigationKey(event) )
+    if ( GetParent()->HandleAsNavigationKey(event) )

         return;
 
     // no item -> nothing to do
         return;
 
     // no item -> nothing to do


@@ -3412,7 +3313,7 @@ void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
     {
         case WXK_RETURN:
         {
     {
         case WXK_RETURN:
         {

-            if (m_currentRow > 0)
+            if (m_currentRow >= 0)

             {
                 wxWindow *parent = GetParent();
                 wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());
             {
                 wxWindow *parent = GetParent();
                 wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());


@@ -3435,11 +3336,11 @@ void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
             break;
         //Add the process for tree expanding/collapsing
         case WXK_LEFT:
             break;
         //Add the process for tree expanding/collapsing
         case WXK_LEFT:

-         OnCollapsing(m_currentRow);
-         break;
-     case WXK_RIGHT:
-         OnExpanding( m_currentRow);
-         break;
+        OnCollapsing(m_currentRow);
+        break;
+    case WXK_RIGHT:
+        OnExpanding( m_currentRow);
+        break;

         case WXK_END:
             if (!IsEmpty())
                 OnArrowChar( GetRowCount() - 1, event );
         case WXK_END:
             if (!IsEmpty())
                 OnArrowChar( GetRowCount() - 1, event );


@@ -3497,7 +3398,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     unsigned int i;
     for (i = 0; i < cols; i++)
     {
     unsigned int i;
     for (i = 0; i < cols; i++)
     {

-        wxDataViewColumn *c = GetOwner()->GetColumn( i );
+        wxDataViewColumn *c = GetOwner()->GetColumnAt( i );

         if (c->IsHidden())
             continue;      // skip it!
 
         if (c->IsHidden())
             continue;      // skip it!
 


@@ -3512,27 +3413,32 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         return;
 
     wxDataViewRenderer *cell = col->GetRenderer();
         return;
 
     wxDataViewRenderer *cell = col->GetRenderer();

-    unsigned int current = y / m_lineHeight;
-    if ((current > GetRowCount()) || (x > GetEndOfLastCol()))
+    unsigned int current = GetLineAt( y );
+    if ((current >= GetRowCount()) || (x > GetEndOfLastCol()))

     {
         // Unselect all if below the last row ?
         return;
     }
 
     //Test whether the mouse is hovered on the tree item button
     {
         // Unselect all if below the last row ?
         return;
     }
 
     //Test whether the mouse is hovered on the tree item button

-    bool hover = false;
-    if ((m_root) && (GetOwner()->GetExpanderColumn() == col))
+    bool hoverOverExpander = false;
+    if ((!IsVirtualList()) && (GetOwner()->GetExpanderColumn() == col))

     {
         wxDataViewTreeNode * node = GetTreeNodeByRow(current);
         if( node!=NULL && node->HasChildren() )
         {
             int indent = node->GetIndentLevel();
             indent = GetOwner()->GetIndent()*indent;
     {
         wxDataViewTreeNode * node = GetTreeNodeByRow(current);
         if( node!=NULL && node->HasChildren() )
         {
             int indent = node->GetIndentLevel();
             indent = GetOwner()->GetIndent()*indent;

-            wxRect rect( xpos + indent + EXPANDER_MARGIN, current * m_lineHeight + EXPANDER_MARGIN, m_lineHeight-2*EXPANDER_MARGIN,m_lineHeight-2*EXPANDER_MARGIN);
-            if( rect.Contains( x, y) )
+
+            // we make the rectangle we are looking in a bit bigger than the actual
+            // visual expander so the user can hit that little thing reliably
+            wxRect rect( xpos + indent,
+                        GetLineStart( current ) + (GetLineHeight(current) - m_lineHeight)/2,
+                        m_lineHeight, m_lineHeight);
+            if( rect.Contains(x, y) )

             {
                 //So the mouse is over the expander
             {
                 //So the mouse is over the expander

-                hover = true;
+                hoverOverExpander = true;

                 if (m_underMouse && m_underMouse != node)
                 {
                     //wxLogMessage("Undo the row: %d", GetRowByItem(m_underMouse->GetItem()));
                 if (m_underMouse && m_underMouse != node)
                 {
                     //wxLogMessage("Undo the row: %d", GetRowByItem(m_underMouse->GetItem()));


@@ -3549,7 +3455,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         if (node!=NULL && !node->HasChildren())
             delete node;
     }
         if (node!=NULL && !node->HasChildren())
             delete node;
     }

-    if (!hover)
+    if (!hoverOverExpander)

     {
         if (m_underMouse != NULL)
         {
     {
         if (m_underMouse != NULL)
         {


@@ -3561,6 +3467,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
 
     wxDataViewModel *model = GetOwner()->GetModel();
 
 
     wxDataViewModel *model = GetOwner()->GetModel();
 

+#if wxUSE_DRAG_AND_DROP

     if (event.Dragging())
     {
         if (m_dragCount == 0)
     if (event.Dragging())
     {
         if (m_dragCount == 0)


@@ -3578,7 +3485,29 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
 
         if (event.LeftIsDown())
         {
 
         if (event.LeftIsDown())
         {

+            m_owner->CalcUnscrolledPosition( m_dragStart.x, m_dragStart.y, &m_dragStart.x, &m_dragStart.y );
+            unsigned int drag_item_row = GetLineAt( m_dragStart.y );
+            wxDataViewItem item = GetItemByRow( drag_item_row );
+

             // Notify cell about drag
             // Notify cell about drag

+            wxDataViewEvent event( wxEVT_COMMAND_DATAVIEW_ITEM_BEGIN_DRAG, m_owner->GetId() );
+            event.SetEventObject( m_owner );
+            event.SetItem( item );
+            event.SetModel( model );
+            if (!m_owner->HandleWindowEvent( event ))
+                return;
+
+            if (!event.IsAllowed())
+                return;
+
+            wxDataObject *obj = event.GetDataObject();
+            if (!obj)
+                return;
+
+            wxDataViewDropSource drag( this, drag_item_row );
+            drag.SetData( *obj );
+            /* wxDragResult res = */ drag.DoDragDrop();
+            delete obj;

         }
         return;
     }
         }
         return;
     }


@@ -3586,8 +3515,9 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     {
         m_dragCount = 0;
     }
     {
         m_dragCount = 0;
     }

+#endif // wxUSE_DRAG_AND_DROP

 
 

-    bool forceClick = false;
+    bool simulateClick = false;

 
     if (event.ButtonDClick())
     {
 
     if (event.ButtonDClick())
     {


@@ -3598,20 +3528,25 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     wxDataViewItem item = GetItemByRow(current);
     bool ignore_other_columns =
         ((GetOwner()->GetExpanderColumn() != col) &&
     wxDataViewItem item = GetItemByRow(current);
     bool ignore_other_columns =
         ((GetOwner()->GetExpanderColumn() != col) &&

-         (model->IsContainer(item)) &&
-         (!model->HasContainerColumns(item)));
+        (model->IsContainer(item)) &&
+        (!model->HasContainerColumns(item)));

 
     if (event.LeftDClick())
     {
 
     if (event.LeftDClick())
     {

-        if ( current == m_lineLastClicked )
+        if(hoverOverExpander)
+        {
+            // a double click on the expander will be converted into a "simulated" normal click
+            simulateClick = true;
+        }
+        else if ( current == m_lineLastClicked )

         {
             if ((!ignore_other_columns) && (cell->GetMode() == wxDATAVIEW_CELL_ACTIVATABLE))
             {
                 wxVariant value;
                 model->GetValue( value, item, col->GetModelColumn() );
                 cell->SetValue( value );
         {
             if ((!ignore_other_columns) && (cell->GetMode() == wxDATAVIEW_CELL_ACTIVATABLE))
             {
                 wxVariant value;
                 model->GetValue( value, item, col->GetModelColumn() );
                 cell->SetValue( value );

-                wxRect cell_rect( xpos, current * m_lineHeight,
-                                  col->GetWidth(), m_lineHeight );
+                wxRect cell_rect( xpos, GetLineStart( current ),
+                                col->GetWidth(), GetLineHeight( current ) );

                 cell->Activate( cell_rect, model, item, col->GetModelColumn() );
 
             }
                 cell->Activate( cell_rect, model, item, col->GetModelColumn() );
 
             }


@@ -3631,43 +3566,22 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         {
             // The first click was on another item, so don't interpret this as
             // a double click, but as a simple click instead
         {
             // The first click was on another item, so don't interpret this as
             // a double click, but as a simple click instead

-            forceClick = true;
+            simulateClick = true;

         }
     }
 
         }
     }
 

-    if (event.LeftUp())
+    if (event.LeftUp() && !hoverOverExpander)

     {
         if (m_lineSelectSingleOnUp != (unsigned int)-1)
         {
             // select single line
             SelectAllRows( false );
             SelectRow( m_lineSelectSingleOnUp, true );
     {
         if (m_lineSelectSingleOnUp != (unsigned int)-1)
         {
             // select single line
             SelectAllRows( false );
             SelectRow( m_lineSelectSingleOnUp, true );

+            SendSelectionChangedEvent( GetItemByRow(m_lineSelectSingleOnUp) );

         }
 
         }
 

-        //Process the event of user clicking the expander
-        bool expander = false;
-        if ((m_root) && (GetOwner()->GetExpanderColumn() == col))
-        {
-            wxDataViewTreeNode * node = GetTreeNodeByRow(current);
-            if( node!=NULL && node->HasChildren() )
-            {
-                int indent = node->GetIndentLevel();
-                indent = GetOwner()->GetIndent()*indent;
-                wxRect rect( xpos + indent + EXPANDER_MARGIN, current * m_lineHeight + EXPANDER_MARGIN, m_lineHeight-2*EXPANDER_MARGIN,m_lineHeight-2*EXPANDER_MARGIN);
-                if( rect.Contains( x, y) )
-                {
-                    expander = true;
-                    if( node->IsOpen() )
-                        OnCollapsing(current);
-                    else
-                        OnExpanding( current );
-                }
-            }
-            if (node && !node->HasChildren())
-               delete node;
-        }

         //If the user click the expander, we do not do editing even if the column with expander are editable
         //If the user click the expander, we do not do editing even if the column with expander are editable

-        if (m_lastOnSame && !expander && !ignore_other_columns)
+        if (m_lastOnSame && !ignore_other_columns)

         {
             if ((col == m_currentCol) && (current == m_currentRow) &&
                 (cell->GetMode() & wxDATAVIEW_CELL_EDITABLE) )
         {
             if ((col == m_currentCol) && (current == m_currentRow) &&
                 (cell->GetMode() & wxDATAVIEW_CELL_EDITABLE) )


@@ -3679,7 +3593,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         m_lastOnSame = false;
         m_lineSelectSingleOnUp = (unsigned int)-1;
     }
         m_lastOnSame = false;
         m_lineSelectSingleOnUp = (unsigned int)-1;
     }

-    else
+    else if(!event.LeftUp())

     {
         // This is necessary, because after a DnD operation in
         // from and to ourself, the up event is swallowed by the
     {
         // This is necessary, because after a DnD operation in
         // from and to ourself, the up event is swallowed by the


@@ -3716,7 +3630,18 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     else if (event.MiddleDown())
     {
     }
     else if (event.MiddleDown())
     {
     }

-    if (event.LeftDown() || forceClick)
+
+    if((event.LeftDown() || simulateClick) && hoverOverExpander)
+    {
+        wxDataViewTreeNode* node = GetTreeNodeByRow(current);
+        // hoverOverExpander being true tells us that our node must be valid and have children.
+        // So we don't need any extra checks.
+        if( node->IsOpen() )
+            OnCollapsing(current);
+        else
+            OnExpanding(current);
+    }
+    else if ((event.LeftDown() || simulateClick) && !hoverOverExpander)

     {
         SetFocus();
 
     {
         SetFocus();
 


@@ -3755,7 +3680,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
                 ChangeCurrentRow(current);
 
                 unsigned int lineFrom = oldCurrentRow,
                 ChangeCurrentRow(current);
 
                 unsigned int lineFrom = oldCurrentRow,

-                       lineTo = current;
+                    lineTo = current;

 
                 if ( lineTo < lineFrom )
                 {
 
                 if ( lineTo < lineFrom )
                 {


@@ -3772,7 +3697,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
                 wxFAIL_MSG( _T("how did we get here?") );
             }
         }
                 wxFAIL_MSG( _T("how did we get here?") );
             }
         }

-        
+

         if (m_currentRow != oldCurrentRow)
             RefreshRow( oldCurrentRow );
 
         if (m_currentRow != oldCurrentRow)
             RefreshRow( oldCurrentRow );
 


@@ -3781,7 +3706,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         // Update selection here...
         m_currentCol = col;
 
         // Update selection here...
         m_currentCol = col;
 

-        m_lastOnSame = !forceClick && ((col == oldCurrentCol) &&
+        m_lastOnSame = !simulateClick && ((col == oldCurrentCol) &&

                         (current == oldCurrentRow)) && oldWasSelected;
 
         // Call LeftClick after everything else as under GTK+
                         (current == oldCurrentRow)) && oldWasSelected;
 
         // Call LeftClick after everything else as under GTK+


@@ -3791,8 +3716,8 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
             wxVariant value;
             model->GetValue( value, item, col->GetModelColumn() );
             cell->SetValue( value );
             wxVariant value;
             model->GetValue( value, item, col->GetModelColumn() );
             cell->SetValue( value );

-            wxRect cell_rect( xpos, current * m_lineHeight,
-                          col->GetWidth(), m_lineHeight );
+            wxRect cell_rect( xpos, GetLineStart( current ),
+                        col->GetWidth(), GetLineHeight( current ) );

             /* ignore ret */ cell->LeftClick( event.GetPosition(), cell_rect, model, item, col->GetModelColumn());
         }
     }
             /* ignore ret */ cell->LeftClick( event.GetPosition(), cell_rect, model, item, col->GetModelColumn());
         }
     }


@@ -3842,35 +3767,37 @@ wxDataViewCtrl::~wxDataViewCtrl()
     if (m_notifier)
         GetModel()->RemoveNotifier( m_notifier );
 
     if (m_notifier)
         GetModel()->RemoveNotifier( m_notifier );
 

-    wxDataViewColumnList::const_iterator iter;
-    for (iter = m_cols.begin(); iter!=m_cols.end(); iter++)
-    {
-        delete *iter;
-    }
+    m_cols.Clear();

 }
 
 void wxDataViewCtrl::Init()
 {
 }
 
 void wxDataViewCtrl::Init()
 {

+    m_cols.DeleteContents(true);

     m_notifier = NULL;
     m_notifier = NULL;

+
+    // No sorting column at start
+    m_sortingColumnIdx = wxNOT_FOUND;
+
+    m_headerArea = NULL;

 }
 
 bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,
 }
 
 bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,

-           const wxPoint& pos, const wxSize& size,
-           long style, const wxValidator& validator )
+        const wxPoint& pos, const wxSize& size,
+        long style, const wxValidator& validator )

 {
 {

-    if ( (style & wxBORDER_MASK) == 0)
-        style |= wxBORDER_SUNKEN;
-    
+//    if ( (style & wxBORDER_MASK) == 0)
+//        style |= wxBORDER_SUNKEN;
+
+    Init();
+

     if (!wxControl::Create( parent, id, pos, size,
                             style | wxScrolledWindowStyle, validator))
         return false;
 
     SetInitialSize(size);
 
     if (!wxControl::Create( parent, id, pos, size,
                             style | wxScrolledWindowStyle, validator))
         return false;
 
     SetInitialSize(size);
 

-    Init();
-

 #ifdef __WXMAC__
 #ifdef __WXMAC__

-    MacSetClipChildren( true ) ;
+    MacSetClipChildren( true );

 #endif
 
     m_clientArea = new wxDataViewMainWindow( this, wxID_ANY );
 #endif
 
     m_clientArea = new wxDataViewMainWindow( this, wxID_ANY );


@@ -3878,7 +3805,7 @@ bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,
     if (HasFlag(wxDV_NO_HEADER))
         m_headerArea = NULL;
     else
     if (HasFlag(wxDV_NO_HEADER))
         m_headerArea = NULL;
     else

-        m_headerArea = new wxDataViewHeaderWindow( this, wxID_ANY );
+        m_headerArea = new wxDataViewHeaderWindow(this);

 
     SetTargetWindow( m_clientArea );
 
 
     SetTargetWindow( m_clientArea );
 


@@ -3891,10 +3818,15 @@ bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,
     return true;
 }
 
     return true;
 }
 

+wxBorder wxDataViewCtrl::GetDefaultBorder() const
+{
+    return wxBORDER_THEME;
+}
+

 #ifdef __WXMSW__
 WXLRESULT wxDataViewCtrl::MSWWindowProc(WXUINT nMsg,
 #ifdef __WXMSW__
 WXLRESULT wxDataViewCtrl::MSWWindowProc(WXUINT nMsg,

-                                       WXWPARAM wParam,
-                                       WXLPARAM lParam)
+                                    WXWPARAM wParam,
+                                    WXLPARAM lParam)

 {
     WXLRESULT rc = wxDataViewCtrlBase::MSWWindowProc(nMsg, wParam, lParam);
 
 {
     WXLRESULT rc = wxDataViewCtrlBase::MSWWindowProc(nMsg, wParam, lParam);
 


@@ -3910,6 +3842,15 @@ WXLRESULT wxDataViewCtrl::MSWWindowProc(WXUINT nMsg,
 }
 #endif
 
 }
 #endif
 

+wxSize wxDataViewCtrl::GetSizeAvailableForScrollTarget(const wxSize& size)
+{
+    wxSize newsize = size;
+    if (!HasFlag(wxDV_NO_HEADER) && (m_headerArea))
+    newsize.y -= m_headerArea->GetSize().y;
+
+    return newsize;
+}
+

 void wxDataViewCtrl::OnSize( wxSizeEvent &WXUNUSED(event) )
 {
     // We need to override OnSize so that our scrolled
 void wxDataViewCtrl::OnSize( wxSizeEvent &WXUNUSED(event) )
 {
     // We need to override OnSize so that our scrolled


@@ -3924,6 +3865,12 @@ void wxDataViewCtrl::OnSize( wxSizeEvent &WXUNUSED(event) )
     AdjustScrollbars();
 }
 
     AdjustScrollbars();
 }
 

+void wxDataViewCtrl::SetFocus()
+{
+    if (m_clientArea)
+        m_clientArea->SetFocus();
+}
+

 bool wxDataViewCtrl::AssociateModel( wxDataViewModel *model )
 {
     if (!wxDataViewCtrlBase::AssociateModel( model ))
 bool wxDataViewCtrl::AssociateModel( wxDataViewModel *model )
 {
     if (!wxDataViewCtrlBase::AssociateModel( model ))


@@ -3942,13 +3889,27 @@ bool wxDataViewCtrl::AssociateModel( wxDataViewModel *model )
     return true;
 }
 
     return true;
 }
 

+#if wxUSE_DRAG_AND_DROP
+
+bool wxDataViewCtrl::EnableDragSource( const wxDataFormat &format )
+{
+    return m_clientArea->EnableDragSource( format );
+}
+
+bool wxDataViewCtrl::EnableDropTarget( const wxDataFormat &format )
+{
+    return m_clientArea->EnableDropTarget( format );
+}
+
+#endif // wxUSE_DRAG_AND_DROP
+

 bool wxDataViewCtrl::AppendColumn( wxDataViewColumn *col )
 {
     if (!wxDataViewCtrlBase::AppendColumn(col))
         return false;
 
     m_cols.Append( col );
 bool wxDataViewCtrl::AppendColumn( wxDataViewColumn *col )
 {
     if (!wxDataViewCtrlBase::AppendColumn(col))
         return false;
 
     m_cols.Append( col );

-    OnColumnChange();
+    OnColumnsCountChanged();

     return true;
 }
 
     return true;
 }
 


@@ -3958,14 +3919,32 @@ bool wxDataViewCtrl::PrependColumn( wxDataViewColumn *col )
         return false;
 
     m_cols.Insert( col );
         return false;
 
     m_cols.Insert( col );

-    OnColumnChange();
+    OnColumnsCountChanged();
+    return true;
+}
+
+bool wxDataViewCtrl::InsertColumn( unsigned int pos, wxDataViewColumn *col )
+{
+    if (!wxDataViewCtrlBase::InsertColumn(pos,col))
+        return false;
+
+    m_cols.Insert( pos, col );
+    OnColumnsCountChanged();

     return true;
 }
 
     return true;
 }
 

-void wxDataViewCtrl::OnColumnChange()
+void wxDataViewCtrl::OnColumnChange(unsigned int idx)
+{
+    if ( m_headerArea )
+        m_headerArea->UpdateColumn(idx);
+
+    m_clientArea->UpdateDisplay();
+}
+
+void wxDataViewCtrl::OnColumnsCountChanged()

 {
     if (m_headerArea)
 {
     if (m_headerArea)

-        m_headerArea->UpdateDisplay();
+        m_headerArea->SetColumnCount(GetColumnCount());

 
     m_clientArea->UpdateDisplay();
 }
 
     m_clientArea->UpdateDisplay();
 }


@@ -3985,64 +3964,75 @@ unsigned int wxDataViewCtrl::GetColumnCount() const
     return m_cols.GetCount();
 }
 
     return m_cols.GetCount();
 }
 

-wxDataViewColumn* wxDataViewCtrl::GetColumn( unsigned int pos ) const
+wxDataViewColumn* wxDataViewCtrl::GetColumn( unsigned int idx ) const

 {
 {

-    wxDataViewColumnList::const_iterator iter;
-    unsigned int i = 0;
-    for (iter = m_cols.begin(); iter!=m_cols.end(); iter++)
-    {
-        if (i == pos)
-            return *iter;
+    return m_cols[idx];
+}

 
 

-        if ((*iter)->IsHidden())
-            continue;
-        i ++;
-    }
-    return NULL;
+wxDataViewColumn *wxDataViewCtrl::GetColumnAt(unsigned int pos) const
+{
+    // columns can't be reordered if there is no header window which allows
+    // to do this
+    const unsigned idx = m_headerArea ? m_headerArea->GetColumnsOrder()[pos]
+                                    : pos;
+
+    return GetColumn(idx);

 }
 
 }
 

-void wxDataViewCtrl::ColumnMoved( wxDataViewColumn* col, unsigned int new_pos )
+int wxDataViewCtrl::GetColumnIndex(const wxDataViewColumn *column) const

 {
 {

-    if (new_pos > m_cols.GetCount()) return;
-    m_cols.DeleteObject( col );
-    m_cols.Insert( new_pos, col );
+    const unsigned count = m_cols.size();
+    for ( unsigned n = 0; n < count; n++ )
+    {
+        if ( m_cols[n] == column )
+            return n;
+    }
+
+    return wxNOT_FOUND;
+}

 
 

+void wxDataViewCtrl::ColumnMoved(wxDataViewColumn * WXUNUSED(col),
+                                unsigned int WXUNUSED(new_pos))
+{
+    // do _not_ reorder m_cols elements here, they should always be in the
+    // order in which columns were added, we only display the columns in
+    // different order

     m_clientArea->UpdateDisplay();
 }
 
 bool wxDataViewCtrl::DeleteColumn( wxDataViewColumn *column )
 {
     m_clientArea->UpdateDisplay();
 }
 
 bool wxDataViewCtrl::DeleteColumn( wxDataViewColumn *column )
 {

-    wxDataViewColumnList::compatibility_iterator  ret = m_cols.Find( column );
+    wxDataViewColumnList::compatibility_iterator ret = m_cols.Find( column );

     if (!ret)
         return false;
 
     m_cols.Erase(ret);
     if (!ret)
         return false;
 
     m_cols.Erase(ret);

-    delete column;
-    OnColumnChange();
+    OnColumnsCountChanged();

 
     return true;
 }
 
 bool wxDataViewCtrl::ClearColumns()
 {
 
     return true;
 }
 
 bool wxDataViewCtrl::ClearColumns()
 {

-    m_cols.clear();
-    OnColumnChange();
+    m_cols.Clear();
+    OnColumnsCountChanged();

     return true;
 }
 
 int wxDataViewCtrl::GetColumnPosition( const wxDataViewColumn *column ) const
 {
     return true;
 }
 
 int wxDataViewCtrl::GetColumnPosition( const wxDataViewColumn *column ) const
 {

-    int ret = 0, dead = 0;
-    int len = GetColumnCount();
-    for (int i=0; i<len; i++)
+    int ret = 0,
+        dummy = 0;
+    unsigned int len = GetColumnCount();
+    for ( unsigned int i = 0; i < len; i++ )

     {
     {

-        wxDataViewColumn * col = GetColumn(i);
+        wxDataViewColumn * col = GetColumnAt(i);

         if (col->IsHidden())
             continue;
         ret += col->GetWidth();
         if (column==col)
         {
         if (col->IsHidden())
             continue;
         ret += col->GetWidth();
         if (column==col)
         {

-            CalcScrolledPosition( ret, dead, &ret, &dead );
+            CalcScrolledPosition( ret, dummy, &ret, &dummy );

             break;
         }
     }
             break;
         }
     }


@@ -4051,7 +4041,8 @@ int wxDataViewCtrl::GetColumnPosition( const wxDataViewColumn *column ) const
 
 wxDataViewColumn *wxDataViewCtrl::GetSortingColumn() const
 {
 
 wxDataViewColumn *wxDataViewCtrl::GetSortingColumn() const
 {

-    return NULL;
+    return m_sortingColumnIdx == wxNOT_FOUND ? NULL
+                                            : GetColumn(m_sortingColumnIdx);

 }
 
 //Selection code with wxDataViewItem as parameters
 }
 
 //Selection code with wxDataViewItem as parameters


@@ -4075,19 +4066,34 @@ int wxDataViewCtrl::GetSelections( wxDataViewItemArray & sel ) const
 
 void wxDataViewCtrl::SetSelections( const wxDataViewItemArray & sel )
 {
 
 void wxDataViewCtrl::SetSelections( const wxDataViewItemArray & sel )
 {

-    wxDataViewSelection selection(wxDataViewSelectionCmp) ;
+    wxDataViewSelection selection(wxDataViewSelectionCmp);
+
+    wxDataViewItem last_parent;
+

     int len = sel.GetCount();
     for( int i = 0; i < len; i ++ )
     {
     int len = sel.GetCount();
     for( int i = 0; i < len; i ++ )
     {

-        int row = m_clientArea->GetRowByItem( sel[i] );
+        wxDataViewItem item = sel[i];
+        wxDataViewItem parent = GetModel()->GetParent( item );
+        if (parent)
+        {
+            if (parent != last_parent)
+                ExpandAncestors(item);
+        }
+
+        last_parent = parent;
+        int row = m_clientArea->GetRowByItem( item );

         if( row >= 0 )
             selection.Add( static_cast<unsigned int>(row) );
     }
         if( row >= 0 )
             selection.Add( static_cast<unsigned int>(row) );
     }

+

     m_clientArea->SetSelections( selection );
 }
 
 void wxDataViewCtrl::Select( const wxDataViewItem & item )
 {
     m_clientArea->SetSelections( selection );
 }
 
 void wxDataViewCtrl::Select( const wxDataViewItem & item )
 {

+    ExpandAncestors( item );
+

     int row = m_clientArea->GetRowByItem( item );
     if( row >= 0 )
     {
     int row = m_clientArea->GetRowByItem( item );
     if( row >= 0 )
     {


@@ -4131,7 +4137,7 @@ int wxDataViewCtrl::GetSelections( wxArrayInt & sel ) const
 
 void wxDataViewCtrl::SetSelections( const wxArrayInt & sel )
 {
 
 void wxDataViewCtrl::SetSelections( const wxArrayInt & sel )
 {

-    wxDataViewSelection selection(wxDataViewSelectionCmp) ;
+    wxDataViewSelection selection(wxDataViewSelectionCmp);

     int len = sel.GetCount();
     for( int i = 0; i < len; i ++ )
     {
     int len = sel.GetCount();
     for( int i = 0; i < len; i ++ )
     {


@@ -4211,23 +4217,17 @@ void wxDataViewCtrl::EnsureVisible( int row, int column )
 
 void wxDataViewCtrl::EnsureVisible( const wxDataViewItem & item, const wxDataViewColumn * column )
 {
 
 void wxDataViewCtrl::EnsureVisible( const wxDataViewItem & item, const wxDataViewColumn * column )
 {

+    ExpandAncestors( item );
+
+    m_clientArea->RecalculateDisplay();
+

     int row = m_clientArea->GetRowByItem(item);
     if( row >= 0 )
     {
         if( column == NULL )
             EnsureVisible(row, -1);
         else
     int row = m_clientArea->GetRowByItem(item);
     if( row >= 0 )
     {
         if( column == NULL )
             EnsureVisible(row, -1);
         else

-        {
-            int col = 0;
-            int len = GetColumnCount();
-            for( int i = 0; i < len; i ++ )
-                if( GetColumn(i) == column )
-                {
-                    col = i;
-                    break;
-                }
-            EnsureVisible( row, col );
-        }
+            EnsureVisible( row, GetColumnIndex(column) );

     }
 
 }
     }
 
 }


@@ -4266,7 +4266,16 @@ void wxDataViewCtrl::Collapse( const wxDataViewItem & item )
         m_clientArea->Collapse(row);
 }
 
         m_clientArea->Collapse(row);
 }
 

- #endif
+bool wxDataViewCtrl::IsExpanded( const wxDataViewItem & item ) const
+{
+    int row = m_clientArea->GetRowByItem( item );
+    if (row != -1)
+        return m_clientArea->IsExpanded(row);
+    return false;
+}
+
+
+#endif

     // !wxUSE_GENERICDATAVIEWCTRL
 
 #endif
     // !wxUSE_GENERICDATAVIEWCTRL
 
 #endif