fixing overrelease and out-of-bounds write, fixes #13725

[wxWidgets.git] / src / common / markupparser.cpp

diff --git a/src/common/markupparser.cpp b/src/common/markupparser.cpp
index cb87983b0e72f86b0d0f1bdfee96fc27da963b7b..70b680bd7f9a2a6d9d688f50d91d81b6336aa558 100644 (file)
--- a/src/common/markupparser.cpp
+++ b/src/common/markupparser.cpp
@@ -172,7 +172,6 @@ wxMarkupParser::ParseAttrs(wxString attrs, TagAndAttrs& tagAndAttrs)
             else // Must be a CSS-like size specification
             {
                 int cssSize = 1;
-                wxString rest;
                 if ( value.StartsWith("xx-", &rest) )
                     cssSize = 3;
                 else if ( value.StartsWith("x-", &rest) )
@@ -279,7 +278,12 @@ bool wxMarkupParser::Parse(const wxString& text)
                         m_output.OnText(current);
                         current.clear();
                     }
-#if wxUSE_LOG_DEBUG
+
+                    // This variable is used only in the debugging messages
+                    // and doesn't need to be defined if they're not compiled
+                    // at all (it actually would result in unused variable
+                    // messages in this case).
+#if wxUSE_LOG_DEBUG || !defined(HAVE_VARIADIC_MACROS)
                     // Remember the tag starting position for the error
                     // messages.
                     const size_t pos = it - text.begin();