Fixed player dialog listbox size and app icon on wxGTK

[wxWidgets.git] / src / generic / htmllbox.cpp

diff --git a/src/generic/htmllbox.cpp b/src/generic/htmllbox.cpp
index 22e2722cec1d411dc210f4d4793e6cad786399fb..cc51601b0d8d490a0f3eb1e4c367a74d4dc53f1d 100644 (file)
--- a/src/generic/htmllbox.cpp
+++ b/src/generic/htmllbox.cpp
@@ -464,7 +464,7 @@ wxPoint wxHtmlListBox::GetRootCellCoords(size_t n) const
 
 bool wxHtmlListBox::PhysicalCoordsToCell(wxPoint& pos, wxHtmlCell*& cell) const
 {
 
 bool wxHtmlListBox::PhysicalCoordsToCell(wxPoint& pos, wxHtmlCell*& cell) const
 {

-    int n = HitTest(pos);
+    int n = VirtualHitTest(pos.y);

     if ( n == wxNOT_FOUND )
         return false;
 
     if ( n == wxNOT_FOUND )
         return false;
 


@@ -562,19 +562,19 @@ bool wxSimpleHtmlListBox::Create(wxWindow *parent, wxWindowID id,
 #if wxUSE_VALIDATORS
     SetValidator(validator);
 #endif
 #if wxUSE_VALIDATORS
     SetValidator(validator);
 #endif

-    for (int i=0; i<n; i++)
-        Append(choices[i]);
+
+    Append(n, choices);

 
     return true;
 }
 
 bool wxSimpleHtmlListBox::Create(wxWindow *parent, wxWindowID id,
 
     return true;
 }
 
 bool wxSimpleHtmlListBox::Create(wxWindow *parent, wxWindowID id,

-                                    const wxPoint& pos,
-                                    const wxSize& size,
-                                    const wxArrayString& choices,
-                                    long style,
-                                    const wxValidator& validator,
-                                    const wxString& name)
+                                 const wxPoint& pos,
+                                 const wxSize& size,
+                                 const wxArrayString& choices,
+                                 long style,
+                                 const wxValidator& validator,
+                                 const wxString& name)

 {
     if (!wxHtmlListBox::Create(parent, id, pos, size, style, name))
         return false;
 {
     if (!wxHtmlListBox::Create(parent, id, pos, size, style, name))
         return false;


@@ -582,6 +582,7 @@ bool wxSimpleHtmlListBox::Create(wxWindow *parent, wxWindowID id,
 #if wxUSE_VALIDATORS
     SetValidator(validator);
 #endif
 #if wxUSE_VALIDATORS
     SetValidator(validator);
 #endif

+

     Append(choices);
 
     return true;
     Append(choices);
 
     return true;


@@ -589,53 +590,46 @@ bool wxSimpleHtmlListBox::Create(wxWindow *parent, wxWindowID id,
 
 wxSimpleHtmlListBox::~wxSimpleHtmlListBox()
 {
 
 wxSimpleHtmlListBox::~wxSimpleHtmlListBox()
 {

-    wxASSERT(m_items.GetCount() == m_HTMLclientData.GetCount());
-    if (HasClientObjectData())
-    {
-        // clear the array of client data objects
-        for (size_t i=0; i<m_items.GetCount(); i++)
-            delete DoGetItemClientObject(i);
-    }
-
-    m_items.Clear();
-    m_HTMLclientData.Clear();
+    wxItemContainer::Clear();

 }
 
 }
 

-void wxSimpleHtmlListBox::Clear()
+void wxSimpleHtmlListBox::DoClear()

 {
 {

+    wxASSERT(m_items.GetCount() == m_HTMLclientData.GetCount());
+

     m_items.Clear();
     m_HTMLclientData.Clear();
     m_items.Clear();
     m_HTMLclientData.Clear();

+

     UpdateCount();
 }
 
     UpdateCount();
 }
 

-void wxSimpleHtmlListBox::Delete(unsigned int n)
+void wxSimpleHtmlListBox::DoDeleteOneItem(unsigned int n)

 {
     m_items.RemoveAt(n);
 {
     m_items.RemoveAt(n);

+

     m_HTMLclientData.RemoveAt(n);
     m_HTMLclientData.RemoveAt(n);

-    UpdateCount();
-}

 
 

-void wxSimpleHtmlListBox::Append(const wxArrayString& strings)
-{
-    // append all given items at once
-    WX_APPEND_ARRAY(m_items, strings);
-    m_HTMLclientData.Add(NULL, strings.GetCount());

     UpdateCount();
 }
 
     UpdateCount();
 }
 

-int wxSimpleHtmlListBox::DoAppend(const wxString& item)
+int wxSimpleHtmlListBox::DoInsertItems(const wxArrayStringsAdapter& items,
+                                       unsigned int pos,
+                                       void **clientData,
+                                       wxClientDataType type)

 {
 {

-    m_items.Add(item);
-    m_HTMLclientData.Add(NULL);
-    UpdateCount();
-    return GetCount()-1;
-}
+    const unsigned int count = items.GetCount();
+
+    m_items.Insert(wxEmptyString, pos, count);
+    m_HTMLclientData.Insert(NULL, pos, count);
+
+    for ( unsigned int i = 0; i < count; ++i, ++pos )
+    {
+        m_items[pos] = items[i];
+        AssignNewItemClientData(pos, clientData, i, type);
+    }

 
 

-int wxSimpleHtmlListBox::DoInsert(const wxString& item, unsigned int pos)
-{
-    m_items.Insert(item, pos);
-    m_HTMLclientData.Insert(NULL, pos);

     UpdateCount();
     UpdateCount();

+

     return pos;
 }
 
     return pos;
 }
 


@@ -644,7 +638,7 @@ void wxSimpleHtmlListBox::SetString(unsigned int n, const wxString& s)
     wxCHECK_RET( IsValid(n),
                  wxT("invalid index in wxSimpleHtmlListBox::SetString") );
 
     wxCHECK_RET( IsValid(n),
                  wxT("invalid index in wxSimpleHtmlListBox::SetString") );
 

-    m_items[n]=s; 
+    m_items[n]=s;

     RefreshRow(n);
 }
 
     RefreshRow(n);
 }