just tidied up the comment

[wxWidgets.git] / include / wx / hash.h

diff --git a/include/wx/hash.h b/include/wx/hash.h
index 199a6193558fc82169bc327e520d6618de188033..cc03625dc4a41544de2e717914c4a40f760e93d0 100644 (file)
--- a/include/wx/hash.h
+++ b/include/wx/hash.h
@@ -151,7 +151,11 @@ public:
                  wxHashTableEqual( keyType ) ),
           m_keyType( keyType ) { }
 
                  wxHashTableEqual( keyType ) ),
           m_keyType( keyType ) { }
 

-    ~wxHashTableBase()
+    ~wxHashTableBase() { Clear(); }
+
+    size_t GetCount() const { return m_map.size(); }
+
+    void Clear()

     {
         if( m_keyType == wxKEY_STRING )
         {
     {
         if( m_keyType == wxKEY_STRING )
         {


@@ -164,26 +168,39 @@ public:
                 delete[] tmp; // used in operator++
             }
         }
                 delete[] tmp; // used in operator++
             }
         }

+        m_map.clear();

     }
     }

-
-    size_t GetCount() const { return m_map.size(); }

 protected:
     void DoPut( long key, void* data )
     {
 protected:
     void DoPut( long key, void* data )
     {

+        wxASSERT( m_keyType == wxKEY_INTEGER );
+

         wxHashKeyValue k; k.integer = key;
         m_map[k] = data;
     }
 
     void DoPut( const wxChar* key, void* data )
     {
         wxHashKeyValue k; k.integer = key;
         m_map[k] = data;
     }
 
     void DoPut( const wxChar* key, void* data )
     {

+        wxASSERT( m_keyType == wxKEY_STRING );
+

         wxHashKeyValue k;
         wxHashKeyValue k;

-        k.string = new wxChar[wxStrlen(key) + 1];
-        wxStrcpy(k.string, key);
-        m_map[k] = data;
+        k.string = (wxChar*)key;
+        wxHashTableBaseBase::iterator it = m_map.find(k);
+
+        if( it == m_map.end() )
+        {
+            k.string = new wxChar[wxStrlen(key) + 1];
+            wxStrcpy(k.string, key);
+            m_map[k] = data;
+        }
+        else
+            it->second = data;

     }
 
     void* DoGet( long key ) const
     {
     }
 
     void* DoGet( long key ) const
     {

+        wxASSERT( m_keyType == wxKEY_INTEGER );
+

         wxHashKeyValue k; k.integer = key;
         wxHashTableBaseBase::const_iterator it = m_map.find( k );
 
         wxHashKeyValue k; k.integer = key;
         wxHashTableBaseBase::const_iterator it = m_map.find( k );
 


@@ -192,6 +209,8 @@ protected:
 
     void* DoGet( const wxChar* key ) const
     {
 
     void* DoGet( const wxChar* key ) const
     {

+        wxASSERT( m_keyType == wxKEY_STRING );
+

         wxHashKeyValue k; k.string = (wxChar*)key;
         wxHashTableBaseBase::const_iterator it = m_map.find( k );
 
         wxHashKeyValue k; k.string = (wxChar*)key;
         wxHashTableBaseBase::const_iterator it = m_map.find( k );
 


@@ -200,6 +219,8 @@ protected:
 
     void* DoDelete( long key )
     {
 
     void* DoDelete( long key )
     {

+        wxASSERT( m_keyType == wxKEY_INTEGER );
+

         wxHashKeyValue k; k.integer = key;
         wxHashTableBaseBase::iterator it = m_map.find( k );
         
         wxHashKeyValue k; k.integer = key;
         wxHashTableBaseBase::iterator it = m_map.find( k );
         


@@ -216,6 +237,8 @@ protected:
 
     void* DoDelete( const wxChar* key )
     {
 
     void* DoDelete( const wxChar* key )
     {

+        wxASSERT( m_keyType == wxKEY_STRING );
+

         wxHashKeyValue k; k.string = (wxChar*)key;
         wxHashTableBaseBase::iterator it = m_map.find( k );
         
         wxHashKeyValue k; k.string = (wxChar*)key;
         wxHashTableBaseBase::iterator it = m_map.find( k );
         


@@ -342,7 +365,7 @@ public:
 
         dummy* operator->() { return (dummy*)this; }
     };
 
         dummy* operator->() { return (dummy*)this; }
     };

-    typedef class compatibility_iterator citer;
+    typedef compatibility_iterator citer;

 
     class dummy
     {
 
     class dummy
     {


@@ -360,12 +383,6 @@ public:
             it lit = i->m_iter;
             return citer( i->m_hash, ++lit );
         }
             it lit = i->m_iter;
             return citer( i->m_hash, ++lit );
         }

-        citer GetPrevious() const
-        {
-            citer* i = (citer*)this;
-            it lit = i->m_iter;
-            return citer( i->m_hash, ++lit );
-        }

         void SetData( wxObject* e )
         {
             citer* i = (citer*)this;
         void SetData( wxObject* e )
         {
             citer* i = (citer*)this;


@@ -410,7 +427,7 @@ public:
         return it;
     }
 
         return it;
     }
 

-    void Clear() { m_map.clear(); }
+    void Clear() { wxHashTableBase::Clear(); }

 private:
     compatibility_iterator m_iter;
 };
 private:
     compatibility_iterator m_iter;
 };


@@ -584,6 +601,8 @@ private:
             ((listclass *)m_hashTable[slot])->Append(value, data);             \
             m_count++;                                                         \
         }                                                                      \
             ((listclass *)m_hashTable[slot])->Append(value, data);             \
             m_count++;                                                         \
         }                                                                      \

+                                                                               \
+        DECLARE_NO_COPY_CLASS(hashclass)                                       \

     }
 
 #endif
     }
 
 #endif