added wxCURSOR_RIGHT_ARROW to wxMGL

[wxWidgets.git] / src / msw / textctrl.cpp

diff --git a/src/msw/textctrl.cpp b/src/msw/textctrl.cpp
index 0de8b105d56145bad059dcec0a3239e9679bf602..e9bbcc1ad55477c6292036242fb3d027aa7c6ae7 100644 (file)
--- a/src/msw/textctrl.cpp
+++ b/src/msw/textctrl.cpp
@@ -91,37 +91,49 @@
     } ENLINK;
 #endif // ENLINK
 
     } ENLINK;
 #endif // ENLINK
 

+#ifndef SF_UNICODE
+    #define SF_UNICODE 0x0010
+#endif
+
+// Watcom C++ doesn't define this
+#ifndef SCF_ALL
+#define SCF_ALL 0x0004
+#endif
+
+// ----------------------------------------------------------------------------
+// private functions
+// ----------------------------------------------------------------------------
+
+#if wxUSE_RICHEDIT
+
+DWORD CALLBACK wxRichEditStreamIn(DWORD dwCookie, BYTE *buf, LONG cb, LONG *pcb);
+
+#endif // wxUSE_RICHEDIT
+

 // ----------------------------------------------------------------------------
 // private classes
 // ----------------------------------------------------------------------------
 
 #if wxUSE_RICHEDIT
 
 // ----------------------------------------------------------------------------
 // private classes
 // ----------------------------------------------------------------------------
 
 #if wxUSE_RICHEDIT
 

-// this module initializes RichEdit DLL if needed
+// this module initializes RichEdit DLL(s) if needed

 class wxRichEditModule : public wxModule
 {
 public:
     virtual bool OnInit();
     virtual void OnExit();
 
 class wxRichEditModule : public wxModule
 {
 public:
     virtual bool OnInit();
     virtual void OnExit();
 

-    // get the version currently loaded, -1 if none
-    static int GetLoadedVersion() { return ms_verRichEdit; }
-

     // load the richedit DLL of at least of required version
     static bool Load(int version = 1);
 
 private:
     // load the richedit DLL of at least of required version
     static bool Load(int version = 1);
 
 private:

-    // the handle to richedit DLL and the version of the DLL loaded
-    static HINSTANCE ms_hRichEdit;
-
-    // the DLL version loaded or -1 if none
-    static int ms_verRichEdit;
+    // the handles to richedit 1.0 and 2.0 (or 3.0) DLLs
+    static HINSTANCE ms_hRichEdit[2];

 
     DECLARE_DYNAMIC_CLASS(wxRichEditModule)
 };
 
 
     DECLARE_DYNAMIC_CLASS(wxRichEditModule)
 };
 

-HINSTANCE wxRichEditModule::ms_hRichEdit = (HINSTANCE)NULL;
-int       wxRichEditModule::ms_verRichEdit = -1;
+HINSTANCE wxRichEditModule::ms_hRichEdit[2] = { NULL, NULL };

 
 IMPLEMENT_DYNAMIC_CLASS(wxRichEditModule, wxModule)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxRichEditModule, wxModule)
 


@@ -161,10 +173,10 @@ END_EVENT_TABLE()
 // creation
 // ----------------------------------------------------------------------------
 
 // creation
 // ----------------------------------------------------------------------------
 

-wxTextCtrl::wxTextCtrl()
+void wxTextCtrl::Init()

 {
 #if wxUSE_RICHEDIT
 {
 #if wxUSE_RICHEDIT

-    m_isRich = FALSE;
+    m_verRichEdit = 0;

 #endif
 }
 
 #endif
 }
 


@@ -183,91 +195,71 @@ bool wxTextCtrl::Create(wxWindow *parent, wxWindowID id,
     if ( parent )
         parent->AddChild(this);
 
     if ( parent )
         parent->AddChild(this);
 

-    // translate wxWin style flags to MSW ones, checking for consistency while
-    // doing it
-    long msStyle = ES_LEFT | WS_VISIBLE | WS_CHILD | WS_TABSTOP;
+    // translate wxWin style flags to MSW ones
+    WXDWORD msStyle = MSWGetCreateWindowFlags();

 
 

-    if ( m_windowStyle & wxCLIP_SIBLINGS )
-        msStyle |= WS_CLIPSIBLINGS;
+    // do create the control - either an EDIT or RICHEDIT
+    wxString windowClass = wxT("EDIT");

 
 

-    if ( m_windowStyle & wxTE_MULTILINE )
+#if wxUSE_RICHEDIT
+    if ( m_windowStyle & wxTE_AUTO_URL )

     {
     {

-        wxASSERT_MSG( !(m_windowStyle & wxTE_PROCESS_ENTER),
-                      wxT("wxTE_PROCESS_ENTER style is ignored for multiline text controls (they always process it)") );
-
-        msStyle |= ES_MULTILINE | ES_WANTRETURN;
-        if ((m_windowStyle & wxTE_NO_VSCROLL) == 0)
-            msStyle |= WS_VSCROLL;
-        m_windowStyle |= wxTE_PROCESS_ENTER;
+        // automatic URL detection only works in RichEdit 2.0+
+        m_windowStyle |= wxTE_RICH2;

     }
     }

-    else
-        msStyle |= ES_AUTOHSCROLL;
-
-    if (m_windowStyle & wxHSCROLL)
-        msStyle |= (WS_HSCROLL | ES_AUTOHSCROLL);
-
-    if (m_windowStyle & wxTE_READONLY)
-        msStyle |= ES_READONLY;

 
 

-    if (m_windowStyle & wxTE_PASSWORD) // hidden input
-        msStyle |= ES_PASSWORD;
-
-   if (m_windowStyle & wxTE_AUTO_SCROLL)
-        msStyle |=  ES_AUTOHSCROLL;
-
-
-    // we always want the characters and the arrows
-    m_lDlgCode = DLGC_WANTCHARS | DLGC_WANTARROWS;
-
-    // we may have several different cases:
-    // 1. normal case: both TAB and ENTER are used for dialog navigation
-    // 2. ctrl which wants TAB for itself: ENTER is used to pass to the next
-    //    control in the dialog
-    // 3. ctrl which wants ENTER for itself: TAB is used for dialog navigation
-    // 4. ctrl which wants both TAB and ENTER: Ctrl-ENTER is used to pass to
-    //    the next control
-    if ( m_windowStyle & wxTE_PROCESS_ENTER )
-        m_lDlgCode |= DLGC_WANTMESSAGE;
-    if ( m_windowStyle & wxTE_PROCESS_TAB )
-        m_lDlgCode |= DLGC_WANTTAB;
-
-    // do create the control - either an EDIT or RICHEDIT
-    wxString windowClass = wxT("EDIT");
+    if ( m_windowStyle & wxTE_RICH2 )
+    {
+        // using richedit 2.0 implies using wxTE_RICH
+        m_windowStyle |= wxTE_RICH;
+    }

 
 

-#if wxUSE_RICHEDIT
+    // we need to load the richedit DLL before creating the rich edit control

     if ( m_windowStyle & wxTE_RICH )
     {
     if ( m_windowStyle & wxTE_RICH )
     {

-        static bool s_errorGiven = FALSE;   // MT-FIXME
+        static bool s_errorGiven = FALSE;// MT-FIXME
+
+        // Which version do we need? Use 1.0 by default because it is much more
+        // like the the standard EDIT or 2.0 if explicitly requested, but use
+        // only 2.0 in Unicode mode as 1.0 doesn't support Unicode at all
+        //
+        // TODO: RichEdit 3.0 is apparently capable of emulating RichEdit 1.0
+        //       (and thus EDIT) much better than RichEdit 2.0 so we probably
+        //       should use 3.0 if available as it is the best of both worlds -
+        //       but as I can't test it right now I don't do it (VZ)
+#if wxUSE_UNICODE
+        const int verRichEdit = 2;
+#else // !wxUSE_UNICODE
+        int verRichEdit = m_windowStyle & wxTE_RICH2 ? 2 : 1;
+#endif // wxUSE_UNICODE/!wxUSE_UNICODE

 
         // only give the error msg once if the DLL can't be loaded
         if ( !s_errorGiven )
         {
 
         // only give the error msg once if the DLL can't be loaded
         if ( !s_errorGiven )
         {

-            // first try to load the RichEdit DLL (will do nothing if already
-            // done)
-            if ( !wxRichEditModule::Load() )
+            // try to load the RichEdit DLL (will do nothing if already done)
+            if ( !wxRichEditModule::Load(verRichEdit) )

             {
             {

-                wxLogError(_("Impossible to create a rich edit control, using simple text control instead. Please reinstall riched32.dll"));
+#if !wxUSE_UNICODE
+                // try another version?
+                verRichEdit = 3 - verRichEdit; // 1 <-> 2
+
+                if ( !wxRichEditModule::Load(verRichEdit) )
+#endif // wxUSE_UNICODE
+                {
+                    wxLogError(_("Impossible to create a rich edit control, using simple text control instead. Please reinstall riched32.dll"));

 
 

-                s_errorGiven = TRUE;
+                    s_errorGiven = TRUE;
+                }

             }
         }
 
             }
         }
 

-        if ( s_errorGiven )
-        {
-            m_isRich = FALSE;
-        }
-        else
+        // have we managed to load any richedit version?
+        if ( !s_errorGiven )

         {
             msStyle |= ES_AUTOVSCROLL;
         {
             msStyle |= ES_AUTOVSCROLL;

-            // Experimental: this seems to help with the scroll problem. See messages from Jekabs Andrushaitis <j.andrusaitis@konts.lv>
-            // wx-dev list, entitled "[wx-dev] wxMSW-EVT_KEY_DOWN and wxMSW-wxTextCtrl" and "[wx-dev] TextCtrl (RichEdit)"
-            // Unfortunately, showing the selection in blue when the control doesn't have
-            // the focus is non-standard behaviour, and we need to find another workaround.
-            //msStyle |= ES_NOHIDESEL ;
-            m_isRich = TRUE;
-
-            int ver = wxRichEditModule::GetLoadedVersion();
-            if ( ver == 1 )
+
+            m_verRichEdit = verRichEdit;
+            if ( m_verRichEdit == 1 )

             {
                 windowClass = wxT("RICHEDIT");
             }
             {
                 windowClass = wxT("RICHEDIT");
             }


@@ -275,7 +267,7 @@ bool wxTextCtrl::Create(wxWindow *parent, wxWindowID id,
             {
 #ifndef RICHEDIT_CLASS
                 wxString RICHEDIT_CLASS;
             {
 #ifndef RICHEDIT_CLASS
                 wxString RICHEDIT_CLASS;

-                RICHEDIT_CLASS.Printf(_T("RichEdit%d0"), ver);
+                RICHEDIT_CLASS.Printf(_T("RichEdit%d0"), m_verRichEdit);

 #if wxUSE_UNICODE
                 RICHEDIT_CLASS += _T('W');
 #else // ANSI
 #if wxUSE_UNICODE
                 RICHEDIT_CLASS += _T('W');
 #else // ANSI


@@ -287,43 +279,26 @@ bool wxTextCtrl::Create(wxWindow *parent, wxWindowID id,
             }
         }
     }
             }
         }
     }

-    else
-        m_isRich = FALSE;

 #endif // wxUSE_RICHEDIT
 
 #endif // wxUSE_RICHEDIT
 

-    bool want3D;
-    WXDWORD exStyle = Determine3DEffects(WS_EX_CLIENTEDGE, &want3D);
-
-    // Even with extended styles, need to combine with WS_BORDER for them to
-    // look right.
-    if ( want3D || wxStyleHasBorder(m_windowStyle) )
-        msStyle |= WS_BORDER;
-
-    // NB: don't use pos and size as CreateWindowEx arguments because they
-    //     might be -1 in which case we should use the default values (and
-    //     SetSize called below takes care of it)
-    m_hWnd = (WXHWND)::CreateWindowEx(exStyle,
-                                      windowClass.c_str(),
-                                      NULL,
-                                      msStyle,
-                                      0, 0, 0, 0,
-                                      GetHwndOf(parent),
-                                      (HMENU)m_windowId,
-                                      wxGetInstance(),
-                                      NULL);
-
-    wxCHECK_MSG( m_hWnd, FALSE, wxT("Failed to create text ctrl") );
-
-#if wxUSE_CTL3D
-    if ( want3D )
+    // we need to turn '\n's into "\r\n"s for the multiline controls
+    wxString valueWin;
+    if ( m_windowStyle & wxTE_MULTILINE )

     {
     {

-        Ctl3dSubclassCtl(GetHwnd());
-        m_useCtl3D = TRUE;
+        valueWin = wxTextFile::Translate(value, wxTextFileType_Dos);

     }
     }

-#endif
+    else // single line
+    {
+        valueWin = value;
+    }
+
+    if ( !MSWCreateControl(windowClass, msStyle, pos, size, valueWin) )
+        return FALSE;
+
+    SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));

 
 #if wxUSE_RICHEDIT
 
 #if wxUSE_RICHEDIT

-    if (m_isRich)
+    if ( IsRich() )

     {
         // have to enable events manually
         LPARAM mask = ENM_CHANGE | ENM_DROPFILES | ENM_SELCHANGE | ENM_UPDATE;
     {
         // have to enable events manually
         LPARAM mask = ENM_CHANGE | ENM_DROPFILES | ENM_SELCHANGE | ENM_UPDATE;


@@ -339,75 +314,113 @@ bool wxTextCtrl::Create(wxWindow *parent, wxWindowID id,
     }
 #endif // wxUSE_RICHEDIT
 
     }
 #endif // wxUSE_RICHEDIT
 

-    SubclassWin(GetHWND());
+    return TRUE;
+}
+
+// Make sure the window style (etc.) reflects the HWND style (roughly)
+void wxTextCtrl::AdoptAttributesFromHWND()
+{
+    wxWindow::AdoptAttributesFromHWND();
+
+    HWND hWnd = GetHwnd();
+    long style = ::GetWindowLong(hWnd, GWL_STYLE);
+
+    // retrieve the style to see whether this is an edit or richedit ctrl
+#if wxUSE_RICHEDIT
+    wxString classname = wxGetWindowClass(GetHWND());

 
 

-    // set font, position, size and initial value
-    wxFont& fontParent = parent->GetFont();
-    if ( fontParent.Ok() )
+    if ( classname.IsSameAs(_T("EDIT"), FALSE /* no case */) )

     {
     {

-        SetFont(fontParent);
+        m_verRichEdit = 0;

     }
     }

-    else
+    else // rich edit?

     {
     {

-        SetFont(wxSystemSettings::GetSystemFont(wxSYS_SYSTEM_FONT));
+        wxChar c;
+        if ( wxSscanf(classname, _T("RichEdit%d0%c"), &m_verRichEdit, &c) != 2 )
+        {
+            wxLogDebug(_T("Unknown edit control '%s'."), classname.c_str());
+
+            m_verRichEdit = 0;
+        }

     }
     }

+#endif // wxUSE_RICHEDIT

 
 

-    // Causes a crash for Symantec C++ and WIN32 for some reason
-#if !(defined(__SC__) && defined(__WIN32__))
-    if ( !value.IsEmpty() )
+    if (style & ES_MULTILINE)
+        m_windowStyle |= wxTE_MULTILINE;
+    if (style & ES_PASSWORD)
+        m_windowStyle |= wxTE_PASSWORD;
+    if (style & ES_READONLY)
+        m_windowStyle |= wxTE_READONLY;
+    if (style & ES_WANTRETURN)
+        m_windowStyle |= wxTE_PROCESS_ENTER;
+}
+
+WXDWORD wxTextCtrl::MSWGetStyle(long style, WXDWORD *exstyle) const
+{
+    // default border for the text controls is the sunken one
+    if ( (style & wxBORDER_MASK) == wxBORDER_DEFAULT )

     {
     {

-        SetValue(value);
+        style |= wxBORDER_SUNKEN;

     }
     }

-#endif

 
 

-    // set colours
-    SetupColours();
+    long msStyle = wxControl::MSWGetStyle(style, exstyle);

 
 

-    SetSize(pos.x, pos.y, size.x, size.y);
+    // default styles
+    msStyle |= ES_LEFT;

 
 

-    return TRUE;
-}
+    if ( style & wxTE_MULTILINE )
+    {
+        wxASSERT_MSG( !(style & wxTE_PROCESS_ENTER),
+                      wxT("wxTE_PROCESS_ENTER style is ignored for multiline text controls (they always process it)") );

 
 

-// Make sure the window style (etc.) reflects the HWND style (roughly)
-void wxTextCtrl::AdoptAttributesFromHWND()
-{
-  wxWindow::AdoptAttributesFromHWND();
+        msStyle |= ES_MULTILINE | ES_WANTRETURN;
+        if ( !(style & wxTE_NO_VSCROLL) )
+            msStyle |= WS_VSCROLL;

 
 

-  HWND hWnd = GetHwnd();
-  long style = GetWindowLong(hWnd, GWL_STYLE);
+        style |= wxTE_PROCESS_ENTER;
+    }
+    else // !multiline
+    {
+        // there is really no reason to not have this style for single line
+        // text controls
+        msStyle |= ES_AUTOHSCROLL;
+    }

 
 

-  // retrieve the style to see whether this is an edit or richedit ctrl
-#if wxUSE_RICHEDIT
-  wxChar buf[256];
+    if ( style & wxHSCROLL )
+        msStyle |= WS_HSCROLL | ES_AUTOHSCROLL;

 
 

-  GetClassName(hWnd, buf, WXSIZEOF(buf));
+    if ( style & wxTE_READONLY )
+        msStyle |= ES_READONLY;

 
 

-  if ( wxStricmp(buf, wxT("EDIT")) == 0 )
-    m_isRich = FALSE;
-  else
-    m_isRich = TRUE;
-#endif // wxUSE_RICHEDIT
+    if ( style & wxTE_PASSWORD )
+        msStyle |= ES_PASSWORD;
+
+    if ( style & wxTE_AUTO_SCROLL )
+        msStyle |= ES_AUTOHSCROLL;

 
 

-  if (style & ES_MULTILINE)
-    m_windowStyle |= wxTE_MULTILINE;
-  if (style & ES_PASSWORD)
-    m_windowStyle |= wxTE_PASSWORD;
-  if (style & ES_READONLY)
-    m_windowStyle |= wxTE_READONLY;
-  if (style & ES_WANTRETURN)
-    m_windowStyle |= wxTE_PROCESS_ENTER;
+    if ( style & wxTE_NOHIDESEL )
+        msStyle |= ES_NOHIDESEL;
+
+    return msStyle;

 }
 
 }
 

-void wxTextCtrl::SetupColours()
+void wxTextCtrl::SetWindowStyleFlag(long style)

 {
 {

-    wxColour bkgndColour;
-//    if (IsEditable() || (m_windowStyle & wxTE_MULTILINE))
-        bkgndColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOW);
-//    else
-//        bkgndColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+#if wxUSE_RICHEDIT
+    // we have to deal with some styles separately because they can't be
+    // changed by simply calling SetWindowLong(GWL_STYLE) but can be changed
+    // using richedit-specific EM_SETOPTIONS
+    if ( IsRich() &&
+            ((style & wxTE_NOHIDESEL) != (GetWindowStyle() & wxTE_NOHIDESEL)) )
+    {
+        bool set = (style & wxTE_NOHIDESEL) != 0;
+
+        ::SendMessage(GetHwnd(), EM_SETOPTIONS, set ? ECOOP_OR : ECOOP_AND,
+                      set ? ECO_NOHIDESEL : ~ECO_NOHIDESEL);
+    }
+#endif // wxUSE_RICHEDIT

 
 

-    SetBackgroundColour(bkgndColour);
-    SetForegroundColour(GetParent()->GetForegroundColour());
+    wxControl::SetWindowStyleFlag(style);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -416,49 +429,77 @@ void wxTextCtrl::SetupColours()
 
 wxString wxTextCtrl::GetValue() const
 {
 
 wxString wxTextCtrl::GetValue() const
 {

-    // we can't use wxGetWindowText() (i.e. WM_GETTEXT internally) for
-    // retrieving more than 64Kb under Win9x
-#if wxUSE_RICHEDIT
-    if ( m_isRich )
+    // range 0..-1 is special for GetRange() and means to retrieve all text
+    return GetRange(0, -1);
+}
+
+wxString wxTextCtrl::GetRange(long from, long to) const
+{
+    wxString str;
+
+    if ( from >= to && to != -1 )

     {
     {

-        wxString str;
+        // nothing to retrieve
+        return str;
+    }

 
 

+#if wxUSE_RICHEDIT
+    if ( IsRich() )
+    {

         int len = GetWindowTextLength(GetHwnd());
         int len = GetWindowTextLength(GetHwnd());

-        if ( len )
+        if ( len > from )

         {
             // alloc one extra WORD as needed by the control
             wxChar *p = str.GetWriteBuf(++len);
 
             TEXTRANGE textRange;
         {
             // alloc one extra WORD as needed by the control
             wxChar *p = str.GetWriteBuf(++len);
 
             TEXTRANGE textRange;

-            textRange.chrg.cpMin = 0;
-            textRange.chrg.cpMax = -1;
+            textRange.chrg.cpMin = from;
+            textRange.chrg.cpMax = to == -1 ? len : to;

             textRange.lpstrText = p;
 
             (void)SendMessage(GetHwnd(), EM_GETTEXTRANGE, 0, (LPARAM)&textRange);
 
             textRange.lpstrText = p;
 
             (void)SendMessage(GetHwnd(), EM_GETTEXTRANGE, 0, (LPARAM)&textRange);
 

-            // believe it or not, but EM_GETTEXTRANGE uses just CR ('\r') for
-            // the newlines which is neither Unix nor Windows style (Win95 with
-            // riched20.dll shows this behaviour) - convert it to something
-            // reasonable
-            for ( ; *p; p++ )
+            if ( m_verRichEdit > 1 )

             {
             {

-                if ( *p == _T('\r') )
-                    *p = _T('\n');
+                // RichEdit 2.0 uses just CR ('\r') for the newlines which is
+                // neither Unix nor Windows style - convert it to something
+                // reasonable
+                for ( ; *p; p++ )
+                {
+                    if ( *p == _T('\r') )
+                        *p = _T('\n');
+                }

             }
 
             str.UngetWriteBuf();
             }
 
             str.UngetWriteBuf();

+
+            if ( m_verRichEdit == 1 )
+            {
+                // convert to the canonical form - see comment below
+                str = wxTextFile::Translate(str, wxTextFileType_Unix);
+            }

         }
         //else: no text at all, leave the string empty
         }
         //else: no text at all, leave the string empty

-
-        return str;

     }
     }

+    else

 #endif // wxUSE_RICHEDIT
 #endif // wxUSE_RICHEDIT

+    {
+        // retrieve all text
+        str = wxGetWindowText(GetHWND());

 
 

-    // WM_GETTEXT uses standard DOS CR+LF (\r\n) convention - convert to the
-    // same one as above for consitency
-    wxString str = wxGetWindowText(GetHWND());
+        // need only a range?
+        if ( from < to )
+        {
+            str = str.Mid(from, to - from);
+        }

 
 

-    return wxTextFile::Translate(str, wxTextFileType_Unix);
+        // WM_GETTEXT uses standard DOS CR+LF (\r\n) convention - convert to the
+        // canonical one (same one as above) for consistency with the other kinds
+        // of controls and, more importantly, with the other ports
+        str = wxTextFile::Translate(str, wxTextFileType_Unix);
+    }
+
+    return str;

 }
 
 void wxTextCtrl::SetValue(const wxString& value)
 }
 
 void wxTextCtrl::SetValue(const wxString& value)


@@ -469,38 +510,172 @@ void wxTextCtrl::SetValue(const wxString& value)
     // edit controls mostly)
     if ( (value.length() > 0x400) || (value != GetValue()) )
     {
     // edit controls mostly)
     if ( (value.length() > 0x400) || (value != GetValue()) )
     {

-        wxString valueDos = wxTextFile::Translate(value, wxTextFileType_Dos);
+        DoWriteText(value, FALSE /* not selection only */);

 
 

-        SetWindowText(GetHwnd(), valueDos.c_str());
+        // mark the control as being not dirty - we changed its text, not the
+        // user
+        DiscardEdits();

 
 

-        // for compatibility with the GTK and because it is more logical, we
-        // move the cursor to the end of the text after SetValue()
+        // for compatibility, don't move the cursor when doing SetValue()
+        SetInsertionPoint(0);
+    }
+}

 
 

-        // GRG, Jun/2000: Changed this back after a lot of discussion
-        //   in the lists. wxWindows 2.2 will have a set of flags to
-        //   customize this behaviour.
-        //SetInsertionPointEnd();
+#if wxUSE_RICHEDIT && (!wxUSE_UNICODE || wxUSE_UNICODE_MSLU)

 
 

-        AdjustSpaceLimit();
+DWORD CALLBACK wxRichEditStreamIn(DWORD dwCookie, BYTE *buf, LONG cb, LONG *pcb)
+{
+    *pcb = 0;
+
+    wchar_t *wbuf = (wchar_t *)buf;
+    const wchar_t *wpc = *(const wchar_t **)dwCookie;
+    while ( cb && *wpc )
+    {
+        *wbuf++ = *wpc++;
+
+        cb -= sizeof(wchar_t);
+        (*pcb) += sizeof(wchar_t);
+    }
+
+    *(const wchar_t **)dwCookie = wpc;
+
+    return 0;
+}
+
+extern long wxEncodingToCodepage(wxFontEncoding encoding); // from utils.cpp
+
+#if wxUSE_UNICODE_MSLU
+bool wxTextCtrl::StreamIn(const wxString& value,
+                          wxFontEncoding WXUNUSED(encoding),
+                          bool selectionOnly)
+{
+    const wchar_t *wpc = value.c_str();
+#else // !wxUSE_UNICODE_MSLU
+bool wxTextCtrl::StreamIn(const wxString& value,
+                          wxFontEncoding encoding,
+                          bool selectionOnly)
+{
+    // we have to use EM_STREAMIN to force richedit control 2.0+ to show any
+    // text in the non default charset - otherwise it thinks it knows better
+    // than we do and always shows it in the default one
+
+    // first get the Windows code page for this encoding
+    long codepage = wxEncodingToCodepage(encoding);
+    if ( codepage == -1 )
+    {
+        // unknown encoding
+        return FALSE;
+    }
+
+    // next translate to Unicode using this code page
+    int len = ::MultiByteToWideChar(codepage, 0, value, -1, NULL, 0);
+
+#if wxUSE_WCHAR_T
+    wxWCharBuffer wchBuf(len);
+#else
+    wchar_t *wchBuf = (wchar_t *)malloc((len + 1)*sizeof(wchar_t));
+#endif
+
+    if ( !::MultiByteToWideChar(codepage, 0, value, -1,
+                                (wchar_t *)(const wchar_t *)wchBuf, len) )
+    {
+        wxLogLastError(_T("MultiByteToWideChar"));

     }
     }

+
+    // finally, stream it in the control
+    const wchar_t *wpc = wchBuf;
+#endif // wxUSE_UNICODE_MSLU
+
+    EDITSTREAM eds;
+    wxZeroMemory(eds);
+    eds.dwCookie = (DWORD)&wpc;
+    // the cast below is needed for broken (very) old mingw32 headers
+    eds.pfnCallback = (EDITSTREAMCALLBACK)wxRichEditStreamIn;
+
+    if ( !::SendMessage(GetHwnd(), EM_STREAMIN,
+                        SF_TEXT |
+                        SF_UNICODE |
+                        (selectionOnly ? SFF_SELECTION : 0),
+                        (LPARAM)&eds) || eds.dwError )
+    {
+        wxLogLastError(_T("EM_STREAMIN"));
+    }
+
+#if !wxUSE_WCHAR_T
+    free(wchBuf);
+#endif // !wxUSE_WCHAR_T
+
+    return TRUE;

 }
 
 }
 

+#endif // wxUSE_RICHEDIT
+

 void wxTextCtrl::WriteText(const wxString& value)
 {
 void wxTextCtrl::WriteText(const wxString& value)
 {

-    wxString valueDos = wxTextFile::Translate(value, wxTextFileType_Dos);
+    DoWriteText(value);
+}
+
+void wxTextCtrl::DoWriteText(const wxString& value, bool selectionOnly)
+{
+    wxString valueDos;
+    if ( m_windowStyle & wxTE_MULTILINE )
+        valueDos = wxTextFile::Translate(value, wxTextFileType_Dos);
+    else
+        valueDos = value;

 
 #if wxUSE_RICHEDIT
 
 #if wxUSE_RICHEDIT

-    // ensure that the new text will be in the default style
-    if ( IsRich() &&
-            (m_defaultStyle.HasFont() || m_defaultStyle.HasTextColour()) )
+    // there are several complications with the rich edit controls here
+    bool done = FALSE;
+    if ( IsRich() )

     {
     {

-        long start, end;
-        GetSelection(&start, &end);
-        SetStyle(start, end, m_defaultStyle );
+        // first, ensure that the new text will be in the default style
+        if ( !m_defaultStyle.IsDefault() )
+        {
+            long start, end;
+            GetSelection(&start, &end);
+            SetStyle(start, end, m_defaultStyle);
+        }
+
+#if wxUSE_UNICODE_MSLU
+        // RichEdit doesn't have Unicode version of EM_REPLACESEL on Win9x,
+        // but EM_STREAMIN works
+        if ( wxUsingUnicowsDll() && GetRichVersion() > 1 )
+        {
+           done = StreamIn(valueDos, wxFONTENCODING_SYSTEM, selectionOnly);
+        }
+#endif // wxUSE_UNICODE_MSLU
+
+#if !wxUSE_UNICODE
+        // next check if the text we're inserting must be shown in a non
+        // default charset -- this only works for RichEdit > 1.0
+        if ( GetRichVersion() > 1 )
+        {
+            wxFont font = m_defaultStyle.GetFont();
+            if ( !font.Ok() )
+                font = GetFont();
+
+            if ( font.Ok() )
+            {
+               wxFontEncoding encoding = font.GetEncoding();
+               if ( encoding != wxFONTENCODING_SYSTEM )
+               {
+                   done = StreamIn(valueDos, encoding, selectionOnly);
+               }
+            }
+        }
+#endif // !wxUSE_UNICODE

     }
     }

+
+    if ( !done )

 #endif // wxUSE_RICHEDIT
 #endif // wxUSE_RICHEDIT

+    {
+        if ( !selectionOnly )
+        {
+            SetSelection(-1, -1);
+        }

 
 

-    SendMessage(GetHwnd(), EM_REPLACESEL, 0, (LPARAM)valueDos.c_str());
+        ::SendMessage(GetHwnd(), EM_REPLACESEL, 0, (LPARAM)valueDos.c_str());
+    }

 
     AdjustSpaceLimit();
 }
 
     AdjustSpaceLimit();
 }


@@ -508,12 +683,13 @@ void wxTextCtrl::WriteText(const wxString& value)
 void wxTextCtrl::AppendText(const wxString& text)
 {
     SetInsertionPointEnd();
 void wxTextCtrl::AppendText(const wxString& text)
 {
     SetInsertionPointEnd();

+

     WriteText(text);
 }
 
 void wxTextCtrl::Clear()
 {
     WriteText(text);
 }
 
 void wxTextCtrl::Clear()
 {

-    SetWindowText(GetHwnd(), wxT(""));
+    ::SetWindowText(GetHwnd(), wxT(""));

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -524,8 +700,7 @@ void wxTextCtrl::Copy()
 {
     if (CanCopy())
     {
 {
     if (CanCopy())
     {

-        HWND hWnd = GetHwnd();
-        SendMessage(hWnd, WM_COPY, 0, 0L);
+        ::SendMessage(GetHwnd(), WM_COPY, 0, 0L);

     }
 }
 
     }
 }
 


@@ -533,8 +708,7 @@ void wxTextCtrl::Cut()
 {
     if (CanCut())
     {
 {
     if (CanCut())
     {

-        HWND hWnd = GetHwnd();
-        SendMessage(hWnd, WM_CUT, 0, 0L);
+        ::SendMessage(GetHwnd(), WM_CUT, 0, 0L);

     }
 }
 
     }
 }
 


@@ -542,8 +716,7 @@ void wxTextCtrl::Paste()
 {
     if (CanPaste())
     {
 {
     if (CanPaste())
     {

-        HWND hWnd = GetHwnd();
-        SendMessage(hWnd, WM_PASTE, 0, 0L);
+        ::SendMessage(GetHwnd(), WM_PASTE, 0, 0L);

     }
 }
 
     }
 }
 


@@ -551,37 +724,35 @@ bool wxTextCtrl::CanCopy() const
 {
     // Can copy if there's a selection
     long from, to;
 {
     // Can copy if there's a selection
     long from, to;

-    GetSelection(& from, & to);
-    return (from != to) ;
+    GetSelection(&from, &to);
+    return from != to;

 }
 
 bool wxTextCtrl::CanCut() const
 {
 }
 
 bool wxTextCtrl::CanCut() const
 {

-    // Can cut if there's a selection
-    long from, to;
-    GetSelection(& from, & to);
-    return (from != to) && (IsEditable());
+    return CanCopy() && IsEditable();

 }
 
 bool wxTextCtrl::CanPaste() const
 {
 }
 
 bool wxTextCtrl::CanPaste() const
 {

+    if ( !IsEditable() )
+        return FALSE;
+

 #if wxUSE_RICHEDIT
 #if wxUSE_RICHEDIT

-    if (m_isRich)
+    if ( IsRich() )

     {
     {

-        int dataFormat = 0; // 0 == any format
-        return (::SendMessage( GetHwnd(), EM_CANPASTE, (WPARAM) (UINT) dataFormat, 0) != 0);
+        UINT cf = 0; // 0 == any format
+
+        return ::SendMessage(GetHwnd(), EM_CANPASTE, cf, 0) != 0;

     }
     }

-#endif
-    if (!IsEditable())
-        return FALSE;
+#endif // wxUSE_RICHEDIT

 
     // Standard edit control: check for straight text on clipboard
 
     // Standard edit control: check for straight text on clipboard

-    bool isTextAvailable = FALSE;
-    if ( ::OpenClipboard(GetHwndOf(wxTheApp->GetTopWindow())) )
-    {
-        isTextAvailable = (::IsClipboardFormatAvailable(CF_TEXT) != 0);
-        ::CloseClipboard();
-    }
+    if ( !::OpenClipboard(GetHwndOf(wxTheApp->GetTopWindow())) )
+        return FALSE;
+
+    bool isTextAvailable = ::IsClipboardFormatAvailable(CF_TEXT) != 0;
+    ::CloseClipboard();

 
     return isTextAvailable;
 }
 
     return isTextAvailable;
 }


@@ -598,46 +769,32 @@ void wxTextCtrl::SetEditable(bool editable)
 
 void wxTextCtrl::SetInsertionPoint(long pos)
 {
 
 void wxTextCtrl::SetInsertionPoint(long pos)
 {

-    HWND hWnd = GetHwnd();
-#ifdef __WIN32__
+    DoSetSelection(pos, pos);
+}
+
+void wxTextCtrl::SetInsertionPointEnd()
+{
+    long pos;
+

 #if wxUSE_RICHEDIT
 #if wxUSE_RICHEDIT

-    if ( m_isRich)
+    if ( m_verRichEdit == 1 )

     {
     {

-        CHARRANGE range;
-        range.cpMin = pos;
-        range.cpMax = pos;
-        SendMessage(hWnd, EM_EXSETSEL, 0, (LPARAM) &range);
-        SendMessage(hWnd, EM_SCROLLCARET, (WPARAM)0, (LPARAM)0);
+        // we don't have to waste time calling GetLastPosition() in this case
+        pos = -1;

     }
     }

-    else
+    else // !RichEdit 1.0

 #endif // wxUSE_RICHEDIT
     {
 #endif // wxUSE_RICHEDIT
     {

-        SendMessage(hWnd, EM_SETSEL, pos, pos);
-        SendMessage(hWnd, EM_SCROLLCARET, (WPARAM)0, (LPARAM)0);
+        pos = GetLastPosition();

     }
     }

-#else // Win16
-    SendMessage(hWnd, EM_SETSEL, 0, MAKELPARAM(pos, pos));
-#endif // Win32/16
-
-#if wxUSE_RICHEDIT
-    if ( !m_isRich)
-#endif
-    {
-        static const wxChar *nothing = _T("");
-        SendMessage(hWnd, EM_REPLACESEL, 0, (LPARAM)nothing);
-    }
-}

 
 

-void wxTextCtrl::SetInsertionPointEnd()
-{
-    long pos = GetLastPosition();

     SetInsertionPoint(pos);
 }
 
 long wxTextCtrl::GetInsertionPoint() const
 {
 #if wxUSE_RICHEDIT
     SetInsertionPoint(pos);
 }
 
 long wxTextCtrl::GetInsertionPoint() const
 {
 #if wxUSE_RICHEDIT

-    if (m_isRich)
+    if ( IsRich() )

     {
         CHARRANGE range;
         range.cpMin = 0;
     {
         CHARRANGE range;
         range.cpMin = 0;


@@ -645,7 +802,7 @@ long wxTextCtrl::GetInsertionPoint() const
         SendMessage(GetHwnd(), EM_EXGETSEL, 0, (LPARAM) &range);
         return range.cpMin;
     }
         SendMessage(GetHwnd(), EM_EXGETSEL, 0, (LPARAM) &range);
         return range.cpMin;
     }

-#endif
+#endif // wxUSE_RICHEDIT

 
     DWORD Pos = (DWORD)SendMessage(GetHwnd(), EM_GETSEL, 0, 0L);
     return Pos & 0xFFFF;
 
     DWORD Pos = (DWORD)SendMessage(GetHwnd(), EM_GETSEL, 0, 0L);
     return Pos & 0xFFFF;


@@ -653,19 +810,12 @@ long wxTextCtrl::GetInsertionPoint() const
 
 long wxTextCtrl::GetLastPosition() const
 {
 
 long wxTextCtrl::GetLastPosition() const
 {

-    HWND hWnd = GetHwnd();
-
-    // Will always return a number > 0 (according to docs)
-    int noLines = (int)SendMessage(hWnd, EM_GETLINECOUNT, (WPARAM)0, (LPARAM)0L);
-
-    // This gets the char index for the _beginning_ of the last line
-    int charIndex = (int)SendMessage(hWnd, EM_LINEINDEX, (WPARAM)(noLines-1), (LPARAM)0L);
+    int numLines = GetNumberOfLines();
+    long posStartLastLine = XYToPosition(0, numLines - 1);

 
 

-    // Get number of characters in the last line. We'll add this to the character
-    // index for the last line, 1st position.
-    int lineLength = (int)SendMessage(hWnd, EM_LINELENGTH, (WPARAM)charIndex, (LPARAM)0L);
+    long lenLastLine = GetLengthOfLineContainingPos(posStartLastLine);

 
 

-    return (long)(charIndex + lineLength);
+    return posStartLastLine + lenLastLine;

 }
 
 // If the return values from and to are the same, there is no
 }
 
 // If the return values from and to are the same, there is no


@@ -673,22 +823,19 @@ long wxTextCtrl::GetLastPosition() const
 void wxTextCtrl::GetSelection(long* from, long* to) const
 {
 #if wxUSE_RICHEDIT
 void wxTextCtrl::GetSelection(long* from, long* to) const
 {
 #if wxUSE_RICHEDIT

-    if (m_isRich)
+    if ( IsRich() )

     {
         CHARRANGE charRange;
     {
         CHARRANGE charRange;

-        ::SendMessage(GetHwnd(), EM_EXGETSEL, 0, (LPARAM) (CHARRANGE*) & charRange);
+        ::SendMessage(GetHwnd(), EM_EXGETSEL, 0, (LPARAM) &charRange);

 
         *from = charRange.cpMin;
         *to = charRange.cpMax;
     }
     else
 
         *from = charRange.cpMin;
         *to = charRange.cpMax;
     }
     else

-#endif // rich/!rich
+#endif // !wxUSE_RICHEDIT

     {
         DWORD dwStart, dwEnd;
     {
         DWORD dwStart, dwEnd;

-        WPARAM wParam = (WPARAM) &dwStart; // receives starting position
-        LPARAM lParam = (LPARAM) &dwEnd;   // receives ending position
-
-        ::SendMessage(GetHwnd(), EM_GETSEL, wParam, lParam);
+        ::SendMessage(GetHwnd(), EM_GETSEL, (WPARAM)&dwStart, (LPARAM)&dwEnd);

 
         *from = dwStart;
         *to = dwEnd;
 
         *from = dwStart;
         *to = dwEnd;


@@ -697,68 +844,84 @@ void wxTextCtrl::GetSelection(long* from, long* to) const
 
 bool wxTextCtrl::IsEditable() const
 {
 
 bool wxTextCtrl::IsEditable() const
 {

+    // strangely enough, we may be called before the control is created: our
+    // own Create() calls MSWGetStyle() which calls AcceptsFocus() which calls
+    // us
+    if ( !m_hWnd )
+        return TRUE;
+

     long style = ::GetWindowLong(GetHwnd(), GWL_STYLE);
 
     long style = ::GetWindowLong(GetHwnd(), GWL_STYLE);
 

-    return ((style & ES_READONLY) == 0);
+    return (style & ES_READONLY) == 0;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// Editing
+// selection

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-void wxTextCtrl::Replace(long from, long to, const wxString& value)
+void wxTextCtrl::SetSelection(long from, long to)

 {
 {

-    HWND hWnd = GetHwnd();
-    long fromChar = from;
-    long toChar = to;
+    // if from and to are both -1, it means (in wxWindows) that all text should
+    // be selected - translate into Windows convention
+    if ( (from == -1) && (to == -1) )
+    {
+        from = 0;
+        to = -1;
+    }

 
 

-    // Set selection and remove it
-#ifdef __WIN32__
-    SendMessage(hWnd, EM_SETSEL, fromChar, toChar);
-    SendMessage(hWnd, EM_REPLACESEL, (WPARAM)TRUE, (LPARAM)value.c_str());
-#else
-    SendMessage(hWnd, EM_SETSEL, (WPARAM)0, (LPARAM)MAKELONG(fromChar, toChar));
-    SendMessage(hWnd, EM_REPLACESEL, (WPARAM)0, (LPARAM)value.c_str());
-#endif
+    DoSetSelection(from, to);

 }
 
 }
 

-void wxTextCtrl::Remove(long from, long to)
+void wxTextCtrl::DoSetSelection(long from, long to, bool scrollCaret)

 {
     HWND hWnd = GetHwnd();
 {
     HWND hWnd = GetHwnd();

-    long fromChar = from;
-    long toChar = to;

 
 

-    // Cut all selected text

 #ifdef __WIN32__
 #ifdef __WIN32__

-    SendMessage(hWnd, EM_SETSEL, fromChar, toChar);
-    SendMessage(hWnd, EM_REPLACESEL, (WPARAM)TRUE, (LPARAM)"");
-#else
-    SendMessage(hWnd, EM_SETSEL, (WPARAM)0, (LPARAM)MAKELONG(fromChar, toChar));
-    SendMessage(hWnd, EM_REPLACESEL, (WPARAM)0, (LPARAM)"");
-#endif
-}
-
-void wxTextCtrl::SetSelection(long from, long to)
-{
-    HWND hWnd = GetHwnd();
-    long fromChar = from;
-    long toChar = to;
+#if wxUSE_RICHEDIT
+    if ( IsRich() )
+    {
+        CHARRANGE range;
+        range.cpMin = from;
+        range.cpMax = to;
+        SendMessage(hWnd, EM_EXSETSEL, 0, (LPARAM) &range);
+    }
+    else
+#endif // wxUSE_RICHEDIT
+    {
+        SendMessage(hWnd, EM_SETSEL, (WPARAM)from, (LPARAM)to);
+    }

 
 

-    // if from and to are both -1, it means (in wxWindows) that all text should
-    // be selected. Translate into Windows convention
-    if ((from == -1) && (to == -1))
+    if ( scrollCaret )

     {
     {

-      fromChar = 0;
-      toChar = -1;
+        SendMessage(hWnd, EM_SCROLLCARET, (WPARAM)0, (LPARAM)0);

     }
     }

+#else // Win16
+    // WPARAM is 0: selection is scrolled into view
+    SendMessage(hWnd, EM_SETSEL, (WPARAM)0, (LPARAM)MAKELONG(from, to));
+#endif // Win32/16
+}
+
+// ----------------------------------------------------------------------------
+// Editing
+// ----------------------------------------------------------------------------
+
+void wxTextCtrl::Replace(long from, long to, const wxString& value)
+{
+    // Set selection and remove it
+    DoSetSelection(from, to, FALSE /* don't scroll caret into view */);

 
 

+    SendMessage(GetHwnd(), EM_REPLACESEL,

 #ifdef __WIN32__
 #ifdef __WIN32__

-    SendMessage(hWnd, EM_SETSEL, (WPARAM)fromChar, (LPARAM)toChar);
-    SendMessage(hWnd, EM_SCROLLCARET, (WPARAM)0, (LPARAM)0);
+                TRUE,

 #else
 #else

-    // WPARAM is 0: selection is scrolled into view
-    SendMessage(hWnd, EM_SETSEL, (WPARAM)0, (LPARAM)MAKELONG(fromChar, toChar));
+                FALSE,

 #endif
 #endif

+                (LPARAM)value.c_str());
+}
+
+void wxTextCtrl::Remove(long from, long to)
+{
+    Replace(from, to, _T(""));

 }
 
 bool wxTextCtrl::LoadFile(const wxString& file)
 }
 
 bool wxTextCtrl::LoadFile(const wxString& file)


@@ -776,7 +939,7 @@ bool wxTextCtrl::LoadFile(const wxString& file)
 
 bool wxTextCtrl::IsModified() const
 {
 
 bool wxTextCtrl::IsModified() const
 {

-    return (SendMessage(GetHwnd(), EM_GETMODIFY, 0, 0) != 0);
+    return SendMessage(GetHwnd(), EM_GETMODIFY, 0, 0) != 0;

 }
 
 // Makes 'unmodified'
 }
 
 // Makes 'unmodified'


@@ -792,11 +955,10 @@ int wxTextCtrl::GetNumberOfLines() const
 
 long wxTextCtrl::XYToPosition(long x, long y) const
 {
 
 long wxTextCtrl::XYToPosition(long x, long y) const
 {

-    HWND hWnd = GetHwnd();
-

     // This gets the char index for the _beginning_ of this line
     // This gets the char index for the _beginning_ of this line

-    int charIndex = (int)SendMessage(hWnd, EM_LINEINDEX, (WPARAM)y, (LPARAM)0);
-    return (long)(x + charIndex);
+    long charIndex = SendMessage(GetHwnd(), EM_LINEINDEX, (WPARAM)y, (LPARAM)0);
+
+    return charIndex + x;

 }
 
 bool wxTextCtrl::PositionToXY(long pos, long *x, long *y) const
 }
 
 bool wxTextCtrl::PositionToXY(long pos, long *x, long *y) const


@@ -804,15 +966,17 @@ bool wxTextCtrl::PositionToXY(long pos, long *x, long *y) const
     HWND hWnd = GetHwnd();
 
     // This gets the line number containing the character
     HWND hWnd = GetHwnd();
 
     // This gets the line number containing the character

-    int lineNo;
+    long lineNo;

 #if wxUSE_RICHEDIT
 #if wxUSE_RICHEDIT

-    if ( m_isRich )
+    if ( IsRich() )

     {
     {

-        lineNo = (int)SendMessage(hWnd, EM_EXLINEFROMCHAR, 0, (LPARAM)pos);
+        lineNo = SendMessage(hWnd, EM_EXLINEFROMCHAR, 0, (LPARAM)pos);

     }
     else
 #endif // wxUSE_RICHEDIT
     }
     else
 #endif // wxUSE_RICHEDIT

-        lineNo = (int)SendMessage(hWnd, EM_LINEFROMCHAR, (WPARAM)pos, 0);
+    {
+        lineNo = SendMessage(hWnd, EM_LINEFROMCHAR, (WPARAM)pos, 0);
+    }

 
     if ( lineNo == -1 )
     {
 
     if ( lineNo == -1 )
     {


@@ -821,7 +985,7 @@ bool wxTextCtrl::PositionToXY(long pos, long *x, long *y) const
     }
 
     // This gets the char index for the _beginning_ of this line
     }
 
     // This gets the char index for the _beginning_ of this line

-    int charIndex = (int)SendMessage(hWnd, EM_LINEINDEX, (WPARAM)lineNo, (LPARAM)0);
+    long charIndex = SendMessage(hWnd, EM_LINEINDEX, (WPARAM)lineNo, (LPARAM)0);

     if ( charIndex == -1 )
     {
         return FALSE;
     if ( charIndex == -1 )
     {
         return FALSE;


@@ -829,9 +993,9 @@ bool wxTextCtrl::PositionToXY(long pos, long *x, long *y) const
 
     // The X position must therefore be the different between pos and charIndex
     if ( x )
 
     // The X position must therefore be the different between pos and charIndex
     if ( x )

-        *x = (long)(pos - charIndex);
+        *x = pos - charIndex;

     if ( y )
     if ( y )

-        *y = (long)lineNo;
+        *y = lineNo;

 
     return TRUE;
 }
 
     return TRUE;
 }


@@ -861,11 +1025,16 @@ void wxTextCtrl::ShowPosition(long pos)
       (void)SendMessage(hWnd, EM_LINESCROLL, (WPARAM)0, (LPARAM)linesToScroll);
 }
 
       (void)SendMessage(hWnd, EM_LINESCROLL, (WPARAM)0, (LPARAM)linesToScroll);
 }
 

+long wxTextCtrl::GetLengthOfLineContainingPos(long pos) const
+{
+    return ::SendMessage(GetHwnd(), EM_LINELENGTH, (WPARAM)pos, 0);
+}
+

 int wxTextCtrl::GetLineLength(long lineNo) const
 {
 int wxTextCtrl::GetLineLength(long lineNo) const
 {

-    long charIndex = XYToPosition(0, lineNo);
-    int len = (int)SendMessage(GetHwnd(), EM_LINELENGTH, charIndex, 0);
-    return len;
+    long pos = XYToPosition(0, lineNo);
+
+    return GetLengthOfLineContainingPos(pos);

 }
 
 wxString wxTextCtrl::GetLineText(long lineNo) const
 }
 
 wxString wxTextCtrl::GetLineText(long lineNo) const


@@ -916,12 +1085,12 @@ void wxTextCtrl::Redo()
 
 bool wxTextCtrl::CanUndo() const
 {
 
 bool wxTextCtrl::CanUndo() const
 {

-    return (::SendMessage(GetHwnd(), EM_CANUNDO, 0, 0) != 0);
+    return ::SendMessage(GetHwnd(), EM_CANUNDO, 0, 0) != 0;

 }
 
 bool wxTextCtrl::CanRedo() const
 {
 }
 
 bool wxTextCtrl::CanRedo() const
 {

-    return (::SendMessage(GetHwnd(), EM_CANUNDO, 0, 0) != 0);
+    return ::SendMessage(GetHwnd(), EM_CANUNDO, 0, 0) != 0;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -956,7 +1125,7 @@ bool wxTextCtrl::MSWShouldPreProcessMessage(WXMSG* pMsg)
     // usual preprocessing for them
     if ( msg->message == WM_KEYDOWN )
     {
     // usual preprocessing for them
     if ( msg->message == WM_KEYDOWN )
     {

-        WORD vkey = msg->wParam;
+        WORD vkey = (WORD) msg->wParam;

         if ( (HIWORD(msg->lParam) & KF_ALTDOWN) == KF_ALTDOWN )
         {
             if ( vkey == VK_BACK )
         if ( (HIWORD(msg->lParam) & KF_ALTDOWN) == KF_ALTDOWN )
         {
             if ( vkey == VK_BACK )


@@ -1027,6 +1196,32 @@ void wxTextCtrl::OnChar(wxKeyEvent& event)
     event.Skip();
 }
 
     event.Skip();
 }
 

+long wxTextCtrl::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
+{
+    // we always want the characters and the arrows
+    if ( nMsg == WM_GETDLGCODE )
+    {
+        // we always want the chars and the arrows
+        long lDlgCode = DLGC_WANTCHARS | DLGC_WANTARROWS;
+
+        // we may have several different cases:
+        // 1. normal case: both TAB and ENTER are used for dialog navigation
+        // 2. ctrl which wants TAB for itself: ENTER is used to pass to the next
+        //    control in the dialog
+        // 3. ctrl which wants ENTER for itself: TAB is used for dialog navigation
+        // 4. ctrl which wants both TAB and ENTER: Ctrl-ENTER is used to pass to
+        //    the next control
+        if ( m_windowStyle & wxTE_PROCESS_ENTER )
+            lDlgCode |= DLGC_WANTMESSAGE;
+        if ( m_windowStyle & wxTE_PROCESS_TAB )
+            lDlgCode |= DLGC_WANTTAB;
+
+        return lDlgCode;
+    }
+
+    return wxTextCtrlBase::MSWWindowProc(nMsg, wParam, lParam);
+}
+

 bool wxTextCtrl::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
 {
     switch (param)
 bool wxTextCtrl::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
 {
     switch (param)


@@ -1105,7 +1300,7 @@ WXHBRUSH wxTextCtrl::OnCtlColor(WXHDC pDC, WXHWND WXUNUSED(pWnd), WXUINT WXUNUSE
     wxColour colBack = GetBackgroundColour();
 
     if (!IsEnabled() && (GetWindowStyle() & wxTE_MULTILINE) == 0)
     wxColour colBack = GetBackgroundColour();
 
     if (!IsEnabled() && (GetWindowStyle() & wxTE_MULTILINE) == 0)

-        colBack = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+        colBack = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);

 
     ::SetBkColor(hdc, wxColourToRGB(colBack));
     ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
 
     ::SetBkColor(hdc, wxColourToRGB(colBack));
     ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));


@@ -1124,15 +1319,13 @@ void wxTextCtrl::OnEraseBackground(wxEraseEvent& event)
 
 #if wxUSE_CTL3D
     if (m_useCtl3D)
 
 #if wxUSE_CTL3D
     if (m_useCtl3D)

-        col = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOW);
+        col = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);

 #endif
 
     RECT rect;
     ::GetClientRect(GetHwnd(), &rect);
 
 #endif
 
     RECT rect;
     ::GetClientRect(GetHwnd(), &rect);
 

-    COLORREF ref = PALETTERGB(col.Red(),
-                              col.Green(),
-                              col.Blue());
+    COLORREF ref = wxColourToRGB(col);

     HBRUSH hBrush = ::CreateSolidBrush(ref);
     if ( !hBrush )
         wxLogLastError(wxT("CreateSolidBrush"));
     HBRUSH hBrush = ::CreateSolidBrush(ref);
     if ( !hBrush )
         wxLogLastError(wxT("CreateSolidBrush"));


@@ -1146,7 +1339,7 @@ void wxTextCtrl::OnEraseBackground(wxEraseEvent& event)
     ::SetMapMode(hdc, mode);
 
 }
     ::SetMapMode(hdc, mode);
 
 }

-#endif
+#endif // Win16

 
 bool wxTextCtrl::AdjustSpaceLimit()
 {
 
 bool wxTextCtrl::AdjustSpaceLimit()
 {


@@ -1174,7 +1367,7 @@ bool wxTextCtrl::AdjustSpaceLimit()
         limit = len + 0x8000;    // 32Kb
 
 #if wxUSE_RICHEDIT
         limit = len + 0x8000;    // 32Kb
 
 #if wxUSE_RICHEDIT

-        if ( m_isRich )
+        if ( IsRich() )

         {
             // as a nice side effect, this also allows passing limit > 64Kb
             ::SendMessage(GetHwnd(), EM_EXLIMITTEXT, 0, limit);
         {
             // as a nice side effect, this also allows passing limit > 64Kb
             ::SendMessage(GetHwnd(), EM_EXLIMITTEXT, 0, limit);


@@ -1282,7 +1475,7 @@ void wxTextCtrl::OnUpdateRedo(wxUpdateUIEvent& event)
 // EN_LINK processing
 // ----------------------------------------------------------------------------
 
 // EN_LINK processing
 // ----------------------------------------------------------------------------
 

-bool wxTextCtrl::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result)
+bool wxTextCtrl::MSWOnNotify(int WXUNUSED(idCtrl), WXLPARAM lParam, WXLPARAM *result)

 {
     NMHDR *hdr = (NMHDR* )lParam;
     if ( hdr->code == EN_LINK )
 {
     NMHDR *hdr = (NMHDR* )lParam;
     if ( hdr->code == EN_LINK )


@@ -1348,11 +1541,6 @@ bool wxTextCtrl::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result)
 // colour setting for the rich edit controls
 // ----------------------------------------------------------------------------
 
 // colour setting for the rich edit controls
 // ----------------------------------------------------------------------------
 

-// Watcom C++ doesn't define this
-#ifndef SCF_ALL
-#define SCF_ALL 0x0004
-#endif
-

 bool wxTextCtrl::SetBackgroundColour(const wxColour& colour)
 {
     if ( !wxTextCtrlBase::SetBackgroundColour(colour) )
 bool wxTextCtrl::SetBackgroundColour(const wxColour& colour)
 {
     if ( !wxTextCtrlBase::SetBackgroundColour(colour) )


@@ -1405,10 +1593,9 @@ bool wxTextCtrl::SetStyle(long start, long end, const wxTextAttr& style)
         return FALSE;
     }
 
         return FALSE;
     }
 

-    // the rich text control doesn't handle setting background colour, so don't
-    // even try if it's the only thing we want to change
-    if ( wxRichEditModule::GetLoadedVersion() < 2 &&
-         !style.HasFont() && !style.HasTextColour() )
+    // the richedit 1.0 doesn't handle setting background colour, so don't
+    // even try to do anything if it's the only thing we want to change
+    if ( m_verRichEdit == 1 && !style.HasFont() && !style.HasTextColour() )

     {
         // nothing to do: return TRUE if there was really nothing to do and
         // FALSE if we failed to set bg colour
     {
         // nothing to do: return TRUE if there was really nothing to do and
         // FALSE if we failed to set bg colour


@@ -1432,7 +1619,9 @@ bool wxTextCtrl::SetStyle(long start, long end, const wxTextAttr& style)
     bool changeSel = start != startOld || end != endOld;
 
     if ( changeSel )
     bool changeSel = start != startOld || end != endOld;
 
     if ( changeSel )

-        SendMessage(GetHwnd(), EM_SETSEL, (WPARAM) start, (LPARAM) end);
+    {
+        DoSetSelection(start, end, FALSE /* don't scroll caret into view */);
+    }

 
     // initialize CHARFORMAT struct
 #if wxUSE_RICHEDIT2
 
     // initialize CHARFORMAT struct
 #if wxUSE_RICHEDIT2


@@ -1440,11 +1629,29 @@ bool wxTextCtrl::SetStyle(long start, long end, const wxTextAttr& style)
 #else
     CHARFORMAT cf;
 #endif
 #else
     CHARFORMAT cf;
 #endif

+

     wxZeroMemory(cf);
     wxZeroMemory(cf);

-    cf.cbSize = sizeof(cf);
+
+    // we can't use CHARFORMAT2 with RichEdit 1.0, so pretend it is a simple
+    // CHARFORMAT in that case
+#if wxUSE_RICHEDIT2
+    if ( m_verRichEdit == 1 )
+    {
+        // this is the only thing the control is going to grok
+        cf.cbSize = sizeof(CHARFORMAT);
+    }
+    else
+#endif
+    {
+        // CHARFORMAT or CHARFORMAT2
+        cf.cbSize = sizeof(cf);
+    }

 
     if ( style.HasFont() )
     {
 
     if ( style.HasFont() )
     {

+        // VZ: CFM_CHARSET doesn't seem to do anything at all in RichEdit 2.0
+        //     but using it doesn't seem to hurt neither so leaving it for now
+

         cf.dwMask |= CFM_FACE | CFM_SIZE | CFM_CHARSET |
                      CFM_ITALIC | CFM_BOLD | CFM_UNDERLINE;
 
         cf.dwMask |= CFM_FACE | CFM_SIZE | CFM_CHARSET |
                      CFM_ITALIC | CFM_BOLD | CFM_UNDERLINE;
 


@@ -1487,7 +1694,7 @@ bool wxTextCtrl::SetStyle(long start, long end, const wxTextAttr& style)
     }
 
 #if wxUSE_RICHEDIT2
     }
 
 #if wxUSE_RICHEDIT2

-    if ( wxRichEditModule::GetLoadedVersion() > 1 && style.HasBackgroundColour() )
+    if ( m_verRichEdit != 1 && style.HasBackgroundColour() )

     {
         cf.dwMask |= CFM_BACKCOLOR;
         cf.crBackColor = wxColourToRGB(style.GetBackgroundColour());
     {
         cf.dwMask |= CFM_BACKCOLOR;
         cf.crBackColor = wxColourToRGB(style.GetBackgroundColour());


@@ -1505,7 +1712,7 @@ bool wxTextCtrl::SetStyle(long start, long end, const wxTextAttr& style)
     if ( changeSel )
     {
         // restore the original selection
     if ( changeSel )
     {
         // restore the original selection

-        SendMessage(GetHwnd(), EM_SETSEL, (WPARAM)startOld, (LPARAM)endOld);
+        DoSetSelection(startOld, endOld, FALSE);

     }
 
     return ok;
     }
 
     return ok;


@@ -1523,48 +1730,48 @@ bool wxRichEditModule::OnInit()
 
 void wxRichEditModule::OnExit()
 {
 
 void wxRichEditModule::OnExit()
 {

-    if ( ms_hRichEdit )
+    for ( size_t i = 0; i < WXSIZEOF(ms_hRichEdit); i++ )

     {
     {

-        FreeLibrary(ms_hRichEdit);
+        if ( ms_hRichEdit[i] )
+        {
+            ::FreeLibrary(ms_hRichEdit[i]);
+        }

     }
 }
 
 /* static */
 bool wxRichEditModule::Load(int version)
 {
     }
 }
 
 /* static */
 bool wxRichEditModule::Load(int version)
 {

-    wxCHECK_MSG( version >= 1 && version <= 3, FALSE,
+    // we don't support loading richedit 3.0 as I don't know how to distinguish
+    // it from 2.0 anyhow
+    wxCHECK_MSG( version == 1 || version == 2, FALSE,

                  _T("incorrect richedit control version requested") );
 
                  _T("incorrect richedit control version requested") );
 

-    if ( version <= ms_verRichEdit )
+    // make it the index in the array
+    version--;
+
+    if ( ms_hRichEdit[version] == (HINSTANCE)-1 )

     {
     {

-        // we've already got this or better
-        return TRUE;
+        // we had already tried to load it and failed
+        return FALSE;

     }
 
     }
 

-    if ( ms_hRichEdit )
+    if ( ms_hRichEdit[version] )

     {
     {

-        ::FreeLibrary(ms_hRichEdit);
+        // we've already got this one
+        return TRUE;

     }
 
     }
 

-    // always try load riched20.dll first - like this we won't have to reload
-    // it later if we're first asked for RE 1 and then for RE 2 or 3
-    wxString dllname = _T("riched20.dll");
-    ms_hRichEdit = ::LoadLibrary(dllname);
-    ms_verRichEdit = 2; // no way to tell if it's 2 or 3, assume 2
+    wxString dllname = version ? _T("riched20") : _T("riched32");
+    dllname += _T(".dll");

 
 

-    if ( !ms_hRichEdit && (version == 1) )
-    {
-        // fall back to RE 1
-        dllname = _T("riched32.dll");
-        ms_hRichEdit = ::LoadLibrary(dllname);
-        ms_verRichEdit = 1;
-    }
+    ms_hRichEdit[version] = ::LoadLibrary(dllname);

 
 

-    if ( !ms_hRichEdit )
+    if ( !ms_hRichEdit[version] )

     {
         wxLogSysError(_("Could not load Rich Edit DLL '%s'"), dllname.c_str());
 
     {
         wxLogSysError(_("Could not load Rich Edit DLL '%s'"), dllname.c_str());
 

-        ms_verRichEdit = -1;
+        ms_hRichEdit[version] = (HINSTANCE)-1;

 
         return FALSE;
     }
 
         return FALSE;
     }