reduced flicker when switching focus to/from the report list ctrl under wxGTK

[wxWidgets.git] / src / generic / statusbr.cpp

diff --git a/src/generic/statusbr.cpp b/src/generic/statusbr.cpp
index d78787b1e9f82c34e6cb20284d8203ac7bee40fa..e1739aa5c326d84aad43d5e4523959f8a14b865c 100644 (file)
--- a/src/generic/statusbr.cpp
+++ b/src/generic/statusbr.cpp
@@ -1,12 +1,12 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        statusbr.cpp
-// Purpose:     wxStatusBar class implementation
+// Name:        generic/statusbr.cpp
+// Purpose:     wxStatusBarGeneric class implementation

 // Author:      Julian Smart
 // Modified by:
 // Created:     01/02/97
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem
 // Author:      Julian Smart
 // Modified by:
 // Created:     01/02/97
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem

-// Licence:    wxWindows license
+// Licence:     wxWindows license

 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__


@@ -20,6 +20,8 @@
 #pragma hdrstop
 #endif
 
 #pragma hdrstop
 #endif
 

+#if wxUSE_STATUSBAR
+

 #ifndef WX_PRECOMP
 #include "wx/setup.h"
 #include "wx/frame.h"
 #ifndef WX_PRECOMP
 #include "wx/setup.h"
 #include "wx/frame.h"


@@ -27,66 +29,66 @@
 #include "wx/dcclient.h"
 #endif
 
 #include "wx/dcclient.h"
 #endif
 

-#include "wx/generic/statusbr.h"
-
-#ifdef __WINDOWS__
-#include <windows.h>
+#include "wx/statusbr.h"

 
 

-#ifdef DrawText
-#undef DrawText
-#endif
+// with wxUSE_NATIVE_STATUSBAR it is not included from wx/statusbr.h
+#include "wx/generic/statusbr.h"

 
 

-#endif
+IMPLEMENT_DYNAMIC_CLASS(wxStatusBarGeneric, wxWindow)

 
 

-#if !USE_SHARED_LIBRARY
-IMPLEMENT_DYNAMIC_CLASS(wxStatusBar, wxWindow)
+#if !defined(__WIN32__) || !wxUSE_NATIVE_STATUSBAR
+    IMPLEMENT_DYNAMIC_CLASS(wxStatusBar, wxStatusBarGeneric)
+#endif // Win32 && wxUSE_NATIVE_STATUSBAR

 
 

-BEGIN_EVENT_TABLE(wxStatusBar, wxWindow)
-       EVT_PAINT(wxStatusBar::OnPaint)
-    EVT_SYS_COLOUR_CHANGED(wxStatusBar::OnSysColourChanged)
+BEGIN_EVENT_TABLE(wxStatusBarGeneric, wxWindow)
+    EVT_PAINT(wxStatusBarGeneric::OnPaint)
+    EVT_SYS_COLOUR_CHANGED(wxStatusBarGeneric::OnSysColourChanged)

 END_EVENT_TABLE()
 END_EVENT_TABLE()

-#endif

 
 // Default status border dimensions
 #define         wxTHICK_LINE_BORDER 2
 #define         wxTHICK_LINE_WIDTH  1
 
 
 // Default status border dimensions
 #define         wxTHICK_LINE_BORDER 2
 #define         wxTHICK_LINE_WIDTH  1
 

-wxStatusBar::wxStatusBar(void)
+wxStatusBarGeneric::wxStatusBarGeneric()

 {
 {

-  m_statusWidths = NULL;
-  m_statusStrings = NULL;
+  m_statusWidths = (int *) NULL;
+  m_statusStrings = (wxString *) NULL;

   m_nFields = 0;
   m_borderX = wxTHICK_LINE_BORDER;
   m_borderY = wxTHICK_LINE_BORDER;
 }
 
   m_nFields = 0;
   m_borderX = wxTHICK_LINE_BORDER;
   m_borderY = wxTHICK_LINE_BORDER;
 }
 

-wxStatusBar::~wxStatusBar(void)
+wxStatusBarGeneric::~wxStatusBarGeneric()

 {
 {

-    SetFont(wxNullFont);
-
-       if ( m_statusWidths )
-               delete[] m_statusWidths;
-       if ( m_statusStrings )
-               delete[] m_statusStrings;
+#   ifdef __WXMSW__
+        SetFont(wxNullFont);
+#   endif // MSW
+
+    if ( m_statusWidths )
+        delete[] m_statusWidths;
+    if ( m_statusStrings )
+        delete[] m_statusStrings;

 }
 
 }
 

-bool wxStatusBar::Create(wxWindow *parent, wxWindowID id,
-           const wxPoint& pos,
-           const wxSize& size,
-           long style,
-           const wxString& name)
+bool wxStatusBarGeneric::Create(wxWindow *parent,
+                         wxWindowID id,
+                         long style,
+                         const wxString& name)

 {
 {

-  m_statusWidths = NULL;
-  m_statusStrings = NULL;
+  m_statusWidths = (int *) NULL;
+  m_statusStrings = (wxString *) NULL;

   m_nFields = 0;
   m_borderX = wxTHICK_LINE_BORDER;
   m_borderY = wxTHICK_LINE_BORDER;
 
   m_nFields = 0;
   m_borderX = wxTHICK_LINE_BORDER;
   m_borderY = wxTHICK_LINE_BORDER;
 

-  bool success = wxWindow::Create(parent, id, pos, size, style, name);
+  bool success = wxWindow::Create(parent, id,
+                                  wxDefaultPosition, wxDefaultSize,
+                                  style | wxTAB_TRAVERSAL, name);

 
   // Don't wish this to be found as a child
 
   // Don't wish this to be found as a child

-  parent->GetChildren()->DeleteObject(this);
-
+#ifndef __WXMAC__
+  parent->GetChildren().DeleteObject(this);
+#endif

   InitColours();
 
   SetFont(m_defaultStatusBarFont);
   InitColours();
 
   SetFont(m_defaultStatusBarFont);


@@ -94,95 +96,111 @@ bool wxStatusBar::Create(wxWindow *parent, wxWindowID id,
   return success;
 }
 
   return success;
 }
 

-void wxStatusBar::SetFieldsCount(int number, int *widths)
+void wxStatusBarGeneric::SetFieldsCount(int number, const int *widths)

 {
 {

-  m_nFields = number;
-
-  if ( m_statusWidths )
-       delete[] m_statusWidths;
-
-  if ( m_statusStrings )
-               delete[] m_statusStrings;
+    if ( number != m_nFields )
+    {
+        m_nFields = number;

 
 

-  m_statusStrings = new wxString[number];
+        delete[] m_statusStrings;
+        m_statusStrings = new wxString[number];

 
 

-  int i;
-  for (i = 0; i < number; i++)
-       m_statusStrings[i] = "";
+#if 0 // VZ: what is this for?
+        int i;
+        for (i = 0; i < number; i++)
+            m_statusStrings[i] = "";
+#endif
+    }

 
 

-       if ( widths )
-               SetStatusWidths(number, widths);
+    SetStatusWidths(number, widths);

 }
 
 }
 

-void wxStatusBar::SetStatusText(const wxString& text, int number)
+void wxStatusBarGeneric::SetStatusText(const wxString& text, int number)

 {
 {

-  if ((number < 0) || (number >= m_nFields))
-    return;
+    wxCHECK_RET( (number >= 0) && (number < m_nFields),
+                 _T("invalid status bar field index") );

 
 

-  m_statusStrings[number] = text;
+    m_statusStrings[number] = text;

 
 

-  Refresh();
-
-#ifdef __WINDOWS__
-  // For some reason, this can cause major GDI problems - graphics
-  // all over the place. E.g. in print previewing.
-//  ::UpdateWindow((HWND) GetHWND());
-#endif
+    Refresh();

 }
 
 }
 

-wxString wxStatusBar::GetStatusText(int n) const
+wxString wxStatusBarGeneric::GetStatusText(int n) const

 {
 {

-  if ((n < 0) || (n >= m_nFields))
-    return wxString("");
-  else
+    wxCHECK_MSG( (n >= 0) && (n < m_nFields), wxEmptyString,
+                 _T("invalid status bar field index") );
+

     return m_statusStrings[n];
 }
 
     return m_statusStrings[n];
 }
 

-void wxStatusBar::SetStatusWidths(int n, int *widths_field)
+void wxStatusBarGeneric::SetStatusWidths(int n, const int widths_field[])

 {
 {

-  // only set status widths, when n == number of statuswindows
-  if (n == m_nFields)
-  {
-    // only set status widths,
+    // only set status widths, when n == number of statuswindows
+    wxCHECK_RET( n == m_nFields, _T("status bar field count mismatch") );
+
+    // delete the old widths in any case - this function may be used to reset
+    // the widths to the default (all equal)
+    delete [] m_statusWidths;
+
+    if ( !widths_field )
+    {
+        // not an error, see the comment above
+        m_statusWidths = (int *)NULL;
+
+        return;
+    }
+
+    int i;
+
+    // VZ: this doesn't do anything as is_variable is unused later
+#if 0

     // when one window (minimum) is variable (width <= 0)
     bool is_variable = FALSE;
     // when one window (minimum) is variable (width <= 0)
     bool is_variable = FALSE;

-    int i;

     for (i = 0; i < m_nFields; i++)
     {
     for (i = 0; i < m_nFields; i++)
     {

-      if (widths_field[i] <= 0) is_variable = TRUE;
+        if (widths_field[i] <= 0)
+            is_variable = TRUE;

     }
     }

-
-    // if there are old widths, delete them
-    if (m_statusWidths)
-      delete [] m_statusWidths;
+#endif // 0

 
     // set widths
     m_statusWidths = new int[n];
     for (i = 0; i < m_nFields; i++)
     {
 
     // set widths
     m_statusWidths = new int[n];
     for (i = 0; i < m_nFields; i++)
     {

-      m_statusWidths[i] = widths_field[i];
+        m_statusWidths[i] = widths_field[i];

     }
     }

-  }

 }
 
 }
 

-void wxStatusBar::OnPaint(wxPaintEvent& WXUNUSED(event) )
+void wxStatusBarGeneric::OnPaint(wxPaintEvent& WXUNUSED(event) )

 {
   wxPaintDC dc(this);
 
 {
   wxPaintDC dc(this);
 

+

   int i;
   int i;

-  if ( GetFont() )
-    dc.SetFont(*GetFont());
+  if ( GetFont().Ok() )
+    dc.SetFont(GetFont());

   dc.SetBackgroundMode(wxTRANSPARENT);
 
   dc.SetBackgroundMode(wxTRANSPARENT);
 

+#ifdef __WXPM__
+  wxColour                          vColor;
+
+  vColor.InitFromName("GREY");
+  ::WinFillRect(dc.m_hPS, &dc.m_vRclPaint, vColor.GetPixel());
+#endif
+

   for ( i = 0; i < m_nFields; i ++ )
   for ( i = 0; i < m_nFields; i ++ )

-       DrawField(dc, i);
+    DrawField(dc, i);
+
+#ifdef __WXMSW__
+  dc.SetFont(wxNullFont);
+#endif // MSW

 }
 
 }
 

-void wxStatusBar::DrawFieldText(wxDC& dc, int i)
+void wxStatusBarGeneric::DrawFieldText(wxDC& dc, int i)

 {
   int leftMargin = 2;
 
 {
   int leftMargin = 2;
 

-  wxRectangle rect;
+  wxRect rect;

   GetFieldRect(i, rect);
 
   wxString text(GetStatusText(i));
   GetFieldRect(i, rect);
 
   wxString text(GetStatusText(i));


@@ -194,6 +212,11 @@ void wxStatusBar::DrawFieldText(wxDC& dc, int i)
   int xpos = rect.x + leftMargin;
   int ypos = (int) (((rect.height - y) / 2 ) + rect.y + 0.5) ;
 
   int xpos = rect.x + leftMargin;
   int ypos = (int) (((rect.height - y) / 2 ) + rect.y + 0.5) ;
 

+#if defined( __WXGTK__ ) || defined(__WXMAC__)
+  xpos++;
+  ypos++;
+#endif
+

   dc.SetClippingRegion(rect.x, rect.y, rect.width, rect.height);
 
   dc.DrawText(text, xpos, ypos);
   dc.SetClippingRegion(rect.x, rect.y, rect.width, rect.height);
 
   dc.DrawText(text, xpos, ypos);


@@ -201,9 +224,9 @@ void wxStatusBar::DrawFieldText(wxDC& dc, int i)
   dc.DestroyClippingRegion();
 }
 
   dc.DestroyClippingRegion();
 }
 

-void wxStatusBar::DrawField(wxDC& dc, int i)
+void wxStatusBarGeneric::DrawField(wxDC& dc, int i)

 {
 {

-  wxRectangle rect;
+  wxRect rect;

   GetFieldRect(i, rect);
 
     // Draw border
   GetFieldRect(i, rect);
 
     // Draw border


@@ -212,33 +235,58 @@ void wxStatusBar::DrawField(wxDC& dc, int i)
     // Inside this, left and top sides - dark grey. Bottom and right -
     // white.
 
     // Inside this, left and top sides - dark grey. Bottom and right -
     // white.
 

-       dc.SetPen(m_hilightPen);
+    dc.SetPen(m_hilightPen);
+
+#ifndef __WXPM__

 
     // Right and bottom white lines
     dc.DrawLine(rect.x + rect.width, rect.y,
                 rect.x + rect.width, rect.y + rect.height);
     dc.DrawLine(rect.x + rect.width, rect.y + rect.height,
 
     // Right and bottom white lines
     dc.DrawLine(rect.x + rect.width, rect.y,
                 rect.x + rect.width, rect.y + rect.height);
     dc.DrawLine(rect.x + rect.width, rect.y + rect.height,

-                               rect.x, rect.y + rect.height);
+                rect.x, rect.y + rect.height);

 
 

-       dc.SetPen(m_mediumShadowPen);
+    dc.SetPen(m_mediumShadowPen);

 
     // Left and top grey lines
     dc.DrawLine(rect.x, rect.y + rect.height,
 
     // Left and top grey lines
     dc.DrawLine(rect.x, rect.y + rect.height,

-               rect.x, rect.y);
+           rect.x, rect.y);

     dc.DrawLine(rect.x, rect.y,
     dc.DrawLine(rect.x, rect.y,

-               rect.x + rect.width, rect.y);
+        rect.x + rect.width, rect.y);
+#else
+    // Right
+    dc.DrawLine(rect.x + rect.width, rect.y,
+                rect.x + rect.width, rect.y + rect.height + 2);
+    dc.SetPen(m_mediumShadowPen);
+    dc.DrawLine(rect.x + rect.width + 1, rect.y,
+                rect.x + rect.width + 1, rect.y + rect.height + 2);
+    dc.DrawLine(rect.x + rect.width + 2, rect.y,
+                rect.x + rect.width + 2, rect.y + rect.height + 2);
+    // Top
+    dc.DrawLine(rect.x + rect.width + 2, rect.y,
+                rect.x - 2, rect.y);
+    dc.DrawLine(rect.x + rect.width + 1, rect.y - 1,
+                rect.x - 2, rect.y - 1);
+    dc.SetPen(m_hilightPen);
+    dc.DrawLine(rect.x + rect.width, rect.y - 2,
+                rect.x - 2, rect.y - 2);
+
+#endif

 
 

-       DrawFieldText(dc, i);
+    DrawFieldText(dc, i);

 }
 
   // Get the position and size of the field's internal bounding rectangle
 }
 
   // Get the position and size of the field's internal bounding rectangle

-bool wxStatusBar::GetFieldRect(int n, wxRectangle& rect) const
+bool wxStatusBarGeneric::GetFieldRect(int n, wxRect& rect) const

 {
 {

-  if ((n < 0) || (n >= m_nFields))
-    return FALSE;
+  wxCHECK_MSG( (n >= 0) && (n < m_nFields), FALSE,
+               _T("invalid status bar field index") );

 
   int width, height;
 
   int width, height;

+#ifdef __WXPM__
+  GetSize(&width, &height);
+#else

   GetClientSize(&width, &height);
   GetClientSize(&width, &height);

+#endif

 
   int i;
   int sum_of_nonvar = 0;
 
   int i;
   int sum_of_nonvar = 0;


@@ -265,9 +313,9 @@ bool wxStatusBar::GetFieldRect(int n, wxRectangle& rect) const
     for (i = 0; i < m_nFields; i++)
     {
       fieldWidth = (int)(width/m_nFields);
     for (i = 0; i < m_nFields; i++)
     {
       fieldWidth = (int)(width/m_nFields);

-         fieldPosition = i*fieldWidth;
-         if ( i == n )
-               break;
+      fieldPosition = i*fieldWidth;
+      if ( i == n )
+        break;

     }
   }
   else // no_same_width
     }
   }
   else // no_same_width


@@ -281,28 +329,28 @@ bool wxStatusBar::GetFieldRect(int n, wxRectangle& rect) const
     }
     for (i = 0; i < m_nFields; i++)
     {
     }
     for (i = 0; i < m_nFields; i++)
     {

-               fieldWidth = tempwidth[i];
-               fieldPosition = temppos;
+        fieldWidth = tempwidth[i];
+        fieldPosition = temppos;

 
 

-       temppos += tempwidth[i];
+          temppos += tempwidth[i];

 
 

-               if ( i == n )
-                       break;
+        if ( i == n )
+            break;

     }
     delete [] tempwidth;
   }
 
     rect.x = fieldPosition + wxTHICK_LINE_BORDER;
     }
     delete [] tempwidth;
   }
 
     rect.x = fieldPosition + wxTHICK_LINE_BORDER;

-       rect.y = wxTHICK_LINE_BORDER;
+    rect.y = wxTHICK_LINE_BORDER;

 
 

-       rect.width = fieldWidth - 2 * wxTHICK_LINE_BORDER ;
-       rect.height = height - 2 * wxTHICK_LINE_BORDER ;
+    rect.width = fieldWidth - 2 * wxTHICK_LINE_BORDER ;
+    rect.height = height - 2 * wxTHICK_LINE_BORDER ;

 
 

-       return TRUE;
+    return TRUE;

 }
 
 // Initialize colours
 }
 
 // Initialize colours

-void wxStatusBar::InitColours(void)
+void wxStatusBarGeneric::InitColours()

 {
     // Shadow colours
 #if defined(__WIN95__)
 {
     // Shadow colours
 #if defined(__WIN95__)


@@ -311,17 +359,20 @@ void wxStatusBar::InitColours(void)
 
     wxColour hilightColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DHILIGHT));
     m_hilightPen = wxPen(hilightColour, 1, wxSOLID);
 
     wxColour hilightColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DHILIGHT));
     m_hilightPen = wxPen(hilightColour, 1, wxSOLID);

+#elif defined(__WXPM__)
+    m_mediumShadowPen = wxPen("LIGHT GREY", 1, wxSOLID);
+    m_hilightPen = wxPen("WHITE", 1, wxSOLID);

 #else
     m_mediumShadowPen = wxPen("GREY", 1, wxSOLID);
     m_hilightPen = wxPen("WHITE", 1, wxSOLID);
 #endif
 
 #else
     m_mediumShadowPen = wxPen("GREY", 1, wxSOLID);
     m_hilightPen = wxPen("WHITE", 1, wxSOLID);
 #endif
 

-       m_defaultStatusBarFont = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
+    m_defaultStatusBarFont = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);

     SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE));
 }
 
 // Responds to colour changes, and passes event on to children.
     SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE));
 }
 
 // Responds to colour changes, and passes event on to children.

-void wxStatusBar::OnSysColourChanged(wxSysColourChangedEvent& event)
+void wxStatusBarGeneric::OnSysColourChanged(wxSysColourChangedEvent& event)

 {
     InitColours();
     Refresh();
 {
     InitColours();
     Refresh();


@@ -330,3 +381,18 @@ void wxStatusBar::OnSysColourChanged(wxSysColourChangedEvent& event)
     wxWindow::OnSysColourChanged(event);
 }
 
     wxWindow::OnSysColourChanged(event);
 }
 

+void wxStatusBarGeneric::SetMinHeight(int height)
+{
+    // check that this min height is not less than minimal height for the
+    // current font
+    wxClientDC dc(this);
+    wxCoord y;
+    dc.GetTextExtent( _T("X"), NULL, &y );
+
+    if ( height > (11*y)/10 )
+    {
+        SetSize(-1, -1, -1, height + 2*m_borderY);
+    }
+}
+
+#endif // wxUSE_STATUSBAR