Stupid bug: using LastError() instead of Error()

[wxWidgets.git] / src / common / imagpng.cpp

diff --git a/src/common/imagpng.cpp b/src/common/imagpng.cpp
index 1a27982b129883f96f860bfce63de5d2fd12f2c0..f869ffedee51cb09a7e1601ed3860d7629e08267 100644 (file)
--- a/src/common/imagpng.cpp
+++ b/src/common/imagpng.cpp
@@ -7,10 +7,9 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-/*
-   We don't put pragma implement in this file because it is already present in
-   src/common/image.cpp
-*/
+#ifdef __GNUG__
+#pragma implementation "imagpng.h"
+#endif

 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"


@@ -25,7 +24,7 @@
 
 #if wxUSE_LIBPNG
 
 
 #if wxUSE_LIBPNG
 

-#include "wx/image.h"
+#include "wx/imagpng.h"

 #include "wx/bitmap.h"
 #include "wx/debug.h"
 #include "wx/log.h"
 #include "wx/bitmap.h"
 #include "wx/debug.h"
 #include "wx/log.h"


@@ -53,11 +52,9 @@
 // wxPNGHandler
 //-----------------------------------------------------------------------------
 
 // wxPNGHandler
 //-----------------------------------------------------------------------------
 

-#if !USE_SHARED_LIBRARIES

 IMPLEMENT_DYNAMIC_CLASS(wxPNGHandler,wxImageHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxPNGHandler,wxImageHandler)

-#endif

 
 

-#if wxUSE_STREAMS
+#if wxUSE_LIBPNG

 
 #if defined(__VISAGECPP__)
 #define LINKAGEMODE _Optlink
 
 #if defined(__VISAGECPP__)
 #define LINKAGEMODE _Optlink


@@ -78,7 +75,7 @@ static void LINKAGEMODE _PNG_stream_writer( png_structp png_ptr, png_bytep data,
 // from pngerror.c
 // so that the libpng doesn't send anything on stderr
 void
 // from pngerror.c
 // so that the libpng doesn't send anything on stderr
 void

-png_silent_error(png_structp png_ptr, png_const_charp WXUNUSED(message))
+LINKAGEMODE png_silent_error(png_structp png_ptr, png_const_charp WXUNUSED(message))

 {
 #ifdef USE_FAR_KEYWORD
    {
 {
 #ifdef USE_FAR_KEYWORD
    {


@@ -92,11 +89,11 @@ png_silent_error(png_structp png_ptr, png_const_charp WXUNUSED(message))
 }
 
 void
 }
 
 void

-png_silent_warning(png_structp WXUNUSED(png_ptr), png_const_charp WXUNUSED(message))
+LINKAGEMODE png_silent_warning(png_structp WXUNUSED(png_ptr), png_const_charp WXUNUSED(message))

 {
 }
 
 {
 }
 

-bool wxPNGHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose)
+bool wxPNGHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose, int WXUNUSED(index) )

 {
     // VZ: as this function uses setjmp() the only fool proof error handling
     //     method is to use goto (setjmp is not really C++ dtors friendly...)
 {
     // VZ: as this function uses setjmp() the only fool proof error handling
     //     method is to use goto (setjmp is not really C++ dtors friendly...)


@@ -144,18 +141,18 @@ bool wxPNGHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose
         png_set_expand( png_ptr );
     png_set_filler( png_ptr, 0xff, PNG_FILLER_AFTER );
 
         png_set_expand( png_ptr );
     png_set_filler( png_ptr, 0xff, PNG_FILLER_AFTER );
 

-    image->Create( width, height );
+    image->Create( (int)width, (int)height );

 
     if (!image->Ok())
         goto error_nolines;
 
 
     if (!image->Ok())
         goto error_nolines;
 

-    lines = (unsigned char **)malloc( height * sizeof(unsigned char *) );
+    lines = (unsigned char **)malloc( (size_t)(height * sizeof(unsigned char *)) );

     if (lines == NULL)
         goto error_nolines;
 
     for (i = 0; i < height; i++)
     {
     if (lines == NULL)
         goto error_nolines;
 
     for (i = 0; i < height; i++)
     {

-        if ((lines[i] = (unsigned char *)malloc(width * (sizeof(unsigned char) * 4))) == NULL)
+        if ((lines[i] = (unsigned char *)malloc( (size_t)(width * (sizeof(unsigned char) * 4)))) == NULL)

         {
             for ( unsigned int n = 0; n < i; n++ )
                 free( lines[n] );
         {
             for ( unsigned int n = 0; n < i; n++ )
                 free( lines[n] );


@@ -167,6 +164,7 @@ bool wxPNGHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose
     {
         int transp = 0;
         png_read_image( png_ptr, lines );
     {
         int transp = 0;
         png_read_image( png_ptr, lines );

+        png_read_end( png_ptr, info_ptr );

         png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
         unsigned char *ptr = image->GetData();
         if ((color_type == PNG_COLOR_TYPE_GRAY) ||
         png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
         unsigned char *ptr = image->GetData();
         if ((color_type == PNG_COLOR_TYPE_GRAY) ||


@@ -243,7 +241,8 @@ bool wxPNGHandler::LoadFile( wxImage *image, wxInputStream& stream, bool verbose
  error_nolines:
     lines = NULL; // called from before it was set
  error:
  error_nolines:
     lines = NULL; // called from before it was set
  error:

-    wxLogError(_("Couldn't load a PNG image - probably file is corrupted."));
+    if (verbose)
+       wxLogError(_("Couldn't load a PNG image - file is corrupted or not enough memory."));

 
     if ( image->Ok() )
     {
 
     if ( image->Ok() )
     {


@@ -278,7 +277,7 @@ bool wxPNGHandler::SaveFile( wxImage *image, wxOutputStream& stream, bool verbos
             return FALSE;
         }
 
             return FALSE;
         }
 

-       if (!verbose) png_set_error_fn(png_ptr, (png_voidp)NULL, png_silent_error, png_silent_warning);
+        if (!verbose) png_set_error_fn(png_ptr, (png_voidp)NULL, png_silent_error, png_silent_warning);

 
         png_infop info_ptr = png_create_info_struct(png_ptr);
         if (info_ptr == NULL)
 
         png_infop info_ptr = png_create_info_struct(png_ptr);
         if (info_ptr == NULL)


@@ -324,15 +323,16 @@ bool wxPNGHandler::SaveFile( wxImage *image, wxOutputStream& stream, bool verbos
                 data[(x << 2) + 0] = *ptr++;
                 data[(x << 2) + 1] = *ptr++;
                 data[(x << 2) + 2] = *ptr++;
                 data[(x << 2) + 0] = *ptr++;
                 data[(x << 2) + 1] = *ptr++;
                 data[(x << 2) + 2] = *ptr++;

-                if ((data[(x << 2) + 0] == image->GetMaskRed()) &&
-                    (data[(x << 2) + 1] == image->GetMaskGreen()) &&
-                    (data[(x << 2) + 2] == image->GetMaskBlue()))
+                if (( !image->HasMask() ) || \
+                    (data[(x << 2) + 0] != image->GetMaskRed()) || \
+                    (data[(x << 2) + 1] != image->GetMaskGreen()) || \
+                    (data[(x << 2) + 2] != image->GetMaskBlue()))

                 {
                 {

-                    data[(x << 2) + 3] = 0;
+                    data[(x << 2) + 3] = 255;

                 }
                 else
                 {
                 }
                 else
                 {

-                    data[(x << 2) + 3] = 255;
+                    data[(x << 2) + 3] = 0;

                 }
             }
             png_bytep row_ptr = data;
                 }
             }
             png_bytep row_ptr = data;


@@ -346,9 +346,15 @@ bool wxPNGHandler::SaveFile( wxImage *image, wxOutputStream& stream, bool verbos
     return TRUE;
 }
 
     return TRUE;
 }
 

-#endif
-  // wxUSE_STREAMS
+bool wxPNGHandler::DoCanRead( wxInputStream& stream )
+{
+    unsigned char hdr[4];

 
 

-#endif
-  // wxUSE_LIBPNG
+    stream.Read(&hdr, 4);
+    stream.SeekI(-4, wxFromCurrent);
+    return (hdr[0] == 0x89 && hdr[1] == 'P' && hdr[2] == 'N' && hdr[3] == 'G');
+}
+
+#endif  // wxUSE_STREAMS

 
 

+#endif  // wxUSE_LIBPNG