made wxHeaderCtrl::GetColumn() const to get rid of the const_cast<>s

[wxWidgets.git] / src / gtk / spinctrl.cpp

diff --git a/src/gtk/spinctrl.cpp b/src/gtk/spinctrl.cpp
index 4c85508b2df96dd701c34d1bb6ab7e48eaf9057d..cb2d02f4f78540169d5b65996b4452c79ba80c02 100644 (file)
--- a/src/gtk/spinctrl.cpp
+++ b/src/gtk/spinctrl.cpp
@@ -16,19 +16,13 @@
 #include "wx/spinctrl.h"
 
 #ifndef WX_PRECOMP
 #include "wx/spinctrl.h"
 
 #ifndef WX_PRECOMP

+    #include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED

     #include "wx/utils.h"
     #include "wx/utils.h"

+    #include "wx/wxcrtvararg.h"

 #endif
 
 #endif
 

-#include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
-#include "wx/math.h"

 #include "wx/gtk/private.h"
 
 #include "wx/gtk/private.h"
 

-//-----------------------------------------------------------------------------
-// idle system
-//-----------------------------------------------------------------------------
-
-static const float sensitivity = 0.02;
-

 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------


@@ -40,15 +34,12 @@ extern bool   g_blockEventsOnDrag;
 //-----------------------------------------------------------------------------
 
 extern "C" {
 //-----------------------------------------------------------------------------
 
 extern "C" {

-static void gtk_spinctrl_callback( GtkWidget *WXUNUSED(widget), wxSpinCtrl *win )
+static void
+gtk_value_changed(GtkSpinButton* spinbutton, wxSpinCtrlGTKBase* win)

 {
 {

-    if (g_isIdle) wxapp_install_idle_handler();
-
-    if (!win->m_hasVMT) return;
-    if (g_blockEventsOnDrag) return;
-
-    wxCommandEvent event( wxEVT_COMMAND_SPINCTRL_UPDATED, win->GetId());
-    event.SetEventObject( win );
+    win->m_value = gtk_spin_button_get_value(spinbutton);
+    if (!win->m_hasVMT || g_blockEventsOnDrag)
+        return;

 
     // note that we don't use wxSpinCtrl::GetValue() here because it would
     // adjust the value to fit into the control range and this means that we
 
     // note that we don't use wxSpinCtrl::GetValue() here because it would
     // adjust the value to fit into the control range and this means that we


@@ -56,8 +47,23 @@ static void gtk_spinctrl_callback( GtkWidget *WXUNUSED(widget), wxSpinCtrl *win
     // temporarily - and trying to enter 10 into the control which accepts the
     // values in range 5..50 is then, ummm, quite challenging (hint: you can't
     // enter 1!) (VZ)
     // temporarily - and trying to enter 10 into the control which accepts the
     // values in range 5..50 is then, ummm, quite challenging (hint: you can't
     // enter 1!) (VZ)

-    event.SetInt( (int)ceil(win->m_adjust->value) );
-    win->GetEventHandler()->ProcessEvent( event );
+
+    if (wxIsKindOf(win, wxSpinCtrl))
+    {
+        wxSpinEvent event(wxEVT_COMMAND_SPINCTRL_UPDATED, win->GetId());
+        event.SetEventObject( win );
+        event.SetPosition((int)(win->m_value + 0.5)); // FIXME should be SetValue
+        event.SetString(GTK_ENTRY(spinbutton)->text);
+        win->HandleWindowEvent( event );
+    }
+    else // wxIsKindOf(win, wxSpinCtrlDouble)
+    {
+        wxSpinDoubleEvent event( wxEVT_COMMAND_SPINCTRLDOUBLE_UPDATED, win->GetId());
+        event.SetEventObject( win );
+        event.SetValue(win->m_value);
+        event.SetString(GTK_ENTRY(spinbutton)->text);
+        win->HandleWindowEvent( event );
+    }

 }
 }
 
 }
 }
 


@@ -67,147 +73,155 @@ static void gtk_spinctrl_callback( GtkWidget *WXUNUSED(widget), wxSpinCtrl *win
 
 extern "C" {
 static void
 
 extern "C" {
 static void

-gtk_spinctrl_text_changed_callback( GtkWidget *WXUNUSED(widget), wxSpinCtrl *win )
+gtk_changed(GtkSpinButton* spinbutton, wxSpinCtrl* win)

 {
 {

-    if (!win->m_hasVMT) return;
-
-    if (g_isIdle)
-        wxapp_install_idle_handler();
+    if (!win->m_hasVMT)
+        return;

 
     wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, win->GetId() );
     event.SetEventObject( win );
 
     wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, win->GetId() );
     event.SetEventObject( win );

+    event.SetString( GTK_ENTRY(spinbutton)->text );

 
     // see above
 
     // see above

-    event.SetInt( (int)ceil(win->m_adjust->value) );
-    win->GetEventHandler()->ProcessEvent( event );
+    event.SetInt((int)win->m_value);
+    win->HandleWindowEvent( event );

 }
 }
 
 //-----------------------------------------------------------------------------
 }
 }
 
 //-----------------------------------------------------------------------------

-// wxSpinCtrl
+// wxSpinCtrlGTKBase

 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxSpinCtrl,wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxSpinCtrlGTKBase, wxSpinCtrlBase)

 
 

-BEGIN_EVENT_TABLE(wxSpinCtrl, wxControl)
-    EVT_CHAR(wxSpinCtrl::OnChar)
+BEGIN_EVENT_TABLE(wxSpinCtrlGTKBase, wxSpinCtrlBase)
+    EVT_CHAR(wxSpinCtrlGTKBase::OnChar)

 END_EVENT_TABLE()
 
 END_EVENT_TABLE()
 

-bool wxSpinCtrl::Create(wxWindow *parent, wxWindowID id,
+bool wxSpinCtrlGTKBase::Create(wxWindow *parent, wxWindowID id,

                         const wxString& value,
                         const wxPoint& pos,  const wxSize& size,
                         long style,
                         const wxString& value,
                         const wxPoint& pos,  const wxSize& size,
                         long style,

-                        int min, int max, int initial,
+                        double min, double max, double initial, double inc,

                         const wxString& name)
 {
                         const wxString& name)
 {

-    m_needParent = true;
-    m_acceptsFocus = true;
-

     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, wxDefaultValidator, name ))
     {
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, wxDefaultValidator, name ))
     {

-        wxFAIL_MSG( wxT("wxSpinCtrl creation failed") );
+        wxFAIL_MSG( wxT("wxSpinCtrlGTKBase creation failed") );

         return false;
     }
 
         return false;
     }
 

-    m_oldPos = initial;
+    m_widget = gtk_spin_button_new_with_range(min, max, inc);
+    g_object_ref(m_widget);

 
 

-    m_adjust = (GtkAdjustment*) gtk_adjustment_new( initial, min, max, 1.0, 5.0, 0.0);
-
-    m_widget = gtk_spin_button_new( m_adjust, 1, 0 );
+    gtk_spin_button_set_value( GTK_SPIN_BUTTON(m_widget), initial);
+    m_value = gtk_spin_button_get_value( GTK_SPIN_BUTTON(m_widget));

 
     gtk_spin_button_set_wrap( GTK_SPIN_BUTTON(m_widget),
                               (int)(m_windowStyle & wxSP_WRAP) );
 
 
     gtk_spin_button_set_wrap( GTK_SPIN_BUTTON(m_widget),
                               (int)(m_windowStyle & wxSP_WRAP) );
 

-    GtkEnableEvents();
+    g_signal_connect_after(m_widget, "value_changed", G_CALLBACK(gtk_value_changed), this);
+    g_signal_connect_after(m_widget, "changed", G_CALLBACK(gtk_changed), this);

 
     m_parent->DoAddChild( this );
 
     PostCreation(size);
 
 
     m_parent->DoAddChild( this );
 
     PostCreation(size);
 

-    SetValue( value );
+    if (!value.empty())
+    {
+        SetValue(value);
+    }

 
     return true;
 }
 
 
     return true;
 }
 

-void wxSpinCtrl::GtkDisableEvents()
+double wxSpinCtrlGTKBase::DoGetValue() const

 {
 {

-    g_signal_handlers_disconnect_by_func (m_adjust,
-                                          (gpointer) gtk_spinctrl_callback,
-                                          this);
-    g_signal_handlers_disconnect_by_func (m_widget,
-                                          (gpointer) gtk_spinctrl_text_changed_callback,
-                                          this);
-}
+    wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );

 
 

-void wxSpinCtrl::GtkEnableEvents()
-{
-    g_signal_connect (m_adjust, "value_changed",
-                      G_CALLBACK (gtk_spinctrl_callback),
-                      this);
-    g_signal_connect (m_widget, "changed",
-                      G_CALLBACK (gtk_spinctrl_text_changed_callback),
-                      this);
+    GtkDisableEvents();
+    gtk_spin_button_update( GTK_SPIN_BUTTON(m_widget) );
+    const_cast<wxSpinCtrlGTKBase*>(this)->m_value =
+        gtk_spin_button_get_value(GTK_SPIN_BUTTON(m_widget));
+    GtkEnableEvents();
+
+    return m_value;

 }
 
 }
 

-int wxSpinCtrl::GetMin() const
+double wxSpinCtrlGTKBase::DoGetMin() const

 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 
 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 

-    return (int)ceil(m_adjust->lower);
+    double min = 0;
+    gtk_spin_button_get_range( GTK_SPIN_BUTTON(m_widget), &min, NULL);
+    return min;

 }
 
 }
 

-int wxSpinCtrl::GetMax() const
+double wxSpinCtrlGTKBase::DoGetMax() const

 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 
 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 

-    return (int)ceil(m_adjust->upper);
+    double max = 0;
+    gtk_spin_button_get_range( GTK_SPIN_BUTTON(m_widget), NULL, &max);
+    return max;

 }
 
 }
 

-int wxSpinCtrl::GetValue() const
+double wxSpinCtrlGTKBase::DoGetIncrement() const

 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 
 {
     wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") );
 

-    gtk_spin_button_update( GTK_SPIN_BUTTON(m_widget) );
+    double inc = 0;
+    gtk_spin_button_get_increments( GTK_SPIN_BUTTON(m_widget), NULL, &inc);
+    return inc;
+}
+
+bool wxSpinCtrlGTKBase::GetSnapToTicks() const
+{
+    wxCHECK_MSG( m_widget, 0, "invalid spin button" );

 
 

-    return (int)ceil(m_adjust->value);
+    return gtk_spin_button_get_snap_to_ticks( GTK_SPIN_BUTTON(m_widget) );

 }
 
 }
 

-void wxSpinCtrl::SetValue( const wxString& value )
+void wxSpinCtrlGTKBase::SetValue( const wxString& value )

 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 
 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 

-    int n;
-    if ( (wxSscanf(value, wxT("%d"), &n) == 1) )
-    {
-        // a number - set it
-        SetValue(n);
-    }
-    else
+    double n;
+    if ( wxSscanf(value, "%lg", &n) == 1 )

     {
     {

-        // invalid number - set text as is (wxMSW compatible)
-        GtkDisableEvents();
-        gtk_entry_set_text( GTK_ENTRY(m_widget), wxGTK_CONV( value ) );
-        GtkEnableEvents();
+        // a number - set it, let DoSetValue round for int value
+        DoSetValue(n);
+        return;

     }
     }

+
+    // invalid number - set text as is (wxMSW compatible)
+    GtkDisableEvents();
+    gtk_entry_set_text( GTK_ENTRY(m_widget), wxGTK_CONV( value ) );
+    GtkEnableEvents();

 }
 
 }
 

-void wxSpinCtrl::SetValue( int value )
+void wxSpinCtrlGTKBase::DoSetValue( double value )

 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 
 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 

-    float fpos = (float)value;
-    m_oldPos = fpos;
-    if (fabs(fpos-m_adjust->value) < sensitivity) return;
-
-    m_adjust->value = fpos;
+    if (wxIsKindOf(this, wxSpinCtrl))
+        value = int(value + 0.5);

 
     GtkDisableEvents();
 
     GtkDisableEvents();

-    g_signal_emit_by_name (m_adjust, "value_changed");
+    gtk_spin_button_set_value( GTK_SPIN_BUTTON(m_widget), value);
+    m_value = gtk_spin_button_get_value( GTK_SPIN_BUTTON(m_widget));

     GtkEnableEvents();
 }
 
     GtkEnableEvents();
 }
 

-void wxSpinCtrl::SetSelection(long from, long to)
+void wxSpinCtrlGTKBase::SetSnapToTicks(bool snap_to_ticks)
+{
+    wxCHECK_RET( (m_widget != NULL), "invalid spin button" );
+
+    gtk_spin_button_set_snap_to_ticks( GTK_SPIN_BUTTON(m_widget), snap_to_ticks);
+}
+
+void wxSpinCtrlGTKBase::SetSelection(long from, long to)

 {
     // translate from wxWidgets conventions to GTK+ ones: (-1, -1) means the
     // entire range
 {
     // translate from wxWidgets conventions to GTK+ ones: (-1, -1) means the
     // entire range


@@ -220,38 +234,51 @@ void wxSpinCtrl::SetSelection(long from, long to)
     gtk_editable_select_region( GTK_EDITABLE(m_widget), (gint)from, (gint)to );
 }
 
     gtk_editable_select_region( GTK_EDITABLE(m_widget), (gint)from, (gint)to );
 }
 

-void wxSpinCtrl::SetRange(int minVal, int maxVal)
+void wxSpinCtrlGTKBase::DoSetRange(double minVal, double maxVal)

 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 
 {
     wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") );
 

-    float fmin = (float)minVal;
-    float fmax = (float)maxVal;
+    GtkDisableEvents();
+    gtk_spin_button_set_range( GTK_SPIN_BUTTON(m_widget), minVal, maxVal);
+    m_value = gtk_spin_button_get_value(GTK_SPIN_BUTTON(m_widget));
+    GtkEnableEvents();
+}

 
 

-    if ((fabs(fmin-m_adjust->lower) < sensitivity) &&
-        (fabs(fmax-m_adjust->upper) < sensitivity))
-    {
-        return;
-    }
+void wxSpinCtrlGTKBase::DoSetIncrement(double inc)
+{
+    wxCHECK_RET( m_widget, "invalid spin button" );

 
 

-    m_adjust->lower = fmin;
-    m_adjust->upper = fmax;
+    GtkDisableEvents();
+    gtk_spin_button_set_increments( GTK_SPIN_BUTTON(m_widget), inc, 10*inc);
+    m_value = gtk_spin_button_get_value(GTK_SPIN_BUTTON(m_widget));
+    GtkEnableEvents();
+}
+
+void wxSpinCtrlGTKBase::GtkDisableEvents() const
+{
+    g_signal_handlers_block_by_func( m_widget,
+        (gpointer)gtk_value_changed, (void*) this);
+
+    g_signal_handlers_block_by_func(m_widget,
+        (gpointer)gtk_changed, (void*) this);
+}

 
 

-    g_signal_emit_by_name (m_adjust, "changed");
+void wxSpinCtrlGTKBase::GtkEnableEvents() const
+{
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtk_value_changed, (void*) this);

 
 

-    // these two calls are required due to some bug in GTK
-    Refresh();
-    SetFocus();
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtk_changed, (void*) this);

 }
 
 }
 

-void wxSpinCtrl::OnChar( wxKeyEvent &event )
+void wxSpinCtrlGTKBase::OnChar( wxKeyEvent &event )

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid spin ctrl") );
 
     if (event.GetKeyCode() == WXK_RETURN)
     {
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid spin ctrl") );
 
     if (event.GetKeyCode() == WXK_RETURN)
     {

-        wxWindow *top_frame = m_parent;
-        while (top_frame->GetParent() && !(top_frame->IsTopLevel()))
-            top_frame = top_frame->GetParent();
+        wxWindow *top_frame = wxGetTopLevelParent(m_parent);

 
         if ( GTK_IS_WINDOW(top_frame->m_widget) )
         {
 
         if ( GTK_IS_WINDOW(top_frame->m_widget) )
         {


@@ -276,37 +303,63 @@ void wxSpinCtrl::OnChar( wxKeyEvent &event )
         GtkSpinButton *gsb = GTK_SPIN_BUTTON(m_widget);
         wxString val = wxGTK_CONV_BACK( gtk_entry_get_text( &gsb->entry ) );
         evt.SetString( val );
         GtkSpinButton *gsb = GTK_SPIN_BUTTON(m_widget);
         wxString val = wxGTK_CONV_BACK( gtk_entry_get_text( &gsb->entry ) );
         evt.SetString( val );

-        if (GetEventHandler()->ProcessEvent(evt)) return;
+        if (HandleWindowEvent(evt)) return;

     }
 
     event.Skip();
 }
 
     }
 
     event.Skip();
 }
 

-bool wxSpinCtrl::IsOwnGtkWindow( GdkWindow *window )
+GdkWindow *wxSpinCtrlGTKBase::GTKGetWindow(wxArrayGdkWindows& windows) const

 {
 {

-    if (GTK_SPIN_BUTTON(m_widget)->entry.text_area == window) return true;
+    GtkSpinButton* spinbutton = GTK_SPIN_BUTTON(m_widget);

 
 

-    if (GTK_SPIN_BUTTON(m_widget)->panel == window) return true;
+    windows.push_back(spinbutton->entry.text_area);
+    windows.push_back(spinbutton->panel);

 
 

-    return false;
+    return NULL;

 }
 
 }
 

-wxSize wxSpinCtrl::DoGetBestSize() const
+wxSize wxSpinCtrlGTKBase::DoGetBestSize() const

 {
     wxSize ret( wxControl::DoGetBestSize() );
 {
     wxSize ret( wxControl::DoGetBestSize() );

-    wxSize best(95, ret.y);
+    wxSize best(95, ret.y); // FIXME: 95?

     CacheBestSize(best);
     return best;
 }
 
 // static
 wxVisualAttributes
     CacheBestSize(best);
     return best;
 }
 
 // static
 wxVisualAttributes

-wxSpinCtrl::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+wxSpinCtrlGTKBase::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))

 {
     // TODO: overload to accept functions like gtk_spin_button_new?
     // Until then use a similar type
     return GetDefaultAttributesFromGTKWidget(gtk_entry_new, true);
 }
 
 {
     // TODO: overload to accept functions like gtk_spin_button_new?
     // Until then use a similar type
     return GetDefaultAttributesFromGTKWidget(gtk_entry_new, true);
 }
 

-#endif
-   // wxUSE_SPINCTRL
+//-----------------------------------------------------------------------------
+// wxSpinCtrl
+//-----------------------------------------------------------------------------
+
+IMPLEMENT_DYNAMIC_CLASS(wxSpinCtrl, wxSpinCtrlGTKBase)
+
+//-----------------------------------------------------------------------------
+// wxSpinCtrlDouble
+//-----------------------------------------------------------------------------
+
+IMPLEMENT_DYNAMIC_CLASS(wxSpinCtrlDouble, wxSpinCtrlGTKBase)
+
+unsigned wxSpinCtrlDouble::GetDigits() const
+{
+    wxCHECK_MSG( m_widget, 0, "invalid spin button" );
+
+    return gtk_spin_button_get_digits( GTK_SPIN_BUTTON(m_widget) );
+}
+
+void wxSpinCtrlDouble::SetDigits(unsigned digits)
+{
+    wxCHECK_RET( m_widget, "invalid spin button" );
+
+    gtk_spin_button_set_digits( GTK_SPIN_BUTTON(m_widget), digits);
+}
+
+#endif // wxUSE_SPINCTRL