[ 1579793 ] numerous bug fixes when mask is used

[wxWidgets.git] / src / gtk / bmpbuttn.cpp

diff --git a/src/gtk/bmpbuttn.cpp b/src/gtk/bmpbuttn.cpp
index c46e779f20df1bd9887daf2c7f290916aeb7a528..656db887dced84958755f9ca1b0fcfdb866f774e 100644 (file)
--- a/src/gtk/bmpbuttn.cpp
+++ b/src/gtk/bmpbuttn.cpp
@@ -1,20 +1,20 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        bmpbuttn.cpp
+// Name:        src/gtk/bmpbuttn.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "bmpbuttn.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
+#if wxUSE_BMPBUTTON

 
 #include "wx/bmpbuttn.h"
 
 
 #include "wx/bmpbuttn.h"
 

-#include "gdk/gdk.h"
-#include "gtk/gtk.h"
+#include "wx/gtk/private.h"

 
 //-----------------------------------------------------------------------------
 // classes
 
 //-----------------------------------------------------------------------------
 // classes


@@ -22,13 +22,6 @@
 
 class wxBitmapButton;
 
 
 class wxBitmapButton;
 

-//-----------------------------------------------------------------------------
-// idle system
-//-----------------------------------------------------------------------------
-
-extern void wxapp_install_idle_handler();
-extern bool g_isIdle;
-

 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------


@@ -39,272 +32,246 @@ extern bool   g_blockEventsOnDrag;
 // "clicked"
 //-----------------------------------------------------------------------------
 
 // "clicked"
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void gtk_bmpbutton_clicked_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {
 static void gtk_bmpbutton_clicked_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {

-    if (g_isIdle) wxapp_install_idle_handler();
+    if (g_isIdle)
+        wxapp_install_idle_handler();

 
 

-    if (!button->HasVMT()) return;
+    if (!button->m_hasVMT) return;

     if (g_blockEventsOnDrag) return;
     if (g_blockEventsOnDrag) return;

-  
+

     wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, button->GetId());
     event.SetEventObject(button);
     button->GetEventHandler()->ProcessEvent(event);
 }
     wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, button->GetId());
     event.SetEventObject(button);
     button->GetEventHandler()->ProcessEvent(event);
 }

+}

 
 //-----------------------------------------------------------------------------
 // "enter"
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 // "enter"
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void gtk_bmpbutton_enter_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {
 static void gtk_bmpbutton_enter_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {

-    if (!button->HasVMT()) return;
+    if (!button->m_hasVMT) return;

     if (g_blockEventsOnDrag) return;
 
     if (g_blockEventsOnDrag) return;
 

-    button->HasFocus(); 
+    button->HasFocus();
+}

 }
 
 //-----------------------------------------------------------------------------
 // "leave"
 //-----------------------------------------------------------------------------
 
 }
 
 //-----------------------------------------------------------------------------
 // "leave"
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void gtk_bmpbutton_leave_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {
 static void gtk_bmpbutton_leave_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {

-    if (!button->HasVMT()) return;
+    if (!button->m_hasVMT) return;

     if (g_blockEventsOnDrag) return;
 
     if (g_blockEventsOnDrag) return;
 

-    button->NotFocus(); 
+    button->NotFocus();
+}

 }
 
 //-----------------------------------------------------------------------------
 // "pressed"
 //-----------------------------------------------------------------------------
 
 }
 
 //-----------------------------------------------------------------------------
 // "pressed"
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void gtk_bmpbutton_press_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {
 static void gtk_bmpbutton_press_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {

-    if (!button->HasVMT()) return;
+    if (!button->m_hasVMT) return;

     if (g_blockEventsOnDrag) return;
 
     if (g_blockEventsOnDrag) return;
 

-    button->StartSelect(); 
+    button->StartSelect();
+}

 }
 
 //-----------------------------------------------------------------------------
 // "released"
 //-----------------------------------------------------------------------------
 
 }
 
 //-----------------------------------------------------------------------------
 // "released"
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void gtk_bmpbutton_release_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {
 static void gtk_bmpbutton_release_callback( GtkWidget *WXUNUSED(widget), wxBitmapButton *button )
 {

-    if (!button->HasVMT()) return;
+    if (!button->m_hasVMT) return;

     if (g_blockEventsOnDrag) return;
 
     if (g_blockEventsOnDrag) return;
 

-    button->EndSelect(); 
+    button->EndSelect();
+}

 }
 
 //-----------------------------------------------------------------------------
 // wxBitmapButton
 //-----------------------------------------------------------------------------
 
 }
 
 //-----------------------------------------------------------------------------
 // wxBitmapButton
 //-----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxBitmapButton,wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxBitmapButton,wxButton)

 
 

-wxBitmapButton::wxBitmapButton()
+void wxBitmapButton::Init()

 {
 {

+    m_hasFocus =
+    m_isSelected = false;

 }
 
 }
 

-bool wxBitmapButton::Create( wxWindow *parent, wxWindowID id, const wxBitmap &bitmap,
-                             const wxPoint &pos, const wxSize &size, 
-                             long style, const wxValidator& validator, const wxString &name )
+bool wxBitmapButton::Create( wxWindow *parent,
+                             wxWindowID id,
+                             const wxBitmap& bitmap,
+                             const wxPoint& pos,
+                             const wxSize& size,
+                             long style,
+                             const wxValidator& validator,
+                             const wxString &name )

 {
 {

-    m_needParent = TRUE;
-    m_acceptsFocus = TRUE;
-  
-    wxSize newSize = size;
-
-    PreCreation( parent, id, pos, newSize, style, name );
-  
-    SetValidator( validator );
-
-    m_bitmap   = bitmap;
-    m_disabled = bitmap;
-    m_focus    = bitmap;
-    m_selected = bitmap;
-  
-    m_label = "";
-  
+    m_needParent = true;
+    m_acceptsFocus = true;
+
+    if (!PreCreation( parent, pos, size ) ||
+        !CreateBase( parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG( wxT("wxBitmapButton creation failed") );
+        return false;
+    }
+
+    m_bmpNormal = bitmap;
+

     m_widget = gtk_button_new();
 
     m_widget = gtk_button_new();
 

-#if (GTK_MINOR_VERSION > 0)    

     if (style & wxNO_BORDER)
        gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );
     if (style & wxNO_BORDER)
        gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );

-#endif

 
 

-    if (m_bitmap.Ok())
+    if (m_bmpNormal.Ok())

     {
     {

-        GdkBitmap *mask = (GdkBitmap *) NULL;
-        if (m_bitmap.GetMask()) mask = m_bitmap.GetMask()->GetBitmap();
-        GtkWidget *pixmap = gtk_pixmap_new( m_bitmap.GetPixmap(), mask );
-    
-        gtk_widget_show( pixmap );
-        gtk_container_add( GTK_CONTAINER(m_widget), pixmap );
+        OnSetBitmap();

     }
     }

-  
-    int border = 10;
-    if (style & wxNO_BORDER) border = 4;
-    if (newSize.x == -1) newSize.x = m_bitmap.GetWidth()+border;
-    if (newSize.y == -1) newSize.y = m_bitmap.GetHeight()+border;
-    SetSize( newSize.x, newSize.y );
-  
-    gtk_signal_connect( GTK_OBJECT(m_widget), "clicked", 
-      GTK_SIGNAL_FUNC(gtk_bmpbutton_clicked_callback), (gpointer*)this );
-
-    gtk_signal_connect( GTK_OBJECT(m_widget), "enter", 
-      GTK_SIGNAL_FUNC(gtk_bmpbutton_enter_callback), (gpointer*)this );
-    gtk_signal_connect( GTK_OBJECT(m_widget), "leave", 
-      GTK_SIGNAL_FUNC(gtk_bmpbutton_leave_callback), (gpointer*)this );
-    gtk_signal_connect( GTK_OBJECT(m_widget), "pressed", 
-      GTK_SIGNAL_FUNC(gtk_bmpbutton_press_callback), (gpointer*)this );
-    gtk_signal_connect( GTK_OBJECT(m_widget), "released", 
-      GTK_SIGNAL_FUNC(gtk_bmpbutton_release_callback), (gpointer*)this );
- 
-    m_parent->AddChild( this );
-
-    (m_parent->m_insertCallback)( m_parent, this );
-  
-    PostCreation();
-  
-    SetBackgroundColour( parent->GetBackgroundColour() );
-
-    Show( TRUE );
-    
-    return TRUE;
+
+    g_signal_connect_after (m_widget, "clicked",
+                            G_CALLBACK (gtk_bmpbutton_clicked_callback),
+                            this);
+
+    g_signal_connect (m_widget, "enter",
+                      G_CALLBACK (gtk_bmpbutton_enter_callback), this);
+    g_signal_connect (m_widget, "leave",
+                      G_CALLBACK (gtk_bmpbutton_leave_callback), this);
+    g_signal_connect (m_widget, "pressed",
+                      G_CALLBACK (gtk_bmpbutton_press_callback), this);
+    g_signal_connect (m_widget, "released",
+                      G_CALLBACK (gtk_bmpbutton_release_callback), this);
+
+    m_parent->DoAddChild( this );
+
+    PostCreation(size);
+
+    return true;

 }
 }

-      
+

 void wxBitmapButton::SetDefault()
 {
     GTK_WIDGET_SET_FLAGS( m_widget, GTK_CAN_DEFAULT );
     gtk_widget_grab_default( m_widget );
 void wxBitmapButton::SetDefault()
 {
     GTK_WIDGET_SET_FLAGS( m_widget, GTK_CAN_DEFAULT );
     gtk_widget_grab_default( m_widget );

-    
+

     SetSize( m_x, m_y, m_width, m_height );
 }
 
 void wxBitmapButton::SetLabel( const wxString &label )
 {
     SetSize( m_x, m_y, m_width, m_height );
 }
 
 void wxBitmapButton::SetLabel( const wxString &label )
 {

-    wxCHECK_RET( m_widget != NULL, _T("invalid button") );
+    wxCHECK_RET( m_widget != NULL, wxT("invalid button") );

 
     wxControl::SetLabel( label );
 }
 
 
     wxControl::SetLabel( label );
 }
 

-wxString wxBitmapButton::GetLabel() const
+void wxBitmapButton::DoApplyWidgetStyle(GtkRcStyle *style)

 {
 {

-    wxCHECK_MSG( m_widget != NULL, _T(""), _T("invalid button") );
+    if (!GTK_BIN(m_widget)->child)
+        return;

 
 

-    return wxControl::GetLabel();
+    wxButton::DoApplyWidgetStyle(style);

 }
 
 }
 

-void wxBitmapButton::ApplyWidgetStyle()
+void wxBitmapButton::OnSetBitmap()

 {
 {

-}
+    wxCHECK_RET( m_widget != NULL, wxT("invalid bitmap button") );

 
 

-void wxBitmapButton::SetBitmap()
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid button") );
+    InvalidateBestSize();

 
     wxBitmap the_one;
 
     wxBitmap the_one;

-  
-    if (!m_isEnabled) 
-        the_one = m_disabled;
-    else 
-    {
-        if (m_isSelected) 
-       {
-           the_one = m_selected;
-       }
-        else 
-       {
-            if (m_hasFocus) 
-               the_one = m_focus;
-            else 
-               the_one = m_bitmap;
-        }
-    }
-
-    if (!the_one.Ok()) the_one = m_bitmap;
+    if (!m_isEnabled)
+        the_one = m_bmpDisabled;
+    else if (m_isSelected)
+        the_one = m_bmpSelected;
+    else if (m_hasFocus)
+        the_one = m_bmpFocus;
+    else
+        the_one = m_bmpNormal;
+
+    if (!the_one.Ok()) the_one = m_bmpNormal;

     if (!the_one.Ok()) return;
     if (!the_one.Ok()) return;

-  
-    GtkButton *bin = GTK_BUTTON( m_widget );
-    GtkPixmap *g_pixmap = GTK_PIXMAP( bin->child );
-  
+

     GdkBitmap *mask = (GdkBitmap *) NULL;
     if (the_one.GetMask()) mask = the_one.GetMask()->GetBitmap();
     GdkBitmap *mask = (GdkBitmap *) NULL;
     if (the_one.GetMask()) mask = the_one.GetMask()->GetBitmap();

-  
-    gtk_pixmap_set( g_pixmap, the_one.GetPixmap(), mask );
-}
-
-void wxBitmapButton::SetBitmapDisabled( const wxBitmap& bitmap ) 
-{
-  wxCHECK_RET( m_widget != NULL, _T("invalid button") );
-
-  if ( ! m_disabled.Ok() ) return;
-  m_disabled = bitmap;
-
-  SetBitmap();
-}

 
 

-void wxBitmapButton::SetBitmapFocus( const wxBitmap& bitmap ) 
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid button") );
+    GtkWidget *child = GTK_BIN(m_widget)->child;
+    if (child == NULL)
+    {
+        // initial bitmap
+        GtkWidget *pixmap;

 
 

-    if ( ! m_focus.Ok() ) return;
-    m_focus = bitmap;
+        if (the_one.HasPixbuf())
+            pixmap = gtk_image_new_from_pixbuf(the_one.GetPixbuf());
+        else
+            pixmap = gtk_image_new_from_pixmap(the_one.GetPixmap(), mask);

 
 

-    SetBitmap();
+        gtk_widget_show(pixmap);
+        gtk_container_add(GTK_CONTAINER(m_widget), pixmap);
+    }
+    else
+    {   // subsequent bitmaps
+        GtkImage *pixmap = GTK_IMAGE(child);
+        if (the_one.HasPixbuf())
+            gtk_image_set_from_pixbuf(pixmap, the_one.GetPixbuf());
+        else
+            gtk_image_set_from_pixmap(pixmap, the_one.GetPixmap(), mask);
+    }

 }
 
 }
 

-void wxBitmapButton::SetBitmapLabel( const wxBitmap& bitmap )
+wxSize wxBitmapButton::DoGetBestSize() const

 {
 {

-    wxCHECK_RET( m_widget != NULL, _T("invalid button") );
-
-    if (!m_bitmap.Ok()) return;
-    m_bitmap = bitmap;
-  
-    SetBitmap();
+    return wxControl::DoGetBestSize();

 }
 
 }
 

-void wxBitmapButton::SetBitmapSelected( const wxBitmap& bitmap )
+bool wxBitmapButton::Enable( bool enable )

 {
 {

-    wxCHECK_RET( m_widget != NULL, _T("invalid button") );
+    if ( !wxWindow::Enable(enable) )
+        return false;

 
 

-    if ( ! m_selected.Ok() ) return;
-    m_selected = bitmap;
+    OnSetBitmap();

 
 

-    SetBitmap();
-}
-
-void wxBitmapButton::Enable( const bool enable )
-{
-    wxWindow::Enable(enable);
-
-    SetBitmap();  
+    return true;

 }
 
 void wxBitmapButton::HasFocus()
 {
 }
 
 void wxBitmapButton::HasFocus()
 {

-    m_hasFocus = TRUE;
-    SetBitmap();
+    m_hasFocus = true;
+    OnSetBitmap();

 }
 
 void wxBitmapButton::NotFocus()
 {
 }
 
 void wxBitmapButton::NotFocus()
 {

-    m_hasFocus = FALSE;
-    SetBitmap();
+    m_hasFocus = false;
+    OnSetBitmap();

 }
 
 void wxBitmapButton::StartSelect()
 {
 }
 
 void wxBitmapButton::StartSelect()
 {

-    m_isSelected = TRUE;
-    SetBitmap();
+    m_isSelected = true;
+    OnSetBitmap();

 }
 
 void wxBitmapButton::EndSelect()
 {
 }
 
 void wxBitmapButton::EndSelect()
 {

-    m_isSelected = FALSE;
-    SetBitmap();
+    m_isSelected = false;
+    OnSetBitmap();

 }
 }

+
+#endif // wxUSE_BMPBUTTON