Whitespaces, tabs and fix to the lack of empty line at end.

[wxWidgets.git] / src / motif / choice.cpp

diff --git a/src/motif/choice.cpp b/src/motif/choice.cpp
index 0b6a7b731475fc857e22af88ef70135b1323c003..87e7eb7880e926bf2a2f7430e8416644d0ed8b40 100644 (file)
--- a/src/motif/choice.cpp
+++ b/src/motif/choice.cpp
@@ -6,13 +6,16 @@
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "choice.h"
 #endif
 
 #pragma implementation "choice.h"
 #endif
 

+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+

 #ifdef __VMS
 #define XtDisplay XTDISPLAY
 #define XtParent XTPARENT
 #ifdef __VMS
 #define XtDisplay XTDISPLAY
 #define XtParent XTPARENT


@@ -20,8 +23,11 @@
 
 #include "wx/defs.h"
 
 
 #include "wx/defs.h"
 

+#if wxUSE_CHOICE
+

 #include "wx/choice.h"
 #include "wx/utils.h"
 #include "wx/choice.h"
 #include "wx/utils.h"

+#include "wx/arrstr.h"

 
 #ifdef __VMS__
 #pragma message disable nosimpint
 
 #ifdef __VMS__
 #pragma message disable nosimpint


@@ -36,6 +42,10 @@
 
 #include "wx/motif/private.h"
 
 
 #include "wx/motif/private.h"
 

+#define WIDTH_OVERHEAD 48
+#define WIDTH_OVERHEAD_SUBTRACT 40
+#define HEIGHT_OVERHEAD 15
+

 IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)
 
 void wxChoiceCallback (Widget w, XtPointer clientData,
 IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControl)
 
 void wxChoiceCallback (Widget w, XtPointer clientData,


@@ -48,8 +58,6 @@ wxChoice::wxChoice()
 
 void wxChoice::Init()
 {
 
 void wxChoice::Init()
 {

-    InitBase();
-

     m_noStrings = 0;
     m_buttonWidget = (WXWidget) 0;
     m_menuWidget = (WXWidget) 0;
     m_noStrings = 0;
     m_buttonWidget = (WXWidget) 0;
     m_menuWidget = (WXWidget) 0;


@@ -65,7 +73,7 @@ bool wxChoice::Create(wxWindow *parent, wxWindowID id,
                       const wxString& name)
 {
     if ( !CreateControl(parent, id, pos, size, style, validator, name) )
                       const wxString& name)
 {
     if ( !CreateControl(parent, id, pos, size, style, validator, name) )

-        return FALSE;
+        return false;

 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 
 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 


@@ -75,6 +83,8 @@ bool wxChoice::Create(wxWindow *parent, wxWindowID id,
         XmNmarginWidth, 0,
         XmNpacking, XmPACK_TIGHT,
         XmNorientation, XmHORIZONTAL,
         XmNmarginWidth, 0,
         XmNpacking, XmPACK_TIGHT,
         XmNorientation, XmHORIZONTAL,

+        XmNresizeWidth, False,
+        XmNresizeHeight, False,

         NULL);
 
     XtVaSetValues ((Widget) m_formWidget, XmNspacing, 0, NULL);
         NULL);
 
     XtVaSetValues ((Widget) m_formWidget, XmNspacing, 0, NULL);


@@ -130,14 +140,26 @@ bool wxChoice::Create(wxWindow *parent, wxWindowID id,
 
     XtVaSetValues((Widget) m_formWidget, XmNresizePolicy, XmRESIZE_NONE, NULL);
 
 
     XtVaSetValues((Widget) m_formWidget, XmNresizePolicy, XmRESIZE_NONE, NULL);
 

-    ChangeFont(FALSE);
+    ChangeFont(false);
+    ChangeBackgroundColour();

 
     AttachWidget (parent, m_buttonWidget, m_formWidget,
                   pos.x, pos.y, bestSize.x, bestSize.y);
 
 
     AttachWidget (parent, m_buttonWidget, m_formWidget,
                   pos.x, pos.y, bestSize.x, bestSize.y);
 

-    ChangeBackgroundColour();
+    return true;
+}

 
 

-    return TRUE;
+bool wxChoice::Create(wxWindow *parent, wxWindowID id,
+                      const wxPoint& pos,
+                      const wxSize& size,
+                      const wxArrayString& choices,
+                      long style,
+                      const wxValidator& validator,
+                      const wxString& name)
+{
+    wxCArrayString chs(choices);
+    return Create(parent, id, pos, size, chs.GetCount(), chs.GetStrings(),
+                  style, validator, name);

 }
 
 wxChoice::~wxChoice()
 }
 
 wxChoice::~wxChoice()


@@ -174,14 +196,14 @@ int wxChoice::DoAppend(const wxString& item)
 #endif
         NULL);
 
 #endif
         NULL);
 

-    DoChangeBackgroundColour((WXWidget) w, m_backgroundColour);
+    wxDoChangeBackgroundColour((WXWidget) w, m_backgroundColour);

 
     if( m_font.Ok() )
         wxDoChangeFont( w, m_font );
 
     m_widgetArray.Add(w);
 
 
     if( m_font.Ok() )
         wxDoChangeFont( w, m_font );
 
     m_widgetArray.Add(w);
 

-    char mnem = wxFindMnemonic ((char*) (const char*) item);
+    char mnem = wxFindMnemonic (item);

     if (mnem != 0)
         XtVaSetValues (w, XmNmnemonic, mnem, NULL);
 
     if (mnem != 0)
         XtVaSetValues (w, XmNmnemonic, mnem, NULL);
 


@@ -204,12 +226,20 @@ int wxChoice::DoAppend(const wxString& item)
     return GetCount() - 1;
 }
 
     return GetCount() - 1;
 }
 

+int wxChoice::DoInsert(const wxString& item, int pos)
+{
+    wxCHECK_MSG(false, -1, wxT("insert not implemented"));
+
+//    wxCHECK_MSG((pos>=0) && (pos<=GetCount()), -1, wxT("invalid index"));
+//    if (pos == GetCount()) return DoAppend(item);
+}
+

 void wxChoice::Delete(int n)
 {
     Widget w = (Widget)m_widgetArray[n];
     XtRemoveCallback(w, XmNactivateCallback, (XtCallbackProc)wxChoiceCallback,
                      (XtPointer)this);
 void wxChoice::Delete(int n)
 {
     Widget w = (Widget)m_widgetArray[n];
     XtRemoveCallback(w, XmNactivateCallback, (XtCallbackProc)wxChoiceCallback,
                      (XtPointer)this);

-    m_stringList.DeleteNode(m_stringList.Item(n));
+    m_stringList.Erase(m_stringList.Item(n));

     m_widgetArray.RemoveAt(size_t(n));
     m_clientDataDict.Delete(n, HasClientObjectData());
 
     m_widgetArray.RemoveAt(size_t(n));
     m_clientDataDict.Delete(n, HasClientObjectData());
 


@@ -254,7 +284,7 @@ int wxChoice::GetSelection() const
     if (!s.IsEmpty())
     {
         int i = 0;
     if (!s.IsEmpty())
     {
         int i = 0;

-        for (wxStringListNode* node = m_stringList.GetFirst ();
+        for (wxStringList::compatibility_iterator node = m_stringList.GetFirst ();

              node; node = node->GetNext ())
         {
             if (wxStrcmp(node->GetData(), s.c_str()) == 0)
              node; node = node->GetNext ())
         {
             if (wxStrcmp(node->GetData(), s.c_str()) == 0)


@@ -272,9 +302,9 @@ int wxChoice::GetSelection() const
 
 void wxChoice::SetSelection(int n)
 {
 
 void wxChoice::SetSelection(int n)
 {

-    m_inSetValue = TRUE;
+    m_inSetValue = true;

 
 

-    wxStringListNode *node = m_stringList.Item(n);
+    wxStringList::compatibility_iterator node = m_stringList.Item(n);

     if (node)
     {
 #if 0
     if (node)
     {
 #if 0


@@ -299,13 +329,13 @@ void wxChoice::SetSelection(int n)
             XmNmenuHistory, (Widget) m_widgetArray[n], NULL);
 #endif
     }
             XmNmenuHistory, (Widget) m_widgetArray[n], NULL);
 #endif
     }

-    m_inSetValue = FALSE;
+    m_inSetValue = false;

 }
 
 int wxChoice::FindString(const wxString& s) const
 {
     int i = 0;
 }
 
 int wxChoice::FindString(const wxString& s) const
 {
     int i = 0;

-    for (wxStringListNode* node = m_stringList.GetFirst();
+    for (wxStringList::compatibility_iterator node = m_stringList.GetFirst();

          node; node = node->GetNext ())
     {
         if (s == node->GetData())
          node; node = node->GetNext ())
     {
         if (s == node->GetData())


@@ -314,12 +344,12 @@ int wxChoice::FindString(const wxString& s) const
         i++;
     }
 
         i++;
     }
 

-    return -1;
+    return wxNOT_FOUND;

 }
 
 wxString wxChoice::GetString(int n) const
 {
 }
 
 wxString wxChoice::GetString(int n) const
 {

-    wxStringListNode *node = m_stringList.Item(n);
+    wxStringList::compatibility_iterator node = m_stringList.Item(n);

     if (node)
         return node->GetData();
     else
     if (node)
         return node->GetData();
     else


@@ -359,7 +389,8 @@ void wxChoice::DoSetSize(int x, int y, int width, int height, int sizeFlags)
     if (managed)
         XtUnmanageChild ((Widget) m_formWidget);
 
     if (managed)
         XtUnmanageChild ((Widget) m_formWidget);
 

-    int actualWidth = width, actualHeight = height;
+    int actualWidth = width - WIDTH_OVERHEAD_SUBTRACT,
+        actualHeight = height - HEIGHT_OVERHEAD;

 
     if (width > -1)
     {
 
     if (width > -1)
     {


@@ -373,11 +404,13 @@ void wxChoice::DoSetSize(int x, int y, int width, int height, int sizeFlags)
     }
     if (height > -1)
     {
     }
     if (height > -1)
     {

+#if 0

         size_t i;
         for (i = 0; i < m_noStrings; i++)
             XtVaSetValues ((Widget) m_widgetArray[i],
                            XmNheight, actualHeight,
                            NULL);
         size_t i;
         for (i = 0; i < m_noStrings; i++)
             XtVaSetValues ((Widget) m_widgetArray[i],
                            XmNheight, actualHeight,
                            NULL);

+#endif

         XtVaSetValues ((Widget) m_buttonWidget, XmNheight, actualHeight,
             NULL);
     }
         XtVaSetValues ((Widget) m_buttonWidget, XmNheight, actualHeight,
             NULL);
     }


@@ -440,33 +473,33 @@ void wxChoice::ChangeFont(bool keepOriginalSize)
             XtVaSetValues( (Widget)m_widgetArray[i],
                            fontTag, fontType,
                            NULL );
             XtVaSetValues( (Widget)m_widgetArray[i],
                            fontTag, fontType,
                            NULL );

-        
+

         GetSize(& width1, & height1);
         if (keepOriginalSize && (width != width1 || height != height1))
         {
         GetSize(& width1, & height1);
         if (keepOriginalSize && (width != width1 || height != height1))
         {

-            SetSize(-1, -1, width, height);
+            SetSize(wxDefaultCoord, wxDefaultCoord, width, height);

         }
     }
 }
 
 void wxChoice::ChangeBackgroundColour()
 {
         }
     }
 }
 
 void wxChoice::ChangeBackgroundColour()
 {

-    DoChangeBackgroundColour(m_formWidget, m_backgroundColour);
-    DoChangeBackgroundColour(m_buttonWidget, m_backgroundColour);
-    DoChangeBackgroundColour(m_menuWidget, m_backgroundColour);
+    wxDoChangeBackgroundColour(m_formWidget, m_backgroundColour);
+    wxDoChangeBackgroundColour(m_buttonWidget, m_backgroundColour);
+    wxDoChangeBackgroundColour(m_menuWidget, m_backgroundColour);

     size_t i;
     for (i = 0; i < m_noStrings; i++)
     size_t i;
     for (i = 0; i < m_noStrings; i++)

-        DoChangeBackgroundColour(m_widgetArray[i], m_backgroundColour);
+        wxDoChangeBackgroundColour(m_widgetArray[i], m_backgroundColour);

 }
 
 void wxChoice::ChangeForegroundColour()
 {
 }
 
 void wxChoice::ChangeForegroundColour()
 {

-    DoChangeForegroundColour(m_formWidget, m_foregroundColour);
-    DoChangeForegroundColour(m_buttonWidget, m_foregroundColour);
-    DoChangeForegroundColour(m_menuWidget, m_foregroundColour);
+    wxDoChangeForegroundColour(m_formWidget, m_foregroundColour);
+    wxDoChangeForegroundColour(m_buttonWidget, m_foregroundColour);
+    wxDoChangeForegroundColour(m_menuWidget, m_foregroundColour);

     size_t i;
     for (i = 0; i < m_noStrings; i++)
     size_t i;
     for (i = 0; i < m_noStrings; i++)

-        DoChangeForegroundColour(m_widgetArray[i], m_foregroundColour);
+        wxDoChangeForegroundColour(m_widgetArray[i], m_foregroundColour);

 }
 
 int wxChoice::GetCount() const
 }
 
 int wxChoice::GetCount() const


@@ -476,7 +509,7 @@ int wxChoice::GetCount() const
 
 void wxChoice::DoSetItemClientData(int n, void* clientData)
 {
 
 void wxChoice::DoSetItemClientData(int n, void* clientData)
 {

-    m_clientDataDict.Set(n, (wxClientData*)clientData, FALSE);
+    m_clientDataDict.Set(n, (wxClientData*)clientData, false);

 }
 
 void* wxChoice::DoGetItemClientData(int n) const
 }
 
 void* wxChoice::DoGetItemClientData(int n) const


@@ -487,7 +520,7 @@ void* wxChoice::DoGetItemClientData(int n) const
 void wxChoice::DoSetItemClientObject(int n, wxClientData* clientData)
 {
     // don't delete, wxItemContainer does that for us
 void wxChoice::DoSetItemClientObject(int n, wxClientData* clientData)
 {
     // don't delete, wxItemContainer does that for us

-    m_clientDataDict.Set(n, clientData, FALSE);
+    m_clientDataDict.Set(n, clientData, false);

 }
 
 wxClientData* wxChoice::DoGetItemClientObject(int n) const
 }
 
 wxClientData* wxChoice::DoGetItemClientObject(int n) const


@@ -507,7 +540,7 @@ wxSize wxChoice::GetItemsSize() const
     // get my
     GetTextExtent( "|", &x, &my );
 
     // get my
     GetTextExtent( "|", &x, &my );
 

-    wxStringList::Node* curr = m_stringList.GetFirst();
+    wxStringList::compatibility_iterator curr = m_stringList.GetFirst();

     while( curr )
     {
         GetTextExtent( curr->GetData(), &x, &y );
     while( curr )
     {
         GetTextExtent( curr->GetData(), &x, &y );


@@ -523,6 +556,8 @@ wxSize wxChoice::DoGetBestSize() const
 {
     wxSize items = GetItemsSize();
     // FIXME arbitrary constants
 {
     wxSize items = GetItemsSize();
     // FIXME arbitrary constants

-    return wxSize( ( items.x ? items.x + 50 : 120 ),
-                     items.y + 15 );
+    return wxSize( ( items.x ? items.x + WIDTH_OVERHEAD : 120 ),
+                     items.y + HEIGHT_OVERHEAD );

 }
 }

+
+#endif // wxUSE_CHOICE