bool IsMask)
{
- wxCHECK_MSG( image, false, _T("invalid pointer in wxBMPHandler::SaveFile") );
+ wxCHECK_MSG( image, false, wxT("invalid pointer in wxBMPHandler::SaveFile") );
if ( !image->Ok() )
{
if ( verbose )
+ {
wxLogError(_("BMP: Couldn't save invalid image."));
+ }
return false;
}
)
{
if ( verbose )
+ {
wxLogError(_("BMP: wxImage doesn't have own wxPalette."));
+ }
return false;
}
bpp = 8;
// get the resolution from the image options or fall back to 72dpi standard
// for the BMP format if not specified
- wxUint32 hres = image->GetOptionInt(wxIMAGE_OPTION_RESOLUTIONX),
- vres = image->GetOptionInt(wxIMAGE_OPTION_RESOLUTIONY);
- switch ( image->GetOptionInt(wxIMAGE_OPTION_RESOLUTION) )
+ int hres, vres;
+ switch ( GetResolutionFromOptions(*image, &hres, &vres) )
{
default:
- wxFAIL_MSG( _T("unexpected image resolution units") );
+ wxFAIL_MSG( wxT("unexpected image resolution units") );
// fall through
case wxIMAGE_RESOLUTION_NONE:
case wxIMAGE_RESOLUTION_INCHES:
// convert resolution in inches to resolution in centimeters
- hres = (wxUint32)(10*mm2inches*hres);
- vres = (wxUint32)(10*mm2inches*vres);
+ hres = (int)(10*mm2inches*hres);
+ vres = (int)(10*mm2inches*vres);
// fall through to convert it to resolution in meters
case wxIMAGE_RESOLUTION_CM:
)
{
if (verbose)
+ {
wxLogError(_("BMP: Couldn't write the file (Bitmap) header."));
+ }
return false;
}
}
)
{
if (verbose)
+ {
wxLogError(_("BMP: Couldn't write the file (BitmapInfo) header."));
+ }
return false;
}
}
if ( !stream.Write(rgbquad, palette_size*4) )
{
if (verbose)
+ {
wxLogError(_("BMP: Couldn't write RGB color map."));
+ }
delete[] rgbquad;
#if wxUSE_PALETTE
delete palette;
if ( !stream.Write(buffer, row_width) )
{
if (verbose)
+ {
wxLogError(_("BMP: Couldn't write data."));
+ }
delete[] buffer;
#if wxUSE_PALETTE
delete palette;
if ( !cmap )
{
if (verbose)
+ {
wxLogError(_("BMP: Couldn't allocate memory."));
+ }
return false;
}
}
if ( !ptr )
{
if ( verbose )
+ {
wxLogError( _("BMP: Couldn't allocate memory.") );
+ }
return false;
}
if ( !alpha )
{
if ( verbose )
+ {
wxLogError(_("BMP: Couldn't allocate memory."));
+ }
return false;
}
}
{
if ( comp == BI_BITFIELDS )
{
- int bit = 0;
+ int bit;
stream.Read(dbuf, 4 * 3);
rmask = wxINT32_SWAP_ON_BE(dbuf[0]);
gmask = wxINT32_SWAP_ON_BE(dbuf[1]);
* Reading the image data
*/
if ( IsBmp )
- stream.SeekI(bmpOffset); // else icon, just carry on
+ {
+ // NOTE: seeking a positive amount in wxFromCurrent mode allows us to
+ // load even non-seekable streams (see wxInputStream::SeekI docs)!
+ const wxFileOffset pos = stream.TellI();
+ if (pos != wxInvalidOffset && bmpOffset > pos)
+ if (stream.SeekI(bmpOffset - pos, wxFromCurrent) == wxInvalidOffset)
+ return false;
+ //else: icon, just carry on
+ }
unsigned char *data = ptr;
{
for (int nibble = 0; nibble < 2 && column < width; nibble++)
{
- int index = ((aByte & (0xF0 >> nibble * 4)) >> (!nibble * 4));
+ int index = ((aByte & (0xF0 >> (nibble * 4))) >> (!nibble * 4));
if ( index >= 16 )
index = 15;
ptr[poffset] = cmap[index].r;
stream.Read(&aWord, 2);
aWord = wxUINT16_SWAP_ON_BE(aWord);
linepos += 2;
- /* use the masks and calculated amonut of shift
+ /* Use the masks and calculated amount of shift
to retrieve the color data out of the word. Then
shift it left by (8 - number of bits) such that
the image has the proper dynamic range */
- temp = (unsigned char)((aWord & rmask) >> rshift << (8-rbits));
+ temp = (unsigned char)(((aWord & rmask) >> rshift) << (8-rbits));
ptr[poffset] = temp;
- temp = (unsigned char)((aWord & gmask) >> gshift << (8-gbits));
+ temp = (unsigned char)(((aWord & gmask) >> gshift) << (8-gbits));
ptr[poffset + 1] = temp;
- temp = (unsigned char)((aWord & bmask) >> bshift << (8-bbits));
+ temp = (unsigned char)(((aWord & bmask) >> bshift) << (8-bbits));
ptr[poffset + 2] = temp;
column++;
}
wxInt32 dbuf[4];
wxInt8 bbuf[4];
- wxFileOffset offset = 0; // keep gcc quiet
if ( IsBmp )
{
// read the header off the .BMP format file
-
- offset = stream.TellI();
- if (offset == wxInvalidOffset)
- offset = 0;
-
stream.Read(bbuf, 2);
stream.Read(dbuf, 16);
}
#if 0 // unused
wxInt32 size = wxINT32_SWAP_ON_BE(dbuf[0]);
#endif
- offset = offset + wxINT32_SWAP_ON_BE(dbuf[2]);
+ wxFileOffset offset = wxINT32_SWAP_ON_BE(dbuf[2]);
stream.Read(dbuf, 4 * 2);
int width = wxINT32_SWAP_ON_BE((int)dbuf[0]);
if ( width > 32767 )
{
if (verbose)
+ {
wxLogError( _("DIB Header: Image width > 32767 pixels for file.") );
+ }
return false;
}
if ( height > 32767 )
{
if (verbose)
+ {
wxLogError( _("DIB Header: Image height > 32767 pixels for file.") );
+ }
return false;
}
if ( bpp != 1 && bpp != 4 && bpp != 8 && bpp != 16 && bpp != 24 && bpp != 32 )
{
if (verbose)
+ {
wxLogError( _("DIB Header: Unknown bitdepth in file.") );
+ }
return false;
}
comp != BI_BITFIELDS )
{
if (verbose)
+ {
wxLogError( _("DIB Header: Unknown encoding in file.") );
+ }
return false;
}
((comp == BI_BITFIELDS) && (bpp != 16 && bpp != 32)))
{
if (verbose)
+ {
wxLogError( _("DIB Header: Encoding doesn't match bitdepth.") );
+ }
return false;
}
verbose, IsBmp, true) )
{
if (verbose)
+ {
wxLogError( _("Error in reading image DIB.") );
+ }
return false;
}
verbose, IsBmp, false) )
{
if (verbose)
+ {
wxLogError( _("ICO: Error in reading mask DIB.") );
+ }
return false;
}
image->SetMaskFromImage(mask, 255, 255, 255);
{
unsigned char hdr[2];
- if ( !stream.Read(hdr, WXSIZEOF(hdr)) )
+ if ( !stream.Read(hdr, WXSIZEOF(hdr)) ) // it's ok to modify the stream position here
return false;
// do we have the BMP file signature?
if ( image->GetHeight () > 127 )
{
if ( verbose )
+ {
wxLogError(_("ICO: Image too tall for an icon."));
+ }
return false;
}
if ( image->GetWidth () > 255 )
{
if ( verbose )
+ {
wxLogError(_("ICO: Image too wide for an icon."));
+ }
return false;
}
if ( !stream.IsOk() )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
if ( !bResult )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
IsMask = true;
if ( !bResult )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
wxUint32 Size = cStream.GetSize();
if ( !cStream.Ok() )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
#endif // 0
if ( !stream.IsOk() )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
if ( !bResult )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
IsMask = true;
if ( !bResult )
{
if ( verbose )
+ {
wxLogError(_("ICO: Error writing the image file!"));
+ }
return false;
}
bool wxICOHandler::LoadFile(wxImage *image, wxInputStream& stream,
bool verbose, int index)
{
- stream.SeekI(0);
return DoLoadFile(image, stream, verbose, index);
}
ICONDIR IconDir;
- wxFileOffset iPos = stream.TellI();
stream.Read(&IconDir, sizeof(IconDir));
wxUint16 nIcons = wxUINT16_SWAP_ON_BE(IconDir.idCount);
+
// nType is 1 for Icons, 2 for Cursors:
wxUint16 nType = wxUINT16_SWAP_ON_BE(IconDir.idType);
int colmax = 0;
int iSel = wxNOT_FOUND;
- for (int i = 0; i < nIcons; i++ )
+ // remember how many bytes we read from the stream:
+ wxFileOffset alreadySeeked = sizeof(IconDir);
+
+ for (unsigned int i = 0; i < nIcons; i++ )
{
- stream.Read(pCurrentEntry, sizeof(ICONDIRENTRY));
+ alreadySeeked += stream.Read(pCurrentEntry, sizeof(ICONDIRENTRY)).LastRead();
+
// bHeight and bColorCount are wxUint8
if ( pCurrentEntry->bWidth >= wMax )
{
colmax = pCurrentEntry->bColorCount;
}
}
+
pCurrentEntry++;
}
{
// seek to selected icon:
pCurrentEntry = pIconDirEntry + iSel;
- stream.SeekI(iPos + wxUINT32_SWAP_ON_BE(pCurrentEntry->dwImageOffset), wxFromStart);
+
+ // NOTE: seeking a positive amount in wxFromCurrent mode allows us to
+ // load even non-seekable streams (see wxInputStream::SeekI docs)!
+ wxFileOffset offset = wxUINT32_SWAP_ON_BE(pCurrentEntry->dwImageOffset) - alreadySeeked;
+ if (offset != 0 && stream.SeekI(offset, wxFromCurrent) == wxInvalidOffset)
+ return false;
+
bResult = LoadDib(image, stream, true, IsBmp);
bool bIsCursorType = (this->GetType() == wxBITMAP_TYPE_CUR) || (this->GetType() == wxBITMAP_TYPE_ANI);
if ( bResult && bIsCursorType && nType == 2 )
image->SetOption(wxIMAGE_OPTION_CUR_HOTSPOT_Y, wxUINT16_SWAP_ON_BE(pCurrentEntry->wBitCount));
}
}
- delete[] pIconDirEntry;
+
+ delete [] pIconDirEntry;
+
return bResult;
}
-int wxICOHandler::GetImageCount(wxInputStream& stream)
+int wxICOHandler::DoGetImageCount(wxInputStream& stream)
{
ICONDIR IconDir;
- wxFileOffset iPos = stream.TellI();
- stream.SeekI(0);
- stream.Read(&IconDir, sizeof(IconDir));
- wxUint16 nIcons = wxUINT16_SWAP_ON_BE(IconDir.idCount);
- stream.SeekI(iPos);
- return (int)nIcons;
+
+ if (stream.Read(&IconDir, sizeof(IconDir)).LastRead() != sizeof(IconDir))
+ // it's ok to modify the stream position here
+ return 0;
+
+ return (int)wxUINT16_SWAP_ON_BE(IconDir.idCount);
}
bool wxICOHandler::DoCanRead(wxInputStream& stream)
{
- stream.SeekI(0);
unsigned char hdr[4];
- if ( !stream.Read(hdr, WXSIZEOF(hdr)) )
+ if ( !stream.Read(hdr, WXSIZEOF(hdr)) ) // it's ok to modify the stream position here
return false;
// hdr[2] is one for an icon and two for a cursor
bool wxCURHandler::DoCanRead(wxInputStream& stream)
{
- stream.SeekI(0);
unsigned char hdr[4];
- if ( !stream.Read(hdr, WXSIZEOF(hdr)) )
+ if ( !stream.Read(hdr, WXSIZEOF(hdr)) ) // it's ok to modify the stream position here
return false;
// hdr[2] is one for an icon and two for a cursor
{
wxANIDecoder decod;
return decod.CanRead(stream);
+ // it's ok to modify the stream position here
}
-int wxANIHandler::GetImageCount(wxInputStream& stream)
+int wxANIHandler::DoGetImageCount(wxInputStream& stream)
{
wxANIDecoder decoder;
- if (!decoder.Load(stream))
+ if (!decoder.Load(stream)) // it's ok to modify the stream position here
return wxNOT_FOUND;
return decoder.GetFrameCount();
projects / wxWidgets.git / blobdiff