Ambiguous overload fix for gcc

[wxWidgets.git] / src / common / dynload.cpp

diff --git a/src/common/dynload.cpp b/src/common/dynload.cpp
index ebff36b860cbf9a8516e858b81abe0ab9e627913..562b6ce975a7d0fd2e23a32ac7ecaa3a6fd40f6e 100644 (file)
--- a/src/common/dynload.cpp
+++ b/src/common/dynload.cpp
@@ -10,10 +10,6 @@
 // Licence:      wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:      wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "dynload.h"
-#endif
-

 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------


@@ -60,7 +56,7 @@ public:
     {
         wxPluginLibrary::ms_classes = new wxDLImports;
         wxPluginManager::CreateManifest();
     {
         wxPluginLibrary::ms_classes = new wxDLImports;
         wxPluginManager::CreateManifest();

-        return TRUE;
+        return true;

     }
 
     virtual void OnExit()
     }
 
     virtual void OnExit()


@@ -87,6 +83,7 @@ wxPluginLibrary::wxPluginLibrary(const wxString &libname, int flags)
 
     if( m_handle != 0 )
     {
 
     if( m_handle != 0 )
     {

+        UpdateClasses();

         RegisterModules();
     }
     else
         RegisterModules();
     }
     else


@@ -101,6 +98,7 @@ wxPluginLibrary::~wxPluginLibrary()
     if( m_handle != 0 )
     {
         UnregisterModules();
     if( m_handle != 0 )
     {
         UnregisterModules();

+        RestoreClasses();

     }
 }
 
     }
 }
 


@@ -118,19 +116,44 @@ bool wxPluginLibrary::UnrefLib()
     wxASSERT_MSG( m_objcount == 0,
                   _T("Library unloaded before all objects were destroyed") );
 
     wxASSERT_MSG( m_objcount == 0,
                   _T("Library unloaded before all objects were destroyed") );
 

-    if ( --m_linkcount == 0 )
+    if ( m_linkcount == 0 || --m_linkcount == 0 )

     {
         delete this;
     {
         delete this;

-        return TRUE;
+        return true;

     }
 
     }
 

-    return FALSE;
+    return false;

 }
 
 // ------------------------
 // Private methods
 // ------------------------
 
 }
 
 // ------------------------
 // Private methods
 // ------------------------
 

+void wxPluginLibrary::UpdateClasses()
+{
+    for (wxClassInfo *info = m_after; info != m_before; info = info->m_next)
+    {
+        if( info->GetClassName() )
+        {
+            // Hash all the class names into a local table too so
+            // we can quickly find the entry they correspond to.
+            (*ms_classes)[info->GetClassName()] = this;
+        }
+    }
+}
+
+void wxPluginLibrary::RestoreClasses()
+{
+    // Check if there is a need to restore classes.
+    if (!ms_classes)
+        return;
+
+    for(wxClassInfo *info = m_after; info != m_before; info = info->m_next)
+    {
+        ms_classes->erase(ms_classes->find(info->GetClassName()));
+    }
+}
+

 void wxPluginLibrary::RegisterModules()
 {
     // Plugin libraries might have wxModules, Register and initialise them if
 void wxPluginLibrary::RegisterModules()
 {
     // Plugin libraries might have wxModules, Register and initialise them if


@@ -199,7 +222,8 @@ void wxPluginLibrary::UnregisterModules()
     for ( it = m_wxmodules.begin(); it != m_wxmodules.end(); ++it )
         wxModule::UnregisterModule( *it );
 
     for ( it = m_wxmodules.begin(); it != m_wxmodules.end(); ++it )
         wxModule::UnregisterModule( *it );
 

-    WX_CLEAR_LIST(wxModuleList, m_wxmodules);
+    // NB: content of the list was deleted by UnregisterModule calls above:
+    m_wxmodules.clear();

 }
 
 
 }
 
 


@@ -288,7 +312,7 @@ bool wxPluginManager::UnloadLibrary(const wxString& libname)
         wxLogDebug(_T("Attempt to unload library '%s' which is not loaded."),
                    libname.c_str());
 
         wxLogDebug(_T("Attempt to unload library '%s' which is not loaded."),
                    libname.c_str());
 

-        return FALSE;
+        return false;

     }
 
     wxLogTrace(_T("dll"), _T("UnloadLibrary(%s)"), realname.c_str());
     }
 
     wxLogTrace(_T("dll"), _T("UnloadLibrary(%s)"), realname.c_str());


@@ -296,12 +320,12 @@ bool wxPluginManager::UnloadLibrary(const wxString& libname)
     if ( !entry->UnrefLib() )
     {
         // not really unloaded yet
     if ( !entry->UnrefLib() )
     {
         // not really unloaded yet

-        return FALSE;
+        return false;

     }
 
     ms_manifest->erase(ms_manifest->find(realname));
 
     }
 
     ms_manifest->erase(ms_manifest->find(realname));
 

-    return TRUE;
+    return true;

 }
 
 // ------------------------
 }
 
 // ------------------------


@@ -392,7 +416,7 @@ wxDllLoader::GetSymbol(wxDllType dllHandle, const wxString &name, bool *success)
         wxFAIL_MSG( _T("Using a library not loaded with wxDllLoader?") );
 
         if ( success )
         wxFAIL_MSG( _T("Using a library not loaded with wxDllLoader?") );
 
         if ( success )

-            *success = FALSE;
+            *success = false;

 
         return NULL;
     }
 
         return NULL;
     }


@@ -434,7 +458,7 @@ wxLibrary::wxLibrary(wxDllType handle)
 
     // Some system may use a local heap for library.
     get_first = (t_get_first)GetSymbol(_T("wxGetClassFirst"));
 
     // Some system may use a local heap for library.
     get_first = (t_get_first)GetSymbol(_T("wxGetClassFirst"));

-    // It is a wxWindows DLL.
+    // It is a wxWidgets DLL.

     if (get_first)
         PrepareClasses(get_first());
 }
     if (get_first)
         PrepareClasses(get_first());
 }


@@ -498,13 +522,13 @@ wxLibraries::wxLibraries():m_loaded(wxKEY_STRING)
 
 wxLibraries::~wxLibraries()
 {
 
 wxLibraries::~wxLibraries()
 {

-    wxNode *node = m_loaded.First();
+    wxNode *node = m_loaded.GetFirst();

 
     while (node) {
 
     while (node) {

-        wxLibrary *lib = (wxLibrary *)node->Data();
+        wxLibrary *lib = (wxLibrary *)node->GetData();

         delete lib;
 
         delete lib;
 

-        node = node->Next();
+        node = node->GetNext();

     }
 }
 
     }
 }
 


@@ -515,7 +539,7 @@ wxLibrary *wxLibraries::LoadLibrary(const wxString& name)
     wxNode      *node = m_loaded.Find(name.GetData());
 
     if (node != NULL)
     wxNode      *node = m_loaded.Find(name.GetData());
 
     if (node != NULL)

-        return ((wxLibrary *)node->Data());
+        return ((wxLibrary *)node->GetData());

 
     // If DLL shares data, this is necessary.
     old_sm_first = wxClassInfo::sm_first;
 
     // If DLL shares data, this is necessary.
     old_sm_first = wxClassInfo::sm_first;


@@ -523,7 +547,7 @@ wxLibrary *wxLibraries::LoadLibrary(const wxString& name)
 
     wxString libname = ConstructLibraryName(name);
 
 
     wxString libname = ConstructLibraryName(name);
 

-    bool success = FALSE;
+    bool success = false;

     wxDllType handle = wxDllLoader::LoadLibrary(libname, &success);
     if(success)
     {
     wxDllType handle = wxDllLoader::LoadLibrary(libname, &success);
     if(success)
     {


@@ -539,15 +563,15 @@ wxLibrary *wxLibraries::LoadLibrary(const wxString& name)
 
 wxObject *wxLibraries::CreateObject(const wxString& path)
 {
 
 wxObject *wxLibraries::CreateObject(const wxString& path)
 {

-    wxNode *node = m_loaded.First();
+    wxNode *node = m_loaded.GetFirst();

     wxObject *obj;
 
     while (node) {
     wxObject *obj;
 
     while (node) {

-        obj = ((wxLibrary *)node->Data())->CreateObject(path);
+        obj = ((wxLibrary *)node->GetData())->CreateObject(path);

         if (obj)
             return obj;
 
         if (obj)
             return obj;
 

-        node = node->Next();
+        node = node->GetNext();

     }
     return NULL;
 }
     }
     return NULL;
 }