class wxDataViewEditorCtrlEvtHandler: public wxEvtHandler
{
public:
- wxDataViewEditorCtrlEvtHandler(wxControl *editor, wxDataViewRenderer *owner)
+ wxDataViewEditorCtrlEvtHandler(wxWindow *editor, wxDataViewRenderer *owner)
{
m_editorCtrl = editor;
m_owner = owner;
private:
wxDataViewRenderer *m_owner;
- wxControl *m_editorCtrl;
+ wxWindow *m_editorCtrl;
bool m_finished;
bool m_focusOnIdle;
} // anonymous namespace
+// ---------------------------------------------------------
+// wxDataViewItemAttr
+// ---------------------------------------------------------
+
+wxFont wxDataViewItemAttr::GetEffectiveFont(const wxFont& font) const
+{
+ if ( !HasFont() )
+ return font;
+
+ wxFont f(font);
+ if ( GetBold() )
+ f.MakeBold();
+ if ( GetItalic() )
+ f.MakeItalic();
+ return f;
+}
+
+
// ---------------------------------------------------------
// wxDataViewModelNotifier
// ---------------------------------------------------------
void wxDataViewRendererBase::DestroyEditControl()
{
+ // Remove our event handler first to prevent it from (recursively) calling
+ // us again as it would do via a call to FinishEditing() when the editor
+ // loses focus when we hide it below.
+ wxEvtHandler * const handler = m_editorCtrl->PopEventHandler();
+
// Hide the control immediately but don't delete it yet as there could be
// some pending messages for it.
m_editorCtrl->Hide();
- wxEvtHandler * const handler = m_editorCtrl->PopEventHandler();
-
wxPendingDelete.Append(handler);
wxPendingDelete.Append(m_editorCtrl);
}
if (!m_editorCtrl)
return;
- GetOwner()->GetOwner()->GetMainWindow()->SetFocus();
-
DestroyEditControl();
}
DestroyEditControl();
- if (!Validate(value))
- return false;
-
+ bool isValid = Validate(value);
unsigned int col = GetOwner()->GetModelColumn();
- dv_ctrl->GetModel()->ChangeValue(value, m_item, col);
// Now we should send Editing Done event
wxDataViewEvent event( wxEVT_COMMAND_DATAVIEW_ITEM_EDITING_DONE, dv_ctrl->GetId() );
event.SetDataViewColumn( GetOwner() );
event.SetModel( dv_ctrl->GetModel() );
event.SetItem( m_item );
+ event.SetValue( value );
+ event.SetColumn( col );
+ event.SetEditCanceled( !isValid );
event.SetEventObject( dv_ctrl );
dv_ctrl->GetEventHandler()->ProcessEvent( event );
- return true;
+ if ( isValid && event.IsAllowed() )
+ {
+ dv_ctrl->GetModel()->ChangeValue(value, m_item, col);
+ return true;
+ }
+
+ return false;
}
+void wxDataViewRendererBase::PrepareForItem(const wxDataViewModel *model,
+ const wxDataViewItem& item,
+ unsigned column)
+{
+ wxVariant value;
+ model->GetValue(value, item, column);
+ SetValue(value);
+
+ wxDataViewItemAttr attr;
+ model->GetAttr(item, column, attr);
+ SetAttr(attr);
+
+ SetEnabled(model->IsEnabled(item, column));
+}
+
+
// ----------------------------------------------------------------------------
// wxDataViewCustomRendererBase
// ----------------------------------------------------------------------------
wxDCFontChanger changeFont(*dc);
if ( m_attr.HasFont() )
- {
- wxFont font(dc->GetFont());
- if ( m_attr.GetBold() )
- font.MakeBold();
- if ( m_attr.GetItalic() )
- font.MakeItalic();
-
- changeFont.Set(font);
- }
+ changeFont.Set(m_attr.GetEffectiveFont(dc->GetFont()));
Render(rectItem, dc, state);
}
+wxSize wxDataViewCustomRendererBase::GetTextExtent(const wxString& str) const
+{
+ const wxDataViewCtrl *view = GetView();
+
+ if ( m_attr.HasFont() )
+ {
+ wxFont font(m_attr.GetEffectiveFont(view->GetFont()));
+ wxSize size;
+ view->GetTextExtent(str, &size.x, &size.y, NULL, NULL, &font);
+ return size;
+ }
+ else
+ {
+ return view->GetTextExtent(str);
+ }
+}
+
void
wxDataViewCustomRendererBase::RenderText(const wxString& text,
int xoffset,
m_max = max;
}
-wxControl* wxDataViewSpinRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
+wxWindow* wxDataViewSpinRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
{
long l = value;
wxSize size = labelRect.GetSize();
return sc;
}
-bool wxDataViewSpinRenderer::GetValueFromEditorCtrl( wxControl* editor, wxVariant &value )
+bool wxDataViewSpinRenderer::GetValueFromEditorCtrl( wxWindow* editor, wxVariant &value )
{
wxSpinCtrl *sc = (wxSpinCtrl*) editor;
long l = sc->GetValue();
wxSize wxDataViewSpinRenderer::GetSize() const
{
- return wxSize(80,16);
+ wxSize sz = GetTextExtent(wxString::Format("%d", (int)m_data));
+
+ // Allow some space for the spin buttons, which is approximately the size
+ // of a scrollbar (and getting pixel-exact value would be complicated).
+ // Also add some whitespace between the text and the button:
+ sz.x += wxSystemSettings::GetMetric(wxSYS_VSCROLL_X);
+ sz.x += GetTextExtent("M").x;
+
+ return sz;
}
bool wxDataViewSpinRenderer::SetValue( const wxVariant &value )
m_choices = choices;
}
-wxControl* wxDataViewChoiceRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
+wxWindow* wxDataViewChoiceRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
{
- wxChoice* c = new wxChoice(parent, wxID_ANY, labelRect.GetTopLeft(), wxDefaultSize, m_choices );
+ wxChoice* c = new wxChoice
+ (
+ parent,
+ wxID_ANY,
+ labelRect.GetTopLeft(),
+ wxSize(labelRect.GetWidth(), -1),
+ m_choices
+ );
c->Move(labelRect.GetRight() - c->GetRect().width, wxDefaultCoord);
c->SetStringSelection( value.GetString() );
return c;
}
-bool wxDataViewChoiceRenderer::GetValueFromEditorCtrl( wxControl* editor, wxVariant &value )
+bool wxDataViewChoiceRenderer::GetValueFromEditorCtrl( wxWindow* editor, wxVariant &value )
{
wxChoice *c = (wxChoice*) editor;
wxString s = c->GetStringSelection();
wxSize wxDataViewChoiceRenderer::GetSize() const
{
- return wxSize(80,16);
+ wxSize sz;
+
+ for ( wxArrayString::const_iterator i = m_choices.begin(); i != m_choices.end(); ++i )
+ sz.IncTo(GetTextExtent(*i));
+
+ // Allow some space for the right-side button, which is approximately the
+ // size of a scrollbar (and getting pixel-exact value would be complicated).
+ // Also add some whitespace between the text and the button:
+ sz.x += wxSystemSettings::GetMetric(wxSYS_VSCROLL_X);
+ sz.x += GetTextExtent("M").x;
+
+ return sz;
}
bool wxDataViewChoiceRenderer::SetValue( const wxVariant &value )
{
}
-wxControl* wxDataViewChoiceByIndexRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
+wxWindow* wxDataViewChoiceByIndexRenderer::CreateEditorCtrl( wxWindow *parent, wxRect labelRect, const wxVariant &value )
{
wxVariant string_value = GetChoice( value.GetLong() );
return wxDataViewChoiceRenderer::CreateEditorCtrl( parent, labelRect, string_value );
}
-bool wxDataViewChoiceByIndexRenderer::GetValueFromEditorCtrl( wxControl* editor, wxVariant &value )
+bool wxDataViewChoiceByIndexRenderer::GetValueFromEditorCtrl( wxWindow* editor, wxVariant &value )
{
wxVariant string_value;
if (!wxDataViewChoiceRenderer::GetValueFromEditorCtrl( editor, string_value ))
wxDATAVIEW_CELL_EDITABLE,
-1, // default width
wxALIGN_NOT, // and alignment
- 0 // not resizeable
+ 0 // not resizable
);
return true;