* Fixed two memory leaks.

[wxWidgets.git] / src / common / textfile.cpp

diff --git a/src/common/textfile.cpp b/src/common/textfile.cpp
index ca7235c4e97b60633790b17e4ed11cce4f1acba7..cf3095cd5e18b6ad32dfaea71d9f0c401868a9a2 100644 (file)
--- a/src/common/textfile.cpp
+++ b/src/common/textfile.cpp
@@ -2,7 +2,7 @@
 // Name:        textfile.cpp
 // Purpose:     implementation of wxTextFile class
 // Author:      Vadim Zeitlin
-// Modified by: 
+// Modified by:
 // Created:     03.04.98
 // RCS-ID:      $Id$
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
@@ -36,14 +36,14 @@
 // ----------------------------------------------------------------------------
 // static variables
 // ----------------------------------------------------------------------------
-  
+
 // default type is the native one
 const wxTextFile::Type wxTextFile::typeDefault = wxTextFile::
 #if   defined(__WINDOWS__)
   Type_Dos;
 #elif defined(__UNIX__)
   Type_Unix;
-#elif defined(__MAC__)
+#elif defined(__WXMAC__)
   Type_Mac;
   // if you feel brave, remove the next line
   #error  "wxTextFile: code for Mac files is untested."
@@ -101,13 +101,13 @@ wxTextFile::Type wxTextFile::GuessType() const
   wxASSERT( m_file.IsOpened() && m_file.Tell() == 0 );
 
   // scan the file lines
-  uint nUnix = 0,     // number of '\n's alone
+  size_t nUnix = 0,     // number of '\n's alone
        nDos  = 0,     // number of '\r\n'
        nMac  = 0;     // number of '\r's
 
   // we take MAX_LINES_SCAN in the beginning, middle and the end of file
   #define MAX_LINES_SCAN    (10)
-  uint nCount = m_aLines.Count() / 3,
+  size_t nCount = m_aLines.Count() / 3,
        nScan =  nCount > 3*MAX_LINES_SCAN ? MAX_LINES_SCAN : nCount / 3;
 
   #define   AnalyseLine(n)              \
@@ -115,9 +115,10 @@ wxTextFile::Type wxTextFile::GuessType() const
       case Type_Unix: nUnix++; break;   \
       case Type_Dos:  nDos++;  break;   \
       case Type_Mac:  nMac++;  break;   \
+      default: wxFAIL_MSG(_("unknown line terminator")); \
     }
 
-  uint n;
+  size_t n;
   for ( n = 0; n < nScan; n++ )     // the beginning
     AnalyseLine(n);
   for ( n = (nCount - nScan)/2; n < (nCount + nScan)/2; n++ )
@@ -130,7 +131,7 @@ wxTextFile::Type wxTextFile::GuessType() const
   // interpret the results (@@ far from being even 50% fool proof)
   if ( nDos + nUnix + nMac == 0 ) {
     // no newlines at all
-    wxLogWarning("'%s' is probably a binary file.", m_strFile.c_str());
+    wxLogWarning(_("'%s' is probably a binary file."), m_strFile.c_str());
   }
   else {
     #define   GREATER_OF(t1, t2) n##t1 == n##t2 ? typeDefault               \
@@ -159,10 +160,12 @@ bool wxTextFile::Read()
 
   wxString str;
   char ch, chLast = '\0';
+  char buf[1024];
+  int n, nRead;
   while ( !m_file.Eof() ) {
-    // @@ should really use a buffer for efficiency
-    if ( m_file.Read(&ch, sizeof(ch)) == ofsInvalid ) {
-      // read error
+    nRead = m_file.Read(buf, WXSIZEOF(buf));
+    if ( nRead == wxInvalidOffset ) {
+      // read error (error message already given in wxFile::Read)
       m_file.Close();
       return FALSE;
     }
@@ -171,36 +174,39 @@ bool wxTextFile::Read()
       #pragma message("wxTextFile::Read() hasn't been tested with Mac files.")
     #endif
 
-    switch ( ch ) {
-      case '\n':
-        // Dos/Unix line termination
-        m_aLines.Add(str);
-        m_aTypes.Add(chLast == '\r' ? Type_Dos : Type_Unix);
-        str.Empty();
-        chLast = '\n';
-        break;
-
-      case '\r':
-        if ( chLast == '\r' ) {
-          // Mac empty line
-          m_aLines.Add("");
-          m_aTypes.Add(Type_Mac);
-        }
-        else
-          chLast = '\r';
-        break;
-
-      default:
-        if ( chLast == '\r' ) {
-          // Mac line termination
+    for ( n = 0; n < nRead; n++ ) {
+      ch = buf[n];
+      switch ( ch ) {
+        case '\n':
+          // Dos/Unix line termination
           m_aLines.Add(str);
-          m_aTypes.Add(Type_Mac);
-          str = ch;
-        }
-        else {
-          // add to the current line
-          str += ch;
-        }
+          m_aTypes.Add(chLast == '\r' ? Type_Dos : Type_Unix);
+          str.Empty();
+          chLast = '\n';
+          break;
+
+        case '\r':
+          if ( chLast == '\r' ) {
+            // Mac empty line
+            m_aLines.Add("");
+            m_aTypes.Add(Type_Mac);
+          }
+          else
+            chLast = '\r';
+          break;
+
+        default:
+          if ( chLast == '\r' ) {
+            // Mac line termination
+            m_aLines.Add(str);
+            m_aTypes.Add(Type_Mac);
+            str = ch;
+          }
+          else {
+            // add to the current line
+            str += ch;
+          }
+      }
     }
   }
 
@@ -218,16 +224,16 @@ bool wxTextFile::Write(Type typeNew)
   wxTempFile fileTmp(m_strFile);
 
   if ( !fileTmp.IsOpened() ) {
-    wxLogError("can't write file '%s' to disk.", m_strFile.c_str());
+    wxLogError(_("can't write file '%s' to disk."), m_strFile.c_str());
     return FALSE;
   }
 
-  uint nCount = m_aLines.Count();
-  for ( uint n = 0; n < nCount; n++ ) {
-    fileTmp.Write(m_aLines[n] + 
+  size_t nCount = m_aLines.Count();
+  for ( size_t n = 0; n < nCount; n++ ) {
+    fileTmp.Write(m_aLines[n] +
                   GetEOL(typeNew == Type_None ? m_aTypes[n] : typeNew));
   }
 
   // replace the old file with this one
   return fileTmp.Commit();
-}
\ No newline at end of file
+}