my $CVS = "cvs -z3"; # the cvs command
+# the regexp for cvs revision number
+my $RE_CVS_REV = "\\d+(?:\\.\\d+)+";
+
sub dec_rev($)
{
my $rev = $_[0];
# decrement the revision number to get the previos one
- # (FIXME this is totally bogus, won't work with branches)
- my $revlen = length($rev) - rindex($rev, '.') - 1;
- my $m = 10**$revlen;
+ $rev =~ s/(\d+)$/$1 - 1/e;
- return int($rev) . "." . ($rev*$m - int($rev)*$m - 1)
+ return $rev;
}
sub get_last_rev($)
my $file = $_[0];
my $basename = $file;
- $basename =~ s@^.*/([^/]\+)@$1@;
+ $basename =~ s@^.*/@@;
# first get the current version: try the Id RCS tag in the file itself
# first, use "cvs status" if this fails
while (<INPUT>) {
# notice that we shouldn't have '$' followed by 'Id' or cvs will
# substitute it!
- if ( /\$(Id): $basename,v (\d+\.\d+)/ ) {
+ if ( /\$(Id): $basename,v ($RE_CVS_REV)/ ) {
return &dec_rev($2);
}
}
open(INPUT, "$CVS -q status $file |") or return 0;
while (<INPUT>) {
- if ( /Working revision:\s+(\d+\.\d+)/ ) {
+ if ( /Working revision:\s+($RE_CVS_REV)/ ) {
return &dec_rev($1);
}
}
if ( !$revlast ) {
warn "Failed to get the last revision for $file, skipping.\n"
}
- elsif ( $revlast =~ "\.0" ) {
+ elsif ( $revlast =~ '\.0' ) {
warn "No previous revision of the file $file.\n"
}
else {