A slightly modified version of Patch #1197468. Keeps track of pending

[wxWidgets.git] / src / msw / statbr95.cpp

diff --git a/src/msw/statbr95.cpp b/src/msw/statbr95.cpp
index 86937ad4a9f7ae4c8b051ab700c6807ebd2e4065..37b9b03f73c7822e6263418f242a23067461b37d 100644 (file)
--- a/src/msw/statbr95.cpp
+++ b/src/msw/statbr95.cpp
@@ -6,10 +6,10 @@
 // Created:     04.04.98
 // RCS-ID:      $Id$
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Created:     04.04.98
 // RCS-ID:      $Id$
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>

-// Licence:     wxWindows license
+// Licence:     wxWindows licence

 ///////////////////////////////////////////////////////////////////////////////
 
 ///////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "statbr95.h"
 #endif
 
 #pragma implementation "statbr95.h"
 #endif
 


@@ -27,7 +27,7 @@
   #include "wx/dcclient.h"
 #endif
 
   #include "wx/dcclient.h"
 #endif
 

-#if defined(__WIN95__) && wxUSE_NATIVE_STATUSBAR
+#if wxUSE_STATUSBAR && defined(__WIN95__) && wxUSE_NATIVE_STATUSBAR

 
 #include "wx/intl.h"
 #include "wx/log.h"
 
 #include "wx/intl.h"
 #include "wx/log.h"


@@ -36,17 +36,10 @@
 #include "wx/msw/private.h"
 #include <windowsx.h>
 
 #include "wx/msw/private.h"
 #include <windowsx.h>
 

-#if !(defined(__GNUWIN32_OLD__) || defined(__TWIN32__))
+#if defined(__WIN95__) && !(defined(__GNUWIN32_OLD__) && !defined(__CYGWIN10__))

     #include <commctrl.h>
 #endif
 
     #include <commctrl.h>
 #endif
 

-// ----------------------------------------------------------------------------
-// wxWindows macros
-// ----------------------------------------------------------------------------
-
-IMPLEMENT_DYNAMIC_CLASS(wxStatusBar95, wxWindow);
-IMPLEMENT_DYNAMIC_CLASS(wxStatusBar, wxStatusBar95)
-

 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------


@@ -57,27 +50,6 @@ IMPLEMENT_DYNAMIC_CLASS(wxStatusBar, wxStatusBar95)
 #define StatusBar_GetTextLen(h, n)  LOWORD(SendMessage(h, SB_GETTEXTLENGTH, (WPARAM)n, 0))
 #define StatusBar_GetText(h, n, s)  LOWORD(SendMessage(h, SB_GETTEXT, (WPARAM)n, (LPARAM)(LPTSTR)s))
 
 #define StatusBar_GetTextLen(h, n)  LOWORD(SendMessage(h, SB_GETTEXTLENGTH, (WPARAM)n, 0))
 #define StatusBar_GetText(h, n, s)  LOWORD(SendMessage(h, SB_GETTEXT, (WPARAM)n, (LPARAM)(LPTSTR)s))
 

-// ----------------------------------------------------------------------------
-//
-// ----------------------------------------------------------------------------
-
-// static WNDPROC gs_wndprocStatBar = NULL;
-static WXFARPROC gs_wndprocStatBar = (WXFARPROC) NULL;
-
-LRESULT APIENTRY wxStatusBarProc(HWND hwnd,
-                                 UINT message,
-                                 WPARAM wParam,
-                                 LPARAM lParam)
-{
-    if ( message == WM_COMMAND )
-    {
-        wxStatusBar95 *sb = (wxStatusBar95 *)GetWindowLong(hwnd, GWL_USERDATA);
-        sb->MSWWindowProc(message, wParam, lParam);
-    }
-
-    return ::CallWindowProc(CASTWNDPROC gs_wndprocStatBar, hwnd, message, wParam, lParam);
-}
-

 // ============================================================================
 // implementation
 // ============================================================================
 // ============================================================================
 // implementation
 // ============================================================================


@@ -88,9 +60,9 @@ LRESULT APIENTRY wxStatusBarProc(HWND hwnd,
 
 wxStatusBar95::wxStatusBar95()
 {
 
 wxStatusBar95::wxStatusBar95()
 {

-  SetParent(NULL);
-  m_hWnd = 0;
-  m_windowId = 0;
+    SetParent(NULL);
+    m_hWnd = 0;
+    m_windowId = 0;

 }
 
 bool wxStatusBar95::Create(wxWindow *parent,
 }
 
 bool wxStatusBar95::Create(wxWindow *parent,


@@ -98,7 +70,7 @@ bool wxStatusBar95::Create(wxWindow *parent,
                            long style,
                            const wxString& name)
 {
                            long style,
                            const wxString& name)
 {

-    wxCHECK_MSG( parent, FALSE, wxT("status bar must have a parent") );
+    wxCHECK_MSG( parent, false, wxT("status bar must have a parent") );

 
     SetName(name);
     SetWindowStyleFlag(style);
 
     SetName(name);
     SetWindowStyleFlag(style);


@@ -106,11 +78,30 @@ bool wxStatusBar95::Create(wxWindow *parent,
 
     parent->AddChild(this);
 
 
     parent->AddChild(this);
 

-    m_windowId = id == -1 ? NewControlId() : id;
+    m_windowId = id == wxID_ANY ? NewControlId() : id;

 
     DWORD wstyle = WS_CHILD | WS_VISIBLE;
 
     DWORD wstyle = WS_CHILD | WS_VISIBLE;

-    if ( style & wxST_SIZEGRIP )
+
+    if ( style & wxCLIP_SIBLINGS )
+        wstyle |= WS_CLIPSIBLINGS;
+
+    // setting SBARS_SIZEGRIP is perfectly useless: it's always on by default
+    // (at least in the version of comctl32.dll I'm using), and the only way to
+    // turn it off is to use CCS_TOP style - as we position the status bar
+    // manually anyhow (see DoMoveWindow), use CCS_TOP style if wxST_SIZEGRIP
+    // is not given
+    if ( !(style & wxST_SIZEGRIP) )
+    {
+        wstyle |= CCS_TOP;
+    }
+    else
+    {
+#ifndef __WXWINCE__
+        // may be some versions of comctl32.dll do need it - anyhow, it won't
+        // do any harm

         wstyle |= SBARS_SIZEGRIP;
         wstyle |= SBARS_SIZEGRIP;

+#endif
+    }

 
     m_hWnd = (WXHWND)CreateStatusWindow(wstyle,
                                         wxEmptyString,
 
     m_hWnd = (WXHWND)CreateStatusWindow(wstyle,
                                         wxEmptyString,


@@ -120,61 +111,53 @@ bool wxStatusBar95::Create(wxWindow *parent,
     {
         wxLogSysError(_("Failed to create a status bar."));
 
     {
         wxLogSysError(_("Failed to create a status bar."));
 

-        return FALSE;
+        return false;

     }
 
     SetFieldsCount(1);
     }
 
     SetFieldsCount(1);

+    SubclassWin(m_hWnd);
+    InheritAttributes();
+
+    SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_MENUBAR));
+    
+    // we must refresh the frame size when the statusbar is created, because
+    // its client area might change
+    wxFrame *frame = wxDynamicCast(GetParent(), wxFrame);
+    if ( frame )
+    {
+        frame->SendSizeEvent();
+    }

 
 

-    // we can't subclass this window as usual because the status bar window
-    // proc processes WM_SIZE and WM_PAINT specially
-    //  SubclassWin(m_hWnd);
-
-    // but we want to process the messages from it still, so do custom
-    // subclassing here
-    gs_wndprocStatBar = (WXFARPROC)GetWindowLong(GetHwnd(), GWL_WNDPROC);
-    SetWindowLong(GetHwnd(), GWL_WNDPROC, (LONG)wxStatusBarProc);
-    SetWindowLong(GetHwnd(), GWL_USERDATA, (LONG)this);
-
-    return TRUE;
+    return true;

 }
 
 wxStatusBar95::~wxStatusBar95()
 {
 }
 
 wxStatusBar95::~wxStatusBar95()
 {

-    delete [] m_statusWidths;
-}
-
-void wxStatusBar95::CopyFieldsWidth(const int widths[])
-{
-  if (widths && !m_statusWidths)
-    m_statusWidths = new int[m_nFields];
-
-  if ( widths != NULL ) {
-    for ( int i = 0; i < m_nFields; i++ )
-      m_statusWidths[i] = widths[i];
-  }
-  else {
-    delete [] m_statusWidths;
-    m_statusWidths = NULL;
-  }
+    // we must refresh the frame size when the statusbar is deleted but the
+    // frame is not - otherwise statusbar leaves a hole in the place it used to
+    // occupy
+    wxFrame *frame = wxDynamicCast(GetParent(), wxFrame);
+    if ( frame && !frame->IsBeingDeleted() )
+    {
+        frame->SendSizeEvent();
+    }

 }
 
 void wxStatusBar95::SetFieldsCount(int nFields, const int *widths)
 {
 }
 
 void wxStatusBar95::SetFieldsCount(int nFields, const int *widths)
 {

-  // this is Windows limitation
-  wxASSERT_MSG( (nFields > 0) && (nFields < 255), _T("too many fields") );
+    // this is a Windows limitation
+    wxASSERT_MSG( (nFields > 0) && (nFields < 255), _T("too many fields") );

 
 

-  m_nFields = nFields;
+    wxStatusBarBase::SetFieldsCount(nFields, widths);

 
 

-  CopyFieldsWidth(widths);
-  SetFieldsWidth();
+    SetFieldsWidth();

 }
 
 void wxStatusBar95::SetStatusWidths(int n, const int widths[])
 {
 }
 
 void wxStatusBar95::SetStatusWidths(int n, const int widths[])
 {

-  wxASSERT_MSG( n == m_nFields, _T("field number mismatch") );
+    wxStatusBarBase::SetStatusWidths(n, widths);

 
 

-  CopyFieldsWidth(widths);
-  SetFieldsWidth();
+    SetFieldsWidth();

 }
 
 void wxStatusBar95::SetFieldsWidth()
 }
 
 void wxStatusBar95::SetFieldsWidth()


@@ -187,46 +170,15 @@ void wxStatusBar95::SetFieldsWidth()
 
     int extraWidth = aBorders[2]; // space between fields
 
 
     int extraWidth = aBorders[2]; // space between fields
 

-    int *pWidths = new int[m_nFields];
-
-    int nWindowWidth, y;
-    GetClientSize(&nWindowWidth, &y);
-
-    if ( m_statusWidths == NULL ) {
-        // default: all fields have the same width
-        int nWidth = nWindowWidth / m_nFields;
-        for ( int i = 0; i < m_nFields; i++ )
-            pWidths[i] = (i + 1) * nWidth;
-    }
-    else {
-        // -1 doesn't mean the same thing for wxWindows and Win32, recalc
-        int nTotalWidth = 0,
-        nVarCount = 0,
-        i;
-        for ( i = 0; i < m_nFields; i++ ) {
-            if ( m_statusWidths[i] == -1 )
-                nVarCount++;
-            else
-                nTotalWidth += m_statusWidths[i] + extraWidth;
-        }
-
-        if ( nVarCount == 0 ) {
-            wxFAIL_MSG( _T("at least one field must be of variable width") );
-
-            nVarCount++;
-        }
+    wxArrayInt widthsAbs =
+        CalculateAbsWidths(GetClientSize().x - extraWidth*(m_nFields - 1));

 
 

-        int nVarWidth = (nWindowWidth - nTotalWidth) / nVarCount;
+    int *pWidths = new int[m_nFields];

 
 

-        // do fill the array
-        int nCurPos = 0;
-        for ( i = 0; i < m_nFields; i++ ) {
-            if ( m_statusWidths[i] == -1 )
-                nCurPos += nVarWidth;
-            else
-                nCurPos += m_statusWidths[i] + extraWidth;
-            pWidths[i] = nCurPos;
-        }
+    int nCurPos = 0;
+    for ( int i = 0; i < m_nFields; i++ ) {
+        nCurPos += widthsAbs[i] + extraWidth;
+        pWidths[i] = nCurPos;

     }
 
     if ( !StatusBar_SetParts(GetHwnd(), m_nFields, pWidths) ) {
     }
 
     if ( !StatusBar_SetParts(GetHwnd(), m_nFields, pWidths) ) {


@@ -241,9 +193,33 @@ void wxStatusBar95::SetStatusText(const wxString& strText, int nField)
     wxCHECK_RET( (nField >= 0) && (nField < m_nFields),
                  _T("invalid statusbar field index") );
 
     wxCHECK_RET( (nField >= 0) && (nField < m_nFields),
                  _T("invalid statusbar field index") );
 

-  if ( !StatusBar_SetText(GetHwnd(), nField, strText) ) {
-    wxLogLastError(wxT("StatusBar_SetText"));
-  }
+    // Get field style, if any
+    int style;
+    if (m_statusStyles)
+    {
+        switch(m_statusStyles[nField])
+        {
+        case wxSB_RAISED:
+            style = SBT_POPOUT;
+            break;
+        case wxSB_FLAT:
+            style = SBT_NOBORDERS;
+            break;
+        case wxSB_NORMAL:
+        default:
+            style = 0;
+            break;
+        }
+    }
+    else
+        style = 0;
+
+    // Pass both field number and style. MSDN library doesn't mention
+    // that nField and style have to be 'ORed'
+    if ( !StatusBar_SetText(GetHwnd(), nField | style, strText) )
+    {
+        wxLogLastError(wxT("StatusBar_SetText"));
+    }

 }
 
 wxString wxStatusBar95::GetStatusText(int nField) const
 }
 
 wxString wxStatusBar95::GetStatusText(int nField) const


@@ -251,14 +227,14 @@ wxString wxStatusBar95::GetStatusText(int nField) const
     wxCHECK_MSG( (nField >= 0) && (nField < m_nFields), wxEmptyString,
                  _T("invalid statusbar field index") );
 
     wxCHECK_MSG( (nField >= 0) && (nField < m_nFields), wxEmptyString,
                  _T("invalid statusbar field index") );
 

-  wxString str;
-  int len = StatusBar_GetTextLen(GetHwnd(), nField);
-  if (len > 0)
-  {
-    StatusBar_GetText(GetHwnd(), nField, str.GetWriteBuf(len));
-    str.UngetWriteBuf();
-  }
-  return str;
+    wxString str;
+    int len = StatusBar_GetTextLen(GetHwnd(), nField);
+    if ( len > 0 )
+    {
+        StatusBar_GetText(GetHwnd(), nField, wxStringBuffer(str, len));
+    }
+
+    return str;

 }
 
 int wxStatusBar95::GetBorderX() const
 }
 
 int wxStatusBar95::GetBorderX() const


@@ -287,26 +263,81 @@ void wxStatusBar95::SetMinHeight(int height)
 
 bool wxStatusBar95::GetFieldRect(int i, wxRect& rect) const
 {
 
 bool wxStatusBar95::GetFieldRect(int i, wxRect& rect) const
 {

-    wxCHECK_MSG( (i >= 0) && (i < m_nFields), FALSE,
+    wxCHECK_MSG( (i >= 0) && (i < m_nFields), false,

                  _T("invalid statusbar field index") );
 
     RECT r;
     if ( !::SendMessage(GetHwnd(), SB_GETRECT, i, (LPARAM)&r) )
     {
                  _T("invalid statusbar field index") );
 
     RECT r;
     if ( !::SendMessage(GetHwnd(), SB_GETRECT, i, (LPARAM)&r) )
     {

-        wxLogLastError("SendMessage(SB_GETRECT)");
+        wxLogLastError(wxT("SendMessage(SB_GETRECT)"));

     }
 
     wxCopyRECTToRect(r, rect);
 
     }
 
     wxCopyRECTToRect(r, rect);
 

-    return TRUE;
+    return true;

 }
 
 void wxStatusBar95::DoMoveWindow(int x, int y, int width, int height)
 {
 }
 
 void wxStatusBar95::DoMoveWindow(int x, int y, int width, int height)
 {

-  FORWARD_WM_SIZE(GetHwnd(), SIZE_RESTORED, x, y, SendMessage);
+    // the status bar wnd proc must be forwarded the WM_SIZE message whenever
+    // the stat bar position/size is changed because it normally positions the
+    // control itself along bottom or top side of the parent window - failing
+    // to do so will result in nasty visual effects
+    FORWARD_WM_SIZE(GetHwnd(), SIZE_RESTORED, x, y, SendMessage);
+
+    // but now, when the standard status bar wnd proc did all it wanted to do,
+    // move the status bar to its correct location - usually this call may be
+    // omitted because for normal status bars (positioned along the bottom
+    // edge) the position is already set correctly, but if the user wants to
+    // position them in some exotic location, this is really needed
+    wxWindowMSW::DoMoveWindow(x, y, width, height);
+
+    // adjust fields widths to the new size
+    SetFieldsWidth();
+
+    // we have to trigger wxSizeEvent if there are children window in status
+    // bar because GetFieldRect returned incorrect (not updated) values up to
+    // here, which almost certainly resulted in incorrectly redrawn statusbar
+    if ( m_children.GetCount() > 0 )
+    {
+        wxSizeEvent event(GetClientSize(), m_windowId);
+        event.SetEventObject(this);
+        GetEventHandler()->ProcessEvent(event);
+    }
+}

 
 

-  // adjust fields widths to the new size
-  SetFieldsWidth();
+void wxStatusBar95::SetStatusStyles(int n, const int styles[])
+{
+    wxStatusBarBase::SetStatusStyles(n, styles);
+
+    if (n != m_nFields)
+        return;
+
+    for (int i = 0; i < n; i++)
+    {
+        int style;
+        switch(styles[i])
+        {
+        case wxSB_RAISED:
+            style = SBT_POPOUT;
+            break;
+        case wxSB_FLAT:
+            style = SBT_NOBORDERS;
+            break;
+        case wxSB_NORMAL:
+        default:
+            style = 0;
+            break;
+        }
+        // The SB_SETTEXT message is both used to set the field's text as well as
+        // the fields' styles. MSDN library doesn't mention
+        // that nField and style have to be 'ORed'
+        wxString text = GetStatusText(i);
+        if (!StatusBar_SetText(GetHwnd(), style | i, text))
+        {
+            wxLogLastError(wxT("StatusBar_SetText"));
+        }
+    }

 }
 
 #endif // __WIN95__ && wxUSE_NATIVE_STATUSBAR
 }
 
 #endif // __WIN95__ && wxUSE_NATIVE_STATUSBAR