fix compilation when one of wxUSE_LISTCTRL and wxUSE_TREECTRL is defined but the...

[wxWidgets.git] / src / common / combocmn.cpp

diff --git a/src/common/combocmn.cpp b/src/common/combocmn.cpp
index fbad3278429902abe5fa26fed879f7aab04be8d2..a633163d30719a911163b9f504190a44e03edbdd 100644 (file)
--- a/src/common/combocmn.cpp
+++ b/src/common/combocmn.cpp
@@ -35,7 +35,6 @@
     #include "wx/timer.h"
 #endif
 
     #include "wx/timer.h"
 #endif
 

-#include "wx/dcbuffer.h"

 #include "wx/tooltip.h"
 
 #include "wx/combo.h"
 #include "wx/tooltip.h"
 
 #include "wx/combo.h"


@@ -45,15 +44,11 @@
 // constants
 // ----------------------------------------------------------------------------
 
 // constants
 // ----------------------------------------------------------------------------
 

-// Milliseconds to wait for two mouse-ups after focus inorder
-// to trigger a double-click.
-#define DOUBLE_CLICK_CONVERSION_TRESHOLD        500
-

 #define DEFAULT_DROPBUTTON_WIDTH                19
 
 #define BMP_BUTTON_MARGIN                       4
 
 #define DEFAULT_DROPBUTTON_WIDTH                19
 
 #define BMP_BUTTON_MARGIN                       4
 

-#define DEFAULT_POPUP_HEIGHT                    200
+#define DEFAULT_POPUP_HEIGHT                    400

 
 #define DEFAULT_TEXT_INDENT                     3
 
 
 #define DEFAULT_TEXT_INDENT                     3
 


@@ -63,21 +58,43 @@
 #if defined(__WXMSW__)
 
 #define USE_TRANSIENT_POPUP           1 // Use wxPopupWindowTransient (preferred, if it works properly on platform)
 #if defined(__WXMSW__)
 
 #define USE_TRANSIENT_POPUP           1 // Use wxPopupWindowTransient (preferred, if it works properly on platform)

+#define TRANSIENT_POPUPWIN_IS_PERFECT 0 // wxPopupTransientWindow works, its child can have focus, and common
+                                        // native controls work on it like normal.
+#define POPUPWIN_IS_PERFECT           0 // Same, but for non-transient popup window.
+#define TEXTCTRL_TEXT_CENTERED        0 // 1 if text in textctrl is vertically centered

 
 //#undef wxUSE_POPUPWIN
 //#define wxUSE_POPUPWIN 0
 
 #elif defined(__WXGTK__)
 
 
 //#undef wxUSE_POPUPWIN
 //#define wxUSE_POPUPWIN 0
 
 #elif defined(__WXGTK__)
 

+// NB: It is not recommended to use wxDialog as popup on wxGTK, because of
+//     this bug: If wxDialog is hidden, its position becomes corrupt
+//     between hide and next show, but without internal coordinates being
+//     reflected (or something like that - atleast commenting out ->Hide()
+//     seemed to eliminate the position change).
+

 #define USE_TRANSIENT_POPUP           1 // Use wxPopupWindowTransient (preferred, if it works properly on platform)
 #define USE_TRANSIENT_POPUP           1 // Use wxPopupWindowTransient (preferred, if it works properly on platform)

+#define TRANSIENT_POPUPWIN_IS_PERFECT 0 // wxPopupTransientWindow works, its child can have focus, and common
+                                        // native controls work on it like normal.
+#define POPUPWIN_IS_PERFECT           1 // Same, but for non-transient popup window.
+#define TEXTCTRL_TEXT_CENTERED        1 // 1 if text in textctrl is vertically centered

 
 #elif defined(__WXMAC__)
 
 #define USE_TRANSIENT_POPUP           0 // Use wxPopupWindowTransient (preferred, if it works properly on platform)
 
 #elif defined(__WXMAC__)
 
 #define USE_TRANSIENT_POPUP           0 // Use wxPopupWindowTransient (preferred, if it works properly on platform)

+#define TRANSIENT_POPUPWIN_IS_PERFECT 0 // wxPopupTransientWindow works, its child can have focus, and common
+                                        // native controls work on it like normal.
+#define POPUPWIN_IS_PERFECT           0 // Same, but for non-transient popup window.
+#define TEXTCTRL_TEXT_CENTERED        1 // 1 if text in textctrl is vertically centered

 
 #else
 
 #define USE_TRANSIENT_POPUP           0 // Use wxPopupWindowTransient (preferred, if it works properly on platform)
 
 #else
 
 #define USE_TRANSIENT_POPUP           0 // Use wxPopupWindowTransient (preferred, if it works properly on platform)

+#define TRANSIENT_POPUPWIN_IS_PERFECT 0 // wxPopupTransientWindow works, its child can have focus, and common
+                                        // native controls work on it like normal.
+#define POPUPWIN_IS_PERFECT           0 // Same, but for non-transient popup window.
+#define TEXTCTRL_TEXT_CENTERED        1 // 1 if text in textctrl is vertically centered

 
 #endif
 
 
 #endif
 


@@ -99,23 +116,76 @@
 #endif
 
 
 #endif
 
 

-#if USE_TRANSIENT_POPUP
+// Define different types of popup windows
+enum
+{
+    POPUPWIN_NONE                   = 0,
+    POPUPWIN_WXPOPUPTRANSIENTWINDOW = 1,
+    POPUPWIN_WXPOPUPWINDOW          = 2,
+    POPUPWIN_WXDIALOG               = 3
+};
+

 
 

-    #define wxComboPopupWindowBase wxPopupTransientWindow
-    #define INSTALL_TOPLEV_HANDLER       0
+#if USE_TRANSIENT_POPUP
+    // wxPopupTransientWindow is implemented
+
+    #define wxComboPopupWindowBase  wxPopupTransientWindow
+    #define PRIMARY_POPUP_TYPE      POPUPWIN_WXPOPUPTRANSIENTWINDOW
+    #define USES_WXPOPUPTRANSIENTWINDOW 1
+
+    #if TRANSIENT_POPUPWIN_IS_PERFECT
+        //
+    #elif POPUPWIN_IS_PERFECT
+        #define wxComboPopupWindowBase2     wxPopupWindow
+        #define SECONDARY_POPUP_TYPE        POPUPWIN_WXPOPUPWINDOW
+        #define USES_WXPOPUPWINDOW          1
+    #else
+        #define wxComboPopupWindowBase2     wxDialog
+        #define SECONDARY_POPUP_TYPE        POPUPWIN_WXDIALOG
+        #define USES_WXDIALOG               1
+    #endif

 
 #elif wxUSE_POPUPWIN
 
 #elif wxUSE_POPUPWIN

+    // wxPopupWindow (but not wxPopupTransientWindow) is properly implemented
+
+    #define wxComboPopupWindowBase      wxPopupWindow
+    #define PRIMARY_POPUP_TYPE          POPUPWIN_WXPOPUPWINDOW
+    #define USES_WXPOPUPWINDOW          1

 
 

-    #define wxComboPopupWindowBase wxPopupWindow
-    #define INSTALL_TOPLEV_HANDLER       1
+    #if !POPUPWIN_IS_PERFECT
+        #define wxComboPopupWindowBase2     wxDialog
+        #define SECONDARY_POPUP_TYPE        POPUPWIN_WXDIALOG
+        #define USES_WXDIALOG               1
+    #endif

 
 #else
 
 #else

+    // wxPopupWindow is not implemented
+
+    #define wxComboPopupWindowBase      wxDialog
+    #define PRIMARY_POPUP_TYPE          POPUPWIN_WXDIALOG
+    #define USES_WXDIALOG               1
+
+#endif
+

 
 

-    #define wxComboPopupWindowBase wxDialog
-    #define INSTALL_TOPLEV_HANDLER      0 // Doesn't need since can monitor active event
+#ifndef USES_WXPOPUPTRANSIENTWINDOW
+    #define USES_WXPOPUPTRANSIENTWINDOW 0
+#endif

 
 

+#ifndef USES_WXPOPUPWINDOW
+    #define USES_WXPOPUPWINDOW          0

 #endif
 
 #endif
 

+#ifndef USES_WXDIALOG
+    #define USES_WXDIALOG               0
+#endif
+
+
+#if USES_WXPOPUPWINDOW
+    #define INSTALL_TOPLEV_HANDLER      1
+#else
+    #define INSTALL_TOPLEV_HANDLER      0
+#endif

 
 
 //
 
 
 //


@@ -140,7 +210,7 @@ class wxComboFrameEventHandler : public wxEvtHandler
 {
 public:
     wxComboFrameEventHandler( wxComboCtrlBase* pCb );
 {
 public:
     wxComboFrameEventHandler( wxComboCtrlBase* pCb );

-    ~wxComboFrameEventHandler();
+    virtual ~wxComboFrameEventHandler();

 
     void OnPopup();
 
 
     void OnPopup();
 


@@ -249,7 +319,7 @@ void wxComboFrameEventHandler::OnMove( wxMoveEvent& event )
 #endif // INSTALL_TOPLEV_HANDLER
 
 // ----------------------------------------------------------------------------
 #endif // INSTALL_TOPLEV_HANDLER
 
 // ----------------------------------------------------------------------------

-// wxComboPopupWindow is wxPopupWindow customized for
+// wxComboPopupWindow is, in essence, wxPopupWindow customized for

 // wxComboCtrl.
 // ----------------------------------------------------------------------------
 
 // wxComboCtrl.
 // ----------------------------------------------------------------------------
 


@@ -257,105 +327,142 @@ class wxComboPopupWindow : public wxComboPopupWindowBase
 {
 public:
 
 {
 public:
 

-    wxComboPopupWindow( wxComboCtrlBase *parent, int style = wxBORDER_NONE );
+    wxComboPopupWindow( wxComboCtrlBase *parent,
+                        int style )
+    #if USES_WXPOPUPWINDOW || USES_WXPOPUPTRANSIENTWINDOW
+                       : wxComboPopupWindowBase(parent,style)
+    #else
+                       : wxComboPopupWindowBase(parent,
+                                                wxID_ANY,
+                                                wxEmptyString,
+                                                wxPoint(-21,-21),
+                                                wxSize(20,20),
+                                                style)
+    #endif
+    {
+        m_inShow = 0;
+    }

 
 

-#if USE_TRANSIENT_POPUP
+#if USES_WXPOPUPTRANSIENTWINDOW
+    virtual bool Show( bool show );

     virtual bool ProcessLeftDown(wxMouseEvent& event);
     virtual bool ProcessLeftDown(wxMouseEvent& event);

+    virtual void OnDismiss();

 #endif
 
 #endif
 

-    void OnKeyEvent(wxKeyEvent& event);
+private:
+    wxByte      m_inShow;
+};

 
 

-    void OnMouseEvent( wxMouseEvent& event );
-#if !wxUSE_POPUPWIN
-    void OnActivate( wxActivateEvent& event );
-#endif

 
 

-protected:
+#if USES_WXPOPUPTRANSIENTWINDOW
+bool wxComboPopupWindow::Show( bool show )
+{
+    // Guard against recursion
+    if ( m_inShow )
+        return wxComboPopupWindowBase::Show(show);

 
 

-#if USE_TRANSIENT_POPUP
-    virtual void OnDismiss();
+    m_inShow++;
+
+    wxASSERT( IsKindOf(CLASSINFO(wxPopupTransientWindow)) );
+
+    wxPopupTransientWindow* ptw = (wxPopupTransientWindow*) this;
+    wxComboCtrlBase* combo = (wxComboCtrlBase*) GetParent();
+
+    if ( show != ptw->IsShown() )
+    {
+        if ( show )
+            ptw->Popup(combo->GetPopupControl()->GetControl());
+        else
+            ptw->Dismiss();
+    }
+
+    m_inShow--;
+
+    return true;
+}
+
+bool wxComboPopupWindow::ProcessLeftDown(wxMouseEvent& event)
+{
+    return wxPopupTransientWindow::ProcessLeftDown(event);
+}
+
+// First thing that happens when a transient popup closes is that this method gets called.
+void wxComboPopupWindow::OnDismiss()
+{
+    wxComboCtrlBase* combo = (wxComboCtrlBase*) GetParent();
+    wxASSERT_MSG( combo->IsKindOf(CLASSINFO(wxComboCtrlBase)),
+                  wxT("parent might not be wxComboCtrl, but check IMPLEMENT_DYNAMIC_CLASS(2) macro for correctness") );
+
+    combo->OnPopupDismiss();
+}
+#endif // USES_WXPOPUPTRANSIENTWINDOW
+
+
+// ----------------------------------------------------------------------------
+// wxComboPopupWindowEvtHandler does bulk of the custom event handling
+// of a popup window. It is separate so we can have different types
+// of popup windows.
+// ----------------------------------------------------------------------------
+
+class wxComboPopupWindowEvtHandler : public wxEvtHandler
+{
+public:
+
+    wxComboPopupWindowEvtHandler( wxComboCtrlBase *parent )
+    {
+        m_combo = parent;
+    }
+
+    void OnSizeEvent( wxSizeEvent& event );
+    void OnKeyEvent(wxKeyEvent& event);
+#if USES_WXDIALOG
+    void OnActivate( wxActivateEvent& event );

 #endif
 
 private:
 #endif
 
 private:

+    wxComboCtrlBase*    m_combo;
+

     DECLARE_EVENT_TABLE()
 };
 
 
     DECLARE_EVENT_TABLE()
 };
 
 

-BEGIN_EVENT_TABLE(wxComboPopupWindow, wxComboPopupWindowBase)
-    EVT_MOUSE_EVENTS(wxComboPopupWindow::OnMouseEvent)
-#if !wxUSE_POPUPWIN
-    EVT_ACTIVATE(wxComboPopupWindow::OnActivate)
+BEGIN_EVENT_TABLE(wxComboPopupWindowEvtHandler, wxEvtHandler)
+    EVT_KEY_DOWN(wxComboPopupWindowEvtHandler::OnKeyEvent)
+    EVT_KEY_UP(wxComboPopupWindowEvtHandler::OnKeyEvent)
+#if USES_WXDIALOG
+    EVT_ACTIVATE(wxComboPopupWindowEvtHandler::OnActivate)

 #endif
 #endif

-    EVT_KEY_DOWN(wxComboPopupWindow::OnKeyEvent)
-    EVT_KEY_UP(wxComboPopupWindow::OnKeyEvent)
+    EVT_SIZE(wxComboPopupWindowEvtHandler::OnSizeEvent)

 END_EVENT_TABLE()
 
 
 END_EVENT_TABLE()
 
 

-wxComboPopupWindow::wxComboPopupWindow( wxComboCtrlBase *parent,
-                                        int style )
-#if wxUSE_POPUPWIN
-                                       : wxComboPopupWindowBase(parent,style)
-#else
-                                       : wxComboPopupWindowBase(parent,
-                                                                wxID_ANY,
-                                                                wxEmptyString,
-                                                                wxPoint(-21,-21),
-                                                                wxSize(20,20),
-                                                                style)
-#endif
+void wxComboPopupWindowEvtHandler::OnSizeEvent( wxSizeEvent& WXUNUSED(event) )

 {
 {

+    // Block the event so that the popup control does not get auto-resized.

 }
 
 }
 

-void wxComboPopupWindow::OnKeyEvent( wxKeyEvent& event )
+void wxComboPopupWindowEvtHandler::OnKeyEvent( wxKeyEvent& event )

 {
     // Relay keyboard event to the main child controls
 {
     // Relay keyboard event to the main child controls

-    // (just skipping may just cause the popup to close)
-    wxWindowList children = GetChildren();
+    wxWindowList children = m_combo->GetPopupWindow()->GetChildren();

     wxWindowList::iterator node = children.begin();
     wxWindow* child = (wxWindow*)*node;
     child->AddPendingEvent(event);
 }
 
     wxWindowList::iterator node = children.begin();
     wxWindow* child = (wxWindow*)*node;
     child->AddPendingEvent(event);
 }
 

-void wxComboPopupWindow::OnMouseEvent( wxMouseEvent& event )
-{
-    event.Skip();
-}
-
-#if !wxUSE_POPUPWIN
-void wxComboPopupWindow::OnActivate( wxActivateEvent& event )
+#if USES_WXDIALOG
+void wxComboPopupWindowEvtHandler::OnActivate( wxActivateEvent& event )

 {
     if ( !event.GetActive() )
     {
         // Tell combo control that we are dismissed.
 {
     if ( !event.GetActive() )
     {
         // Tell combo control that we are dismissed.

-        wxComboCtrl* combo = (wxComboCtrl*) GetParent();
-        wxASSERT( combo );
-        wxASSERT( combo->IsKindOf(CLASSINFO(wxComboCtrl)) );
-
-        combo->HidePopup();
+        m_combo->HidePopup();

 
         event.Skip();
     }
 }
 #endif
 
 
         event.Skip();
     }
 }
 #endif
 

-#if USE_TRANSIENT_POPUP
-bool wxComboPopupWindow::ProcessLeftDown(wxMouseEvent& event )
-{
-    return wxComboPopupWindowBase::ProcessLeftDown(event);
-}
-#endif
-
-#if USE_TRANSIENT_POPUP
-// First thing that happens when a transient popup closes is that this method gets called.
-void wxComboPopupWindow::OnDismiss()
-{
-    wxComboCtrlBase* combo = (wxComboCtrlBase*) GetParent();
-    wxASSERT_MSG( combo->IsKindOf(CLASSINFO(wxComboCtrlBase)),
-                  wxT("parent might not be wxComboCtrl, but check IMPLEMENT_DYNAMIC_CLASS(2) macro for correctness") );
-
-    combo->OnPopupDismiss();
-}
-#endif

 
 // ----------------------------------------------------------------------------
 // wxComboPopup
 
 // ----------------------------------------------------------------------------
 // wxComboPopup


@@ -386,7 +493,7 @@ void wxComboPopup::DefaultPaintComboControl( wxComboCtrlBase* combo,
 {
     if ( combo->GetWindowStyle() & wxCB_READONLY ) // ie. no textctrl
     {
 {
     if ( combo->GetWindowStyle() & wxCB_READONLY ) // ie. no textctrl
     {

-        combo->DrawFocusBackground(dc,rect,0);
+        combo->PrepareBackground(dc,rect,0);

 
         dc.DrawText( combo->GetValue(),
                      rect.x + combo->GetTextIndent(),
 
         dc.DrawText( combo->GetValue(),
                      rect.x + combo->GetTextIndent(),


@@ -438,7 +545,7 @@ public:
     {
         m_combo = combo;
     }
     {
         m_combo = combo;
     }

-    ~wxComboBoxExtraInputHandler() { }
+    virtual ~wxComboBoxExtraInputHandler() { }

     void OnKey(wxKeyEvent& event);
     void OnFocus(wxFocusEvent& event);
 
     void OnKey(wxKeyEvent& event);
     void OnFocus(wxFocusEvent& event);
 


@@ -510,7 +617,7 @@ public:
         m_combo = combo;
         m_beenInside = false;
     }
         m_combo = combo;
         m_beenInside = false;
     }

-    ~wxComboPopupExtraEventHandler() { }
+    virtual ~wxComboPopupExtraEventHandler() { }

 
     void OnMouseEvent( wxMouseEvent& event );
 
 
     void OnMouseEvent( wxMouseEvent& event );
 


@@ -547,7 +654,7 @@ void wxComboPopupExtraEventHandler::OnMouseEvent( wxMouseEvent& event )
          evtType == wxEVT_RIGHT_DOWN )
     {
         // Block motion and click events outside the popup
          evtType == wxEVT_RIGHT_DOWN )
     {
         // Block motion and click events outside the popup

-        if ( !isInside )
+        if ( !isInside || !m_combo->IsPopupShown() )

         {
             event.Skip(false);
             return;
         {
             event.Skip(false);
             return;


@@ -555,11 +662,10 @@ void wxComboPopupExtraEventHandler::OnMouseEvent( wxMouseEvent& event )
     }
     else if ( evtType == wxEVT_LEFT_UP )
     {
     }
     else if ( evtType == wxEVT_LEFT_UP )
     {

-        // Don't let left-down events in if outside
-        if ( evtType == wxEVT_LEFT_DOWN )
+        if ( !m_combo->IsPopupShown() )

         {
         {

-            if ( !isInside )
-                return;
+            event.Skip(false);
+            return;

         }
 
         if ( !m_beenInside )
         }
 
         if ( !m_beenInside )


@@ -610,14 +716,11 @@ END_EVENT_TABLE()
 
 IMPLEMENT_ABSTRACT_CLASS(wxComboCtrlBase, wxControl)
 
 
 IMPLEMENT_ABSTRACT_CLASS(wxComboCtrlBase, wxControl)
 

-// Have global double buffer - should be enough for multiple combos
-static wxBitmap* gs_doubleBuffer = (wxBitmap*) NULL;
-

 void wxComboCtrlBase::Init()
 {
     m_winPopup = (wxWindow *)NULL;
     m_popup = (wxWindow *)NULL;
 void wxComboCtrlBase::Init()
 {
     m_winPopup = (wxWindow *)NULL;
     m_popup = (wxWindow *)NULL;

-    m_isPopupShown = false;
+    m_popupWinState = Hidden;

     m_btn = (wxWindow*) NULL;
     m_text = (wxTextCtrl*) NULL;
     m_popupInterface = (wxComboPopup*) NULL;
     m_btn = (wxWindow*) NULL;
     m_text = (wxTextCtrl*) NULL;
     m_popupInterface = (wxComboPopup*) NULL;


@@ -629,6 +732,8 @@ void wxComboCtrlBase::Init()
     m_toplevEvtHandler = (wxEvtHandler*) NULL;
 #endif
 
     m_toplevEvtHandler = (wxEvtHandler*) NULL;
 #endif
 

+    m_mainCtrlWnd = this;
+

     m_heightPopup = -1;
     m_widthMinPopup = -1;
     m_anchorSide = 0;
     m_heightPopup = -1;
     m_widthMinPopup = -1;
     m_anchorSide = 0;


@@ -638,6 +743,8 @@ void wxComboCtrlBase::Init()
     m_btnState = 0;
     m_btnWidDefault = 0;
     m_blankButtonBg = false;
     m_btnState = 0;
     m_btnWidDefault = 0;
     m_blankButtonBg = false;

+    m_ignoreEvtText = 0;
+    m_popupWinType = POPUPWIN_NONE;

     m_btnWid = m_btnHei = -1;
     m_btnSide = wxRIGHT;
     m_btnSpacingX = 0;
     m_btnWid = m_btnHei = -1;
     m_btnSide = wxRIGHT;
     m_btnSpacingX = 0;


@@ -646,7 +753,6 @@ void wxComboCtrlBase::Init()
     m_extRight = 0;
     m_absIndent = -1;
     m_iFlags = 0;
     m_extRight = 0;
     m_absIndent = -1;
     m_iFlags = 0;

-    m_downReceived = false;

     m_timeCanAcceptClick = 0;
 }
 
     m_timeCanAcceptClick = 0;
 }
 


@@ -701,6 +807,9 @@ wxComboCtrlBase::CreateTextCtrl(int style, const wxValidator& validator)
 {
     if ( !(m_windowStyle & wxCB_READONLY) )
     {
 {
     if ( !(m_windowStyle & wxCB_READONLY) )
     {

+        if ( m_text )
+            m_text->Destroy();
+

         // wxTE_PROCESS_TAB is needed because on Windows, wxTAB_TRAVERSAL is
         // not used by the wxPropertyGrid and therefore the tab is processed by
         // looking at ancestors to see if they have wxTAB_TRAVERSAL. The
         // wxTE_PROCESS_TAB is needed because on Windows, wxTAB_TRAVERSAL is
         // not used by the wxPropertyGrid and therefore the tab is processed by
         // looking at ancestors to see if they have wxTAB_TRAVERSAL. The


@@ -710,18 +819,23 @@ wxComboCtrlBase::CreateTextCtrl(int style, const wxValidator& validator)
         if ( HasFlag(wxTE_PROCESS_ENTER) )
             style |= wxTE_PROCESS_ENTER;
 
         if ( HasFlag(wxTE_PROCESS_ENTER) )
             style |= wxTE_PROCESS_ENTER;
 

+        // Ignore EVT_TEXT generated by the constructor (but only
+        // if the event redirector already exists)
+        // NB: This must be " = 1" instead of "++";
+        if ( m_textEvtHandler )
+            m_ignoreEvtText = 1;
+        else
+            m_ignoreEvtText = 0;
+

         m_text = new wxTextCtrl(this, wxID_ANY, m_valueString,
         m_text = new wxTextCtrl(this, wxID_ANY, m_valueString,

-                                wxDefaultPosition, wxDefaultSize,
+                                wxDefaultPosition, wxSize(10,-1),

                                 style, validator);
                                 style, validator);

-
-        // This is required for some platforms (GTK+ atleast)
-        m_text->SetSizeHints(2,4);

     }
 }
 
 void wxComboCtrlBase::OnThemeChange()
 {
     }
 }
 
 void wxComboCtrlBase::OnThemeChange()
 {

-    SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));
+    SetOwnBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));

 }
 
 wxComboCtrlBase::~wxComboCtrlBase()
 }
 
 wxComboCtrlBase::~wxComboCtrlBase()


@@ -729,9 +843,6 @@ wxComboCtrlBase::~wxComboCtrlBase()
     if ( HasCapture() )
         ReleaseMouse();
 
     if ( HasCapture() )
         ReleaseMouse();
 

-    delete gs_doubleBuffer;
-    gs_doubleBuffer = (wxBitmap*) NULL;
-

 #if INSTALL_TOPLEV_HANDLER
     delete ((wxComboFrameEventHandler*)m_toplevEvtHandler);
     m_toplevEvtHandler = (wxEvtHandler*) NULL;
 #if INSTALL_TOPLEV_HANDLER
     delete ((wxComboFrameEventHandler*)m_toplevEvtHandler);
     m_toplevEvtHandler = (wxEvtHandler*) NULL;


@@ -878,6 +989,7 @@ void wxComboCtrlBase::PositionTextCtrl( int textCtrlXAdjust, int textCtrlYAdjust
     wxSize sz = GetClientSize();
     int customBorder = m_widthCustomBorder;
 
     wxSize sz = GetClientSize();
     int customBorder = m_widthCustomBorder;
 

+#if !TEXTCTRL_TEXT_CENTERED

     if ( (m_text->GetWindowStyleFlag() & wxBORDER_MASK) == wxNO_BORDER )
     {
         // Centre textctrl
     if ( (m_text->GetWindowStyleFlag() & wxBORDER_MASK) == wxNO_BORDER )
     {
         // Centre textctrl


@@ -904,11 +1016,16 @@ void wxComboCtrlBase::PositionTextCtrl( int textCtrlXAdjust, int textCtrlYAdjust
         }
     }
     else
         }
     }
     else

+#else
+    wxUnusedVar(textCtrlXAdjust);
+    wxUnusedVar(textCtrlYAdjust);
+#endif

     {
     {

-        m_text->SetSize( m_tcArea.x,
-                         0,
-                         sz.x - m_btnArea.x - m_widthCustomPaint - customBorder,
-                         sz.y );
+        // If it has border, have textctrl will the entire text field.
+        m_text->SetSize( m_tcArea.x + m_widthCustomPaint,
+                         customBorder,
+                         sz.x - m_btnArea.width - m_widthCustomPaint - customBorder,
+                         sz.y-(customBorder*2) );

     }
 }
 
     }
 }
 


@@ -1036,8 +1153,9 @@ void wxComboCtrlBase::DoSetToolTip(wxToolTip *tooltip)
 // painting
 // ----------------------------------------------------------------------------
 
 // painting
 // ----------------------------------------------------------------------------
 

-// draw focus background on area in a way typical on platform
-void wxComboCtrlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int flags ) const
+#if (!defined(__WXMSW__)) || defined(__WXUNIVERSAL__)
+// prepare combo box background on area in a way typical on platform
+void wxComboCtrlBase::PrepareBackground( wxDC& dc, const wxRect& rect, int flags ) const

 {
     wxSize sz = GetClientSize();
     bool isEnabled;
 {
     wxSize sz = GetClientSize();
     bool isEnabled;


@@ -1106,14 +1224,26 @@ void wxComboCtrlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int fla
     dc.SetBrush( bgCol );
     dc.SetPen( bgCol );
     dc.DrawRectangle( selRect );
     dc.SetBrush( bgCol );
     dc.SetPen( bgCol );
     dc.DrawRectangle( selRect );

+
+    // Don't clip exactly to the selection rectangle so we can draw
+    // to the non-selected area in front of it.
+    wxRect clipRect(rect.x,rect.y,
+                    (selRect.x+selRect.width)-rect.x,rect.height);
+    dc.SetClippingRegion(clipRect);
+}
+#else
+// Save the library size a bit for platforms that re-implement this.
+void wxComboCtrlBase::PrepareBackground( wxDC&, const wxRect&, int ) const
+{

 }
 }

+#endif

 
 

-void wxComboCtrlBase::DrawButton( wxDC& dc, const wxRect& rect, bool paintBg )
+void wxComboCtrlBase::DrawButton( wxDC& dc, const wxRect& rect, int paintBg )

 {
     int drawState = m_btnState;
 
 #ifdef __WXGTK__
 {
     int drawState = m_btnState;
 
 #ifdef __WXGTK__

-    if ( m_isPopupShown )
+    if ( GetPopupWindowState() >= Animating )

         drawState |= wxCONTROL_PRESSED;
 #endif
 
         drawState |= wxCONTROL_PRESSED;
 #endif
 


@@ -1217,25 +1347,21 @@ void wxComboCtrlBase::RecalcAndRefresh()
     }
 }
 
     }
 }
 

-wxBitmap& wxComboCtrlBase::GetBufferBitmap( const wxSize& sz ) const
-{
-    // If size is larger, recalculate double buffer bitmap
-    if ( !gs_doubleBuffer ||
-         sz.x > gs_doubleBuffer->GetWidth() ||
-         sz.y > gs_doubleBuffer->GetHeight() )
-    {
-        delete gs_doubleBuffer;
-        gs_doubleBuffer = new wxBitmap(sz.x+25,sz.y);
-    }
-    return *gs_doubleBuffer;
-}
-

 // ----------------------------------------------------------------------------
 // miscellaneous event handlers
 // ----------------------------------------------------------------------------
 
 void wxComboCtrlBase::OnTextCtrlEvent(wxCommandEvent& event)
 {
 // ----------------------------------------------------------------------------
 // miscellaneous event handlers
 // ----------------------------------------------------------------------------
 
 void wxComboCtrlBase::OnTextCtrlEvent(wxCommandEvent& event)
 {

+    if ( event.GetEventType() == wxEVT_COMMAND_TEXT_UPDATED )
+    {
+        if ( m_ignoreEvtText > 0 )
+        {
+            m_ignoreEvtText--;
+            return;
+        }
+    }
+

     // Change event id, object and string before relaying it forward
     event.SetId(GetId());
     wxString s = event.GetString();
     // Change event id, object and string before relaying it forward
     event.SetId(GetId());
     wxString s = event.GetString();


@@ -1270,28 +1396,19 @@ bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,
             Refresh();
         }
     }
             Refresh();
         }
     }

-    else if ( type == wxEVT_LEFT_DOWN )
+    else if ( type == wxEVT_LEFT_DOWN || type == wxEVT_LEFT_DCLICK )

     {
     {

-        // Only accept event if it wasn't right after popup dismiss
-        //if ( ::wxGetLocalTimeMillis() > m_timeCanClick )
+        if ( flags & (wxCC_MF_ON_CLICK_AREA|wxCC_MF_ON_BUTTON) )

         {
         {

-            // Need to test this, because it might be outside.
-            if ( flags & wxCC_MF_ON_BUTTON )
-            {
-                m_btnState |= wxCONTROL_PRESSED;
-                Refresh();
+            m_btnState |= wxCONTROL_PRESSED;
+            Refresh();

 
 

-                if ( !(m_iFlags & wxCC_POPUP_ON_MOUSE_UP) )
-                    OnButtonClick();
-                else
-                    // If showing popup now, do not capture mouse or there will be interference
-                    CaptureMouse();
-            }
+            if ( !(m_iFlags & wxCC_POPUP_ON_MOUSE_UP) )
+                OnButtonClick();
+            else
+                // If showing popup now, do not capture mouse or there will be interference
+                CaptureMouse();

         }
         }

-        /*else
-        {
-            m_btnState = 0;
-        }*/

     }
     else if ( type == wxEVT_LEFT_UP )
     {
     }
     else if ( type == wxEVT_LEFT_UP )
     {


@@ -1305,7 +1422,7 @@ bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,
             // If mouse was inside, fire the click event.
             if ( m_iFlags & wxCC_POPUP_ON_MOUSE_UP )
             {
             // If mouse was inside, fire the click event.
             if ( m_iFlags & wxCC_POPUP_ON_MOUSE_UP )
             {

-                if ( flags & wxCC_MF_ON_BUTTON )
+                if ( flags & (wxCC_MF_ON_CLICK_AREA|wxCC_MF_ON_BUTTON) )

                     OnButtonClick();
             }
 
                     OnButtonClick();
             }
 


@@ -1320,7 +1437,7 @@ bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,
             m_btnState &= ~(wxCONTROL_CURRENT);
 
             // Mouse hover ends
             m_btnState &= ~(wxCONTROL_CURRENT);
 
             // Mouse hover ends

-            if ( !m_isPopupShown )
+            if ( IsPopupWindowState(Hidden) )

             {
                 m_btnState &= ~(wxCONTROL_PRESSED);
                 Refresh();
             {
                 m_btnState &= ~(wxCONTROL_PRESSED);
                 Refresh();


@@ -1333,65 +1450,24 @@ bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,
     return true;
 }
 
     return true;
 }
 

-// Conversion to double-clicks and some basic filtering

 // returns true if event was consumed or filtered
 // returns true if event was consumed or filtered

-//bool wxComboCtrlBase::PreprocessMouseEvent( wxMouseEvent& event, bool isOnButtonArea )

 bool wxComboCtrlBase::PreprocessMouseEvent( wxMouseEvent& event,
 bool wxComboCtrlBase::PreprocessMouseEvent( wxMouseEvent& event,

-                                               int flags )
+                                            int WXUNUSED(flags) )

 {
     wxLongLong t = ::wxGetLocalTimeMillis();
     int evtType = event.GetEventType();
 
 {
     wxLongLong t = ::wxGetLocalTimeMillis();
     int evtType = event.GetEventType();
 

-#if !USE_TRANSIENT_POPUP
-    if ( m_isPopupShown &&
-         ( evtType == wxEVT_LEFT_DOWN || evtType == wxEVT_RIGHT_DOWN ) )
+#if USES_WXPOPUPWINDOW || USES_WXDIALOG
+    if ( m_popupWinType != POPUPWIN_WXPOPUPTRANSIENTWINDOW )

     {
     {

-        HidePopup();
-        return true;
-    }
-#endif
-
-    //
-    // Generate our own double-clicks
-    // (to allow on-focus dc-event on double-clicks instead of triple-clicks)
-    if ( (m_windowStyle & wxCC_SPECIAL_DCLICK) &&
-         !m_isPopupShown &&
-         //!(handlerFlags & wxCC_MF_ON_BUTTON) )
-         !(flags & wxCC_MF_ON_BUTTON) )
-    {
-        if ( evtType == wxEVT_LEFT_DOWN )
-        {
-            // Set value to avoid up-events without corresponding downs
-            m_downReceived = true;
-        }
-        else if ( evtType == wxEVT_LEFT_DCLICK )
+        if ( IsPopupWindowState(Visible) &&
+             ( evtType == wxEVT_LEFT_DOWN || evtType == wxEVT_RIGHT_DOWN ) )

         {
         {

-            // We'll make our own double-clicks
-            //evtType = 0;
-            event.SetEventType(0);
+            HidePopup();

             return true;
         }
             return true;
         }

-        else if ( evtType == wxEVT_LEFT_UP )
-        {
-            if ( m_downReceived || m_timeLastMouseUp == 1 )
-            {
-                wxLongLong timeFromLastUp = (t-m_timeLastMouseUp);
-
-                if ( timeFromLastUp < DOUBLE_CLICK_CONVERSION_TRESHOLD )
-                {
-                    //type = wxEVT_LEFT_DCLICK;
-                    event.SetEventType(wxEVT_LEFT_DCLICK);
-                    m_timeLastMouseUp = 1;
-                }
-                else
-                {
-                    m_timeLastMouseUp = t;
-                }
-
-                //m_downReceived = false;
-            }
-        }

     }
     }

+#endif

 
     // Filter out clicks on button immediately after popup dismiss (Windows like behaviour)
     if ( evtType == wxEVT_LEFT_DOWN && t < m_timeCanAcceptClick )
 
     // Filter out clicks on button immediately after popup dismiss (Windows like behaviour)
     if ( evtType == wxEVT_LEFT_DOWN && t < m_timeCanAcceptClick )


@@ -1410,13 +1486,12 @@ void wxComboCtrlBase::HandleNormalMouseEvent( wxMouseEvent& event )
     if ( (evtType == wxEVT_LEFT_DOWN || evtType == wxEVT_LEFT_DCLICK) &&
          (m_windowStyle & wxCB_READONLY) )
     {
     if ( (evtType == wxEVT_LEFT_DOWN || evtType == wxEVT_LEFT_DCLICK) &&
          (m_windowStyle & wxCB_READONLY) )
     {

-        if ( m_isPopupShown )
+        if ( GetPopupWindowState() >= Animating )

         {
         {

-    #if !wxUSE_POPUPWIN
-        // Normally do nothing - evt handler should close it for us
-    #elif !USE_TRANSIENT_POPUP
+    #if USES_WXPOPUPWINDOW

             // Click here always hides the popup.
             // Click here always hides the popup.

-            HidePopup();
+            if ( m_popupWinType == POPUPWIN_WXPOPUPWINDOW )
+                HidePopup();

     #endif
         }
         else
     #endif
         }
         else


@@ -1437,7 +1512,7 @@ void wxComboCtrlBase::HandleNormalMouseEvent( wxMouseEvent& event )
         }
     }
     else
         }
     }
     else

-    if ( m_isPopupShown )
+    if ( IsPopupShown() )

     {
         // relay (some) mouse events to the popup
         if ( evtType == wxEVT_MOUSEWHEEL )
     {
         // relay (some) mouse events to the popup
         if ( evtType == wxEVT_MOUSEWHEEL )


@@ -1461,11 +1536,15 @@ void wxComboCtrlBase::OnKeyEvent(wxKeyEvent& event)
         if ( keycode == WXK_TAB )
         {
             wxNavigationKeyEvent evt;
         if ( keycode == WXK_TAB )
         {
             wxNavigationKeyEvent evt;

+
+            wxWindow* mainCtrl = GetMainWindowOfCompositeControl();
+

             evt.SetFlags(wxNavigationKeyEvent::FromTab|
                          (!event.ShiftDown() ? wxNavigationKeyEvent::IsForward
                                              : wxNavigationKeyEvent::IsBackward));
             evt.SetFlags(wxNavigationKeyEvent::FromTab|
                          (!event.ShiftDown() ? wxNavigationKeyEvent::IsForward
                                              : wxNavigationKeyEvent::IsBackward));

-            evt.SetEventObject(this);
-            GetParent()->GetEventHandler()->AddPendingEvent(evt);
+            evt.SetEventObject(mainCtrl);
+            evt.SetCurrentFocus(mainCtrl);
+            mainCtrl->GetParent()->GetEventHandler()->AddPendingEvent(evt);

             return;
         }
 
             return;
         }
 


@@ -1498,14 +1577,11 @@ void wxComboCtrlBase::OnFocusEvent( wxFocusEvent& event )
 {
     if ( event.GetEventType() == wxEVT_SET_FOCUS )
     {
 {
     if ( event.GetEventType() == wxEVT_SET_FOCUS )
     {

-        // First click is the first part of double-click
-        // Some platforms don't generate down-less mouse up-event
-        // (Windows does, GTK+2 doesn't), so that's why we have
-        // to do this.
-        m_timeLastMouseUp = ::wxGetLocalTimeMillis();
-
-        if ( m_text && m_text != ::wxWindow::FindFocus() )
-            m_text->SetFocus();
+#ifndef __WXMAC__
+        wxWindow* tc = GetTextCtrl();
+        if ( tc && tc != DoFindFocus() )
+            tc->SetFocus();
+#endif

     }
 
     Refresh();
     }
 
     Refresh();


@@ -1531,7 +1607,28 @@ void wxComboCtrlBase::CreatePopup()
     wxWindow* popup;
 
     if ( !m_winPopup )
     wxWindow* popup;
 
     if ( !m_winPopup )

-        m_winPopup = new wxComboPopupWindow( this, wxNO_BORDER );
+    {
+#ifdef wxComboPopupWindowBase2
+        if ( m_iFlags & wxCC_IFLAG_USE_ALT_POPUP )
+        {
+        #if !USES_WXDIALOG
+            m_winPopup = new wxComboPopupWindowBase2( this, wxNO_BORDER );
+        #else
+            m_winPopup = new wxComboPopupWindowBase2( this, wxID_ANY, wxEmptyString,
+                                                      wxPoint(-21,-21), wxSize(20, 20),
+                                                      wxNO_BORDER );
+        #endif
+            m_popupWinType = SECONDARY_POPUP_TYPE;
+        }
+        else
+#endif
+        {
+            m_winPopup = new wxComboPopupWindow( this, wxNO_BORDER );
+            m_popupWinType = PRIMARY_POPUP_TYPE;
+        }
+        m_popupWinEvtHandler = new wxComboPopupWindowEvtHandler(this);
+        m_winPopup->PushEventHandler(m_popupWinEvtHandler);
+    }

 
     popupInterface->Create(m_winPopup);
     m_popup = popup = popupInterface->GetControl();
 
     popupInterface->Create(m_winPopup);
     m_popup = popup = popupInterface->GetControl();


@@ -1560,7 +1657,12 @@ void wxComboCtrlBase::DestroyPopup()
     delete m_popupInterface;
 
     if ( m_winPopup )
     delete m_popupInterface;
 
     if ( m_winPopup )

+    {
+        m_winPopup->RemoveEventHandler(m_popupWinEvtHandler);
+        delete m_popupWinEvtHandler;
+        m_popupWinEvtHandler = NULL;

         m_winPopup->Destroy();
         m_winPopup->Destroy();

+    }

 
     m_popupExtraHandler = (wxEvtHandler*) NULL;
     m_popupInterface = (wxComboPopup*) NULL;
 
     m_popupExtraHandler = (wxEvtHandler*) NULL;
     m_popupInterface = (wxComboPopup*) NULL;


@@ -1613,7 +1715,10 @@ void wxComboCtrlBase::OnButtonClick()
 void wxComboCtrlBase::ShowPopup()
 {
     EnsurePopupControl();
 void wxComboCtrlBase::ShowPopup()
 {
     EnsurePopupControl();

-    wxCHECK_RET( !IsPopupShown(), wxT("popup window already shown") );
+    wxCHECK_RET( !IsPopupWindowState(Visible), wxT("popup window already shown") );
+
+    if ( IsPopupWindowState(Animating) )
+        return;

 
     SetFocus();
 
 
     SetFocus();
 


@@ -1670,6 +1775,8 @@ void wxComboCtrlBase::ShowPopup()
         popup = m_popup;
     }
 
         popup = m_popup;
     }
 

+    winPopup->Enable();
+    

     wxASSERT( !m_popup || m_popup == popup ); // Consistency check.
 
     wxSize adjustedSize = m_popupInterface->GetAdjustedSize(widthPopup,
     wxASSERT( !m_popup || m_popup == popup ); // Consistency check.
 
     wxSize adjustedSize = m_popupInterface->GetAdjustedSize(widthPopup,


@@ -1729,22 +1836,27 @@ void wxComboCtrlBase::ShowPopup()
     else
         popupX = 0;
 
     else
         popupX = 0;
 

+    int showFlags = CanDeferShow;
+

     if ( spaceBelow < szp.y )
     {
         popupY = scrPos.y - szp.y;
     if ( spaceBelow < szp.y )
     {
         popupY = scrPos.y - szp.y;

+        showFlags |= ShowAbove;

     }
 
     }
 

-    // Move to position
-    //wxLogDebug(wxT("popup scheduled position1: %i,%i"),ptp.x,ptp.y);
-    //wxLogDebug(wxT("popup position1: %i,%i"),winPopup->GetPosition().x,winPopup->GetPosition().y);
-
-    // Some platforms (GTK) may need these two to be separate
-    winPopup->SetSize( szp.x, szp.y );
-    winPopup->Move( popupX, popupY );
-
-    //wxLogDebug(wxT("popup position2: %i,%i"),winPopup->GetPosition().x,winPopup->GetPosition().y);
+#if INSTALL_TOPLEV_HANDLER
+    // Put top level window event handler into place
+    if ( m_popupWinType == POPUPWIN_WXPOPUPWINDOW )
+    {
+        if ( !m_toplevEvtHandler )
+            m_toplevEvtHandler = new wxComboFrameEventHandler(this);

 
 

-    m_popup = popup;
+        wxWindow* toplev = ::wxGetTopLevelParent( this );
+        wxASSERT( toplev );
+        ((wxComboFrameEventHandler*)m_toplevEvtHandler)->OnPopup();
+        toplev->PushEventHandler( m_toplevEvtHandler );
+    }
+#endif

 
     // Set string selection (must be this way instead of SetStringSelection)
     if ( m_text )
 
     // Set string selection (must be this way instead of SetStringSelection)
     if ( m_text )


@@ -1761,36 +1873,62 @@ void wxComboCtrlBase::ShowPopup()
     }
 
     // This must be after SetStringValue
     }
 
     // This must be after SetStringValue

-    m_isPopupShown = true;
+    m_popupWinState = Animating;

 
 

-    // Show it
-#if USE_TRANSIENT_POPUP
-    ((wxPopupTransientWindow*)winPopup)->Popup(popup);
-#else
-    winPopup->Show();
-#endif
+    wxRect popupWinRect( popupX, popupY, szp.x, szp.y );

 
 

-#if INSTALL_TOPLEV_HANDLER
-    // Put top level window event handler into place
-    if ( !m_toplevEvtHandler )
-        m_toplevEvtHandler = new wxComboFrameEventHandler(this);
+    m_popup = popup;
+    if ( (m_iFlags & wxCC_IFLAG_DISABLE_POPUP_ANIM) ||
+         AnimateShow( popupWinRect, showFlags ) )
+    {
+        DoShowPopup( popupWinRect, showFlags );
+    }
+}

 
 

-    wxWindow* toplev = ::wxGetTopLevelParent( this );
-    wxASSERT( toplev );
-    ((wxComboFrameEventHandler*)m_toplevEvtHandler)->OnPopup();
-    toplev->PushEventHandler( m_toplevEvtHandler );
-#endif
+bool wxComboCtrlBase::AnimateShow( const wxRect& WXUNUSED(rect), int WXUNUSED(flags) )
+{
+    return true;
+}

 
 

+void wxComboCtrlBase::DoShowPopup( const wxRect& rect, int WXUNUSED(flags) )
+{
+    wxWindow* winPopup = m_winPopup;
+
+    if ( IsPopupWindowState(Animating) )
+    {
+        // Make sure the popup window is shown in the right position.
+        // Should not matter even if animation already did this.
+
+        // Some platforms (GTK) may like SetSize and Move to be separate
+        // (though the bug was probably fixed).
+        winPopup->SetSize( rect );
+
+        winPopup->Show();
+
+        m_popupWinState = Visible;
+    }
+    else if ( IsPopupWindowState(Hidden) )
+    {
+        // Animation was aborted
+
+        wxASSERT( !winPopup->IsShown() );
+
+        m_popupWinState = Hidden;
+    }

 }
 
 void wxComboCtrlBase::OnPopupDismiss()
 {
     // Just in case, avoid double dismiss
 }
 
 void wxComboCtrlBase::OnPopupDismiss()
 {
     // Just in case, avoid double dismiss

-    if ( !m_isPopupShown )
+    if ( IsPopupWindowState(Hidden) )

         return;
 
         return;
 

-    // *Must* set this before focus etc.
-    m_isPopupShown = false;
+    // This must be set before focus - otherwise there will be recursive
+    // OnPopupDismisses.
+    m_popupWinState = Hidden;
+
+    //SetFocus();
+    m_winPopup->Disable();

 
     // Inform popup control itself
     m_popupInterface->OnDismiss();
 
     // Inform popup control itself
     m_popupInterface->OnDismiss();


@@ -1808,11 +1946,14 @@ void wxComboCtrlBase::OnPopupDismiss()
     }
 #endif
 
     }
 #endif
 

-    m_timeCanAcceptClick = ::wxGetLocalTimeMillis() + 150;
+    m_timeCanAcceptClick = ::wxGetLocalTimeMillis();
+
+    if ( m_popupWinType == POPUPWIN_WXPOPUPTRANSIENTWINDOW )
+        m_timeCanAcceptClick += 150;

 
     // If cursor not on dropdown button, then clear its state
     // (technically not required by all ports, but do it for all just in case)
 
     // If cursor not on dropdown button, then clear its state
     // (technically not required by all ports, but do it for all just in case)

-    if ( !m_btnArea.Inside(ScreenToClient(::wxGetMousePosition())) )
+    if ( !m_btnArea.Contains(ScreenToClient(::wxGetMousePosition())) )

         m_btnState = 0;
 
     // Return parent's tab traversal flag.
         m_btnState = 0;
 
     // Return parent's tab traversal flag.


@@ -1827,27 +1968,20 @@ void wxComboCtrlBase::OnPopupDismiss()
     // refresh control (necessary even if m_text)
     Refresh();
 
     // refresh control (necessary even if m_text)
     Refresh();
 

-#if !wxUSE_POPUPWIN

     SetFocus();
     SetFocus();

-#endif
-

 }
 
 void wxComboCtrlBase::HidePopup()
 {
     // Should be able to call this without popup interface
 }
 
 void wxComboCtrlBase::HidePopup()
 {
     // Should be able to call this without popup interface

-    //wxCHECK_RET( m_popupInterface, _T("no popup interface") );
-    if ( !m_isPopupShown )
+    if ( IsPopupWindowState(Hidden) )

         return;
 
     // transfer value and show it in textctrl, if any
         return;
 
     // transfer value and show it in textctrl, if any

-    SetValue( m_popupInterface->GetStringValue() );
+    if ( !IsPopupWindowState(Animating) )
+        SetValue( m_popupInterface->GetStringValue() );

 
 

-#if USE_TRANSIENT_POPUP
-    ((wxPopupTransientWindow*)m_winPopup)->Dismiss();
-#else

     m_winPopup->Hide();
     m_winPopup->Hide();

-#endif

 
     OnPopupDismiss();
 }
 
     OnPopupDismiss();
 }


@@ -1962,10 +2096,13 @@ wxString wxComboCtrlBase::GetValue() const
     return m_valueString;
 }
 
     return m_valueString;
 }
 

-void wxComboCtrlBase::SetValue(const wxString& value)
+void wxComboCtrlBase::SetValueWithEvent(const wxString& value, bool withEvent)

 {
     if ( m_text )
     {
 {
     if ( m_text )
     {

+        if ( !withEvent )
+            m_ignoreEvtText++;
+

         m_text->SetValue(value);
         if ( !(m_iFlags & wxCC_NO_TEXT_AUTO_SELECT) )
             m_text->SelectAll();
         m_text->SetValue(value);
         if ( !(m_iFlags & wxCC_NO_TEXT_AUTO_SELECT) )
             m_text->SelectAll();


@@ -1983,6 +2120,11 @@ void wxComboCtrlBase::SetValue(const wxString& value)
     }
 }
 
     }
 }
 

+void wxComboCtrlBase::SetValue(const wxString& value)
+{
+    SetValueWithEvent(value, false);
+}
+

 // In this SetValue variant wxComboPopup::SetStringValue is not called
 void wxComboCtrlBase::SetText(const wxString& value)
 {
 // In this SetValue variant wxComboPopup::SetStringValue is not called
 void wxComboCtrlBase::SetText(const wxString& value)
 {


@@ -1992,6 +2134,12 @@ void wxComboCtrlBase::SetText(const wxString& value)
 
     m_valueString = value;
 
 
     m_valueString = value;
 

+    if ( m_text )
+    {
+        m_ignoreEvtText++;
+        m_text->SetValue( value );
+    }
+

     Refresh();
 }
 
     Refresh();
 }