use wxIsSameDouble() and wxIsNullDouble() for warning-less double comparison of doubles

[wxWidgets.git] / src / univ / button.cpp

diff --git a/src/univ/button.cpp b/src/univ/button.cpp
index 6306d33ac5a2897a90dfd253a27aab5421b6c028..f41f45b6e6d7648149bbcce0e479927cbe7cd56f 100644 (file)
--- a/src/univ/button.cpp
+++ b/src/univ/button.cpp
@@ -17,10 +17,6 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#ifdef __GNUG__
-    #pragma implementation "univbutton.h"
-#endif
-

 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__


@@ -41,6 +37,7 @@
 #include "wx/univ/inphand.h"
 #include "wx/univ/theme.h"
 #include "wx/univ/colschem.h"
 #include "wx/univ/inphand.h"
 #include "wx/univ/theme.h"
 #include "wx/univ/colschem.h"

+#include "wx/stockitem.h"

 
 // ----------------------------------------------------------------------------
 // constants
 
 // ----------------------------------------------------------------------------
 // constants


@@ -63,27 +60,44 @@ IMPLEMENT_DYNAMIC_CLASS(wxButton, wxControl)
 void wxButton::Init()
 {
     m_isPressed =
 void wxButton::Init()
 {
     m_isPressed =

-    m_isDefault = FALSE;
+    m_isDefault = false;

 }
 
 bool wxButton::Create(wxWindow *parent,
                       wxWindowID id,
                       const wxBitmap& bitmap,
 }
 
 bool wxButton::Create(wxWindow *parent,
                       wxWindowID id,
                       const wxBitmap& bitmap,

-                      const wxString &label,
+                      const wxString &lbl,

                       const wxPoint &pos,
                       const wxSize &size,
                       long style,
                       const wxValidator& validator,
                       const wxString &name)
 {
                       const wxPoint &pos,
                       const wxSize &size,
                       long style,
                       const wxValidator& validator,
                       const wxString &name)
 {

-    // center label by default
-    if ( !(style & wxALIGN_MASK) )
-    {
-        style |= wxALIGN_CENTRE_HORIZONTAL | wxALIGN_CENTRE_VERTICAL;
-    }
+    wxString label(lbl);
+    if (label.empty() && wxIsStockID(id))
+        label = wxGetStockLabel(id);
+
+    long ctrl_style = style & ~wxBU_ALIGN_MASK;
+
+    wxASSERT_MSG( (ctrl_style & wxALIGN_MASK) == 0,
+                  _T("Some style conflicts with align flags") );
+
+    if((style & wxBU_RIGHT) == wxBU_RIGHT)
+        ctrl_style |= wxALIGN_RIGHT;
+    else if((style & wxBU_LEFT) == wxBU_LEFT)
+        ctrl_style |= wxALIGN_LEFT;
+    else
+        ctrl_style |= wxALIGN_CENTRE_HORIZONTAL;
+
+    if((style & wxBU_TOP) == wxBU_TOP)
+        ctrl_style |= wxALIGN_TOP;
+    else if((style & wxBU_BOTTOM) == wxBU_BOTTOM)
+        ctrl_style |= wxALIGN_BOTTOM;
+    else
+        ctrl_style |= wxALIGN_CENTRE_VERTICAL;

 
 

-    if ( !wxControl::Create(parent, id, pos, size, style, wxDefaultValidator, name) )
-        return FALSE;
+    if ( !wxControl::Create(parent, id, pos, size, ctrl_style, validator, name) )
+        return false;

 
     SetLabel(label);
     SetImageLabel(bitmap);
 
     SetLabel(label);
     SetImageLabel(bitmap);


@@ -91,7 +105,7 @@ bool wxButton::Create(wxWindow *parent,
 
     CreateInputHandler(wxINP_HANDLER_BUTTON);
 
 
     CreateInputHandler(wxINP_HANDLER_BUTTON);
 

-    return TRUE;
+    return true;

 }
 
 wxButton::~wxButton()
 }
 
 wxButton::~wxButton()


@@ -113,8 +127,11 @@ wxSize wxButtonBase::GetDefaultSize()
 
         // this corresponds more or less to wxMSW standard in Win32 theme (see
         // wxWin32Renderer::AdjustSize())
 
         // this corresponds more or less to wxMSW standard in Win32 theme (see
         // wxWin32Renderer::AdjustSize())

-        s_sizeBtn.x = 8*dc.GetCharWidth();
-        s_sizeBtn.y = (11*dc.GetCharHeight())/10 + 2;
+//        s_sizeBtn.x = 8*dc.GetCharWidth();
+//        s_sizeBtn.y = (11*dc.GetCharHeight())/10 + 2;
+        // Otto Wyss, Patch 664399
+        s_sizeBtn.x = dc.GetCharWidth()*10 + 2;
+        s_sizeBtn.y = dc.GetCharHeight()*11/10 + 2;

     }
 
     return s_sizeBtn;
     }
 
     return s_sizeBtn;


@@ -136,9 +153,14 @@ wxSize wxButton::DoGetBestClientSize() const
         width += m_bitmap.GetWidth() + 2*m_marginBmpX;
     }
 
         width += m_bitmap.GetWidth() + 2*m_marginBmpX;
     }
 

+    // The default size should not be adjusted, so the code is moved into the
+    // renderer. This is conceptual wrong but currently the only solution.
+    // (Otto Wyss, Patch 664399)
+
+/*

     // for compatibility with other ports, the buttons default size is never
     // less than the standard one, but not when display not PDAs.
     // for compatibility with other ports, the buttons default size is never
     // less than the standard one, but not when display not PDAs.

-    if (wxSystemSettings::GetScreen() < wxSYS_SCREEN_PDA)
+    if (wxSystemSettings::GetScreenType() > wxSYS_SCREEN_PDA)

     {
         if ( !(GetWindowStyle() & wxBU_EXACTFIT) )
         {
     {
         if ( !(GetWindowStyle() & wxBU_EXACTFIT) )
         {


@@ -147,7 +169,7 @@ wxSize wxButton::DoGetBestClientSize() const
                 width = szDef.x;
         }
     }
                 width = szDef.x;
         }
     }

-
+*/

     return wxSize(width, height);
 }
 
     return wxSize(width, height);
 }
 


@@ -171,7 +193,7 @@ bool wxButton::DoDrawBackground(wxDC& dc)
     wxSize size = GetSize();
     rect.width = size.x;
     rect.height = size.y;
     wxSize size = GetSize();
     rect.width = size.x;
     rect.height = size.y;

-    
+

     if ( GetBackgroundBitmap().Ok() )
     {
         // get the bitmap and the flags
     if ( GetBackgroundBitmap().Ok() )
     {
         // get the bitmap and the flags


@@ -186,7 +208,7 @@ bool wxButton::DoDrawBackground(wxDC& dc)
                                       rect, GetStateFlags());
     }
 
                                       rect, GetStateFlags());
     }
 

-    return TRUE;
+    return true;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -197,7 +219,7 @@ void wxButton::Press()
 {
     if ( !m_isPressed )
     {
 {
     if ( !m_isPressed )
     {

-        m_isPressed = TRUE;
+        m_isPressed = true;

 
         Refresh();
     }
 
         Refresh();
     }


@@ -207,7 +229,7 @@ void wxButton::Release()
 {
     if ( m_isPressed )
     {
 {
     if ( m_isPressed )
     {

-        m_isPressed = FALSE;
+        m_isPressed = false;

 
         Refresh();
     }
 
         Refresh();
     }


@@ -249,7 +271,7 @@ bool wxButton::PerformAction(const wxControlAction& action,
     else
         return wxControl::PerformAction(action, numArg, strArg);
 
     else
         return wxControl::PerformAction(action, numArg, strArg);
 

-    return TRUE;
+    return true;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -267,13 +289,13 @@ void wxButton::SetImageMargins(wxCoord x, wxCoord y)
 {
     m_marginBmpX = x + 2;
     m_marginBmpY = y + 2;
 {
     m_marginBmpX = x + 2;
     m_marginBmpY = y + 2;

-    
+

     SetBestSize(wxDefaultSize);
 }
 
 void wxButton::SetDefault()
 {
     SetBestSize(wxDefaultSize);
 }
 
 void wxButton::SetDefault()
 {

-    m_isDefault = TRUE;
+    m_isDefault = true;

 }
 
 // ============================================================================
 }
 
 // ============================================================================


@@ -284,7 +306,7 @@ wxStdButtonInputHandler::wxStdButtonInputHandler(wxInputHandler *handler)
                        : wxStdInputHandler(handler)
 {
     m_winCapture = NULL;
                        : wxStdInputHandler(handler)
 {
     m_winCapture = NULL;

-    m_winHasMouse = FALSE;
+    m_winHasMouse = false;

 }
 
 bool wxStdButtonInputHandler::HandleKey(wxInputConsumer *consumer,
 }
 
 bool wxStdButtonInputHandler::HandleKey(wxInputConsumer *consumer,


@@ -296,7 +318,7 @@ bool wxStdButtonInputHandler::HandleKey(wxInputConsumer *consumer,
     {
         consumer->PerformAction(wxACTION_BUTTON_TOGGLE);
 
     {
         consumer->PerformAction(wxACTION_BUTTON_TOGGLE);
 

-        return TRUE;
+        return true;

     }
 
     return wxStdInputHandler::HandleKey(consumer, event, pressed);
     }
 
     return wxStdInputHandler::HandleKey(consumer, event, pressed);


@@ -319,11 +341,11 @@ bool wxStdButtonInputHandler::HandleMouse(wxInputConsumer *consumer,
         {
             m_winCapture = consumer->GetInputWindow();
             m_winCapture->CaptureMouse();
         {
             m_winCapture = consumer->GetInputWindow();
             m_winCapture->CaptureMouse();

-            m_winHasMouse = TRUE;
+            m_winHasMouse = true;

 
             consumer->PerformAction(wxACTION_BUTTON_PRESS);
 
 
             consumer->PerformAction(wxACTION_BUTTON_PRESS);
 

-            return TRUE;
+            return true;

         }
         else if ( event.LeftUp() )
         {
         }
         else if ( event.LeftUp() )
         {


@@ -338,7 +360,7 @@ bool wxStdButtonInputHandler::HandleMouse(wxInputConsumer *consumer,
                 // this will generate a click event
                 consumer->PerformAction(wxACTION_BUTTON_TOGGLE);
 
                 // this will generate a click event
                 consumer->PerformAction(wxACTION_BUTTON_TOGGLE);
 

-                return TRUE;
+                return true;

             }
             //else: the mouse was released outside the window, this doesn't
             //      count as a click
             }
             //else: the mouse was released outside the window, this doesn't
             //      count as a click


@@ -360,46 +382,46 @@ bool wxStdButtonInputHandler::HandleMouseMove(wxInputConsumer *consumer,
         if ( event.Leaving() )
         {
             // remember that the mouse is now outside
         if ( event.Leaving() )
         {
             // remember that the mouse is now outside

-            m_winHasMouse = FALSE;
+            m_winHasMouse = false;

 
             // we do have a pressed button, so release it
 
             // we do have a pressed button, so release it

-            consumer->GetInputWindow()->SetCurrent(FALSE);
+            consumer->GetInputWindow()->SetCurrent(false);

             consumer->PerformAction(wxACTION_BUTTON_RELEASE);
 
             consumer->PerformAction(wxACTION_BUTTON_RELEASE);
 

-            return TRUE;
+            return true;

         }
         // and entering it back should make it pressed again if it had been
         // pressed
         else if ( event.Entering() )
         {
             // the mouse is (back) inside the button
         }
         // and entering it back should make it pressed again if it had been
         // pressed
         else if ( event.Entering() )
         {
             // the mouse is (back) inside the button

-            m_winHasMouse = TRUE;
+            m_winHasMouse = true;

 
             // we did have a pressed button which we released when leaving the
             // window, press it again
 
             // we did have a pressed button which we released when leaving the
             // window, press it again

-            consumer->GetInputWindow()->SetCurrent(TRUE);
+            consumer->GetInputWindow()->SetCurrent(true);

             consumer->PerformAction(wxACTION_BUTTON_PRESS);
 
             consumer->PerformAction(wxACTION_BUTTON_PRESS);
 

-            return TRUE;
+            return true;

         }
     }
 
     return wxStdInputHandler::HandleMouseMove(consumer, event);
 }
 
         }
     }
 
     return wxStdInputHandler::HandleMouseMove(consumer, event);
 }
 

-bool wxStdButtonInputHandler::HandleFocus(wxInputConsumer *consumer,
-                                          const wxFocusEvent& event)
+bool wxStdButtonInputHandler::HandleFocus(wxInputConsumer * WXUNUSED(consumer),
+                                          const wxFocusEvent& WXUNUSED(event))

 {
 {

-    // buttons change appearance when they get/lose focus, so return TRUE to
+    // buttons change appearance when they get/lose focus, so return true to

     // refresh
     // refresh

-    return TRUE;
+    return true;

 }
 
 bool wxStdButtonInputHandler::HandleActivation(wxInputConsumer *consumer,
 }
 
 bool wxStdButtonInputHandler::HandleActivation(wxInputConsumer *consumer,

-                                               bool activated)
+                                               bool WXUNUSED(activated))

 {
     // the default button changes appearance when the app is [de]activated, so
 {
     // the default button changes appearance when the app is [de]activated, so

-    // return TRUE to refresh
+    // return true to refresh

     return wxStaticCast(consumer->GetInputWindow(), wxButton)->IsDefault();
 }
 
     return wxStaticCast(consumer->GetInputWindow(), wxButton)->IsDefault();
 }