Applied patch [ 1443707 ] kill "cast truncates constant value" warnings

[wxWidgets.git] / src / motif / colour.cpp

diff --git a/src/motif/colour.cpp b/src/motif/colour.cpp
index b77ec7a38bac47545d152de125965fe2045cff54..473e2028645ad8d305defded82c910cf493f32f3 100644 (file)
--- a/src/motif/colour.cpp
+++ b/src/motif/colour.cpp
@@ -1,20 +1,19 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        colour.cpp
+// Name:        src/motif/colour.cpp
 // Purpose:     wxColour class
 // Author:      Julian Smart
 // Modified by:
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart
-// Licence:    wxWindows licence
+// Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 //// TODO: make wxColour a ref-counted object,
 //// so pixel values get shared.
 
-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "colour.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
 
 #include "wx/gdicmn.h"
 #include "wx/colour.h"
@@ -34,16 +33,21 @@ IMPLEMENT_DYNAMIC_CLASS(wxColour, wxObject)
 
 // Colour
 
-wxColour::wxColour ()
+void wxColour::Init()
 {
-    m_isInit = FALSE;
+    m_isInit = false;
     m_red =
     m_blue =
     m_green = 0;
     m_pixel = -1;
 }
 
-wxColour::wxColour (const wxColour& col)
+wxColour::wxColour()
+{
+    Init();
+}
+
+wxColour::wxColour(const wxColour& col)
 {
     *this = col;
 }
@@ -60,7 +64,18 @@ wxColour& wxColour::operator =(const wxColour& col)
 
 void wxColour::InitFromName(const wxString& name)
 {
-    *this = wxTheColourDatabase->Find(name);
+    if ( wxTheColourDatabase )
+    {
+        wxColour col = wxTheColourDatabase->Find(name);
+        if ( col.Ok() )
+        {
+            *this = col;
+            return;
+        }
+    }
+
+    // leave invalid
+    Init();
 }
 
 /* static */
@@ -73,31 +88,31 @@ wxColour wxColour::CreateByName(const wxString& name)
     XColor xcol;
     if ( XParseColor( dpy, (Colormap)colormap, name.mb_str(), &xcol ) )
     {
-        col.m_red = xcol.red & 0xff;
-        col.m_green = xcol.green & 0xff;
-        col.m_blue = xcol.blue & 0xff;
-        col.m_isInit = TRUE;
+        col.m_red = (unsigned char)(xcol.red & 0xff);
+        col.m_green = (unsigned char)(xcol.green & 0xff);
+        col.m_blue = (unsigned char)(xcol.blue & 0xff);
+        col.m_isInit = true;
         col.m_pixel = -1;
     }
 
     return col;
 }
 
-wxColour::~wxColour ()
+wxColour::~wxColour()
 {
 }
 
-void wxColour::Set (unsigned char r, unsigned char g, unsigned char b)
+void wxColour::Set(unsigned char r, unsigned char g, unsigned char b)
 {
     m_red = r;
     m_green = g;
     m_blue = b;
-    m_isInit = TRUE;
+    m_isInit = true;
     m_pixel = -1;
 }
 
 // Allocate a colour, or nearest colour, using the given display.
-// If realloc is TRUE, ignore the existing pixel, otherwise just return
+// If realloc is true, ignore the existing pixel, otherwise just return
 // the existing one.
 // Returns the old or allocated pixel.
 
@@ -108,19 +123,19 @@ int wxColour::AllocColour(WXDisplay* display, bool realloc)
 {
     if ((m_pixel != -1) && !realloc)
         return m_pixel;
-    
+
     XColor color;
     color.red = (unsigned short) Red ();
-    color.red |= color.red << 8;
+    color.red |= (unsigned short)(color.red << 8);
     color.green = (unsigned short) Green ();
-    color.green |= color.green << 8;
+    color.green |= (unsigned short)(color.green << 8);
     color.blue = (unsigned short) Blue ();
-    color.blue |= color.blue << 8;
-    
+    color.blue |= (unsigned short)(color.blue << 8);
+
     color.flags = DoRed | DoGreen | DoBlue;
-    
+
     WXColormap cmap = wxTheApp->GetMainColormap(display);
-    
+
     if (!XAllocColor ((Display*) display, (Colormap) cmap, &color))
     {
         m_pixel = wxGetBestMatchingPixel((Display*) display, &color,(Colormap) cmap);
@@ -167,7 +182,7 @@ int wxGetBestMatchingPixel(Display *display, XColor *desiredColor, Colormap cmap
 {
     if (cmap == (Colormap) NULL)
         cmap = (Colormap) wxTheApp->GetMainColormap(display);
-    
+
     int numPixVals = XDisplayCells(display, DefaultScreen (display));
     int mindist = 256 * 256 * 3;
     int bestpixel = (int) BlackPixel (display, DefaultScreen (display));
@@ -175,21 +190,21 @@ int wxGetBestMatchingPixel(Display *display, XColor *desiredColor, Colormap cmap
     int green = desiredColor->green >> 8;
     int blue = desiredColor->blue >> 8;
     const int threshold = 2 * 2 * 3;    // allow an error of up to 2 in R,G & B
-    
+
     for (int pixelcount = 0; pixelcount < numPixVals; pixelcount++)
     {
         XColor matching_color;
         matching_color.pixel = pixelcount;
         XQueryColor(display,cmap,&matching_color);
-        
+
         int delta_red = red - (matching_color.red >> 8);
         int delta_green = green - (matching_color.green >> 8);
         int delta_blue = blue - (matching_color.blue >> 8);
-        
+
         int dist = delta_red * delta_red +
             delta_green * delta_green +
             delta_blue * delta_blue;
-        
+
         if (dist <= threshold)
         {
             // try to allocate a read-only colour...