handle NULL BSTRs as empty ones per Microsoft convention

[wxWidgets.git] / src / cocoa / gauge.mm

diff --git a/src/cocoa/gauge.mm b/src/cocoa/gauge.mm
index 08b164e41965f381d1a41034acc52429692997dd..b28f42360675123b6ea1970f98276d840efd0f13 100644 (file)
--- a/src/cocoa/gauge.mm
+++ b/src/cocoa/gauge.mm
@@ -1,20 +1,22 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        cocoa/gauge.mm
+// Name:        src/cocoa/gauge.mm
 // Purpose:     wxGauge
 // Author:      David Elliott
 // Modified by:
 // Created:     2003/07/15
 // RCS-ID:      $Id$
 // Copyright:   (c) 2003 David Elliott
-// Licence:    wxWidgets licence
+// Licence:     wxWidgets licence
 /////////////////////////////////////////////////////////////////////////////
 
 #include "wx/wxprec.h"
+
 #if wxUSE_GAUGE
 
+#include "wx/gauge.h"
+
 #ifndef WX_PRECOMP
     #include "wx/app.h"
-    #include "wx/gauge.h"
     #include "wx/log.h"
 #endif //WX_PRECOMP
 
@@ -26,6 +28,7 @@
 #include <math.h>
 
 IMPLEMENT_DYNAMIC_CLASS(wxGauge, wxControl)
+
 BEGIN_EVENT_TABLE(wxGauge, wxGaugeBase)
 END_EVENT_TABLE()
 // WX_IMPLEMENT_COCOA_OWNER(wxGauge,NSProgressIndicator,NSView,NSView)
@@ -34,17 +37,20 @@ bool wxGauge::Create(wxWindow *parent, wxWindowID winid, int range,
             const wxPoint& pos, const wxSize& size, long style,
             const wxValidator& validator, const wxString& name)
 {
-    //flag checking
-    wxASSERT_MSG( !(style & wxGA_HORIZONTAL), wxT("Horizontal gauge not supported on cocoa"));//*
-    wxASSERT_MSG( !(style & wxGA_SMOOTH), wxT("Smooth gauge not supported on cocoa"));
-    //* - GNUStep made isVertical and setVertical part of thier framework, but its specific to them
-    //the way they do it is just handle that flag in drawRect.
-
+    // NOTE: wxGA_SMOOTH flag is simply ignored (gauges are ALWAYS smooth)
     if(!CreateControl(parent,winid,pos,size,style,validator,name))
         return false;
     SetNSView([[NSProgressIndicator alloc] initWithFrame: MakeDefaultNSRect(size)]);
     [m_cocoaNSView release];
 
+    // TODO: DoGetBestSize is likely totally wrong for vertical gauges but
+    // this actually makes the widgets sample work so it's better than nothing.
+    if(style & wxGA_VERTICAL)
+    {
+        wxLogDebug(wxT("wxGA_VERTICAL may not work correctly.  See src/cocoa/gauge.mm"));
+        [m_cocoaNSView setBoundsRotation:-90.0];
+    }
+
     [(NSProgressIndicator*)m_cocoaNSView setMaxValue:range];
     [(NSProgressIndicator*)m_cocoaNSView setIndeterminate:NO];