workaround because regions that were built up, were sometimes being drawn on the...

[wxWidgets.git] / src / mac / carbon / menuitem.cpp

diff --git a/src/mac/carbon/menuitem.cpp b/src/mac/carbon/menuitem.cpp
index eedc3b0a0f22eb91392c973ed5bea0d8aee5cae6..a2a3a583b9cbeecb3f757575c8a06189619d43e4 100644 (file)
--- a/src/mac/carbon/menuitem.cpp
+++ b/src/mac/carbon/menuitem.cpp
@@ -1,11 +1,11 @@
 ///////////////////////////////////////////////////////////////////////////////
 // Name:        menuitem.cpp
 // Purpose:     wxMenuItem implementation
 ///////////////////////////////////////////////////////////////////////////////
 // Name:        menuitem.cpp
 // Purpose:     wxMenuItem implementation

-// Author:      AUTHOR
-// Modified by: 
-// Created:     ??/??/98
+// Author:      Stefan Csomor
+// Modified by:
+// Created:     1998-01-01

 // RCS-ID:      $Id$
 // RCS-ID:      $Id$

-// Copyright:   (c) AUTHOR
+// Copyright:   (c) Stefan Csomor

 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 


@@ -13,6 +13,8 @@
 // headers & declarations
 // ============================================================================
 
 // headers & declarations
 // ============================================================================
 

+#include "wx/wxprec.h"
+

 #include "wx/app.h"
 #include "wx/menu.h"
 #include "wx/menuitem.h"
 #include "wx/app.h"
 #include "wx/menu.h"
 #include "wx/menuitem.h"


@@ -26,9 +28,7 @@
 // dynamic classes implementation
 // ----------------------------------------------------------------------------
 
 // dynamic classes implementation
 // ----------------------------------------------------------------------------
 

-#if !USE_SHARED_LIBRARY
-  IMPLEMENT_DYNAMIC_CLASS(wxMenuItem, wxObject)
-#endif  //USE_SHARED_LIBRARY
+IMPLEMENT_DYNAMIC_CLASS(wxMenuItem, wxObject)

 
 // ----------------------------------------------------------------------------
 // wxMenuItem
 
 // ----------------------------------------------------------------------------
 // wxMenuItem


@@ -43,167 +43,200 @@ wxMenuItem::wxMenuItem(wxMenu *pParentMenu,
                        const wxString& text,
                        const wxString& strHelp,
                        wxItemKind kind,
                        const wxString& text,
                        const wxString& strHelp,
                        wxItemKind kind,

-                       wxMenu *pSubMenu) 
-          : wxMenuItemBase(pParentMenu, id, text, strHelp, kind, pSubMenu)
+                       wxMenu *pSubMenu)
+           :wxMenuItemBase(pParentMenu, id, text, strHelp, kind, pSubMenu)

 {
 {

+    wxASSERT_MSG( id != 0 || pSubMenu != NULL , wxT("A MenuItem ID of Zero does not work under Mac") ) ;
+

     // In other languages there is no difference in naming the Exit/Quit menu item between MacOS and Windows guidelines
     // therefore these item must not be translated
     // In other languages there is no difference in naming the Exit/Quit menu item between MacOS and Windows guidelines
     // therefore these item must not be translated

-    if ( wxStripMenuCodes(m_text).Upper() ==  "EXIT" )
+    if ( wxStripMenuCodes(m_text).Upper() ==  wxT("EXIT") )

     {
     {

-        m_text = "Quit\tCtrl+Q" ;
+        m_text =wxT("Quit\tCtrl+Q") ;

     }
 
     m_radioGroup.start = -1;
     }
 
     m_radioGroup.start = -1;

-    m_isRadioGroupStart = FALSE;
+    m_isRadioGroupStart = false;

 }
 
 }
 

-wxMenuItem::~wxMenuItem() 
+wxMenuItem::~wxMenuItem()

 {
 }
 
 // change item state
 // -----------------
 
 {
 }
 
 // change item state
 // -----------------
 

-void wxMenuItem::SetBitmap(const wxBitmap& bitmap) 
-{ 
-       m_bitmap = bitmap; 
-       UpdateItemBitmap() ;
+void wxMenuItem::SetBitmap(const wxBitmap& bitmap)
+{
+      m_bitmap = bitmap;
+      UpdateItemBitmap();

 }
 
 }
 

-void wxMenuItem::UpdateItemBitmap() 
+void wxMenuItem::UpdateItemBitmap()

 {
 {

-       if ( !m_parentMenu )
-               return ;
-               
-       MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
-       MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
-       if( mhandle == NULL || index == 0)
-               return ;
-               
-       if ( m_bitmap.Ok() )
-       {
-               ControlButtonContentInfo info ;
-               wxMacCreateBitmapButton( &info , m_bitmap , kControlContentCIconHandle ) ;
-               if ( info.contentType != kControlNoContent )
-               {
-                       if ( info.contentType == kControlContentCIconHandle )
-                               SetMenuItemIconHandle( mhandle , index , 
-                                       kMenuColorIconType , (Handle) info.u.cIconHandle ) ;
-           }
-                       
-       }
+    if ( !m_parentMenu )
+        return ;
+
+    MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
+    MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
+    if( mhandle == NULL || index == 0)
+        return ;
+
+    if ( m_bitmap.Ok() )
+    {
+#if wxUSE_BMPBUTTON
+        ControlButtonContentInfo info ;
+        wxMacCreateBitmapButton( &info , m_bitmap ) ;
+        if ( info.contentType != kControlNoContent )
+        {
+            if ( info.contentType == kControlContentIconRef )
+                SetMenuItemIconHandle( mhandle , index ,
+                    kMenuIconRefType , (Handle) info.u.iconRef ) ;
+        }
+        wxMacReleaseBitmapButton( &info ) ;
+#endif
+    }

 }
 
 }
 

-void wxMenuItem::UpdateItemStatus() 
+void wxMenuItem::UpdateItemStatus()

 {
 {

-       if ( !m_parentMenu )
-               return ;
-               
-       MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
-       MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
-       if( mhandle == NULL || index == 0)
-               return ;
-
-       UMAEnableMenuItem( mhandle , index , m_isEnabled ) ;
-       if ( IsCheckable() && IsChecked() )
-               ::SetItemMark( mhandle , index , 0x12 ) ; // checkmark
-       else
-               ::SetItemMark( mhandle , index , 0 ) ; // no mark
-
-       UMASetMenuItemText( mhandle , index , m_text ) ; 
-       wxAcceleratorEntry *entry = wxGetAccelFromString( m_text ) ;
-       UMASetMenuItemShortcut( mhandle , index , entry ) ;
-       delete entry ;
+    if ( !m_parentMenu )
+        return ;
+
+#if TARGET_CARBON
+    if ( UMAGetSystemVersion() >= 0x1000 && GetId() == wxApp::s_macPreferencesMenuItemId)
+    {
+        if ( !IsEnabled() )
+            DisableMenuCommand( NULL , kHICommandPreferences ) ;
+        else
+            EnableMenuCommand( NULL , kHICommandPreferences ) ;
+    }
+    if ( UMAGetSystemVersion() >= 0x1000 && GetId() == wxApp::s_macExitMenuItemId)
+    {
+        if ( !IsEnabled() )
+            DisableMenuCommand( NULL , kHICommandQuit ) ;
+        else
+            EnableMenuCommand( NULL , kHICommandQuit ) ;
+    }
+#endif
+    {
+        MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
+        MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
+        if( mhandle == NULL || index == 0)
+            return ;
+
+        UMAEnableMenuItem( mhandle , index , m_isEnabled ) ;
+        if ( IsCheckable() && IsChecked() )
+            ::SetItemMark( mhandle , index , 0x12 ) ; // checkmark
+        else
+            ::SetItemMark( mhandle , index , 0 ) ; // no mark
+
+        UMASetMenuItemText( mhandle , index , m_text , wxFont::GetDefaultEncoding() ) ;
+        wxAcceleratorEntry *entry = wxGetAccelFromString( m_text ) ;
+        UMASetMenuItemShortcut( mhandle , index , entry ) ;
+        delete entry ;
+    }

 }
 
 }
 

-void wxMenuItem::UpdateItemText() 
+void wxMenuItem::UpdateItemText()

 {
 {

-       if ( !m_parentMenu )
-               return ;
-               
-       MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
-       MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
-       if( mhandle == NULL || index == 0)
-               return ;
-
-       UMASetMenuItemText( mhandle , index , m_text ) ; 
-       wxAcceleratorEntry *entry = wxGetAccelFromString( m_text ) ;
-       UMASetMenuItemShortcut( mhandle , index , entry ) ;
-       delete entry ;
+    if ( !m_parentMenu )
+        return ;
+
+    MenuHandle mhandle = MAC_WXHMENU(m_parentMenu->GetHMenu()) ;
+    MenuItemIndex index = m_parentMenu->MacGetIndexFromItem( this ) ;
+    if( mhandle == NULL || index == 0)
+        return ;
+
+    UMASetMenuItemText( mhandle , index , m_text , wxFont::GetDefaultEncoding() ) ;
+    wxAcceleratorEntry *entry = wxGetAccelFromString( m_text ) ;
+    UMASetMenuItemShortcut( mhandle , index , entry ) ;
+    delete entry ;

 }
 
 
 void wxMenuItem::Enable(bool bDoEnable)
 {
 }
 
 
 void wxMenuItem::Enable(bool bDoEnable)
 {

-       if ( m_isEnabled != bDoEnable ) 
-       {
-               wxMenuItemBase::Enable( bDoEnable ) ;
-               UpdateItemStatus() ;
-       }
+    if (( m_isEnabled != bDoEnable
+#if TARGET_CARBON
+      // avoid changing menuitem state when menu is disabled
+      // eg. BeginAppModalStateForWindow() will disable menus and ignore this change
+      // which in turn causes m_isEnabled to become out of sync with real menuitem state
+         && !(m_parentMenu && !IsMenuItemEnabled(MAC_WXHMENU(m_parentMenu->GetHMenu()), 0)) )
+      // always update builtin menuitems
+         || (   GetId() == wxApp::s_macPreferencesMenuItemId
+             || GetId() == wxApp::s_macExitMenuItemId
+             || GetId() == wxApp::s_macAboutMenuItemId
+#endif
+         ))
+    {
+        wxMenuItemBase::Enable( bDoEnable ) ;
+        UpdateItemStatus() ;
+    }

 }
 void wxMenuItem::UncheckRadio()
 {
 }
 void wxMenuItem::UncheckRadio()
 {

-       if ( m_isChecked ) 
-       {
-               wxMenuItemBase::Check( false ) ;
-               UpdateItemStatus() ;
-       }
+    if ( m_isChecked )
+    {
+        wxMenuItemBase::Check( false ) ;
+        UpdateItemStatus() ;
+    }

 }
 
 void wxMenuItem::Check(bool bDoCheck)
 {
 }
 
 void wxMenuItem::Check(bool bDoCheck)
 {

-       wxCHECK_RET( IsCheckable(), "only checkable items may be checked" );
-
-       if ( m_isChecked != bDoCheck ) 
-       {
-               if ( GetKind() == wxITEM_RADIO )
-               {
-                       if ( bDoCheck )
-                       {
-                               wxMenuItemBase::Check( bDoCheck ) ;
-                               UpdateItemStatus() ;
-                               
-                       // get the index of this item in the menu
-                       const wxMenuItemList& items = m_parentMenu->GetMenuItems();
-                       int pos = items.IndexOf(this);
-                       wxCHECK_RET( pos != wxNOT_FOUND,
-                                    _T("menuitem not found in the menu items list?") );
-
-                       // get the radio group range
-                       int start,
-                           end;
-
-                       if ( m_isRadioGroupStart )
-                       {
-                           // we already have all information we need
-                           start = pos;
-                           end = m_radioGroup.end;
-                       }
-                       else // next radio group item
-                       {
-                           // get the radio group end from the start item
-                           start = m_radioGroup.start;
-                           end = items.Item(start)->GetData()->m_radioGroup.end;
-                       }
-
-                       // also uncheck all the other items in this radio group
-                       wxMenuItemList::Node *node = items.Item(start);
-                       for ( int n = start; n <= end && node; n++ )
-                       {
-                           if ( n != pos )
-                           {
-                               ((wxMenuItem*)node->GetData())->UncheckRadio();
-                           }
-                           node = node->GetNext();
-                       }
-                       }
-               }
-               else
-               {
-                       wxMenuItemBase::Check( bDoCheck ) ;
-                       UpdateItemStatus() ;
-               }
-       }
+    wxCHECK_RET( IsCheckable(), wxT("only checkable items may be checked") );
+
+    if ( m_isChecked != bDoCheck )
+    {
+        if ( GetKind() == wxITEM_RADIO )
+        {
+            if ( bDoCheck )
+            {
+                wxMenuItemBase::Check( bDoCheck ) ;
+                UpdateItemStatus() ;
+
+                // get the index of this item in the menu
+                const wxMenuItemList& items = m_parentMenu->GetMenuItems();
+                int pos = items.IndexOf(this);
+                wxCHECK_RET( pos != wxNOT_FOUND,
+                             _T("menuitem not found in the menu items list?") );
+
+                // get the radio group range
+                int start,
+                    end;
+
+                if ( m_isRadioGroupStart )
+                {
+                    // we already have all information we need
+                    start = pos;
+                    end = m_radioGroup.end;
+                }
+                else // next radio group item
+                {
+                    // get the radio group end from the start item
+                    start = m_radioGroup.start;
+                    end = items.Item(start)->GetData()->m_radioGroup.end;
+                }
+
+                // also uncheck all the other items in this radio group
+                wxMenuItemList::compatibility_iterator node = items.Item(start);
+                for ( int n = start; n <= end && node; n++ )
+                {
+                    if ( n != pos )
+                    {
+                        ((wxMenuItem*)node->GetData())->UncheckRadio();
+                    }
+                    node = node->GetNext();
+                }
+            }
+        }
+        else
+        {
+            wxMenuItemBase::Check( bDoCheck ) ;
+            UpdateItemStatus() ;
+        }
+    }

 }
 
 void wxMenuItem::SetText(const wxString& text)
 }
 
 void wxMenuItem::SetText(const wxString& text)


@@ -213,7 +246,7 @@ void wxMenuItem::SetText(const wxString& text)
         return;
 
     wxMenuItemBase::SetText(text);
         return;
 
     wxMenuItemBase::SetText(text);

-    
+

     UpdateItemText() ;
 }
 
     UpdateItemText() ;
 }
 


@@ -222,7 +255,7 @@ void wxMenuItem::SetText(const wxString& text)
 
 void wxMenuItem::SetAsRadioGroupStart()
 {
 
 void wxMenuItem::SetAsRadioGroupStart()
 {

-    m_isRadioGroupStart = TRUE;
+    m_isRadioGroupStart = true;

 }
 
 void wxMenuItem::SetRadioGroupStart(int start)
 }
 
 void wxMenuItem::SetRadioGroupStart(int start)