Don't create uneeded variables.

[wxWidgets.git] / demos / forty / scorefil.cpp

diff --git a/demos/forty/scorefil.cpp b/demos/forty/scorefil.cpp
index 534b11e996e2ba39b7c8e90a59c2940d2c17a69a..f85ec62988cd79366496e70dde5724ed0c1f2f48 100644 (file)
--- a/demos/forty/scorefil.cpp
+++ b/demos/forty/scorefil.cpp
@@ -6,16 +6,9 @@
 // Created:     21/07/97
 // RCS-ID:      $Id$
 // Copyright:   (c) 1993-1998 Chris Breeze
 // Created:     21/07/97
 // RCS-ID:      $Id$
 // Copyright:   (c) 1993-1998 Chris Breeze

-// Licence:    wxWindows licence
-//---------------------------------------------------------------------------
-// Last modified: 14th May 1998 - ported to wxWidgets 2.0
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation
-#pragma interface
-#endif
-

 // For compilers that support precompilation, includes "wx/wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx/wx.h".
 #include "wx/wxprec.h"
 


@@ -41,65 +34,65 @@
 ScoreFile::ScoreFile(const wxString& appName)
 {
 #if 0
 ScoreFile::ScoreFile(const wxString& appName)
 {
 #if 0

-       wxString filename;
-       m_configFilename << "/usr/local/share/" << appName << ".scores";
-       if (access(m_configFilename, F_OK) == 0)
-       {
-               if (access(m_configFilename, R_OK | W_OK) != 0)
-               {
-                       // file is not r/w - use local file instead
-                       m_configFilename = wxFileConfig::GetLocalFileName(appName);
-               }
-       }
-       else
-       {
-               int fd = creat(m_configFilename, 0666);
-
-               if (fd < 0)
-               {
-                       // failed to create file - use local file instead
-                       m_configFilename = wxFileConfig::GetLocalFileName(appName);
-               }
-               else
-               {
-                       // ensure created file has rw-rw-rw permissions
-                       close(fd);
-               }
-       }
+    wxString filename;
+    m_configFilename << "/usr/local/share/" << appName << ".scores";
+    if (access(m_configFilename, F_OK) == 0)
+    {
+        if (access(m_configFilename, R_OK | W_OK) != 0)
+        {
+            // file is not r/w - use local file instead
+            m_configFilename = wxFileConfig::GetLocalFileName(appName);
+        }
+    }
+    else
+    {
+        int fd = creat(m_configFilename, 0666);
+
+        if (fd < 0)
+        {
+            // failed to create file - use local file instead
+            m_configFilename = wxFileConfig::GetLocalFileName(appName);
+        }
+        else
+        {
+            // ensure created file has rw-rw-rw permissions
+            close(fd);
+        }
+    }

 #endif
 
 #endif
 

-       m_config = new wxConfig(appName, _T("wxWidgets"), appName, _T(""),
+    m_config = new wxConfig(appName, _T("wxWidgets"), appName, wxEmptyString,

                                 wxCONFIG_USE_LOCAL_FILE);  // only local
 }
 
 ScoreFile::~ScoreFile()
 {
                                 wxCONFIG_USE_LOCAL_FILE);  // only local
 }
 
 ScoreFile::~ScoreFile()
 {

-       delete m_config;
+    delete m_config;

 #ifdef __WXGTK__
 #ifdef __WXGTK__

-       // ensure score file has rw-rw-rw permissions
-       // (wxFileConfig sets them to rw-------)
-       chmod(m_configFilename, 0666);
+    // ensure score file has rw-rw-rw permissions
+    // (wxFileConfig sets them to rw-------)
+    chmod(m_configFilename, 0666);

 #endif
 }
 
 
 void ScoreFile::GetPlayerList( wxArrayString &list )
 {
 #endif
 }
 
 
 void ScoreFile::GetPlayerList( wxArrayString &list )
 {

-       m_config->SetPath(_T("/Players"));
-       int length = m_config->GetNumberOfGroups();
-
-       if (length <= 0) return;
-
-       wxString player;
-       long index;
-       if (m_config->GetFirstGroup(player, index))
-       {
-            list.Add( player );
-               while (m_config->GetNextGroup(player, index))
-               {
-                 list.Add( player );
-               }
-       }
+    m_config->SetPath(_T("/Players"));
+    int length = m_config->GetNumberOfGroups();
+
+    if (length <= 0) return;
+
+    wxString player;
+    long index;
+    if (m_config->GetFirstGroup(player, index))
+    {
+         list.Add( player );
+        while (m_config->GetNextGroup(player, index))
+        {
+              list.Add( player );
+        }
+    }

 }
 
 
 }
 
 


@@ -111,73 +104,73 @@ long ScoreFile::CalcCheck(const wxString& name, int p1, int p2, int p3)
     size_t i, max = name.length();
 
     for(i = 0; i < max; ++i )
     size_t i, max = name.length();
 
     for(i = 0; i < max; ++i )

-       {
-               check = (check << 1) ^ (long)name[i];
-               check = ((check >> 23) ^ check) & 0xFFFFFF;
-       }
-       check = (check << 1) ^ (long)p1;
-       check = ((check >> 23) ^ check) & 0xFFFFFF;
-       check = (check << 1) ^ (long)p2;
-       check = ((check >> 23) ^ check) & 0xFFFFFF;
-       check = (check << 1) ^ (long)p3;
-       check = ((check >> 23) ^ check) & 0xFFFFFF;
+    {
+        check = (check << 1) ^ (long)name[i];
+        check = ((check >> 23) ^ check) & 0xFFFFFF;
+    }
+    check = (check << 1) ^ (long)p1;
+    check = ((check >> 23) ^ check) & 0xFFFFFF;
+    check = (check << 1) ^ (long)p2;
+    check = ((check >> 23) ^ check) & 0xFFFFFF;
+    check = (check << 1) ^ (long)p3;
+    check = ((check >> 23) ^ check) & 0xFFFFFF;

     return check;
 }
 
 wxString ScoreFile::GetPreviousPlayer() const
 {
     return check;
 }
 
 wxString ScoreFile::GetPreviousPlayer() const
 {

-       wxString result;
-       m_config->SetPath(_T("/General"));
-       m_config->Read(_T("LastPlayer"), &result);
-       return result;
+    wxString result;
+    m_config->SetPath(_T("/General"));
+    m_config->Read(_T("LastPlayer"), &result);
+    return result;

 }
 
 void ScoreFile::ReadPlayersScore(
 }
 
 void ScoreFile::ReadPlayersScore(

-                                               const wxString& player,
-                                               int& wins,
-                                               int& games,
-                                               int& score)
+                        const wxString& player,
+                        int& wins,
+                        int& games,
+                        int& score)

 {
 {

-       long check = 0;
-       long myWins = 0, myGames = 0, myScore = 0;
-
-       games = wins = score = 0;
-
-       m_config->SetPath(_T("/Players"));
-       m_config->SetPath(player);
-       if (m_config->Read(_T("Score"), &myScore, 0L) &&
-               m_config->Read(_T("Games"), &myGames, 0L) &&
-               m_config->Read(_T("Wins"),  &myWins, 0L) &&
-               m_config->Read(_T("Check"), &check, 0L))
-       {
-           if (check != CalcCheck(player, myGames, myWins, myScore))
-               {
-                       wxMessageBox(_T("Score file corrupted"), _T("Warning"),
+    long check = 0;
+    long myWins = 0, myGames = 0, myScore = 0;
+
+    games = wins = score = 0;
+
+    m_config->SetPath(_T("/Players"));
+    m_config->SetPath(player);
+    if (m_config->Read(_T("Score"), &myScore, 0L) &&
+        m_config->Read(_T("Games"), &myGames, 0L) &&
+        m_config->Read(_T("Wins"),  &myWins, 0L) &&
+        m_config->Read(_T("Check"), &check, 0L))
+    {
+        if (check != CalcCheck(player, myGames, myWins, myScore))
+        {
+            wxMessageBox(_T("Score file corrupted"), _T("Warning"),

                                      wxOK | wxICON_EXCLAMATION);
                                      wxOK | wxICON_EXCLAMATION);

-               }
-               else
-               {
-                       games = myGames;
-                       wins = myWins;
-                       score = myScore;
-               }
-       }
-       WritePlayersScore(player, wins, games, score);
+        }
+        else
+        {
+            games = myGames;
+            wins = myWins;
+            score = myScore;
+        }
+    }
+    WritePlayersScore(player, wins, games, score);

 }
 
 
 void ScoreFile::WritePlayersScore(const wxString& player, int wins, int games, int score)
 {
     if (player)
 }
 
 
 void ScoreFile::WritePlayersScore(const wxString& player, int wins, int games, int score)
 {
     if (player)

-       {
-               m_config->SetPath(_T("/General"));
-               m_config->Write(_T("LastPlayer"), wxString(player)); // Without wxString tmp, thinks it's bool in VC++
-
-               m_config->SetPath(_T("/Players"));
-               m_config->SetPath(player);
-               m_config->Write(_T("Score"), (long)score);
-               m_config->Write(_T("Games"), (long)games);
-               m_config->Write(_T("Wins"), (long)wins);
-               m_config->Write(_T("Check"), CalcCheck(player, games, wins, score));
-       }
+    {
+        m_config->SetPath(_T("/General"));
+        m_config->Write(_T("LastPlayer"), wxString(player)); // Without wxString tmp, thinks it's bool in VC++
+
+        m_config->SetPath(_T("/Players"));
+        m_config->SetPath(player);
+        m_config->Write(_T("Score"), (long)score);
+        m_config->Write(_T("Games"), (long)games);
+        m_config->Write(_T("Wins"), (long)wins);
+        m_config->Write(_T("Check"), CalcCheck(player, games, wins, score));
+    }

 }
 }