wxMessageBox off the main thread lost result code.

[wxWidgets.git] / src / common / file.cpp

diff --git a/src/common/file.cpp b/src/common/file.cpp
index 0364794e8bce07c6cb3e2e81019c21864fde0a76..b2a5aca73628991930426bde04c4384c0a1dc9f6 100644 (file)
--- a/src/common/file.cpp
+++ b/src/common/file.cpp
@@ -5,7 +5,6 @@
 // Author:      Vadim Zeitlin
 // Modified by:
 // Created:     29/01/98
 // Author:      Vadim Zeitlin
 // Modified by:
 // Created:     29/01/98

-// RCS-ID:      $Id$

 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////


@@ -24,7 +23,7 @@
 #if wxUSE_FILE
 
 // standard
 #if wxUSE_FILE
 
 // standard

-#if defined(__WXMSW__) && !defined(__GNUWIN32__) && !defined(__WXMICROWIN__) && !defined(__WXWINCE__)
+#if defined(__WINDOWS__) && !defined(__GNUWIN32__) && !defined(__WXMICROWIN__) && !defined(__WXWINCE__)

 
 #define   WIN32_LEAN_AND_MEAN
 #define   NOSERVICE
 
 #define   WIN32_LEAN_AND_MEAN
 #define   NOSERVICE


@@ -47,7 +46,7 @@
 #define   NOCRYPT
 #define   NOMCX
 
 #define   NOCRYPT
 #define   NOMCX
 

-#elif defined(__WXMSW__) && defined(__WXWINCE__)
+#elif defined(__WINDOWS__) && defined(__WXWINCE__)

     #include  "wx/msw/missing.h"
 #elif (defined(__OS2__))
     #include <io.h>
     #include  "wx/msw/missing.h"
 #elif (defined(__OS2__))
     #include <io.h>


@@ -119,7 +118,7 @@
     #define   O_BINARY    (0)
 #endif  //__UNIX__
 
     #define   O_BINARY    (0)
 #endif  //__UNIX__
 

-#ifdef __WXMSW__
+#ifdef __WINDOWS__

     #include "wx/msw/mslu.h"
 #endif
 
     #include "wx/msw/mslu.h"
 #endif
 


@@ -204,17 +203,17 @@ bool wxFile::Create(const wxString& fileName, bool bOverwrite, int accessMode)
 {
     // if bOverwrite we create a new file or truncate the existing one,
     // otherwise we only create the new file and fail if it already exists
 {
     // if bOverwrite we create a new file or truncate the existing one,
     // otherwise we only create the new file and fail if it already exists

-    int fd = wxOpen( fileName,
+    int fildes = wxOpen( fileName,

                      O_BINARY | O_WRONLY | O_CREAT |
                      (bOverwrite ? O_TRUNC : O_EXCL),
                      accessMode );
                      O_BINARY | O_WRONLY | O_CREAT |
                      (bOverwrite ? O_TRUNC : O_EXCL),
                      accessMode );

-    if ( CheckForError(fd) )
+    if ( CheckForError(fildes) )

     {
         wxLogSysError(_("can't create file '%s'"), fileName);
         return false;
     }
 
     {
         wxLogSysError(_("can't create file '%s'"), fileName);
         return false;
     }
 

-    Attach(fd);
+    Attach(fildes);

     return true;
 }
 
     return true;
 }
 


@@ -258,15 +257,15 @@ bool wxFile::Open(const wxString& fileName, OpenMode mode, int accessMode)
     accessMode &= wxS_IRUSR | wxS_IWUSR;
 #endif // __WINDOWS__
 
     accessMode &= wxS_IRUSR | wxS_IWUSR;
 #endif // __WINDOWS__
 

-    int fd = wxOpen( fileName, flags, accessMode);
+    int fildes = wxOpen( fileName, flags, accessMode);

 
 

-    if ( CheckForError(fd) )
+    if ( CheckForError(fildes) )

     {
         wxLogSysError(_("can't open file '%s'"), fileName);
         return false;
     }
 
     {
         wxLogSysError(_("can't open file '%s'"), fileName);
         return false;
     }
 

-    Attach(fd);
+    Attach(fildes);

     return true;
 }
 
     return true;
 }
 


@@ -291,6 +290,38 @@ bool wxFile::Close()
 // read/write
 // ----------------------------------------------------------------------------
 
 // read/write
 // ----------------------------------------------------------------------------
 

+bool wxFile::ReadAll(wxString *str, const wxMBConv& conv)
+{
+    wxCHECK_MSG( str, false, wxS("Output string must be non-NULL") );
+
+    ssize_t length = Length();
+    wxCHECK_MSG( (wxFileOffset)length == Length(), false, wxT("huge file not supported") );
+
+    wxCharBuffer buf(length);
+    char* p = buf.data();
+    for ( ;; )
+    {
+        static const ssize_t READSIZE = 4096;
+
+        ssize_t nread = Read(p, length > READSIZE ? READSIZE : length);
+        if ( nread == wxInvalidOffset )
+            return false;
+
+        p += nread;
+        if ( length <= nread )
+            break;
+
+        length -= nread;
+    }
+
+    *p = 0;
+
+    wxString strTmp(buf, conv);
+    str->swap(strTmp);
+
+    return true;
+}
+

 // read
 ssize_t wxFile::Read(void *pBuf, size_t nCount)
 {
 // read
 ssize_t wxFile::Read(void *pBuf, size_t nCount)
 {


@@ -460,7 +491,7 @@ bool wxFile::Eof() const
 
     wxFileOffset iRc;
 
 
     wxFileOffset iRc;
 

-#if defined(__DOS__) || defined(__UNIX__) || defined(__GNUWIN32__) || defined( __MWERKS__ )
+#if defined(__DOS__) || defined(__UNIX__) || defined(__GNUWIN32__)

     // @@ this doesn't work, of course, on unseekable file descriptors
     wxFileOffset ofsCur = Tell(),
     ofsMax = Length();
     // @@ this doesn't work, of course, on unseekable file descriptors
     wxFileOffset ofsCur = Tell(),
     ofsMax = Length();


@@ -479,10 +510,6 @@ bool wxFile::Eof() const
     {
         wxLogSysError(_("can't determine if the end of file is reached on descriptor %d"), m_fd);
     }
     {
         wxLogSysError(_("can't determine if the end of file is reached on descriptor %d"), m_fd);
     }

-    else if ( iRc != 1 )
-    {
-        wxFAIL_MSG(wxT("invalid eof() return value."));
-    }

 
     return true;
 }
 
     return true;
 }