wxCHECK_RET( m_layout, wxT("no Pango layout") );
wxCHECK_RET( m_fontdesc, wxT("no Pango font description") );
+ bool underlined = m_font.Ok() && m_font.GetUnderlined();
+
#if wxUSE_UNICODE
const wxCharBuffer data = wxConvUTF8.cWC2MB( text );
#else
const wxWCharBuffer wdata = wxConvLocal.cMB2WC( text );
+ if ( !wdata )
+ return;
const wxCharBuffer data = wxConvUTF8.cWC2MB( wdata );
#endif
- pango_layout_set_text( m_layout, (const char*) data, strlen( (const char*) data ));
+ size_t datalen = strlen((const char*)data);
+ pango_layout_set_text( m_layout, (const char*) data, datalen);
+
+ if (underlined)
+ {
+ PangoAttrList *attrs = pango_attr_list_new();
+ PangoAttribute *a = pango_attr_underline_new(PANGO_UNDERLINE_SINGLE);
+ a->start_index = 0;
+ a->end_index = datalen;
+ pango_attr_list_insert(attrs, a);
+ pango_layout_set_attributes(m_layout, attrs);
+ pango_attr_list_unref(attrs);
+ }
int w,h;
// Draw layout.
gdk_draw_layout( m_window, m_textGC, x, y, m_layout );
}
+
+ if (underlined)
+ {
+ // undo underline attributes setting:
+ pango_layout_set_attributes(m_layout, NULL);
+ }
wxCoord width = w;
wxCoord height = h;
// Set layout's text
#if wxUSE_UNICODE
const wxCharBuffer data = wxConvUTF8.cWC2MB( string );
- pango_layout_set_text( m_layout, (const char*) data, strlen( (const char*) data ));
+ const char *dataUTF8 = (const char *)data;
#else
const wxWCharBuffer wdata = wxConvLocal.cMB2WC( string );
+ if ( !wdata )
+ {
+ if (width) (*width) = 0;
+ if (height) (*height) = 0;
+ return;
+ }
const wxCharBuffer data = wxConvUTF8.cWC2MB( wdata );
- pango_layout_set_text( m_layout, (const char*) data, strlen( (const char*) data ));
+ const char *dataUTF8 = (const char *)data;
#endif
+
+ if ( !dataUTF8 )
+ {
+ // hardly ideal, but what else can we do if conversion failed?
+ return;
+ }
+
+ pango_layout_set_text( m_layout, dataUTF8, strlen(dataUTF8) );
int w,h;
pango_layout_get_pixel_size( m_layout, &w, &h );
- if (width) (*width) = (wxCoord) w;
- if (height) (*height) = (wxCoord) h;
+ if (width)
+ *width = (wxCoord) w;
+ if (height)
+ *height = (wxCoord) h;
if (descent)
{
- // Do something about metrics here. TODO.
- (*descent) = 0;
+ PangoLayoutIter *iter = pango_layout_get_iter(m_layout);
+ int baseline = pango_layout_iter_get_baseline(iter);
+ pango_layout_iter_free(iter);
+ *descent = h - PANGO_PIXELS(baseline);
}
- if (externalLeading) (*externalLeading) = 0; // ??
+ if (externalLeading)
+ *externalLeading = 0; // ??
// Reset old font description
if (theFont)
pango_layout_set_font_description( m_layout, m_fontdesc );
-#else
+#else // GTK+ 1.x
wxFont fontToUse = m_font;
if (theFont) fontToUse = *theFont;
if (height) (*height) = wxCoord((font->ascent + font->descent) / m_scaleY);
if (descent) (*descent) = wxCoord(font->descent / m_scaleY);
if (externalLeading) (*externalLeading) = 0; // ??
-#endif
+#endif // GTK+ 2/1
}
wxCoord wxWindowDC::GetCharWidth() const
IMPLEMENT_DYNAMIC_CLASS(wxPaintDC, wxClientDC)
+// Limit the paint region to the window size. Sometimes
+// the paint region is too big, and this risks X11 errors
+static void wxLimitRegionToSize(wxRegion& region, const wxSize& sz)
+{
+ wxRect originalRect = region.GetBox();
+ wxRect rect(originalRect);
+ if (rect.width + rect.x > sz.x)
+ rect.width = sz.x - rect.x;
+ if (rect.height + rect.y > sz.y)
+ rect.height = sz.y - rect.y;
+ if (rect != originalRect)
+ {
+ region = wxRegion(rect);
+ wxLogTrace(wxT("painting"), wxT("Limiting region from %d, %d, %d, %d to %d, %d, %d, %d\n"),
+ originalRect.x, originalRect.y, originalRect.width, originalRect.height,
+ rect.x, rect.y, rect.width, rect.height);
+ }
+}
+
wxPaintDC::wxPaintDC( wxWindow *win )
: wxClientDC( win )
{
if (!win->m_clipPaintRegion)
return;
+ wxSize sz = win->GetSize();
m_paintClippingRegion = win->GetUpdateRegion();
+ wxLimitRegionToSize(m_paintClippingRegion, sz);
+
GdkRegion *region = m_paintClippingRegion.GetRegion();
if ( region )
{
- m_paintClippingRegion = win->GetUpdateRegion();
- GdkRegion *region = m_paintClippingRegion.GetRegion();
- if ( region )
- {
- m_currentClippingRegion.Union( m_paintClippingRegion );
+ m_currentClippingRegion.Union( m_paintClippingRegion );
+ wxLimitRegionToSize(m_currentClippingRegion, sz);
- gdk_gc_set_clip_region( m_penGC, region );
- gdk_gc_set_clip_region( m_brushGC, region );
- gdk_gc_set_clip_region( m_textGC, region );
- gdk_gc_set_clip_region( m_bgGC, region );
- }
+ if (sz.x <= 0 || sz.y <= 0)
+ return ;
+
+ gdk_gc_set_clip_region( m_penGC, region );
+ gdk_gc_set_clip_region( m_brushGC, region );
+ gdk_gc_set_clip_region( m_textGC, region );
+ gdk_gc_set_clip_region( m_bgGC, region );
}
#endif // USE_PAINT_REGION
}