another segfault fix

[wxWidgets.git] / src / msw / statbr95.cpp

diff --git a/src/msw/statbr95.cpp b/src/msw/statbr95.cpp
index 312fabcea26fd0bb9f76a9bbe6c2206f924884fd..5889081a5f904cf7d8c99d05cd03599b01ce34e5 100644 (file)
--- a/src/msw/statbr95.cpp
+++ b/src/msw/statbr95.cpp
@@ -2,7 +2,7 @@
 // Name:        msw/statbr95.cpp
 // Purpose:     native implementation of wxStatusBar
 // Author:      Vadim Zeitlin
 // Name:        msw/statbr95.cpp
 // Purpose:     native implementation of wxStatusBar
 // Author:      Vadim Zeitlin

-// Modified by: 
+// Modified by:

 // Created:     04.04.98
 // RCS-ID:      $Id$
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>
 // Created:     04.04.98
 // RCS-ID:      $Id$
 // Copyright:   (c) 1998 Vadim Zeitlin <zeitlin@dptmaths.ens-cachan.fr>


@@ -27,50 +27,28 @@
   #include "wx/dcclient.h"
 #endif
 
   #include "wx/dcclient.h"
 #endif
 

-#ifdef __WIN95__
+#if defined(__WIN95__) && wxUSE_NATIVE_STATUSBAR

 
 

+#include "wx/intl.h"

 #include "wx/log.h"
 #include "wx/log.h"

-#include "wx/generic/statusbr.h"
-#include "wx/msw/statbr95.h"
+#include "wx/statusbr.h"

 
 

-#include  <windows.h>
-#include  <windowsx.h>
+#include "wx/msw/private.h"
+#include <windowsx.h>

 
 

-#if !defined(__GNUWIN32__) || defined(__TWIN32__)
-#include  <commctrl.h>
+#if defined(__WIN95__) && !((defined(__GNUWIN32_OLD__) || defined(__TWIN32__)) && !defined(__CYGWIN10__))
+    #include <commctrl.h>

 #endif
 
 #endif
 

-#ifdef GetClassInfo
-#undef GetClassInfo
-#endif
-
-#ifdef GetClassName
-#undef GetClassName
-#endif
-
-#if wxUSE_NATIVE_STATUSBAR
-
-#if     !USE_SHARED_LIBRARY
-  IMPLEMENT_DYNAMIC_CLASS(wxStatusBar95, wxStatusBar);
-
-  BEGIN_EVENT_TABLE(wxStatusBar95, wxStatusBar)
-    EVT_PAINT(wxWindow::OnPaint)
-    EVT_SIZE(wxStatusBar95::OnSize)
-  END_EVENT_TABLE()
-#endif  //USE_SHARED_LIBRARY
-
-

 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 
 // windowsx.h and commctrl.h don't define those, so we do it here
 #define StatusBar_SetParts(h, n, w) SendMessage(h, SB_SETPARTS, (WPARAM)n, (LPARAM)w)
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 
 // windowsx.h and commctrl.h don't define those, so we do it here
 #define StatusBar_SetParts(h, n, w) SendMessage(h, SB_SETPARTS, (WPARAM)n, (LPARAM)w)

-#define StatusBar_SetText(h, n, t)  SendMessage(h, SB_SETTEXT, (WPARAM)n, (LPARAM)(LPCSTR)t)
+#define StatusBar_SetText(h, n, t)  SendMessage(h, SB_SETTEXT, (WPARAM)n, (LPARAM)(LPCTSTR)t)

 #define StatusBar_GetTextLen(h, n)  LOWORD(SendMessage(h, SB_GETTEXTLENGTH, (WPARAM)n, 0))
 #define StatusBar_GetTextLen(h, n)  LOWORD(SendMessage(h, SB_GETTEXTLENGTH, (WPARAM)n, 0))

-#define StatusBar_GetText(h, n, s)  LOWORD(SendMessage(h, SB_GETTEXT, (WPARAM)n, (LPARAM)(LPSTR)s))
-
-#define hwnd      ((HWND)m_hWnd)
+#define StatusBar_GetText(h, n, s)  LOWORD(SendMessage(h, SB_GETTEXT, (WPARAM)n, (LPARAM)(LPTSTR)s))

 
 // ============================================================================
 // implementation
 
 // ============================================================================
 // implementation


@@ -82,163 +60,208 @@
 
 wxStatusBar95::wxStatusBar95()
 {
 
 wxStatusBar95::wxStatusBar95()
 {

-  SetParent(NULL);
-  m_hWnd = 0;
-  m_windowId = 0;
+    SetParent(NULL);
+    m_hWnd = 0;
+    m_windowId = 0;

 }
 
 }
 

-wxStatusBar95::wxStatusBar95(wxWindow *parent, wxWindowID id, long style)
+bool wxStatusBar95::Create(wxWindow *parent,
+                           wxWindowID id,
+                           long style,
+                           const wxString& name)

 {
 {

-  Create(parent, id, style);
-}
+    wxCHECK_MSG( parent, FALSE, wxT("status bar must have a parent") );

 
 

-bool wxStatusBar95::Create(wxWindow *parent, wxWindowID id, long style)
-{
-  SetParent(parent);
-
-  if (id == -1)
-    m_windowId = NewControlId();
-  else
-    m_windowId = id;
-
-  DWORD wstyle = WS_CHILD | WS_VISIBLE;
-  if ( style & wxST_SIZEGRIP )
-    wstyle |= SBARS_SIZEGRIP;
-
-  m_hWnd = (WXHWND)CreateStatusWindow(wstyle,
-                                      "",
-                                      (HWND)parent->GetHWND(),
-                                      m_windowId);
-  if ( m_hWnd == 0 ) {
-    wxLogSysError("can't create status bar window");
-    return FALSE;
-  }
-
-  // this doesn't work: display problems (white 1-2 pixel borders...)
-  //  SubclassWin(m_hWnd);
-
-  return TRUE;
+    SetName(name);
+    SetWindowStyleFlag(style);
+    SetParent(parent);
+
+    parent->AddChild(this);
+
+    m_windowId = id == -1 ? NewControlId() : id;
+
+    DWORD wstyle = WS_CHILD | WS_VISIBLE;
+
+    if ( style & wxCLIP_SIBLINGS )
+        wstyle |= WS_CLIPSIBLINGS;
+
+    // setting SBARS_SIZEGRIP is perfectly useless: it's always on by default
+    // (at least in the version of comctl32.dll I'm using), and the only way to
+    // turn it off is to use CCS_TOP style - as we position the status bar
+    // manually anyhow (see DoMoveWindow), use CCS_TOP style if wxST_SIZEGRIP
+    // is not given
+    if ( !(style & wxST_SIZEGRIP) )
+    {
+        wstyle |= CCS_TOP;
+    }
+    else
+    {
+        // may be some versions of comctl32.dll do need it - anyhow, it won't
+        // do any harm
+        wstyle |= SBARS_SIZEGRIP;
+    }
+
+    m_hWnd = (WXHWND)CreateStatusWindow(wstyle,
+                                        wxEmptyString,
+                                        GetHwndOf(parent),
+                                        m_windowId);
+    if ( m_hWnd == 0 )
+    {
+        wxLogSysError(_("Failed to create a status bar."));
+
+        return FALSE;
+    }
+
+    SetFieldsCount(1);
+    SubclassWin(m_hWnd);
+
+    return TRUE;

 }
 
 }
 

-void wxStatusBar95::CopyFieldsWidth(const int widths[])
+wxStatusBar95::~wxStatusBar95()

 {
 {

-  if (widths && !m_statusWidths)
-    m_statusWidths = new int[m_nFields];
-
-  if ( widths != NULL ) {
-    for ( int i = 0; i < m_nFields; i++ )
-      m_statusWidths[i] = widths[i];
-  }
-  else {
-    delete [] m_statusWidths;
-    m_statusWidths = NULL;
-  }

 }
 
 }
 

-void wxStatusBar95::SetFieldsCount(int nFields, const int widths[])
+void wxStatusBar95::SetFieldsCount(int nFields, const int *widths)

 {
 {

-  wxASSERT( (nFields > 0) && (nFields < 255) );
+    // this is a Windows limitation
+    wxASSERT_MSG( (nFields > 0) && (nFields < 255), _T("too many fields") );

 
 

-  m_nFields = nFields;
+    wxStatusBarBase::SetFieldsCount(nFields, widths);

 
 

-  CopyFieldsWidth(widths);
-  SetFieldsWidth();
+    SetFieldsWidth();

 }
 
 void wxStatusBar95::SetStatusWidths(int n, const int widths[])
 {
 }
 
 void wxStatusBar95::SetStatusWidths(int n, const int widths[])
 {

-  // @@ I don't understand what this function is for...
-  wxASSERT( n == m_nFields );
+    wxStatusBarBase::SetStatusWidths(n, widths);

 
 

-  CopyFieldsWidth(widths);
-  SetFieldsWidth();
+    SetFieldsWidth();

 }
 
 void wxStatusBar95::SetFieldsWidth()
 {
 }
 
 void wxStatusBar95::SetFieldsWidth()
 {

-  int *pWidths = new int[m_nFields];
-
-  int nWindowWidth, y;
-  GetClientSize(&nWindowWidth, &y);
-
-  if ( m_statusWidths == NULL ) {
-    // default: all fields have the same width
-    int nWidth = nWindowWidth / m_nFields;
-    for ( int i = 0; i < m_nFields; i++ )
-      pWidths[i] = (i + 1) * nWidth;
-  }
-  else {
-    // -1 doesn't mean the same thing for wxWindows and Win32, recalc
-    int nTotalWidth = 0, 
-        nVarCount = 0, 
-        i;
-    for ( i = 0; i < m_nFields; i++ ) {
-      if ( m_statusWidths[i] == -1 )
-        nVarCount++;
-      else
-        nTotalWidth += m_statusWidths[i];
-    }
+    if ( !m_nFields )
+        return;

 
 

-    if ( nVarCount == 0 ) {
-      // wrong! at least one field must be of variable width
-      wxFAIL;
+    int aBorders[3];
+    SendMessage(GetHwnd(), SB_GETBORDERS, 0, (LPARAM)aBorders);

 
 

-      nVarCount++;
-    }
+    int extraWidth = aBorders[2]; // space between fields
+
+    wxArrayInt widthsAbs =
+        CalculateAbsWidths(GetClientSize().x - extraWidth*(m_nFields - 1));

 
 

-    int nVarWidth = (nWindowWidth - nTotalWidth) / nVarCount;
+    int *pWidths = new int[m_nFields];

 
 

-    // do fill the array

     int nCurPos = 0;
     int nCurPos = 0;

-    for ( i = 0; i < m_nFields; i++ ) {
-      if ( m_statusWidths[i] == -1 )
-        nCurPos += nVarWidth;
-      else
-        nCurPos += m_statusWidths[i];
-      pWidths[i] = nCurPos;
+    for ( int i = 0; i < m_nFields; i++ ) {
+        nCurPos += widthsAbs[i] + extraWidth;
+        pWidths[i] = nCurPos;

     }
     }

-  }

 
 

-  if ( !StatusBar_SetParts(hwnd, m_nFields, pWidths) ) {
-    wxLogDebug("StatusBar_SetParts failed.");
-  }
+    if ( !StatusBar_SetParts(GetHwnd(), m_nFields, pWidths) ) {
+        wxLogLastError(wxT("StatusBar_SetParts"));
+    }

 
 

-  delete [] pWidths;
+    delete [] pWidths;

 }
 
 void wxStatusBar95::SetStatusText(const wxString& strText, int nField)
 {
 }
 
 void wxStatusBar95::SetStatusText(const wxString& strText, int nField)
 {

-  if ( !StatusBar_SetText(hwnd, nField, strText) ) {
-    wxLogDebug("StatusBar_SetText failed");
-  }
+    wxCHECK_RET( (nField >= 0) && (nField < m_nFields),
+                 _T("invalid statusbar field index") );
+
+    if ( !StatusBar_SetText(GetHwnd(), nField, strText) )
+    {
+        wxLogLastError(wxT("StatusBar_SetText"));
+    }

 }
 
 wxString wxStatusBar95::GetStatusText(int nField) const
 {
 }
 
 wxString wxStatusBar95::GetStatusText(int nField) const
 {

-  wxASSERT( (nField > -1) && (nField < m_nFields) );
-
-  wxString str("");
-  int len = StatusBar_GetTextLen(hwnd, nField);
-  if (len > 0)
-  {
-        StatusBar_GetText(hwnd, nField, str.GetWriteBuf(len));
+    wxCHECK_MSG( (nField >= 0) && (nField < m_nFields), wxEmptyString,
+                 _T("invalid statusbar field index") );
+
+    wxString str;
+    int len = StatusBar_GetTextLen(GetHwnd(), nField);
+    if ( len > 0 )
+    {
+        StatusBar_GetText(GetHwnd(), nField, str.GetWriteBuf(len));

         str.UngetWriteBuf();
         str.UngetWriteBuf();

-  }
-  return str;
+    }
+
+    return str;

 }
 
 }
 

-void wxStatusBar95::OnSize(wxSizeEvent& event)
+int wxStatusBar95::GetBorderX() const

 {
 {

-  FORWARD_WM_SIZE(hwnd, SIZE_RESTORED, event.GetSize().x, event.GetSize().y,
-                  SendMessage);
+    int aBorders[3];
+    SendMessage(GetHwnd(), SB_GETBORDERS, 0, (LPARAM)aBorders);

 
 

-  // adjust fields widths to the new size
-  SetFieldsWidth();
+    return aBorders[0];
+}
+
+int wxStatusBar95::GetBorderY() const
+{
+    int aBorders[3];
+    SendMessage(GetHwnd(), SB_GETBORDERS, 0, (LPARAM)aBorders);
+
+    return aBorders[1];
+}
+
+void wxStatusBar95::SetMinHeight(int height)
+{
+    SendMessage(GetHwnd(), SB_SETMINHEIGHT, height + 2*GetBorderY(), 0);
+
+    // have to send a (dummy) WM_SIZE to redraw it now
+    SendMessage(GetHwnd(), WM_SIZE, 0, 0);
+}
+
+bool wxStatusBar95::GetFieldRect(int i, wxRect& rect) const
+{
+    wxCHECK_MSG( (i >= 0) && (i < m_nFields), FALSE,
+                 _T("invalid statusbar field index") );
+
+    RECT r;
+    if ( !::SendMessage(GetHwnd(), SB_GETRECT, i, (LPARAM)&r) )
+    {
+        wxLogLastError(wxT("SendMessage(SB_GETRECT)"));
+    }
+
+    wxCopyRECTToRect(r, rect);
+
+    return TRUE;
+}
+
+void wxStatusBar95::DoMoveWindow(int x, int y, int width, int height)
+{
+    // the status bar wnd proc must be forwarded the WM_SIZE message whenever
+    // the stat bar position/size is changed because it normally positions the
+    // control itself along bottom or top side of the parent window - failing
+    // to do so will result in nasty visual effects
+    FORWARD_WM_SIZE(GetHwnd(), SIZE_RESTORED, x, y, SendMessage);
+
+    // but now, when the standard status bar wnd proc did all it wanted to do,
+    // move the status bar to its correct location - usually this call may be
+    // omitted because for normal status bars (positioned along the bottom
+    // edge) the position is already set correctly, but if the user wants to
+    // position them in some exotic location, this is really needed
+    wxWindow::DoMoveWindow(x, y, width, height);
+
+    // adjust fields widths to the new size
+    SetFieldsWidth();
+
+    // we have to trigger wxSizeEvent if there are children window in status 
+    // bar because GetFieldRect returned incorrect (not updated) values up to
+    // here, which almost certainly resulted in incorrectly redrawn statusbar
+    if ( m_children.GetCount() > 0 )
+    {
+        wxSizeEvent event(GetClientSize(), m_windowId);
+        event.SetEventObject(this);
+        GetEventHandler()->ProcessEvent(event);
+    }

 }
 
 }
 

-#endif  // wxUSE_NATIVE_STATUSBAR
+#endif // __WIN95__ && wxUSE_NATIVE_STATUSBAR

 
 

-#else
-    #error "wxStatusBar95 is only available under Windows 95 and later."
-#endif // __WIN95__
-