compilation fix for gcc (closes bug 996701)

[wxWidgets.git] / contrib / src / ogl / divided.cpp

diff --git a/contrib/src/ogl/divided.cpp b/contrib/src/ogl/divided.cpp
index cb1de4fbaa2a182f78ba925b4f66131bf35dcb0b..d8ced84d431805d6b1e8dbda73ca28eddb1393e5 100644 (file)
--- a/contrib/src/ogl/divided.cpp
+++ b/contrib/src/ogl/divided.cpp
@@ -6,7 +6,7 @@
 // Created:     12/07/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart
 // Created:     12/07/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__


@@ -24,14 +24,12 @@
 #include <wx/wx.h>
 #endif
 
 #include <wx/wx.h>
 #endif
 

-#include <wx/wxexpr.h>
+#if wxUSE_PROLOGIO
+#include <wx/deprecated/wxexpr.h>
+#endif
+
+#include "wx/ogl/ogl.h"

 
 

-#include <wx/ogl/basic.h>
-#include <wx/ogl/basicp.h>
-#include <wx/ogl/canvas.h>
-#include <wx/ogl/divided.h>
-#include <wx/ogl/lines.h>
-#include <wx/ogl/misc.h>

 
 class wxDividedShapeControlPoint: public wxControlPoint
 {
 
 class wxDividedShapeControlPoint: public wxControlPoint
 {


@@ -83,7 +81,7 @@ void wxDividedShape::OnDrawContents(wxDC& dc)
 
   if (m_pen) dc.SetPen(* m_pen);
 
 
   if (m_pen) dc.SetPen(* m_pen);
 

-  if (m_textColour) dc.SetTextForeground(* m_textColour);
+  dc.SetTextForeground(m_textColour);

 
 #ifdef __WXMSW__
   // For efficiency, don't do this under X - doesn't make
 
 #ifdef __WXMSW__
   // For efficiency, don't do this under X - doesn't make


@@ -95,7 +93,7 @@ void wxDividedShape::OnDrawContents(wxDC& dc)
   if (!formatted)
   {
     FormatRegionText();
   if (!formatted)
   {
     FormatRegionText();

-    formatted = TRUE;
+    formatted = true;

   }
 */
   if (GetDisableLabel()) return;
   }
 */
   if (GetDisableLabel()) return;


@@ -109,7 +107,7 @@ void wxDividedShape::OnDrawContents(wxDC& dc)
   {
     wxShapeRegion *region = (wxShapeRegion *)node->GetData();
     dc.SetFont(* region->GetFont());
   {
     wxShapeRegion *region = (wxShapeRegion *)node->GetData();
     dc.SetFont(* region->GetFont());

-    dc.SetTextForeground(* region->GetActualColourObject());
+    dc.SetTextForeground(region->GetActualColourObject());

 
     double proportion =
       region->m_regionProportionY < 0.0 ? defaultProportion : region->m_regionProportionY;
 
     double proportion =
       region->m_regionProportionY < 0.0 ? defaultProportion : region->m_regionProportionY;


@@ -139,7 +137,7 @@ void wxDividedShape::OnDrawContents(wxDC& dc)
   }
 }
 
   }
 }
 

-void wxDividedShape::SetSize(double w, double h, bool recursive)
+void wxDividedShape::SetSize(double w, double h, bool WXUNUSED(recursive))

 {
   SetAttachmentSize(w, h);
   m_width = w;
 {
   SetAttachmentSize(w, h);
   m_width = w;


@@ -245,18 +243,8 @@ bool wxDividedShape::GetAttachmentPosition(int attachment, double *x, double *y,
   // Left or right.
   else
   {
   // Left or right.
   else
   {

-    int i = 0;
-    bool isLeft = FALSE;
-    if (attachment < (n+1))
-    {
-      i = attachment-1;
-      isLeft = FALSE;
-    }
-    else
-    {
-      i = (totalNumberAttachments - attachment - 1);
-      isLeft = TRUE;
-    }
+    bool isLeft = !(attachment < (n+1));
+    int i = (isLeft) ? (totalNumberAttachments - attachment - 1) : (attachment-1);

     wxNode *node = GetRegions().Item(i);
     if (node)
     {
     wxNode *node = GetRegions().Item(i);
     if (node)
     {


@@ -297,10 +285,10 @@ bool wxDividedShape::GetAttachmentPosition(int attachment, double *x, double *y,
     {
       *x = m_xpos;
       *y = m_ypos;
     {
       *x = m_xpos;
       *y = m_ypos;

-      return FALSE;
+      return false;

     }
   }
     }
   }

-  return TRUE;
+  return true;

 }
 
 int wxDividedShape::GetNumberOfAttachments() const
 }
 
 int wxDividedShape::GetNumberOfAttachments() const


@@ -321,7 +309,7 @@ int wxDividedShape::GetNumberOfAttachments() const
   return maxN + 1;
 }
 
   return maxN + 1;
 }
 

-bool wxDividedShape::AttachmentIsValid(int attachment)
+bool wxDividedShape::AttachmentIsValid(int attachment) const

 {
   int totalNumberAttachments = (GetRegions().GetCount() * 2) + 2;
   if (attachment >= totalNumberAttachments)
 {
   int totalNumberAttachments = (GetRegions().GetCount() * 2) + 2;
   if (attachment >= totalNumberAttachments)


@@ -329,9 +317,9 @@ bool wxDividedShape::AttachmentIsValid(int attachment)
     return wxShape::AttachmentIsValid(attachment);
   }
   else if (attachment >= 0)
     return wxShape::AttachmentIsValid(attachment);
   }
   else if (attachment >= 0)

-    return TRUE;
+    return true;

   else
   else

-    return FALSE;
+    return false;

 }
 
 void wxDividedShape::Copy(wxShape& copy)
 }
 
 void wxDividedShape::Copy(wxShape& copy)


@@ -536,7 +524,7 @@ void wxDividedShape::EditRegions()
 
   wxEndBusyCursor();
 
 
   wxEndBusyCursor();
 

-  dialog->Show(TRUE);
+  dialog->Show(true);

 
   node = GetRegions().GetFirst();
   i = 0;
 
   node = GetRegions().GetFirst();
   i = 0;


@@ -591,7 +579,7 @@ wxDividedShapeControlPoint::~wxDividedShapeControlPoint()
 }
 
 // Implement resizing of divided object division
 }
 
 // Implement resizing of divided object division

-void wxDividedShapeControlPoint::OnDragLeft(bool draw, double x, double y, int keys, int attachment)
+void wxDividedShapeControlPoint::OnDragLeft(bool WXUNUSED(draw), double WXUNUSED(x), double y, int WXUNUSED(keys), int WXUNUSED(attachment))

 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);
 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);


@@ -609,7 +597,7 @@ void wxDividedShapeControlPoint::OnDragLeft(bool draw, double x, double y, int k
     dc.DrawLine(WXROUND(x1), WXROUND(y1), WXROUND(x2), WXROUND(y2));
 }
 
     dc.DrawLine(WXROUND(x1), WXROUND(y1), WXROUND(x2), WXROUND(y2));
 }
 

-void wxDividedShapeControlPoint::OnBeginDragLeft(double x, double y, int keys, int attachment)
+void wxDividedShapeControlPoint::OnBeginDragLeft(double WXUNUSED(x), double y, int WXUNUSED(keys), int WXUNUSED(attachment))

 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);
 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);


@@ -628,7 +616,7 @@ void wxDividedShapeControlPoint::OnBeginDragLeft(double x, double y, int keys, i
     m_canvas->CaptureMouse();
 }
 
     m_canvas->CaptureMouse();
 }
 

-void wxDividedShapeControlPoint::OnEndDragLeft(double x, double y, int keys, int attachment)
+void wxDividedShapeControlPoint::OnEndDragLeft(double WXUNUSED(x), double y, int WXUNUSED(keys), int WXUNUSED(attachment))

 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);
 {
     wxClientDC dc(GetCanvas());
     GetCanvas()->PrepareDC(dc);


@@ -654,7 +642,10 @@ void wxDividedShapeControlPoint::OnEndDragLeft(double x, double y, int keys, int
 
     // Save values
     double thisRegionTop = 0.0;
 
     // Save values
     double thisRegionTop = 0.0;

+    #if 0
+    // this variable is not readed later

     double thisRegionBottom = 0.0;
     double thisRegionBottom = 0.0;

+    #endif

     double nextRegionBottom = 0.0;
 
     node = dividedObject->GetRegions().GetFirst();
     double nextRegionBottom = 0.0;
 
     node = dividedObject->GetRegions().GetFirst();


@@ -669,7 +660,10 @@ void wxDividedShapeControlPoint::OnEndDragLeft(double x, double y, int keys, int
       if (region == thisRegion)
       {
         thisRegionTop = currentY;
       if (region == thisRegion)
       {
         thisRegionTop = currentY;

+        #if 0
+        // no need for assignment if value is not used later

         thisRegionBottom = actualY;
         thisRegionBottom = actualY;

+        #endif

         if (node->GetNext())
           nextRegion = (wxShapeRegion *)node->GetNext()->GetData();
       }
         if (node->GetNext())
           nextRegion = (wxShapeRegion *)node->GetNext()->GetData();
       }


@@ -706,9 +700,8 @@ void wxDividedShapeControlPoint::OnEndDragLeft(double x, double y, int keys, int
         wxShapeRegion *region = (wxShapeRegion *)node->GetData();
         if (region->GetText())
         {
         wxShapeRegion *region = (wxShapeRegion *)node->GetData();
         if (region->GetText())
         {

-        wxChar *s = copystring(region->GetText());
-        dividedObject->FormatText(dc, s, i);
-        delete[] s;
+        wxString s(region->GetText());
+        dividedObject->FormatText(dc, s.c_str(), i);

         }
         node = node->GetNext();
         i++;
         }
         node = node->GetNext();
         i++;